Re: [PULL v3 15/32] vfio: Add ioctl to get dirty pages bitmap during dma unmap

2020-12-15 Thread zhukeqian
Hi Kirti, On 2020/11/2 5:01, Alex Williamson wrote: > From: Kirti Wankhede > > With vIOMMU, IO virtual address range can get unmapped while in pre-copy > phase of migration. In that case, unmap ioctl should return pages pinned > in that range and QEMU should find its correcponding guest physical

[PATCH] build-sys: fix -static linking of libvhost-user

2020-12-15 Thread marcandre . lureau
From: Marc-André Lureau Fix linking vhost-user binaries with with ./configure -static, by overriding glib-2.0 dependency with configure results. Fixes: 0df750e9d3a5fea5e1 ("libvhost-user: make it a meson subproject") Reported-by: Peter Maydell Signed-off-by: Marc-André Lureau --- meson.build

Re: [PATCH 1/2] audio: remove qemu_spice_audio_init()

2020-12-15 Thread Gerd Hoffmann
> > +if (using_spice) { > > +/* > > + * When using spice allow the spice audio driver being picked > > + * as default. > > + * > > + * Temporary hack. Using audio devices without explicit > > + * audiodev= property is already deprecated. Same go

[PATCH] audio: add sanity check

2020-12-15 Thread Gerd Hoffmann
Check whenever we actually found the spiceaudio driver before flipping the can_be_default field. Fixes: f0c4555edfdd ("audio: remove qemu_spice_audio_init()") Buglink: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=977301 Reported-by: dann frazier Signed-off-by: Gerd Hoffmann --- audio/audio

Re: [PATCH 1/4] coreaudio: rename misnamed variable fake_as

2020-12-15 Thread Gerd Hoffmann
On Sun, Dec 13, 2020 at 02:05:25PM +0100, Volker Rümelin wrote: > While the variable once was used to fake audio settings, since > commit ed2a4a7941 "audio: proper support for float samples in > mixeng" this is no longer true. Rename the variable to obt_as. > This is the same naming scheme as in a

Re: [PULL v3 11/32] vfio: Get migration capability flags for container

2020-12-15 Thread zhukeqian
Hi Kirti, On 2020/11/2 5:00, Alex Williamson wrote: > From: Kirti Wankhede > > Added helper functions to get IOMMU info capability chain. > Added function to get migration capability information from that > capability chain for IOMMU container. > > Similar change was proposed earlier: > https:/

Re: [PATCH v4 01/32] cs4231: Get rid of empty property array

2020-12-15 Thread Gerd Hoffmann
On Fri, Dec 11, 2020 at 05:04:58PM -0500, Eduardo Habkost wrote: > An empty props array is unnecessary, we can just not call > device_class_set_props(). > > Reviewed-by: Marc-André Lureau > Signed-off-by: Eduardo Habkost > --- > Cc: Gerd Hoffmann > Cc: qemu-devel@nongnu.org Patch added to aud

Re: [PATCH] audio: Simplify audio_bug() removing old code

2020-12-15 Thread Gerd Hoffmann
On Thu, Dec 10, 2020 at 11:35:06PM +0100, Philippe Mathieu-Daudé wrote: > This code (introduced in commit 1d14ffa97ea, Oct 2005) > is likely unused since years. Time to remove it. If > the condition is true, simply call abort(). > > Suggested-by: Gerd Hoffmann > Signed-off-by: Philippe Mathieu-

Re: [PATCH 1/1] virtio-blk-ccw: tweak the default for num_queues

2020-12-15 Thread Cornelia Huck
On Tue, 10 Nov 2020 14:18:39 +0100 Christian Borntraeger wrote: > On 10.11.20 11:40, Halil Pasic wrote: > > On Tue, 10 Nov 2020 09:47:51 +0100 > > Christian Borntraeger wrote: > > > >> > >> > >> On 09.11.20 19:53, Halil Pasic wrote: > >>> On Mon, 9 Nov 2020 17:06:16 +0100 > >>> Cornelia Huc

[PATCH] tests/docker: Remove the remainders of debian9 containers from the Makefile

2020-12-15 Thread Thomas Huth
The Debian 9 containers have been removed a while ago, so we can delete the corresponding entries in the Makefile, too. Fixes: e3755276d1 ("tests/docker: Remove old Debian 9 containers") Signed-off-by: Thomas Huth --- tests/docker/Makefile.include | 6 +- 1 file changed, 1 insertion(+), 5 de

[PATCH v2] gitlab-CI: Test 32-bit builds with the fedora-i386-cross container

2020-12-15 Thread Thomas Huth
After adding some missing packages, it's possible to check 32-bit builds and tests with the fedora-i386-cross container in the gitlab-CI, too. Unfortunately, the code in subprojects/ ignores the --extra-cflags (on purpose), so the vhost-user part has to be disabled for this. While we're at it, upd

Re: [PATCH v5 3/4] hmp: Use QMP query-netdev in hmp_info_network

2020-12-15 Thread Markus Armbruster
Jason Wang writes: [...] > One more stupid question, instead of generating the string via hard > codes, is there any method (dict?) to iterate all the key/values > automatically? QAPI visitors. The lazy way: use the QObject output visitor to convert the QAPI type (here: NetdevInfo) to QObject,

Re: [PATCH] iotests/210: Fix reference output

2020-12-15 Thread Vladimir Sementsov-Ogievskiy
14.12.2020 20:51, Max Reitz wrote: Commit 8b1170012b1 has added a global maximum disk length for the block layer, so the error message when creating an overly large disk has changed. Fixes: 8b1170012b1de6649c66ac1887f4df7e312abf3b ("block: introduce BDRV_MAX_LENGTH") Signed-off-by: Max R

Re: [PATCH v3 01/15] hw/riscv: Expand the is 32-bit check to support more CPUs

2020-12-15 Thread Bin Meng
On Tue, Dec 15, 2020 at 4:34 AM Alistair Francis wrote: > > Currently the riscv_is_32_bit() function only supports the generic rv32 > CPUs. Extend the function to support the SiFive and LowRISC CPUs as > well. > > Signed-off-by: Alistair Francis > --- > hw/riscv/boot.c | 12 +++- > 1 fil

Re: [PATCH v3 09/15] target/riscv: fpu_helper: Match function defs in HELPER macros

2020-12-15 Thread Bin Meng
Hi Alistair, On Tue, Dec 15, 2020 at 4:34 AM Alistair Francis wrote: > > The helper functions defined in helper.h specify that the argument is of I can't find the helper.h that declare these functions? > type target_long. Let's change the implementation to match the header > definition. > > Sig

Re: [RFC PATCH] .cirrus.yml: bump timeout period for MacOS builds

2020-12-15 Thread Daniel P . Berrangé
On Mon, Dec 14, 2020 at 10:33:09AM +0100, Thomas Huth wrote: > On 14/12/2020 10.24, Alex Bennée wrote: > > > > 罗勇刚(Yonggang Luo) writes: > > > >> On Mon, Dec 14, 2020 at 2:36 AM Philippe Mathieu-Daudé > >> wrote: > >>> > >>> On Wed, Nov 18, 2020 at 4:11 PM Thomas Huth wrote: > On 18/11/20

Re: [PATCH] ui: add support for remote power control to VNC server

2020-12-15 Thread Daniel P . Berrangé
On Mon, Dec 14, 2020 at 12:05:07PM +0100, Gerd Hoffmann wrote: > On Fri, Dec 11, 2020 at 04:08:25PM +, Daniel P. Berrangé wrote: > > The "XVP" (Xen VNC Proxy) extension defines a mechanism for a VNC client > > to issue power control requests to trigger graceful shutdown, reboot, or > > hard res

Re: [RFC PATCH 1/2] gitlab-ci: Step in to maintain the fedora-i386-cross runner

2020-12-15 Thread Daniel P . Berrangé
On Mon, Dec 14, 2020 at 06:52:31PM +0100, Philippe Mathieu-Daudé wrote: > On 12/14/20 1:35 PM, Thomas Huth wrote: > > On 11/12/2020 18.17, Philippe Mathieu-Daudé wrote: > >> As I am interested in using the runner based on the fedora-i386-cross > >> docker image, add a smoke test job to be sure this

Re: [PATCH 0/3] qemu-timer: Make timer_free() imply timer_del()

2020-12-15 Thread Paolo Bonzini
On 14/12/20 21:30, Peter Maydell wrote: Currently timer_free() is a simple wrapper for g_free(). This means that the timer being freed must not be currently active, as otherwise QEMU might crash later when the active list is processed and still has a pointer to freed memory on it. As a result a

Re: [PATCH v4] file-posix: detect the lock using the real file

2020-12-15 Thread Daniel P . Berrangé
On Tue, Dec 15, 2020 at 03:09:28PM +0800, Li Feng wrote: > This patch addresses this issue: > When accessing a volume on an NFS filesystem without supporting the file lock, > tools, like qemu-img, will complain "Failed to lock byte 100". > > In the original code, the qemu_has_ofd_lock will test th

Re: [PATCH] build-sys: fix -static linking of libvhost-user

2020-12-15 Thread Paolo Bonzini
On 15/12/20 09:03, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Fix linking vhost-user binaries with with ./configure -static, by overriding glib-2.0 dependency with configure results. Fixes: 0df750e9d3a5fea5e1 ("libvhost-user: make it a meson subproject") Reported-by: Peter Mayd

Re: [PATCH v2 8/9] vnc: add support for extended desktop resize

2020-12-15 Thread Gerd Hoffmann
On Tue, Dec 08, 2020 at 06:13:28PM +, Daniel P. Berrangé wrote: > On Tue, Dec 08, 2020 at 12:57:36PM +0100, Gerd Hoffmann wrote: > > The extended desktop resize encoding adds support for (a) clients > > sending resize requests to the server, and (b) multihead support. > > > > This patch imple

Re: [PATCH v2 8/9] vnc: add support for extended desktop resize

2020-12-15 Thread Daniel P . Berrangé
On Tue, Dec 15, 2020 at 11:15:03AM +0100, Gerd Hoffmann wrote: > On Tue, Dec 08, 2020 at 06:13:28PM +, Daniel P. Berrangé wrote: > > On Tue, Dec 08, 2020 at 12:57:36PM +0100, Gerd Hoffmann wrote: > > > The extended desktop resize encoding adds support for (a) clients > > > sending resize reques

Re: [PATCH V17 4/6] hw/mips: Add Loongson-3 boot parameter helpers

2020-12-15 Thread Philippe Mathieu-Daudé
Le mar. 15 déc. 2020 06:34, Huacai Chen a écrit : > Hi, Philippe, > > On Mon, Dec 14, 2020 at 9:49 PM Philippe Mathieu-Daudé > wrote: > > > > On 12/14/20 3:37 AM, Huacai Chen wrote: > > > Hi, Philippe, > > > > > > On Mon, Dec 14, 2020 at 7:09 AM Philippe Mathieu-Daudé < > f4...@amsat.org> wrote:

Re: [PATCH v1 1/1] intc/arm_gic: Fix gic_irq_signaling_enabled() for vCPUs

2020-12-15 Thread Luc Michel
On 12/14/20 11:21 PM, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Correct the indexing into s->cpu_ctlr for vCPUs. Signed-off-by: Edgar E. Iglesias Hi Edgar, Nice catch! Thanks. Reviewed-by: Luc Michel -- Luc --- hw/intc/arm_gic.c | 4 +++- 1 file changed, 3 insertions(+), 1

Re: [PATCH v13 00/19] Initial support for multi-process Qemu

2020-12-15 Thread Stefan Hajnoczi
On Mon, Dec 14, 2020 at 12:14:40AM -0500, Jagannathan Raman wrote: > Hello, > > This is the v13 of the patchset. Thank you very much for reviewing v12 and > sharing your feedback. As mentioned on IRC, please add a ./configure option so package maintainers can easily disable multi-process QEMU wit

Re: [PATCH v13 10/19] multi-process: Associate fd of a PCIDevice with its object

2020-12-15 Thread Stefan Hajnoczi
On Mon, Dec 14, 2020 at 12:14:50AM -0500, Jagannathan Raman wrote: > +static void remote_object_release(DeviceListener *listener, DeviceState *dev) > +{ > +RemoteObject *o = container_of(listener, RemoteObject, listener); > + > +if (o->dev == dev) { > +object_unref(OBJECT(o)); > +

Re: [PATCH v13 00/19] Initial support for multi-process Qemu

2020-12-15 Thread Stefan Hajnoczi
On Mon, Dec 14, 2020 at 12:14:40AM -0500, Jagannathan Raman wrote: > This is the v13 of the patchset. Thank you very much for reviewing v12 and > sharing your feedback. > > We have addressed all the comments from the v12 review except for the > following two items, which we will be addressing in s

Re: [PATCH v13 07/19] multi-process: add qio channel function to transmit data and fds

2020-12-15 Thread Marc-André Lureau
Hi On Mon, Dec 14, 2020 at 9:15 AM Jagannathan Raman wrote: > From: Elena Ufimtseva > > Adds QIO channel functions that transmit and receive iovs along with fds. > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > Reviewed-by: Stefan Hajnoc

Re: [PATCH v4] file-posix: detect the lock using the real file

2020-12-15 Thread Li Feng
Daniel P. Berrangé 于2020年12月15日周二 下午6:08写道: > > On Tue, Dec 15, 2020 at 03:09:28PM +0800, Li Feng wrote: > > This patch addresses this issue: > > When accessing a volume on an NFS filesystem without supporting the file > > lock, > > tools, like qemu-img, will complain "Failed to lock byte 100". >

[PATCH v5] file-posix: detect the lock using the real file

2020-12-15 Thread Li Feng
This patch addresses this issue: When accessing a volume on an NFS filesystem without supporting the file lock, tools, like qemu-img, will complain "Failed to lock byte 100". In the original code, the qemu_has_ofd_lock will test the lock on the "/dev/null" pseudo-file. Actually, the file.locking i

Re: [PATCH v5] file-posix: detect the lock using the real file

2020-12-15 Thread Daniel P . Berrangé
On Tue, Dec 15, 2020 at 06:53:56PM +0800, Li Feng wrote: > This patch addresses this issue: > When accessing a volume on an NFS filesystem without supporting the file lock, > tools, like qemu-img, will complain "Failed to lock byte 100". > > In the original code, the qemu_has_ofd_lock will test th

Re: [PATCH] iotests/210: Fix reference output

2020-12-15 Thread Kevin Wolf
Am 14.12.2020 um 18:51 hat Max Reitz geschrieben: > Commit 8b1170012b1 has added a global maximum disk length for the block > layer, so the error message when creating an overly large disk has > changed. > > Fixes: 8b1170012b1de6649c66ac1887f4df7e312abf3b >("block: introduce BDRV_MAX_LENGT

Re: [PATCH 1/2] accel: kvm: Fix memory waste under mismatch page size

2020-12-15 Thread Andrew Jones
On Tue, Dec 15, 2020 at 03:19:47PM +0800, Keqian Zhu wrote: > When handle dirty log, we face qemu_real_host_page_size and > TARGET_PAGE_SIZE. The first one is the granule of KVM dirty > bitmap, and the second one is the granule of QEMU dirty bitmap. > > Generally speaking, qemu_real_host_page_size

Re: [PATCH 1/7] allwinner-a10-pit: Use ptimer_free() in the finalize function to avoid memleaks

2020-12-15 Thread Peter Maydell
On Tue, 15 Dec 2020 at 02:38, ganqixin wrote: > > > -Original Message- > > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > > Sent: Tuesday, December 15, 2020 12:20 AM > > To: ganqixin > > Cc: qemu-arm ; QEMU Developers > > ; Chenqun (kuhn) > > ; Zhanghailiang > > ; Euler Robot > >

Re: [PATCH 1/1] virtio-blk-ccw: tweak the default for num_queues

2020-12-15 Thread Halil Pasic
On Tue, 15 Dec 2020 09:26:56 +0100 Cornelia Huck wrote: > On Tue, 10 Nov 2020 14:18:39 +0100 > Christian Borntraeger wrote: > > > On 10.11.20 11:40, Halil Pasic wrote: > > > On Tue, 10 Nov 2020 09:47:51 +0100 > > > Christian Borntraeger wrote: > > > > > >> > > >> > > >> On 09.11.20 19:53, H

Re: [PATCH 0/3] qemu-timer: Make timer_free() imply timer_del()

2020-12-15 Thread Peter Maydell
On Tue, 15 Dec 2020 at 10:07, Paolo Bonzini wrote: > > On 14/12/20 21:30, Peter Maydell wrote: > > Currently timer_free() is a simple wrapper for g_free(). This means > > that the timer being freed must not be currently active, as otherwise > > QEMU might crash later when the active list is proce

Re: [PATCH] iotests: Quote $cmd in _send_qemu_cmd

2020-12-15 Thread Kevin Wolf
Am 14.12.2020 um 18:58 hat Max Reitz geschrieben: > With bash 5.1, the output of the following script (which creates an > array with a single element, then takes a single-element slice from that > array, and echos the result) changes: > > a=("double space") > a=${a[@]:0:1} > echo "$a" > >

Re: [PATCH v4 05/32] sparc: Check dev->realized at sparc_set_nwindows()

2020-12-15 Thread Mark Cave-Ayland
On 11/12/2020 22:05, Eduardo Habkost wrote: sparc_set_nwindows() is one of the very few property setters that don't check dev->realized, and there's no reason for it to be special. Check dev->realized like the other setters. Reviewed-by: Marc-André Lureau Signed-off-by: Eduardo Habkost --- C

Re: [PATCH 1/3] util/qemu-timer: Make timer_free() imply timer_del()

2020-12-15 Thread Peter Maydell
On Mon, 14 Dec 2020 at 20:30, Peter Maydell wrote: > > Currently timer_free() is a simple wrapper for g_free(). This means > that the timer being freed must not be currently active, as otherwise > QEMU might crash later when the active list is processed and still > has a pointer to freed memory o

Re: [for-6.0 v5 13/13] s390: Recognize securable-guest-memory option

2020-12-15 Thread Cornelia Huck
On Fri, 4 Dec 2020 16:44:15 +1100 David Gibson wrote: > At least some s390 cpu models support "Protected Virtualization" (PV), > a mechanism to protect guests from eavesdropping by a compromised > hypervisor. > > This is similar in function to other mechanisms like AMD's SEV and > POWER's PEF,

[PATCH v2 3/5] target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h

2020-12-15 Thread Leif Lindholm
Signed-off-by: Leif Lindholm --- target/arm/cpu.h | 24 1 file changed, 24 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index fadd1a47df..90ba707b64 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -1736,6 +1736,30 @@ FIELD(V7M_FPCCR, ASPEN, 31,

[PATCH v2 0/5] target/arm: various changes to cpu.h

2020-12-15 Thread Leif Lindholm
First, fix a typo in ID_AA64PFR1 (SBSS -> SSBS). Second, turn clidr in the ARMCPU struct 64-bit, to support all fields defined by the ARM ARM. Third, add field definitions for CLIDR (excepting the Ttype fields, since I was unsure of prefererred naming - Ttype7-Ttype1?). Fourth add all ID_AA64 re

[PATCH v2 5/5] target/arm: add aarch32 ID register fields to cpu.h

2020-12-15 Thread Leif Lindholm
Add entries present in ARM DDI 0487F.c (August 2020). Signed-off-by: Leif Lindholm --- target/arm/cpu.h | 28 1 file changed, 28 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index efa977eaca..fb81eed776 100644 --- a/target/arm/cpu.h +++ b/target/ar

[PATCH v2 2/5] target/arm: make ARMCPU.clidr 64-bit

2020-12-15 Thread Leif Lindholm
The AArch64 view of CLIDR_EL1 extends the ICB field to include also bit 32, as well as adding a Ttype field when FEAT_MTE is implemented. Extend the clidr field to be able to hold this context. Signed-off-by: Leif Lindholm --- target/arm/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[PATCH v2 4/5] target/arm: add aarch64 ID register fields to cpu.h

2020-12-15 Thread Leif Lindholm
Add entries present in ARM DDI 0487F.c (August 2020). Signed-off-by: Leif Lindholm --- target/arm/cpu.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 90ba707b64..efa977eaca 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -1

Re: [PATCH v4 17/32] sparc: Use DEFINE_PROP for nwindows property

2020-12-15 Thread Mark Cave-Ayland
On 11/12/2020 22:05, Eduardo Habkost wrote: Use the DEFINE_PROP macro (which will set extra fields in the struct) instead of initializing a Property struct manually. Signed-off-by: Eduardo Habkost --- This is a new patch added in v2 of the series --- Cc: Mark Cave-Ayland Cc: Artyom Tarasenko

[PATCH v2 1/5] target/arm: fix typo in cpu.h ID_AA64PFR1 field name

2020-12-15 Thread Leif Lindholm
SBSS -> SSBS Signed-off-by: Leif Lindholm --- target/arm/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 7e6c881a7e..5e3cf77ec7 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -1883,7 +1883,7 @@ FIELD(ID_AA64PFR0, RAS, 2

Re: [PATCH v2 3/5] target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h

2020-12-15 Thread Leif Lindholm
On Mon, Dec 14, 2020 at 13:36:51 +, Peter Maydell wrote: > On Mon, 14 Dec 2020 at 12:36, Leif Lindholm wrote: > > > > Signed-off-by: Leif Lindholm > > --- > > v1->v2: > > - Correct CCSIDR_EL1 field sizes. > > Hi -- could you resend the whole series for a v2, please? > The tools (and people)

Re: [PATCH 1/3] util/qemu-timer: Make timer_free() imply timer_del()

2020-12-15 Thread Paolo Bonzini
On 15/12/20 12:44, Peter Maydell wrote: +static inline void timer_free(QEMUTimer *ts) +{ + +if (ts->expire_time != -1) { +timer_del(ts); +} +g_free(ts); +} I was thinking about this again this morning, and I'm not sure this is thread-safe. It may not be thread-safe in pri

Re: [PATCH 2/2] accel: kvm: Add aligment check for kvm_log_clear_one_slot

2020-12-15 Thread Andrew Jones
On Tue, Dec 15, 2020 at 03:19:48PM +0800, Keqian Zhu wrote: > The parameters start and size are transfered from QEMU memory > emulation layer. It can promise that they are TARGET_PAGE_SIZE > aligned. However, KVM needs they are qemu_real_page_size aligned. > > Though no caller breaks this aligned

Re: [PATCH 1/3] util/qemu-timer: Make timer_free() imply timer_del()

2020-12-15 Thread Peter Maydell
On Tue, 15 Dec 2020 at 11:53, Paolo Bonzini wrote: > > On 15/12/20 12:44, Peter Maydell wrote: > > > >> +static inline void timer_free(QEMUTimer *ts) > >> +{ > >> + > >> +if (ts->expire_time != -1) { > >> +timer_del(ts); > >> +} > >> +g_free(ts); > >> +} > > I was thinking abou

Re: [PATCH v2 1/4] block: Honor blk_set_aio_context() context requirements

2020-12-15 Thread Kevin Wolf
Am 14.12.2020 um 18:05 hat Sergio Lopez geschrieben: > The documentation for bdrv_set_aio_context_ignore() states this: > > * The caller must own the AioContext lock for the old AioContext of bs, but > it > * must not own the AioContext lock for new_context (unless new_context is the > * same

Re: [PULL 00/19] Trivial branch for 6.0 patches

2020-12-15 Thread Peter Maydell
On Mon, 14 Dec 2020 at 16:06, Laurent Vivier wrote: > > The following changes since commit 17584289af1aaa72c932e7e47c25d583b329dc45: > > Merge remote-tracking branch 'remotes/vivier/tags/m68k-for-6.0-pull-request= > ' into staging (2020-12-12 18:33:46 +) > > are available in the Git reposito

Re: [PATCH v2 0/5] target/arm: various changes to cpu.h

2020-12-15 Thread Peter Maydell
On Tue, 15 Dec 2020 at 11:48, Leif Lindholm wrote: > > First, fix a typo in ID_AA64PFR1 (SBSS -> SSBS). > > Second, turn clidr in the ARMCPU struct 64-bit, to support all fields defined > by the ARM ARM. > > Third, add field definitions for CLIDR (excepting the Ttype fields, since > I was unsure o

Re: [PATCH v2 2/4] block: Avoid processing BDS twice in bdrv_set_aio_context_ignore()

2020-12-15 Thread Kevin Wolf
Am 14.12.2020 um 18:05 hat Sergio Lopez geschrieben: > While processing the parents of a BDS, one of the parents may process > the child that's doing the tail recursion, which leads to a BDS being > processed twice. This is especially problematic for the aio_notifiers, > as they might attempt to wo

Re: [PATCH] iotests: Quote $cmd in _send_qemu_cmd

2020-12-15 Thread Max Reitz
On 15.12.20 12:43, Kevin Wolf wrote: Am 14.12.2020 um 18:58 hat Max Reitz geschrieben: With bash 5.1, the output of the following script (which creates an array with a single element, then takes a single-element slice from that array, and echos the result) changes: a=("double space") a=$

Re: [PATCH v2 3/5] target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h

2020-12-15 Thread Laurent Desnogues
Hello, On Tue, Dec 15, 2020 at 12:51 PM Leif Lindholm wrote: > > Signed-off-by: Leif Lindholm > --- > target/arm/cpu.h | 24 > 1 file changed, 24 insertions(+) > > diff --git a/target/arm/cpu.h b/target/arm/cpu.h > index fadd1a47df..90ba707b64 100644 > --- a/target/arm/

Re: [PATCH v2 1/5] target/arm: fix typo in cpu.h ID_AA64PFR1 field name

2020-12-15 Thread Laurent Desnogues
On Tue, Dec 15, 2020 at 12:51 PM Leif Lindholm wrote: > > SBSS -> SSBS > > Signed-off-by: Leif Lindholm Reviewed-by: Laurent Desnogues Thanks, Laurent > --- > target/arm/cpu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/arm/cpu.h b/target/arm/cpu.h > inde

Re: [PATCH v2 4/5] target/arm: add aarch64 ID register fields to cpu.h

2020-12-15 Thread Laurent Desnogues
On Tue, Dec 15, 2020 at 12:51 PM Leif Lindholm wrote: > > Add entries present in ARM DDI 0487F.c (August 2020). > > Signed-off-by: Leif Lindholm Reviewed-by: Laurent Desnogues Thanks, Laurent > --- > target/arm/cpu.h | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/

Re: [PATCH v2 2/5] target/arm: make ARMCPU.clidr 64-bit

2020-12-15 Thread Laurent Desnogues
On Tue, Dec 15, 2020 at 12:52 PM Leif Lindholm wrote: > > The AArch64 view of CLIDR_EL1 extends the ICB field to include also bit > 32, as well as adding a Ttype field when FEAT_MTE is implemented. > Extend the clidr field to be able to hold this context. > > Signed-off-by: Leif Lindholm Reviewe

[PATCH v4 7/7] virtio_blk: Add support for retry on errors

2020-12-15 Thread Jiahui Cen
Insert failed requests into device's list for later retry and handle queued requests to implement retry_request_cb. Signed-off-by: Jiahui Cen Signed-off-by: Ying Fang --- hw/block/virtio-blk.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/hw/block/virt

[PATCH v4 0/7] block: Add retry for werror=/rerror= mechanism

2020-12-15 Thread Jiahui Cen
A VM in the cloud environment may use a virutal disk as the backend storage, and there are usually filesystems on the virtual block device. When backend storage is temporarily down, any I/O issued to the virtual block device will cause an error. For example, an error occurred in ext4 filesystem wou

[PATCH v4 1/7] qapi/block-core: Add retry option for error action

2020-12-15 Thread Jiahui Cen
Add a new error action 'retry' to support retry on errors. Signed-off-by: Jiahui Cen Signed-off-by: Ying Fang --- blockdev.c | 2 ++ qapi/block-core.json | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/blockdev.c b/blockdev.c index 412354b4b6..47c0e6db52 10064

[PATCH v4 5/7] block-backend: Add timeout support for retry

2020-12-15 Thread Jiahui Cen
Retry should only be triggered when timeout is not reached, so let's check timeout before retry. Device should also reset retry_start_time after successful retry. Signed-off-by: Jiahui Cen Signed-off-by: Ying Fang --- block/block-backend.c | 25 +++- include/sysemu/bloc

Re: [PATCH v2 5/5] target/arm: add aarch32 ID register fields to cpu.h

2020-12-15 Thread Laurent Desnogues
On Tue, Dec 15, 2020 at 12:52 PM Leif Lindholm wrote: > > Add entries present in ARM DDI 0487F.c (August 2020). > > Signed-off-by: Leif Lindholm Reviewed-by: Laurent Desnogues Thanks, Laurent > --- > target/arm/cpu.h | 28 > 1 file changed, 28 insertions(+) > >

[PATCH v4 6/7] block: Add error retry param setting

2020-12-15 Thread Jiahui Cen
Add "retry_interval" and "retry_timeout" parameter for drive and device option. These parameter are valid only when werror/rerror=retry. eg. --drive file=image,rerror=retry,retry_interval=1000,retry_timeout=5000 Signed-off-by: Jiahui Cen Signed-off-by: Ying Fang --- block/block-backend.c

[PATCH v4 3/7] block-backend: Add device specific retry callback

2020-12-15 Thread Jiahui Cen
Add retry_request_cb in BlockDevOps to do device specific retry action. Backend's timer would be registered only when the backend is set 'retry' on errors and the device supports retry action. Signed-off-by: Jiahui Cen Signed-off-by: Ying Fang --- block/block-backend.c | 8 in

[PATCH v4 4/7] block-backend: Enable retry action on errors

2020-12-15 Thread Jiahui Cen
Enable retry action when backend's retry timer is available. It would trigger the timer to do device specific retry action. Signed-off-by: Jiahui Cen Signed-off-by: Ying Fang --- block/block-backend.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/block/block-backend.c b/block/block

[PATCH v4 2/7] block-backend: Introduce retry timer

2020-12-15 Thread Jiahui Cen
Add a timer to regularly trigger retry on errors. Signed-off-by: Jiahui Cen Signed-off-by: Ying Fang --- block/block-backend.c | 21 1 file changed, 21 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index ce78d30794..fe775ea298 100644 --- a/block/

[Bug 1908266] [NEW] spice unnecessary forces nographic

2020-12-15 Thread Tom Yan
Public bug reported: When spice is enabled, qemu does not give the graphical window. It should not imply -nographic but only -display none. ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Bug 1908266] Re: spice unnecessary forces nographic

2020-12-15 Thread Tom Yan
More precisely, there should be a way to prevent -vga qxl from being wired to the graphical window. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1908266 Title: spice unnecessary forces nographic

Re: [PATCH v12 0/7] Introduce 'yank' oob qmp command to recover from hanging qemu

2020-12-15 Thread Markus Armbruster
Lukas Straub writes: > Hello Everyone, > So here is v12. > @Marc-André Lureau, We still need an ACK for the chardev patch. Marc-André? Would be good to get this wrapped before Christmas.

Re: [PATCH v2 2/4] block: Avoid processing BDS twice in bdrv_set_aio_context_ignore()

2020-12-15 Thread Sergio Lopez
On Tue, Dec 15, 2020 at 01:12:33PM +0100, Kevin Wolf wrote: > Am 14.12.2020 um 18:05 hat Sergio Lopez geschrieben: > > While processing the parents of a BDS, one of the parents may process > > the child that's doing the tail recursion, which leads to a BDS being > > processed twice. This is especia

Re: [PATCH v3 14/15] target/riscv: csr: Remove compile time XLEN checks

2020-12-15 Thread Bin Meng
On Tue, Dec 15, 2020 at 4:34 AM Alistair Francis wrote: > > Signed-off-by: Alistair Francis > --- > target/riscv/cpu_bits.h | 4 +- > target/riscv/csr.c | 176 +--- > 2 files changed, 92 insertions(+), 88 deletions(-) > > diff --git a/target/riscv/cpu_b

Re: [RFC PATCH] hw/misc/zynq_slcr: Avoid #DIV/0! error

2020-12-15 Thread Peter Maydell
On Thu, 10 Dec 2020 at 14:16, Philippe Mathieu-Daudé wrote: > > Malicious user can set the feedback divisor for the PLLs > to zero, triggering a floating-point exception (SIGFPE). > > As the datasheet [*] is not clear how hardware behaves > when these bits are zeroes, use the maximum divisor > pos

Re: [PATCH v5 0/4] hw/block/m25p80: Numonyx: Fix dummy cycles and check for SPI mode on cmds

2020-12-15 Thread Peter Maydell
On Mon, 16 Nov 2020 at 23:13, Joe Komlodi wrote: > > Changelog: > v4 -> v5 > - 3/4: Simplify logic when changing state and checking mode. > - 3/4: numonyx_get_mode -> numonyx_mode > - 4/4: Reword commit message to include QIO mode. > > v3 -> v4 > - 1/4: Patch changed to change names of registe

Re: [PATCH 1/3] pl031: Use timer_free() in the finalize function to avoid memleaks

2020-12-15 Thread Peter Maydell
On Fri, 4 Dec 2020 at 08:13, Gan Qixin wrote: > > When running device-introspect-test, a memory leak occurred in the pl031_init > function, this patch use timer_free() in the finalize function to fix it. > > ASAN shows memory leak stack: > > Direct leak of 48 byte(s) in 1 object(s) allocated from:

[PULL 0/7] Audio 20201215 patches

2020-12-15 Thread Gerd Hoffmann
The following changes since commit aa14de086675280206dbc1849da6f85b75f62f1b: Merge remote-tracking branch 'remotes/philmd-gitlab/tags/mips-20201213' int= o staging (2020-12-14 18:53:30 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/audio-20201215-pu

[PULL 1/7] coreaudio: rename misnamed variable fake_as

2020-12-15 Thread Gerd Hoffmann
From: Volker Rümelin While the variable once was used to fake audio settings, since commit ed2a4a7941 "audio: proper support for float samples in mixeng" this is no longer true. Rename the variable to obt_as. This is the same naming scheme as in audio/sdlaudio.c Tested-by: Howard Spoelstra Sign

[PULL 4/7] audio: remove unused function audio_is_cleaning_up()

2020-12-15 Thread Gerd Hoffmann
From: Volker Rümelin The previous commit removed the last call site of audio_is_cleaning_up(). Remove the now unused function. Tested-by: Howard Spoelstra Signed-off-by: Volker Rümelin Message-id: 20201213130528.5863-4-vr_q...@t-online.de Signed-off-by: Gerd Hoffmann --- audio/audio.h | 1 -

[PULL 2/7] coreaudio: don't start playback in init routine

2020-12-15 Thread Gerd Hoffmann
From: Volker Rümelin Every emulated audio device has a way to enable audio playback. Don't start playback until the guest enables the audio device to keep the Core Audio device run state in sync with hw->enabled. Tested-by: Howard Spoelstra Signed-off-by: Volker Rümelin Message-id: 20201213130

[PULL 7/7] audio: add sanity check

2020-12-15 Thread Gerd Hoffmann
Check whenever we actually found the spiceaudio driver before flipping the can_be_default field. Fixes: f0c4555edfdd ("audio: remove qemu_spice_audio_init()") Buglink: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=977301 Reported-by: dann frazier Signed-off-by: Gerd Hoffmann Message-Id: <202

[PULL 5/7] cs4231: Get rid of empty property array

2020-12-15 Thread Gerd Hoffmann
From: Eduardo Habkost An empty props array is unnecessary, we can just not call device_class_set_props(). Reviewed-by: Marc-André Lureau Signed-off-by: Eduardo Habkost Message-id: 20201211220529.2290218-2-ehabk...@redhat.com Signed-off-by: Gerd Hoffmann --- hw/audio/cs4231.c | 5 - 1 fil

[PULL 3/7] coreaudio: always stop audio playback on shut down

2020-12-15 Thread Gerd Hoffmann
From: Volker Rümelin Always stop audio playback and remove the playback callback when QEMU exits. On shut down the function coreaudio_fini_out() destroys the coreaudio mutex but fails to stop audio playback and to remove the audio playback callback, because function audio_is_cleaning_up() always

[Bug 1890333] Re: [OSS-Fuzz] Issue 26797: qemu:qemu-fuzz-i386-target-generic-fuzz-virtio-blk: ASSERT: addr < cache->len && 2 <= cache->len - addr

2020-12-15 Thread Qiuhao Li
Hi, It seems while the minimized producer doesn't fail the assertion now, the original reproducer provided by OSS-Fuzz[1] can still crash the latest QEMU (1758428, Dec 12, built with --enable-sanitizers --enable- fuzzing). Could anyone check if they trigger different bugs? Tested on: Ubuntu: 20

[PULL 6/7] audio: Simplify audio_bug() removing old code

2020-12-15 Thread Gerd Hoffmann
From: Philippe Mathieu-Daudé This code (introduced in commit 1d14ffa97ea, Oct 2005) is likely unused since years. Time to remove it. If the condition is true, simply call abort(). Suggested-by: Gerd Hoffmann Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau Message-id: 202

Re: [PATCH v2 01/16] target/mips: Inline cpu_state_reset() in mips_cpu_reset()

2020-12-15 Thread Richard Henderson
On 12/14/20 12:37 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/cpu.c | 26 +- > 1 file changed, 9 insertions(+), 17 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 04/16] target/mips: Remove consecutive CONFIG_USER_ONLY ifdefs

2020-12-15 Thread Richard Henderson
On 12/14/20 12:37 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/helper.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 05/16] target/mips: Extract common helpers from helper.c to common_helper.c

2020-12-15 Thread Richard Henderson
On 12/14/20 12:37 PM, Philippe Mathieu-Daudé wrote: > The rest of helper.c is TLB related. Extract the non TLB > specific functions to a new file, so we can rename helper.c > as tlb_helper.c in the next commit. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/internal.h | 2 + > t

Re: [PATCH v2 10/16] target/mips: Replace gen_exception_err(err=0) by gen_exception_end()

2020-12-15 Thread Richard Henderson
On 12/14/20 12:37 PM, Philippe Mathieu-Daudé wrote: > generate_exception_err(err=0) is simply generate_exception_end(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 03/16] target/mips: Add !CONFIG_USER_ONLY comment after #endif

2020-12-15 Thread Richard Henderson
On 12/14/20 12:37 PM, Philippe Mathieu-Daudé wrote: > To help understand ifdef'ry, add comment after #endif. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/helper.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 09/16] target/mips: Rename translate_init.c as cpu-defs.c

2020-12-15 Thread Richard Henderson
On 12/14/20 12:37 PM, Philippe Mathieu-Daudé wrote: > This file is not TCG specific, contains CPU definitions > and is consumed by cpu.c. Rename it as such. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/cpu.c| 2 +- > target/mips/{translate_ini

Re: [PATCH v2 11/16] target/mips: Replace gen_exception_end(EXCP_RI) by gen_rsvd_instruction

2020-12-15 Thread Richard Henderson
On 12/14/20 12:37 PM, Philippe Mathieu-Daudé wrote: > gen_reserved_instruction() is easier to read than > generate_exception_end(ctx, EXCP_RI), replace it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.c | 724 > 1 file changed,

Re: [PATCH v2 04/12] i386: Register feature bit properties as class properties

2020-12-15 Thread Markus Armbruster
Eduardo Habkost writes: > Class properties make QOM introspection simpler and easier, as > they don't require an object to be instantiated. > > Signed-off-by: Eduardo Habkost This is significantly more than just "simpler and easier". The other day, I played with the QMP core to reduce its appe

[PULL 04/20] target/openrisc: Move pic_cpu code into CPU object proper

2020-12-15 Thread Peter Maydell
The openrisc code uses an old style of interrupt handling, where a separate standalone set of qemu_irqs invoke a function openrisc_pic_cpu_handler() which signals the interrupt to the CPU proper by directly calling cpu_interrupt() and cpu_reset_interrupt(). Because CPU objects now inherit (indirect

[PULL 05/20] target/nios2: Move IIC code into CPU object proper

2020-12-15 Thread Peter Maydell
The Nios2 architecture supports two different interrupt controller options: * The IIC (Internal Interrupt Controller) is part of the CPU itself; it has 32 IRQ input lines and no NMI support. Interrupt status is queried and controlled via the CPU's ipending and istatus registers. * The

[PULL 09/20] hw/core/loader.c: Improve reporting of ROM overlap errors

2020-12-15 Thread Peter Maydell
In rom_check_and_register_reset() we report to the user if there is a "ROM region overlap". This has a couple of problems: * the reported information is not very easy to intepret * the function just prints the overlap to stderr (and relies on its single callsite in vl.c to do an error_report()

[PULL 06/20] target/nios2: Move nios2_check_interrupts() into target/nios2

2020-12-15 Thread Peter Maydell
The function nios2_check_interrupts)() looks only at CPU-internal state; it belongs in target/nios2, not hw/nios2. Move it into the same file as its only caller, so it can just be local to that file. This removes the only remaining code from cpu_pic.c, so we can delete that file entirely. Signed

[PULL 00/20] target-arm queue

2020-12-15 Thread Peter Maydell
-pull-request' into staging (2020-12-14 20:32:38 +) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20201215 for you to fetch changes up to 23af268566069183285bebbdf95b1b37cb7c0942: hw/block/m25p80: Fix Numonyx fast read d

  1   2   3   4   5   >