Hi Claudio,
On 12/10/20 1:11 PM, Claudio Fontana wrote:
> Hello, this is version 10 of the cleanup, changed from RFC to PATCH.
>
> v9 -> v10: minor tweaks and fixes
>
> * in "i386: split cpu accelerators from cpu.c",
>
> use kvm/kvm-cpu.c, hvf/hvf-cpu.c, tcg/tcg-cpu.c.
> Easier to understand co
On 12/10/20 2:10 PM, Claudio Fontana wrote:
> On 12/10/20 1:59 PM, Philippe Mathieu-Daudé wrote:
>> On 12/10/20 1:12 PM, Claudio Fontana wrote:
>>> Signed-off-by: Claudio Fontana
>>> Reviewed-by: Alex Bennée
>>> ---
>>> include/hw/core/cpu.h | 18 +++---
>>> include/hw/core/t
Hi,
> /* ui/gtk.c */
> void gd_update_windowsize(VirtualConsole *vc);
> +int gd_refresh_rate_millihz(GtkWidget *window);
Patch is whitespace-mangled.
Can you resend with "git send-email"?
thanks,
Gerd
On 12/10/20 1:59 PM, Philippe Mathieu-Daudé wrote:
> On 12/10/20 1:12 PM, Claudio Fontana wrote:
>> Signed-off-by: Claudio Fontana
>> Reviewed-by: Alex Bennée
>> ---
>> include/hw/core/cpu.h | 18 +++---
>> include/hw/core/tcg-cpu-ops.h | 10 ++
>> hw/mips/jazz.c
Hi
On Thu, Nov 26, 2020 at 3:57 PM Peter Maydell
wrote:
> On Thu, 26 Nov 2020 at 11:29, wrote:
> >
> > From: Marc-André Lureau
> >
> > Since commit efc6c07 ("configure: Add a test for the minimum compiler
> > version"), QEMU explicitely depends on GCC >= 4.8.
> >
> > (clang >= 3.8 advertizes i
On 12/10/20 2:01 PM, Philippe Mathieu-Daudé wrote:
> On 12/10/20 1:12 PM, Claudio Fontana wrote:
>> make it consistently SOFTMMU-only.
>>
>> Signed-off-by: Claudio Fontana
>> Reviewed-by: Alex Bennée
>> ---
>> include/hw/core/cpu.h | 17 +++--
>> include/hw/core/tcg-cpu-ops
To sum up everything:
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 2d5aeeb45a..61f0963916 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -3028,11 +3028,11 @@ static int spapr_kvm_type(MachineState *machine,
const char *vm_type)
return 0;
}
-if (!strcmp(vm_type, "HV
Hi
On Thu, Nov 26, 2020 at 4:23 PM Peter Maydell
wrote:
> On Thu, 26 Nov 2020 at 12:06, Daniel P. Berrangé
> wrote:
> >
> > On Thu, Nov 26, 2020 at 11:49:28AM +, Peter Maydell wrote:
> > > On Thu, 26 Nov 2020 at 11:29, wrote:
> > > >
> > > > From: Philippe Mathieu-Daudé
> > > >
> > > > Si
From: Marc-André Lureau
Hi,
Since commit efc6c07 ("configure: Add a test for the minimum compiler version"),
QEMU explicitely depends on GCC >= 4.8.
v3:
- drop first patch replacing QEMU_GNUC_PREREQ with G_GNUC_CHECK_VERSION
- add last patch to remove QEMU_GNUC_PREREQ
- tweak commit messages
On Thu, 10 Dec 2020 13:34:59 +0100
Paolo Bonzini wrote:
> To sum up everything:
>
LGTM
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 2d5aeeb45a..61f0963916 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -3028,11 +3028,11 @@ static int spapr_kvm_type(MachineState *machine,
From: Marc-André Lureau
Since commit efc6c07 ("configure: Add a test for the minimum compiler
version"), QEMU explicitely depends on GCC >= 4.8.
(clang >= 3.4 advertizes itself as GCC >= 4.2 compatible)
Signed-off-by: Marc-André Lureau
Reviewed-by: Peter Maydell
Acked-by: Alex Bennée
---
te
I guess "git send-email" didn't do much, so I'm just forwarding the
email now.
-- Forwarded message --
From: Nikola Pavlica
Subject: [PATCH] ui/gtk: Update refresh rate for EGL as well
Date: 2020-12-10T13:40:06+0100
To: qemu-de...@nongnu.com
Cc: Nikola Pavlica
---
include/ui/g
From: Marc-André Lureau
Since commit efc6c07 ("configure: Add a test for the minimum compiler
version"), QEMU explicitely depends on GCC >= 4.8.
(clang >= 3.4 advertizes itself as GCC >= 4.2 compatible and supports
__builtin_expect too)
Signed-off-by: Marc-André Lureau
---
include/qemu/compil
From: John Wang
Add an eeprom device and fill it with fru
information
$ ipmitool fru print 0
Product Manufacturer : Bytedance
Product Name : G220A
Signed-off-by: John Wang
Reviewed-by: Cédric Le Goater
Message-Id: <20201210103607.556-1-wangzhiqiang...@bytedance.com>
Signed-off-by: C
From: Marc-André Lureau
QEMU requires Clang or GCC, that define and support __GNUC__ extensions
Signed-off-by: Marc-André Lureau
Reviewed-by: Peter Maydell
---
include/exec/poison.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/exec/poison.h b/include/exec/poison.h
index 7b9ac3
On Thu, Dec 10, 2020 at 05:17:05PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Thu, Nov 26, 2020 at 4:23 PM Peter Maydell
> wrote:
>
> > On Thu, 26 Nov 2020 at 12:06, Daniel P. Berrangé
> > wrote:
> > >
> > > On Thu, Nov 26, 2020 at 11:49:28AM +, Peter Maydell wrote:
> > > > On Thu, 26 Nov
> The following changes since commit 5e7b204dbfae9a562fc73684986f936b97f63877:
>
> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging
> (2020-12-09 20:08:54 +)
>
> are available in the Git repository at:
>
> https://git.linaro.org/peo
From: Marc-André Lureau
Since commit efc6c07 ("configure: Add a test for the minimum compiler
version"), QEMU explicitely depends on GCC >= 4.8.
(clang >= 3.4 advertizes itself as GCC >= 4.2 compatible)
Signed-off-by: Marc-André Lureau
Acked-by: Alex Bennée
---
include/qemu/qemu-plugin.h | 9
On 201210 1411, Philippe Mathieu-Daudé wrote:
> On 12/10/20 12:36 PM, Darren Kenny wrote:
> > Hi Alex,
> >
> > On Wednesday, 2020-12-09 at 15:10:54 -05, Alexander Bulekov wrote:
> >> Prior to this patch, the fuzzer found inputs to map PCI device BARs and
> >> enable the device. While it is nice th
On 12/10/20 1:12 PM, Claudio Fontana wrote:
> Signed-off-by: Claudio Fontana
> Reviewed-by: Alex Bennée
> ---
> include/hw/core/cpu.h | 2 --
> include/hw/core/tcg-cpu-ops.h | 3 +++
> accel/tcg/cpu-exec.c| 4 ++--
> target/alpha/cpu.c | 2 +-
> target/ar
From: Marc-André Lureau
This allows to get rid of a check for older GCC version (which was a bit
bogus too since it was falling back on c++ version..)
Signed-off-by: Marc-André Lureau
---
tools/virtiofsd/fuse_common.h | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --gi
From: Philippe Mathieu-Daudé
Since commit efc6c070aca ("configure: Add a test for the
minimum compiler version") the minimum compiler version
required for GCC is 4.8, which has the GCC BZ#36793 bug fixed.
We can safely remove the special case introduced in commit
a281ebc11a6 ("virtio: add missin
On 12/10/20 1:12 PM, Claudio Fontana wrote:
> Signed-off-by: Claudio Fontana
> Reviewed-by: Alex Bennée
> ---
> include/hw/core/cpu.h | 18 +++---
> include/hw/core/tcg-cpu-ops.h | 10 ++
> hw/mips/jazz.c| 9 +++--
> target/alpha/cpu.c
From: Marc-André Lureau
QEMU requires Clang or GCC, that define and support __GNUC__ extensions.
Signed-off-by: Marc-André Lureau
Reviewed-by: Peter Maydell
---
linux-user/strace.c | 4
1 file changed, 4 deletions(-)
diff --git a/linux-user/strace.c b/linux-user/strace.c
index 11fea14fb
On Thu, 10 Dec 2020 10:10:21 -0300
Daniel Henrique Barboza wrote:
>
>
> On 12/10/20 9:47 AM, Greg Kurz wrote:
> > On Thu, 10 Dec 2020 13:34:59 +0100
> > Paolo Bonzini wrote:
> >
> >> To sum up everything:
> >>
> >
> > LGTM
>
> I just sent a v2 with a bit more done (e.g. added ignore case co
changes from v1, all proposed by Greg:
* Removed comment at the start of spapr_get_kvm_type()
* Added a one liner return in spapr_get_kvm_type()
* use g_ascii_strcasecmp() in all str comparisons in spapr_kvm_type()
* Exposed the 'auto' default kvm-type mode in the docs
* changed HV and PR to lower-
From: Marc-André Lureau
When needed, the G_GNUC_CHECK_VERSION() glib macro can be used instead.
Signed-off-by: Marc-André Lureau
---
include/qemu/compiler.h| 11 ---
scripts/cocci-macro-file.h | 1 -
2 files changed, 12 deletions(-)
diff --git a/include/qemu/compiler.h b/include/
From: Marc-André Lureau
Since commit efc6c07 ("configure: Add a test for the minimum compiler
version"), QEMU explicitely depends on GCC >= 4.8, we could thus drop
earlier version checks. Except clang advertizes itself as GCC 4.2.1.
Since clang doesn't support gnu_printf, make that case explicit
On 12/10/20 2:05 PM, Philippe Mathieu-Daudé wrote:
> Hi Claudio,
>
> On 12/10/20 1:11 PM, Claudio Fontana wrote:
>> Hello, this is version 10 of the cleanup, changed from RFC to PATCH.
>>
>> v9 -> v10: minor tweaks and fixes
>>
>> * in "i386: split cpu accelerators from cpu.c",
>>
>> use kvm/kvm-c
Patchew URL:
https://patchew.org/QEMU/20201210134752.780923-1-marcandre.lur...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20201210134752.780923-1-marcandre.lur...@redhat.com
Subject: [PATCH v3 00/13] Re
On Thu, Dec 10, 2020 at 01:42:51PM +, Daniel P. Berrangé wrote:
> On Thu, Dec 10, 2020 at 05:17:05PM +0400, Marc-André Lureau wrote:
> > Hi
> >
> > On Thu, Nov 26, 2020 at 4:23 PM Peter Maydell
> > wrote:
> >
> > > On Thu, 26 Nov 2020 at 12:06, Daniel P. Berrangé
> > > wrote:
> > > >
> > >
From: Philippe Mathieu-Daudé
Since commit efc6c070aca ("configure: Add a test for the
minimum compiler version") the minimum compiler version
required for GCC is 4.8.
We can safely remove the special case for GCC 4.6 introduced
in commit 0448f5f8b81 ("cpu-exec: Fix compiler warning
(-Werror=clob
On Thu, 10 Dec 2020 10:07:21 -0300
Daniel Henrique Barboza wrote:
> spapr_kvm_type() is considering 'vm_type=NULL' as a valid input, where
> the function returns 0. This is relying on the current QEMU machine
> options handling logic, where the absence of the 'kvm-type' option
> will be reflected
From: Marc-André Lureau
QEMU requires Clang or GCC, that define and support __GNUC__ extensions.
Signed-off-by: Marc-André Lureau
---
include/qemu/compiler.h | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h
index 62122
From: Marc-André Lureau
QEMU requires either GCC or Clang, which both advertize __GNUC__.
Drop MSVC fallback path.
Note: I intentionally left further cleanups for a later work.
Signed-off-by: Marc-André Lureau
---
audio/audio.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
dif
On Thu, 10 Dec 2020 15:01:20 +0100
Greg Kurz wrote:
> On Thu, 10 Dec 2020 10:07:21 -0300
> Daniel Henrique Barboza wrote:
>
> > spapr_kvm_type() is considering 'vm_type=NULL' as a valid input, where
> > the function returns 0. This is relying on the current QEMU machine
> > options handling log
From: Marc-André Lureau
QEMU requires Clang or GCC, that define and support __GNUC__ extensions
Signed-off-by: Marc-André Lureau
Acked-by: Stefano Stabellini
---
include/hw/xen/interface/io/ring.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/include/hw/xen/interface/io/ring.h
Good to know. Then it makes sense to close this report for now. Feel
free to reopen it if necessary.
Thanks!
** Changed in: qemu
Status: Confirmed => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.lau
On Thu, Dec 03, 2020 at 07:59:02PM +0530, P J P wrote:
> From: Prasad J Pandit
>
> We are about to introduce a qemu-security mailing list to report
> and triage QEMU security issues.
>
> Update the security process web page with new mailing list address
> and triage details.
>
> Signed-off-by:
On 12/10/20 11:14 AM, Greg Kurz wrote:
On Thu, 10 Dec 2020 15:01:20 +0100
Greg Kurz wrote:
On Thu, 10 Dec 2020 10:07:21 -0300
Daniel Henrique Barboza wrote:
spapr_kvm_type() is considering 'vm_type=NULL' as a valid input, where
the function returns 0. This is relying on the current QEMU
Malicious user can set the feedback divisor for the PLLs
to zero, triggering a floating-point exception (SIGFPE).
As the datasheet [*] is not clear how hardware behaves
when these bits are zeroes, use the maximum divisor
possible (128) to avoid the software FPE.
[*] Zynq-7000 TRM, UG585 (v1.12.2)
he Git repository at:
>
> git://git.kraxel.org/qemu tags/microvm-20201210-pull-request
>
> for you to fetch changes up to 08af4e13f8d4db099bc444f83879c32459df7f3a:
>
> tests/acpi: disallow updates for
On 12/10/20 2:47 PM, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> QEMU requires either GCC or Clang, which both advertize __GNUC__.
> Drop MSVC fallback path.
>
> Note: I intentionally left further cleanups for a later work.
>
> Signed-off-by: Marc-André Lureau
> ---
> aud
Hi all!
I have an idea, that not storing backing filename in qcow2 image at all may be
a good thing. I'll give some reasons and want to know what do you think about
it.
1. Libvirt has to manage and keep in mind backing chains anyway.
This means, that storing this information in qcow2 header i
Allows guest to receive mouse buttons 4 and 5, aka "SIDE" button
and "EXTRA" button
Signed-off-by: Darrell Walisser
---
ui/sdl2.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ui/sdl2.c b/ui/sdl2.c
index 189d26e2a9..a578017268 100644
--- a/ui/sdl2.c
+++ b/ui/sdl2.c
@@ -275,6 +275,8 @@ st
On 12/10/20 3:27 PM, Peter Maydell wrote:
> On Thu, 10 Dec 2020 at 14:26, Philippe Mathieu-Daudé
> wrote:
>>
>> On 12/10/20 2:47 PM, marcandre.lur...@redhat.com wrote:
>>> From: Marc-André Lureau
>>>
>>> QEMU requires either GCC or Clang, which both advertize __GNUC__.
>>> Drop MSVC fallback pat
On 12/10/20 2:47 PM, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> QEMU requires Clang or GCC, that define and support __GNUC__ extensions
>
> Signed-off-by: Marc-André Lureau
> Reviewed-by: Peter Maydell
> ---
> include/exec/poison.h | 2 --
> 1 file changed, 2 deletions(-
On 12/10/20 2:47 PM, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> QEMU requires Clang or GCC, that define and support __GNUC__ extensions.
>
> Signed-off-by: Marc-André Lureau
> Reviewed-by: Peter Maydell
> ---
> linux-user/strace.c | 4
> 1 file changed, 4 deletions(
On 12/10/20 2:47 PM, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Since commit efc6c07 ("configure: Add a test for the minimum compiler
> version"), QEMU explicitely depends on GCC >= 4.8.
>
> (clang >= 3.4 advertizes itself as GCC >= 4.2 compatible and supports
> __builtin_e
On Thu, 10 Dec 2020 at 14:26, Philippe Mathieu-Daudé wrote:
>
> On 12/10/20 2:47 PM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > QEMU requires either GCC or Clang, which both advertize __GNUC__.
> > Drop MSVC fallback path.
> >
> > Note: I intentionally left further cle
Allows guest to receive mouse buttons 4 and 5, aka "SIDE" button
and "EXTRA" button
Signed-off-by: Darrell Walisser
---
ui/sdl2.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ui/sdl2.c b/ui/sdl2.c
index 189d26e2a9..a578017268 100644
--- a/ui/sdl2.c
+++ b/ui/sdl2.c
@@ -275,6 +275,8 @@ st
Allows guest to receive mouse buttons 4 and 5, aka "SIDE" button
and "EXTRA" button
Signed-off-by: Darrell Walisser
---
ui/sdl2.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ui/sdl2.c b/ui/sdl2.c
index 189d26e2a9..a578017268 100644
--- a/ui/sdl2.c
+++ b/ui/sdl2.c
@@ -275,6 +275,8 @@ st
On Thu, 10 Dec 2020 at 14:32, Philippe Mathieu-Daudé wrote:
>
> On 12/10/20 2:47 PM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Since commit efc6c07 ("configure: Add a test for the minimum compiler
> > version"), QEMU explicitely depends on GCC >= 4.8.
> >
> > (clang >
> We support coordinated discarding of RAM using the RamDiscardMgr. Let's
> unlock support for coordinated discards, keeping uncoordinated discards
> (e.g., via virtio-balloon) disabled.
>
> This unlocks virtio-mem + vfio. Note that vfio used via "nvme://" by the
> block layer has to be implemented
On Thu, Dec 10, 2020 at 10:53:23AM +0800, zhukeqian wrote:
>
>
> On 2020/12/10 10:08, Peter Xu wrote:
> > Keqian,
> >
> > On Thu, Dec 10, 2020 at 09:46:06AM +0800, zhukeqian wrote:
> >> Hi,
> >>
> >> I see that if start or size is not PAGE aligned, it also clears areas
> >> which beyond caller's
> We have users in migration context that don't hold the BQL (when
> finishing migration). To prepare for further changes, use a dedicated mutex
> instead of atomic operations. Keep using qatomic_read ("READ_ONCE") for the
> functions that only extract the current state (e.g., used by
> virtio-ball
changes from v2, all proposed by Greg:
* Handle 'NULL' value as default mode fallback in spapr_kvm_type()
* Do not allow for 'AUTO' to be a valid mode in spapr_kvm_type()
* Initialize 'spapr->kvm_type' in spapr_instance_init() like Paolo
proposed. This will spare us from changing spapr_get_kvm_ty
spapr_kvm_type() is considering 'vm_type=NULL' as a valid input, where
the function returns 0. This is relying on the current QEMU machine
options handling logic, where the absence of the 'kvm-type' option
will be reflected as 'vm_type=NULL' in this function.
This is not robust, and will break if
Hi
On Thu, Dec 10, 2020 at 6:47 PM Peter Maydell wrote:
>
> On Thu, 10 Dec 2020 at 14:32, Philippe Mathieu-Daudé
> wrote:
> >
> > On 12/10/20 2:47 PM, marcandre.lur...@redhat.com wrote:
> > > From: Marc-André Lureau
> > >
> > > Since commit efc6c07 ("configure: Add a test for the minimum compi
Hi
On Thu, Dec 10, 2020 at 6:35 PM Philippe Mathieu-Daudé
wrote:
>
> On 12/10/20 3:27 PM, Peter Maydell wrote:
> > On Thu, 10 Dec 2020 at 14:26, Philippe Mathieu-Daudé
> > wrote:
> >>
> >> On 12/10/20 2:47 PM, marcandre.lur...@redhat.com wrote:
> >>> From: Marc-André Lureau
> >>>
> >>> QEMU re
Kevin Wolf 于2020年12月10日周四 上午1:43写道：
>
> Am 09.12.2020 um 10:33 hat Daniel P. Berrangé geschrieben:
> > On Tue, Dec 08, 2020 at 03:38:22PM +0100, Kevin Wolf wrote:
> > > Am 08.12.2020 um 13:59 hat Li Feng geschrieben:
> > > > This patch addresses this issue:
> > > > When accessing a volume on an NF
>> bool ram_block_discard_is_disabled(void)
>> {
>> -return qatomic_read(&ram_block_discard_disabled) > 0;
>> +return qatomic_read(&ram_block_discard_disablers);
>> }
> return value won't be bool?
The compiler does type conversion.
!= 0 -> true
== 0 -> false
[...]
> Apart from query
On Thu, 10 Dec 2020 11:55:17 -0300
Daniel Henrique Barboza wrote:
> spapr_kvm_type() is considering 'vm_type=NULL' as a valid input, where
> the function returns 0. This is relying on the current QEMU machine
> options handling logic, where the absence of the 'kvm-type' option
> will be reflected
On 12/10/20 5:28 AM, Cornelia Huck wrote:
On Wed, 9 Dec 2020 15:34:20 -0500
Matthew Rosato wrote:
s390 PCI currently disallows PCI devices without the MSI-X capability.
However, this fence doesn't make sense for passthrough devices. Move
the check to only fence emulated devices (e.g., virtio
On 12/10/20 5:30 AM, Cornelia Huck wrote:
On Wed, 9 Dec 2020 15:34:21 -0500
Matthew Rosato wrote:
In pcistb_service_call, we are grabbing 8 bits from a guest register to
indicate the length of the store operation -- but per the architecture
the length is actually defined by 13 bits of the gue
> >> bool ram_block_discard_is_disabled(void)
> >> {
> >> -return qatomic_read(&ram_block_discard_disabled) > 0;
> >> +return qatomic_read(&ram_block_discard_disablers);
> >> }
> > return value won't be bool?
>
> The compiler does type conversion.
>
> != 0 -> true
> == 0 -> false
ah... I
The 'ch' will be NULL in the following stack:
send_notify_iov()->fuse_send_msg()->virtio_send_msg(),
so we should check 'ch' is valid before dereferencing it
Reported-by: Euler Robot
Signed-off-by: Alex Chen
---
tools/virtiofsd/fuse_virtio.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a
On Thu, Dec 10, 2020 at 10:56:59PM +0800, Li Feng wrote:
> Kevin Wolf 于2020年12月10日周四 上午1:43写道：
> >
> > Am 09.12.2020 um 10:33 hat Daniel P. Berrangé geschrieben:
> > > On Tue, Dec 08, 2020 at 03:38:22PM +0100, Kevin Wolf wrote:
> > > > Am 08.12.2020 um 13:59 hat Li Feng geschrieben:
> > > > > This
On Thu, Dec 10, 2020 at 11:24:46AM +, Peter Maydell wrote:
> On Thu, 10 Dec 2020 at 11:14, Stefan Hajnoczi wrote:
> > On Thu, Dec 03, 2020 at 08:40:11PM +, Peter Maydell wrote:
> > > I would prefer to see this going through the tree of an
> > > established QEMU developer who's already send
On 10.12.20 13:52, Philippe Mathieu-Daudé wrote:
NVMe drive can not be shrunk.
*cannot
Since commit c80d8b06cfa we can use the @exact parameter (set
to false) to return success if the block device is larger than
the requested offset (even if we can not be shrunk).
Use this parameter to imple
On 12/10/20 4:36 PM, Max Reitz wrote:
> On 10.12.20 13:52, Philippe Mathieu-Daudé wrote:
>> NVMe drive can not be shrunk.
>
> *cannot
>
>> Since commit c80d8b06cfa we can use the @exact parameter (set
>> to false) to return success if the block device is larger than
>> the requested offset (even
My mistake, you are not on the receiver list of my v2.
I use the get_maintainer.sh to generate the cc list.
I will resend it to you.
Daniel P. Berrangé 于2020年12月10日周四 下午11:29写道：
>
> On Thu, Dec 10, 2020 at 10:56:59PM +0800, Li Feng wrote:
> > Kevin Wolf 于2020年12月10日周四 上午1:43写道：
> > >
> > > Am 09
This patch addresses this issue:
When accessing a volume on an NFS filesystem without supporting the file lock,
tools, like qemu-img, will complain "Failed to lock byte 100".
In the original code, the qemu_has_ofd_lock will test the lock on the
"/dev/null" pseudo-file. Actually, the file.locking i
On Thu, Dec 10, 2020 at 11:53:09PM +0800, Feng Li wrote:
> My mistake, you are not on the receiver list of my v2.
> I use the get_maintainer.sh to generate the cc list.
> I will resend it to you.
No, need. I've seen 2, but didn't think you were referring to that
as it still has most of the flaws I
Remove some simple CLI parameters that have been deprecated since
at least two releass already.
Philippe Mathieu-Daudé (1):
accel/tcg: Remove deprecated '-tb-size' option
Thomas Huth (3):
docs/system: Move the list of removed features to a separate file
Remove the deprecated -realtime optio
From: Philippe Mathieu-Daudé
The '-tb-size' option (replaced by '-accel tcg,tb-size') is
deprecated since 5.0 (commit fe174132478). Remove it.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20201202112714.1223783-1-phi...@redhat.com>
Signed-off-by: Thomas Huth
---
accel/tcg/translate-all.
It has been marked as deprecated since QEMU v4.2, replaced by
the -overcommit option. Time to remove it now.
Signed-off-by: Thomas Huth
---
docs/system/deprecated.rst | 6 --
docs/system/removed-features.rst| 6 ++
qemu-options.hx | 14 +-
s
ilable in the Git repository at:
>
> https://github.com/legoater/qemu/ tags/pull-aspeed-20201210
>
> for you to fetch changes up to 6f5f6507e49df4820207a94f3aeaaeab08092d32:
>
> aspeed: g220a-bmc: Add an FRU (2020-12-10 12:11:03 +0100)
>
> --
It has been marked as deprecated since QEMU v5.0, replaced by the
corresponding parameter of the -display option.
Signed-off-by: Thomas Huth
---
docs/system/deprecated.rst | 6 --
docs/system/removed-features.rst | 6 ++
qemu-options.hx | 7 ---
softmmu/vl.c
Otherwise there is a chance that new deprecated features get added
to the list of removed features at the end of the file by accident.
It's way less confusing if the removed features reside in a separate
file.
Signed-off-by: Thomas Huth
---
docs/system/deprecated.rst | 232
On Wed, Dec 09, 2020 at 12:54:48PM +0800, Li Feng wrote:
> This patch addresses this issue:
> When accessing a volume on an NFS filesystem without supporting the file lock,
> tools, like qemu-img, will complain "Failed to lock byte 100".
>
> In the original code, the qemu_has_ofd_lock will test th
On 10/12/2020 16.58, Thomas Huth wrote:
> From: Philippe Mathieu-Daudé
>
> The '-tb-size' option (replaced by '-accel tcg,tb-size') is
> deprecated since 5.0 (commit fe174132478). Remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé
> Message-Id: <20201202112714.1223783-1-phi...@redhat.com>
I
On Wed, 9 Dec 2020 at 18:10, Michael S. Tsirkin wrote:
>
> From: Marc-André Lureau
>
> By making libvhost-user a subproject, check it builds
> standalone (without the global QEMU cflags etc).
>
> Note that the library still relies on QEMU include/qemu/atomic.h and
> linux_headers/.
>
> Signed-off
On 02/12/2020 12.27, Philippe Mathieu-Daudé wrote:
> The '-tb-size' option (replaced by '-accel tcg,tb-size') is
> deprecated since 5.0 (commit fe174132478). Remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> docs/system/deprecated.rst | 12 +---
> accel/tcg/translate-all.c |
Hi,
Now virtiofs DAX support has been merged in upstream kernel 5.10 (It
has yet to be merged qemu). So I decided to do some performance
benchmarking and see what's the impact of DAX on different workloads in
different caching modes. Hence I ran some performance numbers and
publishing the results
Ok, I see.
I will split the detect lock without changing the global variable to a
separate function.
Don't call the qemu_has_ofd_lock.
Thanks.
Daniel P. Berrangé 于2020年12月10日周四 下午11:59写道：
>
> On Wed, Dec 09, 2020 at 12:54:48PM +0800, Li Feng wrote:
> > This patch addresses this issue:
> > When ac
Signed-off-by: Markus Armbruster
---
tests/check-qjson.c | 41 +++--
1 file changed, 39 insertions(+), 2 deletions(-)
diff --git a/tests/check-qjson.c b/tests/check-qjson.c
index 6ab6b111b0..8cb8a40524 100644
--- a/tests/check-qjson.c
+++ b/tests/check-qjson.c
Move one of large_number()'s three checks to uint_number(), and the
other two to float_number().
Signed-off-by: Markus Armbruster
---
tests/check-qjson.c | 47 +++--
1 file changed, 3 insertions(+), 44 deletions(-)
diff --git a/tests/check-qjson.c b/tests
This demonstrates rounding error due to insufficient precision: double
3.1415926535897932 gets converted to JSON 3.141593.
Signed-off-by: Markus Armbruster
---
tests/test-string-output-visitor.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/test-string-output-visi
simple_number() and float_number() convert from JSON to QNumber and
back.
simple_number() tests "-0", but skips the conversion back to JSON,
because it yields "0", not "-0". Works as intended, so better cover
it: don't skip, but expect the funny result.
float_number() tests "-32.20e-10", but ski
qnum_to_string() has a FIXME comment about rounding errors due to
insufficient precision. Cover it: 2.718281828459045 gets converted to
"2.718282". The next commit will fix it.
Signed-off-by: Markus Armbruster
---
tests/check-qnum.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tes
The string output visitor should serialize numbers so that the string
input visitor deserializes them back to the same number. It fails to
do so.
print_type_number() uses format %f. This is prone to nasty rounding
errors. For instance, numbers between 0 and 0.005 get flushed to
zero.
We cu
simple_number() checks only qnum_get_try_int(). Also check
qnum_get_try_uint() and qnum_get_double().
float_number() checks only qnum_get_double(). Also check
qnum_get_try_int() and qnum_get_try_uint().
Signed-off-by: Markus Armbruster
---
tests/check-qjson.c | 19 ---
1 file
We should serialize numbers to JSON so that they deserialize back to
the same number. We fail to do so.
The culprit is qnum_to_string(): it uses format %f with trailing '0'
trimmed. Results in pretty output for "nice" numbers, but is prone to
nasty rounding errors. For instance, numbers between
Signed-off-by: Markus Armbruster
---
tests/test-visitor-serialization.c | 18 ++
1 file changed, 2 insertions(+), 16 deletions(-)
diff --git a/tests/test-visitor-serialization.c
b/tests/test-visitor-serialization.c
index 1c5a8b94ea..19b72571bb 100644
--- a/tests/test-visitor-ser
test_primitives() uses union member intmax_t max to compare the
integer members. Unspecified behavior. Has worked fine for many
years, though. Clean it up.
Signed-off-by: Markus Armbruster
---
tests/test-visitor-serialization.c | 44 +-
1 file changed, 37 insertion
This takes care of ancient FIXMEs, mostly because a future series will
rework the code, and I can't bring myself tiptoeing around these bugs.
Markus Armbruster (10):
tests/check-qjson: Don't skip funny QNumber to JSON conversions
tests/check-qjson: Examine QNum more thoroughly
tests/check-qj
block-commit defaults @base-node to the deepest backing image. When
there is none, it fails with "Base 'NULL' not found". Improve to
"There is no backing image".
block-commit and block-stream reject a @base argument that doesn't
resolve with "Base 'BASE' not found". Commit 6b33f3ae8b "qemu-img:
On Thu, Dec 10, 2020 at 5:11 PM Peter Maydell wrote:
> Looking at the commit, it's not clear to me why the
> vhost-user changes have resulted in all binaries getting
> a change to their link line. Paolo ?
Because libvhost-user/meson.build is not using the GLIB flags from
QEMU's configure and is n
Clean up includes so that osdep.h is included first and headers
which it implies are not included manually.
This commit was created with scripts/clean-includes, with the changes
to the following files manually reverted:
contrib/libvhost-user/libvhost-user-glib.h
contrib/libvhost-user/libv
201 - 300 of 447 matches
Mail list logo
