changes from v2, all proposed by Greg: * Handle 'NULL' value as default mode fallback in spapr_kvm_type() * Do not allow for 'AUTO' to be a valid mode in spapr_kvm_type() * Initialize 'spapr->kvm_type' in spapr_instance_init() like Paolo proposed. This will spare us from changing spapr_get_kvm_type() altogether. v2 link: https://lists.gnu.org/archive/html/qemu-devel/2020-12/msg02623.html
This patch addresses an issue that happens with the pseries machine after testing Paolo's patch [1]: $ sudo ./ppc64-softmmu/qemu-system-ppc64 -nographic -nodefaults -machine pseries --enable-kvm qemu-system-ppc64: Unknown kvm-type specified '' The reason lies on how qemu_opt_get() and object_property_get_str() works when there is no 'kvm-type' specified. We were conting on receiving NULL for kvm-type, but the latter will use a blank string "". Instead on relying on NULL, let's expose the already existing 'auto' kvm-type mode to the users and use that as default. [1] https://lists.gnu.org/archive/html/qemu-devel/2020-12/msg00471.html Daniel Henrique Barboza (1): spapr.c: set a 'kvm-type' default value instead of relying on NULL hw/ppc/spapr.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) -- 2.26.2
