Re: [PATCH v4 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

2020-10-19 Thread Cleber Rosa
On Mon, Oct 19, 2020 at 12:42:03PM +0200, Philippe Mathieu-Daudé wrote: > On 10/19/20 3:50 AM, Cleber Rosa wrote: > > The QEMU project has two machines (aarch64 and s390) that can be used > > "s390x" =) > Sure! Thanks! - Cleber. signature.asc Description: PGP signature

Re: [PATCH v7 01/11] hw/block/nvme: Add Commands Supported and Effects log

2020-10-19 Thread Klaus Jensen
On Oct 19 11:17, Dmitry Fomichev wrote: > This log page becomes necessary to implement to allow checking for > Zone Append command support in Zoned Namespace Command Set. > > This commit adds the code to report this log page for NVM Command > Set only. The parts that are specific to zoned operatio

[PATCH v2] softmmu/memory: fix memory_region_ioeventfd_equal()

2020-10-19 Thread Elena Afanasova
Eventfd can be registered with a zero length when fast_mmio is true. Handle this case properly when dispatching through QEMU. Signed-off-by: Elena Afanasova --- softmmu/memory.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/softmmu/memory.c b/softmmu/memory.c in

Re: [PATCH] virtio-iommu: fix incorrect print type

2020-10-19 Thread Eric Blake
On 10/19/20 8:39 AM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/1603114311-7392-1-git-send-email-lizhen...@huawei.com/ c61a848 virtio-iommu: fix incorrect print type === OUTPUT BEGIN === ERROR: Missing Signed-off-by: line(s) total: 1 errors, 0 warnings, 24 lines chec

Re: [PATCH v4 2/4] Jobs based on custom runners: build environment docs and playbook

2020-10-19 Thread Cleber Rosa
On Mon, Oct 19, 2020 at 12:27:41PM +0200, Erik Skultety wrote: > ... > > > diff --git a/scripts/ci/setup/inventory b/scripts/ci/setup/inventory > > new file mode 100644 > > index 00..8bb7ba6b33 > > --- /dev/null > > +++ b/scripts/ci/setup/inventory > > @@ -0,0 +1,2 @@ > > +[local] > > Nit

Re: [PATCH 6/30] semihosting: Fix Lesser GPL version number

2020-10-19 Thread Eric Blake
On 10/16/20 9:42 AM, Chetan Pant wrote: There is no "version 2" of the "Lesser" General Public License. Meta-comment: Looking in the archives, I see some odd threading going on: https://lists.gnu.org/archive/html/qemu-devel/2020-10/threads.html#04020 You sent 1/30 and 2/30 as independent thre

Re: [PATCH] virtio-gpu: fix incorrect print type

2020-10-19 Thread Eric Blake
On 10/19/20 9:23 AM, Zhengui li wrote: The type of input variable is unsigned int while the printer type is int. So fix incorrect print type. Signed-off-by: Zhengui li --- hw/display/virtio-gpu.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) This

Re: [PATCH v4 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

2020-10-19 Thread Cleber Rosa
On Mon, Oct 19, 2020 at 12:26:10PM +0200, Erik Skultety wrote: > On Sun, Oct 18, 2020 at 09:50:02PM -0400, Cleber Rosa wrote: > > To have the jobs dispatched to custom runners, gitlab-runner must > > be installed, active as a service and properly configured. The > > variables file and playbook int

Re: [PATCH v4 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

2020-10-19 Thread Cleber Rosa
On Mon, Oct 19, 2020 at 12:26:10PM +0200, Erik Skultety wrote: > On Sun, Oct 18, 2020 at 09:50:02PM -0400, Cleber Rosa wrote: > > + > > +- name: Checks the availability of official gitlab-runner builds in > > the archive > > + uri: > > +url: https://s3.amazonaws.com/gitlab-runner-

Re: [PATCH v7 03/11] hw/block/nvme: Add support for Namespace Types

2020-10-19 Thread Klaus Jensen
On Oct 19 11:17, Dmitry Fomichev wrote: > From: Niklas Cassel > > Define the structures and constants required to implement > Namespace Types support. > > Namespace Types introduce a new command set, "I/O Command Sets", > that allows the host to retrieve the command sets associated with > a name

[PATCH] scripts/qmp: delete 'qmp' script

2020-10-19 Thread John Snow
This script has not seen a patch that was specifically for this script since it was moved to this location in 2013, and I doubt it is used. It uses "man qmp" for its help message, which does not exist. It also presumes there is a manual page for qmp-XXX, for each defined qmp command XXX. I don't th

Re: [PATCH v6 02/10] migration: stop returning errno from load_snapshot()

2020-10-19 Thread Eric Blake
On 10/8/20 10:49 AM, Daniel P. Berrangé wrote: None of the callers care about the errno value since there is a full Error object populated. This gives consistency with save_snapshot() which already just returns -1. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé --- mig

Re: [PATCH v5] sev: add sev-inject-launch-secret

2020-10-19 Thread Tobin Feldman-Fitzthum
On 2020-10-19 12:47, Eduardo Habkost wrote: On Mon, Oct 19, 2020 at 12:46:08PM -0400, Eduardo Habkost wrote: On Thu, Oct 15, 2020 at 10:37:13AM -0400, to...@linux.ibm.com wrote: [...] > diff --git a/target/i386/sev-stub.c b/target/i386/sev-stub.c > index 88e3f39a1e..2d2ee54cc6 100644 > --- a/tar

Re: [PATCH v6 03/10] block: add ability to specify list of blockdevs during snapshot

2020-10-19 Thread Eric Blake
On 10/8/20 10:49 AM, Daniel P. Berrangé wrote: When running snapshot operations, there are various rules for which blockdevs are included/excluded. While this provides reasonable default behaviour, there are scenarios that are not well handled by the default logic. Some of the conditions do not h

Re: [PATCH] scripts/qmp: delete 'qmp' script

2020-10-19 Thread Eric Blake
On 10/19/20 4:04 PM, John Snow wrote: This script has not seen a patch that was specifically for this script since it was moved to this location in 2013, and I doubt it is used. It uses "man qmp" for its help message, which does not exist. It also presumes there is a manual page for qmp-XXX, for

Re: [PATCH v6 04/10] block: allow specifying name of block device for vmstate storage

2020-10-19 Thread Eric Blake
On 10/8/20 10:49 AM, Daniel P. Berrangé wrote: Currently the vmstate will be stored in the first block device that supports snapshots. Historically this would have usually been the root device, but with UEFI it might be the variable store. There needs to be a way to override the choice of block d

Re: [PATCH v6 05/10] block: rename and alter bdrv_all_find_snapshot semantics

2020-10-19 Thread Eric Blake
On 10/8/20 10:49 AM, Daniel P. Berrangé wrote: Currently bdrv_all_find_snapshot() will return 0 if it finds a snapshot, -1 if an error occurs, or if it fails to find a snapshot. New callers to be added want to distinguish between the error scenario and failing to find a snapshot. Rename it to bd

Re: [PATCH v10 09/10] virtio-iommu: Set supported page size mask

2020-10-19 Thread Peter Xu
On Thu, Oct 08, 2020 at 07:15:57PM +0200, Jean-Philippe Brucker wrote: > From: Bharat Bhushan > > The virtio-iommu device can deal with arbitrary page sizes for virtual > endpoints, but for endpoints assigned with VFIO it must follow the page > granule used by the host IOMMU driver. > > Implemen

Re: [PATCH v10 01/10] virtio-iommu: Fix virtio_iommu_mr()

2020-10-19 Thread Peter Xu
On Thu, Oct 08, 2020 at 07:15:49PM +0200, Jean-Philippe Brucker wrote: > Due to an invalid mask, virtio_iommu_mr() may return the wrong memory > region. It hasn't been too problematic so far because the function was > only used to test existence of an endpoint, but that is about to change. > > Fix

Re: [PATCH v6 06/10] migration: control whether snapshots are ovewritten

2020-10-19 Thread Eric Blake
On 10/8/20 10:49 AM, Daniel P. Berrangé wrote: The traditional HMP "savevm" command will overwrite an existing snapshot if it already exists with the requested name. This new flag allows this to be controlled allowing for safer behaviour with a future QMP command. Signed-off-by: Daniel P. Berran

Re: [PATCH v10 07/10] memory: Add interface to set iommu page size mask

2020-10-19 Thread Peter Xu
On Thu, Oct 08, 2020 at 07:15:55PM +0200, Jean-Philippe Brucker wrote: > From: Bharat Bhushan > > Allow to set the page size mask supported by an iommu memory region. > This enables a vIOMMU to communicate the page size granule supported by > an assigned device, on hosts that use page sizes great

Re: [PATCH v4 4/7] nbd: Update qapi to support exporting multiple bitmaps

2020-10-19 Thread Eric Blake
On 10/14/20 7:15 AM, Vladimir Sementsov-Ogievskiy wrote: 10.10.2020 00:55, Eric Blake wrote: Since 'nbd-server-add' is deprecated, and 'block-export-add' is new to 5.2, we can still tweak the interface.  Allowing 'bitmaps':['str'] is nicer than 'bitmap':'str'.  This wires up the qapi and qemu-nb

Re: [PATCH 4/6] hw/pci-host/sabre: Report unimplemented accesses via UNIMP log_mask

2020-10-19 Thread Mark Cave-Ayland
On 12/10/2020 18:09, Philippe Mathieu-Daudé wrote: Report unimplemented register accesses using qemu_log_mask(UNIMP). Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/sabre.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/pci-host/sabre.c b/hw/pci-h

Re: [PATCH 5/6] hw/pci-host/sabre: Report IOMMU address range as unimplemented

2020-10-19 Thread Mark Cave-Ayland
On 12/10/2020 18:09, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/sabre.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c index 4412e23131c..67699ac9058 100644 --- a/hw/pci-host/sabre.c +++ b/hw/pci-host/s

Re: [PATCH v3 34/81] target/arm: Implement SVE2 WHILERW, WHILEWR

2020-10-19 Thread Richard Henderson
On 10/12/20 7:33 PM, LIU Zhiwei wrote: >> +if (a->rw) { >> +/* WHILERW */ >> +/* diff = abs(op1 - op0), noting that op0/1 are unsigned. */ >> +t1 = tcg_temp_new_i64(); >> +tcg_gen_sub_i64(diff, op0, op1); >> +tcg_gen_sub_i64(t1, op1, op0); >> +tcg

Re: [PATCH 6/6] hw/pci-host/sabre: Log reserved address accesses as GUEST_ERROR

2020-10-19 Thread Mark Cave-Ayland
On 12/10/2020 18:09, Philippe Mathieu-Daudé wrote: Report accesses to reserved registers using qemu_log_mask(GUEST_ERROR). Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/sabre.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c inde

Re: [PATCH 0/6] hw/pci-host/sabre: Report UNIMP/GUEST_ERROR accesses

2020-10-19 Thread Mark Cave-Ayland
On 12/10/2020 18:09, Philippe Mathieu-Daudé wrote: Notes while trying to understand Mark's patch from yesterday: "sabre: increase number of PCI bus IRQs from 32 to 64" https://www.mail-archive.com/qemu-devel@nongnu.org/msg749458.html Philippe Mathieu-Daudé (6): hw/pci-host/sabre: Update docu

Re: [PATCH v2 9/9] block: check availablity for preadv/pwritev on mac

2020-10-19 Thread Joelle van Dyne
On Mon, Oct 19, 2020 at 1:27 AM Thomas Huth wrote: > > On 19/10/2020 03.39, Joelle van Dyne wrote: > > From: osy > > That "From:" line looks wrong ... could you please fix the "Author" of your > patches / your git config? osy wrote the original changes. I joined the UTM project to help bring the

Re: [PATCH v2 2/9] configure: cross-compiling without cross_prefix

2020-10-19 Thread Joelle van Dyne
Correct me if I'm wrong but wouldn't the following test still fail with --cross-prefix="" if test -n "$cross_prefix"; then ... That was my main reason for making this change. -j On Mon, Oct 19, 2020 at 4:24 AM BALATON Zoltan wrote: > > On Mon, 19 Oct 2020, Thomas Huth wrote: > > On 19/10/2020

Re: [PATCH v2 6/9] tcg: implement mirror mapped JIT for iOS

2020-10-19 Thread Joelle van Dyne
> Explicit cast may not be needed here so this could be a macro if caling it > differently helps or why don't you just use tcg_mirror_prr_rw directly > everywhere? There are quite a bit of code that depends on tcg_insn_unit * type such as *tcg_code_ptr_rw(s, code_ptr) = insn; and (tcg_code_ptr_

Re: [RFC] Don't lookup full CPU state in the indirect branch fast path on AArch64 when running in user mode.

2020-10-19 Thread Owen Anderson
On Mon, Oct 19, 2020 at 11:22 AM Richard Henderson wrote: > > (1) What qemu version are you looking at and, > (2) Do you have --enable-tcg-debug enabled? My use case is a large automated testing environment for large C++ binaries with heavy use of virtual dispatch. The binaries are generally not

[PATCH v5 0/6] migration/postcopy: Sync faulted addresses after network recovered

2020-10-19 Thread Peter Xu
This is v5 of the series. Probably my first series that got queued/unqueued twice. I found a bug in v4 that was about page sizes, however that didn't match with PeterM's report on big endian hosts. My manual reproduce on s390x also didn't reproduce. However after I ran the tree (with the fix) o

[PATCH v5 1/6] migration: Pass incoming state into qemu_ufd_copy_ioctl()

2020-10-19 Thread Peter Xu
It'll be used in follow up patches to access more fields out of it. Meanwhile fetch the userfaultfd inside the function. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- migration/postcopy-ram.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/migratio

[PATCH v5 3/6] migration: Maintain postcopy faulted addresses

2020-10-19 Thread Peter Xu
Maintain a list of faulted addresses on the destination host for which we're waiting on. This is implemented using a GTree rather than a real list to make sure even there're plenty of vCPUs/threads that are faulting, the lookup will still be fast with O(log(N)) (because we'll do that after placing

[PATCH v5 5/6] migration/postcopy: Release fd before going into 'postcopy-pause'

2020-10-19 Thread Peter Xu
Logically below race could trigger with the old code: test programmigration thread wait_until('postcopy-pause') postcopy_pause()

[PATCH v5 6/6] migration-test: Only hide error if !QTEST_LOG

2020-10-19 Thread Peter Xu
The errors are very useful when debugging qtest failures, especially when QTEST_LOG=1 is set. Let's allow override MigrateStart.hide_stderr when QTEST_LOG=1 is specified, because that means the user wants to be verbose. Not very nice to introduce the first QTEST_LOG env access in migration-test.c

[PATCH v5 4/6] migration: Sync requested pages after postcopy recovery

2020-10-19 Thread Peter Xu
We synchronize the requested pages right after a postcopy recovery happens. This helps to synchronize the prioritized pages on source so that the faulted threads can be served faster. Reported-by: Xiaohui Li Signed-off-by: Peter Xu --- migration/savevm.c | 57 +++

[PATCH v5 2/6] migration: Introduce migrate_send_rp_message_req_pages()

2020-10-19 Thread Peter Xu
This is another layer wrapper for sending a page request to the source VM. The new migrate_send_rp_message_req_pages() will be used elsewhere in coming patches. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- migration/migration.c | 10 -- migration/migration.h | 2 ++

Re: [RFC] Don't lookup full CPU state in the indirect branch fast path on AArch64 when running in user mode.

2020-10-19 Thread Richard Henderson
On 10/19/20 3:44 PM, Owen Anderson wrote: > My use case is currently using QEMU 4.0, but we will be moving to QEMU > 4.2 soon. I do not have --enable-tcg-debug enabled. > e979972a6a1 does look promising, and like it might deliver increased > performance for our use case. It looks like the code in

Re: [PATCH 0/2] tcg: optimize across branches

2020-10-19 Thread Richard Henderson
Ping. On 10/13/20 3:23 PM, Richard Henderson wrote: > In several cases, it's easy to optimize across a non-taken branch > simply by *not* flushing the relevant tables. This is true both > for value propagation and register allocation. > > This comes up in quite a number of cases with arm, most s

Re: [PATCH v2 2/4] hw/riscv: Return the end address of the loaded firmware

2020-10-19 Thread Palmer Dabbelt
On Tue, 13 Oct 2020 17:17:28 PDT (-0700), Alistair Francis wrote: Instead of returning the unused entry address from riscv_load_firmware() instead return the end address. Also return the end address from riscv_find_and_load_firmware(). This tells the caller if a firmware was loaded and how big i

Re: [PATCH v2 4/4] hw/riscv: Load the kernel after the firmware

2020-10-19 Thread Palmer Dabbelt
On Tue, 13 Oct 2020 17:17:33 PDT (-0700), Alistair Francis wrote: Instead of loading the kernel at a hardcoded start address, let's load the kernel at the next alligned address after the end of the firmware. This should have no impact for current users of OpenSBI, but will allow loading a noMMU

Re: [PATCH v2 1/4] hw/riscv: sifive_u: Allow specifying the CPU

2020-10-19 Thread Palmer Dabbelt
On Tue, 13 Oct 2020 17:17:25 PDT (-0700), Alistair Francis wrote: Allow the user to specify the main application CPU for the sifive_u machine. Signed-off-by: Alistair Francis Reviewed-by: Bin Meng --- include/hw/riscv/sifive_u.h | 1 + hw/riscv/sifive_u.c | 18 +- 2 f

Re: [PATCH v2 3/4] hw/riscv: Add a riscv_is_32_bit() function

2020-10-19 Thread Palmer Dabbelt
On Tue, 13 Oct 2020 17:17:30 PDT (-0700), Alistair Francis wrote: Signed-off-by: Alistair Francis --- include/hw/riscv/boot.h | 2 ++ hw/riscv/boot.c | 9 + 2 files changed, 11 insertions(+) diff --git a/include/hw/riscv/boot.h b/include/hw/riscv/boot.h index 0acbd8aa6e..2975ed

Re: [PATCH v2 5/9] tcg: add const hints for code pointers

2020-10-19 Thread Richard Henderson
On 10/18/20 6:39 PM, Joelle van Dyne wrote: > From: osy > > We will introduce mirror mapping for JIT segment with separate RX and RW > access. Adding 'const' hints will make it easier to identify read-only > accesses and allow us to easier catch bugs at compile time in the future. > > Signed-off

Re: [PATCH v2 5/9] tcg: add const hints for code pointers

2020-10-19 Thread Joelle van Dyne
You can --author "Joelle van Dyne " -j On Mon, Oct 19, 2020 at 4:19 PM Richard Henderson wrote: > > On 10/18/20 6:39 PM, Joelle van Dyne wrote: > > From: osy > > > > We will introduce mirror mapping for JIT segment with separate RX and RW > > access. Adding 'const' hints will make it easier to

Re: [PATCH v2 5/9] tcg: add const hints for code pointers

2020-10-19 Thread Richard Henderson
On 10/18/20 6:39 PM, Joelle van Dyne wrote: > From: osy > > We will introduce mirror mapping for JIT segment with separate RX and RW > access. Adding 'const' hints will make it easier to identify read-only > accesses and allow us to easier catch bugs at compile time in the future. > > Signed-off

Re: [PATCH v2 5/9] tcg: add const hints for code pointers

2020-10-19 Thread Joelle van Dyne
Seems like I missed a few. Sorry about that. Will fix. -j On Mon, Oct 19, 2020 at 4:27 PM Richard Henderson wrote: > > On 10/18/20 6:39 PM, Joelle van Dyne wrote: > > From: osy > > > > We will introduce mirror mapping for JIT segment with separate RX and RW > > access. Adding 'const' hints will

[PATCH 2/8] tests/9pfs: add local unlinkat directory test

2020-10-19 Thread Christian Schoenebeck
This test case uses a Tunlinkat 9p request with flag AT_REMOVEDIR (see 'man 2 unlink') to remove a directory from host's test directory. Signed-off-by: Christian Schoenebeck --- tests/qtest/virtio-9p-test.c | 72 1 file changed, 72 insertions(+) diff --git a

[PATCH 1/8] tests/9pfs: simplify fs_mkdir()

2020-10-19 Thread Christian Schoenebeck
Split out walking a directory path to a separate new utility function fs_walk_fid() and use that function in fs_mkdir(). The code difference saved this way is not much, but we'll use that new fs_walk_fid() function in the upcoming patches, so it will avoid quite some code duplication after all. S

[PATCH 5/8] tests/9pfs: add local Tsymlink test

2020-10-19 Thread Christian Schoenebeck
This test case uses a Tsymlink 9p request to create a symbolic link using the 9pfs 'local' fs driver. Signed-off-by: Christian Schoenebeck --- tests/qtest/virtio-9p-test.c | 78 1 file changed, 78 insertions(+) diff --git a/tests/qtest/virtio-9p-test.c b/tes

[PATCH 3/8] tests/9pfs: add local Tlcreate test

2020-10-19 Thread Christian Schoenebeck
This test case uses a Tlcreate 9p request to create a regular file inside host's test directory. Signed-off-by: Christian Schoenebeck --- tests/qtest/virtio-9p-test.c | 78 1 file changed, 78 insertions(+) diff --git a/tests/qtest/virtio-9p-test.c b/tests/qt

[PATCH 0/8] 9pfs: more local tests

2020-10-19 Thread Christian Schoenebeck
Just a bunch of more test case using the 9pfs 'local' fs driver backend, namely for these 9p requests: * Tunlinkat, Tlcreate, Tsymlink and Tlink. Christian Schoenebeck (8): tests/9pfs: simplify fs_mkdir() tests/9pfs: add local unlinkat directory test tests/9pfs: add local Tlcreate test te

Re: [PATCH v2 5/9] tcg: add const hints for code pointers

2020-10-19 Thread Richard Henderson
On 10/19/20 4:36 PM, Joelle van Dyne wrote: > Seems like I missed a few. Sorry about that. Will fix. I'll keep looking, Just In Case. ;-) >> s->code_gen_epilogue = tb_ret_addr = s->code_ptr; In this case, just splitting the chained assignment to two statements is sufficient to fix. r~

[PATCH 4/8] tests/9pfs: add local unlinkat file test

2020-10-19 Thread Christian Schoenebeck
This test case uses a Tunlinkat request to remove a regular file using the 9pfs 'local' fs driver. Signed-off-by: Christian Schoenebeck --- tests/qtest/virtio-9p-test.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-

[PATCH 6/8] tests/9pfs: add local unlinkat symlink test

2020-10-19 Thread Christian Schoenebeck
This test case uses a Tunlinkat request to remove a symlink using the 9pfs 'local' fs driver. Signed-off-by: Christian Schoenebeck --- tests/qtest/virtio-9p-test.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p

[PATCH 7/8] tests/9pfs: add local Tlink test

2020-10-19 Thread Christian Schoenebeck
This test case uses a Tlink request to create a hard link to a regular file using the 9pfs 'local' fs driver. Signed-off-by: Christian Schoenebeck --- tests/qtest/virtio-9p-test.c | 61 1 file changed, 61 insertions(+) diff --git a/tests/qtest/virtio-9p-test

[PATCH 8/8] tests/9pfs: add local unlinkat hard link test

2020-10-19 Thread Christian Schoenebeck
This test case uses a Tunlinkat request to remove a previously hard linked file by using the 9pfs 'local' fs driver. Signed-off-by: Christian Schoenebeck --- tests/qtest/virtio-9p-test.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/tests/qtest/virtio-9p

Re: [PATCH v2 6/9] tcg: implement mirror mapped JIT for iOS

2020-10-19 Thread BALATON Zoltan via
On Mon, 19 Oct 2020, Joelle van Dyne wrote: Explicit cast may not be needed here so this could be a macro if caling it differently helps or why don't you just use tcg_mirror_prr_rw directly everywhere? There are quite a bit of code that depends on tcg_insn_unit * type such as *tcg_code_ptr_rw(

Re: [PATCH 7/8] tests/9pfs: add local Tlink test

2020-10-19 Thread Christian Schoenebeck
On Dienstag, 20. Oktober 2020 01:13:24 CEST Christian Schoenebeck wrote: > This test case uses a Tlink request to create a hard link to a regular > file using the 9pfs 'local' fs driver. > > Signed-off-by: Christian Schoenebeck > --- > tests/qtest/virtio-9p-test.c | 61 ++

Re: [PATCH v2 6/9] tcg: implement mirror mapped JIT for iOS

2020-10-19 Thread Richard Henderson
On 10/19/20 3:39 PM, Joelle van Dyne wrote: >> Explicit cast may not be needed here so this could be a macro if caling it >> differently helps or why don't you just use tcg_mirror_prr_rw directly >> everywhere? > > There are quite a bit of code that depends on tcg_insn_unit * type such as > > *tc

Re: [PATCH v2 7/9] tcg: mirror mapping RWX pages for iOS optional

2020-10-19 Thread Richard Henderson
On 10/18/20 6:39 PM, Joelle van Dyne wrote: > From: osy > > This allows jailbroken devices with entitlements to switch the option off. > > Signed-off-by: Joelle van Dyne > --- I can guess why this performs better: half the page table entries and thus half the tlb entries required. Which for a

Question on Compression for Raw Image

2020-10-19 Thread Wang, Wei W
Hi, Does anyone know the reason why raw-format.c doesn't have compression support (but qcow has the supported added)? For example, raw image backup with compression, "qemu-img convert -c -O raw origin.img dist.img", doesn't work. Thanks, Wei

Re: [PATCH v1 0/2] Add timeout mechanism to qmp actions

2020-10-19 Thread Zhenyu Ye
On 2020/10/19 21:25, Paolo Bonzini wrote: > On 19/10/20 14:40, Zhenyu Ye wrote: >> The kernel backtrace for io_submit in GUEST is: >> >> guest# ./offcputime -K -p `pgrep -nx fio` >> b'finish_task_switch' >> b'__schedule' >> b'schedule' >> b'io_schedule' >>

Re: [PATCH V14 1/8] target/mips: Fix PageMask with variable page size

2020-10-19 Thread Huacai Chen
Hi, Philippe, On Fri, Oct 16, 2020 at 11:15 PM Philippe Mathieu-Daudé wrote: > > On 10/16/20 8:51 AM, Huacai Chen wrote: > > From: Jiaxun Yang > > > > Our current code assumed the target page size is always 4k > > when handling PageMask and VPN2, however, variable page size > > was just added to

Re: [PATCH v2 0/5] memory: Skip assertion in memory_region_unregister_iommu_notifier

2020-10-19 Thread Jason Wang
On 2020/10/19 下午6:42, Eugenio Pérez wrote: I am able to hit this assertion when a Red Hat 7 guest virtio_net device raises an "Invalidation" of all the TLB entries. This happens in the guest's startup if 'intel_iommu=on' argument is passed to the guest kernel and right IOMMU/ATS devices are dec

Re: [PATCH V14 6/8] hw/mips: Add Loongson-3 boot parameter helpers

2020-10-19 Thread Huacai Chen
Hi, Philippe, On Fri, Oct 16, 2020 at 10:24 PM Philippe Mathieu-Daudé wrote: > > Hi Huacai, > > On 10/16/20 8:51 AM, Huacai Chen wrote: > > Preparing to add Loongson-3 machine support, add Loongson-3's LEFI (a > > UEFI-like interface for BIOS-Kernel boot parameters) helpers first. > > > > Signed-

[PATCH v2 1/6] vhost-user-gpu: fix incorrect print type

2020-10-19 Thread Zhengui li
The type of input variable is unsigned int while the printer type is int. So fix incorrect print type. Signed-off-by: Zhengui li --- contrib/vhost-user-gpu/vhost-user-gpu.c | 34 - 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/contrib/vhost-user-

[PATCH v2 3/6] vhost-user: fix incorrect print type

2020-10-19 Thread Zhengui li
The type of input variable is unsigned int while the printer type is int. So fix incorrect print type. Signed-off-by: Zhengui li --- hw/virtio/vhost-user.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 9c5b4f7

[PATCH v2 2/6] vhost-user-scsi: fix incorrect print type

2020-10-19 Thread Zhengui li
The type of input variable is unsigned int while the printer type is int. So fix incorrect print type. Signed-off-by: Zhengui li --- contrib/vhost-user-scsi/vhost-user-scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/vhost-user-scsi/vhost-user-scsi.c b/contrib/

[PATCH v2 6/6] vfio: fix incorrect print type

2020-10-19 Thread Zhengui li
The type of input variable is unsigned int while the printer type is int. So fix incorrect print type. Signed-off-by: Zhengui li --- hw/vfio/common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 13471ae..acc3356 100644 --- a/hw

[PATCH v2 5/6] virtio-iommu: fix incorrect print type

2020-10-19 Thread Zhengui li
The type of input variable is unsigned int while the printer type is int. So fix incorrect print type. Signed-off-by: Zhengui li --- hw/virtio/virtio-iommu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c index 21ec63

[PATCH v2 4/6] virtio-gpu: fix incorrect print type

2020-10-19 Thread Zhengui li
The type of input variable is unsigned int while the printer type is int. So fix incorrect print type. Signed-off-by: Zhengui li --- hw/display/virtio-gpu.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/hw/display/virtio-gpu.c b/hw/display

Re: [RFC PATCH v7 2/2] hw/misc/sifive_u_otp: Add backend drive support

2020-10-19 Thread Green Wan
Sorry for replying late. I missed this email. I will revise the patch today. Thanks, - Green On Thu, Oct 15, 2020 at 4:01 PM Bin Meng wrote: > > On Thu, Oct 15, 2020 at 12:15 PM Green Wan wrote: > > > > Add '-drive' support to OTP device. Allow users to assign a raw file > > as OTP image. > > >

Re: [PATCH v2 3/8] migration: Add spaces around operator

2020-10-19 Thread Bihong Yu
OK, I will change it to "VMStateDescription *[]". Thank you for your review. On 2020/10/19 19:59, Markus Armbruster wrote: > Bihong Yu writes: > >> Yes, I used to think "const VMStateDescription *[]" was right, but when I >> search >> similar expressions, most of all are "xxx * []". Such as: >>

Re: [RFC PATCH 00/12] hw/arm/virt: Introduce cpu and cache topology support

2020-10-19 Thread Ying Fang
On 10/16/2020 6:07 PM, Andrew Jones wrote: On Fri, Oct 16, 2020 at 05:40:02PM +0800, Ying Fang wrote: On 10/15/2020 3:59 PM, Andrew Jones wrote: On Thu, Oct 15, 2020 at 10:07:16AM +0800, Ying Fang wrote: On 10/14/2020 2:08 AM, Andrew Jones wrote: On Tue, Oct 13, 2020 at 12:11:20PM +000

Re: [PATCH v2] Adding ani's email as an individual contributor

2020-10-19 Thread Ani Sinha
more ping ... On Thu, Oct 15, 2020 at 8:22 PM Ani Sinha wrote: > Ping ... > > On Mon, Oct 12, 2020 at 8:27 PM Ani Sinha wrote: > > > > Request to queue this patch for the next pull. > > > > On Wed, Oct 7, 2020 at 23:25 Philippe Mathieu-Daudé > wrote: > >> > >> On 10/7/20 6:19 PM, Ani Sinha wro

[PATCH v3 1/8] migration: Do not use C99 // comments

2020-10-19 Thread Bihong Yu
Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert --- migration/block.c | 2 +- migration/rdma.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/block.c b/migration/block.c index 737b649..4b8576b 100644 --- a/migration/block.

[PATCH v3 0/8] Fix some style problems in migration

2020-10-19 Thread Bihong Yu
Recently I am reading migration related code, find some style problems in migration directory while using checkpatch.pl to check migration code. Fix the error style problems. v2: - fix Signed-off-by error - fix printf format error: "%0x" -> "0x%x" v3: - change "VMStateDescription * []" to "VMStat

[PATCH v3 6/8] migration: Do not initialise statics and globals to 0 or NULL

2020-10-19 Thread Bihong Yu
Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c| 2 +- migration/savevm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 09178cc..2da2b62 100644 --- a/migration/ram.c ++

[PATCH v3 4/8] migration: Open brace '{' following struct go on the same line

2020-10-19 Thread Bihong Yu
Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert --- migration/migration.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/migration/migration.h b/migration/migration.h index deb411a..99784b4 100644 --- a/migration/migration.h +++ b/mig

[PATCH v3 3/8] migration: Add spaces around operator

2020-10-19 Thread Bihong Yu
Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert --- migration/migration.c| 4 ++-- migration/postcopy-ram.c | 2 +- migration/ram.c | 2 +- migration/savevm.c | 2 +- migration/vmstate.c | 10 +- 5 files changed, 10 inser

[PATCH v3 7/8] migration: Open brace '{' following function declarations go on the next line

2020-10-19 Thread Bihong Yu
Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert --- migration/rdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c index 0eb42b7..ca4d315 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -27

Re: [PATCH v2 1/4] hw/riscv: sifive_u: Allow specifying the CPU

2020-10-19 Thread Bin Meng
On Wed, Oct 14, 2020 at 8:28 AM Alistair Francis wrote: > > Allow the user to specify the main application CPU for the sifive_u > machine. > > Signed-off-by: Alistair Francis > Reviewed-by: Bin Meng > --- > include/hw/riscv/sifive_u.h | 1 + > hw/riscv/sifive_u.c | 18 +

[PATCH v3 5/8] migration: Add braces {} for if statement

2020-10-19 Thread Bihong Yu
Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 0aea78f..09178cc 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -101

[PATCH v3 2/8] migration: Don't use '#' flag of printf format

2020-10-19 Thread Bihong Yu
Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert --- migration/block.c | 2 +- migration/ram.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/migration/block.c b/migration/block.c index 4b8576b..273392b 100644 --- a/migration/bloc

Re: [PATCH v2 3/4] hw/riscv: Add a riscv_is_32_bit() function

2020-10-19 Thread Bin Meng
On Wed, Oct 14, 2020 at 8:28 AM Alistair Francis wrote: > > Signed-off-by: Alistair Francis > --- > include/hw/riscv/boot.h | 2 ++ > hw/riscv/boot.c | 9 + > 2 files changed, 11 insertions(+) > Reviewed-by: Bin Meng Tested-by: Bin Meng

[PATCH v3 8/8] migration: Delete redundant spaces

2020-10-19 Thread Bihong Yu
Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert --- migration/rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c index ca4d315..00eac34 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -855,

Re: [PATCH v2 2/4] hw/riscv: Return the end address of the loaded firmware

2020-10-19 Thread Bin Meng
On Wed, Oct 14, 2020 at 8:28 AM Alistair Francis wrote: > > Instead of returning the unused entry address from riscv_load_firmware() > instead return the end address. Also return the end address from > riscv_find_and_load_firmware(). > > This tells the caller if a firmware was loaded and how big i

Re: [PATCH v2 4/4] hw/riscv: Load the kernel after the firmware

2020-10-19 Thread Bin Meng
On Wed, Oct 14, 2020 at 8:28 AM Alistair Francis wrote: > > Instead of loading the kernel at a hardcoded start address, let's load > the kernel at the next alligned address after the end of the firmware. typo of "aligned" > > This should have no impact for current users of OpenSBI, but will > al

Re: [PATCH v3 0/8] Fix some style problems in migration

2020-10-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1603163448-27122-1-git-send-email-yubih...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1603163448-27122-1-git-send-email-yubih...@huawei.com Subject: [PATCH v3 0/8]

[PATCH v8 0/2] Add file-backed and write-once features to OTP

2020-10-19 Thread Green Wan
patch [1/2] - add write function and wrire-once feature patch [2/2] - add file backend support Test Steps: (should work even only 1/2 is applied) 1) Follow instructions to prepare fw_payload - https://github.com/riscv/opensbi/blob/master/docs/platform/sifive_fu540.md a) build 1-round opensbi

[PATCH v8 2/2] hw/misc/sifive_u_otp: Add backend drive support

2020-10-19 Thread Green Wan
Add '-drive' support to OTP device. Allow users to assign a raw file as OTP image. test commands for 16k otp.img filled with zero: $ dd if=/dev/zero of=./otp.img bs=1k count=16 $ ./qemu-system-riscv64 -M sifive_u -m 256M -nographic -bios none \ -kernel ../opensbi/build/platform/sifive/fu540/firmw

[PATCH v8 1/2] hw/misc/sifive_u_otp: Add write function and write-once protection

2020-10-19 Thread Green Wan
- Add write operation to update fuse data bit when PWE bit is on. - Add array, fuse_wo, to store the 'written' status for all bits of OTP to block the write operation. Signed-off-by: Green Wan Reviewed-by: Alistair Francis Reviewed-by: Bin Meng Tested-by: Bin Meng --- hw/misc/sifive_u_ot

[Bug 1889411] Re: RISC-V: Unable to unwind the stack upon signals

2020-10-19 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1889411 Title: RISC-V: Una

Re: [PATCH v2 2/9] configure: cross-compiling without cross_prefix

2020-10-19 Thread Thomas Huth
On 20/10/2020 00.24, Joelle van Dyne wrote: > Correct me if I'm wrong but wouldn't the following test still fail > with --cross-prefix="" > > if test -n "$cross_prefix"; then > ... > > That was my main reason for making this change. That's why I wrote "still introduce the cross_compile=yes varia

Re: [PATCH v6 02/10] migration: stop returning errno from load_snapshot()

2020-10-19 Thread Markus Armbruster
Eric Blake writes: > On 10/8/20 10:49 AM, Daniel P. Berrangé wrote: >> None of the callers care about the errno value since there is a full >> Error object populated. This gives consistency with save_snapshot() >> which already just returns -1. >> Reviewed-by: Dr. David Alan Gilbert >> Signed-of

Re: [PATCH v6 04/10] block: allow specifying name of block device for vmstate storage

2020-10-19 Thread Markus Armbruster
Eric Blake writes: > On 10/8/20 10:49 AM, Daniel P. Berrangé wrote: >> Currently the vmstate will be stored in the first block device that >> supports snapshots. Historically this would have usually been the >> root device, but with UEFI it might be the variable store. There >> needs to be a way

Re: [PATCH v2 9/9] block: check availablity for preadv/pwritev on mac

2020-10-19 Thread Thomas Huth
On 20/10/2020 00.20, Joelle van Dyne wrote: > On Mon, Oct 19, 2020 at 1:27 AM Thomas Huth wrote: >> >> On 19/10/2020 03.39, Joelle van Dyne wrote: >>> From: osy >> >> That "From:" line looks wrong ... could you please fix the "Author" of your >> patches / your git config? > osy wrote the original

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-19 Thread Markus Armbruster
Mark Cave-Ayland writes: > One thing I have thought about is being able to mark a link property > as mandatory so if a value hasn't been set before realize then you A non-null value, I presume. > receive a fatal error. This would be for cases like this where 2 > internal devices are connected t

<    1   2   3   4   5   >