Eric Blake <ebl...@redhat.com> writes: > On 10/8/20 10:49 AM, Daniel P. Berrangé wrote: >> Currently the vmstate will be stored in the first block device that >> supports snapshots. Historically this would have usually been the >> root device, but with UEFI it might be the variable store. There >> needs to be a way to override the choice of block device to store >> the state in. >> Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> >> --- > >> @@ -83,7 +83,7 @@ QEMU X.Y.Z monitor - type 'help' for more information >> (qemu) savevm snap0 >> Error: Device 'file' is writable but does not support snapshots >> (qemu) info snapshots >> -No block device supports snapshots >> +no block device can store vmstate for snapshot > > We're inconsistent on whether error messages start with a Capital.
Pervasive issue. Starting with lower case plays more nicely with error_prepend(). > But our split-brain behavior is not made any worse by this patch. > > Reviewed-by: Eric Blake <ebl...@redhat.com>
