OK, I will change it to "VMStateDescription *[]". Thank you for your review.
On 2020/10/19 19:59, Markus Armbruster wrote: > Bihong Yu <yubih...@huawei.com> writes: > >> Yes, I used to think "const VMStateDescription *[]" was right, but when I >> search >> similar expressions, most of all are "xxx * []". Such as: >> fsdev/qemu-fsdev.c:54: .opts = (const char * []) >> hw/intc/s390_flic_kvm.c:567: .subsections = (const VMStateDescription * >> []) >> ... > > All three variations occur in the code: no space, space on both sides, > space only on the left. > >> So, I keep the same style. Should I change it to "const VMStateDescription >> *[]"? > > Dropping the change to savevm.c should be fine. > > Changing it to "VMStateDescription *[]" should be also fine. > > I figure you can keep David's R-by in both cases. > > [...] > > . >
