Re: acceptance-system-fedora failures

On 10/7/20 7:20 AM, Philippe Mathieu-Daudé wrote: > On 10/7/20 1:07 AM, John Snow wrote: >> I'm seeing this gitlab test fail quite often in my Python work; I don't >> *think* this has anything to do with my patches, but maybe I need to try >> and bisect this more aggressively. >> >> The very first

Re: [PATCH] meson.build: drop duplicate 'sparc64' entry

On Wed, Oct 7, 2020 at 3:06 AM Sergei Trofimovich wrote: > > Signed-off-by: Sergei Trofimovich > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index a02c743794..48e7c56cc1 100644 > --- a/meson.build > +++ b/meson.build > @@

Re: acceptance-system-fedora failures

On 07/10/2020 07.20, Philippe Mathieu-Daudé wrote: > On 10/7/20 1:07 AM, John Snow wrote: >> I'm seeing this gitlab test fail quite often in my Python work; I don't >> *think* this has anything to do with my patches, but maybe I need to try >> and bisect this more aggressively. [...] > w.r.t. the e

Re: [PATCH v2 1/6] spapr/xive: Introduce a StoreEOI capability

On Wed, 7 Oct 2020 07:59:26 +0200 Cédric Le Goater wrote: > > > On 10/6/20 6:42 PM, Greg Kurz wrote: > > On Mon, 5 Oct 2020 18:51:42 +0200 > > Cédric Le Goater wrote: > > > >> When an interrupt has been handled, the OS notifies the interrupt > >> controller with an EOI sequence. On the XIVE i

Re: [PATCH v5 02/36] qapi: modify docstrings to be sphinx-compatible

John Snow writes: > On 10/6/20 7:21 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> A precise style guide and a package-wide overhaul is forthcoming pending >>> further discussion and consensus. At present, we are avoiding obvious >>> errors that cause sphinx documentation build proble

Re: [PATCH v2 5/6] spapr/xive: Activate StoreEOI at the source level

On Tue, 6 Oct 2020 19:41:28 +0200 Cédric Le Goater wrote: > On 10/6/20 7:06 PM, Greg Kurz wrote: > > On Mon, 5 Oct 2020 18:51:46 +0200 > > Cédric Le Goater wrote: > > > >> When the StoreEOI capability is "on", the H_INT_GET_SOURCE_INFO will > >> set the StoreEOI flag for all sources. This could

Re: Emulate Rpi with QEMU fails

Hi, I already considered the host CPU power. However I have this CPU Intel Core 2 Quad Q9550 2,83 GHz and assumed this should be powerful enough for RPi emulation

Re: [PATCH v2 1/9] s390x/pci: Move header files to include/hw/s390x

On 06/10/20 19:33, Richard Henderson wrote: > On 10/6/20 11:43 AM, Matthew Rosato wrote: >>> Looks good, but... >>> >>> Is there any way to coax out a more reviewable version of this >>> via git mv? >>> >> >> I tried git mv, but a diff between the old patch and the new patch looks the >> same (othe

Re: [PATCH] qom: fix objects with improper parent type

On 06/10/20 21:20, snizovt...@gmail.com wrote: > On Tue, 2020-10-06 at 01:55 -0400, Michael S. Tsirkin wrote: >> On Tue, Sep 29, 2020 at 04:47:14PM -0700, Sergey Nizovtsev wrote: >>> Some objects accidentally inherit ObjectClass instead of Object. >>> They compile silently but may crash after downc

Re: [PATCH v2] hw/pci/pci: Fix slot check for plugged devices

On Tue, Oct 06, 2020 at 02:59:08PM +0200, Julia Suvorova wrote: > If devfn is assigned automatically, 'else' clauses will never be > executed. And if it does not matter for the reserved and available > devfn, because we have already checked it, the check for function0 > needs to be done again. > >

[PATCH v3 0/3] qga: add command guest-get-disks

Adds command to list disks of the VM. The patch does compile on master but to work properly it requires changes to qemu-ga by Thomas Huth in series: Allow guest-get-fsinfo also for non-PCI devices. v3: - renamed "slaves" field to "dependents" - comments from Marc and Daniel - 2/3: factored out pi

[PATCH v3 2/3] qga: add implementation of guest-get-disks for Linux

The command lists all disks (real and virtual) as well as disk partitions. For each disk the list of dependent disks is also listed and /dev path is used as a handle so it can be matched with "name" field of other returned disk entries. For disk partitions the "dependents" list is populated with th

[PATCH v3 1/3] qga: add command guest-get-disks

Add API and stubs for new guest-get-disks command. The command guest-get-fsinfo can be used to list information about disks and partitions but it is limited only to mounted disks with filesystem. This new command should allow listing information about disks of the VM regardles whether they are mou

[PATCH v3 3/3] qga: add implementation of guest-get-disks for Windows

The command lists all the physical disk drives. Unlike for Linux partitions and virtual volumes are not listed. Example output: { "return": [ { "name": ".\\PhysicalDrive0", "partition": false, "address": { "serial": "QM1", "bus-type": "sata",

Re: [PATCH v4 0/4] Introducing QMP query-netdev command

ping http://patchwork.ozlabs.org/project/qemu-devel/list/?series=203284 21.09.2020, 22:19, "Alexey Kirillov" : > This patch series introduces a new QMP command "query-netdev" to get > information about currently attached backend network devices (netdevs). > Also, since the "info_str" field of "Ne

[PATCH 2/2] docs/devel: update instruction on how to add new unit tests

The instructions for adding new unit tests were not in build-system.rst and therefore I missed them in the Meson conversion. Just like with the Makefile code there are some magic variables to be aware of, so document them. Signed-off-by: Paolo Bonzini --- docs/devel/qtest.rst | 30 +++

[PATCH 0/2] simplify tests/qtest/meson.build and update docs

The instructions for adding new unit tests were not in build-system.rst and therefore I missed them in the Meson conversion. Patch 2 updates them; before that, however, patch 1 applies the same trick to qtests that was used to simplify the unit tests conversion. Paolo Bonzini (2): qtest: unify

Re: [PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

John Snow writes: > On 10/6/20 7:51 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> This is a minor re-work of the entrypoint script. It isolates a >>> generate() method from the actual command-line mechanism. >>> >>> Signed-off-by: John Snow >>> Reviewed-by: Eduardo Habkost >>> Revi

[PATCH 1/2] qtest: unify extra_qtest_srcs and extra_qtest_deps

Currently the extra sources and extra dependencies of qtests are held in two separate dictionaries. Use the same trick as tests/meson.build to combine them into one. This will make it easier to update the documentation for unit tests and qtests. Signed-off-by: Paolo Bonzini --- tests/qtest/mes

Re: [PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

John Snow writes: > This is a minor re-work of the entrypoint script. It isolates a > generate() method from the actual command-line mechanism. > > Signed-off-by: John Snow > Reviewed-by: Eduardo Habkost > Reviewed-by: Cleber Rosa > Tested-by: Cleber Rosa > --- > scripts/qapi-gen.py | 85 +++

Re: [PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

I keep stumbling over things in later patches that turn out to go back to this one. John Snow writes: > This is a minor re-work of the entrypoint script. It isolates a > generate() method from the actual command-line mechanism. > > Signed-off-by: John Snow > Reviewed-by: Eduardo Habkost > Revi

Re: [PATCH v3 2/3] qga: add implementation of guest-get-disks for Linux

On Wed, Oct 7, 2020 at 11:46 AM Tomáš Golembiovský wrote: > The command lists all disks (real and virtual) as well as disk > partitions. For each disk the list of dependent disks is also listed and > /dev path is used as a handle so it can be matched with "name" field of > other returned disk ent

Re: [PATCH v5 07/36] qapi: enforce import order/styling with isort

John Snow writes: > While we're mucking around with imports, we might as well formalize the > style we use. Let's use isort to do it for us. > > lines_after_imports=2: Use two lines after imports, to match PEP8's > desire to have "two lines before and after" class definitions, which are > likely

Re: [PULL 00/21] machine + QOM queue, 2020-10-05

On Tue, Oct 06, 2020 at 08:47:29PM +0200, Thomas Huth wrote: > On 06/10/2020 16.42, Daniel P. Berrangé wrote: > > On Tue, Oct 06, 2020 at 03:38:56PM +0100, Peter Maydell wrote: > > > On Tue, 6 Oct 2020 at 15:36, Eduardo Habkost wrote: > > > > > > > > On Tue, Oct 06, 2020 at 03:03:57PM +0100, Pete

Re: [PATCH v5 08/36] qapi: delint using flake8

John Snow writes: > Petty style guide fixes and line length enforcement. Not a big win, not > a big loss, but flake8 passes 100% on the qapi module, which gives us an > easy baseline to enforce hereafter. > > A note on the flake8 exception: flake8 will warn on *any* bare except, > but pylint's i

Re: acceptance-system-fedora failures

On 10/7/20 9:23 AM, Thomas Huth wrote: > On 07/10/2020 07.20, Philippe Mathieu-Daudé wrote: >> On 10/7/20 1:07 AM, John Snow wrote: >>> I'm seeing this gitlab test fail quite often in my Python work; I don't >>> *think* this has anything to do with my patches, but maybe I need to try >>> and bisect

Re: [PATCH v3 3/3] qga: add implementation of guest-get-disks for Windows

Hi On Wed, Oct 7, 2020 at 11:46 AM Tomáš Golembiovský wrote: > The command lists all the physical disk drives. Unlike for Linux > partitions and virtual volumes are not listed. > > Example output: > > { > "return": [ > { > "name": ".\\PhysicalDrive0", > "partition": false,

Re: [PATCH v3 2/3] cirrus: Fixing and speedup the msys2/mingw CI

On 07/10/20 05:51, Yonggang Luo wrote: > Using a prepared > https://github.com/lygstate/qemu/releases/download/v5.1.0/msys2-x86_64.tar.xz > for speed up the msys2/mingw prepare speed on the cirrus CI. > This file are generated by the msys2.docker The speedup is nice, but we need to be able to reg

Re: acceptance-system-fedora failures

On 07/10/2020 09.13, Philippe Mathieu-Daudé wrote: > On 10/7/20 7:20 AM, Philippe Mathieu-Daudé wrote: >> On 10/7/20 1:07 AM, John Snow wrote: >>> I'm seeing this gitlab test fail quite often in my Python work; I don't >>> *think* this has anything to do with my patches, but maybe I need to try >>>

Re: [PATCH 2/2] cirrus: Fixing and speedup the msys2/mingw CI

These kind of changes are not appropriate for QEMU trivial. On Wed, Oct 07, 2020 at 10:41:35AM +0800, Yonggang Luo wrote: > Using a prepared > https://github.com/lygstate/qemu/releases/download/v5.1.0/msys2-x86_64.tar.xz > for speed up the msys2/mingw prepare speed on the cirrus CI. I appreciate

Re: [PATCH v3 2/3] cirrus: Fixing and speedup the msys2/mingw CI

On Wed, Oct 07, 2020 at 10:18:48AM +0200, Paolo Bonzini wrote: > On 07/10/20 05:51, Yonggang Luo wrote: > > Using a prepared > > https://github.com/lygstate/qemu/releases/download/v5.1.0/msys2-x86_64.tar.xz > > for speed up the msys2/mingw prepare speed on the cirrus CI. > > This file are generate

[PATCH V13 0/9] mips: Add Loongson-3 machine support

Loongson-3 CPU family include Loongson-3A R1/R2/R3/R4 and Loongson-3B R1/R2. Loongson-3A R1 is the oldest and its ISA is the smallest, while Loongson-3A R4 is the newest and its ISA is almost the superset of all others. To reduce complexity, in QEMU we just define two CPU types: 1, "Loongson-3A100

[PATCH V13 1/9] linux-headers: Update MIPS KVM type defintition

Update MIPS KVM type defintition from Linux 5.9-rc6. Signed-off-by: Huacai Chen --- linux-headers/linux/kvm.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index 6683e2e..c138b2f 100644 --- a/linux-headers/linux/kvm

[PATCH V13 2/9] meson.build: Re-enable KVM support for MIPS

After converting from configure to meson, KVM support is lost for MIPS, so re-enable it in meson.build. Fixes: fdb75aeff7c212e1afaaa3a43 ("configure: remove target configuration") Fixes: 8a19980e3fc42239aae054bc9 ("configure: move accelerator logic to meson") Cc: aolo Bonzini Signed-off-by: Huaca

Re: [PATCH v3 2/3] cirrus: Fixing and speedup the msys2/mingw CI

On 07/10/2020 10.18, Paolo Bonzini wrote: [...] > > On top of this, whoever commits this needs to replace the URL with > something under download.qemu.org, but that's the easy part. I agree with Daniel - please let's not get go this way again. We've had this with the various Free-/Net-/OpenBSD im

[PATCH V13 5/9] target/mips: Add loongson-ext lswc2 group of instructions (Part 2)

From: Jiaxun Yang LWC2 & SWC2 have been rewritten by Loongson EXT vendor ASE as "load/store quad word" and "shifted load/store" groups of instructions. This patch add implementation of these instructions: gslwlc1: similar to lwl but RT is FPR instead of GPR gslwrc1: similar to lwr but RT is FPR

[PATCH V13 3/9] target/mips: Fix PageMask with variable page size

From: Jiaxun Yang Our current code assumed the target page size is always 4k when handling PageMask and VPN2, however, variable page size was just added to mips target and that's no longer true. Fixes: ee3863b9d414 ("target/mips: Support variable page size") Signed-off-by: Huacai Chen Signed-of

[PATCH V13 6/9] target/mips: Add loongson-ext lsdc2 group of instructions

From: Jiaxun Yang LDC2/SDC2 opcodes have been rewritten as "load & store with offset" group of instructions by loongson-ext ASE. This patch add implementation of these instructions: gslbx: load 1 bytes to GPR gslhx: load 2 bytes to GPR gslwx: load 4 bytes to GPR gsldx: load 8 bytes to GPR gslwxc

[PATCH V13 4/9] target/mips: Add loongson-ext lswc2 group of instructions (Part 1)

From: Jiaxun Yang LWC2 & SWC2 have been rewritten by Loongson EXT vendor ASE as "load/store quad word" and "shifted load/store" groups of instructions. This patch add implementation of these instructions: gslq: load 16 bytes to GPR gssq: store 16 bytes from GPR gslqc1: load 16 bytes to FPR gssqc

[PATCH V13 8/9] hw/mips: Add Loongson-3 machine support

Add Loongson-3 based machine support, it use liointc as the interrupt controler and use GPEX as the pci controller. Currently it can work with both TCG and KVM. As the machine model is not based on any exiting physical hardware, the name of the machine is "loongson3-virt". It may be superseded in

[PATCH V13 7/9] hw/mips: Implement fw_cfg_arch_key_name()

Implement fw_cfg_arch_key_name(), which returns the name of a mips-specific key. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Huacai Chen Co-developed-by: Jiaxun Yang --- hw/mips/fw_cfg.c| 35 +++ hw/mips/fw_cfg.h| 19 +++ hw/mips/m

[PATCH V13 9/9] docs/system: Update MIPS machine documentation

Add Loongson-3A CPU models and Loongson-3 based machine description. Signed-off-by: Huacai Chen --- docs/system/cpu-models-mips.rst.inc | 10 -- docs/system/target-mips.rst | 10 ++ 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/docs/system/cpu-models-mip

Re: [PATCH v5 11/36] qapi/common.py: Add indent manager

John Snow writes: > Code style tools really dislike the use of global keywords, because it > generally involves re-binding the name at runtime which can have strange > effects depending on when and how that global name is referenced in > other modules. > > Make a little indent level manager inste

Re: [PATCH V13 2/9] meson.build: Re-enable KVM support for MIPS

On 07/10/20 10:39, Huacai Chen wrote: > After converting from configure to meson, KVM support is lost for MIPS, > so re-enable it in meson.build. > > Fixes: fdb75aeff7c212e1afaaa3a43 ("configure: remove target configuration") > Fixes: 8a19980e3fc42239aae054bc9 ("configure: move accelerator logic t

Re: acceptance-system-fedora failures

On 07.10.2020 11:23, Thomas Huth wrote: On 07/10/2020 09.13, Philippe Mathieu-Daudé wrote: On 10/7/20 7:20 AM, Philippe Mathieu-Daudé wrote: On 10/7/20 1:07 AM, John Snow wrote: I'm seeing this gitlab test fail quite often in my Python work; I don't *think* this has anything to do with my patc

Re: [PATCH v3 2/3] cirrus: Fixing and speedup the msys2/mingw CI

On Wed, Oct 7, 2020 at 4:41 PM Thomas Huth wrote: > > On 07/10/2020 10.18, Paolo Bonzini wrote: > [...] > > > > On top of this, whoever commits this needs to replace the URL with > > something under download.qemu.org, but that's the easy part. > > I agree with Daniel - please let's not get go this

Re: [PATCH v2 3/6] spapr/xive: Add a warning when StoreEOI is activated on POWER9 CPUs

On Tue, 6 Oct 2020 19:03:28 +0200 Cédric Le Goater wrote: > On 10/6/20 6:58 PM, Greg Kurz wrote: > > On Mon, 5 Oct 2020 18:51:44 +0200 > > Cédric Le Goater wrote: > > > >> StoreEOI on POWER9 CPUs is racy because load-after-store ordering is > >> not enforced. > >> > >> Signed-off-by: Cédric Le

Re: [PATCH v5 15/36] qapi/common.py: add type hint annotations

John Snow writes: > Annotations do not change runtime behavior. > This commit *only* adds annotations. > > Signed-off-by: John Snow > Reviewed-by: Eduardo Habkost > Reviewed-by: Cleber Rosa > --- > scripts/qapi/common.py | 27 --- > 1 file changed, 16 insertions(+), 11

Re: [PULL 00/21] machine + QOM queue, 2020-10-05

On Tue, Oct 06, 2020 at 09:10:59PM +0200, Paolo Bonzini wrote: > Il mar 6 ott 2020, 20:47 Thomas Huth ha scritto: > > > I think Cirrus-CI needs a github account? Is there a way to use Gitlab now > > instead? (just like Travis recently added Gitlab support?) > > > > It does only support GitHub. I

Re: [PATCH v5 16/36] qapi/common.py: Convert comments into docstrings, and elaborate

John Snow writes: > As docstrings, they'll show up in documentation and IDE help. > > The docstring style being targeted is the Sphinx documentation > style. Sphinx uses an extension of ReST with "domains". We use the > (implicit) Python domain, which supports a number of custom "info > fields".

[PATCH] configure: add option for virtiofsd

Currently it is unknown whether virtiofsd will be built at configuration time. It will be automatically built when dependency is met. Also, required libraries are not clear. To make this clear, add configure option --{enable,disable}-virtiofsd. The default is the same as current (enabled if availa

Re: [PATCH v2 3/6] spapr/xive: Add a warning when StoreEOI is activated on POWER9 CPUs

On 10/7/20 10:56 AM, Greg Kurz wrote: > On Tue, 6 Oct 2020 19:03:28 +0200 > Cédric Le Goater wrote: > >> On 10/6/20 6:58 PM, Greg Kurz wrote: >>> On Mon, 5 Oct 2020 18:51:44 +0200 >>> Cédric Le Goater wrote: >>> StoreEOI on POWER9 CPUs is racy because load-after-store ordering is not e

Re: [PATCH v5 17/36] qapi/common.py: move build_params into gen.py

John Snow writes: > Including it in common.py creates a circular import dependency; schema > relies on common, but common.build_params requires a type annotation > from schema. To type this properly, it needs to be moved outside the > cycle. > > Signed-off-by: John Snow > Reviewed-by: Eduardo Ha

Re: [PATCH v5 18/36] qapi: establish mypy type-checking baseline

John Snow writes: > Fix two very minor issues, What are the two issues? I'm asking because I can see only one. >and then establish a mypy type-checking > baseline. Any particular reason this can't go before PATCH 15 "qapi/common.py: add type hint annotations". > L

Re: [PULL 19/33] mips/cps: Use start-powered-off CPUState property

David Gibson writes: > From: Thiago Jung Bauermann > > Instead of setting CPUState::halted to 1 in main_cpu_reset(), use the > start-powered-off property which makes cpu_common_reset() initialize it > to 1 in common code. > > Also change creation of CPU object from cpu_create() to object_new()

Re: [PATCH 03/20] python/machine.py: reorder __init__

Am 07.10.2020 um 01:58 hat John Snow geschrieben: > Put the init arg handling all at the top, and mostly in order (deviating > when one is dependent on another), and put what is effectively runtime > state declaration at the bottom. > > Signed-off-by: John Snow > --- > python/qemu/machine.py | 4

Re: [PATCH 01/20] python/qemu: use isort to lay out imports

Am 07.10.2020 um 01:57 hat John Snow geschrieben: > Borrowed from the QAPI cleanup series, use the same configuration to > standardize the way we write and sort imports. > > Signed-off-by: John Snow Reviewed-by: Kevin Wolf

Re: [PATCH 07/20] python/machine.py: Add _qmp access shim

Am 07.10.2020 um 01:58 hat John Snow geschrieben: > Like many other Optional[] types, it's not always a given that this > object will be set. Wrap it in a type-shim that raises a meaningful > error and will always return a concrete type. > > Signed-off-by: John Snow > @@ -515,11 +515,13 @@ def s

Re: acceptance-system-fedora failures

On 10/7/20 10:51 AM, Pavel Dovgalyuk wrote: > On 07.10.2020 11:23, Thomas Huth wrote: >> On 07/10/2020 09.13, Philippe Mathieu-Daudé wrote: >>> On 10/7/20 7:20 AM, Philippe Mathieu-Daudé wrote: On 10/7/20 1:07 AM, John Snow wrote: > I'm seeing this gitlab test fail quite often in my Python

Re: [PATCH v10 6/9] copy-on-read: skip non-guest reads if no copy needed

29.09.2020 15:38, Andrey Shinkevich wrote: If the flag BDRV_REQ_PREFETCH was set, pass it further to the COR-driver to skip unneeded reading. It can be taken into account for the COR-algorithms optimization. That check is being made during the block stream job by the moment. Signed-off-by: Andre

Re: [PATCH 08/20] python/machine.py: fix _popen access

Am 07.10.2020 um 01:58 hat John Snow geschrieben: > As always, Optional[T] causes problems with unchecked access. Add a > helper that asserts the pipe is present before we attempt to talk with > it. > > Signed-off-by: John Snow First a question about the preexisting state: I see that after initi

[PATCH v2 2/2] hw/arm/sbsa-ref : allocate IRQs for SMMUv3

Original commit did not allocate IRQs for the SMMUv3 in the irqmap effectively using irq 0->3 (shared with other devices). Assuming original intent was to allocate unique IRQs then add an allocation to the irqmap. Fixes: e9fdf453240 ("hw/arm: Add arm SBSA reference machine, devices part") Reviewed

[PATCH v2 0/2] hw/arm/sbsa-ref : small fixes to smmuv3 initialisation

Fix two issues with the smmuv3 initialisation, first where a previous patch had transposed an i to a 1. The second an assumption that the IRQs allocated were meant to be unique and not 0 based. v1->v2 - split into two patches - previously sent as v1 post split by accident, resending for clarity

[PATCH v2 1/2] hw/arm/sbsa-ref : Fix SMMUv3 Initialisation

SMMUv3 has an error in a previous patch where an i was transposed to a 1 meaning interrupts would not have been correctly assigned to the SMMUv3 instance. Fixes: 48ba18e6d3f3 ("hw/arm/sbsa-ref: Simplify by moving the gic in the machine state") Signed-off-by: Graeme Gregory --- hw/arm/sbsa-ref.c

Re: [PATCH v10 7/9] stream: skip filters when writing backing file name to QCOW2 header

29.09.2020 15:38, Andrey Shinkevich wrote: Avoid writing a filter JSON-name to QCOW2 image when the backing file is changed after the block stream job. Signed-off-by: Andrey Shinkevich --- block/stream.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/block/strea

Re: [PATCH v10 8/9] block: remove unused backing-file name parameter

29.09.2020 15:38, Andrey Shinkevich wrote: The block stream QMP parameter backing-file is in use no more. It designates a backing file name to set in QCOW2 image header after the block stream job finished. The base file name is used instead. Signed-off-by: Andrey Shinkevich We can't just remo

Re: [PATCH v2 1/2] hw/arm/sbsa-ref : Fix SMMUv3 Initialisation

On 10/7/20 12:07 PM, Graeme Gregory wrote: > SMMUv3 has an error in a previous patch where an i was transposed to a 1 > meaning interrupts would not have been correctly assigned to the SMMUv3 > instance. > > Fixes: 48ba18e6d3f3 ("hw/arm/sbsa-ref: Simplify by moving the gic in the > machine state"

Re: [PATCH v2 2/2] hw/arm/sbsa-ref : allocate IRQs for SMMUv3

On 10/7/20 12:07 PM, Graeme Gregory wrote: > Original commit did not allocate IRQs for the SMMUv3 in the irqmap > effectively using irq 0->3 (shared with other devices). Assuming > original intent was to allocate unique IRQs then add an allocation > to the irqmap. > > Fixes: e9fdf453240 ("hw/arm:

Re: [PATCH v2 1/5] qemu-nbd: Honor SIGINT and SIGHUP

30.09.2020 15:11, Eric Blake wrote: Honoring just SIGTERM on Linux is too weak; we also want to handle other common signals, and do so even on BSD. Why? Because at least 'qemu-nbd -B bitmap' needs a chance to clean up the in-use bit on bitmaps when the server is shut down via a signal. Probab

Re: [PATCH v2 1/2] hw/arm/sbsa-ref : Fix SMMUv3 Initialisation

On Wed, Oct 07, 2020 at 12:24:32PM +0200, Philippe Mathieu-Daudé wrote: > On 10/7/20 12:07 PM, Graeme Gregory wrote: > > SMMUv3 has an error in a previous patch where an i was transposed to a 1 > > meaning interrupts would not have been correctly assigned to the SMMUv3 > > instance. > > > > Fixes:

Re: Purpose of QOM properties registered at realize time?

On Tue, 6 Oct 2020, Eduardo Habkost wrote: Hi, While trying to understand how QOM properties are used in QEMU, I stumbled upon multiple cases where alias properties are added at realize time. Now, I don't understand why those properties exist. As the properties are added at realize time, I ass

Re: [PULL 19/33] mips/cps: Use start-powered-off CPUState property

On 10/7/20 11:28 AM, Alex Bennée wrote: > > David Gibson writes: > >> From: Thiago Jung Bauermann >> >> Instead of setting CPUState::halted to 1 in main_cpu_reset(), use the >> start-powered-off property which makes cpu_common_reset() initialize it >> to 1 in common code. >> >> Also change crea

Re: [PATCH v2] hw/pci/pci: Fix slot check for plugged devices

On Wed, Oct 7, 2020 at 9:39 AM Stefano Garzarella wrote: > > On Tue, Oct 06, 2020 at 02:59:08PM +0200, Julia Suvorova wrote: > > If devfn is assigned automatically, 'else' clauses will never be > > executed. And if it does not matter for the reserved and available > > devfn, because we have alread

Re: [PATCH v2 2/5] nbd/server: Reject embedded NUL in NBD strings

30.09.2020 15:11, Eric Blake wrote: The NBD spec is clear that any string sent from the client must not contain embedded NUL characters. If the client passes "a\0", we should reject that option request rather than act on "a". Testing this is not possible with a compliant client, but I was able

Re: [PATCH v2 1/6] virtiofsd: Silence gcc warning

* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > Gcc worries fd might be used unset, in reality it's always set if > fi is set, and only used if fi is set so it's safe. Initialise it to -1 > just to keep gcc happy for now. > > Signed-off-by: Dr. D

Re: [PATCH v2 1/2] hw/arm/sbsa-ref : Fix SMMUv3 Initialisation

On 10/7/20 12:32 PM, Graeme Gregory wrote: > On Wed, Oct 07, 2020 at 12:24:32PM +0200, Philippe Mathieu-Daudé wrote: >> On 10/7/20 12:07 PM, Graeme Gregory wrote: >>> SMMUv3 has an error in a previous patch where an i was transposed to a 1 >>> meaning interrupts would not have been correctly ass

Re: [PATCH 11/20] python/qemu: Add mypy type annotations

Am 07.10.2020 um 01:58 hat John Snow geschrieben: > These should all be purely annotations with no changes in behavior at > all. You need to be in the python folder, but you should be able to > confirm that these annotations are correct (or at least self-consistent) > by running `mypy --strict qemu

Re: [RFC PATCH 01/19] tools/virtiofsd: add support for --socket-group

* Alex Bennée (alex.ben...@linaro.org) wrote: > If you like running QEMU as a normal user (very common for TCG runs) > but you have to run virtiofsd as a root user you run into connection > problems. Adding support for an optional --socket-group allows the > users to keep using the command line. >

Re: [PULL 19/33] mips/cps: Use start-powered-off CPUState property

Philippe Mathieu-Daudé writes: > On 10/7/20 11:28 AM, Alex Bennée wrote: >> >> David Gibson writes: >> >>> From: Thiago Jung Bauermann >>> >>> Instead of setting CPUState::halted to 1 in main_cpu_reset(), use the >>> start-powered-off property which makes cpu_common_reset() initialize it >>

[PATCH v4 0/2] Improve cirrus msys2

Fixes the broken msys2/mingw ci and speed it up. V3-V4 Using cirrus cache to speed up msys2 ci instead of downloading archive file V2-V3 Add one more patch: cirrus: msys2/mingw speed is up, add excluded target back Do not build sphinx on windows, that's failing set the number of parallel count to

[PATCH v4 1/2] cirrus: Fixing and speedup the msys2/mingw CI

Use cache of cirrus caching msys2 The install of msys2 are refer to https://github.com/msys2/setup-msys2 The first time install msys2 would be time consuming, so increase timeout_in to 90m according to https://cirrus-ci.org/faq/#instance-timed-out Apply patch of https://lists.gnu.org/archive/htm

[PATCH v4 2/2] cirrus: msys2/mingw speed is up, add excluded target back

The following target are add back: i386-softmmu,arm-softmmu,ppc-softmmu,mips-softmmu Signed-off-by: Yonggang Luo --- .cirrus.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index b58fb63521..fc4b066170 100644 --- a/.cirrus.yml +++ b/.cirrus.yml

Re: [PATCH] virtiofsd: Call qemu_init_exec_dir

* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > Since fcb4f59c879 qemu_get_local_state_pathname relies on the > init_exec_dir, and virtiofsd asserts because we never set it. > Set it. > > Reported-by: Alex Bennée > Signed-off-by: Dr. David Alan

Re: [PATCH 12/20] python/qemu/console_socket.py: Correct type of recv()

Am 07.10.2020 um 01:58 hat John Snow geschrieben: > The type and parameter names of recv() should match socket.socket(). Should this be socket.socket without parentheses (the class name)? socket.socket() is the constructor and it takes very different parameters. > OK, easy enough, but in the case

Re: [PATCH 13/20] python/qemu/console_socket.py: fix typing of settimeout

Am 07.10.2020 um 01:58 hat John Snow geschrieben: > The types and names of the parameters must match the socket.socket interface. > > Signed-off-by: John Snow Reviewed-by: Kevin Wolf

Re: [PATCH 15/20] python/qemu/console_socket.py: Add type hint annotations

Am 07.10.2020 um 01:58 hat John Snow geschrieben: > Finish the typing of console_socket.py with annotations and no code > changes. > > Signed-off-by: John Snow Reviewed-by: Kevin Wolf

Re: [PULL v8 00/86] Misc QEMU patches for 2020-09-24

On 10/2/20 8:24 PM, Eduardo Habkost wrote: On Fri, Oct 02, 2020 at 06:27:35PM +0200, Paolo Bonzini wrote: On 02/10/20 17:58, Michal Prívozník wrote: cd442a45db60a1a72fcf980c24bd1227f13f8a87 is the first bad commit Sorry for noticing this earlier, but is this known? The build starts failing

Re: Emulate Rpi with QEMU fails

Thomas Schneider <74cmo...@gmail.com> writes: > Hi, > > I already considered the host CPU power. > However I have this > > > CPU > Intel Core 2 Quad Q9550 2,83 G

Re: [PATCH 2/3] docs/devel/qtest: Include protocol spec in document

On 05/10/20 22:52, Eduardo Habkost wrote: > + * DOC: QTest Protocol > + * > + * .. highlight:: none > * > * Line based protocol, request/response based. Server can send async > messages > * so clients should always handle many async messages before the response > * comes in. > * > * V

Re: [PATCH 14/20] python/qemu/console_socket.py: Clarify type of drain_thread

Am 07.10.2020 um 01:58 hat John Snow geschrieben: > Mypy needs just a little help to guess the type here. > > Signed-off-by: John Snow Reviewed-by: Kevin Wolf

Re: [PATCH v2 1/2] hw/arm/sbsa-ref : Fix SMMUv3 Initialisation

On Wed, Oct 07, 2020 at 12:44:43PM +0200, Philippe Mathieu-Daudé wrote: > On 10/7/20 12:32 PM, Graeme Gregory wrote: > > On Wed, Oct 07, 2020 at 12:24:32PM +0200, Philippe Mathieu-Daudé wrote: > >> On 10/7/20 12:07 PM, Graeme Gregory wrote: > >>> SMMUv3 has an error in a previous patch where an

Re: [PATCH 16/20] python/console_socket: avoid encoding to/from string

Am 07.10.2020 um 01:58 hat John Snow geschrieben: > We can work directly in bytes instead of translating back and forth to > string, which removes the question of which encodings to use. > > Signed-off-by: John Snow Reviewed-by: Kevin Wolf

Re: Fwd: Enable IOMMU Inside QEMU

Thanks, Peter! That worked for me, Not sure if Virsh XML has some issue. for sake of other, this is the complete command I use. /usr/bin/qemu-system-x86_64 -machine q35,kernel-irqchip=split,accel=kvm -smp 4 -m 2G -device intel-iommu,intremap=on,caching-mode=on -nographic os_image.qcow2 dmesg i

Re: [PATCH 17/20] python/qemu/qmp.py: Preserve error context on re-raise

Am 07.10.2020 um 01:58 hat John Snow geschrieben: > Use the "from ..." phrasing when re-raising errors to preserve their > initial context, to help aid debugging when things go wrong. > > This also silences a pylint 2.6.0+ error. > > Signed-off-by: John Snow I don't really understand what this

Re: acceptance-system-fedora failures

Philippe Mathieu-Daudé writes: > On 10/7/20 10:51 AM, Pavel Dovgalyuk wrote: >> On 07.10.2020 11:23, Thomas Huth wrote: >>> On 07/10/2020 09.13, Philippe Mathieu-Daudé wrote: On 10/7/20 7:20 AM, Philippe Mathieu-Daudé wrote: > On 10/7/20 1:07 AM, John Snow wrote: >> I'm seeing this

Re: [PATCH 18/20] python/qemu/qmp.py: re-raise OSError when encountered

Am 07.10.2020 um 01:58 hat John Snow geschrieben: > Nested if conditions don't change when the exception block fires; we > need to explicitly re-raise the error if we didn't intend to capture and > suppress it. > > Signed-off-by: John Snow > --- > python/qemu/qmp.py | 6 +++--- > 1 file changed,

Re: [PATCH v5 19/36] qapi/events.py: add type hint annotations

John Snow writes: > Annotations do not change runtime behavior. > This commit *only* adds annotations. > > Signed-off-by: John Snow > Reviewed-by: Eduardo Habkost > Reviewed-by: Cleber Rosa > --- > scripts/qapi/events.py | 46 -- > scripts/qapi/mypy.ini

Re: [PATCH v5 21/36] qapi/commands.py: Don't re-bind to variable of different type

John Snow writes: > Mypy isn't a fan of rebinding a variable with a new data type. > It's easy enough to avoid. > > Signed-off-by: John Snow > Reviewed-by: Eduardo Habkost > Reviewed-by: Cleber Rosa > --- > scripts/qapi/commands.py | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >

Re: [PATCH 20/20] python: add mypy config

Am 07.10.2020 um 01:58 hat John Snow geschrieben: > Formalize the options used for checking the python library. You can run > mypy from the directory that mypy.ini is in by typing `mypy qemu/`. > > Signed-off-by: John Snow > --- > python/mypy.ini | 4 > 1 file changed, 4 insertions(+) > cr

Re: Emulate Rpi with QEMU fails

Are you referring to this tool? https://github.com/stefano-garzarella/qemu-boot-time Am 07.10.2020 um 13:00 schrieb Alex Bennée: perf to record your boot

  1   2   3   4   >