On Tue, Oct 06, 2020 at 08:47:29PM +0200, Thomas Huth wrote: > On 06/10/2020 16.42, Daniel P. Berrangé wrote: > > On Tue, Oct 06, 2020 at 03:38:56PM +0100, Peter Maydell wrote: > > > On Tue, 6 Oct 2020 at 15:36, Eduardo Habkost <ehabk...@redhat.com> wrote: > > > > > > > > On Tue, Oct 06, 2020 at 03:03:57PM +0100, Peter Maydell wrote: > > > > > Compile failure on OSX: > > > > > > > > > > ../../hw/core/numa.c:429:20: error: format specifies type 'unsigned > > > > > char' but the argument has type 'int' [-Werror,-Wformat] > > > > > node->level - 1); > > > > > ^~~~~~~~~~~~~~~~ > > > > > /Users/pm215/src/qemu-for-merges/include/qapi/error.h:319:35: note: > > > > > expanded from macro 'error_setg' > > > > > (fmt), ## __VA_ARGS__) > > > > > ~~~ ^~~~~~~~~~~ > > > > > 1 error generated. > > > > > > > > Is there a CI system where this is tested? I'd like to be able > > > > to detect this kind of failure before sending pull requests. > > > > > > Currently this is still my ad-hoc setup. I think there is > > > some CI that tests OSX compiles, though I have no idea how > > > individual maintainers set up to use it. > > > > Cirrus CI will cover macOS builds. You just need to register with > > Cirrus CI via your GitLab login, then pushing a branch to gitlab > > should trigger both GitLab CI and Cirrus CI, which covers a vast > > majority of combinations. > > I think Cirrus-CI needs a github account? Is there a way to use Gitlab now > instead? (just like Travis recently added Gitlab support?)
Sorry, I was mixing up Travis and Cirrus. > We should eventually set up the cirrus-run tool, so we can use gitlab, too, > but I think you then still need at least a dummy github account to be able > to use it, don't you? Yes, you still need a github account. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
