From: Markus Armbruster
Replace
error_report("...: %s", ..., error_get_pretty(err));
by
error_reportf_err(err, "...: ", ...);
One of the replaced messages lacked a colon. Add it.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Philippe Mathieu-Daudé
Message-
From: Cornelia Huck
commit 6a8b55ed4056ea5559ebe4f6a4b247f627870d4c
Reviewed-by: Michael S. Tsirkin # virtio/vhost parts
Signed-off-by: Cornelia Huck
Message-Id: <20200427102415.10915-3-coh...@redhat.com>
(cherry picked from commit dc6f8d458a4ccc360723993f31d310d06469f55f)
*dep for 3219b42f02
From: Markus Armbruster
Commit 150ab54aa6 "net/virtio: fix re-plugging of primary device"
fixed failover_replug_primary() to return false on failure. Commit
5a0948d36c "net/virtio: Fix failover error handling crash bugs" broke
it again for hotplug_handler_plug() failure. Unbreak it.
Commit 5a0
From: lichun
Errors are already freed by error_report_err, so we only need to call
error_free when that function is not called.
Cc: qemu-sta...@nongnu.org
Signed-off-by: lichun
Message-Id: <20200621213017.17978-1-lic...@ruijie.com.cn>
Reviewed-by: Markus Armbruster
[Commit message improved, cc
From: Stephen Long
The fallback inline expansion for vectorized absolute value,
when the host doesn't support such an insn was flawed.
E.g. when a vector of bytes has all elements negative, mask
will be 0x___. Subtracting mask only adds 1
to the low element instead of all elemen
From: Marc-André Lureau
Since commit 781f2b3d1e ("qga: process_event() simplification"),
send_response() is called unconditionally, but will assert when "rsp" is
NULL. This may happen with QCO_NO_SUCCESS_RESP commands, such as
"guest-shutdown".
Fixes: 781f2b3d1e5ef389b44016a897fd55e7a780bf35
Cc:
From: Markus Armbruster
error_report_err() frees its first argument. Freeing it again is
wrong. Don't.
Fixes: 47287c27d0c367a89f7b2851e23a7f8b2d499dd6
Cc: Gerd Hoffmann
Cc: Daniel P. Berrangé
Cc: qemu-sta...@nongnu.org
Signed-off-by: Markus Armbruster
Message-Id: <20200630090351.1247703-7-a
From: Alexander Duyck
Recently a feature named Free Page Reporting was added to the virtio
balloon. In order to avoid any confusion we should drop the use of the word
'report' when referring to Free Page Hinting. So what this patch does is go
through and replace all instances of 'report' with 'hi
From: Greg Kurz
Locking was introduced in QEMU 2.7 to address the deprecation of
readdir_r(3) in glibc 2.24. It turns out that the frontend code is
the worst place to handle a critical section with a pthread mutex:
the code runs in a coroutine on behalf of the QEMU mainloop and then
yields contro
From: Cornelia Huck
If a virtio device does not have legacy support, make sure that
it is actually off, and bail out if not.
For virtio-pci, this means that any device without legacy support
that has been specified to modern-only (or that has been forced
to it) will work.
For virtio-ccw, this d
From: Philippe Mathieu-Daudé
We want to report the index of the descriptor,
not its pointer.
Fixes: 7b2e5c65f4 ("contrib: add libvhost-user")
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20200723171935.18535-1-phi...@redhat.com>
Reviewed-by: Marc-André Lureau
Reviewed-by: Raphael Norwitz
From: Philippe Mathieu-Daudé
In few commits we won't allow SD card images with invalid size
(not aligned to a power of 2). Prepare the tests: add the
pow2ceil() and image_pow2ceil_expand() methods and resize the
images (expanding) of the tests using SD cards.
Signed-off-by: Philippe Mathieu-Daud
From: Stefan Berger
The TPM 2 code in libtpms was fixed to handle the PCR 'TCB group' according
to the PCClient profile. The change of the PCRs belonging to the 'TCB group'
now affects the pcrUpdateCounter in the TPM2_PCRRead() responses where its
value is now different (typically lower by '1') t
From: Philippe Mathieu-Daudé
To make the next commit easier to review, clean this code first.
Reviewed-by: Peter Maydell
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Reviewed-by: Alexander Bulekov
Message-Id: <20200630133912.9428-3-f4...@amsat.org>
(cherry picked from
From: Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland
Cc: qemu-sta...@nongnu.org
(cherry picked from commit 54414d0fb11314ede939ec80238787c5b2079f4e)
Signed-off-by: Michael Roth
---
pc-bios/openbios-ppc | Bin 696912 -> 696912 bytes
pc-bios/openbios-sparc32 | Bin 382048 -> 382048 bytes
p
From: Alexander Duyck
There is already locking in place when we are stopping free page hinting
but there is not similar protections in place when we start. I can only
assume this was overlooked as in most cases the page hinting should not be
occurring when we are starting the hinting, however the
From: Richard Henderson
Two temps allocated but not freed. Do enough subtractions
within a single TB and one can run out of temps entirely.
Fixes: b2167459ae ("target-hppa: Implement basic arithmetic")
Buglink: https://bugs.launchpad.net/qemu/+bug/1880287
Tested-by: Sven Schnelle
Reviewed-by:
From: Gerd Hoffmann
Store calculated setup_len in a local variable, verify it, and only
write it to the struct (USBDevice->setup_len) in case it passed the
sanity checks.
This prevents other code (do_token_{in,out} functions specifically)
from working with invalid USBDevice->setup_len values and
From: Markus Armbruster
Help on device properties gets printed to stdout instead of the
monitor. If you have the monitor anywhere else, no help for you.
Broken when commit e1043d674d "qdev: use object_property_help()"
accidentally switched from qemu_printf() to printf(). Switch right
back.
Fix
From: Cornelia Huck
Several types of virtio devices had already been around before the
virtio standard was specified. These devices support virtio in legacy
(and transitional) mode.
Devices that have been added in the virtio standard are considered
non-transitional (i.e. with no support for lega
From: Jan Charvat
Signed-off-by: Jan Charvat
Signed-off-by: Pavel Pisa
Reviewed-by: Vikram Garhwal
---
hw/net/can/can_sja1000.c | 29 +++--
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/hw/net/can/can_sja1000.c b/hw/net/can/can_sja1000.c
index ec66d423
From: Alexander Duyck
Based on code review it appears possible for the driver to force the device
out of a stopped state when hinting by repeating the last ID it was
provided.
Prevent this by only allowing a transition to the start state when we are
in the requested state. This way the driver is
From: Liu Yi L
In chapter 10.4.23 of VT-d spec 3.0, Descriptor Width bit was introduced
in VTD_IQA_REG. Software could set this bit to tell VT-d the QI descriptor
from software would be 256 bits. Accordingly, the VTD_IQH_QH_SHIFT should
be 5 when descriptor size is 256 bits.
This patch adds the
On Thu, Jul 09, 2020 at 10:55:07AM +0200, Erik Skultety wrote:
> On Wed, Jul 08, 2020 at 10:46:57PM -0400, Cleber Rosa wrote:
> > This is a mapping of Peter's "remake-merge-builds" and
> > "pull-buildtest" scripts, gone through some updates, adding some build
> > option and removing others.
> >
> >
From: Max Reitz
Since these functions take a @qiov_offset, they must always take it into
account when working with @qiov. There are a couple of places where
they do not, but they should.
Fixes: 65cd4424b9df03bb5195351c33e04cbbecc0705c
("block/io: bdrv_aligned_preadv: use and support qiov
From: Andrew Melnychenko
There is an issue when callback may be called with invalid vdev.
It happens on unplug when vdev already deleted and VirtIOPciProxy is not.
So now, callbacks accept proxy device, and vdev retrieved from it.
Technically memio callbacks should be removed during the flatview
On Fri, Sep 4, 2020 at 1:20 AM Richard Henderson <
richard.hender...@linaro.org> wrote:
> On 9/3/20 1:31 AM, Yonggang Luo wrote:
> > Rename function dup_const to dup_const_eval for avoid confliction with
> macro dup_const
> >
> > The link error on msys2
> >
> > Linking target qemu-system-alpha.exe
From: Jan Charvat
Signed-off-by: Jan Charvat
Signed-off-by: Pavel Pisa
Reviewed-by: Vikram Garhwal
---
include/net/can_emu.h | 4
net/can/can_core.c| 36
2 files changed, 40 insertions(+)
diff --git a/include/net/can_emu.h b/include/net/can_emu.
From: Eric Blake
Ever since commit 36683283 (v2.8), the server code asserts that error
strings sent to the client are well-formed per the protocol by not
exceeding the maximum string length of 4096. At the time the server
first started sending error messages, the assertion could not be
triggered
Do not set parallel_cpus if there is only one cpu instantiated.
This will allow tcg to use serial code to implement atomics.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
softmmu/cpus.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/so
From: Max Reitz
Signed-off-by: Max Reitz
Message-Id: <20200728120806.265916-3-mre...@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy
Tested-by: Vladimir Sementsov-Ogievskiy
Tested-by: Claudio Fontana
(cherry picked from commit ae159450e161b3e1e2c5b815d19632acd1a1)
Signed-off-by: Mic
From: Graeme Gregory
Fixing a typo in a previous patch that translated an "i" to a 1
and therefore breaking the allocation of PCIe interrupts. This was
discovered when virtio-net-pci devices ceased to function correctly.
Cc: qemu-sta...@nongnu.org
Fixes: 48ba18e6d3f3 ("hw/arm/sbsa-ref: Simplify
Do not store back to the exact memory from which we just loaded.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
tcg/tcg-op-gvec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tcg/tcg-op-gvec.c b/tcg/tcg-op-gvec.c
index 793d4ba64c..fcc25b04e6
From: Jan Charvat
The implementation of the model of complete open-source/design/hardware
CAN FD controller. The IP core project has been started and is maintained
by Ondrej Ille at Czech Technical University in Prague.
CTU CAN FD project pages:
https://gitlab.fel.cvut.cz/canbus/ctucanfd
From: Yuri Benditovich
Removal of duplicated RSC definitions. Changing names of the
fields to ones defined in the Linux header.
Signed-off-by: Yuri Benditovich
Signed-off-by: Jason Wang
(cherry picked from commit dd3d85e89123c907be7628957457af3d03e3b85b)
Conflicts:
hw/net/virtio-net.c
From: David Hildenbrand
In case we don't have an iothread, we mark the feature as abscent but
still add the queue. 'free_page_bh' remains set to NULL.
qemu-system-i386 \
-M microvm \
-nographic \
-device virtio-balloon-device,free-page-hint=true \
-nographic \
Updated MAINTAINERS for CAN bus related emulation as well.
Signed-off-by: Pavel Pisa
---
MAINTAINERS | 9
docs/can.txt | 113 ++-
2 files changed, 111 insertions(+), 11 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index b233da2a73..
Quoting Alistair Francis (2020-09-01 18:59:29)
> On Mon, Aug 31, 2020 at 10:59 PM Nathan Chancellor
> wrote:
> >
> > When shutting down the machine running a mainline Linux kernel, the
> > following error happens:
> >
> > $ build/riscv64-softmmu/qemu-system-riscv64 -bios default -M virt \
> >
Your pipeline has failed.
Project: QEMU ( https://gitlab.com/qemu-project/qemu )
Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master )
Commit: 67a7bfe5 (
https://gitlab.com/qemu-project/qemu/-/commit/67a7bfe560a1bba59efab085cb3430f45176d382
)
Commit Message: Merge remote-tr
From: Pavel Pisa
CTU CAN FD is an open source soft core written in VHDL.
It originated in 2015 as Ondrej Ille's project at the
Department of Measurement of FEE at CTU.
Integration for Xilinx Zynq and Intel based SoCs is available
as well as support for PCIe integration of the core.
The core sou
We already support duplication of 128-bit blocks. This extends
that support to 256-bit blocks. This will be needed by SVE2.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
tcg/tcg-op-gvec.c | 52 ---
1 file changed, 49 inser
Hi,
This spin attempts to cover all suggestions and concerns pointed
out by David Gibson in the v2 review.
The patches were rebased with David's ppc-for-5.2 at 615ae3763144.
They can also be cloned from
https://github.com/danielhb/qemu/tree/spapr_numa_v3.
Changes from v2:
- patches 1 and 2 from
Signed-off-by: Yonggang Luo
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index e42d210e5f..ae63c4fd54 100755
--- a/configure
+++ b/configure
@@ -2545,7 +2545,7 @@ fi
# vhost-user backends
test "$vhost_net_user" = "" && vhost_net_user=$v
From: Jan Charvat
Signed-off-by: Jan Charvat
Signed-off-by: Pavel Pisa
Reviewed-by: Vikram Garhwal
---
hw/net/can/can_sja1000.c | 2 ++
include/net/can_emu.h| 8 ++-
net/can/can_socketcan.c | 47 +---
3 files changed, 53 insertions(+), 4 deletion
The following changes since commit 3dd23a4fb8fd72d2220a90a809f213999ffe7f3a:
Merge remote-tracking branch 'remotes/legoater/tags/pull-aspeed-20200901'
into staging (2020-09-03 14:12:48 +0100)
are available in the Git repository at:
https://github.com/rth7680/qemu.git tags/pull-tc
Vcpus have an additional paramenter to be appended, vcpu_id. This
also changes the size of the of property itself, which is being
represented in index 0 of numa_assoc_array[cpu->node_id],
and defaults to MAX_DISTANCE_REF_POINTS for all cases but
vcpus.
All this logic makes more sense in spapr_numa
The next step to centralize all NUMA/associativity handling in
the spapr machine is to create a 'one stop place' for all
things ibm,associativity.
This patch introduces numa_assoc_array, a 2 dimensional array
that will store all ibm,associativity arrays of all NUMA nodes.
This array is initialized
This has no functional change.
The current function structure is:
inline QEMU_ALWAYSINLINE
store_memop() {
switch () {
...
default:
qemu_build_not_reached();
}
}
inline QEMU_ALWAYSINLINE
store_helper() {
...
if (s
The implementation of this hypercall will be modified to use
spapr->numa_assoc_arrays input. Moving it to spapr_numa.c makes
make more sense.
Signed-off-by: Daniel Henrique Barboza
---
hw/ppc/spapr_hcall.c| 37 +
hw/ppc/spapr_numa.c | 36 ++
The work to be done in h_home_node_associativity() intersects
with what is already done in spapr_numa_fixup_cpu_dt(). This
patch creates a new helper, spapr_numa_get_vcpu_assoc(), to
be used for both spapr_numa_fixup_cpu_dt() and
h_home_node_associativity().
Signed-off-by: Daniel Henrique Barboza
On 03/09/20 15:18, Philippe Mathieu-Daudé wrote:
> As of this patch, all the non-PCI, but I plan to add a similar
> check for USB on top of this series.
Do you mean for memory-mapped USB host controllers?
>> I'm worried that there are cases of MMIO reads that would be broken.
>> They are certainl
The current implementation of h_home_node_associativity hard codes
the values of associativity domains of the vcpus. Let's make
it consider the values already initialized in spapr->numa_assoc_array,
via the spapr_numa_get_vcpu_assoc() helper.
We want to set it and forget it, and for that we also n
Signed-off-by: Yonggang Luo
---
tests/test-replication.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/tests/test-replication.c b/tests/test-replication.c
index 9ab3666a90..d0e06f8d77 100644
--- a/tests/test-replication.c
+++ b/tests/test-replication.c
@@
From: Jan Charvat
Definitions of registers and CAN FD frame message box of CTU CAN FD
IP core are generated the specification in CACTUS/IP-XACT format.
CTU CAN FD IP core repository
https://gitlab.fel.cvut.cz/canbus/ctucanfd_ip_core
The location of the CTU CAN IP core specification within
IP
The original CAN_PCI config option enables multiple SJA1000 PCI boards
emulation build. These boards bridge SJA1000 into I/O or memory
address space of the host CPU and depend on SJA1000 emulation.
Signed-off-by: Pavel Pisa
---
hw/net/Kconfig | 7 +++
1 file changed, 3 insertions(+), 4 delet
In a similar fashion as the previous patch, let's move the
handling of ibm,associativity-lookup-arrays from spapr.c to
spapr_numa.c. A spapr_numa_write_assoc_lookup_arrays() helper was
created, and spapr_dt_dynamic_reconfiguration_memory() can now
use it to advertise the lookup-arrays.
Signed-off-
The NVLink2 GPUs works like a regular NUMA node with its
own associativity values, regardless of user input.
This can be handled inside spapr_numa_associativity_init(),
initializing NVGPU_MAX_NUM associativity arrays that can
be used by the GPUs.
Signed-off-by: Daniel Henrique Barboza
---
hw/pp
sg_get_max_transfer_length() and sg_get_max_segments() have nothing
to do with the sg driver or SG_IO at all. They can be and should be
used on all host devices / cdroms (on Linux).
Also use MIN_NON_ZERO instead when we clamp max_sectors against
max_segments.
Signed-off-by: Tom Yan
---
block/fi
On Thu, Sep 3, 2020 at 10:33 PM Thomas Huth wrote:
> On 03/09/2020 11.18, 罗勇刚(Yonggang Luo) wrote:
> [...]
> > TESTcheck-unit: tests/test-replication.exe
> > **
> > ERROR:C:/work/xemu/qemu/tests/test-replication.c:136:make_temp:
> > assertion failed: (fd >= 0)
> > ERROR test-replication.exe
Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
Host Memory : 15.49 GB
Start Time (UTC) : 2020-09-03 22:30:01
End Time (UTC) : 2020-09-03 23:02:32
Execution Time : 0:32:30.542730
Status : SUCCESS
Note:
Changes denoted by '-' are less than 0.01%.
-
On Thu, Jul 09, 2020 at 12:07:32PM +0200, Philippe Mathieu-Daudé wrote:
> On 7/9/20 4:46 AM, Cleber Rosa wrote:
> > This is a mapping of Peter's "remake-merge-builds" and
> > "pull-buildtest" scripts, gone through some updates, adding some build
> > option and removing others.
> >
> > The jobs cur
On 9/3/20 2:19 PM, 罗勇刚(Yonggang Luo) wrote:
> No, really, as I asked before: what symbol is present in tcg-op-gvec.c.obj
> without this patch?
>
> The tcg-op-gvec.c.obj are missing now, maybe skip this patch first?
Yes, please.
> Anyway have same name with function and macro is not th
On Thu, Sep 03, 2020 at 07:06:38PM -0300, Daniel Henrique Barboza wrote:
> The work to be done in h_home_node_associativity() intersects
> with what is already done in spapr_numa_fixup_cpu_dt(). This
> patch creates a new helper, spapr_numa_get_vcpu_assoc(), to
> be used for both spapr_numa_fixup_c
On Thu, Sep 03, 2020 at 07:06:34PM -0300, Daniel Henrique Barboza wrote:
> Vcpus have an additional paramenter to be appended, vcpu_id. This
> also changes the size of the of property itself, which is being
> represented in index 0 of numa_assoc_array[cpu->node_id],
> and defaults to MAX_DISTANCE_R
On Thu, Sep 03, 2020 at 07:06:32PM -0300, Daniel Henrique Barboza wrote:
> Hi,
>
> This spin attempts to cover all suggestions and concerns pointed
> out by David Gibson in the v2 review.
>
> The patches were rebased with David's ppc-for-5.2 at 615ae3763144.
> They can also be cloned from
> https
On Thu, Sep 03, 2020 at 07:06:39PM -0300, Daniel Henrique Barboza wrote:
> The current implementation of h_home_node_associativity hard codes
> the values of associativity domains of the vcpus. Let's make
> it consider the values already initialized in spapr->numa_assoc_array,
> via the spapr_numa_
On Thu, Sep 03, 2020 at 07:06:37PM -0300, Daniel Henrique Barboza wrote:
> The implementation of this hypercall will be modified to use
> spapr->numa_assoc_arrays input. Moving it to spapr_numa.c makes
> make more sense.
>
> Signed-off-by: Daniel Henrique Barboza
> ---
> hw/ppc/spapr_hcall.c
On 9/2/20 6:42 PM, Eduardo Habkost wrote:
Make the type checking macro name consistent with the TYPE_*
constant.
Signed-off-by: Eduardo Habkost
Reviewed-by: Stefan Berger
---
Cc: Stefan Berger
Cc: qemu-devel@nongnu.org
---
hw/tpm/tpm_crb.c | 14 +++---
1 file changed, 7 inse
On 9/2/20 6:42 PM, Eduardo Habkost wrote:
Make the type checking macro name consistent with the TYPE_*
constant.
Signed-off-by: Eduardo Habkost
Reviewed-by: Stefan Berger
---
Cc: Stefan Berger
Cc: qemu-devel@nongnu.org
---
hw/tpm/tpm_spapr.c | 14 +++---
1 file changed, 7 inse
Oops I forgot max_transfer needs to be in bytes (and BLKSECTGET in sg
has always been implemented wrongly). Will send a new version.
On Fri, 4 Sep 2020 at 06:37, Tom Yan wrote:
>
> sg_get_max_transfer_length() and sg_get_max_segments() have nothing
> to do with the sg driver or SG_IO at all. They
On Thu, Jul 09, 2020 at 11:30:29AM +0100, Daniel P. Berrangé wrote:
> On Wed, Jul 08, 2020 at 10:46:57PM -0400, Cleber Rosa wrote:
> > This is a mapping of Peter's "remake-merge-builds" and
> > "pull-buildtest" scripts, gone through some updates, adding some build
> > option and removing others.
>
On Thu, Jul 09, 2020 at 01:28:27PM +0200, Andrea Bolognani wrote:
> On Thu, 2020-07-09 at 11:30 +0100, Daniel P. Berrangé wrote:
> > On Wed, Jul 08, 2020 at 10:46:57PM -0400, Cleber Rosa wrote:
> > > +- name: Installation of basic packages to build QEMU
> > > + hosts: all
> > > + vars_files:
> >
>
> test "$vhost_net_user" = "" && vhost_net_user=$vhost_user
> if test "$vhost_net_user" = "yes" && test "$vhost_user" = "no"; then
> - error_exit "--enable-vhost-net-user requires --enable-vhost-user"
> + error_exit "--enable-vhost-net requires --enable-vhost-user"
> fi
>
This change seems
On 9/3/20 8:23 PM, David Gibson wrote:
On Thu, Sep 03, 2020 at 07:06:34PM -0300, Daniel Henrique Barboza wrote:
Vcpus have an additional paramenter to be appended, vcpu_id. This
also changes the size of the of property itself, which is being
represented in index 0 of numa_assoc_array[cpu->nod
On Wed, Jul 29, 2020 at 11:16:29AM +0100, Stefan Hajnoczi wrote:
> On Wed, Jul 08, 2020 at 10:46:57PM -0400, Cleber Rosa wrote:
>
> Awesome, thanks for creating this stuff! Minor suggestions:
>
> > diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
> > index c1ff24370b..f8dab788ea 10064
We can and should get max transfer length and max segments for all host
devices / cdroms (on Linux).
Also use MIN_NON_ZERO instead when we clamp max transfer length against
max segments.
Signed-off-by: Tom Yan
---
v2: fix get_max_transfer_length for non-sg devices; also add/fix
sg_get_max_segmen
sg devices have different major/minor than their corresponding
block devices. Using sysfs to get max segments never really worked
for them.
Fortunately the sg driver provides an ioctl to get sg_tablesize,
which is apparently equivalent to max segments.
Signed-off-by: Tom Yan
---
block/file-posi
Hi,
Another spin for this rework of the existing NUMA support
for pSeries, prior to incoming changes in how we calculate
NUMA distance in the pseries machine. Changes here were
made based on David Gibson's review of v3.
This patches were rebased using David's ppc-for-5.2 tree.
changes from v3:
-
The implementation of this hypercall will be modified to use
spapr->numa_assoc_arrays input. Moving it to spapr_numa.c makes
make more sense.
Signed-off-by: Daniel Henrique Barboza
---
hw/ppc/spapr_hcall.c | 40 ---
hw/ppc/spapr_numa.c | 45 ++
Kindly ping.
On 2020/8/26 18:15, AlexChen wrote:
> From: AlexChen
>
> The 'kdgb' is allocating memory in get_kdbg(), but it is not freed
> in both fill_header() and fill_context() failed branches, fix it.
>
> Signed-off-by: AlexChen
> ---
> contrib/elf2dmp/main.c | 4 ++--
> 1 file changed, 2
The work to be done in h_home_node_associativity() intersects
with what is already done in spapr_numa_fixup_cpu_dt(). This
patch creates a new helper, spapr_numa_get_vcpu_assoc(), to
be used for both spapr_numa_fixup_cpu_dt() and
h_home_node_associativity().
While we're at it, use memcpy() instead
The current implementation of h_home_node_associativity hard codes
the values of associativity domains of the vcpus. Let's make
it consider the values already initialized in spapr->numa_assoc_array,
via the spapr_numa_get_vcpu_assoc() helper.
We want to set it and forget it, and for that we also n
We can and should get max transfer length and max segments for all host
devices / cdroms (on Linux).
Also use MIN_NON_ZERO instead when we clamp max transfer length against
max segments.
Signed-off-by: Tom Yan
---
v2: fix get_max_transfer_length for non-sg devices; also add/fix
sg_get_max_segmen
sg devices have different major/minor than their corresponding
block devices. Using sysfs to get max segments never really worked
for them.
Fortunately the sg driver provides an ioctl to get sg_tablesize,
which is apparently equivalent to max segments.
Signed-off-by: Tom Yan
---
block/file-posi
sg devices have different major/minor than their corresponding
block devices. Using sysfs to get max segments never really worked
for them.
Fortunately the sg driver provides an ioctl to get sg_tablesize,
which is apparently equivalent to max segments.
Signed-off-by: Tom Yan
---
block/file-posi
We can and should get max transfer length and max segments for all host
devices / cdroms (on Linux).
Also use MIN_NON_ZERO instead when we clamp max transfer length against
max segments.
Signed-off-by: Tom Yan
---
v2: fix get_max_transfer_length for non-sg devices; also add/fix
sg_get_max_segmen
We can and should get max transfer length and max segments for all host
devices / cdroms (on Linux).
Also use MIN_NON_ZERO instead when we clamp max transfer length against
max segments.
Signed-off-by: Tom Yan
---
v2: fix get_max_transfer_length for non-sg devices; also add/fix
sg_get_max_segmen
sg devices have different major/minor than their corresponding
block devices. Using sysfs to get max segments never really worked
for them.
Fortunately the sg driver provides an ioctl to get sg_tablesize,
which is apparently equivalent to max segments.
Signed-off-by: Tom Yan
---
block/file-posi
On 2020/9/3 下午7:19, Peter Maydell wrote:
On Thu, 3 Sep 2020 at 12:11, Li Qiang wrote:
Peter Maydell 于2020年9月3日周四 下午6:53写道：
On Thu, 3 Sep 2020 at 04:55, Jason Wang wrote:
I think we still need to seek a way to address this issue completely.
How about adding a flag in MemoryRegionOps and d
On 2020/9/4 上午3:46, Edgar E. Iglesias wrote:
On Thu, Sep 03, 2020 at 07:53:33PM +0200, Paolo Bonzini wrote:
On 03/09/20 17:50, Edgar E. Iglesias wrote:
Hmm, I guess it would make sense to have a configurable option in KVM
to isolate passthrough devices so they only can DMA to guest RAM...
Pa
From: Cédric Le Goater
On POWER9, the KVM XIVE device uses priority 7 for the escalation
interrupts. On POWER10, the host can use a reduced set of priorities
and KVM will configure the escalation priority to a lower number. In
any case, the guest is allowed to use priorities in a single range :
From: Cédric Le Goater
The OPAL test suite runs a read-erase-write test on the PNOR :
https://github.com/open-power/op-test/blob/master/testcases/OpTestPNOR.py
which revealed that the IPMI HIOMAP handlers didn't support
HIOMAP_C_ERASE. Implement the sector erase command by writing 0xFF in
the
The following changes since commit 67a7bfe560a1bba59efab085cb3430f45176d382:
Merge remote-tracking branch
'remotes/huth-gitlab/tags/pull-request-2020-09-03' into staging (2020-09-03
16:58:25 +0100)
are available in the Git repository at:
git://github.com/dgibson/qemu.git tags/ppc-for-5.2-2
From: Cédric Le Goater
This is doing an extra loop but should be equivalent.
It also differentiate the reset of the sources from the restore of the
sources configuration. This will help in allocating the vCPU IPIs
independently.
Signed-off-by: Cédric Le Goater
Message-Id: <20200820134547.23557
From: Cédric Le Goater
We will use to check if a vCPU IPI has been created.
Signed-off-by: Cédric Le Goater
Message-Id: <20200820134547.2355743-2-...@kaod.org>
Signed-off-by: David Gibson
---
hw/intc/spapr_xive_kvm.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/
From: Daniel Henrique Barboza
Since we're using the string just once, just use g_autofree and
avoid leaking it without calling g_free().
Signed-off-by: Daniel Henrique Barboza
Message-Id: <20200825215749.213536-2-danielhb...@gmail.com>
Signed-off-by: David Gibson
---
hw/ppc/spapr_nvdimm.c | 3
The TypeInfo incorrectly just lets the class size be inherited. It won't
actually break things, since the class is abstract, but we should get it
right.
Signed-off-by: David Gibson
Reviewed-by: Cédric Le Goater
Reviewed-by: Philippe Mathieu-Daudé
---
hw/input/adb.c | 1 +
1 file changed, 1 in
From: Cédric Le Goater
When QEMU switches to the XIVE interrupt mode, it creates all the
guest interrupts at the level of the KVM device. These interrupts are
backed by real HW interrupts from the IPI interrupt pool of the XIVE
controller.
Currently, this is done from the QEMU main thread, which
spapr_drc.h includes typechecker macro boilerplate for the many different
DRC subclasses. However, most of these types don't actually have different
data in their class and/or instance, making these unneeded, unused, and in
fact a bad idea. Remove them.
Signed-off-by: David Gibson
Reviewed-by:
From: Cédric Le Goater
The vCPU IPIs are now allocated in kvmppc_xive_cpu_connect() when the
vCPU connects to the KVM device and not when all the sources are reset
in kvmppc_xive_source_reset()
This requires extra care for hotplug vCPUs and VM restore.
Signed-off-by: Cédric Le Goater
Message-I
501 - 600 of 629 matches
Mail list logo
