On Fri, Sep 4, 2020 at 1:20 AM Richard Henderson <
richard.hender...@linaro.org> wrote:
> On 9/3/20 1:31 AM, Yonggang Luo wrote:
> > Rename function dup_const to dup_const_eval for avoid confliction with
> macro dup_const
> >
> > The link error on msys2
> >
> > Linking target qemu-system-alpha.exe
> >
> C:/CI-Tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
> libqemu-alpha-softmmu.fa.p/tcg_optimize.c.obj: in function `tcg_optimize':
> > E:\CI-Cor-Ready\xemu\qemu-build/../qemu.org/tcg/optimize.c:1106:
> undefined reference to `dup_const'
> >
> C:/CI-Tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
> libqemu-alpha-softmmu.fa.p/tcg_tcg-op-vec.c.obj: in function
> `tcg_gen_dupi_vec':
> > E:\CI-Cor-Ready\xemu\qemu-build/../qemu.org/tcg/tcg-op-vec.c:283:
> undefined reference to `dup_const'
> > collect2.exe: error: ld returned 1 exit status
> >
> > Signed-off-by: Yonggang Luo <luoyongg...@gmail.com>
> > ---
> > include/tcg/tcg.h | 6 +++---
> > tcg/tcg-op-gvec.c | 2 +-
> > 2 files changed, 4 insertions(+), 4 deletions(-)
>
> No, really, as I asked before: what symbol is present in tcg-op-gvec.c.obj
> without this patch?
>
The tcg-op-gvec.c.obj are missing now, maybe skip this patch first?
Anyway have same name with function and macro is not that good
>
> That you need this, to me says that you've got a broken compiler. This is
> bog-standard C. There is nothing windows-specific about it.
>
>
> r~
>
--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo
