On 28.08.20 13:08, Alberto Garcia wrote:
> This patch replaces instances of sizeof(uint64_t) in the qcow2 driver
> with macros that indicate what those sizes are actually referring to.
>
> Signed-off-by: Alberto Garcia
> ---
> block/qcow2.h | 6 +++
> block/qcow2-bitmap.c | 11 --
03.09.2020 15:29, Paolo Bonzini wrote:
On 03/09/20 13:16, Vladimir Sementsov-Ogievskiy wrote:
(gdb) info thr
Id Target Id Frame
* 1 Thread 0x7fb9f0f39e00 (LWP 215115) "qemu-system-x86"
0x7fb9d784f54d in __lll_lock_wait () from /lib64/libpthr
Hello,
I am interested in contributing to the implementation of the BusLogic
adapter. I saw on the doc pages of QEMU that it is an incomplete adaptation
and I would like to take it further and complete it.
Before I take it up however, I wanted to check in and see if it wasn't
already being worked
On 03/09/20 17:35, Bruce Rogers wrote:
> Turn on the meson install flag for these executables
>
> Signed-off-by: Bruce Rogers
> ---
> contrib/ivshmem-client/meson.build | 2 +-
> contrib/ivshmem-server/meson.build | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/contr
Hi
On Thu, Sep 3, 2020 at 7:35 PM Bruce Rogers wrote:
>
> Turn on the meson install flag for these executables
>
> Signed-off-by: Bruce Rogers
I am not sure we want to install binaries that don't even have
maintainers (or am I wrong?).
> ---
> contrib/ivshmem-client/meson.build | 2 +-
> cont
On 03/09/20 17:42, Vladimir Sementsov-Ogievskiy wrote:
>
>
> so no timer exists now: reconnect code goes to yield during drain, to
> continue after drain-end.. Haha, that's obviously bad design, as nobody
> will wake up the waiting requests, and drain will hang forever. OK
> thanks, you helped me
Hi
On Thu, Sep 3, 2020 at 7:33 PM Bruce Rogers wrote:
> Ever since commit 537fe2d63f744e7c96ff45b60d09486a81958e06 there
> has been a 'linkage' to sdl for compiling baum.c. Originally it
> had to do with including sdl cflags for any file including sdl
> headers. There is no longer any such need
On 03/09/20 16:24, Edgar E. Iglesias wrote:
>> [*] I do wonder about hardware-device-passthrough setups; I
>> don't think I would care to pass through an arbitrary device
>> to an untrusted guest...
> Hmm, I guess it would make sense to have a configurable option in KVM
> to isolate passthrough dev
On Donnerstag, 3. September 2020 17:41:23 CEST Greg Kurz wrote:
> On Thu, 3 Sep 2020 17:19:31 +0200
>
> Greg Kurz wrote:
> > On Thu, 3 Sep 2020 16:41:02 +0200
> >
> > Christian Schoenebeck wrote:
> > > I have updated the QEMU 9P setup wiki page about this 'msize' issue. For
> > > some reason th
On Thu, Sep 03, 2020 at 05:44:25PM +0200, Paolo Bonzini wrote:
> On 03/09/20 17:35, Bruce Rogers wrote:
> > Turn on the meson install flag for these executables
> >
> > Signed-off-by: Bruce Rogers
> > ---
> > contrib/ivshmem-client/meson.build | 2 +-
> > contrib/ivshmem-server/meson.build | 2 +
On Thu, Sep 03, 2020 at 05:46:39PM +0200, Paolo Bonzini wrote:
> On 03/09/20 16:24, Edgar E. Iglesias wrote:
> >> [*] I do wonder about hardware-device-passthrough setups; I
> >> don't think I would care to pass through an arbitrary device
> >> to an untrusted guest...
> > Hmm, I guess it would mak
Dne 02. 09. 20 v 12:21 Thomas Huth napsal(a):
> On 02/09/2020 10.37, Paolo Bonzini wrote:
>> On 02/09/20 10:19, Daniel P. Berrangé wrote:
>>> On Wed, Sep 02, 2020 at 04:00:46AM -0400, Paolo Bonzini wrote:
check-block has its own test harness, unlike every other test. If
we capture its ou
On Tue, 1 Sep 2020 at 13:45, Cédric Le Goater wrote:
>
> The following changes since commit 2f4c51c0f384d7888a04b4815861e6d5fd244d75:
>
> Merge remote-tracking branch
> 'remotes/kraxel/tags/usb-20200831-pull-request' into staging (2020-08-31
> 19:39:13 +0100)
>
> are available in the Git repos
On 9/3/20 4:01 PM, Philippe Mathieu-Daudé wrote:
> On 9/3/20 9:08 AM, P J P wrote:
>> From: Prasad J Pandit
>>
>> While doing multi block SDMA, transfer block size may exceed
>> the 's->fifo_buffer[s->buf_maxsz]' size. It may leave the
>> current element pointer 's->data_count' pointing out of bou
On Thu, 3 Sep 2020 16:20:21 +0200
Christian Schoenebeck wrote:
> It is essential to choose a reasonable high value for 'msize' to avoid
> severely degraded file I/O performance. This parameter can only be
> chosen on client/guest side, and a Linux client defaults to an 'msize'
> of only 8192 if t
Devices on hppa occupy at least 4k starting at the HPA, so MEMORY_HPA+4k is
blocked (by Linux) for the memory module. I noticed this when testing the new
Linux kernel patch to let the fw_cfg entries show up in Linux under /proc.
The Linux kernel driver could not allocate the region for fw_cfg.
Thi
Simplify the code by using new introduced ADDR_TO_Y() and ADDR_TO_X()
macros. Those macros extract the x/y-coordinate from the given uint32.
As further simplification the extraction of the x/y coordinates for
VRAM_WRITE_INCR_Y and VRAM_WRITE_INCR_X can be done centrally in
vram_bit_write(), so mov
hppa power button support, graphics updates and firmware fixes
The following changes since commit ac8b279f13865d1a4f1958d3bf34240c1c3af90d:
Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20200827' into
staging (2020-08-27 13:48:12 +0100)
are available in the Git repository at:
ht
Reviewed-by: Richard Henderson
Signed-off-by: Helge Deller
---
hw/hppa/machine.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c
index e9d84d0f03..4b35afc9d5 100644
--- a/hw/hppa/machine.c
+++ b/hw/hppa/machine.c
@@ -58,6 +58,12 @@ static uint64
Previous name didn't reflect the iommu operation.
Signed-off-by: Eugenio Pérez
Reviewed-by: Peter Xu
Reviewed-by: David Gibson
Reviewed-by: Juan Quintela
Reviewed-by: Eric Auger
---
include/exec/memory.h | 6 +++---
hw/arm/smmu-common.c | 2 +-
hw/arm/smmuv3.c | 2 +-
hw/i386/intel_io
Adjust the ADDR_TO_Y() macro to extract 11 bits, which allows userspace
to address screen sizes up to 2048 lines (instead of 1024 before).
Signed-off-by: Helge Deller
Reviewed-by: Richard Henderson
---
hw/display/artist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/di
This way we can tell between regular IOMMUTLBEntry (entry of IOMMU
hardware) and notifications.
In the notifications, we set explicitly if it is a MAPs or an UNMAP,
instead of trusting in entry permissions to differentiate them.
Signed-off-by: Eugenio Pérez
Reviewed-by: Peter Xu
Reviewed-by: Ju
Change QEMU_FW_CFG_IO_BASE to shorter variant FW_CFG_IO_BASE and hand
over the actual port address in %r19 to SeaBIOS.
Signed-off-by: Helge Deller
Reviewed-by: Richard Henderson
---
hw/hppa/hppa_hardware.h | 2 +-
hw/hppa/machine.c | 7 ++-
2 files changed, 7 insertions(+), 2 deletion
On Thu, Sep 03, 2020 at 02:47:33PM +0200, Philippe Mathieu-Daudé wrote:
> On 9/3/20 12:42 AM, Eduardo Habkost wrote:
> > This will make the type name constant consistent with the name of
> > the type checking macro.
> >
> > Signed-off-by: Eduardo Habkost
> > ---
> > Cc: "Michael S. Tsirkin"
> >
I am able to hit this assertion when a Red Hat 7 guest virtio_net device
raises an "Invalidation" of all the TLB entries. This happens in the
guest's startup if 'intel_iommu=on' argument is passed to the guest
kernel and right IOMMU/ATS devices are declared in qemu's command line.
Command line:
/h
Device IOTLB invalidations can unmap arbitrary ranges, eiter outside of
the memory region or even [0, ~0ULL] for all the space. The assertion
could be hit by a guest, and rhel7 guest effectively hit it.
Signed-off-by: Eugenio Pérez
Reviewed-by: Peter Xu
Reviewed-by: Juan Quintela
---
softmmu/m
Artist hardware is limited to 2048 x 2048 pixels.
STI ROMs allow at minimum 640 x 480 pixels.
Qemu users can adjust the screen size on the command line with:
-global artist.width=800 -global artist.height=600
but we need to ensure that the screen size stays inside the given
boundaries, otherwise
Until now the TLB size was fixed at 256 entries. To allow operating
systems to utilize more TLB entries in the future, we need to tell
firmware how many TLB entries we actually support in the emulation.
Firmware then reports this to the operating system via the
PDC_CACHE_INFO call.
This patch simp
On 9/3/20 6:32 AM, Peter Maydell wrote:
> In the Neon instructions, some instruction formats have a 2-bit size
> field which corresponds exactly to QEMU's MO_8/16/32/64. However the
> floating-point insns in the 3-same group have a 1-bit size field
> which is "0 for 32-bit float and 1 for 16-bit f
On Thu, 03 Sep 2020 17:48:33 +0200
Christian Schoenebeck wrote:
> On Donnerstag, 3. September 2020 17:41:23 CEST Greg Kurz wrote:
> > On Thu, 3 Sep 2020 17:19:31 +0200
> >
> > Greg Kurz wrote:
> > > On Thu, 3 Sep 2020 16:41:02 +0200
> > >
> > > Christian Schoenebeck wrote:
> > > > I have upda
The current qemu hppa emulation emulates a PA1.1 CPU, which can only execute
the 32-bit instruction set. For unknown 64-bit instructions, a instruction trap
is sent to the virtual CPU.
This behaviour is correct in the sense that we emulate what the PA1.1
specification says.
But when trying to boot
Emulate a power button switch, tell SeaBIOS the address via fw_cfg and
bind the power button to the qemu UI.
Signed-off-by: Helge Deller
Reviewed-by: Richard Henderson
---
hw/hppa/machine.c | 32
1 file changed, 32 insertions(+)
diff --git a/hw/hppa/machine.c b
On Thu, Sep 03, 2020 at 02:53:52PM +0200, Philippe Mathieu-Daudé wrote:
> On 9/3/20 12:42 AM, Eduardo Habkost wrote:
> > This will make the type name constant consistent with the name of
> > the type checking macro.
> >
> > Signed-off-by: Eduardo Habkost
> > ---
> > Cc: "Michael S. Tsirkin"
> >
On Thu, 2020-09-03 at 16:49 +0100, Daniel P. Berrangé wrote:
> On Thu, Sep 03, 2020 at 05:44:25PM +0200, Paolo Bonzini wrote:
> > On 03/09/20 17:35, Bruce Rogers wrote:
> > > Turn on the meson install flag for these executables
> > >
> > > Signed-off-by: Bruce Rogers
> > > ---
> > > contrib/ivsh
On 9/3/20 6:32 AM, Peter Maydell wrote:
> The VCMLA and VCADD insns have a size field which is 0 for fp16
> and 1 for fp32 (note that this is the reverse of the Neon 3-same
> encoding!). Convert it to MO_* values in decode for consistency.
>
> Signed-off-by: Peter Maydell
> ---
> target/arm/neon
This allows us to differentiate between regular IOMMU map/unmap events
and DEVIOTLB unmap. Doing so, notifiers that only need device IOTLB
invalidations will not receive regular IOMMU unmappings.
Adapt intel and vhost to use it.
Signed-off-by: Eugenio Pérez
Reviewed-by: Peter Xu
Reviewed-by: Ju
On Donnerstag, 3. September 2020 18:02:48 CEST Greg Kurz wrote:
> > diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
> > index 7bb994bbf2..99b6f24fd6 100644
> > --- a/hw/9pfs/9p.c
> > +++ b/hw/9pfs/9p.c
> > @@ -1353,6 +1353,15 @@ static void coroutine_fn v9fs_version(void *opaque)
> >
> > goto ou
Although they didn't reach the notifier because of the filtering in
memory_region_notify_iommu_one, the vt-d was still splitting huge
memory invalidations in chunks. Skipping it.
This improves performance in case of netperf with vhost-net:
* TCP_STREAM: From 1923.6Mbit/s to 2175.13Mbit/s (13%)
* T
On Thu, Sep 03, 2020 at 02:59:00PM +0200, Philippe Mathieu-Daudé wrote:
> On 9/3/20 12:42 AM, Eduardo Habkost wrote:
> > Rename macros to names that are unique in the source tree, to
> > reduce confusion and make automated conversion of the code
> > easier.
> >
> > Signed-off-by: Eduardo Habkost
On Thu, Sep 03, 2020 at 02:45:12PM +0200, Philippe Mathieu-Daudé wrote:
> On 9/3/20 12:42 AM, Eduardo Habkost wrote:
> > This will make the type name constant consistent with the name of
> > the type checking macro.
> >
> > Signed-off-by: Eduardo Habkost
> > ---
> > Cc: "Hervé Poussineau"
> >
On Thu, Sep 03, 2020 at 02:47:03PM +0200, Philippe Mathieu-Daudé wrote:
> On 9/3/20 12:42 AM, Eduardo Habkost wrote:
> > This will make the type name constant consistent with the name of
> > the type checking macro.
> >
> > Signed-off-by: Eduardo Habkost
> > ---
> > Cc: "Michael S. Tsirkin"
> >
On Thu, Sep 03, 2020 at 03:01:33PM +0200, Philippe Mathieu-Daudé wrote:
> On 9/3/20 12:42 AM, Eduardo Habkost wrote:
> > Make the type checking macro name consistent with the TYPE_*
> > constant.
> >
> > Signed-off-by: Eduardo Habkost
> > ---
> > Cc: Mark Cave-Ayland
> > Cc: Laurent Vivier
> >
On Thu, Sep 03, 2020 at 02:56:20PM +0200, Philippe Mathieu-Daudé wrote:
> On 9/3/20 12:42 AM, Eduardo Habkost wrote:
> > This will make the type name constant consistent with the name of
> > the type checking macro.
> >
> > Signed-off-by: Eduardo Habkost
> > ---
> > Cc: Gerd Hoffmann
> > Cc: qe
Hi,
here are the changes from v1:
- Split changes into three different patches.
- Rewrite the documentation of qcow2_alloc_cluster_offset() [Max]
- Use peek_file_be in the test case to read the offset of the refcount
table [Max].
- Extend the list of unsupported options for the test case [Max].
The current text corresponds to an earlier, simpler version of this
function and it does not explain how it works now.
Signed-off-by: Alberto Garcia
---
block/qcow2-cluster.c | 24 ++--
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/block/qcow2-cluster.c b/bl
On 9/3/20 6:32 AM, Peter Maydell wrote:
> Convert the insns using the 2reg_vcvt and 2reg_vcvt_f16 formats
> to pass the size through to the trans function as a MO_* value
> rather than the '0==f32, 1==f16' used in the fp 3-same encodings.
>
> Signed-off-by: Peter Maydell
> ---
> target/arm/neon-
In the past, when a new cluster was allocated the l2meta structure was
a variable in the stack so it was necessary to have a way to tell
whether it had been initialized and contained valid data or not. The
nb_clusters field was used for this purpose. Since commit f50f88b9fe
this is no longer the ca
On Thu, Sep 03, 2020 at 02:55:06PM +0200, Philippe Mathieu-Daudé wrote:
> On 9/3/20 12:42 AM, Eduardo Habkost wrote:
> > This will make the type name constant consistent with the name of
> > the type checking macro.
> >
> > Signed-off-by: Eduardo Habkost
> > ---
> > Cc: Paolo Bonzini
> > Cc: Fa
When a write request needs to allocate new clusters (or change the L2
bitmap of existing ones) a QCowL2Meta structure is created so the L2
metadata can be later updated and any copy-on-write can be performed
if necessary.
A write request can span a region consisting of an arbitrary
combination of
On Thu, Sep 03, 2020 at 12:18:09PM -0400, Eduardo Habkost wrote:
> On Thu, Sep 03, 2020 at 02:47:03PM +0200, Philippe Mathieu-Daudé wrote:
> > On 9/3/20 12:42 AM, Eduardo Habkost wrote:
> > > This will make the type name constant consistent with the name of
> > > the type checking macro.
> > >
On Thu, Sep 03, 2020 at 12:19:46PM -0400, Eduardo Habkost wrote:
> On Thu, Sep 03, 2020 at 02:47:33PM +0200, Philippe Mathieu-Daudé wrote:
> > On 9/3/20 12:42 AM, Eduardo Habkost wrote:
> > > This will make the type name constant consistent with the name of
> > > the type checking macro.
> > >
> >
On Wed, Sep 02, 2020 at 06:42:08PM -0400, Eduardo Habkost wrote:
> Reducing boilerplate QOM code using the new OBJECT_DEFINE_* and
> OBJECT_DECLARE_* macros is quite difficult when there are
> multiple ways a TYPE_* constant name is written.
>
> This series renames many type checking macros and/or
On 9/3/20 7:44 AM, Peter Maydell wrote:
> Implement a model of the MPS2 with the AN386 firmware. This is
> essentially identical to the AN385 firmware, but it has a
> Cortex-M4 rather than a Cortex-M3.
>
> Signed-off-by: Peter Maydell
> ---
> hw/arm/mps2.c | 30 +++---
>
On 9/3/20 8:22 AM, Daniel P. Berrangé wrote:
> We're going to have multiple callers to open() from qemu_open()
> soon. Readability would thus benefit from having a helper for
> dealing with O_CLOEXEC.
>
> Reviewed-by: Markus Armbruster
> Signed-off-by: Daniel P. Berrangé
> ---
> util/osdep.c |
On 9/3/20 8:22 AM, Daniel P. Berrangé wrote:
> Currently code has to call monitor_fdset_get_fd, then dup
> the return fd, and then add the duplicate FD back into the
> fdset. This dance is overly verbose for the caller and
> introduces extra failure modes which can be avoided by
> folding all the l
On 9/3/20 8:22 AM, Daniel P. Berrangé wrote:
> We want to introduce a new version of qemu_open() that uses an Error
> object for reporting problems and make this it the preferred interface.
> Rename the existing method to release the namespace for the new impl.
>
> Reviewed-by: Eric Blake
> Revie
On 9/3/20 8:22 AM, Daniel P. Berrangé wrote:
> This simple refactoring prepares for future patches. The variadic args
> handling is split from the main bulk of the open logic.
>
> Reviewed-by: Markus Armbruster
> Signed-off-by: Daniel P. Berrangé
> ---
> util/osdep.c | 24 +-
On 9/3/20 8:22 AM, Daniel P. Berrangé wrote:
> qemu_open_old() works like open(): set errno and return -1 on failure.
> It has even more failure modes, though. Reporting the error clearly
> to users is basically impossible for many of them.
>
> Our standard cure for "errno is too coarse" is the E
On 9/3/20 8:22 AM, Daniel P. Berrangé wrote:
> Instead of relying on the limited information from errno, we can now
> also provide detailed error messages to callers that ask for it.
>
> Reviewed-by: Markus Armbruster
> Signed-off-by: Daniel P. Berrangé
> ---
> util/osdep.c | 15 +--
On Thu, Sep 03, 2020 at 05:44:29PM +0100, Daniel P. Berrangé wrote:
> On Thu, Sep 03, 2020 at 12:18:09PM -0400, Eduardo Habkost wrote:
> > On Thu, Sep 03, 2020 at 02:47:03PM +0200, Philippe Mathieu-Daud̮̩
> > wrote:
> > > On 9/3/20 12:42 AM, Eduardo Habkost wrote:
> > > > This will make the
On 9/3/20 8:22 AM, Daniel P. Berrangé wrote:
> A common error scenario is to tell QEMU to use O_DIRECT in combination
> with a filesystem that doesn't support it. To aid users to diagnosing
> their mistake we want to provide a clear error message when this happens.
>
> Reviewed-by: Markus Armbrust
On 9/3/20 8:22 AM, Daniel P. Berrangé wrote:
> Currently at startup if using cache=none on a filesystem lacking
> O_DIRECT such as tmpfs, at startup QEMU prints
>
> qemu-system-x86_64: -drive file=/tmp/foo.img,cache=none: file system may not
> support O_DIRECT
> qemu-system-x86_64: -drive file=/t
On Thu, Sep 3, 2020 at 2:05 AM David Gibson wrote:
>
> On Wed, Sep 02, 2020 at 04:24:50PM +0200, Auger Eric wrote:
> > Hi Eugenio,
> >
> > On 9/1/20 4:26 PM, Eugenio Pérez wrote:
> > > Signed-off-by: Eugenio Pérez
> > Please could you explain in the commit message why you need to remove
> > the a
Your pipeline has failed.
Project: QEMU ( https://gitlab.com/qemu-project/qemu )
Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master )
Commit: 3dd23a4f (
https://gitlab.com/qemu-project/qemu/-/commit/3dd23a4fb8fd72d2220a90a809f213999ffe7f3a
)
Commit Message: Merge remote-tr
On 9/3/20 4:21 AM, Alex Bennée wrote:
> One of the Travis builds was complaining about:
>
> qemu/include/tcg/tcg.h:437:12: error: ‘cond’ may be used uninitialized in
> this function [-Werror=maybe-uninitialized]
>return (TCGCond)(c ^ 1);
> ../target/mips/translate.c:20031:13: note: ‘c
On 9/3/20 1:31 AM, Yonggang Luo wrote:
> Rename function dup_const to dup_const_eval for avoid confliction with macro
> dup_const
>
> The link error on msys2
>
> Linking target qemu-system-alpha.exe
> C:/CI-Tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-ming
Am 03.09.2020 um 14:54 hat Max Reitz geschrieben:
> On 02.09.20 13:03, Kevin Wolf wrote:
> > It is convenient to be able to edit the tests and run them without
> > changing the current working directory back and forth. Instead of
> > assuming that $PWD is the qemu-iotests build directory, derive th
On Thu, Sep 03, 2020 at 12:16:47PM -0400, Eduardo Habkost wrote:
> On Thu, Sep 03, 2020 at 02:45:12PM +0200, Philippe Mathieu-Daudé wrote:
> > On 9/3/20 12:42 AM, Eduardo Habkost wrote:
> > > This will make the type name constant consistent with the name of
> > > the type checking macro.
> > >
>
Still trying to fix the bugs reported by Aleksander...
- Do not send 0 block count
- Reduce DMA to MMIO re-entrancy by yielding when pending IRQ
Based-on: <20200901140411.112150-1-f4...@amsat.org>
Philippe Mathieu-Daudé (4):
hw/sd/sdhci: Stop multiple transfers when block count is cleared
hw
If we have pending DMA requests scheduled, process them first.
So far we don't need to implement a bottom half to process them.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sd/sdhci.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index 703357e9
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sd/sdhci.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index 2b197631870..06cb098036c 100644
--- a/hw/sd/sdhci.c
+++ b/hw/sd/sdhci.c
@@ -215,9 +215,14 @@ static uint8_t sdhci_slotint(SDHCIS
The Descriptor Table has a bit to allow the DMA to generates
Interrupt when the operation of the descriptor line is completed
(see "1.13.4. Descriptor Table" of 'SD Host Controller Simplified
Specification Version 2.00').
If we have pending interrupt and the descriptor requires it
to be generated
Clearing BlockCount stops multiple transfers.
See "SD Host Controller Simplified Specification Version 2.00":
- 2.2.3. Block Count Register (Offset 006h)
- Table 2-8 : Determination of Transfer Type
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sd/sdhci.c | 7 ++-
1 file changed, 6 insertio
+-- On Thu, 3 Sep 2020, Philippe Mathieu-Daudé wrote --+
| > -assert(s->data_count <= s->buf_maxsz && s->data_count > begin);
| > +assert(s->data_count <= s->buf_maxsz);
| > +assert(s->data_count > begin);
|
| Doesn't seem enough, guest crash here, having:
|
|
+-- On Thu, 3 Sep 2020, Philippe Mathieu-Daudé wrote --+
| If you don't mind I might split the assert in 2 when applying:
|
| -assert(s->data_count <= s->buf_maxsz && s->data_count > begin);
| +assert(s->data_count <= s->buf_maxsz);
| +assert(s->data_count > beg
On 03/09/20 17:43, Rohit Shinde wrote:
> I am interested in contributing to the implementation of the BusLogic
> adapter. I saw on the doc pages of QEMU that it is an incomplete
> adaptation and I would like to take it further and complete it.
>
Hi, the BT-958 is not available at all in QEMU. Wh
On 03/09/20 17:50, Edgar E. Iglesias wrote:
>>> Hmm, I guess it would make sense to have a configurable option in KVM
>>> to isolate passthrough devices so they only can DMA to guest RAM...
>>
>> Passthrough devices are always protected by the IOMMU, anything else
>> would be obviously insane^H^H^H
On 03/09/20 17:49, Daniel P. Berrangé wrote:
> On Thu, Sep 03, 2020 at 05:44:25PM +0200, Paolo Bonzini wrote:
>> On 03/09/20 17:35, Bruce Rogers wrote:
>>> Turn on the meson install flag for these executables
>>>
>>> Signed-off-by: Bruce Rogers
>>> ---
>>> contrib/ivshmem-client/meson.build | 2 +
Rename type checking function to be consistent with the type name
constant (TYPE_ISA_PIT) and type name string ("isa-pit").
Suggested-by: "Daniel P. Berrangé"
Signed-off-by: Eduardo Habkost
---
Cc: "Michael S. Tsirkin"
Cc: Paolo Bonzini
Cc: qemu-devel@nongnu.org
---
hw/timer/i8254.c | 6 +++--
This will make the type name constant consistent with the name of
the QOM type ("isa-pit").
Suggested-by: "Daniel P. Berrangé"
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2:
* v1 subject was: "i8254: Rename TYPE_I8254 to TYPE_PIT"
* Rename it to TYPE_ISA_PIT instead of TYPE_PIT,
to be c
Reducing boilerplate QOM code using the new OBJECT_DEFINE_* and
OBJECT_DECLARE_* macros is quite difficult when there are
multiple ways a TYPE_* constant name is written.
This series renames many type checking macros and/or TYPE_*
constants to make sure they are consistent.
This is a second pass
Rename the type checking function to be consistent with the type
name constant (TYPE_ISA_I8259) and the QOM type name string
("isa-i8259").
Suggested-by: Philippe Mathieu-Daudé
Suggested-by: "Daniel P. Berrangé"
Signed-off-by: Eduardo Habkost
---
Cc: "Michael S. Tsirkin"
Cc: Paolo Bonzini
Cc:
This will make the type name constant consistent with QOM
type name string ("isa-i8259").
Suggested-by: Philippe Mathieu-Daudé
Suggested-by: "Daniel P. Berrangé"
Signed-off-by: Eduardo Habkost
---
Changes v1 ->v2:
* v1 subject was "i8259: Rename TYPE_I8259 to TYPE_PIC"
* Rename it to TYPE_ISA_I
On 03/09/20 17:29, Bruce Rogers wrote:
> Ever since commit 537fe2d63f744e7c96ff45b60d09486a81958e06 there
> has been a 'linkage' to sdl for compiling baum.c. Originally it
> had to do with including sdl cflags for any file including sdl
> headers. There is no longer any such need for baum.c, but th
Rename the type checking function to be consistent with the type
name constant (TYPE_KVM_I8259) and type name string
("kvm-i8259").
Suggested-by: Philippe Mathieu-Daudé
Suggested-by: "Daniel P. Berrangé"
Signed-off-by: Eduardo Habkost
---
Cc: "Michael S. Tsirkin"
Cc: Marcel Apfelbaum
Cc: Paol
Rename the type checking function to be consistent with the type
name constant (TYPE_AM53C974) and type name string ("am53c974").
Suggested-by: Philippe Mathieu-Daudé
Suggested-by: "Daniel P. Berrangé"
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2:
* New patch added to series v2
---
Cc: P
Make type checking function name consistent with the TYPE_TUSB6010
constant and QOM type name ("tusb6010").
Suggested-by: Philippe Mathieu-Daudé
Suggested-by: "Daniel P. Berrangé"
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2:
* v1 subject was "tusb6010: Rename TYPE_TUSB6010 to TYPE_TUSB"
This will make the type name constant consistent with the QOM
type name string ("am53c974").
Suggested-by: Philippe Mathieu-Daudé
Suggested-by: "Daniel P. Berrangé"
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2:
* v1 subject was "scsi: Rename TYPE_AM53C974_DEVICE to TYPE_PCI_ESP"
* Rename
On Thu, 3 Sep 2020 at 17:25, Richard Henderson
wrote:
>
> On 9/3/20 6:32 AM, Peter Maydell wrote:
> > I wanted to call the field %3same_fp_size, but decodetree
> > doesn't seem to allow a field starting with a digit, even
> > though it does allow a format that starts with a digit.
> > So it's %fp_
On 8/25/20 2:16 AM, Havard Skinnemoen via wrote:
> I also pushed this and the previous patchsets to my qemu fork on github.
> The branches are named npcm7xx-v[1-8].
>
> https://github.com/hskinnemoen/qemu
>
> This patch series models enough of the Nuvoton NPCM730 and NPCM750 SoCs to
> boot
> a
From: Prasad J Pandit
When cancelling an i/o operation via ide_cancel_dma_sync(),
a block pointer may be null. Add check to avoid null pointer
dereference.
-> https://ruhr-uni-bochum.sciebo.de/s/NNWP2GfwzYKeKwE?path=%2Fide_nullptr1
==1803100==Hint: address points to the zero page.
#0 blk_bs .
+-- On Thu, 27 Aug 2020, P J P wrote --+
| +-- On Mon, 17 Aug 2020, P J P wrote --+
| | +-- On Mon, 17 Aug 2020, Philippe Mathieu-Daudé wrote --+
| | | On 8/17/20 7:02 AM, P J P wrote:
| | | > +-- On Sun, 16 Aug 2020, Philippe Mathieu-Daudé wrote --+
| | | > | What about read_with_attrs()/write_wit
If vhostdev is not provided QEMU crashes, and more generally
vhost-vdpa doesn't explain why parameters are wrong.
This series fixes that.
Laurent Vivier (2):
vhost-vdpa: define and use default value for vhostdev
vhost-vdpa: improve error reporting
net/vhost-vdpa.c | 19 +++
vhostdev is defined as optional in net.json, and if not set
/dev/vhost-vdpa-0 should be used.
The default value is not set and if vhostdev is not provided
QEMU crashes with a SIGSEGV exception.
Fixes: 1e0a84ea49b6 ("vhost-vdpa: introduce vhost-vdpa net client")
Cc: l...@redhat.com
Signed-off-by:
Use Error framework to report the id of the device and the details of
the error (vhostdev name and errno).
For instance:
qemu-system-x86_64 ... -netdev vhost-vdpa,id=hostnet1 ...
hostnet1: Cannot open '/dev/vhost-vdpa-0': No such file or directory
Signed-off-by: Laurent Vivier
---
net/vhost-
On 8/25/20 2:17 AM, Havard Skinnemoen via wrote:
> If a -bios option is specified on the command line, load the image into
> the internal ROM memory region, which contains the first instructions
> run by the CPU after reset.
>
> If -bios is not specified, the vbootrom included with qemu is loaded
On 9/3/20 4:21 AM, Alex Bennée wrote:
> From: Daniel P. Berrangé
>
> If nettle is disabled and gcrypt enabled, the compiler and linker flags
> needed for gcrypt are not passed.
>
> Gnutls was also not added as a dependancy when gcrypt is enabled.
>
> Attempting to add the library dependencies a
In a recent commit 12c75e20a269ac we've improved
nbd_co_reconnect_loop() to not make drain wait for additional sleep.
Similarly, we shouldn't try to connect, if previous sleep was
interrupted by drain begin, otherwise drain_begin will have to wait for
the whole connection attempt.
Signed-off-by: V
We pause reconnect process during drained section. So, if we have some
requests, waiting for reconnect we should cancel them, otherwise they
deadlock the drained section.
How to reproduce:
1. Create an image:
qemu-img create -f qcow2 xx 100M
2. Start NBD server:
qemu-nbd xx
3. Start vm wi
Hi! Let's continue fixing nbd reconnect feature.
These series is based on "[PULL 0/6] NBD patches for 2020-09-02"
Based-on: <20200902215400.2673028-1-ebl...@redhat.com>
Vladimir Sementsov-Ogievskiy (4):
block/nbd: fix drain dead-lock because of nbd reconnect-delay
block/nbd: correctly use qio
301 - 400 of 629 matches
Mail list logo
