Hi
On Tue, Aug 25, 2020 at 10:44 AM Gerd Hoffmann wrote:
> Dunno why the default is set to "always". IMHO it should be "auto",
> i.e. only colorize in case stdout goes to a terminal. Cluttering
> logfiles and confusing compiler message parsers with terminal control
> sequences is not nice ...
Le 25/08/2020 à 00:30, Filip Bozuta a écrit :
> This patch introduces functionality for following time64 syscalls:
>
> *ppoll_time64
>
> This is a year 2038 safe variant of:
>
> int poll(struct pollfd *fds, nfds_t nfds, int timeout)
> -- wait for some event on a file descriptor --
>
Le 25/08/2020 à 00:30, Filip Bozuta a écrit :
> This patch introduces functionality for following time64 syscalls:
>
> *ppoll_time64
>
> This is a year 2038 safe variant of:
>
> int poll(struct pollfd *fds, nfds_t nfds, int timeout)
> -- wait for some event on a file descriptor --
>
Le 25/08/2020 à 00:30, Filip Bozuta a écrit :
> This patch introduces functionality for following time64 syscalls:
>
> *utimensat_time64()
>
> int utimensat(int dirfd, const char *pathname,
> const struct timespec times[2], int flags);
> -- change file timestamps with na
On 8/25/20 8:01 AM, Joel Stanley wrote:
> On Wed, 19 Aug 2020 at 10:10, Cédric Le Goater wrote:
>>
>> Hello,
>>
>> This series includes various fixes improving the support of Aspeed
>> machines. Extra attention was given to the robustness of the ftgmac100
>> model. A small kernel module tester was
Il lun 24 ago 2020, 22:27 Mark Cave-Ayland
ha scritto:
>
> With this I can get all the way to the link phase so I think it's fairly
> close. I'm
> not sure whether these escaping/quoting problems are with meson or the way
> in which
> configure is using it?
>
You can try building with ninja to f
Queued, thanks.
Paolo
Il lun 24 ago 2020, 18:31 Daniel P. Berrangé ha
scritto:
> If Windows EXE files are built with -pie/-fpie they will fail to
> launch. Historically QEMU defaulted to disabling PIE for Windows,
> but this setting was accidentally lost when the configure summary
> text was re
Queued, thanks.
Paolo
Il lun 24 ago 2020, 17:52 Bruce Rogers ha scritto:
> The daxctl library needs to be linked against when daxctl is asked for
> in configure.
>
> Signed-off-by: Bruce Rogers
> ---
> configure | 1 +
> meson.build | 6 +-
> 2 files changed, 6 insertions(+), 1 deletion
Queued, thanks.
Paolo
Il lun 24 ago 2020, 17:52 Bruce Rogers ha scritto:
> Somehow in the conversion to meson, the module named chardev-baum got
> renamed to chardev-brlapi. Change it back.
>
> Signed-off-by: Bruce Rogers
> ---
> chardev/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1
On 24/08/2020 12:37, Gerd Hoffmann wrote:
>> 2) GTK UI now depends on CONFIG_VTE
>>
>> This one I spotted on my local Linux setup as I didn't have the libvte-dev
>> package
>> installed and couldn't understand why I couldn't run QEMU with the GTK UI as
>> I always
>> do, even though configure re
Queued, thanks.
Paolo
Il lun 24 ago 2020, 17:24 Laurent Vivier ha scritto:
> We don't need it with linux-user only build, and if xkbcommon dynamic
> library is detected it can break the build of static only binaries.
>
> So disable it if it is no explicitly asked by the user when neither
> syst
Great, thanks! Can you send it as a patch? I am collecting Meson fixes and
I should be able to send a pull request this week.
Also if you can please test the msys fixes that were sent on the list that
would be great.
Paolo
Il mar 25 ago 2020, 09:52 Mark Cave-Ayland
ha scritto:
> On 24/08/2020
Il lun 24 ago 2020, 00:58 Alexander Bulekov ha scritto:
> Hi Paolo,
> Our oss-fuzz builds started failing, after the meson merge. I think I
> tracked down the issues:
> 1.) Looking at the build-log here:
>
> https://oss-fuzz-build-logs.storage.googleapis.com/log-d43d402c-1ce5-4422-b3db-ccbf83a862
Build system parts
Acked-by: Paolo Bonzini
Il dom 23 ago 2020, 13:18 Thomas Huth ha scritto:
> Now that we can use all our QEMU build containers in the gitlab-CI,
> we can also run the cross-compilation jobs there. Of course, some
> problems have to be fixed first, so this is taken care of in
Queued, thanks.
Paolo
Il dom 23 ago 2020, 12:26 Thomas Huth ha scritto:
> When configure has been run with --with-pkgversion=xyz, the shell complains
> about a missing ']' in this script.
>
> Fixes: 2c273f32d3 ("meson: generate qemu-version.h")
> Signed-off-by: Thomas Huth
> ---
> scripts/qem
On Tue, Aug 25, 2020 at 10:59:42AM +0400, Marc-André Lureau wrote:
> Hi
>
> On Tue, Aug 25, 2020 at 10:44 AM Gerd Hoffmann wrote:
>
> > Dunno why the default is set to "always". IMHO it should be "auto",
> > i.e. only colorize in case stdout goes to a terminal. Cluttering
> > logfiles and con
Hi
On Tue, Aug 25, 2020 at 12:07 PM Gerd Hoffmann wrote:
> On Tue, Aug 25, 2020 at 10:59:42AM +0400, Marc-André Lureau wrote:
> > Hi
> >
> > On Tue, Aug 25, 2020 at 10:44 AM Gerd Hoffmann
> wrote:
> >
> > > Dunno why the default is set to "always". IMHO it should be "auto",
> > > i.e. only col
* Babu Moger (babu.mo...@amd.com) wrote:
> Hi Dave,
>
> On 8/24/20 1:41 PM, Dr. David Alan Gilbert wrote:
> > * Babu Moger (babu.mo...@amd.com) wrote:
> >> To support some of the complex topology, we introduced EPYC mode apicid
> >> decode.
> >> But, EPYC mode decode is running into problems. Als
Hi Paolo Bonzini,
I've already sent a series of fixes for msys, do you have a look at that?
On Tue, Aug 25, 2020 at 3:55 PM Paolo Bonzini wrote:
> Great, thanks! Can you send it as a patch? I am collecting Meson fixes and
> I should be able to send a pull request this week.
>
> Also if you can
On Mon, Aug 17, 2020 at 4:50 PM wrote:
> From: Frank Chang
>
> This patchset implements the vector extension v1.0 for RISC-V on QEMU.
>
> This patchset is sent as RFC because RVV v1.0 is still in draft state.
> v2 patchset was sent for RVV v0.9 and bumped to RVV v1.0 since v3 patchset.
>
> The p
From: Alberto Garcia
handle_alloc() creates a QCowL2Meta structure in order to update the
image metadata and perform the necessary copy-on-write operations.
This patch moves that code to a separate function so it can be used
from other places.
Signed-off-by: Alberto Garcia
Reviewed-by: Max Rei
The following changes since commit 30aa19446d82358a30eac3b556b4d6641e00b7c1:
Merge remote-tracking branch 'remotes/cschoenebeck/tags/pull-9p-20200812'
into staging (2020-08-24 16:39:53 +0100)
are available in the Git repository at:
https://github.com/XanClic/qemu.git tags/pull-block-2020-08
From: Alberto Garcia
Subcluster allocation in qcow2 is implemented by extending the
existing L2 table entries and adding additional information to
indicate the allocation status of each subcluster.
This patch documents the changes to the qcow2 format and how they
affect the calculation of the L2
From: Alberto Garcia
We are going to need it in other places.
Signed-off-by: Alberto Garcia
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id:
<65e5d9627ca2ebe7e62deaeddf60949c33067d9d.1594396418.git.be...@igalia.com>
Signed-off-by: Max Reitz
---
block/qcow2-clust
From: Alberto Garcia
The file_cluster_offset field of Qcow2AioTask stores a cluster-aligned
host offset. In practice this is not very useful because all users(*)
of this structure need the final host offset into the cluster, which
they calculate using
host_offset = file_cluster_offset + offse
From: Alberto Garcia
This patch adds QCow2SubclusterType, which is the subcluster-level
version of QCow2ClusterType. All QCOW2_SUBCLUSTER_* values have the
the same meaning as their QCOW2_CLUSTER_* equivalents (when they
exist). See below for details and caveats.
In images without extended L2 en
From: Alberto Garcia
When writing to a qcow2 file there are two functions that take a
virtual offset and return a host offset, possibly allocating new
clusters if necessary:
- handle_copied() looks for normal data clusters that are already
allocated and have a reference count of 1. In th
From: Alberto Garcia
Extended L2 entries are 128-bit wide: 64 bits for the entry itself and
64 bits for the subcluster allocation bitmap.
In order to support them correctly get/set_l2_entry() need to be
updated so they take the entry width into account in order to
calculate the correct offset.
From: Alberto Garcia
qcow2_get_cluster_offset() takes an (unaligned) guest offset and
returns the (aligned) offset of the corresponding cluster in the qcow2
image.
In practice none of the callers need to know where the cluster starts
so this patch makes the function calculate and return the fina
From: Alberto Garcia
This function will be used by the qcow2 code to check if an image has
subclusters or not.
At the moment this simply returns false. Once all patches needed for
subcluster support are ready then QEMU will be able to create and
read images with subclusters and this function wil
From: Alberto Garcia
When dealing with subcluster types there is a new value called
QCOW2_SUBCLUSTER_UNALLOCATED_ALLOC that has no equivalent in
QCow2ClusterType.
This patch handles that value in all places where subcluster types
are processed.
Signed-off-by: Alberto Garcia
Reviewed-by: Max Re
From: Alberto Garcia
There are situations in which we want to know how many contiguous
subclusters of the same type there are in a given cluster. This can be
done by simply iterating over the subclusters and repeatedly calling
qcow2_get_subcluster_type() for each one of them.
However once we det
From: Alberto Garcia
The size of an L2 entry is 64 bits, but if we want to have subclusters
we need extended L2 entries. This means that we have to access L2
tables and slices differently depending on whether an image has
extended L2 entries or not.
This patch replaces all l2_slice[] accesses wi
From: Alberto Garcia
For a given offset, return the subcluster number within its cluster
(i.e. with 32 subclusters per cluster it returns a number between 0
and 31).
Signed-off-by: Alberto Garcia
Reviewed-by: Max Reitz
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-Id:
<56e3e4ac0d827c6a2f
From: Alberto Garcia
If an image has subclusters then there are more copy-on-write
scenarios that we need to consider. Let's say we have a write request
from the middle of subcluster #3 until the end of the cluster:
1) If we are writing to a newly allocated cluster then we need
copy-on-write.
From: Alberto Garcia
This function returns an integer that can be either an error code or a
cluster type (a value from the QCow2ClusterType enum).
We are going to start using subcluster types instead of cluster types
in some functions so it's better to use the exact data types instead
of integer
From: Alberto Garcia
This field allows us to indicate that the L2 metadata update does not
come from a write request with actual data but from a preallocation
request.
For traditional images this does not make any difference, but for
images with extended L2 entries this means that the clusters a
From: Alberto Garcia
In order to support extended L2 entries some functions of the qcow2
driver need to start dealing with subclusters instead of clusters.
qcow2_get_host_offset() is modified to return the subcluster type
instead of the cluster type, and all callers are updated to replace
all va
From: Alberto Garcia
This patch adds the following new fields to BDRVQcow2State:
- subclusters_per_cluster: Number of subclusters in a cluster
- subcluster_size: The size of each subcluster, in bytes
- subcluster_bits: No. of bits so 1 << subcluster_bits = subcluster_size
Images without subclus
From: Alberto Garcia
The offset field of an uncompressed cluster's L2 entry must be aligned
to the cluster size, otherwise it is invalid. If the cluster has no
data then it means that the offset points to a preallocation, so we
can clear the offset field without affecting the guest-visible data.
From: Alberto Garcia
Like offset_into_cluster() and size_to_clusters(), but for
subclusters.
Signed-off-by: Alberto Garcia
Reviewed-by: Eric Blake
Reviewed-by: Max Reitz
Message-Id:
<3cc2390dcdef3d234d47c741b708bd8734490862.1594396418.git.be...@igalia.com>
Signed-off-by: Max Reitz
---
bloc
From: Alberto Garcia
Extended L2 entries are bigger than normal L2 entries so this has an
impact on the amount of metadata needed for a qcow2 file.
Signed-off-by: Alberto Garcia
Reviewed-by: Max Reitz
Message-Id:
<7efae2efd5e36b42d2570743a12576d68ce53685.1594396418.git.be...@igalia.com>
Signe
From: Alberto Garcia
The QCOW_OFLAG_ZERO bit that indicates that a cluster reads as
zeroes is only used in standard L2 entries. Extended L2 entries use
individual 'all zeroes' bits for each subcluster.
This must be taken into account when updating the L2 entry and also
when deciding that an exis
From: Alberto Garcia
The bdrv_co_pwrite_zeroes() call here fills complete clusters with
zeroes, but it can happen that some subclusters are not part of the
write request or the copy-on-write. This patch makes sure that only
the affected subclusters are overwritten.
A potential improvement would
From: Alberto Garcia
qcow2 images with subclusters have 128-bit L2 entries. The first 64
bits contain the same information as traditional images and the last
64 bits form a bitmap with the status of each individual subcluster.
Because of that we cannot assume that L2 entries are sizeof(uint64_t)
From: Yonggang Luo
---
scripts/mtest2make.py | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/scripts/mtest2make.py b/scripts/mtest2make.py
index bdb257bbd9..d7a51bf97e 100644
--- a/scripts/mtest2make.py
+++ b/scripts/mtest2make.py
@@ -53,9 +53,16 @@ i = 0
for tes
From: Alberto Garcia
The logic of this function remains pretty much the same, except that
it uses count_contiguous_subclusters(), which combines the logic of
count_contiguous_clusters() / count_contiguous_clusters_unallocated()
and checks individual subclusters.
qcow2_cluster_to_subcluster_type(
From: Alberto Garcia
The L2 bitmap needs to be updated after each write to indicate what
new subclusters are now allocated. This needs to happen even if the
cluster was already allocated and the L2 entry was otherwise valid.
In some cases however a write operation doesn't need change the L2
bitm
From: Alberto Garcia
This helper function tells us if a cluster is allocated (that is,
there is an associated host offset for it).
Signed-off-by: Alberto Garcia
Reviewed-by: Eric Blake
Reviewed-by: Max Reitz
Message-Id:
<6d8771c5c79cbdc6c519875a5078e1cc85856d63.1594396418.git.be...@igalia.co
From: Yonggang Luo
---
scripts/ninjatool.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/ninjatool.py b/scripts/ninjatool.py
index cc77d51aa8..6ca8be6f10 100755
--- a/scripts/ninjatool.py
+++ b/scripts/ninjatool.py
@@ -55,7 +55,7 @@ else:
PATH_RE = r"[^$\s:|]+|\
OK, I resend the patches in consecutive ways.
and for througfully fixes msys2 build, we need upstream meson pull request
https://github.com/mesonbuild/meson/pull/7637
On Tue, Aug 25, 2020 at 4:34 PM Paolo Bonzini wrote:
> I saw it, thanks. I would like to have someone else (like Mark) test it
>
From: Alberto Garcia
Two things need to be taken into account here:
1) With full_discard == true the L2 entry must be cleared completely.
This also includes the L2 bitmap if the image has extended L2
entries.
2) With full_discard == false we have to make the discarded cluster
read back
From: Yonggang Luo
---
meson.build | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/meson.build b/meson.build
index df5bf728b5..a3585881e1 100644
--- a/meson.build
+++ b/meson.build
@@ -224,8 +224,7 @@ if 'CONFIG_BRLAPI' in config_host
brlapi = declare_dependency(link_arg
From: Alberto Garcia
Now that the implementation of subclusters is complete we can finally
add the necessary options to create and read images with this feature,
which we call "extended L2 entries".
Signed-off-by: Alberto Garcia
Reviewed-by: Eric Blake
Reviewed-by: Max Reitz
Message-Id:
<647
From: Alberto Garcia
This works now at the subcluster level and pwrite_zeroes_alignment is
updated accordingly.
qcow2_cluster_zeroize() is turned into qcow2_subcluster_zeroize() with
the following changes:
- The request can now be subcluster-aligned.
- The cluster-aligned body of the req
I saw it, thanks. I would like to have someone else (like Mark) test it and
then I will include it.
Paolo
Il mar 25 ago 2020, 10:24 罗勇刚(Yonggang Luo) ha
scritto:
> Hi Paolo Bonzini,
> I've already sent a series of fixes for msys, do you have a look at that?
>
>
> On Tue, Aug 25, 2020 at 3:55 PM
From: Alberto Garcia
Signed-off-by: Alberto Garcia
Reviewed-by: Max Reitz
Message-Id:
Signed-off-by: Max Reitz
---
tests/qemu-iotests/271 | 901 +
tests/qemu-iotests/271.out | 726 ++
tests/qemu-iotests/group | 1 +
3 f
From: Alberto Garcia
This function is only used by qcow2_expand_zero_clusters() to
downgrade a qcow2 image to a previous version. This would require
transforming all extended L2 entries into normal L2 entries but this
is not a simple task and there are no plans to implement this at the
moment.
S
From: Alberto Garcia
Traditional qcow2 images don't allow preallocation if a backing file
is set. This is because once a cluster is allocated there is no way to
tell that its data should be read from the backing file.
Extended L2 entries have individual allocation bits for each
subcluster, and t
From: Alberto Garcia
Compressed clusters always have the bitmap part of the extended L2
entry set to 0.
Signed-off-by: Alberto Garcia
Reviewed-by: Max Reitz
Message-Id:
<04455b3de5dfeb9d1cfe1fc7b02d7060a6e09710.1594396418.git.be...@igalia.com>
Signed-off-by: Max Reitz
---
block/qcow2-cluste
From: Yonggang Luo
---
scripts/undefsym.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/undefsym.sh b/scripts/undefsym.sh
index b9ec332e95..8189308b2c 100755
--- a/scripts/undefsym.sh
+++ b/scripts/undefsym.sh
@@ -1,4 +1,4 @@
-#! /usr/bin/env bash
+#!/bin/sh
# B
From: Yonggang Luo
---
configure | 34 ++
1 file changed, 22 insertions(+), 12 deletions(-)
diff --git a/configure b/configure
index b8f5b81a67..a0e2b20877 100755
--- a/configure
+++ b/configure
@@ -13,8 +13,13 @@ export CCACHE_RECACHE=yes
# make source path a
On Tue, Aug 25, 2020 at 04:34:59PM +0800, luoyongg...@gmail.com wrote:
> From: Yonggang Luo
>
> ---
> scripts/undefsym.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/undefsym.sh b/scripts/undefsym.sh
> index b9ec332e95..8189308b2c 100755
> --- a/scripts/unde
On Tue, Aug 25, 2020 at 04:35:00PM +0800, luoyongg...@gmail.com wrote:
Please explain *why* the change is needed in the commit message.
ie explain what's broken with current code.
> From: Yonggang Luo
>
> ---
> configure | 34 ++
> 1 file changed, 22 insertions(
On Mon, Aug 24, 2020 at 03:24:31PM +0100, Daniel P. Berrangé wrote:
> On Sun, Aug 23, 2020 at 12:05:47PM +0300, Roman Bolshakov wrote:
> > dtrace on macOS uses unresolved symbols with a special prefix to define
> > probes [1], only headers should be generated for USDT (dtrace(1)). But
> > it doesn'
Subject line is way too long here. The explanation should be
in the commit message body, not the subject.
On Tue, Aug 25, 2020 at 04:34:57PM +0800, luoyongg...@gmail.com wrote:
> From: Yonggang Luo
>
> ---
> scripts/mtest2make.py | 11 +--
> 1 file changed, 9 insertions(+), 2 delet
Commit message subject is way too long. Put the explanation into
commit message body, not the subject line.
On Tue, Aug 25, 2020 at 04:34:56PM +0800, luoyongg...@gmail.com wrote:
> From: Yonggang Luo
>
> ---
> scripts/ninjatool.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Hi, works, msys2 sh compiled and run
On Tue, Aug 25, 2020 at 4:59 PM Daniel P. Berrangé
wrote:
> On Tue, Aug 25, 2020 at 04:34:59PM +0800, luoyongg...@gmail.com wrote:
> > From: Yonggang Luo
> >
> > ---
> > scripts/undefsym.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > d
Yes, I have already queued it.
Paolo
Il mar 25 ago 2020, 11:04 Roman Bolshakov ha
scritto:
> On Mon, Aug 24, 2020 at 03:24:31PM +0100, Daniel P. Berrangé wrote:
> > On Sun, Aug 23, 2020 at 12:05:47PM +0300, Roman Bolshakov wrote:
> > > dtrace on macOS uses unresolved symbols with a special pref
On Mon, Aug 24, 2020 at 04:57:31PM +0100, Peter Maydell wrote:
> On Mon, 24 Aug 2020 at 15:51, Eric Blake wrote:
> >
> > On 8/22/20 4:21 PM, Roman Bolshakov wrote:
> > > New meson/make build requires GNU make 3.82+ but macOS ships 3.81 even
> > > on Big Sur while homebrew provides GNU make 4.3 as
On Mon, 24 Aug 2020 at 22:54, Max Filippov wrote:
>
> On Mon, Aug 24, 2020 at 2:33 PM Peter Maydell
> wrote:
> > On Sat, 22 Aug 2020 at 20:48, Max Filippov wrote:
> > > On Sat, Aug 22, 2020 at 3:20 AM Philippe Mathieu-Daudé
> > > wrote:
> > > >
> > > > Where does that come from?
> > >
> > > G
On Tue, 25 Aug 2020 at 06:57, Thomas Huth wrote:
>
> On 24/08/2020 20.46, Peter Maydell wrote:
> > We don't mandate SPDX[*],
> > but it will do the job if you want to use it.
> >
> > [*] Mostly because nobody's cared enough to say "we should
> > standardize on this and convert existing files and a
On 8/24/20 8:49 PM, David Gibson wrote:
On Mon, Aug 24, 2020 at 08:45:12AM -0300, Daniel Henrique Barboza wrote:
[...]
LOPAPR support a somewhat asymmetrical NUMA setup in its current
form,
Huh, I didn't even realize that. What's the mechanism?
LOPAPR mentions that a single resourc
On 19.08.20 16:19, David Edmondson wrote:
> On Wednesday, 2020-08-19 at 15:11:37 +01, Stefan Hajnoczi wrote:
>
>> On Tue, Aug 18, 2020 at 12:08:36PM +0100, David Edmondson wrote:
>>> When using qemu-img to convert an image that is hosted on an HTTP
>>> server to some faster local (or pseudo-local)
On Mon, Aug 24, 2020 at 03:59:38PM +0100, Peter Maydell wrote:
> On Thu, 20 Aug 2020 at 14:32, Graeme Gregory wrote:
> >
> > A difference between sbsa platform and the virt platform is PSCI is
> > handled by ARM-TF in the sbsa platform. This means that the PSCI code
> > there needs to communicate
On Fri, Aug 21, 2020 at 03:49:11PM +0200, Philippe Mathieu-Daudé wrote:
> On 8/20/20 3:32 PM, Graeme Gregory wrote:
> > A difference between sbsa platform and the virt platform is PSCI is
> > handled by ARM-TF in the sbsa platform. This means that the PSCI code
> > there needs to communicate some o
On Tue, Aug 25, 2020 at 01:07:55AM +0300, Roman Bolshakov wrote:
> On Mon, Aug 24, 2020 at 09:37:07AM -0500, Eric Blake wrote:
> > On 8/22/20 4:21 PM, Roman Bolshakov wrote:
> > > @@ -38,6 +38,8 @@ then
> > > # This file is auto-generated by configure to support in-source tree
> > > # 'make' co
Hi
On Tue, Aug 25, 2020 at 4:17 AM wrote:
> From: Yonggang Luo
>
> ---
> meson.build | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index df5bf728b5..a3585881e1 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -224,8 +224,7 @@ if 'CONF
On 21.08.20 01:54, Nir Soffer wrote:
> If os.remove() fails to remove one of the paths, for example if the file
> was removed by the test, the cleanup loop would exit silently, without
> removing the rest of the files.
>
> Fixes: de263986b5dc
> Signed-off-by: Nir Soffer
> ---
> tests/qemu-iotest
On Tue, 25 Aug 2020 at 11:08, Graeme Gregory wrote:
>
> On Mon, Aug 24, 2020 at 03:59:38PM +0100, Peter Maydell wrote:
> > > +enum sbsa_secure_ec_powerstates {
> > > +SBSA_SECURE_EC_CMD_NULL,
> > > +SBSA_SECURE_EC_CMD_POWEROFF,
> > > +SBSA_SECURE_EC_CMD_REBOOT,
> >
> > The last two are
On Mon, Aug 24, 2020 at 12:12:53PM -0500, Eric Blake wrote:
> On 8/24/20 12:02 PM, Daniel P. Berrangé wrote:
> > Disabling these parts are sufficient to get the qemu-nbd program
> > compiling in a Windows build.
> >
> > Signed-off-by: Daniel P. Berrangé
> > ---
> > meson.build | 7 ++-
> >
We are already building the NBD client and server on Windows when it is
used via the main system emulator binaries. This demonstrates there is
no fundamental blocker to buildig the qemu-nbd binary too.
Changed in v2:
- Split second patch into two parts
- Use HAVE_NBD_DEVICE condition to disabl
The termsig_handler function is used by the client thread handling the
host NBD device connection to do a graceful shutdown. IOW, if we have
disabled NBD device support at compile time, we don't need the SIGTERM
handler. This fixes a build issue for Windows.
Signed-off-by: Daniel P. Berrangé
---
Disabling these parts are sufficient to get the qemu-nbd program
compiling in a Windows build.
Signed-off-by: Daniel P. Berrangé
---
meson.build | 7 ++-
qemu-nbd.c | 5 +
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/meson.build b/meson.build
index df5bf728b5..10718716
Any tool that uses sockets needs to call socket_init() in order to work
on the Windows platform.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrangé
---
qemu-img.c | 2 ++
qemu-io.c | 2 ++
qemu-nbd.c | 1 +
3 files changed, 5 insertions(+)
diff --git a/qemu-img.c b/qemu-img.c
index 530
On 21.08.20 01:54, Nir Soffer wrote:
> When this class was extracted from FilePath, the docstring was not
> updated for generating multiple files, and the example usage was
> referencing unrelated file.
>
> Fixes: de263986b5dc
> Signed-off-by: Nir Soffer
> ---
> tests/qemu-iotests/iotests.py | 1
On 21.08.20 01:54, Nir Soffer wrote:
> When this class was extracted from FilePath, the docstring was not
> updated for generating multiple files, and the example usage was
> referencing unrelated file.
>
> Fixes: de263986b5dc
> Signed-off-by: Nir Soffer
> ---
> tests/qemu-iotests/iotests.py | 1
On 21.08.20 01:54, Nir Soffer wrote:
> Accept variable number of names instead of a sequence:
>
> with FilePaths("a", "b", "c") as (a, b, c):
>
> The disadvantage is that base_dir must be used as kwarg:
>
> with FilePaths("a", "b", base_dir=soc_dir) as (sock1, sock2):
>
> But this is mo
From: Li Qiang
After build qemu with '-fsanitize=address' extra-cflags,
'make check' show following leak:
=
==44580==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 2500 byte(s) in 1 object(s) allocated from:
#0 0x7f
The following changes since commit 44423107e7b5731ef40c5c8632a5bad8b49d0838:
Merge remote-tracking branch 'remotes/xtensa/tags/20200821-xtensa' into
staging (2020-08-24 19:55:23 +0100)
are available in the Git repository at:
https://github.com/berrange/qemu tags/socket-next-pull-request
fo
On 21.08.20 01:54, Nir Soffer wrote:
> FilePath creates now one temporary file:
>
> with FilePath("a") as a:
>
> Or more:
>
> with FilePath("a", "b", "c") as (a, b, c):
>
> This is also the behavior of the file_path() helper, used by some of the
> tests. Now we have only 2 helpers for c
On Tue, Aug 25, 2020 at 08:27:28AM +0200, Markus Armbruster wrote:
> Philippe Mathieu-Daudé writes:
>
> > Cc'ing Markus
> >
> > On 8/20/20 9:06 PM, Daniel Henrique Barboza wrote:
> >> We do not implement hotplug in the vscsi bus, but we forgot to
> >> tell qdev about it. The result is that users
On 21.08.20 01:54, Nir Soffer wrote:
> Use list comprehension instead of append loop.
>
> Signed-off-by: Nir Soffer
> ---
> tests/qemu-iotests/iotests.py | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
On 25.08.2020 09:37, Markus Armbruster wrote:
Andrey Shinkevich writes:
Provide the possibility to pass the 'filter-node-name' parameter to the
block-stream job as it is done for the commit block job.
Signed-off-by: Andrey Shinkevich
Reviewed-by: Vladimir Sementsov-Ogievskiy
[...]
diff --
On Wed, Aug 19, 2020 at 08:11:42PM -0400, Eduardo Habkost wrote:
> The PL110 enum value name will conflict with the PL110 type cast
> checker, when we replace the existing macro with an inline
> function. Add a VERSION_ prefix to all pl110_version enum
> values, to avoid conflicts.
>
> Signed-off
On Wed, Aug 19, 2020 at 08:11:43PM -0400, Eduardo Habkost wrote:
> Some of the enum constant names conflict with the QOM type check
> macros (AW_H3_CCU, AW_H3_SYSCTRL). This needs to be addressed to
> allow us to transform the QOM type check macros into functions
> generated by OBJECT_DECLARE_TYPE
On Wed, Aug 19, 2020 at 08:11:44PM -0400, Eduardo Habkost wrote:
> Some of the enum constant names conflict with the QOM type check
> macros:
>
> ASPEED_GPIO
> ASPEED_I2C
> ASPEED_RTC
> ASPEED_SCU
> ASPEED_SDHCI
> ASPEED_SDMC
> ASPEED_VIC
> ASPEED_WDT
> ASPEED_XDMA
>
> This needs to be addressed
On Wed, Aug 19, 2020 at 08:11:45PM -0400, Eduardo Habkost wrote:
> Some of the enum constant names conflict with the QOM type check
> macros (IBEX_PLIC, IBEX_UART). This needs to be addressed to
> allow us to transform the QOM type check macros into functions
> generated by OBJECT_DECLARE_TYPE().
On Wed, Aug 19, 2020 at 08:11:46PM -0400, Eduardo Habkost wrote:
> Some of the enum constant names conflict with a QOM type check
> macro (SIFIVE_E_PRCI). This needs to be addressed to allow us to
> transform the QOM type check macros into functions generated by
> OBJECT_DECLARE_TYPE().
>
> Renam
On Wed, Aug 19, 2020 at 08:11:47PM -0400, Eduardo Habkost wrote:
> Some of the enum constant names conflict with the QOM type check
> macros (SIFIVE_U_OTP, SIFIVE_U_PRCI). This needs to be addressed
> to allow us to transform the QOM type check macros into functions
> generated by OBJECT_DECLARE_T
1 - 100 of 538 matches
Mail list logo
