On Wed, Aug 19, 2020 at 08:11:43PM -0400, Eduardo Habkost wrote: > Some of the enum constant names conflict with the QOM type check > macros (AW_H3_CCU, AW_H3_SYSCTRL). This needs to be addressed to > allow us to transform the QOM type check macros into functions > generated by OBJECT_DECLARE_TYPE(). > > Rename all the constants to AW_H3_DEV_*, to avoid conflicts. > > Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > --- > Changes v1 -> v2: > * Added more details to commit message > > --- > Cc: Beniamino Galvani <b.galv...@gmail.com> > Cc: Peter Maydell <peter.mayd...@linaro.org> > Cc: Niek Linnenbank <nieklinnenb...@gmail.com> > Cc: qemu-...@nongnu.org > Cc: qemu-devel@nongnu.org > --- > include/hw/arm/allwinner-h3.h | 62 ++++++++--------- > hw/arm/allwinner-h3.c | 124 +++++++++++++++++----------------- > hw/arm/orangepi.c | 6 +- > 3 files changed, 96 insertions(+), 96 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
