On Mon, 24 Aug 2020 at 22:54, Max Filippov <jcmvb...@gmail.com> wrote: > > On Mon, Aug 24, 2020 at 2:33 PM Peter Maydell <peter.mayd...@linaro.org> > wrote: > > On Sat, 22 Aug 2020 at 20:48, Max Filippov <jcmvb...@gmail.com> wrote: > > > On Sat, Aug 22, 2020 at 3:20 AM Philippe Mathieu-Daudé <f4...@amsat.org> > > > wrote: > > > > > > > > Where does that come from? > > > > > > Generated by xtensa processor generator, as one of many output artifacts. > > > > Is there anything different with the source for these cores > > compared to the ones we already have in the tree, or are > > these just "more cores, generated the same way as the old ones" ? > > They are generated the same way as the old ones, but they have different > configurations: they support FPU2000 and DFPU opcodes implemented > earlier in this series. I've added them to enable testing of these opcodes. > de233_fpu is supposed to be a platform for further xtensa gcc development.
OK, in that case I don't see any reason why we should keep them out of the tree. Which isn't to shut down the point Philippe has raised about generated sources, just that there's not much need to block this pullreq while we have that conversation since it's not a change from the status-quo. Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.2 for any user-visible changes. -- PMM
