Re: [PATCH] ide: Get rid of IDEDrive struct

2020-08-05 Thread Eduardo Habkost
On Wed, Aug 05, 2020 at 09:41:25PM +0100, Peter Maydell wrote: > On Wed, 5 Aug 2020 at 20:49, Eduardo Habkost wrote: > > > > The struct had a single field (IDEDevice dev), and is only used > > in the QOM type declarations and property lists. We can simply > > use the IDEDevice struct directly ins

Re: vhost-user protocol feature negotiation

2020-08-05 Thread Michael S. Tsirkin
On Wed, Aug 05, 2020 at 03:13:06PM +, Alyssa Ross wrote: > Quoting from the definition of VHOST_USER_SET_PROTOCOL_FEATURES in > vhost-user.rst: > > > Only legal if feature bit ``VHOST_USER_F_PROTOCOL_FEATURES`` is present in > > ``VHOST_USER_GET_FEATURES``. > > > > .. Note:: > >Slave

Re: [PATCH 0/6] fcntl, sockopt, and ioctl options

2020-08-05 Thread Shu-Chun Weng
Ping! Patchew: https://patchew.org/QEMU/cover.1595461447.git@google.com/ On Wed, Jul 22, 2020 at 5:19 PM Shu-Chun Weng wrote: > Hi Laurent, > > This is a series of 6 patches in 4 groups, putting into a single thread for > easier tracking. > > [PATCH 1/6] linux-user: Support F_ADD_SEALS and F

Re: [PATCH v2] linux-user: Add most IFTUN ioctls

2020-08-05 Thread Shu-Chun Weng
Ping: https://patchew.org/QEMU/20200723231020.769893-1-...@google.com/ On Thu, Jul 23, 2020 at 4:10 PM Shu-Chun Weng wrote: > The three options handling `struct sock_fprog` (TUNATTACHFILTER, > TUNDETACHFILTER, and TUNGETFILTER) are not implemented. Linux kernel > keeps a user space pointer in th

Re: [PATCH 0/2] Instruction set detection for clang.

2020-08-05 Thread Shu-Chun Weng
Ping: https://patchew.org/QEMU/cover.1595463707.git@google.com/ On Wed, Jul 22, 2020 at 5:27 PM Shu-Chun Weng wrote: > Currently when configuring QEMU with clang, AVX2, AVX512F, ATOMIC64, and > ATOMIC128 are all disabled because the detection code is GCC-only. With > these > two patches, I a

Re: Adding VHOST_USER_PROTOCOL_F_CONFIG_MEM_SLOTS to 5.1 release notes

2020-08-05 Thread Raphael Norwitz
ping On Wed, Jul 29, 2020 at 9:17 PM Raphael Norwitz wrote: > > How about something like: > "A new feature, VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS, has been > added to the vhost-user protocol which, when negotiated, changes the > way QEMU transmit memory regions to backend devices. Instead of

[PATCH v5 2/2] tests/bios-tables-test: add smbios cpu speed test

2020-08-05 Thread Ying Fang
Add smbios type 4 CPU speed check for we added new options to set smbios type 4 "max speed" and "current speed". The default value should be 2000 when no option is specified, just as the old version did. We add the test case to one machine of each architecture, though it doesn't really run on aarc

[PATCH v5 0/2] add new options to set smbios type 4 fields

2020-08-05 Thread Ying Fang
From: fangying Hi, this patchset was previously posted by my teamate Heyi Guo several months ago, however we missed the merge window. It is reposted here to make it an end. Thanks. Patch description: Common VM users sometimes care about CPU speed, so we add two new options to allow VM vendors

[PATCH v5 1/2] hw/smbios: add options for type 4 max-speed and current-speed

2020-08-05 Thread Ying Fang
Common VM users sometimes care about CPU speed, so we add two new options to allow VM vendors to present CPU speed to their users. Normally these information can be fetched from host smbios. Strictly speaking, the "max speed" and "current speed" in type 4 are not really for the max speed and curre

Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline)

2020-08-05 Thread Markus Armbruster
John Snow writes: > On 8/5/20 3:36 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 8/4/20 4:03 AM, Markus Armbruster wrote: The pain of tweaking the parser is likely dwarved several times over by the pain of the flag day. >>> >>> You mention this often; I wonder if I misund

Re: [PATCH for-5.2 3/5] ppc/xive: Introduce dedicated kvm_irqchip_in_kernel() wrappers

2020-08-05 Thread David Gibson
On Wed, Aug 05, 2020 at 07:35:37PM +0200, Greg Kurz wrote: > Calls to the KVM XIVE device are guarded by kvm_irqchip_in_kernel(). This > ensures that QEMU won't try to use the device if KVM is disabled or if > an in-kernel irqchip isn't required. > > When using ic-mode=dual with the pseries machin

Re: [PATCH for-5.2 5/5] spapr: Simplify error handling in spapr_phb_realize()

2020-08-05 Thread David Gibson
On Wed, Aug 05, 2020 at 07:35:51PM +0200, Greg Kurz wrote: > The spapr_phb_realize() function has a local_err variable which > is used to: > > 1) check failures of spapr_irq_findone() and spapr_irq_claim() > > 2) prepend extra information to the error message > > Recent work from Markus Armbrust

Re: [PATCH for-5.2 4/5] spapr/xive: Convert KVM device fd checks to assert()

2020-08-05 Thread David Gibson
On Wed, Aug 05, 2020 at 07:35:44PM +0200, Greg Kurz wrote: > All callers guard these functions with kvmppc_xive_in_kernel() or one > of its variants. Make it clear that these functions are only to be > called when the KVM XIVE device is active. > > Note that the check on xive is dropped in kvmppc_

Re: [PATCH for-5.2 1/5] spapr/xive: Fix xive->fd if kvm_create_device() fails

2020-08-05 Thread David Gibson
On Wed, Aug 05, 2020 at 07:35:22PM +0200, Greg Kurz wrote: > If the creation of the KVM XIVE device fails for some reasons, the > negative errno ends up in xive->fd, but the rest of the code assumes > that xive->fd either contains an open fd, ie. positive value, or -1. > > This doesn't cause any m

Re: [PATCH for-5.2 2/5] spapr/xive: Simplify kvmppc_xive_disconnect()

2020-08-05 Thread David Gibson
On Wed, Aug 05, 2020 at 07:35:29PM +0200, Greg Kurz wrote: > Since this function begins with: > > /* The KVM XIVE device is not in use */ > if (!xive || xive->fd == -1) { > return; > } > > we obviously don't need to check xive->fd again. > > Signed-off-by: Greg Kurz Applied

Re: cleanups with long-term benefits

2020-08-05 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, Aug 05, 2020 at 06:23:23PM +0200, Kevin Wolf wrote: >> We're basically weighing "git blame" against syntax highlighting >> defaults. I don't think the latter has an obviously higher weight. > > I think "syntax highlight defaults" is far from being an accurate > d

Re: Adding VHOST_USER_PROTOCOL_F_CONFIG_MEM_SLOTS to 5.1 release notes

2020-08-05 Thread Michael S. Tsirkin
A bit verbose. I shortened it to A new feature, VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS, has been added to the vhost-user protocol. VMs with vhost-user device backends which support this feature will not be subject to the current max RAM slots limit of 8 and will be able to hot-add memory as man

Re: [PATCH v3 0/8] Generalize start-powered-off property from ARM

2020-08-05 Thread David Gibson
On Wed, Aug 05, 2020 at 08:04:11PM +0100, Peter Maydell wrote: > On Wed, 5 Aug 2020 at 18:01, Thiago Jung Bauermann > wrote: > > Any news on this? Is there something I should be doing? I saw -rc3 today > > but not these patches. > > Sorry, you've missed the bus for 5.1 at this point. I'd assumed

Re: [PATCH] spapr: Clarify error and documentation for broken KVM XICS

2020-08-05 Thread David Gibson
On Wed, Aug 05, 2020 at 05:47:16PM +0200, Greg Kurz wrote: > When starting an L2 KVM guest with `ic-mode=dual,kernel-irqchip=on`, > QEMU fails with: > > KVM is too old to support ic-mode=dual,kernel-irqchip=on > > This error message was introduced to detect older KVM versions that > didn't allow

Re: [PATCH] ide: Get rid of IDEDrive struct

2020-08-05 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, Aug 05, 2020 at 09:41:25PM +0100, Peter Maydell wrote: >> On Wed, 5 Aug 2020 at 20:49, Eduardo Habkost wrote: >> > >> > The struct had a single field (IDEDevice dev), and is only used >> > in the QOM type declarations and property lists. We can simply >> > use

Re: [PATCH v5 0/2] add new options to set smbios type 4 fields

2020-08-05 Thread Michael S. Tsirkin
On Thu, Aug 06, 2020 at 11:56:32AM +0800, Ying Fang wrote: > From: fangying > > Hi, this patchset was previously posted by my teamate Heyi Guo several > months ago, however we missed the merge window. It is reposted here to > make it an end. Thanks. Thanks, I will tag it for after the release.

Re: [PATCH v2 1/7] target/riscv: Generate nanboxed results from fp helpers

2020-08-05 Thread Chih-Min Chao
On Fri, Jul 24, 2020 at 2:06 PM LIU Zhiwei wrote: > > > On 2020/7/24 11:55, Richard Henderson wrote: > > On 7/23/20 7:35 PM, LIU Zhiwei wrote: > >> > >> On 2020/7/24 8:28, Richard Henderson wrote: > >>> Make sure that all results from single-precision scalar helpers > >>> are properly nan-boxed t

Re: [for-5.2 v4 10/10] s390: Recognize host-trust-limitation option

2020-08-05 Thread David Gibson
On Mon, Jul 27, 2020 at 05:50:40PM +0200, Cornelia Huck wrote: > On Fri, 24 Jul 2020 12:57:44 +1000 > David Gibson wrote: > > > At least some s390 cpu models support "Protected Virtualization" (PV), > > a mechanism to protect guests from eavesdropping by a compromised > > hypervisor. > > > > Thi

Re: [PATCH v2 2/7] target/riscv: Generalize gen_nanbox_fpr to gen_nanbox_s

2020-08-05 Thread Chih-Min Chao
On Fri, Jul 24, 2020 at 8:28 AM Richard Henderson < richard.hender...@linaro.org> wrote: > Do not depend on the RVD extension, take input and output via > TCGv_i64 instead of fpu regno. Move the function to translate.c > so that it can be used in multiple trans_*.inc.c files. > > Signed-off-by: R

Re: [PATCH v2 3/7] target/riscv: Generate nanboxed results from trans_rvf.inc.c

2020-08-05 Thread Chih-Min Chao
On Fri, Jul 24, 2020 at 8:28 AM Richard Henderson < richard.hender...@linaro.org> wrote: > Make sure that all results from inline single-precision scalar > operations are properly nan-boxed to 64-bits. > > Signed-off-by: Richard Henderson > --- > target/riscv/insn_trans/trans_rvf.inc.c | 4

Re: [PATCH v2 4/7] target/riscv: Check nanboxed inputs to fp helpers

2020-08-05 Thread Chih-Min Chao
On Fri, Jul 24, 2020 at 8:29 AM Richard Henderson < richard.hender...@linaro.org> wrote: > If a 32-bit input is not properly nanboxed, then the input is > replaced with the default qnan. > > Signed-off-by: Richard Henderson > --- > target/riscv/internals.h | 11 +++ > target/riscv/fpu_helpe

Re: [PATCH v2 5/7] target/riscv: Check nanboxed inputs in trans_rvf.inc.c

2020-08-05 Thread Chih-Min Chao
On Fri, Jul 24, 2020 at 8:28 AM Richard Henderson < richard.hender...@linaro.org> wrote: > If a 32-bit input is not properly nanboxed, then the input is replaced > with the default qnan. The only inline expansion is for the sign-changing > set of instructions: FSGNJ.S, FSGNJX.S, FSGNJN.S. > > Sig

Re: [PATCH v2 6/7] target/riscv: Clean up fmv.w.x

2020-08-05 Thread Chih-Min Chao
On Fri, Jul 24, 2020 at 8:28 AM Richard Henderson < richard.hender...@linaro.org> wrote: > From: LIU Zhiwei > > Use tcg_gen_extu_tl_i64 to avoid the ifdef. > > Signed-off-by: LIU Zhiwei > Message-Id: <20200626205917.4545-7-zhiwei_...@c-sky.com> > Signed-off-by: Richard Henderson > --- > target

Re: [PATCH v2 7/7] target/riscv: check before allocating TCG temps

2020-08-05 Thread Chih-Min Chao
On Fri, Jul 24, 2020 at 8:32 AM Richard Henderson < richard.hender...@linaro.org> wrote: > From: LIU Zhiwei > > Signed-off-by: LIU Zhiwei > Message-Id: <20200626205917.4545-5-zhiwei_...@c-sky.com> > Signed-off-by: Richard Henderson > --- > target/riscv/insn_trans/trans_rvd.inc.c | 8 >

[qemu]: How to use qemu to run 64MB bmc image?

2020-08-05 Thread www
Hi Joel Stanley, Andrew Jeffery, Cédric Le Goater, How to modify it so that QEMU can run 64MB BMC image? In addition, how to learn the source code of QEMU? Are there any guidelines and reference documents? thanks, Byron

<    1   2   3