Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-25 Thread David Hildenbrand
> >> So it's wrapping architecture-specific data in a common >> parameter. Hmm. > > Well, I don't know I'd say "wrapping". You have a common parameter > that points to an object with a well defined interface. The available > implementations of that object will tend to be either zero or one per

Re: [PATCH 30/46] s390x/pci: Fix harmless mistake in zpci's property fid's setter

2020-06-25 Thread Cornelia Huck
On Wed, 24 Jun 2020 18:43:28 +0200 Markus Armbruster wrote: > s390_pci_set_fid() sets zpci->fid_defined to true even when > visit_type_uint32() failed. Reproducer: "-device zpci,fid=junk". > Harmless in practice, because qdev_device_add() then fails, throwing > away @zpci. Fix it anyway. > > C

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-25 Thread David Hildenbrand
>> Still unsure how to bring this new machine property and the cpu feature >> together. Would be great to have the same interface everywhere, but >> having two distinct command line objects depend on each other sucks. > > Kinda, but the reality is that hardware - virtual and otherwise - > frequent

Re: [PATCH v5 2/5] virtio-iommu: Implement RESV_MEM probe request

2020-06-25 Thread Markus Armbruster
Eric Auger writes: > This patch implements the PROBE request. At the moment, > only THE RESV_MEM property is handled. The first goal is > to report iommu wide reserved regions such as the MSI regions > set by the machine code. On x86 this will be the IOAPIC MSI > region, [0xFEE0 - 0xFEEF]

Re: [PATCH 4/8] i386: hvf: Implement CPU kick

2020-06-25 Thread Claudio Fontana
Hi Roman, On 6/25/20 12:58 AM, Roman Bolshakov wrote: > HVF doesn't have a CPU kick and without it it's not possible to perform > an action on CPU thread until a VMEXIT happens. The kick is also needed > for timely interrupt delivery. > > Existing implementation of CPU kick sends SIG_IPI (aka SIG

Re: [PATCH 2/8] i386: hvf: Move synchronize functions to sysemu

2020-06-25 Thread Claudio Fontana
Reviewed-by: Claudio Fontana On 6/25/20 12:58 AM, Roman Bolshakov wrote: > Cc: Cameron Esfahani > Signed-off-by: Roman Bolshakov > --- > cpus.c| 12 > include/sysemu/hw_accel.h | 10 ++ > 2 files changed, 10 insertions(+), 12 deletions(-) > > diff --gi

Re: [PATCH 02/46] error: Document Error API usage rules

2020-06-25 Thread Vladimir Sementsov-Ogievskiy
24.06.2020 19:43, Markus Armbruster wrote: This merely codifies existing practice, with one exception: the rule advising against returning void, where existing practice is mixed. When the Error API was created, we adopted the (unwritten) rule to return void when the function returns no useful va

Re: [PATCH] net: tap: check if the file descriptor is valid before using it

2020-06-25 Thread Laurent Vivier
On 25/06/2020 08:19, Philippe Mathieu-Daudé wrote: > On 6/24/20 9:00 PM, Laurent Vivier wrote: >> qemu_set_nonblock() checks that the file descriptor can be used and, if >> not, crashes QEMU. An assert() is used for that. The use of assert() is >> used to detect programming error and the coredump w

Re: [PATCH] net: tap: check if the file descriptor is valid before using it

2020-06-25 Thread Philippe Mathieu-Daudé
On 6/25/20 9:38 AM, Laurent Vivier wrote: > On 25/06/2020 08:19, Philippe Mathieu-Daudé wrote: >> On 6/24/20 9:00 PM, Laurent Vivier wrote: >>> qemu_set_nonblock() checks that the file descriptor can be used and, if >>> not, crashes QEMU. An assert() is used for that. The use of assert() is >>> use

Re: [PATCH v9 00/10] accel: Allow targets to use Kconfig

2020-06-25 Thread Philippe Mathieu-Daudé
Hi Paolo, Claudio raised an issue with patch #4, so at this point I have to admit again having the KVM-only build merged for the next release won't be possible :( Only patch #9 depends on patch #4. Are you OK to take the rest of the series, patches 1-3, 5-8, 10 (all but 4 and 9). Patches are full

Re: [PATCH v2 2/3] usb/hcd-xhci: Move qemu-xhci device to hcd-xhci-pci.c

2020-06-25 Thread Markus Armbruster
Sai Pavan Boddu writes: > Move pci specific devices to new file. This set the environment to move all > pci specific hooks in hcd-xhci.c to hcd-xhci-pci.c. > > Signed-off-by: Sai Pavan Boddu > --- > hw/usb/hcd-xhci-pci.c | 64 > +++ > hw/usb/hcd-

Re: [PATCH v2 3/3] usb/hcd-xhci: Split pci wrapper for xhci base model

2020-06-25 Thread Markus Armbruster
Sai Pavan Boddu writes: > This patch sets the base to use xhci as sysbus model, for which pci > specific hooks are moved to hcd-xhci-pci.c. As a part of this requirment > msi/msix interrupts handling is moved under XHCIPCIState, and XHCIState > is non qom object, make use of 'container_of' calls

[PULL 0/4] target/xtensa fixes

2020-06-25 Thread Max Filippov
in the Git repository at: git://github.com/OSLL/qemu-xtensa.git tags/20200625-xtensa for you to fetch changes up to 8a3a81478dcc592518069125a6ad271fe5511b95: target/xtensa: drop gen_io_end call (2020-06-22 03:38:30 -0700) tar

Re: [PATCH v4 4/8] hw/misc/pca9552: Add a 'description' property for debugging purpose

2020-06-25 Thread Philippe Mathieu-Daudé
On 6/25/20 8:37 AM, Markus Armbruster wrote: > Cédric Le Goater writes: > >> On 6/22/20 10:31 AM, Philippe Mathieu-Daudé wrote: >>> On 6/22/20 8:27 AM, Cédric Le Goater wrote: On 6/21/20 12:58 AM, Philippe Mathieu-Daudé wrote: > Add a description field to distinguish between multiple dev

Re: [PATCH v2 2/3] usb/hcd-xhci: Move qemu-xhci device to hcd-xhci-pci.c

2020-06-25 Thread Philippe Mathieu-Daudé
On 6/25/20 10:06 AM, Markus Armbruster wrote: > Sai Pavan Boddu writes: > >> Move pci specific devices to new file. This set the environment to move all >> pci specific hooks in hcd-xhci.c to hcd-xhci-pci.c. >> >> Signed-off-by: Sai Pavan Boddu >> --- >> hw/usb/hcd-xhci-pci.c | 64 >> +

Re: [PULL v1 00/12] Merge tpm 2020/06/23 v1

2020-06-25 Thread Peter Maydell
On Tue, 23 Jun 2020 at 12:41, Stefan Berger wrote: > > This PR cleans up header includes in TPM code and moves some backend > components > into backends/tpm. > > The following changes since commit 292ef18a38270e1cb8e9a3dc06bca589068f293d: > > Merge remote-tracking branch 'remotes/jasowang/tags/

Re: [PULL 00/43] Block layer patches

2020-06-25 Thread Klaus Jensen
On Jun 18 15:30, Peter Maydell wrote: > On Wed, 17 Jun 2020 at 15:49, Kevin Wolf wrote: > > > > The following changes since commit 5c24bce3056ff209a1ecc50ff4b7e65b85ad8e74: > > > > Merge remote-tracking branch > > 'remotes/stsquad/tags/pull-testing-and-plugin-160620-2' into staging > > (2020-0

Re: [PATCH v9 04/10] configure: Generate rule to calculate the base architecture of a target

2020-06-25 Thread Claudio Fontana
On 6/23/20 3:17 PM, Philippe Mathieu-Daudé wrote: > On 6/23/20 10:45 AM, Philippe Mathieu-Daudé wrote: >> On 6/23/20 10:01 AM, Claudio Fontana wrote: >>> Hi Philippe, Alex, >>> >>> On 6/18/20 2:33 PM, Philippe Mathieu-Daudé wrote: From: Alex Bennée As we encode the base architecture

Re: [PATCH] net: tap: check if the file descriptor is valid before using it

2020-06-25 Thread Daniel P . Berrangé
On Wed, Jun 24, 2020 at 09:00:09PM +0200, Laurent Vivier wrote: > qemu_set_nonblock() checks that the file descriptor can be used and, if > not, crashes QEMU. An assert() is used for that. The use of assert() is > used to detect programming error and the coredump will allow to debug > the problem.

Re: [PATCH RFC 1/3] gitlab: introduce explicit "container" and "build" stages

2020-06-25 Thread Thomas Huth
On 22/06/2020 17.33, Daniel P. Berrangé wrote: If no stage is listed, jobs get put in an implicit "test" stage. Some jobs which create container images to be used by later stages are currently listed as in a "build" stages. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/edk2.yml| 3 +

Re: [PATCH RFC 1/3] gitlab: introduce explicit "container" and "build" stages

2020-06-25 Thread Philippe Mathieu-Daudé
On 6/25/20 10:54 AM, Thomas Huth wrote: > On 22/06/2020 17.33, Daniel P. Berrangé wrote: >> If no stage is listed, jobs get put in an implicit "test" stage. >> Some jobs which create container images to be used by later stages >> are currently listed as in a "build" stages. >> >> Signed-off-by: Dan

[PATCH v2 0/2] linux-user/sparc64: Translate flushw opcode

2020-06-25 Thread Laurent Vivier
I send a modified version according to Richard's comments of the original series sent by Giuseppe Musacchio (aka LemonBoy). v2: split patch in two patches update comment style I didn't really test the new patches (except a build and "make check"). But there is no code modification so I don't

[PATCH v2 2/2] linux-user/sparc64: Fix the handling of window spill trap

2020-06-25 Thread Laurent Vivier
From: LemonBoy Fix the handling of window spill traps by keeping cansave into account when calculating the new CWP. Signed-off-by: Giuseppe Musacchio Signed-off-by: Laurent Vivier --- bsd-user/main.c | 6 +- linux-user/sparc/cpu_loop.c | 6 +- 2 files changed, 10 insertion

[PATCH v2 1/2] target/sparc: Translate flushw opcode

2020-06-25 Thread Laurent Vivier
From: LemonBoy The ifdef logic should unconditionally compile in the `xop == 0x2b` case when targeting sparc64. Signed-off-by: Giuseppe Musacchio Signed-off-by: Laurent Vivier --- target/sparc/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/sparc/translate.c b/target/

Re: [PATCH v2 7/9] tz-ppc: add dummy read/write methods

2020-06-25 Thread P J P
+-- On Thu, 25 Jun 2020, Philippe Mathieu-Daudé wrote --+ | > @@ -196,7 +196,22 @@ static bool tz_ppc_dummy_accepts(void *opaque, hwaddr addr, | > g_assert_not_reached(); | | This is a shame we now have to fill the read/write handlers for | unreachable code :( | | > +static uint64_t tz_ppc_

Re: [PATCH v3 0/3] Add Scripts for Finding Top 25 Executed Functions

2020-06-25 Thread Aleksandar Markovic
сре, 24. јун 2020. у 17:31 Ahmed Karaman је написао/ла: > > Greetings, > > As a part of the TCG Continous Benchmarking project for GSoC this > year, detailed reports discussing different performance measurement > methodologies and analysis results will be sent here on the mailing > list. > > The p

Re: [PATCH v3 1/2] qom: Introduce object_property_try_add_child()

2020-06-25 Thread Markus Armbruster
Eric Auger writes: > object_property_add() does not allow object_property_try_add() > to gracefully fail as &error_abort is passed as an error handle. > > However such failure can easily be triggered from the QMP shell when, > for instance, one attempts to create an object with an id that already

Re: [PATCH v2] chardev/tcp: fix error message double free error

2020-06-25 Thread Marc-André Lureau
Hi On Thu, Jun 25, 2020 at 10:47 AM Markus Armbruster wrote: > > lichun writes: > > > Signed-off-by: lichun > > --- > > chardev/char-socket.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/chardev/char-socket.c b/chardev/char-socket.c > > index afebeec5c3..569

Re: [PULL 07/15] hw/timer: RX62N 8-Bit timer (TMR)

2020-06-25 Thread Peter Maydell
On Sun, 21 Jun 2020 at 13:54, Philippe Mathieu-Daudé wrote: > > From: Yoshinori Sato > > renesas_tmr: 8bit timer modules. Hi; the recent Coverity run reports a potential bug in this code: (CID 1429976) > +static uint16_t read_tcnt(RTMRState *tmr, unsigned size, int ch) > +{ > +int64_t delt

Re: [PULL V2 29/33] net/colo-compare.c: Correct ordering in complete and finalize

2020-06-25 Thread Peter Maydell
On Thu, 18 Jun 2020 at 14:23, Jason Wang wrote: > > From: Lukas Straub > > In colo_compare_complete, insert CompareState into net_compares > only after everything has been initialized. > In colo_compare_finalize, remove CompareState from net_compares > before anything is deinitialized. Hi; this

Re: [PATCH RFC 2/3] gitlab: build all container images during CI

2020-06-25 Thread Thomas Huth
On 22/06/2020 17.33, Daniel P. Berrangé wrote: We have a number of container images in tests/docker/dockerfiles that are intended to provide well defined environments for doing test builds. We want our CI system to use these containers too. This introduces builds of all of them as the first stag

Re: [PATCH 1/5] target/i386: implement special cases for fxtract

2020-06-25 Thread Peter Maydell
On Tue, 23 Jun 2020 at 23:01, Joseph Myers wrote: > > On Tue, 23 Jun 2020, Eduardo Habkost wrote: > > > > +if (EXPD(temp) == 0) { > > > +int shift = clz64(temp.l.lower); > > > +temp.l.lower <<= shift; > > > > Coverity reports the following. It looks like a false po

Re: [PATCH v3 1/3] scripts/performance: Add topN_perf.py script

2020-06-25 Thread Aleksandar Markovic
сре, 24. јун 2020. у 17:32 Ahmed Karaman је написао/ла: > > Syntax: > topN_perf.py [-h] [-n] -- \ > [] \ > [] > > [-h] - Print the script arguments help message. > [-n] - Specify the number of top functions to print. > - If this flag is not specified, the

Re: [PATCH v3 2/2] tests/qmp-cmd-test: Add qmp/object-add-duplicate-id

2020-06-25 Thread Paolo Bonzini
On 24/06/20 21:48, Eric Auger wrote: > This new test checks that attempting to create an object > with an existing ID gracefully fails. > > Signed-off-by: Eric Auger > Acked-by: Thomas Huth > --- > tests/qtest/qmp-cmd-test.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-25 Thread Cornelia Huck
On Thu, 25 Jun 2020 08:59:00 +0200 David Hildenbrand wrote: > How do upper layers actually figure out if memory encryption etc is > available? on s390x, it's simply via the expanded host CPU model. > >>> > >>> Haven't really tackled that yet. But one way that works for multiple > >>>

Re: [PATCH RFC 2/3] gitlab: build all container images during CI

2020-06-25 Thread Daniel P . Berrangé
On Thu, Jun 25, 2020 at 11:35:54AM +0200, Thomas Huth wrote: > On 22/06/2020 17.33, Daniel P. Berrangé wrote: > > We have a number of container images in tests/docker/dockerfiles > > that are intended to provide well defined environments for doing > > test builds. We want our CI system to use these

Re: [PATCH v2 0/6] virtio-console: notify about the terminal size

2020-06-25 Thread Szymon Lukasz
On Wed, Jun 24, 2020 at 12:49:15PM +0100, Daniel P. Berrangé wrote: > On Wed, Jun 24, 2020 at 01:26:34PM +0200, Szymon Lukasz wrote: > > Also there is a problem with the virtio spec and Linux Kernel > > implementation, the order of fields in virtio_console_resize struct > > differs between the kern

Re: [PATCH v3 2/3] scripts/performance: Add topN_callgrind.py script

2020-06-25 Thread Aleksandar Markovic
сре, 24. јун 2020. у 17:32 Ahmed Karaman је написао/ла: > > Python script that prints the top N most executed functions in QEMU > using callgrind. > > Syntax: > topN_callgrind.py [-h] [-n] -- \ >[] \ >[] > > [-h] - Print the script arguments help m

Re: [PATCH v2 0/6] virtio-console: notify about the terminal size

2020-06-25 Thread Szymon Lukasz
On Wed, Jun 24, 2020 at 12:56:15PM +0100, Daniel P. Berrangé wrote: > On Wed, Jun 24, 2020 at 01:26:34PM +0200, Szymon Lukasz wrote: > > In this series resize notifications are only supported for the stdio > > backend but I think it should be easy to add support for the vc backend. > > Support for

QEMU | Pipeline #159947573 has failed for master | 27c77b1f

2020-06-25 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 27c77b1f ( https://gitlab.com/qemu-project/qemu/-/commit/27c77b1f55323fae772699e05cd5107aa32f9e9a ) Commit Message: Merge remote-tr

Re: [PATCH RFC 3/3] gitlab: convert jobs to use custom built containers

2020-06-25 Thread Thomas Huth
On 22/06/2020 17.33, Daniel P. Berrangé wrote: Now that we're building standard container images from dockerfiles in tests/docker/dockerfiles, we can convert the build jobs to use them. The key benefit of this is that a contributor can now more easily replicate the CI environment on their local m

Re: [PATCH v3 3/3] MAINTAINERS: Add 'Performance Tools and Tests' subsection

2020-06-25 Thread Aleksandar Markovic
сре, 24. јун 2020. у 17:32 Ahmed Karaman је написао/ла: > > This commit creates a new 'Miscellaneous' section which hosts a new > 'Performance Tools and Tests' subsection. > The subsection will contain the the performance scripts and benchmarks Remove 'the the'. > written as a part of the 'TCG C

Re: [PATCH v5 5/5] hw/arm/virt: Let the virtio-iommu bypass MSIs

2020-06-25 Thread Peter Maydell
On Wed, 24 Jun 2020 at 14:27, Eric Auger wrote: > > At the moment the virtio-iommu translates MSI transactions. > This behavior is inherited from ARM SMMU. The virt machine > code knows where the guest MSI doorbells are so we can easily > declare those regions as VIRTIO_IOMMU_RESV_MEM_T_MSI. With

Re: [PATCH v5 0/5] VIRTIO-IOMMU probe request support and MSI bypass on ARM

2020-06-25 Thread Peter Maydell
On Wed, 24 Jun 2020 at 16:16, Michael S. Tsirkin wrote: > Virtio bits look OK: > > Reviewed-by: Michael S. Tsirkin I can take it via the arm tree once it's ready. I had a comment on patch 5 and it looks like Markus had a question about patch 2, though. thanks -- PMM

[RFC 0/4] Enable virtio-fs on s390x

2020-06-25 Thread Marc Hartmayer
This RFC is about enabling virtio-fs on s390x. For that we need + some shim code (first patch), and we need + libvhost-user to deal with virtio endiannes as mandated by the spec. The second part is trickier, because unlike QEMU we are not certain about the guest's native endianness, which is ne

[RFC 4/4] HACK: Hard-code the libvhost-user.o-cflags for s390x

2020-06-25 Thread Marc Hartmayer
This patch exists only to show the actual problem that libvhost-user and it's users are architecture dependent as soon as we're trying to support legacy virtio. Signed-off-by: Marc Hartmayer --- Makefile.objs | 1 + contrib/libvhost-user/libvhost-access.h | 7 +++ 2

[RFC 1/4] virtio: add vhost-user-fs-ccw device

2020-06-25 Thread Marc Hartmayer
From: Halil Pasic Wire up the CCW device for vhost-user-fs. Signed-off-by: Halil Pasic --- hw/s390x/Makefile.objs | 1 + hw/s390x/vhost-user-fs-ccw.c | 74 2 files changed, 75 insertions(+) create mode 100644 hw/s390x/vhost-user-fs-ccw.c diff --git

[RFC 3/4] libvhost-user: handle endianness as mandated by the spec

2020-06-25 Thread Marc Hartmayer
Since virtio existed even before it got standardized, the virtio standard defines the following types of virtio devices: + legacy device (pre-virtio 1.0) + non-legacy or VIRTIO 1.0 device + transitional device (which can act both as legacy and non-legacy) Virtio 1.0 defines the fields of the v

Re: [PULL 07/15] hw/timer: RX62N 8-Bit timer (TMR)

2020-06-25 Thread Thomas Huth
On 25/06/2020 11.25, Peter Maydell wrote: [...] +static uint64_t tmr_read(void *opaque, hwaddr addr, unsigned size) +{ In this function Coverity reports a missing "break" (CID 1429977): +case A_TCORA: +if (size == 1) { +return tmr->tcora[ch]; +} else if (ch ==

Re: [PATCH RFC 2/3] gitlab: build all container images during CI

2020-06-25 Thread Daniel P . Berrangé
On Mon, Jun 22, 2020 at 04:33:17PM +0100, Daniel P. Berrangé wrote: > We have a number of container images in tests/docker/dockerfiles > that are intended to provide well defined environments for doing > test builds. We want our CI system to use these containers too. > > This introduces builds of

[RFC 2/4] libvhost-user: print invalid address on vu_panic

2020-06-25 Thread Marc Hartmayer
This can be helpful for debugging. Signed-off-by: Marc Hartmayer --- contrib/libvhost-user/libvhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/libvhost-user.c index d315db139606..9e8750a9dabc 100644 --

[PATCH] hw/virtio/virtio-iommu-pci.c: Fix typo in error message

2020-06-25 Thread Peter Maydell
Fix a typo in an error message in virtio_iommu_pci_realize(): "Check you machine" should be "Check your machine". Reported-by: Markus Armbruster Signed-off-by: Peter Maydell --- hw/virtio/virtio-iommu-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/virtio-iom

Re: [PATCH v4] sm501: Fix and optimize overlap check

2020-06-25 Thread Peter Maydell
On Wed, 24 Jun 2020 at 17:47, BALATON Zoltan wrote: > > When doing reverse blit we need to check if source and dest overlap > but it is not trivial due to possible different base and pitch of > source and dest. Do rectangle overlap if base and pitch match, > otherwise just check if memory area con

Re: [PATCH v5 2/5] virtio-iommu: Implement RESV_MEM probe request

2020-06-25 Thread Peter Maydell
On Thu, 25 Jun 2020 at 08:06, Markus Armbruster wrote: > $ qemu-system-x86_64 -nodefaults -S -display none -device > virtio-iommu-pci,len-reserved-regions=1,reserved-regions[0]=0xfee0:0xfeef:99 > qemu-system-x86_64: -device > virtio-iommu-pci,len-reserved-regions=1,reserved-regio

Re: [RFC 0/4] Enable virtio-fs on s390x

2020-06-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200625100430.22407-1-mhart...@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [RFC 0/4] Enable virtio-fs on s390x Type: series Message-id: 20200625100430.22407-1-mhart...@linux.ibm

Re: [PATCH RFC 2/3] gitlab: build all container images during CI

2020-06-25 Thread Thomas Huth
On 22/06/2020 17.33, Daniel P. Berrangé wrote: We have a number of container images in tests/docker/dockerfiles that are intended to provide well defined environments for doing test builds. We want our CI system to use these containers too. This introduces builds of all of them as the first stag

Re: [RFC 0/4] Enable virtio-fs on s390x

2020-06-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200625100430.22407-1-mhart...@linux.ibm.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [RFC 0/4] Enable virtio-fs on s390x

2020-06-25 Thread Cornelia Huck
On Thu, 25 Jun 2020 12:04:26 +0200 Marc Hartmayer wrote: > This RFC is about enabling virtio-fs on s390x. For that we need > + some shim code (first patch), and we need > + libvhost-user to deal with virtio endiannes as mandated by the spec. > > The second part is trickier, because unlike QEM

Re: [PATCH v8 10/45] target/arm: Revise decoding for disas_add_sub_imm

2020-06-25 Thread Peter Maydell
On Tue, 23 Jun 2020 at 20:37, Richard Henderson wrote: > > The current Arm ARM has adjusted the official decode of > "Add/subtract (immediate)" so that the shift field is only bit 22, > and bit 23 is part of the op1 field of the parent category > "Data processing - immediate". > > Suggested-by: Pe

Re: [RFC 0/4] Enable virtio-fs on s390x

2020-06-25 Thread Daniel P . Berrangé
On Thu, Jun 25, 2020 at 12:04:26PM +0200, Marc Hartmayer wrote: > This RFC is about enabling virtio-fs on s390x. For that we need > + some shim code (first patch), and we need > + libvhost-user to deal with virtio endiannes as mandated by the spec. > > The second part is trickier, because unlik

Re: [PATCH] hw/virtio/virtio-iommu-pci.c: Fix typo in error message

2020-06-25 Thread Philippe Mathieu-Daudé
On 6/25/20 12:08 PM, Peter Maydell wrote: > Fix a typo in an error message in virtio_iommu_pci_realize(): > "Check you machine" should be "Check your machine". > > Reported-by: Markus Armbruster > Signed-off-by: Peter Maydell > --- > hw/virtio/virtio-iommu-pci.c | 2 +- > 1 file changed, 1 inse

Re: [PATCH v9 00/10] accel: Allow targets to use Kconfig

2020-06-25 Thread Paolo Bonzini
On 25/06/20 09:49, Philippe Mathieu-Daudé wrote: > Hi Paolo, > > Claudio raised an issue with patch #4, so at this point > I have to admit again having the KVM-only build merged > for the next release won't be possible :( > > Only patch #9 depends on patch #4. Are you OK to take > the rest of the

Re: [PATCH v2 7/9] tz-ppc: add dummy read/write methods

2020-06-25 Thread Philippe Mathieu-Daudé
On 6/25/20 11:18 AM, P J P wrote: > +-- On Thu, 25 Jun 2020, Philippe Mathieu-Daudé wrote --+ > | > @@ -196,7 +196,22 @@ static bool tz_ppc_dummy_accepts(void *opaque, > hwaddr addr, > | > g_assert_not_reached(); > | > | This is a shame we now have to fill the read/write handlers for > | unr

Re: [PATCH v9 00/10] accel: Allow targets to use Kconfig

2020-06-25 Thread Philippe Mathieu-Daudé
On 6/25/20 12:20 PM, Paolo Bonzini wrote: > On 25/06/20 09:49, Philippe Mathieu-Daudé wrote: >> Hi Paolo, >> >> Claudio raised an issue with patch #4, so at this point >> I have to admit again having the KVM-only build merged >> for the next release won't be possible :( >> >> Only patch #9 depends

Re: [PATCH RFC 2/3] gitlab: build all container images during CI

2020-06-25 Thread Daniel P . Berrangé
On Thu, Jun 25, 2020 at 12:14:33PM +0200, Thomas Huth wrote: > On 22/06/2020 17.33, Daniel P. Berrangé wrote: > > We have a number of container images in tests/docker/dockerfiles > > that are intended to provide well defined environments for doing > > test builds. We want our CI system to use these

Re: [PATCH v5 04/12] pc-bios: s390x: Get rid of magic offsets into the lowcore

2020-06-25 Thread Thomas Huth
On 24/06/2020 09.52, Janosch Frank wrote: If we have a lowcore struct that has members for offsets that we want to touch, why not use it? Signed-off-by: Janosch Frank Reviewed-by: David Hildenbrand --- pc-bios/s390-ccw/cio.h | 17 +++-- pc-bios/s390-ccw/main.c | 8 +++- 2

Re: [PATCH 4/8] i386: hvf: Implement CPU kick

2020-06-25 Thread Paolo Bonzini
On 25/06/20 00:58, Roman Bolshakov wrote: > HVF doesn't have a CPU kick and without it it's not possible to perform > an action on CPU thread until a VMEXIT happens. The kick is also needed > for timely interrupt delivery. > > Existing implementation of CPU kick sends SIG_IPI (aka SIGUSR1) to vCPU

Re: [RFC 0/4] Enable virtio-fs on s390x

2020-06-25 Thread Cornelia Huck
On Thu, 25 Jun 2020 11:19:35 +0100 Daniel P. Berrangé wrote: > On Thu, Jun 25, 2020 at 12:04:26PM +0200, Marc Hartmayer wrote: > > This RFC is about enabling virtio-fs on s390x. For that we need > > + some shim code (first patch), and we need > > + libvhost-user to deal with virtio endiannes as

Re: [PATCH RFC 0/3] gitlab: build containers to use in build jobs

2020-06-25 Thread Alex Bennée
Daniel P. Berrangé writes: > The current gitlab CI jobs are quite inefficient because they > use the generic distro images and then apt-get/dnf install > extra packages every time. I should say I've queued this into testing/next and tweaked it slightly. -- Alex Bennée

Re: [PATCH 6/8] i386: hvf: Drop hvf_reset_vcpu()

2020-06-25 Thread Paolo Bonzini
On 25/06/20 00:58, Roman Bolshakov wrote: > +uint64_t pdpte[4] = {0, 0, 0, 0}; > +int i; > + > +/* Reset IA-32e mode guest (LMA) */ > +wvmcs(cpu->hvf_fd, VMCS_ENTRY_CTLS, 0); > + Where is the place (if any...) that calls macvm_set_cr0 and macvm_set_cr4 from cpu_synchronize_*? If y

Re: [PATCH V6 2/4] hw/intc: Add Loongson liointc support

2020-06-25 Thread Aleksandar Markovic
сре, 24. јун 2020. у 12:44 Huacai Chen је написао/ла: > > Loongson-3 has an integrated liointc (Local I/O interrupt controller). > It is similar to goldfish interrupt controller, but more powerful (e.g., > it can route external interrupt to multi-cores). > > Documents about Loongson-3's liointc: >

Re: [PULL 00/43] Block layer patches

2020-06-25 Thread Kevin Wolf
Am 25.06.2020 um 10:39 hat Klaus Jensen geschrieben: > On Jun 18 15:30, Peter Maydell wrote: > > On Wed, 17 Jun 2020 at 15:49, Kevin Wolf wrote: > > > > > > The following changes since commit > > > 5c24bce3056ff209a1ecc50ff4b7e65b85ad8e74: > > > > > > Merge remote-tracking branch > > > 'remote

Re: [RFC 0/4] Enable virtio-fs on s390x

2020-06-25 Thread Daniel P . Berrangé
On Thu, Jun 25, 2020 at 12:31:36PM +0200, Cornelia Huck wrote: > On Thu, 25 Jun 2020 11:19:35 +0100 > Daniel P. Berrangé wrote: > > > On Thu, Jun 25, 2020 at 12:04:26PM +0200, Marc Hartmayer wrote: > > > This RFC is about enabling virtio-fs on s390x. For that we need > > > + some shim code (firs

Re: [PATCH v8 11/45] target/arm: Implement the ADDG, SUBG instructions

2020-06-25 Thread Peter Maydell
On Tue, 23 Jun 2020 at 20:37, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > +/* > + * Add/subtract (immediate, with tags) > + * > + * 31 30 29 28 23 22 21 16 14 10 9 5 4 0 > + * +--+--+--+-+--+-+--+---+-+-+ > + * |sf|op| S| 1

Re: [PATCH V6 4/4] MAINTAINERS: Add Loongson-3 maintainer and reviewer

2020-06-25 Thread Aleksandar Markovic
сре, 24. јун 2020. у 12:45 Huacai Chen је написао/ла: > > Add myself as a maintainer of Loongson-3 virtual platform, and also add > Jiaxun Yang as a reviewer. > > Signed-off-by: Huacai Chen > Co-developed-by: Jiaxun Yang > --- I am inclined to select LIOINTC patch for the next MIPS queue, even

Re: [PATCH v8 14/45] target/arm: Define arm_cpu_do_unaligned_access for user-only

2020-06-25 Thread Peter Maydell
On Tue, 23 Jun 2020 at 20:37, Richard Henderson wrote: > > Use the same code as system mode, so that we generate the same > exception + syndrome for the unaligned access. > > For the moment, if MTE is enabled so that this path is reachable, > this would generate a SIGSEGV in the user-only cpu_loop

Re: [RFC 0/4] Enable virtio-fs on s390x

2020-06-25 Thread Cornelia Huck
On Thu, 25 Jun 2020 11:39:24 +0100 Daniel P. Berrangé wrote: > On Thu, Jun 25, 2020 at 12:31:36PM +0200, Cornelia Huck wrote: > > On Thu, 25 Jun 2020 11:19:35 +0100 > > Daniel P. Berrangé wrote: > > > > > On Thu, Jun 25, 2020 at 12:04:26PM +0200, Marc Hartmayer wrote: > > > > This RFC is ab

Re: [PATCH v8 15/45] target/arm: Implement LDG, STG, ST2G instructions

2020-06-25 Thread Peter Maydell
On Tue, 23 Jun 2020 at 20:37, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v2: Split out allocation_tag_mem. Handle atomicity of stores. > v3: Add X[t] input to these insns; require pre-cleaned addresses. > v5: Fix !32-byte aligned operation of st2g. > v6: Fix op2 extrac

Re: [RFC 1/4] virtio: add vhost-user-fs-ccw device

2020-06-25 Thread Cornelia Huck
On Thu, 25 Jun 2020 12:04:27 +0200 Marc Hartmayer wrote: > From: Halil Pasic > > Wire up the CCW device for vhost-user-fs. > > Signed-off-by: Halil Pasic > --- > hw/s390x/Makefile.objs | 1 + > hw/s390x/vhost-user-fs-ccw.c | 74 > 2 files changed,

Re: [PATCH 4/8] i386: hvf: Implement CPU kick

2020-06-25 Thread Roman Bolshakov
On Thu, Jun 25, 2020 at 09:07:04AM +0200, Claudio Fontana wrote: > Hi Roman, > > On 6/25/20 12:58 AM, Roman Bolshakov wrote: > > HVF doesn't have a CPU kick and without it it's not possible to perform > > an action on CPU thread until a VMEXIT happens. The kick is also needed > > for timely interr

Re: [PATCH v8 25/45] target/arm: Implement helper_mte_check1

2020-06-25 Thread Peter Maydell
On Tue, 23 Jun 2020 at 20:37, Richard Henderson wrote: > > Fill out the stub that was added earlier. > > Signed-off-by: Richard Henderson > --- > v8: Remove ra argument to mte_probe1 (pmm). > --- > target/arm/internals.h | 48 +++ > target/arm/mte_helper.c | 132 +++

Re: [PATCH v5 05/12] pc-bios: s390x: Remove unneeded dasd-ipl.c reset psw mask changes

2020-06-25 Thread Thomas Huth
On 24/06/2020 09.52, Janosch Frank wrote: jump_to_low_kernel() and the functions that it calls will already or 64 bit addressing into the reset psw mask when executing jump_to_IPL_2() after the diag308 subcode 1. Hmm, the jump_to_IPL_code() also sets the 64-bit addressing bits ... but jump_to_

Re: [PATCH v3 2/2] tests/qmp-cmd-test: Add qmp/object-add-duplicate-id

2020-06-25 Thread Markus Armbruster
Eric Auger writes: > This new test checks that attempting to create an object > with an existing ID gracefully fails. > > Signed-off-by: Eric Auger > Acked-by: Thomas Huth > --- > tests/qtest/qmp-cmd-test.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/tests/qte

Re: [PATCH v5 06/12] pc-bios: s390x: Rename PSW_MASK_ZMODE to PSW_MASK_64

2020-06-25 Thread Thomas Huth
On 24/06/2020 09.52, Janosch Frank wrote: This constant enables 64 bit addressing, not the ESAME architecture, so it shouldn't be named ZMODE. Signed-off-by: Janosch Frank --- pc-bios/s390-ccw/s390-arch.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pc-bios/s390-ccw/s3

Re: [PATCH v8 28/45] target/arm: Use mte_checkN for sve unpredicated loads

2020-06-25 Thread Peter Maydell
On Tue, 23 Jun 2020 at 20:37, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v8: Drop the out-of-line helper (pmm). > --- > target/arm/translate-sve.c | 61 +- > 1 file changed, 33 insertions(+), 28 deletions(-) > Reviewed-by: Peter May

Re: [PATCH v8 29/45] target/arm: Use mte_checkN for sve unpredicated stores

2020-06-25 Thread Peter Maydell
On Tue, 23 Jun 2020 at 20:37, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v8: Drop the out-of-line helper (pmm). > --- > target/arm/translate-sve.c | 61 +- > 1 file changed, 33 insertions(+), 28 deletions(-) Reviewed-by: Peter Mayde

Re: [PATCH 0/8] Improve synchronization between QEMU and HVF

2020-06-25 Thread Paolo Bonzini
On 25/06/20 00:58, Roman Bolshakov wrote: > The series is a prerequisite to implement gdbstub support for HVF and mostly > concerns improvements of cpu_synchronize_* functions wrt to HVF and addresses > old TODO's in the related code. > > Unfortunately live snapshots don't seem to work yet but the

Re: [RFC 0/4] Enable virtio-fs on s390x

2020-06-25 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Jun 25, 2020 at 12:04:26PM +0200, Marc Hartmayer wrote: > > This RFC is about enabling virtio-fs on s390x. For that we need > > + some shim code (first patch), and we need > > + libvhost-user to deal with virtio endiannes as mandated by

Re: [PATCH v5 05/12] pc-bios: s390x: Remove unneeded dasd-ipl.c reset psw mask changes

2020-06-25 Thread Thomas Huth
On 25/06/2020 12.57, Thomas Huth wrote: On 24/06/2020 09.52, Janosch Frank wrote: jump_to_low_kernel() and the functions that it calls will already or 64 bit addressing into the reset psw mask when executing jump_to_IPL_2() after the diag308 subcode 1. Hmm, the jump_to_IPL_code() also sets the

Re: [PATCH v8 30/45] target/arm: Use mte_check1 for sve LD1R

2020-06-25 Thread Peter Maydell
On Tue, 23 Jun 2020 at 20:37, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate-sve.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH RESEND v2 2/2] nvme: allow cmb and pmr to be enabled on same device

2020-06-25 Thread Klaus Jensen
On Jun 19 10:30, Andrzej Jakowski wrote: > On 6/18/20 2:25 AM, Klaus Jensen wrote: > > On Jun 16 22:18, Andrzej Jakowski wrote: > >> So far it was not possible to have CMB and PMR emulated on the same > >> device, because BAR2 was used exclusively either of PMR or CMB. This > >> patch places CMB at

Re: [PATCH v10 2/5] hw/nvram/fw_cfg: Add the FW_CFG_DATA_GENERATOR interface

2020-06-25 Thread Daniel P . Berrangé
On Tue, Jun 23, 2020 at 07:27:23PM +0200, Philippe Mathieu-Daudé wrote: > The FW_CFG_DATA_GENERATOR allows any object to produce > blob of data consumable by the fw_cfg device. > > Reviewed-by: Laszlo Ersek > Signed-off-by: Philippe Mathieu-Daudé > --- > docs/specs/fw_cfg.txt | 9 +++-

Re: [PATCH v10 3/5] softmmu/vl: Let -fw_cfg option take a 'gen_id' argument

2020-06-25 Thread Daniel P . Berrangé
On Tue, Jun 23, 2020 at 07:27:24PM +0200, Philippe Mathieu-Daudé wrote: > The 'gen_id' argument refers to a QOM object able to produce > data consumable by the fw_cfg device. The producer object must > implement the FW_CFG_DATA_GENERATOR interface. > > Reviewed-by: Laszlo Ersek > Signed-off-by: P

Re: [PATCH v3 2/2] nvme: allow cmb and pmr to be enabled on same device

2020-06-25 Thread Klaus Jensen
On Jun 22 11:25, Andrzej Jakowski wrote: > So far it was not possible to have CMB and PMR emulated on the same > device, because BAR2 was used exclusively either of PMR or CMB. This > patch places CMB at BAR4 offset so it not conflicts with MSI-X vectors. > > Signed-off-by: Andrzej Jakowski > ---

Re: [PATCH v10 1/5] crypto: Add tls-cipher-suites object

2020-06-25 Thread Daniel P . Berrangé
On Tue, Jun 23, 2020 at 07:27:22PM +0200, Philippe Mathieu-Daudé wrote: > On the host OS, various aspects of TLS operation are configurable. > In particular it is possible for the sysadmin to control the TLS > cipher/protocol algorithms that applications are permitted to use. > > * Any given crypt

Re: [PATCH RFC 2/3] gitlab: build all container images during CI

2020-06-25 Thread Alex Bennée
Daniel P. Berrangé writes: > On Mon, Jun 22, 2020 at 04:33:17PM +0100, Daniel P. Berrangé wrote: >> We have a number of container images in tests/docker/dockerfiles >> that are intended to provide well defined environments for doing >> test builds. We want our CI system to use these containers

Re: [PATCH v10 5/5] crypto/tls-cipher-suites: Produce fw_cfg consumable blob

2020-06-25 Thread Daniel P . Berrangé
On Tue, Jun 23, 2020 at 07:27:26PM +0200, Philippe Mathieu-Daudé wrote: > Since our format is consumable by the fw_cfg device, > we can implement the FW_CFG_DATA_GENERATOR interface. > > Example of use to dump the cipher suites (if tracing enabled): > > $ qemu-system-x86_64 -S \ > -object t

Re: [PATCH v8 31/45] target/arm: Tidy trans_LD1R_zpri

2020-06-25 Thread Peter Maydell
On Tue, 23 Jun 2020 at 20:37, Richard Henderson wrote: > > Move the variable declarations to the top of the function, > but do not create a new label before sve_access_check. > > Signed-off-by: Richard Henderson > --- > v8: Split out from previous patch (pmm). > --- Reviewed-by: Peter Maydell

Re: [PATCH v10 4/5] softmmu/vl: Allow -fw_cfg 'gen_id' option to use the 'etc/' namespace

2020-06-25 Thread Daniel P . Berrangé
On Tue, Jun 23, 2020 at 07:27:25PM +0200, Philippe Mathieu-Daudé wrote: > Names of user-provided fw_cfg items are supposed to start > with "opt/". However FW_CFG_DATA_GENERATOR items are generated > by QEMU, so allow the "etc/" namespace in this specific case. > > Reviewed-by: Laszlo Ersek > Sign

Re: [PATCH RFC 0/3] gitlab: build containers to use in build jobs

2020-06-25 Thread Thomas Huth
On 22/06/2020 17.33, Daniel P. Berrangé wrote: The current gitlab CI jobs are quite inefficient because they use the generic distro images and then apt-get/dnf install extra packages every time. The other downside is that the container environment used is only defined in thte .gitlab-ci.yml file

  1   2   3   4   5   >