On Wed, 24 Jun 2020 18:43:28 +0200 Markus Armbruster <arm...@redhat.com> wrote:
> s390_pci_set_fid() sets zpci->fid_defined to true even when > visit_type_uint32() failed. Reproducer: "-device zpci,fid=junk". > Harmless in practice, because qdev_device_add() then fails, throwing > away @zpci. Fix it anyway. > > Cc: Matthew Rosato <mjros...@linux.ibm.com> > Cc: Cornelia Huck <coh...@redhat.com> > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > hw/s390x/s390-pci-bus.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Cornelia Huck <coh...@redhat.com>