Patchew URL: https://patchew.org/QEMU/20200625100430.22407-1-mhart...@linux.ibm.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [RFC 0/4] Enable virtio-fs on s390x Type: series Message-id: 20200625100430.22407-1-mhart...@linux.ibm.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20200622153318.751107-1-berra...@redhat.com -> patchew/20200622153318.751107-1-berra...@redhat.com * [new tag] patchew/20200625100430.22407-1-mhart...@linux.ibm.com -> patchew/20200625100430.22407-1-mhart...@linux.ibm.com * [new tag] patchew/20200625100811.12690-1-peter.mayd...@linaro.org -> patchew/20200625100811.12690-1-peter.mayd...@linaro.org Switched to a new branch 'test' b2cd719 HACK: Hard-code the libvhost-user.o-cflags for s390x f0ba6d5 libvhost-user: handle endianness as mandated by the spec 5f2feba libvhost-user: print invalid address on vu_panic 19994e0 virtio: add vhost-user-fs-ccw device === OUTPUT BEGIN === 1/4 Checking commit 19994e01a67c (virtio: add vhost-user-fs-ccw device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 ERROR: space required after that ',' (ctx:VxV) #86: FILE: hw/s390x/vhost-user-fs-ccw.c:57: + device_class_set_props(dc,vhost_user_fs_ccw_properties); ^ total: 1 errors, 1 warnings, 81 lines checked Patch 1/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/4 Checking commit 5f2feba1e3c5 (libvhost-user: print invalid address on vu_panic) 3/4 Checking commit f0ba6d5325c1 (libvhost-user: handle endianness as mandated by the spec) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #27: new file mode 100644 ERROR: braces {} are necessary for all arms of this statement #100: FILE: contrib/libvhost-user/libvhost-access.h:69: + if (vu_access_is_big_endian(vdev)) [...] ERROR: braces {} are necessary for all arms of this statement #107: FILE: contrib/libvhost-user/libvhost-access.h:76: + if (vu_access_is_big_endian(vdev)) [...] ERROR: braces {} are necessary for all arms of this statement #114: FILE: contrib/libvhost-user/libvhost-access.h:83: + if (vu_access_is_big_endian(vdev)) [...] WARNING: line over 80 characters #375: FILE: contrib/libvhost-user/libvhost-user.c:2515: + vu_ldq_p(dev, &desc[i].addr), vu_ldl_p(dev, &desc[i].len)); WARNING: line over 80 characters #384: FILE: contrib/libvhost-user/libvhost-user.c:2523: + vu_ldq_p(dev, &desc[i].addr), vu_ldl_p(dev, &desc[i].len)); total: 3 errors, 3 warnings, 392 lines checked Patch 3/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/4 Checking commit b2cd71997828 (HACK: Hard-code the libvhost-user.o-cflags for s390x) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200625100430.22407-1-mhart...@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
