On Thu, May 14, 2020 at 12:56:42AM +0200, Greg Kurz wrote:
> First three patches of this series are simple cleanups. The other
> ones fix some regressions introduced by Cedric's recent addition
> of partition-scoped translation.
Applied to ppc-for-5.1, thanks.
>
> Changes since v1:
> - fix build
On 13.05.20 18:11, Eric Blake wrote:
> On 5/13/20 9:56 AM, Max Reitz wrote:
>> This command allows mapping block node names to aliases for the purpose
>> of block dirty bitmap migration.
>>
>> This way, management tools can use different node names on the source
>> and destination and pass the mapp
On 2020/5/13 下午5:36, Dima Stepanov wrote:
On Wed, May 13, 2020 at 11:00:38AM +0800, Jason Wang wrote:
On 2020/5/12 下午5:08, Dima Stepanov wrote:
On Tue, May 12, 2020 at 11:26:11AM +0800, Jason Wang wrote:
On 2020/5/11 下午5:11, Dima Stepanov wrote:
On Mon, May 11, 2020 at 11:05:58AM +0800, Jas
It is usefull for the Vhost-user backend to know
about about the Virtio device status updates,
especially when the driver sets the DRIVER_OK bit.
With that information, no more need to do hazardous
assumptions on when the driver is done with the
device configuration.
Signed-off-by: Maxime Coqueli
On 2020/5/13 下午5:47, Dima Stepanov wrote:
case CHR_EVENT_CLOSED:
/* a close event may happen during a read/write, but vhost
* code assumes the vhost_dev remains setup, so delay the
* stop & clear to idle.
* FIXME: better handle failure in vhost code,
On 13.05.20 22:09, Vladimir Sementsov-Ogievskiy wrote:
> 13.05.2020 17:56, Max Reitz wrote:
>> This command allows mapping block node names to aliases for the purpose
>> of block dirty bitmap migration.
>>
>> This way, management tools can use different node names on the source
>> and destination a
Richard,
this problem seems related to the work you already done on vsyscalls:
b26491b4d4f8 ("linux-user/i386: Emulate x86_64 vsyscalls")
I don't know if we should support AT_SYSINFO or consider this as a bug
of the target libc.
--
You received this bug notification because you are a member
On 2020/5/14 下午3:33, Maxime Coquelin wrote:
It is usefull for the Vhost-user backend to know
about about the Virtio device status updates,
especially when the driver sets the DRIVER_OK bit.
With that information, no more need to do hazardous
assumptions on when the driver is done with the
devi
On 5/14/20 6:46 AM, Klaus Jensen wrote:
From: Klaus Jensen
Signed-off-by: Klaus Jensen
Reviewed-by: Maxim Levitsky
---
hw/block/nvme.c | 95 ++---
1 file changed, 51 insertions(+), 44 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
i
28.04.2020 08:20, Vladimir Sementsov-Ogievskiy wrote:
27.04.2020 18:36, Markus Armbruster wrote:
Markus Armbruster writes:
Markus Armbruster writes:
QEMU's Error was patterned after GLib's GError. Differences include:
[...]
* Return value conventions
Common: non-void functions retur
On 5/14/20 6:46 AM, Klaus Jensen wrote:
From: Klaus Jensen
Having the patch subject duplicated ease review (not all email client
display email subject close to email content):
"Do cmb/pmr init as part of pci init."
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Klaus Jensen
Review
IMHO configuration files are in general a failed experiment. In
practice, they do not add much value over just a shell script because
they don't allow configuring all QEMU options, they are very much fixed
(by their nature). I think it's more or less agreed that they are not
solving any problem f
** Changed in: kunpeng920
Status: Triaged => In Progress
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1805256
Title:
qemu-img hangs on rcu_call_ready_event logic in Aarch64 when
convertin
On 5/14/20 1:24 AM, John Snow wrote:
On 5/10/20 11:51 PM, Alexander Bulekov wrote:
Hello,
While fuzzing, I found an input that triggers an assertion failure
through virtio-rng -> vring_split_desc_read. Maybe this is related to:
Message-ID: <20200511033001.dzvtbdhl3oz5p...@mozz.bu.edu>
Assertio
I'm not able to reproduce your problem.
Are you able to reproduce the problem if you cleanup your build
directory (make distclean)?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1878348
Title:
--s
* Max Reitz (mre...@redhat.com) wrote:
> +void qmp_migrate_set_bitmap_node_mapping(MigrationBlockNodeMappingList
> *mapping,
> + Error **errp)
> +{
> +QDict *in_mapping = qdict_new();
> +QDict *out_mapping = qdict_new();
> +
> +for (; mapping;
Hello,
Thanks for the detailed explaination and insightful advise!!
I firstly give a try to use objcopy from GNU binutils, but it
seems the COFF file I am work on (which is generated by TI's CCS IDE) cannot be
recognized. The COFF format used by TI sllightly differs from GNU's definition.
On Thu, 14 May 2020 at 09:44, casmac <1482995...@qq.com> wrote:
>
> Hello,
>Thanks for the detailed explaination and insightful advise!!
>I firstly give a try to use objcopy from GNU binutils, but it seems the
> COFF file I am work on (which is generated by TI's CCS IDE) cannot be
> recog
On Thu, May 14, 2020 at 10:09:21AM +0200, Paolo Bonzini wrote:
> IMHO configuration files are in general a failed experiment. In
> practice, they do not add much value over just a shell script because
> they don't allow configuring all QEMU options, they are very much fixed
> (by their nature). I
On Thu, May 14, 2020 at 10:09:21AM +0200, Paolo Bonzini wrote:
> IMHO configuration files are in general a failed experiment. In
> practice, they do not add much value over just a shell script because
> they don't allow configuring all QEMU options, they are very much fixed
> (by their nature). I
From: Christian Schoenebeck
If delivery of some 9pfs response fails for some reason, log the
error message by mentioning the 9P protocol reply type, not by
client's request type. The latter could be misleading that the
error occurred already when handling the request input.
Signed-off-by: Christ
From: Christian Schoenebeck
The docs are ambiguous about the difference (or actually their
equality) between options '-virtfs' vs. '-fsdev'. So clarify that
'-virtfs' is actually just a convenience shortcut for its
generalized form '-fsdev' in conjunction with '-device virtio-9p-pci'.
And as we'
From: Omar Sandoval
QEMU's local 9pfs server passes through O_NOATIME from the client. If
the QEMU process doesn't have permissions to use O_NOATIME (namely, it
does not own the file nor have the CAP_FOWNER capability), the open will
fail. This causes issues when from the client's point of view,
From: Christian Schoenebeck
As suggested by Greg, let's upgrade myself as co-maintainer of 9pfs.
Signed-off-by: Christian Schoenebeck
Reviewed-by: Philippe Mathieu-Daudé
Message-Id:
Signed-off-by: Greg Kurz
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
The following changes since commit d5c75ec500d96f1d93447f990cd5a4ef5ba27fae:
Merge remote-tracking branch
'remotes/stefanberger/tags/pull-tpm-2020-05-08-1' into staging (2020-05-12
17:00:10 +0100)
are available in the Git repository at:
https://github.com/gkurz/qemu.git tags/9p-next-2020-0
On 14.05.20 10:42, Dr. David Alan Gilbert wrote:
> * Max Reitz (mre...@redhat.com) wrote:
>
>
>
>> +void qmp_migrate_set_bitmap_node_mapping(MigrationBlockNodeMappingList
>> *mapping,
>> + Error **errp)
>> +{
>> +QDict *in_mapping = qdict_new();
>> +
On 13.05.20 22:09, Vladimir Sementsov-Ogievskiy wrote:
[...]
> 1. So, you decided to make only node-mapping, not bitmap-mapping, so we
> can't rename bitmaps in-flight and can't migrate bitmaps from one node
> to several and visa-versa. I think it's OK, nothing good in such
> possibilities, and thi
Right, after a make distclean + configure, I managed to complete the
build after installing libffi-dev libselinux1-dev.
However, I think there's a bug in configure: it should either complain
when these packages are missing, or disable the module that needs them.
Without libffi-dev and libselinux1
* Max Reitz (mre...@redhat.com) wrote:
> On 14.05.20 10:42, Dr. David Alan Gilbert wrote:
> > * Max Reitz (mre...@redhat.com) wrote:
> >
> >
> >
> >> +void qmp_migrate_set_bitmap_node_mapping(MigrationBlockNodeMappingList
> >> *mapping,
> >> + Error **err
On Wed, 13 May 2020 16:08:06 -0400
Jag Raman wrote:
> > On May 13, 2020, at 11:25 AM, Igor Mammedov wrote:
> >
> > On Wed, 13 May 2020 09:40:42 +0100
> > Stefan Hajnoczi wrote:
> >
> >> On Tue, May 12, 2020 at 07:56:33AM -0400, Jag Raman wrote:
> >>>
> >>>
> On May 12, 2020, at 4
* Jag Raman (jag.ra...@oracle.com) wrote:
>
>
> > On May 13, 2020, at 11:25 AM, Igor Mammedov wrote:
> >
> > On Wed, 13 May 2020 09:40:42 +0100
> > Stefan Hajnoczi wrote:
> >
> >> On Tue, May 12, 2020 at 07:56:33AM -0400, Jag Raman wrote:
> >>>
> >>>
> On May 12, 2020, at 4:48 AM, Dani
On Wed, 13 May 2020 at 15:15, Max Reitz wrote:
>
> The following changes since commit d5c75ec500d96f1d93447f990cd5a4ef5ba27fae:
>
> Merge remote-tracking branch
> 'remotes/stefanberger/tags/pull-tpm-2020-05-08-1' into staging (2020-05-12
> 17:00:10 +0100)
>
> are available in the Git repositor
On Tue, 12 May 2020 17:59:25 +0200
Auger Eric wrote:
> Hi Igor,
>
> On 5/12/20 4:14 PM, Igor Mammedov wrote:
> > On Wed, 6 May 2020 05:58:25 -0400
> > "Michael S. Tsirkin" wrote:
> >
> >> On Wed, May 06, 2020 at 08:33:14AM +0200, Andrew Jones wrote:
> >>> I realize this function is just ge
On Wed, 13 May 2020 at 15:23, Eduardo Habkost wrote:
>
> Peter, note that my PGP key had expired 2 weeks ago, so you'll
> probably see a few signature check warnings.
I couldn't find your updated key on the keyservers -- which
server did you upload it to?
thanks
-- PMM
Hi John,
Looks like an AHCI emulation issue. I have subscribed you to this bug report.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1878255
Title:
Assertion failure in bdrv_aio_cancel, through ide
Am 14.05.2020 um 08:24 hat John Snow geschrieben:
> On 3/31/20 9:44 AM, Kevin Wolf wrote:
> > Am 31.03.2020 um 02:00 hat John Snow geschrieben:
> >> We can turn logging on/off globally instead of per-function.
> >>
> >> Remove use_log from run_job, and use python logging to turn on
> >> diffable ou
On Sun, 10 May 2020 13:35:05 +0200
Philippe Mathieu-Daudé wrote:
> Since commit 82b911aaff3, machine_run_board_init() checks for
> ram_memdev_id and consume it. As TYPE_SUN4M_MEMORY is no more
> needed, replace it by the generic memdev allocated MemoryRegion
> and remove it. This completes commit
Semi-officially, QEMU only aims to support static linking with usermode
emulators, not system mode emulators. I'm not sure we make that clear
anywhere in the docs, or configure script. We should probably print a
warning from configure if using --static in combination with system
emulators, that th
On 5/14/20 9:53 AM, Jason Wang wrote:
>
> On 2020/5/14 下午3:33, Maxime Coquelin wrote:
>> It is usefull for the Vhost-user backend to know
>> about about the Virtio device status updates,
>> especially when the driver sets the DRIVER_OK bit.
>>
>> With that information, no more need to do hazard
I think it's largely that many distros ship pkg-config files which are
just broken for the static linking case -- so configure tests "does pkg-
config say this will work for static linking", and pkg-config says "yes,
that will work", and then it doesn't. If you care about trying to get
this to be m
On Wed, 13 May 2020 at 17:32, Richard Henderson
wrote:
>
> Version 4 fixes the VRSRA bug, and updates for other review comments.
>
> For patch 13 "target/arm: Pass pointer to qc to qrdmla/qrdmls",
> I added a note about the type change on the inline functions.
>
Applied to target-arm.next, than
Am 13.05.2020 um 21:12 hat Lukas Straub geschrieben:
> Terminology:
> instance = one (nbd) blockdev/one chardev/the single migrationstate
> connection = one TCP connection
>
> Hello Everyone,
> Having read all the comments, here is proposal v2:
Looks quite good to me.
> Every instance registers
On Wed, 13 May 2020 at 22:52, John Snow wrote:
> +# We require the python3 version of sphinx, but sphinx-build-3 is a
> +# distro package. prefer 'sphinx-build' to find the venv version, if
> +# any, but ensure it is a suitable version.
> sphinx_build=
> -for binary in sphinx-build-3 sphinx-buil
On Thu, May 14, 2020 at 09:33:32AM +0200, Maxime Coquelin wrote:
> It is usefull for the Vhost-user backend to know
> about about the Virtio device status updates,
> especially when the driver sets the DRIVER_OK bit.
>
> With that information, no more need to do hazardous
> assumptions on when the
On Thu, 14 May 2020 at 10:05, Greg Kurz wrote:
>
> The following changes since commit d5c75ec500d96f1d93447f990cd5a4ef5ba27fae:
>
> Merge remote-tracking branch
> 'remotes/stefanberger/tags/pull-tpm-2020-05-08-1' into staging (2020-05-12
> 17:00:10 +0100)
>
> are available in the Git repositor
On Thu, May 14, 2020 at 12:14:32PM +0200, Maxime Coquelin wrote:
>
>
> On 5/14/20 9:53 AM, Jason Wang wrote:
> >
> > On 2020/5/14 下午3:33, Maxime Coquelin wrote:
> >> It is usefull for the Vhost-user backend to know
> >> about about the Virtio device status updates,
> >> especially when the drive
14.05.2020 12:09, Max Reitz wrote:
On 13.05.20 22:09, Vladimir Sementsov-Ogievskiy wrote:
[...]
1. So, you decided to make only node-mapping, not bitmap-mapping, so we
can't rename bitmaps in-flight and can't migrate bitmaps from one node
to several and visa-versa. I think it's OK, nothing good
On Thu, 30 Apr 2020 16:50:25 +0200
David Hildenbrand wrote:
> On 29.04.20 14:11, Janosch Frank wrote:
> > On 3/24/20 4:08 PM, Janosch Frank wrote:
> >> The bios is in dire need for a cleanup as there are still a lot of
> >> magic constants being used throughout as well as duplicated code.
> >>
* Lukas Straub (lukasstra...@web.de) wrote:
> Terminology:
> instance = one (nbd) blockdev/one chardev/the single migrationstate
> connection = one TCP connection
>
> Hello Everyone,
> Having read all the comments, here is proposal v2:
> Every instance registers itself with a unique name in the fo
Am 14.05.2020 um 11:09 hat Max Reitz geschrieben:
> On 13.05.20 22:09, Vladimir Sementsov-Ogievskiy wrote:
> [...]
> > 1. So, you decided to make only node-mapping, not bitmap-mapping, so we
> > can't rename bitmaps in-flight and can't migrate bitmaps from one node
> > to several and visa-versa. I
On Wed, 6 May 2020 at 19:32, Patrick Williams wrote:
>
> Sonora Pass is a 2 socket x86 motherboard designed by Facebook
> and supported by OpenBMC. Strapping configuration was obtained
> from hardware and i2c configuration is based on dts found at:
>
> https://github.com/facebook/openbmc-linux/bl
Am 14.05.2020 um 09:13 hat Max Reitz geschrieben:
> On 13.05.20 18:11, Eric Blake wrote:
> > On 5/13/20 9:56 AM, Max Reitz wrote:
> >> This command allows mapping block node names to aliases for the purpose
> >> of block dirty bitmap migration.
> >>
> >> This way, management tools can use different
On Tue, 12 May 2020 at 04:03, Dongjiu Geng wrote:
>
> The little end UUID is used in many places, so make
> NVDIMM_UUID_LE to a common macro to convert the UUID
> to a little end array.
>
> Reviewed-by: Xiang Zheng
> Signed-off-by: Dongjiu Geng
> ---
Reviewed-by: Peter Maydell
thanks
-- PMM
On 5/14/20 12:59 PM, Cornelia Huck wrote:
> On Thu, 30 Apr 2020 16:50:25 +0200
> David Hildenbrand wrote:
>
>> On 29.04.20 14:11, Janosch Frank wrote:
>>> On 3/24/20 4:08 PM, Janosch Frank wrote:
The bios is in dire need for a cleanup as there are still a lot of
magic constants being
Dear all,
I have encountered a weird crash.
I remember before a few days it works well and I rebase my code from upstream.
This is the command:
/root/qemu-master/x86_64-softmmu/qemu-system-x86_64 -enable-kvm
-device virtio-balloon -cpu host -smp 4 -m 2G -drive
file=/root/html/fedora-10g.img,forma
On 4/7/20 9:25 AM, Cornelia Huck wrote:
> On Tue, 24 Mar 2020 11:08:44 -0400
> Janosch Frank wrote:
>
>> panic() was defined for the ccw and net bios, i.e. twice, so it's
>> cleaner to rather put it into the header.
>
> They were also slightly different, so unifying them makes sense.
>
>>
>> Al
On 4/30/20 5:36 PM, David Hildenbrand wrote:
> On 24.03.20 16:08, Janosch Frank wrote:
>> 0x00 looks odd, time to replace it with 0 or 0x0 (for pointers).
>
> s/0x0/NULL/ ?
I'd like to avoid NULL if I refer to offset 0 of the memory and only use
it to indicate that I purposely do not assign any s
13.05.2020 04:16, Eric Blake wrote:
-HBitmap **backup, Error **errp)
+BdrvDirtyBitmap *block_dirty_bitmap_merge(const char *node, const char *target,
+ BlockDirtyBitmapMergeSourceList
*bitmaps,
+ HBitmap **
On Thu, 14 May 2020 13:27:20 +0200
Janosch Frank wrote:
> On 4/7/20 9:25 AM, Cornelia Huck wrote:
> > On Tue, 24 Mar 2020 11:08:44 -0400
> > Janosch Frank wrote:
> >
> >> panic() was defined for the ccw and net bios, i.e. twice, so it's
> >> cleaner to rather put it into the header.
> >
>
On 5/14/2020 10:31 AM, Alex Williamson wrote:
On Thu, 14 May 2020 01:34:38 +0530
Kirti Wankhede wrote:
Added migration capability in IOMMU info chain.
User application should check IOMMU info chain for migration capability
to use dirty page tracking feature provided by kernel module.
User a
On 10.05.20 15:40, Maxim Levitsky wrote:
> Next few patches will expose that functionality to the user.
>
> Signed-off-by: Maxim Levitsky
> Reviewed-by: Daniel P. Berrangé
> ---
> crypto/block-luks.c | 395 +++-
> qapi/crypto.json| 61 ++-
> 2 fi
Cc'ing David/Paolo in case they have a clue...
On 5/14/20 1:27 PM, Li Feng wrote:
Dear all,
I have encountered a weird crash.
I remember before a few days it works well and I rebase my code from upstream.
This is the command:
/root/qemu-master/x86_64-softmmu/qemu-system-x86_64 -enable-kvm
-dev
On 5/14/20 12:09 PM, Igor Mammedov wrote:
On Sun, 10 May 2020 13:35:05 +0200
Philippe Mathieu-Daudé wrote:
Since commit 82b911aaff3, machine_run_board_init() checks for
ram_memdev_id and consume it. As TYPE_SUN4M_MEMORY is no more
needed, replace it by the generic memdev allocated MemoryRegion
On 10.05.20 15:40, Maxim Levitsky wrote:
> 'force' option will be used for some unsafe amend operations.
>
> This includes things like erasing last keyslot in luks based formats
> (which destroys the data, unless the master key is backed up
> by external means), but that _might_ be desired result.
On Mon, May 11, 2020 at 11:48:53PM -0700, Paul Zimmerman wrote:
> Gerd, Peter, what do you think about accepting this patch series? The
> only possibly disruptive patch is #5, which modifies the dev-storage.c
> code a bit, the rest is all new code which shouldn't affect anything
> else. Felippe Mat
The following changes since commit d5c75ec500d96f1d93447f990cd5a4ef5ba27fae:
Merge remote-tracking branch
'remotes/stefanberger/tags/pull-tpm-2020-05-08-1' into staging (2020-05-12
17:00:10 +0100)
are available in the Git repository at:
git://git.kraxel.org/qemu tags/usb-202
From: Paul Zimmerman
Add a check for functional dwc-hsotg (dwc2) USB host emulation to
the Raspi 2 acceptance test
Reviewed-by: Philippe Mathieu-Daude
Signed-off-by: Paul Zimmerman
Message-id: 20200512064900.28554-8-pauld...@gmail.com
Signed-off-by: Gerd Hoffmann
---
tests/acceptance/boot_li
From: Paul Zimmerman
Add the dwc-hsotg (dwc2) USB host controller state definitions.
Mostly based on hw/usb/hcd-ehci.h.
Signed-off-by: Paul Zimmerman
Message-id: 20200512064900.28554-4-pauld...@gmail.com
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-dwc2.h | 173
From: Paul Zimmerman
Add BCM2835 SOC MPHI (Message-based Parallel Host Interface)
emulation. It is very basic, only providing the FIQ interrupt
needed to allow the dwc-otg USB host controller driver in the
Raspbian kernel to function.
Signed-off-by: Paul Zimmerman
Message-id: 20200512064900.285
From: Paul Zimmerman
Add the dwc-hsotg (dwc2) USB host controller emulation code.
Based on hw/usb/hcd-ehci.c and hw/usb/hcd-ohci.c.
Note that to use this with the dwc-otg driver in the Raspbian
kernel, you must pass the option "dwc_otg.fiq_fsm_enable=0" on
the kernel command line.
Emulation of
From: Paul Zimmerman
Import the dwc-hsotg (dwc2) register definitions file from the
Linux kernel. This is a copy of drivers/usb/dwc2/hw.h from the
mainline Linux kernel, the only changes being two instances of
'u32' changed to 'uint32_t' to allow it to compile. Checkpatch
throws a boatload of er
From: Paul Zimmerman
Wire the dwc-hsotg (dwc2) emulation into Qemu
Reviewed-by: Philippe Mathieu-Daude
Signed-off-by: Paul Zimmerman
Message-id: 20200512064900.28554-7-pauld...@gmail.com
Signed-off-by: Gerd Hoffmann
---
include/hw/arm/bcm2835_peripherals.h | 3 ++-
hw/arm/bcm2835_peripheral
On Fri, May 08, 2020 at 09:44:24PM +0800, Changbin Du wrote:
> hello, is this ready to merge now?
>
> On Mon, Apr 27, 2020 at 09:24:12PM +0800, Changbin Du wrote:
> > I found SDL_GetWindowFromID() sometimes return NULL when I start qemu via
> > ssh forwarding even the window has been crated alread
From: Paul Zimmerman
The dwc-hsotg (dwc2) USB host depends on a short packet to
indicate the end of an IN transfer. The usb-storage driver
currently doesn't provide this, so fix it.
I have tested this change rather extensively using a PC
emulation with xhci, ehci, and uhci controllers, and have
On 10.05.20 15:40, Maxim Levitsky wrote:
> Some options are only useful for creation
> (or hard to be amended, like cluster size for qcow2), while some other
> options are only useful for amend, like upcoming keyslot management
> options for luks
>
> Since currently only qcow2 supports amend, move
On 5/14/2020 10:32 AM, Alex Williamson wrote:
On Thu, 14 May 2020 01:34:36 +0530
Kirti Wankhede wrote:
VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations:
- Start dirty pages tracking while migration is active
- Stop dirty pages tracking.
- Get dirty pages bitmap. Its user space applica
Let's move some of the PSW mask defines into s390-arch.h and use them
in jump2ipl.c
Signed-off-by: Janosch Frank
Reviewed-by: David Hildenbrand
---
pc-bios/s390-ccw/jump2ipl.c | 10 --
pc-bios/s390-ccw/s390-arch.h | 2 ++
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/
The bios is in dire need for a cleanup as there are still a lot of
magic constants being used throughout as well as duplicated code.
In the first part of this series we consolidate constants and
functions, as well as doing some minor cleanups and fixes.
The patches are available here:
https://git
Let's initialize the structs at the beginning to ease reading and also
zeroing all other fields. This also makes the compiler stop
compalining about sense_id_ccw.flags being ored into when it's not
initialized.
Signed-off-by: Janosch Frank
Reviewed-by: Pierre Morel
---
pc-bios/s390-ccw/cio.c |
ZMODE has a lot of ambiguity with the ESAME architecture mode, but is
actually 64 bit addressing.
Signed-off-by: Janosch Frank
Reviewed-by: Pierre Morel
Reviewed-by: David Hildenbrand
---
pc-bios/s390-ccw/dasd-ipl.c | 3 +--
pc-bios/s390-ccw/s390-arch.h | 2 +-
2 files changed, 2 insertions(+
If we have a lowcore struct that has members for offsets that we want
to touch, why not use it?
Signed-off-by: Janosch Frank
---
pc-bios/s390-ccw/cio.h | 17 +++--
pc-bios/s390-ccw/main.c | 8 +++-
2 files changed, 14 insertions(+), 11 deletions(-)
diff --git a/pc-bios/s390-cc
On 14/05/20 10:56, Daniel P. Berrangé wrote:
> On Thu, May 14, 2020 at 10:09:21AM +0200, Paolo Bonzini wrote:
>> IMHO configuration files are in general a failed experiment. In
>> practice, they do not add much value over just a shell script because
>> they don't allow configuring all QEMU options
panic() was defined for the ccw and net bios, i.e. twice, so it's
cleaner to rather put it into the header.
Also let's add an infinite loop into the assembly of disabled_wait() so
the caller doesn't need to take care of it.
Signed-off-by: Janosch Frank
Reviewed-by: Pierre Morel
Reviewed-by: Dav
Why should we do conversion of a ebcdic value if we have a handy table
where we coul look up the ascii value instead?
Signed-off-by: Janosch Frank
Reviewed-by: David Hildenbrand
---
pc-bios/s390-ccw/bootmap.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/pc-bios/s390-cc
Let's make it a bit more clear that we check the full 64 bits to fit
into the 32 we return.
Signed-off-by: Janosch Frank
Suggested-by: David Hildenbrand
Reviewed-by: David Hildenbrand
---
pc-bios/s390-ccw/helper.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pc-bios/s390
Let's consolidate timing related functions into one header.
Signed-off-by: Janosch Frank
---
pc-bios/s390-ccw/menu.c| 1 +
pc-bios/s390-ccw/netmain.c | 15 +++--
pc-bios/s390-ccw/s390-ccw.h| 18
pc-bios/s390-ccw/time.h| 39 +++
On Thu, 14 May 2020 at 13:22, Gerd Hoffmann wrote:
>
> On Mon, May 11, 2020 at 11:48:53PM -0700, Paul Zimmerman wrote:
> > Gerd, Peter, what do you think about accepting this patch series? The
> > only possibly disruptive patch is #5, which modifies the dev-storage.c
> > code a bit, the rest is al
>
> are available in the Git repository at:
>
> git://git.kraxel.org/qemu tags/usb-20200514-pull-request
>
> for you to fetch changes up to 8b2b45c506f4d71b831473d8de93b3cedaea4844:
>
> raspi2 acceptance test: add test for dwc
0x00 looks odd, time to replace it with 0 or 0x0 (for pointers).
Signed-off-by: Janosch Frank
---
pc-bios/s390-ccw/dasd-ipl.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/pc-bios/s390-ccw/dasd-ipl.c b/pc-bios/s390-ccw/dasd-ipl.c
index b932531e6f..764ee89e92
Reviewed-by: zhanghailiang
>
> If we suceed in receiving ram state, but fail receiving the device state,
> there
> will be a mismatch between the two.
>
> Fix this by flushing the ram cache only after the vmstate has been received.
>
> Signed-off-by: Lukas Straub
> ---
> migration/colo.c |
Patchew URL:
https://patchew.org/QEMU/20200514063112.1457125-1-raphael.p...@hetzner.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20200514063112.1457125-1-raphael.p...@hetzner.com
Subject: [PATCH v2 0/1] qemu-nbd: Close inher
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
> Cc'ing David/Paolo in case they have a clue...
>
> On 5/14/20 1:27 PM, Li Feng wrote:
> > Dear all,
> >
> > I have encountered a weird crash.
> > I remember before a few days it works well and I rebase my code from
> > upstream.
> >
> > Thi
On Tue, 12 May 2020 at 04:03, Dongjiu Geng wrote:
>
> In the ARMv8 platform, the CPU error types includes synchronous external
> abort(SEA)
> and SError Interrupt (SEI). If exception happens in guest, host does not know
> the detailed
> information of guest, so it is expected that guest can do t
> This causes the migration thread to hang if we failover during checkpoint. A
> shutdown fd won't cause network traffic anyway.
>
I'm not quite sure if this modification can take side effect on normal
migration process or not,
There are several places calling it.
Maybe Juan and Dave can help ;
Am 29.04.2020 um 16:11 hat Max Reitz geschrieben:
> v1: https://lists.nongnu.org/archive/html/qemu-block/2020-04/msg01245.html
>
> Branch: https://github.com/XanClic/qemu.git fix-bdrv_make_empty-v2
> Branch: https://git.xanclic.moe/XanClic/qemu.git fix-bdrv_make_empty-v2
>
> Based-on: <2020042819
On Mon, May 11, 2020 at 07:36:29PM +0100, Stefan Hajnoczi wrote:
> The io_uring file descriptor monitoring implementation has an internal
> list of fd handlers that are pending submission to io_uring.
> fdmon_io_uring_destroy() deletes all fd handlers on the list.
>
> Don't delete fd handlers dire
On Mon, May 11, 2020 at 07:36:30PM +0100, Stefan Hajnoczi wrote:
> The glib event loop does not call fdmon_io_uring_wait() so fd handlers
> waiting to be submitted build up in the list. There is no benefit is
> using io_uring when the glib GSource is being used, so disable it
> instead of implement
"Dr. David Alan Gilbert" writes:
> * Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
>> Cc'ing David/Paolo in case they have a clue...
>>
>> On 5/14/20 1:27 PM, Li Feng wrote:
>> > Dear all,
>> >
>> > I have encountered a weird crash.
>> > I remember before a few days it works well and I reb
On Tue, 12 May 2020 at 08:48, Philippe Mathieu-Daudé wrote:
>
> Coverity points out (CID 1421934) that we are leaking the
> memory returned by qemu_allocate_irqs(). We can avoid this
> leak by switching to using qdev_init_gpio_in(); the base
> class finalize will free the irqs that this allocates
Hi Prasad,
On Thursday, 2020-05-14 at 00:55:38 +0530, P J P wrote:
> From: Prasad J Pandit
>
> A guest user may set 'reply_queue_head' field of MegasasState to
> a negative value. Later in 'megasas_lookup_frame' it is used to
> index into s->frames[] array. Use unsigned type to avoid OOB
> access
1 - 100 of 428 matches
Mail list logo
