On Tue, 12 May 2020 17:59:25 +0200 Auger Eric <eric.au...@redhat.com> wrote:
> Hi Igor, > > On 5/12/20 4:14 PM, Igor Mammedov wrote: > > On Wed, 6 May 2020 05:58:25 -0400 > > "Michael S. Tsirkin" <m...@redhat.com> wrote: > > > >> On Wed, May 06, 2020 at 08:33:14AM +0200, Andrew Jones wrote: > >>> I realize this function is just getting moved, but maybe it should get > >>> converted to the build_append* API while being moved? > >> > >> I'd rather refactoring was done in a separate patch - > >> easier to review. > > maybe first convert and then move > > > > PS: > > me wonders if we have test with TPM enabled, if not maybe it's time to add > > them > > i.e. first goes testcase in bios-tables and then refactoring/moving > > in that case review is simpler. > Do you mean tests checking the ACPI table content when TPM is > instantiated? I don't think so otherwise it would have failed I guess. yes, I've meant that. > Otherwise we have functional tests with TPM (MMIO access), ie qtest > tests tpm-tis-device-test and tpm-tis-device-swtpm-test. > > Thanks > > Eric > > > >
