Hi Anup,
On Sun, May 3, 2020 at 12:38 PM Anup Patel wrote:
>
> On Fri, May 1, 2020 at 9:26 PM Bin Meng wrote:
> >
> > From: Bin Meng
> >
> > The RISC-V generic platform is a flattened device tree (FDT) based
> > platform where all platform specific functionality is provided based
> > on FDT pas
Few patches while playing with the Zephyr Project.
- better display of unimplemented peripheral accesses,
- better display of timers use.
Philippe Mathieu-Daudé (4):
hw/arm/nrf51: Add NRF51_PERIPHERAL_SIZE definition
hw/arm/nrf51_soc: Mark some peripherals as unimplemented
hw/timer/nrf51_ti
Map some peripherals used by Zephyr Project:
https://github.com/zephyrproject-rtos/zephyr/blob/zephyr-v2.2.0/dts/arm/nordic/nrf51822.dtsi
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/arm/nrf51.h | 4
hw/arm/nrf51_soc.c | 11 +++
2 files changed, 15 insertions(+)
diff
On the NRF51 series, all peripherals have a fixed I/O size
of 4KiB. Define NRF51_PERIPHERAL_SIZE and use it.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/arm/nrf51.h| 3 +--
include/hw/i2c/microbit_i2c.h | 2 +-
hw/arm/nrf51_soc.c| 4 ++--
hw/i2c/microbit_i2c.c
Add trace event to display timer's counter value updates.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/timer/nrf51_timer.c | 1 +
hw/timer/trace-events | 1 +
2 files changed, 2 insertions(+)
diff --git a/hw/timer/nrf51_timer.c b/hw/timer/nrf51_timer.c
index 38cea0542e..42be79c736 100644
--- a
The NRF51 series SoC have 3 timer peripherals, each having
4 counters. To help differentiate which peripheral is accessed,
display the timer ID in the trace events.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/timer/nrf51_timer.h | 1 +
hw/arm/nrf51_soc.c | 5 +
hw/time
PPA created with temporarily workaround in comment #34.
https://launchpad.net/~ikepanhc/+archive/ubuntu/lp1805256
This PPA can solve temporarily but is not acceptable for offical
release.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QE
On 04.05.20 08:46, Janosch Frank wrote:
> On 4/30/20 5:42 PM, David Hildenbrand wrote:
>> On 24.03.20 16:08, Janosch Frank wrote:
>>> panic() was defined for the ccw and net bios, i.e. twice, so it's
>>> cleaner to rather put it into the header.
>>>
>>> Also let's add an infinite loop into the asse
On Mon, May 4, 2020 at 12:46 PM Bin Meng wrote:
>
> Hi Anup,
>
> On Sun, May 3, 2020 at 12:38 PM Anup Patel wrote:
> >
> > On Fri, May 1, 2020 at 9:26 PM Bin Meng wrote:
> > >
> > > From: Bin Meng
> > >
> > > The RISC-V generic platform is a flattened device tree (FDT) based
> > > platform wher
On 30.04.20 15:56, Denis Plotnikov wrote:
>
>
> On 30.04.2020 14:47, Max Reitz wrote:
>> On 30.04.20 11:48, Denis Plotnikov wrote:
>>>
>>> On 30.04.2020 11:26, Max Reitz wrote:
On 29.04.20 15:02, Vladimir Sementsov-Ogievskiy wrote:
> 29.04.2020 15:17, Max Reitz wrote:
>> On 29.04.20
Hi Anup,
On Mon, May 4, 2020 at 3:52 PM Anup Patel wrote:
>
> On Mon, May 4, 2020 at 12:46 PM Bin Meng wrote:
> >
> > Hi Anup,
> >
> > On Sun, May 3, 2020 at 12:38 PM Anup Patel wrote:
> > >
> > > On Fri, May 1, 2020 at 9:26 PM Bin Meng wrote:
> > > >
> > > > From: Bin Meng
> > > >
> > > > Th
On Mon, May 4, 2020 at 4:00 PM Bin Meng wrote:
>
> Hi Anup,
>
> On Mon, May 4, 2020 at 3:52 PM Anup Patel wrote:
> >
> > On Mon, May 4, 2020 at 12:46 PM Bin Meng wrote:
> > >
> > > Hi Anup,
> > >
> > > On Sun, May 3, 2020 at 12:38 PM Anup Patel wrote:
> > > >
> > > > On Fri, May 1, 2020 at 9:26
* Peter Maydell (peter.mayd...@linaro.org) wrote:
> On Fri, 1 May 2020 at 20:16, Dr. David Alan Gilbert (git)
> wrote:
> >
> > From: "Dr. David Alan Gilbert"
> >
> > The following changes since commit 1c47613588ccff44422d4bdeea0dc36a0a308ec7:
> >
> > Merge remote-tracking branch 'remotes/kevin/
Extract timer definitions to 'hw/timer/tmu012.h'.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/sh4/sh.h | 9 -
include/hw/timer/tmu012.h | 23 +++
hw/sh4/sh7750.c | 1 +
hw/timer/sh_timer.c | 2 ++
4 files changed, 26 insertions(+), 9
Some SH4 patches worth salvaging while doing housekeeping.
Philippe Mathieu-Daudé (3):
hw/sh4: Use MemoryRegion typedef
hw/sh4: Extract timer definitions to 'hw/timer/tmu012.h'
hw/timer/sh_timer: Remove unused 'qemu/timer.h' include
include/hw/sh4/sh.h | 12 +---
include/hw/t
Use the MemoryRegion type defined in "qemu/typedefs.h",
to keep the repository style consistent.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/sh4/sh.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/include/hw/sh4/sh.h b/include/hw/sh4/sh.h
index 767a2df7e2..fe77
On Mon, May 4, 2020 at 1:35 PM Bin Meng wrote:
>
> On Mon, May 4, 2020 at 4:00 PM Bin Meng wrote:
> >
> > Hi Anup,
> >
> > On Mon, May 4, 2020 at 3:52 PM Anup Patel wrote:
> > >
> > > On Mon, May 4, 2020 at 12:46 PM Bin Meng wrote:
> > > >
> > > > Hi Anup,
> > > >
> > > > On Sun, May 3, 2020 at
Remove unused "qemu/timer.h" include.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/timer/sh_timer.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/timer/sh_timer.c b/hw/timer/sh_timer.c
index b9cbacf5d0..bb0e1c8ee5 100644
--- a/hw/timer/sh_timer.c
+++ b/hw/timer/sh_timer.c
@@ -13,7 +13,6
On Thu, 16 Apr 2020 at 16:48, Peter Maydell wrote:
>
> On Thu, 9 Apr 2020 at 07:31, Joel Stanley wrote:
> >
> > This is a boot stub that is similar to the code u-boot runs, allowing
> > the kernel to boot the secondary CPU.
>
> > +static void aspeed_write_smpboot(ARMCPU *cpu,
> > +
This is a boot stub that is similar to the code u-boot runs, allowing
the kernel to boot the secondary CPU.
u-boot works as follows:
1. Initialises the SMP mailbox area in the SCU at 0x1e6e2180 with default
values
2. Copies a stub named 'mailbox_insn' from flash to the SCU, just above the
To use the DEFINE_EDID_PROPERTIES() macro we need the
definitions from "hw/qdev-properties.h".
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/display/edid.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/hw/display/edid.h b/include/hw/display/edid.h
index ff99dc0a05..23371ee82
As target-specific code use this header, move it to the publicly
accessible include/ folder.
$ git grep hw/usb/hcd-ehci.h
hw/arm/allwinner-h3.c:31:#include "hw/usb/hcd-ehci.h"
hw/arm/exynos4210.c:38:#include "hw/usb/hcd-ehci.h"
hw/ppc/sam460ex.c:38:#include "hw/usb/hcd-ehci.h"
include/hw
The "framebuffer.h" header is not an exported include.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/display/artist.c | 2 +-
hw/display/next-fb.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/display/artist.c b/hw/display/artist.c
index 753dbb9a77..e1d5885fed 100644
Some 'display' patches worth salvaging while doing housekeeping.
Philippe Mathieu-Daudé (2):
hw/display: Include local 'framebuffer.h'
hw/display/edid: Add missing 'qdev-properties.h' header
include/hw/display/edid.h | 1 +
hw/display/artist.c | 2 +-
hw/display/next-fb.c | 2 +-
On Tue, Mar 17, 2020 at 12:54:25 +0100, Markus Armbruster wrote:
> This series extends QMP introspection to cover deprecation.
> Additionally, new option -compat lets you configure what to do when
> deprecated interfaces get used. This is intended for testing users of
> the management interfaces.
The vmmouse helpers are only used in hw/i386/vmmouse.c,
make them static.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i386/pc.h | 4
hw/i386/vmmouse.c| 22 +-
hw/i386/vmport.c | 23 +--
3 files changed, 22 insertions(+), 27 deletions
Remove unused "hw/input/i8042.h" include.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/i386/vmport.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/i386/vmport.c b/hw/i386/vmport.c
index 1f31e27c8a..114141c6f3 100644
--- a/hw/i386/vmport.c
+++ b/hw/i386/vmport.c
@@ -24,7 +24,6 @@
#includ
Some x86 patches worth salvaging while doing housekeeping:
Restrict vmport/vmmouse devices to x86 targets.
A step forward having "hw/i386/pc.h" target-specific...
Philippe Mathieu-Daudé (4):
hw/i386/pc: Create 'vmport' device in place
hw/i386/vmport: Remove unused 'hw/input/i8042.h' include
On 02.05.20 07:15, Markus Armbruster wrote:
> Christian Borntraeger writes:
>
>> On 29.04.20 10:54, Christian Borntraeger wrote:
>>>
>>>
>>> On 28.04.20 19:13, David Hildenbrand wrote:
On 28.04.20 18:34, Markus Armbruster wrote:
> Both s390_features[S390_FEAT_PCC_CMAC_AES_256].name an
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i386/pc.h | 6 --
hw/i386/pc.c | 2 +-
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 6ab6eda046..26e2a3d92b 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc
Move 'vmport' related declarations in a target-specific header.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/i386/vmport.h | 34 ++
include/hw/i386/pc.h | 3 ---
hw/i386/pc.c | 1 +
hw/i386/vmmouse.c| 1 +
hw/i386/vmport.c | 1 +
5 files ch
Some QOM patches worth salvaging while doing housekeeping.
Philippe Mathieu-Daudé (3):
qom/object: Move Object typedef to 'qemu/typedefs.h'
io/task: Move 'qom/object.h' header to source
qom/object: Make reparenting error more verbose
include/io/task.h | 2 --
include/qemu/typedefs.
Display child and parent names when reparenting occurs.
Signed-off-by: Philippe Mathieu-Daudé
---
qom/object.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/qom/object.c b/qom/object.c
index be700e831f..417fd90aa5 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -1683,
We use the Object type all over the place.
Forward declare it in "qemu/typedefs.h".
Signed-off-by: Philippe Mathieu-Daudé
---
include/qemu/typedefs.h | 1 +
include/qom/object.h | 2 --
include/qom/qom-qobject.h | 2 --
include/sysemu/sysemu.h | 1 -
4 files changed, 1 insertion(+), 5 d
On Mon, 4 May 2020, Philippe Mathieu-Daudé wrote:
As target-specific code use this header, move it to the publicly
accessible include/ folder.
$ git grep hw/usb/hcd-ehci.h
hw/arm/allwinner-h3.c:31:#include "hw/usb/hcd-ehci.h"
hw/arm/exynos4210.c:38:#include "hw/usb/hcd-ehci.h"
hw/ppc/sam460e
We need "qom/object.h" to call object_ref()/object_unref().
Signed-off-by: Philippe Mathieu-Daudé
---
include/io/task.h | 2 --
io/task.c | 1 +
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/io/task.h b/include/io/task.h
index 1abbfb8b65..6818dfedd0 100644
--- a/i
On 4/30/20 9:59 AM, Kevin Wolf wrote:
Am 30.04.2020 um 08:57 hat Philippe Mathieu-Daudé geschrieben:
Keep an eye on these "same same, but different" files.
Acked-by: Alex Bennée
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTA
Ping?
On 4/23/20 12:43 PM, Philippe Mathieu-Daudé wrote:
List the name of the helper targets when calling 'make help',
along with the tool targets:
$ make help
[...]
Helper targets:
fsdev/virtfs-proxy-helper - Build virtfs-proxy-helper
scsi/qemu-pr-helper- B
On 4/22/20 3:31 PM, Philippe Mathieu-Daudé wrote:
Fix trivial warnings reported by the Clang static code analyzer.
Only patch #2 'blockdev: Remove dead assignment' misses review.
Thanks to Max this series is now fully reviewed, so... ping?
The official Clang static code analyzer documentati
+block +trivial to raise the odds to get this patch merged.
On 4/22/20 6:45 PM, Keith Busch wrote:
On Tue, Apr 21, 2020 at 02:22:36PM +0200, Philippe Mathieu-Daudé wrote:
keith.bu...@intel.com address is being rejected.
Replace by the email address Keith is actively using.
Signed-off-by: Phili
Public bug reported:
BUG:
Starting FreeBSD Layer 2 bhyve Guest within Layer 1 FreeBSD VM Host on
Layer 0 Ubuntu 20.04 KVM / QEMU Host result in Layer 1 Guest / Host
Pausing with "Emulation Failure"
TESTING:
My test scenario is nested virtualisation:
Layer 0 - Ubuntu 20.04 Host
Layer 1 - FreeBSD
On Mon, Apr 27, 2020 at 01:14:33PM +0100, Dr. David Alan Gilbert wrote:
> * Denis Plotnikov (dplotni...@virtuozzo.com) wrote:
> > The patch adds ability to qemu-file to write the data
> > asynchronously to improve the performance on writing.
> > Before, only synchronous writing was supported.
> >
On Fri, 01 May 2020 16:04:41 +0200
Christian Schoenebeck wrote:
> On Donnerstag, 30. April 2020 15:30:49 CEST Greg Kurz wrote:
> > > > I agree that a client that issues concurrent readdir requests on the
> > > > same fid is probably asking for troubles, but this permitted by the
> > > > spec. Whe
On Sun, May 03, 2020 at 11:55:35AM +0300, Maxim Levitsky wrote:
> On Tue, 2020-04-28 at 14:16 +0100, Daniel P. Berrangé wrote:
> > On Sun, Mar 08, 2020 at 05:18:51PM +0200, Maxim Levitsky wrote:
> > > Next few patches will expose that functionality
> > > to the user.
> > >
> > > Signed-off-by: Max
Le 16/03/2020 à 15:28, Philippe Mathieu-Daudé a écrit :
> Michael Walle expressed his desire to orphan the lm32 target [*]:
>
> I guess it is time to pull the plug. Mainly, because I have
> no time for this anymore. I've always worked on this on my
> spare time and life changed. And secondly
On 03.05.20 18:49, Maxim Levitsky wrote:
> Commit f62514b3def5fb2acbef64d0e053c0c31fa45aff made qemu-img reject -o ""
> but this test uses it
>
> Since this test only tries to do a dry-run run of qemu-img amend, replace the
> -o "" with
> dummy -o "size=0" since due to the nature of the test, it
Le 10/03/2020 à 19:05, Wainer dos Santos Moschetta a écrit :
> Improve one error message and fix one code style warning.
>
> Wainer dos Santos Moschetta (2):
> hw/mem/pc-dimm: Print slot number on error at pc_dimm_pre_plug()
> hw/mem/pc-dimm: Fix line over 80 characters warning
>
> hw/mem/pc
On Mon, 4 May 2020 at 06:13, Michael S. Tsirkin wrote:
>
> On Tue, Apr 21, 2020 at 01:59:27PM +0100, Shameer Kolothum wrote:
> > This series adds NVDIMM support to arm/virt platform.
> > The series reuses some of the patches posted by Eric
> > in his earlier attempt here[1].
> >
> > This series pr
On Sat, May 02, 2020 at 07:06:38AM +0200, Markus Armbruster wrote:
> Eric Blake writes:
>
> > On 4/28/20 11:34 AM, Markus Armbruster wrote:
> >> Uses of gchar * in qom/object.h:
> >>
> >
> > Nice audit. I don't know if we can blindly assume that 'gchar' is a
> > (stupid) typedef to 'char', or if
On Fri, May 01, 2020 at 01:25:59PM -0400, Alexander Bulekov wrote:
> char-file already supports distinct paths for input/output but it was
> only possible to specify a distinct input through QMP. With this change,
> we can also specify a distinct input with the -chardev file argument:
> qemu -c
There are minimal differences from Qemu's point of view between the A0
and A1 silicon revisions.
As the A1 exercises different code paths in u-boot it is desirable to
emulate that instead.
Signed-off-by: Joel Stanley
---
hw/arm/aspeed.c | 8
hw/arm/aspeed_ast2600.c |
On Mon, 27 Apr 2020 at 17:00, Richard Henderson
wrote:
>
> On 4/27/20 3:48 AM, Peter Maydell wrote:
> > The old code passed size into cc->tlb_fill; the new version does not.
> > The old code passed size into page_check_range(); the new version does not.
>
> This is the user-only version, and size
On Mon, 2020-05-04 at 11:22 +0200, Max Reitz wrote:
> On 03.05.20 18:49, Maxim Levitsky wrote:
> > Commit f62514b3def5fb2acbef64d0e053c0c31fa45aff made qemu-img reject -o ""
> > but this test uses it
> >
> > Since this test only tries to do a dry-run run of qemu-img amend, replace
> > the -o ""
On Thu, 30 Apr 2020 at 17:28, Richard Henderson
wrote:
>
> With sve_cont_ldst_pages, the differences between first-fault and no-fault
> are minimal, so unify the routines. With cpu_probe_watchpoint, we are able
> to make progress through pages with TLB_WATCHPOINT set when the watchpoint
> does no
On Thu, 30 Apr 2020 at 17:28, Richard Henderson
wrote:
>
> The goal here is to support MTE, but there's some cleanup to do.
>
> Technically, we have sufficient interfaces in cputlb.c now, but it
> requires multiple tlb lookups on different interfaces to do so.
>
> Adding probe_access_flags() allow
Hi,
On 5/4/20 11:29 AM, Peter Maydell wrote:
> On Mon, 4 May 2020 at 06:13, Michael S. Tsirkin wrote:
>>
>> On Tue, Apr 21, 2020 at 01:59:27PM +0100, Shameer Kolothum wrote:
>>> This series adds NVDIMM support to arm/virt platform.
>>> The series reuses some of the patches posted by Eric
>>> in h
Le 04/05/2020 à 10:58, Philippe Mathieu-Daudé a écrit :
> +block +trivial to raise the odds to get this patch merged.
>
> On 4/22/20 6:45 PM, Keith Busch wrote:
>> On Tue, Apr 21, 2020 at 02:22:36PM +0200, Philippe Mathieu-Daudé wrote:
>>> keith.bu...@intel.com address is being rejected.
>>> Repla
On Fri, May 01, 2020 at 04:28:25PM +0100, Daniel P. Berrangé wrote:
> On Fri, May 01, 2020 at 03:01:01PM +, Felipe Franciosi wrote:
> > Hi,
> >
> > > On Apr 30, 2020, at 4:20 PM, Thanos Makatos
> > > wrote:
> > >
> > More importantly, considering:
> > a) Marc-André's comments abou
On Mon, May 04, 2020 at 10:29:18AM +0100, Peter Maydell wrote:
> On Mon, 4 May 2020 at 06:13, Michael S. Tsirkin wrote:
> >
> > On Tue, Apr 21, 2020 at 01:59:27PM +0100, Shameer Kolothum wrote:
> > > This series adds NVDIMM support to arm/virt platform.
> > > The series reuses some of the patches
Signed-off-by: Philippe Mathieu-Daudé
---
include/qemu/bitmap.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/qemu/bitmap.h b/include/qemu/bitmap.h
index 82a1d2f41f..0b390ff576 100644
--- a/include/qemu/bitmap.h
+++ b/include/qemu/bitmap.h
@@ -90,12 +90,14 @@ int slow_bitmap_inter
The most important patch of this series is 'Align block pages
queue to host page size', it start fixing an issue on PowerPC
hosts. It is not sufficient, but the rest is VFIO specific,
so I prefer to send it separately.
The other patches are documentation I was writing down while
looking at the cod
Le 23/04/2020 à 22:20, Peter Maydell a écrit :
> Calling g_mapped_file_unref() on a NULL pointer is not valid, and
> glib will assert if you try it.
>
> $ qemu-system-arm -M virt -display none -device loader,file=/tmp/bad.elf
> qemu-system-arm: -device loader,file=/tmp/bad.elf: GLib: g_mapped_file
As it is not obvious for a block neophyte what means
the 'log' value, document it.
Signed-off-by: Philippe Mathieu-Daudé
---
include/block/block.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/block/block.h b/include/block/block.h
index c57fdecf9a..94517c92b6 10
Document allocator functions that require a specific
de-allocator call.
Signed-off-by: Philippe Mathieu-Daudé
---
include/block/block.h | 4
include/qemu/osdep.h | 3 +++
include/sysemu/block-backend.h | 2 ++
3 files changed, 9 insertions(+)
diff --git a/include/block/b
In nvme_create_queue_pair() we create a page list using
qemu_blockalign(), then map it with qemu_vfio_dma_map():
q->prp_list_pages = qemu_blockalign0(bs, s->page_size * NVME_QUEUE_SIZE);
r = qemu_vfio_dma_map(s->vfio, q->prp_list_pages,
s->page_size * NVME_QUEUE_SIZE, .
The blk_read()/blk_pwrite() return value is not obvious,
document it.
Signed-off-by: Philippe Mathieu-Daudé
---
include/sysemu/block-backend.h | 24
1 file changed, 24 insertions(+)
diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h
index f2dcf
The NVMe device should not use target specific API.
Use memory_region_do_writeback() (which was introduced
in commit 61c490e25e0, after the NVMe emulated device
was added) to replace qemu_ram_writeback().
Signed-off-by: Philippe Mathieu-Daudé
---
RFC because I have no clue how dirty_log_mask work
Le 26/04/2020 à 23:09, Mikhail Gusarov a écrit :
> macOS API for dealing with serial ports/ttys is identical to BSDs.
>
> Signed-off-by: Mikhail Gusarov
> ---
>
> Note that the same file has a line
>> #endif /* linux || sun */
> that is severely out of date.
>
> chardev/char-serial.c | 2 +-
>
On Fri, May 01, 2020 at 02:25:48PM -0400, Colin Walters wrote:
> I'd like to make use of virtiofs as part of our tooling in
> https://github.com/coreos/coreos-assembler
> Most of the code runs as non-root today; qemu also runs as non-root.
> We use 9p right now.
>
> virtiofsd's builtin sandboxing
One might find interesting to look at AHCI IRQs.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/ide/ahci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 13d91e109a..fc82cbd5f1 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -1509,6 +1509,7 @@ static void
Am Mon, 4 May 2020 10:20:02 +0200
schrieb Philippe Mathieu-Daudé :
> The "framebuffer.h" header is not an exported include.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/display/artist.c | 2 +-
> hw/display/next-fb.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed
Le 03/04/2020 à 14:53, Stefan Hajnoczi a écrit :
> On Wed, Apr 01, 2020 at 10:23:14PM +0530, Simran Singhal wrote:
>> Compress two lines into a single line if immediate return statement is found.
>>
>> It also remove variables progress, val, data, ret and sock
>> as they are no longer needed.
>>
>>
As TYPE_ISA_PARALLEL inherits from TYPE_ISA_DEVICE, it also
inherits from the DEVICE methods. Convert its reset handler
into a proper DeviceReset method.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/char/parallel.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/hw/ch
On Mon, 4 May 2020 at 10:46, Michael S. Tsirkin wrote:
>
> On Mon, May 04, 2020 at 10:29:18AM +0100, Peter Maydell wrote:
> > I notice that checkpatch complains a lot about
> >
> > ERROR: Do not add expected files together with tests, follow
> > instructions in tests/qtest/bios-tables-test.c: both
On Tue, Apr 21, 2020 at 08:12:57AM -0700, no-re...@patchew.org wrote:
> Patchew URL:
> https://patchew.org/QEMU/20200421125934.14952-1-shameerali.kolothum.th...@huawei.com/
>
>
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Subje
On 30.04.20 17:21, Eric Blake wrote:
> On 4/30/20 9:55 AM, Max Reitz wrote:
>> On 21.04.20 23:20, Eric Blake wrote:
>>> Include actions for --add, --remove, --clear, --enable, --disable, and
>>> --merge (note that --clear is a bit of fluff, because the same can be
>>> accomplished by removing a bit
罗勇刚(Yonggang Luo) writes:
> On Mon, May 4, 2020 at 7:40 AM BALATON Zoltan wrote:
>
>> Hello,
>>
>> On Mon, 4 May 2020, 罗勇刚(Yonggang Luo) wrote:
>> > Hello Richard, Can you have a look at the following patch, and was that
>> are
>> > the right direction?
>>
>> Formatting of the patch is broken
Le 22/04/2020 à 15:31, Philippe Mathieu-Daudé a écrit :
> Fix trivial warnings reported by the Clang static code analyzer.
>
> Only patch #2 'blockdev: Remove dead assignment' misses review.
>
> The official Clang static code analyzer documentation is on:
> https://clang-analyzer.llvm.org/
>
> O
On Mon, 4 May 2020 at 10:57, Michael S. Tsirkin wrote:
> > ./scripts/checkpatch.pl --mailback base..
> > 2/7 Checking commit 5554e78b18ea (nvdimm: Use configurable ACPI IO base and
> > size)
> > ERROR: Do not add expected files together with tests, follow instructions
> > in tests/qtest/bios-t
The CPU() macro is defined as:
#define CPU(obj) ((CPUState *)(obj))
which expands to:
((CPUState *)object_dynamic_cast_assert((Object *)(obj), (name),
__FILE__, __LINE__, __func__))
This assertion can only fail when @obj points to something other
th
The OBJECT() macro is defined as:
#define OBJECT(obj) ((Object *)(obj))
which expands to:
((Object *)object_dynamic_cast_assert((Object *)(obj), (name),
__FILE__, __LINE__, __func__))
This assertion can only fail when @obj points to something other
th
Remove unnecessary casts using coccinelle scripts.
The CPU()/OBJECT() patches don't introduce logical change,
The DEVICE() one removes various OBJECT_CHECK() calls.
Since v2:
- Add A-b/R-b tags
- Reword description (Markus)
Philippe Mathieu-Daudé (3):
target: Remove unnecessary CPU() cast
va
The DEVICE() macro is defined as:
#define DEVICE(obj) OBJECT_CHECK(DeviceState, (obj), TYPE_DEVICE)
which expands to:
((DeviceState *)object_dynamic_cast_assert((Object *)(obj), (name),
__FILE__, __LINE__,
On 5/4/20 10:48 AM, BALATON Zoltan wrote:
On Mon, 4 May 2020, Philippe Mathieu-Daudé wrote:
As target-specific code use this header, move it to the publicly
accessible include/ folder.
$ git grep hw/usb/hcd-ehci.h
hw/arm/allwinner-h3.c:31:#include "hw/usb/hcd-ehci.h"
hw/arm/exynos4210.c:38:#
On Mon, 27 Apr 2020 at 19:16, Edgar E. Iglesias
wrote:
>
> From: "Edgar E. Iglesias"
>
> This series starts with some basic cleaning, continues with embedding
> devices into the Versal SoC (as suggested by Peter in another review).
> We then connect SD and the RTC to the Versal SoC and hook it al
has_igd_gfx_passthru is only available when QEMU is built with
CONFIG_XEN_PCI_PASSTHROUGH, and hence shouldn't be used in common
code without checking if it's available.
Fixes: 46472d82322d0 ('xen: convert "-machine igd-passthru" to an accelerator
property')
Signed-off-by: Roger Pau Monné
---
Cc
On Sun, May 03, 2020 at 09:43:10PM +0300, Maxim Levitsky wrote:
> Hi!
> Here is the updated series of my patches, incorporating all the feedback I
> received.
>
> This implements the API interface that we agreed upon except that I merged the
> LUKSKeyslotActive/LUKSKeyslotInactive union into a st
On 5/4/20 12:12 PM, Philippe Mathieu-Daudé wrote:
On 5/4/20 10:48 AM, BALATON Zoltan wrote:
On Mon, 4 May 2020, Philippe Mathieu-Daudé wrote:
As target-specific code use this header, move it to the publicly
accessible include/ folder.
$ git grep hw/usb/hcd-ehci.h
hw/arm/allwinner-h3.c:31:#in
On Montag, 4. Mai 2020 11:18:34 CEST Greg Kurz wrote:
> > > > > > +memcpy(e->dent, dent, sizeof(struct dirent));
> > > > > > +
> > > > > > +/* perform a full stat() for directory entry if requested
> > > > > > by
> > > > > > caller */ +if (dostat) {
> > > > > > +
On Fri, May 1, 2020 at 7:15 PM Alex Bennée wrote:
>
> Hopefully this will un-stick the test which has been broken for a long
> time.
>
> Signed-off-by: Alex Bennée
> ---
> .cirrus.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.cirrus.yml b/.cirrus.yml
> index 90645
On Mon, 2020-05-04 at 11:19 +0100, Daniel P. Berrangé wrote:
> On Sun, May 03, 2020 at 09:43:10PM +0300, Maxim Levitsky wrote:
> > Hi!
> > Here is the updated series of my patches, incorporating all the feedback I
> > received.
> >
> > This implements the API interface that we agreed upon except
In colo_compare_complete, insert CompareState into net_compares
only after everything has been initialized.
In colo_compare_finalize, remove CompareState from net_compares
before anything is deinitialized.
Signed-off-by: Lukas Straub
---
net/colo-compare.c | 45 +++---
qemu_bh_new will set the bh to be executed in the main
loop. This causes crashes as colo_compare_handle_event assumes
that it has exclusive access the queues, which are also
concurrently accessed in the iothread.
Create the bh with the AioContext of the iothread to fulfill
these assumptions and fi
Hello Everyone,
Here are fixes for bugs that I found in my tests.
Benchmark results:
Client-to-server tcp:
without patch: ~63 Mbit/s
with patch: ~66 Mbit/s
Server-to-client tcp:
without patch: ~771 Kbit/s
with patch: ~702 Kbit/s
Regards,
Lukas Straub
Version changes:
v4:
-fix potential deadlock
On Wed, 29 Apr 2020 03:42:01 -0400
Christian Borntraeger wrote:
> We need some little help in the code to reduce the valgrind noise.
> This patch does this with some designated initializers for the cpu
> model features and subfunctions.
>
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: C
This will be needed in the next patch.
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Reviewed-by: Zhang Chen
---
chardev/char.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/chardev/char.c b/chardev/char.c
index e77564060d..5c8014199f 100644
--- a/chard
The chr_out chardev is connected to a filter-redirector
running in the main loop. qemu_chr_fe_write_all might block
here in compare_chr_send if the (socket-)buffer is full.
If another filter-redirector in the main loop want's to
send data to chr_pri_in it might also block if the buffer
is full. Thi
Hi Roger,
On 5/4/20 12:14 PM, Roger Pau Monne wrote:
has_igd_gfx_passthru is only available when QEMU is built with
CONFIG_XEN_PCI_PASSTHROUGH, and hence shouldn't be used in common
code without checking if it's available.
Fixes: 46472d82322d0 ('xen: convert "-machine igd-passthru" to an accele
If the colo-compare object is removed before failover and a
checkpoint happens, qemu crashes because it tries to lock
the destroyed event_mtx in colo_notify_compares_event.
Fix this by checking if everything is initialized by
introducing a new variable colo_compare_active which
is protected by a n
On Thu, Apr 16, 2020 at 11:36:22PM +0300, Maxim Levitsky wrote:
> @@ -90,9 +92,13 @@ static void bus_reset_child_foreach(Object *obj,
> ResettableChildCallback cb,
> BusState *bus = BUS(obj);
> BusChild *kid;
>
> -QTAILQ_FOREACH(kid, &bus->children, sibling) {
> +rcu_read_lock(
1 - 100 of 512 matches
Mail list logo
