On 4/22/20 3:31 PM, Philippe Mathieu-Daudé wrote:
Fix trivial warnings reported by the Clang static code analyzer.
Only patch #2 'blockdev: Remove dead assignment' misses review.
Thanks to Max this series is now fully reviewed, so... ping?
The official Clang static code analyzer documentation is on:
https://clang-analyzer.llvm.org/
On Fedora I simply used it as:
$ sudo dnf install clang-analyzer
$ ../configure
$ scan-build make
Since v2:
- Based on lvivier/trivial-patches-for-5.1
- Removed dup patches from Kuhn Chenqun
Since v1:
- Addressed Markus/Zoltan/Aleksandar review comments
Philippe Mathieu-Daudé (9):
block: Avoid dead assignment
blockdev: Remove dead assignment
hw/i2c/pm_smbus: Remove dead assignment
hw/input/adb-kbd: Remove dead assignment
hw/ide/sii3112: Remove dead assignment
hw/isa/i82378: Remove dead assignment
hw/gpio/aspeed_gpio: Remove dead assignment
hw/timer/stm32f2xx_timer: Remove dead assignment
hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning
block.c | 2 +-
blockdev.c | 2 +-
hw/gpio/aspeed_gpio.c | 2 +-
hw/i2c/pm_smbus.c | 1 -
hw/ide/sii3112.c | 5 +++--
hw/input/adb-kbd.c | 6 +-----
hw/isa/i82378.c | 8 ++++----
hw/timer/pxa2xx_timer.c | 1 +
hw/timer/stm32f2xx_timer.c | 1 -
9 files changed, 12 insertions(+), 16 deletions(-)
