On Tue, Apr 21, 2020 at 08:12:57AM -0700, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20200421125934.14952-1-shameerali.kolothum.th...@huawei.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [PATCH v4 0/7] ARM virt: Add NVDIMM support > Message-id: 20200421125934.14952-1-shameerali.kolothum.th...@huawei.com > Type: series > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > ./scripts/checkpatch.pl --mailback base.. > === TEST SCRIPT END === > > Switched to a new branch 'test' > c4f3ad1 tests/acpi: add expected tables for bios-tables-test > 5b55be7 bios-tables-test: test pc-dimm and nvdimm coldplug for arm/virt > f0c9bb6 tests: Update ACPI tables list for upcoming arm/virt test changes > c2dd728 hw/arm/virt: Add nvdimm hotplug support > f7dad84 hw/arm/virt: Add nvdimm hot-plug infrastructure > 5554e78 nvdimm: Use configurable ACPI IO base and size > 8058b6f hw/acpi/nvdimm: Fix for NVDIMM incorrect DSM output buffer length > > === OUTPUT BEGIN === > 1/7 Checking commit 8058b6f6d753 (hw/acpi/nvdimm: Fix for NVDIMM incorrect > DSM output buffer length) > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and hw/acpi/nvdimm.c found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and hw/acpi/nvdimm.c found > > total: 2 errors, 0 warnings, 59 lines checked
OK so this is a false positive in the script. I will fix it. > Patch 1/7 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > 2/7 Checking commit 5554e78b18ea (nvdimm: Use configurable ACPI IO base and > size) > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and hw/acpi/nvdimm.c found This beats me. Where did we get tests/qtest/bios-tables-test-allowed-diff.h from? It's a different patch, isn't it? > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and hw/acpi/nvdimm.c found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and hw/i386/acpi-build.c found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and hw/i386/acpi-build.c found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and hw/i386/acpi-build.h found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and hw/i386/acpi-build.h found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and hw/i386/pc_piix.c found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and hw/i386/pc_piix.c found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and hw/i386/pc_q35.c found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and hw/i386/pc_q35.c found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and include/hw/mem/nvdimm.h found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and include/hw/mem/nvdimm.h found > > total: 12 errors, 0 warnings, 158 lines checked > > Patch 2/7 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > 3/7 Checking commit f7dad84068ce (hw/arm/virt: Add nvdimm hot-plug > infrastructure) > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and hw/arm/Kconfig found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and hw/arm/Kconfig found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and hw/arm/virt-acpi-build.c found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and hw/arm/virt-acpi-build.c found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and hw/arm/virt.c found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and hw/arm/virt.c found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and hw/mem/Kconfig found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and hw/mem/Kconfig found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and include/hw/arm/virt.h found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and include/hw/arm/virt.h found > > total: 10 errors, 0 warnings, 80 lines checked > > Patch 3/7 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > 4/7 Checking commit c2dd7289fec4 (hw/arm/virt: Add nvdimm hotplug support) > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and > docs/specs/acpi_hw_reduced_hotplug.rst found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and > docs/specs/acpi_hw_reduced_hotplug.rst found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and > hw/acpi/generic_event_device.c found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and > hw/acpi/generic_event_device.c found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and hw/arm/virt.c found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and hw/arm/virt.c found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and > include/hw/acpi/generic_event_device.h found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and > include/hw/acpi/generic_event_device.h found > > total: 8 errors, 0 warnings, 103 lines checked > > Patch 4/7 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > 5/7 Checking commit f0c9bb65828f (tests: Update ACPI tables list for upcoming > arm/virt test changes) > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both tests/data/acpi/virt/NFIT.memhp and > include/hw/acpi/generic_event_device.h found > > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #17: > new file mode 100644 > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both tests/data/acpi/virt/SSDT.memhp and > include/hw/acpi/generic_event_device.h found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and > include/hw/acpi/generic_event_device.h found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and > include/hw/acpi/generic_event_device.h found > > total: 4 errors, 1 warnings, 6 lines checked > > Patch 5/7 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > 6/7 Checking commit 5b55be7a85b5 (bios-tables-test: test pc-dimm and nvdimm > coldplug for arm/virt) > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and > tests/qtest/bios-tables-test.c found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and > tests/qtest/bios-tables-test.c found > > total: 2 errors, 0 warnings, 19 lines checked > > Patch 6/7 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > 7/7 Checking commit c4f3ad1b593c (tests/acpi: add expected tables for > bios-tables-test) > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both tests/data/acpi/pc/SSDT.dimmpxm and > tests/qtest/bios-tables-test.c found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/SSDT.dimmpxm and > tests/qtest/bios-tables-test.c found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both tests/data/acpi/virt/DSDT.memhp and > tests/qtest/bios-tables-test.c found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both tests/data/acpi/virt/NFIT.memhp and > tests/qtest/bios-tables-test.c found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both tests/data/acpi/virt/SSDT.memhp and > tests/qtest/bios-tables-test.c found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and > tests/qtest/bios-tables-test.c found > > ERROR: Do not add expected files together with tests, follow instructions in > tests/qtest/bios-tables-test.c: both > tests/qtest/bios-tables-test-allowed-diff.h and > tests/qtest/bios-tables-test.c found > > total: 7 errors, 0 warnings, 1 lines checked > > Patch 7/7 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > === OUTPUT END === > > Test command exited with code: 1 > > > The full log is available at > http://patchew.org/logs/20200421125934.14952-1-shameerali.kolothum.th...@huawei.com/testing.checkpatch/?type=message. > --- > Email generated automatically by Patchew [https://patchew.org/]. > Please send your feedback to patchew-de...@redhat.com
