RE: [PATCH 0/2] net/colo-compare.c: Expose more COLO internal

2020-03-18 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Wednesday, March 18, 2020 10:48 AM > To: Zhang, Chen ; qemu-dev de...@nongnu.org> > Cc: Daniel Cho ; Dr . David Alan Gilbert > ; Zhang Chen > Subject: Re: [PATCH 0/2] net/colo-compare.c: Expose more COLO internal > > > On 2020/3/17 下午4:

[PATCH] hmp-cmd: fix a missing_break warning

2020-03-18 Thread Pan Nengyuan
This fix coverity issues 94417686: 1260break; CID 94417686: (MISSING_BREAK) 1261. unterminated_case: The case for value "MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD" is not terminated by a 'break' statement. 1261case MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD:

Re: [PATCH] hmp-cmd: fix a missing_break warning

2020-03-18 Thread Pan Nengyuan
Correcting zhang hailiang's email. On 3/18/2020 3:16 PM, Pan Nengyuan wrote: > This fix coverity issues 94417686: > 1260break; > CID 94417686: (MISSING_BREAK) > 1261. unterminated_case: The case for value > "MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD" is not terminated by

[PATCH v2] ppc/spapr: Set the effective address provided flag in mc error log.

2020-03-18 Thread Mahesh Salgaonkar
Per PAPR, it is expected to set effective address provided flag in sub_err_type member of mc extended error log (i.e rtas_event_log_v6_mc.sub_err_type). This somehow got missed in original fwnmi-mce patch series. The current code just updates the effective address but does not set the flag to indic

Re: [PULL 0/4] Python queue for 5.0 soft freeze

2020-03-18 Thread Vladimir Sementsov-Ogievskiy
18.03.2020 7:12, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200318011217.2102748-1-ehabk...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 0/4] Python queue for 5.0 soft freeze Message-id:

Re: [PULL 07/13] cpu: Use DeviceClass reset instead of a special CPUClass reset

2020-03-18 Thread Philippe Mathieu-Daudé
On 3/18/20 2:17 AM, Eduardo Habkost wrote: From: Peter Maydell The CPUClass has a 'reset' method. This is a legacy from when TYPE_CPU used not to inherit from TYPE_DEVICE. We don't need it any more, as we can simply use the TYPE_DEVICE reset. The 'cpu_reset()' function is kept as the API whi

Re: [PATCH 3/4] tests/migration: Disable autoconverge test on Travis-CI s390x

2020-03-18 Thread Philippe Mathieu-Daudé
On 3/17/20 9:26 PM, Dr. David Alan Gilbert wrote: * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: This test fails on Travis-CI s390x when configured with --disable-tcg: $ make check-qtest TESTcheck-qtest-s390x: tests/qtest/boot-serial-test qemu-system-s390x: -accel tcg: inval

Re: [PATCH 0/3] Fix Skylake, Cascadelake and Icelake Server CPU models

2020-03-18 Thread Chenyi Qiang
Ping. On 2/27/2020 5:08 PM, Chenyi Qiang wrote: Current Skylake-Server, Cascadelake-Server and Icelake-Server CPU models lack several VMX features. Icelake-Server also lacks two features in FEAT_7_0_EBX. In addition, The model numbers of Icelake-Client and Icelake-Server need to be fixed. Cheny

Re: [PATCH] hmp-cmd: fix a missing_break warning

2020-03-18 Thread zhukeqian
Hi Nengyuan, On 2020/3/18 15:22, Pan Nengyuan wrote: > Correcting zhang hailiang's email. > > On 3/18/2020 3:16 PM, Pan Nengyuan wrote: >> This fix coverity issues 94417686: >> 1260break; >> CID 94417686: (MISSING_BREAK) >> 1261. unterminated_case: The case for value >> "MIGR

Re: Missing Null check

2020-03-18 Thread Philippe Mathieu-Daudé
On 3/17/20 9:40 PM, Mansour Ahmadi wrote: Is a NULL check on 'drv1->format_name' missing here? https://github.com/qemu/qemu/blob/cc818a2148c5f321bdeb8e5564bdb2914e824600/block.c#L400-L403 if(!strcmp(drv1->format_name, format_name)) { This could be NULL indeed. I'd rather assertions in the entr

Re: [PULL 00/13] target: Add the Renesas RX architecture

2020-03-18 Thread Philippe Mathieu-Daudé
Hi Peter, On 3/17/20 5:36 PM, Philippe Mathieu-Daudé wrote: This pull request adds the architectural part of the Renesas RX architecture. Richard Henderson temporarily handed it over for the 5.0 release. The following changes since commit a98135f727595382e200d04c2996e868b7925a01: Merge rem

Re: [PATCH v2 0/9] user-mode: Prune build dependencies (part 3)

2020-03-18 Thread Philippe Mathieu-Daudé
Hi Eduardo, On 3/16/20 1:11 AM, Philippe Mathieu-Daudé wrote: This is the second part of a series reducing user-mode dependencies. By stripping out unused code, the build and testing time is reduced (as is space used by objects). Part 3: - Extract code not related to user-mode from hw/core/qdev

Re: [PATCH v2 1/8] target/i386: Restrict X86CPUFeatureWord to X86 targets

2020-03-18 Thread Philippe Mathieu-Daudé
Hi Eduardo, On 3/16/20 1:03 AM, Philippe Mathieu-Daudé wrote: Move out x86-specific structures from generic machine code. If you have to respin "x86 and machine queue" please consider including this patch :) Acked-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- qapi/ma

[PATCH v2 0/2] net/colo-compare.c: Expose COLO-compare parameters to users

2020-03-18 Thread Zhang Chen
From: Zhang Chen Make a way to config COLO "compare_timeout" and "expired_scan_cycle" parameters according to user's scenarios and environments. V2: - Rebased on upstream. - Fixed typos. Zhang Chen (2): net/colo-compare.c: Expose "compare_timeout" to users net/colo-compare.c: Expose "expi

[PATCH v2 1/2] net/colo-compare.c: Expose "compare_timeout" to users

2020-03-18 Thread Zhang Chen
From: Zhang Chen The "compare_timeout" determines the maximum time to hold the primary net packet. This patch expose the "compare_timeout", make user have ability to adjest the value according to application scenarios. QMP command demo: { "execute": "qom-get", "arguments": { "path"

[PATCH v2 2/2] net/colo-compare.c: Expose "expired_scan_cycle" to users

2020-03-18 Thread Zhang Chen
From: Zhang Chen The "expired_scan_cycle" determines period of scanning expired primary node net packets. Signed-off-by: Zhang Chen --- net/colo-compare.c | 48 +++--- qemu-options.hx| 4 +++- 2 files changed, 48 insertions(+), 4 deletions(-) diff

Re: [PATCH v9 14/15] docs: Add protvirt docs

2020-03-18 Thread Janosch Frank
On 3/17/20 7:23 PM, Cornelia Huck wrote: > On Fri, 13 Mar 2020 13:28:56 + > Peter Maydell wrote: > >> On Wed, 11 Mar 2020 at 13:31, Janosch Frank wrote: >>> >>> Lets add some documentation for the Protected VM functionality. >>> >>> Signed-off-by: Janosch Frank >>> --- >>> docs/system/inde

Re: [PATCH v9 15/15] s390x: Add unpack facility feature to GA1

2020-03-18 Thread Janosch Frank
On 3/17/20 7:06 PM, Cornelia Huck wrote: > On Wed, 11 Mar 2020 09:21:51 -0400 > Janosch Frank wrote: > >> From: Christian Borntraeger >> >> The unpack facility is an indication that diagnose 308 subcodes 8-10 >> are available to the guest. That means, that the guest can put itself >> into protec

Re: [PATCH v2 0/2] net/colo-compare.c: Expose COLO-compare parameters to users

2020-03-18 Thread Jason Wang
On 2020/3/18 下午4:23, Zhang Chen wrote: From: Zhang Chen Make a way to config COLO "compare_timeout" and "expired_scan_cycle" parameters according to user's scenarios and environments. V2: - Rebased on upstream. - Fixed typos. Zhang Chen (2): net/colo-compare.c: Expose "compare_timeou

[PATCH v5 2/7] virtio-net: implement RSS configuration command

2020-03-18 Thread Yuri Benditovich
Optionally report RSS feature. Handle RSS configuration command and keep RSS parameters in virtio-net device context. Signed-off-by: Yuri Benditovich --- hw/net/trace-events| 3 + hw/net/virtio-net.c| 189 + include/hw/virtio/virtio-net.h

[PATCH v5 1/7] virtio-net: introduce RSS and hash report features

2020-03-18 Thread Yuri Benditovich
Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c | 65 + 1 file changed, 65 insertions(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 3627bb1717..90b01221e9 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -71,6 +71

[PATCH v5 0/7] reference implementation of RSS and hash report

2020-03-18 Thread Yuri Benditovich
Support for VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT features in QEMU for reference purpose. Implements Toeplitz hash calculation for incoming packets according to configuration provided by driver. Uses calculated hash for decision on receive virtqueue and/or reports the hash in the virtio hea

[PATCH v5 4/7] tap: allow extended virtio header with hash info

2020-03-18 Thread Yuri Benditovich
Signed-off-by: Yuri Benditovich --- net/tap.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/net/tap.c b/net/tap.c index 6207f61f84..47de7fdeb6 100644 --- a/net/tap.c +++ b/net/tap.c @@ -63,6 +63,14 @@ typedef struct TAPState { Notifier exit; } TAPState; +

[PATCH v5 3/7] virtio-net: implement RX RSS processing

2020-03-18 Thread Yuri Benditovich
If VIRTIO_NET_F_RSS negotiated and RSS is enabled, process incoming packets, calculate packet's hash and place the packet into respective RX virtqueue. Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c| 88 +- include/hw/virtio/virtio-net.h | 1

[PATCH v5 6/7] vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro

2020-03-18 Thread Yuri Benditovich
Similar to VMSTATE_VARRAY_UINT32_ALLOC, but the size is 16-bit field. Signed-off-by: Yuri Benditovich --- include/migration/vmstate.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 30667631bc..baaefb6b9b 100644 ---

[PATCH v5 5/7] virtio-net: reference implementation of hash report

2020-03-18 Thread Yuri Benditovich
Suggest VIRTIO_NET_F_HASH_REPORT if specified in device parameters. If the VIRTIO_NET_F_HASH_REPORT is set, the device extends configuration space. If the feature is negotiated, the packet layout is extended to accomodate the hash information. In this case deliver packet's hash value and report typ

[PATCH v5 7/7] virtio-net: add migration support for RSS and hash report

2020-03-18 Thread Yuri Benditovich
Save and restore RSS/hash report configuration. Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index a0614ad4e6..0b058aae9f 100644 --- a/hw/net/virtio-net.c +++ b/hw

Re: [PATCH] pci: Display PCI IRQ pin in "info pci"

2020-03-18 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Tue, Mar 17, 2020 at 08:21:17PM +, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > Sometimes it would be good to be able to read the pin number along > > > with the IRQ number allocated. Since we'll dump the IRQ number, n

Re: [PATCH v9 15/15] s390x: Add unpack facility feature to GA1

2020-03-18 Thread Cornelia Huck
On Wed, 18 Mar 2020 09:44:08 +0100 Janosch Frank wrote: > On 3/17/20 7:06 PM, Cornelia Huck wrote: > > On Wed, 11 Mar 2020 09:21:51 -0400 > > Janosch Frank wrote: > >> diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c > >> index ff6027036ec2f14a..e11e895a3d9038bb 100644 > >> --- a/target/s39

[PATCH for-5.0] compat: disable edid on correct virtio-gpu device

2020-03-18 Thread Cornelia Huck
Commit bb15791166c1 ("compat: disable edid on virtio-gpu base device") tried to disable 'edid' on the virtio-gpu base device. However, that device is not 'virtio-gpu', but 'virtio-gpu-device'. Fix it. Fixes: bb15791166c1 ("compat: disable edid on virtio-gpu base device") Reported-by: Lukáš Doktor

Re: [PATCH v9 15/15] s390x: Add unpack facility feature to GA1

2020-03-18 Thread Janosch Frank
On 3/18/20 10:27 AM, Cornelia Huck wrote: > What about > > /* > * If we have support for protected virtualization, indicate > * the protected virtualization IPL unpack facility. > */ > Sure signature.asc Description: OpenPGP digital signature

Re: [PATCH v5 0/7] reference implementation of RSS and hash report

2020-03-18 Thread Michael S. Tsirkin
On Wed, Mar 18, 2020 at 11:15:18AM +0200, Yuri Benditovich wrote: > Support for VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT > features in QEMU for reference purpose. > Implements Toeplitz hash calculation for incoming > packets according to configuration provided by driver. > Uses calculated hash

Re: [PATCH v5 6/7] vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro

2020-03-18 Thread Michael S. Tsirkin
On Wed, Mar 18, 2020 at 11:15:24AM +0200, Yuri Benditovich wrote: > Similar to VMSTATE_VARRAY_UINT32_ALLOC, but the size is > 16-bit field. > > Signed-off-by: Yuri Benditovich Hmm this is exactly my patch isn't it? If yes pls fix up attribution (if this is not reposted, then when applying): Fro

Re: [PATCH 1/4] tests/test-util-filemonitor: Fix Travis-CI $ARCH env variable name

2020-03-18 Thread Daniel P . Berrangé
On Tue, Mar 17, 2020 at 09:05:38PM +0100, Philippe Mathieu-Daudé wrote: > While we can find reference of a 'TRAVIS_ARCH' variable in > the environment and source [1], per the Travis-CI multi-arch > documentation [2] the variable is named TRAVIS_CPU_ARCH. > > [1] > https://github.com/travis-ci/tra

Re: [PATCH 2/4] tests/test-util-sockets: Skip test on non-x86 Travis containers

2020-03-18 Thread Daniel P . Berrangé
On Tue, Mar 17, 2020 at 09:05:39PM +0100, Philippe Mathieu-Daudé wrote: > Similarly to commit 4f370b1098, test-util-sockets fails in > restricted non-x86 Travis containers since they apparently > blacklisted some required system calls there. > Let's simply skip the test if we detect such an environ

Re: [PATCH v5 0/7] reference implementation of RSS and hash report

2020-03-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200318091525.27044-1-yuri.benditov...@daynix.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/

Qemu API documentation

2020-03-18 Thread Priyamvad Acharya
Hello developer community, I am working on implementing a custom device in Qemu, so to implement it I need documentation of functions which are used to emulate a hardware model in Qemu. What are the references to get it ? Thanks, Priyamvad

[PATCH v8 0/8] virtio-iommu: VFIO integration

2020-03-18 Thread Bharat Bhushan
This patch series integrates VFIO with virtio-iommu. This is only applicable for PCI pass-through with virtio-iommu. This series is available at: https://github.com/bharat-bhushan-devel/qemu.git virtio-iommu-vfio-integration-v8 This is tested with assigning more than one pci devices to Virtual M

[PATCH v8 1/8] hw/vfio/common: Remove error print on mmio region translation by viommu

2020-03-18 Thread Bharat Bhushan
On ARM, the MSI doorbell is translated by the virtual IOMMU. As such address_space_translate() returns the MSI controller MMIO region and we get an "iommu map to non memory area" message. Let's remove this latter. Signed-off-by: Eric Auger Signed-off-by: Bharat Bhushan --- hw/vfio/common.c | 2

[PATCH v8 4/8] virtio-iommu: set supported page size mask

2020-03-18 Thread Bharat Bhushan
Add optional interface to set page size mask. Currently this is set global configuration and not per endpoint. Signed-off-by: Bharat Bhushan --- v7->v8: - new patch hw/virtio/virtio-iommu.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/vir

[PATCH v8 2/8] memory: Add interface to set iommu page size mask

2020-03-18 Thread Bharat Bhushan
Allow to set page size mask to be supported by iommu. This is required to expose page size mask compatible with host with virtio-iommu. Signed-off-by: Bharat Bhushan --- v7->v8: - new patch include/exec/memory.h | 20 memory.c | 10 ++ 2 files changed,

[PATCH v8 3/8] vfio: set iommu page size as per host supported page size

2020-03-18 Thread Bharat Bhushan
Set iommu supported page size mask same as host Linux supported page size mask. Signed-off-by: Bharat Bhushan --- v7->v8: - new patch hw/vfio/common.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index c586edf47a..6ea50d696f 100644 --- a/hw/vfio/co

[PATCH v8 5/8] virtio-iommu: Add iommu notifier for map/unmap

2020-03-18 Thread Bharat Bhushan
This patch extends VIRTIO_IOMMU_T_MAP/UNMAP request to notify registered iommu-notifier. Which will call vfio notifier to map/unmap region in iommu. Signed-off-by: Bharat Bhushan Signed-off-by: Eric Auger --- include/hw/virtio/virtio-iommu.h | 2 + hw/virtio/virtio-iommu.c | 67 +++

[PATCH v8 7/8] virtio-iommu: add iommu replay

2020-03-18 Thread Bharat Bhushan
Default replay does not work with virtio-iommu, so this patch provide virtio-iommu replay functionality. Signed-off-by: Bharat Bhushan --- hw/virtio/virtio-iommu.c | 44 hw/virtio/trace-events | 1 + 2 files changed, 45 insertions(+) diff --git a/hw/v

Re: [PATCH 3/4] tests/migration: Disable autoconverge test on Travis-CI s390x

2020-03-18 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > On 3/17/20 9:26 PM, Dr. David Alan Gilbert wrote: > > * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > > > This test fails on Travis-CI s390x when configured with --disable-tcg: > > > > > >$ make check-qtest > > > TESTcheck-qt

[PATCH v8 6/8] virtio-iommu: Call iommu notifier for attach/detach

2020-03-18 Thread Bharat Bhushan
iommu-notifier are called when a device is attached or detached to as address-space. This is needed for VFIO. Signed-off-by: Bharat Bhushan --- hw/virtio/virtio-iommu.c | 49 1 file changed, 49 insertions(+) diff --git a/hw/virtio/virtio-iommu.c b/hw/vir

[PATCH v8 8/8] virtio-iommu: add iommu notifier memory-region

2020-03-18 Thread Bharat Bhushan
Finally add notify_flag_changed() to for memory-region access flag iommu flag change notifier Finally add the memory notifier Signed-off-by: Bharat Bhushan --- hw/virtio/virtio-iommu.c | 22 ++ hw/virtio/trace-events | 2 ++ 2 files changed, 24 insertions(+) diff --git a

Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-18 Thread Bharat Bhushan
Hi Jean, On Tue, Mar 17, 2020 at 9:29 PM Jean-Philippe Brucker wrote: > > On Tue, Mar 17, 2020 at 02:46:55PM +0530, Bharat Bhushan wrote: > > Hi Jean, > > > > On Tue, Mar 17, 2020 at 2:23 PM Jean-Philippe Brucker > > wrote: > > > > > > On Tue, Mar 17, 2020 at 12:40:39PM +0530, Bharat Bhushan wro

Re: [PATCH 09/11] target/mips: Always enable CONFIG_SEMIHOSTING

2020-03-18 Thread Paolo Bonzini
On 16/03/20 13:00, Philippe Mathieu-Daudé wrote: > diff --git a/default-configs/mips-linux-user-common.mak > b/default-configs/mips-linux-user-common.mak > new file mode 100644 > index 00..04947706e8 > --- /dev/null > +++ b/default-configs/mips-linux-user-common.mak > @@ -0,0 +1,4 @@ > +#

[PATCH] Documentation: create/move s390x documentation

2020-03-18 Thread Cornelia Huck
Create a subdirectory for s390x under docs/system/ and move the existing vfio-ap documentation there. Create an initial document describing s390x system emulation. Suggested-by: Peter Maydell Signed-off-by: Cornelia Huck --- Mostly an initial version so that Janosch can base his protected virt

Re: [PATCH v4 28/34] qapi: Implement deprecated-output=hide for QMP command results

2020-03-18 Thread Eric Blake
On 3/17/20 6:54 AM, Markus Armbruster wrote: This policy suppresses deprecated bits in output, and thus permits "testing the future". Implement it for QMP command results. Example: when QEMU is run with -compat deprecated-output=hide, then {"execute": "query-cpus-fast"} yields {"re

Re: [PATCH v2] MAINTAINERS: Add an entry for the HVF accelerator

2020-03-18 Thread Paolo Bonzini
On 16/03/20 18:18, Roman Bolshakov wrote: > Cc: Nikita Leshenko > Cc: Sergio Andres Gomez Del Real > Cc: Patrick Colp > Cc: Cameron Esfahani > Cc: Liran Alon > Cc: Heiher > > Signed-off-by: Roman Bolshakov > --- > > Changes since v1: > Status is changed to Maintained instead of Supported

Re: [PATCH] kvm: support to get/set dirty log initial-all-set capability

2020-03-18 Thread Paolo Bonzini
On 04/03/20 03:55, Jay Zhou wrote: > Since the new capability KVM_DIRTY_LOG_INITIALLY_SET of > KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2 has been introduced in the > kernel, tweak the userspace side to detect and enable this > capability. > > Signed-off-by: Jay Zhou > --- > accel/kvm/kvm-all.c | 2

Re: [PATCH v7 00/13] APIC ID fixes for AMD EPYC CPU model

2020-03-18 Thread Igor Mammedov
On Wed, 18 Mar 2020 02:43:57 + "Moger, Babu" wrote: > [AMD Official Use Only - Internal Distribution Only] > > > > > -Original Message- > > From: Eduardo Habkost > > Sent: Tuesday, March 17, 2020 6:46 PM > > To: Moger, Babu > > Cc: marcel.apfelb...@gmail.com; pbonz...@redhat.com;

Re: [PATCH v5 7/7] virtio-net: add migration support for RSS and hash report

2020-03-18 Thread Dr. David Alan Gilbert
* Yuri Benditovich (yuri.benditov...@daynix.com) wrote: > Save and restore RSS/hash report configuration. > > Signed-off-by: Yuri Benditovich > --- > hw/net/virtio-net.c | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.

Re: [PATCH v8 0/8] virtio-iommu: VFIO integration

2020-03-18 Thread Auger Eric
Hi Bharat On 3/18/20 11:11 AM, Bharat Bhushan wrote: > This patch series integrates VFIO with virtio-iommu. > This is only applicable for PCI pass-through with virtio-iommu. > > This series is available at: > https://github.com/bharat-bhushan-devel/qemu.git > virtio-iommu-vfio-integration-v8 >

Re: [PATCH v5 6/7] vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro

2020-03-18 Thread Dr. David Alan Gilbert
* Yuri Benditovich (yuri.benditov...@daynix.com) wrote: > Similar to VMSTATE_VARRAY_UINT32_ALLOC, but the size is > 16-bit field. > > Signed-off-by: Yuri Benditovich > --- > include/migration/vmstate.h | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/include/migration/vmstat

Re: Qemu API documentation

2020-03-18 Thread Peter Maydell
On Wed, 18 Mar 2020 at 09:55, Priyamvad Acharya wrote: > > Hello developer community, > > I am working on implementing a custom device in Qemu, so to implement it I > need documentation of functions which are used to emulate a hardware model in > Qemu. > > What are the references to get it ? QE

Re: [PATCH] Documentation: create/move s390x documentation

2020-03-18 Thread Peter Maydell
On Wed, 18 Mar 2020 at 10:39, Cornelia Huck wrote: > > Create a subdirectory for s390x under docs/system/ and move the > existing vfio-ap documentation there. > > Create an initial document describing s390x system emulation. > > Suggested-by: Peter Maydell > Signed-off-by: Cornelia Huck > --- >

Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-18 Thread Jean-Philippe Brucker
On Wed, Mar 18, 2020 at 03:47:44PM +0530, Bharat Bhushan wrote: > Hi Jean, > > On Tue, Mar 17, 2020 at 9:29 PM Jean-Philippe Brucker > wrote: > > > > On Tue, Mar 17, 2020 at 02:46:55PM +0530, Bharat Bhushan wrote: > > > Hi Jean, > > > > > > On Tue, Mar 17, 2020 at 2:23 PM Jean-Philippe Brucker >

Re: [PATCH] build: Silence clang warning on older glib autoptr usage

2020-03-18 Thread Eric Blake
On 3/17/20 1:11 PM, Peter Maydell wrote: On Tue, 17 Mar 2020 at 17:55, Eric Blake wrote: glib's G_DEFINE_AUTOPTR_CLEANUP_FUNC() macro defines several static inline functions, often with some of them unused, but prior to 2.57.2 did not mark the functions as such. As a result, clang (but not gc

RE: [EXT] Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-18 Thread Bharat Bhushan
> -Original Message- > From: Jean-Philippe Brucker > Sent: Wednesday, March 18, 2020 4:48 PM > To: Bharat Bhushan > Cc: Auger Eric ; Peter Maydell > ; kevin.t...@intel.com; Tomasz Nowicki [C] > ; m...@redhat.com; drjo...@redhat.com; > pet...@redhat.com; qemu-devel@nongnu.org; alex.will

Re: [PATCH v4 01/30] qcow2: Make Qcow2AioTask store the full host offset

2020-03-18 Thread Eric Blake
On 3/17/20 1:15 PM, Alberto Garcia wrote: The file_cluster_offset field of Qcow2AioTask stores a cluster-aligned host offset. In practice this is not very useful because all users(*) of this structure need the final host offset into the cluster, which they calculate using host_offset = file_

Re: [PATCH v9 14/15] docs: Add protvirt docs

2020-03-18 Thread Cornelia Huck
On Wed, 11 Mar 2020 09:21:50 -0400 Janosch Frank wrote: > Lets add some documentation for the Protected VM functionality. s/Lets/Let's/ :) > > Signed-off-by: Janosch Frank > --- > docs/system/index.rst| 1 + > docs/system/protvirt.rst | 56 > 2 f

Re: [PATCH] Documentation: create/move s390x documentation

2020-03-18 Thread Cornelia Huck
On Wed, 18 Mar 2020 11:12:11 + Peter Maydell wrote: > On Wed, 18 Mar 2020 at 10:39, Cornelia Huck wrote: > > > > Create a subdirectory for s390x under docs/system/ and move the > > existing vfio-ap documentation there. > > > > Create an initial document describing s390x system emulation. > >

Re: [PATCH v8 4/8] virtio-iommu: set supported page size mask

2020-03-18 Thread Auger Eric
Hi Bharat, On 3/18/20 11:11 AM, Bharat Bhushan wrote: > Add optional interface to set page size mask. > Currently this is set global configuration and not > per endpoint. > > Signed-off-by: Bharat Bhushan > --- > v7->v8: > - new patch > > hw/virtio/virtio-iommu.c | 10 ++ > 1 file cha

Re: [PATCH] hmp-cmd: fix a missing_break warning

2020-03-18 Thread Dr. David Alan Gilbert
* Pan Nengyuan (pannengy...@huawei.com) wrote: > This fix coverity issues 94417686: > 1260break; > CID 94417686: (MISSING_BREAK) > 1261. unterminated_case: The case for value > "MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD" is not terminated by a > 'break' statement. > 1

[Bug 1867519] Re: libvirt 6.0 : virtual machine stuck when detaching PCI device using virsh command

2020-03-18 Thread Christian Ehrhardt 
I re-run the above, full PCI passthrough still attaches/detaches fine. VFs attach fine VFs break on detach I've thrown qemu into GDB and this is the backtrace Thread 4 "CPU 0/KVM" received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7f82f0e31700 (LWP 3998)] 0x55d2f322d45d in no

[Bug 1867519] Re: qemu 4.2 segfaults on VF detach

2020-03-18 Thread Christian Ehrhardt 
I changed the bug task to Qemu (Ubuntu) as this isn't a libvirt error. I also added an upstream qemu task in case this is a known issue for the developers there. Someone might be able to point us at a known discussion/fix. The Backtrace I added in the last comment should help to identify known ca

Re: [PATCH] hmp-cmd: fix a missing_break warning

2020-03-18 Thread Philippe Mathieu-Daudé
On 3/18/20 8:16 AM, Pan Nengyuan wrote: This fix coverity issues 94417686: 1260break; CID 94417686: (MISSING_BREAK) 1261. unterminated_case: The case for value "MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD" is not terminated by a 'break' statement. 1261case MIG

[Bug 1867519] Re: qemu 4.2 segfaults on VF detach

2020-03-18 Thread Mohammad Heib
Hi Christian, yes that exactly what we see in our tests, so are the logs that you asked for in comment#1 still needed? also if you fix it can you please provide us a link for a package or even a workaround until the issue resolved, since this issue stuck our QA from testing ASAP over Focal. --

Re: [PATCH v9 04/15] s390x: protvirt: Inhibit balloon when switching to protected mode

2020-03-18 Thread Cornelia Huck
On Wed, 11 Mar 2020 09:21:40 -0400 Janosch Frank wrote: > Ballooning in protected VMs can only be done when the guest shares the > pages it gives to the host. If pages are not shared, the integrity > checks will fail once those pages have been altered and are given back > to the guest. > > As we

Re: [EXT] Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-18 Thread Auger Eric
Hi Jean, On 3/18/20 12:20 PM, Bharat Bhushan wrote: > > >> -Original Message- >> From: Jean-Philippe Brucker >> Sent: Wednesday, March 18, 2020 4:48 PM >> To: Bharat Bhushan >> Cc: Auger Eric ; Peter Maydell >> ; kevin.t...@intel.com; Tomasz Nowicki [C] >> ; m...@redhat.com; drjo...@re

[Bug 1867519] Re: qemu 4.2 segfaults on VF detach

2020-03-18 Thread Christian Ehrhardt 
At the breaking function we have: 29 void notifier_remove(Notifier *notifier) 30 { 31 QLIST_REMOVE(notifier, node); 32 } (gdb) p notifier $1 = (Notifier *) 0x55d2f40c5078 (gdb) p *notifier $2 = {notify = 0x0, node = {le_next = 0x0, le_prev = 0x0}} And since QLIST_REMOVE

[Bug 1867519] Re: qemu 4.2 segfaults on VF detach

2020-03-18 Thread Christian Ehrhardt 
Might be https://git.qemu.org/?p=qemu.git;a=commit;h=0446f8121723b134ca1d1ed0b73e96d4a0a8689d This would also match the backtrace path. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed t

[Bug 1867519] Re: qemu 4.2 segfaults on VF detach

2020-03-18 Thread Daniel Berrange
That commit you mention is confirmed to solve a bug reported against Fedora with almost the same stack trace you see here. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1867519 Title: qemu 4.2 segf

Re: [EXT] Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-18 Thread Jean-Philippe Brucker
On Wed, Mar 18, 2020 at 12:42:25PM +0100, Auger Eric wrote: > Hi Jean, > > On 3/18/20 12:20 PM, Bharat Bhushan wrote: > > > > > >> -Original Message- > >> From: Jean-Philippe Brucker > >> Sent: Wednesday, March 18, 2020 4:48 PM > >> To: Bharat Bhushan > >> Cc: Auger Eric ; Peter Maydel

Re: [PATCH v4 02/30] qcow2: Convert qcow2_get_cluster_offset() into qcow2_get_host_offset()

2020-03-18 Thread Eric Blake
On 3/17/20 1:15 PM, Alberto Garcia wrote: qcow2_get_cluster_offset() takes an (unaligned) guest offset and returns the (aligned) offset of the corresponding cluster in the qcow2 image. In practice none of the callers need to know where the cluster starts so this patch makes the function calculat

Re: [PATCH v13 Kernel 4/7] vfio iommu: Implementation of ioctl to for dirty pages tracking.

2020-03-18 Thread Dr. David Alan Gilbert
* Kirti Wankhede (kwankh...@nvidia.com) wrote: > VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: > - Start pinned and unpinned pages tracking while migration is active > - Stop pinned and unpinned dirty pages tracking. This is also used to > stop dirty pages tracking if migration failed o

Re: [PATCH] Documentation: create/move s390x documentation

2020-03-18 Thread Christian Borntraeger
On 18.03.20 11:39, Cornelia Huck wrote: > Create a subdirectory for s390x under docs/system/ and move the > existing vfio-ap documentation there. > > Create an initial document describing s390x system emulation. > > Suggested-by: Peter Maydell > Signed-off-by: Cornelia Huck > --- > > Mostly

Re: [PATCH v4 29/34] qapi: Implement deprecated-output=hide for QMP events

2020-03-18 Thread Eric Blake
On 3/17/20 6:54 AM, Markus Armbruster wrote: This policy suppresses deprecated bits in output, and thus permits "testing the future". Implement it for QMP events: suppress deprecated ones. No QMP event is deprecated right now. Signed-off-by: Markus Armbruster --- @@ -140,6 +141,23 @@ stati

Re: [PATCH v9 04/15] s390x: protvirt: Inhibit balloon when switching to protected mode

2020-03-18 Thread Janosch Frank
On 3/18/20 12:42 PM, Cornelia Huck wrote: > On Wed, 11 Mar 2020 09:21:40 -0400 > Janosch Frank wrote: > >> Ballooning in protected VMs can only be done when the guest shares the >> pages it gives to the host. If pages are not shared, the integrity >> checks will fail once those pages have been al

Re: [PATCH v9 14/15] docs: Add protvirt docs

2020-03-18 Thread Janosch Frank
On 3/18/20 12:25 PM, Cornelia Huck wrote: > On Wed, 11 Mar 2020 09:21:50 -0400 > Janosch Frank wrote: > >> Lets add some documentation for the Protected VM functionality. > > s/Lets/Let's/ :) > >> >> Signed-off-by: Janosch Frank >> --- >> docs/system/index.rst| 1 + >> docs/system/protvi

[RFC v1] arm/virt: Add memory hot remove support

2020-03-18 Thread Shameer Kolothum
This adds support for memory hot remove on arm/virt that uses acpi ged device. Signed-off-by: Shameer Kolothum --- -RFC because linux kernel support for mem hot remove is just queued for 5.7[1]. -Tested with guest kernel 5.6-rc5 + [1] 1. https://patchwork.kernel.org/cover/11419301/ --- hw/a

Re: [PATCH] build: Silence clang warning on older glib autoptr usage

2020-03-18 Thread Eric Blake
On 3/18/20 6:19 AM, Eric Blake wrote: This wasn't a NetBSD failure. I hit it on my clang-on-x86-64-Ubuntu setup, and also on FreeBSD. (The latter is just the tests/vm FreeBSD config, so you can repro that if you need to.) The ubuntu setup is libglib 2.56.4-0ubuntu0.18.04.4 and clang 6.0.0-1ubun

Re: [PULL 00/10] Bitmaps patches

2020-03-18 Thread Eric Blake
On 3/17/20 9:00 AM, Peter Maydell wrote: block/qcow2-bitmap: use bdrv_dirty_bitmap_next_dirty (2020-03-12 16:36:46 -0400) Pull request --- Hi; this fails to compil

Re: [PATCH] build: Silence clang warning on older glib autoptr usage

2020-03-18 Thread Eric Blake
On 3/17/20 1:11 PM, Peter Maydell wrote: On Tue, 17 Mar 2020 at 17:55, Eric Blake wrote: glib's G_DEFINE_AUTOPTR_CLEANUP_FUNC() macro defines several static inline functions, often with some of them unused, but prior to 2.57.2 did not mark the functions as such. As a result, clang (but not gc

Re: [PATCH v4 2/3] mac_via: fix incorrect creation of mos6522 device in mac_via

2020-03-18 Thread Markus Armbruster
Paolo Bonzini writes: > On 16/03/20 07:03, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> On 15/03/20 15:56, Markus Armbruster wrote: > > The question is why they are not, i.e. where does the above reasoning > break. I don't know. But let's for the sake of the argum

Re: [PATCH v5 6/7] vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro

2020-03-18 Thread Juan Quintela
Yuri Benditovich wrote: > Similar to VMSTATE_VARRAY_UINT32_ALLOC, but the size is > 16-bit field. > > Signed-off-by: Yuri Benditovich Reviewed-by: Juan Quintela Same caveat about attribution to MST. Once told tha, I don't understand why you are using a unit16_t. You define indirections_len as

Re: [PATCH v4 2/3] mac_via: fix incorrect creation of mos6522 device in mac_via

2020-03-18 Thread Paolo Bonzini
On 18/03/20 14:02, Markus Armbruster wrote: > Object instantiation must be completely reverted by finalization. > > device-introspect-test guards against a particularly egregious violation > of this rule, namely output of "info qtree" after initialization + > finalization differing from output bef

Re: [PATCH] hw/scsi/vmw_pvscsi: Remove assertion for kick after reset

2020-03-18 Thread Paolo Bonzini
On 15/03/20 14:26, Liran Alon wrote: > From: Elazar Leibovich > > When running Ubuntu 3.13.0-65-generic guest, QEMU sometimes crashes > during guest ACPI reset. It crashes on assert(s->rings_info_valid) > in pvscsi_process_io(). > > Analyzing the crash revealed that it happens when userspace iss

Re: [PATCH v13 Kernel 4/7] vfio iommu: Implementation of ioctl to for dirty pages tracking.

2020-03-18 Thread Alex Williamson
On Wed, 18 Mar 2020 12:13:12 + "Dr. David Alan Gilbert" wrote: > * Kirti Wankhede (kwankh...@nvidia.com) wrote: > > VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: > > - Start pinned and unpinned pages tracking while migration is active > > - Stop pinned and unpinned dirty pages track

[Bug 1867786] Re: Qemu PPC64 freezes with multi-core CPU

2020-03-18 Thread Laurent Vivier
Thank you for the test. I'm going to try to reproduce the problem and bisect. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1867786 Title: Qemu PPC64 freezes with multi-core CPU Status in QEMU:

[PATCH] hw/rdma/vmw/pvrdma_dev_ring: Replace strncpy with pstrcpy

2020-03-18 Thread Julia Suvorova
ring->name is defined as 'char name[MAX_RING_NAME_SZ]'. Replace untruncated strncpy with QEMU function. This case prevented QEMU from compiling with --enable-sanitizers. Signed-off-by: Julia Suvorova --- hw/rdma/vmw/pvrdma_dev_ring.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) dif

Re: [PULL v2 00/37] Linux user for 5.0 patches

2020-03-18 Thread Peter Maydell
On Tue, 17 Mar 2020 at 16:05, Laurent Vivier wrote: > > The following changes since commit 373c7068dd610e97f0b551b5a6d0a27cd6da4506: > > qemu.nsi: Install Sphinx documentation (2020-03-09 16:45:00 +) > > are available in the Git repository at: > > git://github.com/vivier/qemu.git tags/linu

Re: [PULL v2 00/37] Linux user for 5.0 patches

2020-03-18 Thread Laurent Vivier
Le 18/03/2020 à 14:57, Peter Maydell a écrit : > On Tue, 17 Mar 2020 at 16:05, Laurent Vivier wrote: >> >> The following changes since commit 373c7068dd610e97f0b551b5a6d0a27cd6da4506: >> >> qemu.nsi: Install Sphinx documentation (2020-03-09 16:45:00 +) >> >> are available in the Git reposito

[PATCH] MAINTAINERS: Upgrade myself as 9pfs co-maintainer

2020-03-18 Thread Christian Schoenebeck
As suggested by Greg, let's upgrade myself as co-maintainer of 9pfs. Signed-off-by: Christian Schoenebeck --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7364af0d8b..8d9cd04ab5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1630

[RFC (fix for 5.0?)] block/io: do not do pointer arithmetic on void *

2020-03-18 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi all! C standard doesn't allow pointer arithmetic on void *. Still, gcc allows it as an extension: https://gcc.gnu.org/onlinedocs/gcc-4.8.0/gcc/Pointer-Arith.html I can create a series of patches like this. Do we need it? Also, where is docume

Re: [RFC (fix for 5.0?)] block/io: do not do pointer arithmetic on void *

2020-03-18 Thread Daniel P . Berrangé
On Wed, Mar 18, 2020 at 05:22:53PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > Hi all! > > C standard doesn't allow pointer arithmetic on void *. > Still, gcc allows it as an extension: > https://gcc.gnu.org/onlinedocs/gcc-4.8.0/gcc/Pointer

[PATCH v10 00/16] s390x: Protected Virtualization support

2020-03-18 Thread Janosch Frank
Most of the QEMU changes for PV are related to the new IPL type with subcodes 8 - 10 and the execution of the necessary Ultravisor calls to IPL secure guests. Note that we can only boot into secure mode from normal mode, i.e. stfle 161 is not active in secure mode. The other changes related to dat

  1   2   3   >