On Wed, 18 Mar 2020 09:44:08 +0100 Janosch Frank <fran...@linux.ibm.com> wrote:
> On 3/17/20 7:06 PM, Cornelia Huck wrote:
> > On Wed, 11 Mar 2020 09:21:51 -0400
> > Janosch Frank <fran...@linux.ibm.com> wrote:
> >> diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
> >> index ff6027036ec2f14a..e11e895a3d9038bb 100644
> >> --- a/target/s390x/kvm.c
> >> +++ b/target/s390x/kvm.c
> >> @@ -2403,6 +2403,11 @@ void kvm_s390_get_host_cpu_model(S390CPUModel
> >> *model, Error **errp)
> >> clear_bit(S390_FEAT_BPB, model->features);
> >> }
> >>
> >> + /* we do have the IPL enhancements */
> >
> > I'm more confused by that comment than educated :) Not sure what 'IPL
> > enhancements' means in this context.
>
> /* We do have the protected virtualization ipl unpack facility */
> ?
Ah :)
What about
/*
* If we have support for protected virtualization, indicate
* the protected virtualization IPL unpack facility.
*/
?
>
> >
> >> + if (cap_protected) {
> >> + set_bit(S390_FEAT_UNPACK, model->features);
> >> + }
> >> +
> >> /* We emulate a zPCI bus and AEN, therefore we don't need HW support
> >> */
> >> set_bit(S390_FEAT_ZPCI, model->features);
> >> set_bit(S390_FEAT_ADAPTER_EVENT_NOTIFICATION, model->features);
> >
>
>
pgpU7UWvjSFJ3.pgp
Description: OpenPGP digital signature
