18.03.2020 7:12, no-re...@patchew.org wrote:
Patchew URL:
https://patchew.org/QEMU/20200318011217.2102748-1-ehabk...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PULL 0/4] Python queue for 5.0 soft freeze
Message-id: 20200318011217.2102748-1-ehabk...@redhat.com
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
1b4f6f3 MAINTAINERS: add simplebench
57b42b6 scripts/simplebench: add example usage of simplebench
99ea4d7 scripts/simplebench: add qemu/bench_block_job.py
196f97d scripts/simplebench: add simplebench.py
=== OUTPUT BEGIN ===
1/4 Checking commit 196f97d8566d (scripts/simplebench: add simplebench.py)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16:
new file mode 100644
ERROR: please use python3 interpreter
#21: FILE: scripts/simplebench/simplebench.py:1:
+#!/usr/bin/env python
Hmm, yes, we need to fix it.
Should I resend?
total: 1 errors, 1 warnings, 128 lines checked
Patch 1/4 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/4 Checking commit 99ea4d73bba8 (scripts/simplebench: add
qemu/bench_block_job.py)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16:
new file mode 100755
ERROR: please use python3 interpreter
#21: FILE: scripts/simplebench/bench_block_job.py:1:
+#!/usr/bin/env python
and here.
total: 1 errors, 1 warnings, 119 lines checked
Patch 2/4 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/4 Checking commit 57b42b691f7b (scripts/simplebench: add example usage of
simplebench)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644
total: 0 errors, 1 warnings, 80 lines checked
Patch 3/4 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/4 Checking commit 1b4f6f3850f4 (MAINTAINERS: add simplebench)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200318011217.2102748-1-ehabk...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
--
Best regards,
Vladimir
