[ Patch didn't make it to the list, so reviewing
https://github.com/romanheros/qemu/commit/c77bef489c5517951077679ec9228438d05f1e1a
]
Reviewed-by: Richard Henderson
r~
[ Patch didn't make it to the list, so reviewing
https://github.com/romanheros/qemu/commit/60668e86d94ffa48adb2f9c346753cf77f582686
]
Reviewed-by: Richard Henderson
It should be possible to rewrite the helpers in units of uint64_t. The
unmasked path is easy; the masked path is more complicated
[ The patch didn't make it to the list, so reviewing
https://github.com/romanheros/qemu/commit/f46b8c8bbbf0acd78746a49fe712306d7c05c7e6
]
Reviewed-by: Richard Henderson
r~
If the process documented in tests/qtest/bios-tables-test.c
is followed, then same patch never touches both expected
files and code. Teach checkpatch to enforce this rule.
Signed-off-by: Michael S. Tsirkin
---
Peter, Igor what do you think?
scripts/checkpatch.pl | 24
On 14/03/2020 22:56, Michael S. Tsirkin wrote:
On Sat, Mar 14, 2020 at 10:05:20PM +0200, Liran Alon wrote:
Michael, you can also refer to this VMware time-keeping whitepaper:
https://urldefense.com/v3/__https://www.vmware.com/pdf/vmware_timekeeping.pdf__;!!GqivPVa7Brio!K8sfnfvVgKwrQ4SMwX-K6-S5
On Sun, 15 Mar 2020, Michael S. Tsirkin wrote:
On Fri, Mar 13, 2020 at 10:14:34PM +0100, BALATON Zoltan wrote:
This removes pci_piix4_ide_init() function similar to clean up done to
other ide devices.
Signed-off-by: BALATON Zoltan
---
hw/ide/piix.c| 12 +---
hw/isa/piix4.c | 5
From: Chen Gang
Another DRM_IOCTL_* commands will be done later.
Signed-off-by: Chen Gang
---
linux-user/ioctls.h| 2 ++
linux-user/syscall.c | 62 ++
linux-user/syscall_defs.h | 15 +
linux-user/syscall_types.h | 11 +++
4 files
From: Elazar Leibovich
When running Ubuntu 3.13.0-65-generic guest, QEMU sometimes crashes
during guest ACPI reset. It crashes on assert(s->rings_info_valid)
in pvscsi_process_io().
Analyzing the crash revealed that it happens when userspace issues
a sync during a reboot syscall.
Below are back
From: Elazar Leibovich
When running Ubuntu 3.13.0-65-generic guest, QEMU sometimes crashes
during guest ACPI reset. It crashes on assert(s->rings_info_valid)
in pvscsi_process_io().
Analyzing the crash revealed that it happens when userspace issues
a sync during a reboot syscall.
Below are back
This is a merger of Yoshinori's v32 of the Renesas RX
architecture emulation.
Richard temporarily handed it over for the 5.0 release.
This part adds the architectural part. The hardware part
will follow.
Call this release, or merge, candidate 1.
repo: https://gitlab.com/philmd/qemu.git
branch: r
From: Yoshinori Sato
Reviewed-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Yoshinori Sato
Signed-off-by: Richard Henderson
Message-Id: <20200224141923.82118-2-ys...@users.sourceforge.jp>
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 5 +
1 file chan
From: Richard Henderson
Note that the ld == 3 case handled by prt_ldmi is decoded as
XCHG_rr and cannot appear here.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Yoshinori Sato
Tested-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
Message-Id: <20190531134315.4109-21-richard.
From: Yoshinori Sato
Reviewed-by: Richard Henderson
Signed-off-by: Yoshinori Sato
Signed-off-by: Richard Henderson
[PMD: Use newer QOM style, split cpu-qom.h, restrict access to
extable array, use rx_cpu_tlb_fill() extracted from patch of
Yoshinori Sato 'Convert to CPUClass::tlb_fill', call
From: Yoshinori Sato
Some RX peripheral using 8bit and 16bit registers.
Added 8bit and 16bit APIs.
Reviewed-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Signed-off-by: Yoshinori Sato
Signed-off-by: Richard Henderso
From: Yoshinori Sato
Reviewed-by: Richard Henderson
Tested-by: Philippe Mathieu-Daudé
Signed-off-by: Yoshinori Sato
Signed-off-by: Richard Henderson
[PMD: Removed tlb_fill, extracted from patch of Yoshinori Sato
'Convert to CPUClass::tlb_fill']
Signed-off-by: Philippe Mathieu-Daudé
Message-
From: Richard Henderson
Many of the multi-part prints have been eliminated by previous
patches. Eliminate the rest of them.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Yoshinori Sato
Tested-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
Message-Id: <20190531134315.4109-22-
From: Richard Henderson
We were eliding all zero indexes. It is only ld==0 that does
not have an index in the instruction. This also allows us to
avoid breaking the final print into multiple pieces.
Reviewed-by: Yoshinori Sato
Tested-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderso
From: Richard Henderson
There are so many different forms of each RX instruction
that it will be very useful to be able to look at the bytes
to see on which path a bug may lie.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Yoshinori Sato
Tested-by: Philippe Mathieu-Daudé
Signed-off-by: Ric
From: Richard Henderson
This has consistency with prt_ri(). It loads all data before
beginning output. It uses exactly one call to prt() to emit
the full instruction.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Yoshinori Sato
Tested-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Hen
From: Yoshinori Sato
Tested-by: Philippe Mathieu-Daudé
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Yoshinori Sato
Signed-off-by: Richard Henderson
[PMD: Squashed patches from Richard Henderson modifying
qapi/common.json and tests/machine-none-test.c]
Message-Id: <20200224141923.8
From: Richard Henderson
Collected, to be used in the next patch.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Yoshinori Sato
Tested-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
Message-Id: <20190531134315.4109-23-richard.hender...@linaro.org>
Signed-off-by: Philippe Mathie
From: Yoshinori Sato
This part only supported RXv1 instructions.
Instruction manual:
https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01us0032ej0120_rxsm.pdf
Reviewed-by: Richard Henderson
Tested-by: Philippe Mathieu-Daudé
Signed-off-by: Yoshinori Sato
Signed-off-by: Richa
From: Yoshinori Sato
Reviewed-by: Richard Henderson
Tested-by: Philippe Mathieu-Daudé
Signed-off-by: Yoshinori Sato
Signed-off-by: Richard Henderson
Message-Id: <20200224141923.82118-8-ys...@users.sourceforge.jp>
Signed-off-by: Philippe Mathieu-Daudé
---
include/disas/dis-asm.h |5 +
ta
From: Philippe Mathieu-Daudé
The RX code flash is not a Masked ROM but a EEPROM (electrically
erasable programmable flash memory).
When implementing the flash hardware, the rom_ptr() returns NULL
and the reset vector is not set.
Instead, use the address_space ld/st API to fetch the reset vector
a
Patchew URL:
https://patchew.org/QEMU/20200315132447.113131-1-liran.a...@oracle.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN
On 3/15/20 2:48 PM, Philippe Mathieu-Daudé wrote:
From: Philippe Mathieu-Daudé
Hmm author email should be ...
The RX code flash is not a Masked ROM but a EEPROM (electrically
erasable programmable flash memory).
When implementing the flash hardware, the rom_ptr() returns NULL
and the reset
Patchew URL:
https://patchew.org/QEMU/20200315132634.113632-1-liran.a...@oracle.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN
Patchew URL: https://patchew.org/QEMU/20200315132810.7022-1-f4...@amsat.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH 00/13] target: Add Renesas RX architecture
Message-id: 20200315132810.7022-1-f4...@amsat.org
Type: serie
Locally defined helper qdict_cmp_simple() implements just enough of a
comparison to serve here. Replace it by qobject_is_equal(), which
implements all of it.
Signed-off-by: Markus Armbruster
---
tests/test-qmp-event.c | 66 +-
1 file changed, 1 insertion(
Commit a9b305ba29 "socket: allow wait=false for client socket"
deprecated use of @wait for client socket chardevs, but neglected to
update char.json's doc comment. Make up for that.
Signed-off-by: Markus Armbruster
---
qapi/char.json | 1 +
1 file changed, 1 insertion(+)
diff --git a/qapi/char
Signed-off-by: Markus Armbruster
---
qapi/qmp-dispatch.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
index 112d29a9ab..fb53687ce9 100644
--- a/qapi/qmp-dispatch.c
+++ b/qapi/qmp-dispatch.c
@@ -164,7 +164,11 @@ QDict *qmp_dispa
Checking the value of qmp_dispatch() is repetitive. Factor out
helpers do_qmp_dispatch() and do_qmp_dispatch_error(). Without this,
the next commit would make things even more repetitive.
Signed-off-by: Markus Armbruster
---
tests/test-qmp-cmds.c | 72 +-
Signed-off-by: Markus Armbruster
---
qapi/qmp-dispatch.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
index a588072523..550d1fe8d2 100644
--- a/qapi/qmp-dispatch.c
+++ b/qapi/qmp-dispatch.c
@@ -106,7 +106
Signed-off-by: Markus Armbruster
---
tests/test-qmp-cmds.c | 23 +--
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/tests/test-qmp-cmds.c b/tests/test-qmp-cmds.c
index b31064b064..464b370189 100644
--- a/tests/test-qmp-cmds.c
+++ b/tests/test-qmp-cmds.c
@@ -151
We convert the request object to a QDict twice: first in
qmp_dispatch() to get the request ID, and then again in
qmp_dispatch_check_obj(), which converts to QDict, then checks and
returns it. We can't get the request ID from the latter, because it's
null when the qdict flunks the checks.
Move get
Mention SchemaInfo variant member "allow-oob" defaults to false.
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt
index 59d6973e1e..5906602504 10
Building expected data with qdict_put() & friends is tedious to write
and hard to read. Parse them from string literals with
qdict_from_jsonf_nofail() instead.
While there, use initializers instead of assignments for initializing
aggregate event arguments.
Signed-off-by: Markus Armbruster
---
Building requests with qdict_put() & friends is tedious to write and
hard to read. Parse them from string literals with
qdict_from_vjsonf_nofail() instead.
Signed-off-by: Markus Armbruster
---
tests/test-qmp-cmds.c | 93 ++-
1 file changed, 38 insertions(
Signed-off-by: Markus Armbruster
---
tests/test-qmp-event.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/test-qmp-event.c b/tests/test-qmp-event.c
index d64066139c..7dd0053190 100644
--- a/tests/test-qmp-event.c
+++ b/tests/test-qmp-event.c
@@ -26,6 +26,7 @@
Policy "crash" calls abort() when deprecated input is received.
Bugs in integration tests may mask the error from policy "reject".
Provide a larger hammer: crash outright. Masking that seems unlikely.
Signed-off-by: Markus Armbruster
---
qapi/compat.json | 3 ++-
qapi/qmp-dispatch.
The .connect_doc() of classes that have QAPISchemaMember connect them
to their documentation. Change them to delegate the actual work to
new QAPISchemaMember.connect_doc(). Matches the .connect_doc() that
already exist.
Signed-off-by: Markus Armbruster
---
scripts/qapi/schema.py | 23 +
QAPISchema._make_features() takes a definition expression, and
extracts its 'features' member. The other ._make_FOO() leave
destructuring expressions to their callers. Change ._make_features()
to match them.
Signed-off-by: Markus Armbruster
---
scripts/qapi/schema.py | 17 +
1
Commit 6a8c0b5102 "qapi: Add feature flags to struct types" neglected
to update section "Client JSON Protocol introspection", and commit
23394b4c39 "qapi: Add feature flags to commands" didn't either. Make
up for that.
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.txt | 43 +
This policy rejects deprecated input, and thus permits "testing the
future". Implement it for QMP commands: make deprecated ones fail.
Example: when QEMU is run with -compat deprecated-input=reject, then
{"execute": "query-cpus"}
fails like this
{"error": {"class": "CommandNotFound", "d
This series extends QMP introspection to cover deprecation.
Additionally, new option -compat lets you configure what to do when
deprecated interfaces get used. This is intended for testing users of
the management interfaces. It is experimental.
-compat deprecated-input= configures what to do whe
Move QAPISchemaAlternateType up some, so that all QAPISchemaFOOType
are together. Move QAPISchemaObjectTypeVariants right behind its
users.
Signed-off-by: Markus Armbruster
---
scripts/qapi/schema.py | 284 -
1 file changed, 142 insertions(+), 142 deletio
This policy suppresses deprecated bits in output, and thus permits
"testing the future". Implement it for QMP events: suppress
deprecated ones.
No QMP event is deprecated right now.
Signed-off-by: Markus Armbruster
---
tests/test-qmp-event.c | 19 +++
scripts/qapi/events.py | 1
Both functions check @request is a QDict, and both have code for
QCO_NO_SUCCESS_RESP. This wasn't the case back when they were
created. It's a sign of muddled responsibilities. Inline. The next
commits will clean up some more.
Signed-off-by: Markus Armbruster
---
qapi/qmp-dispatch.c | 90 +++
A number of deprecated QMP arguments and results were missed in commit
eb22aeca65 "docs: document deprecation policy & deprecated features in
appendix" (v2.10.0):
* Commit b33945cfff "block: Accept device model name for
blockdev-open/close-tray" (v2.8.0) deprecated blockdev-open-tray,
blockdev
Add feature 'deprecated' to the deprecated QMP commands, so their
deprecation becomes visible in output of query-qmp-schema. Looks like
this:
{"name": "query-cpus",
"ret-type": "[164]",
"meta-type": "command",
"arg-type": "0",
---> "features": ["deprecated"]}
Management applic
This policy suppresses deprecated bits in output, and thus permits
"testing the future". Implement it for QMP command results. Example:
when QEMU is run with -compat deprecated-output=hide, then
{"execute": "query-cpus-fast"}
yields
{"return": [{"thread-id": 9805, "props": {"core-id":
This policy suppresses deprecated bits in output, and thus permits
"testing the future". Implement it for QMP event data: suppress
deprecated members.
No QMP event data is deprecated right now.
Signed-off-by: Markus Armbruster
---
tests/test-qmp-event.c | 18 ++
The value of @qmp_schema_qlit is generated from an expression tree.
Tree nodes are created in several places. Factor out the common code
into _make_tree(). This isn't much of a win now. It will pay off
when we add feature flags in the next few commits.
Signed-off-by: Markus Armbruster
---
scr
QAPISchemaObjectTypeVariants represents both object type and alternate
type variants. Rename to QAPISchemaVariants.
Rename QAPISchemaObjectTypeVariant the same way.
Signed-off-by: Markus Armbruster
---
scripts/qapi/schema.py | 22 +++---
1 file changed, 11 insertions(+), 11 del
We generate the value of qmp_schema_qlit from an expression tree. The
function doing that is named to_qlit(), and its inputs are accumulated
in QAPISchemaGenIntrospectVisitor._qlits. We call both its input and
its output "qlit". This is confusing.
Use "tree" for input, and "qlit" only for outpu
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.txt| 4 +++-
tests/qapi-schema/doc-good.texi | 2 ++
qapi/introspect.json| 6 +-
scripts/qapi/expr.py| 3 ++-
scripts/qapi/introspect.py | 2 +-
scripts/
QAPISchemaEntity calls doc.connect_feature() in .check(). Improper
since commit ee1e6a1f6c8 split .connect_doc() off .check(). Move the
call. Requires making the children call super().connect_doc() as they
should.
Signed-off-by: Markus Armbruster
---
scripts/qapi/schema.py | 13 +
Unlike regular feature flags, the new special feature flag
"deprecated" is recognized by the QAPI generator. For now, it's only
permitted with commands, events, and struct members. It will be put
to use shortly.
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.txt
This policy rejects deprecated input, and thus permits "testing the
future". Implement it for QMP command arguments: reject commands with
deprecated ones. Example: when QEMU is run with -compat
deprecated-input=reject, then
{"execute": "eject", "arguments": {"device": "cd"}}
fails like this
Paolo Bonzini writes:
> On 14/03/20 14:19, Mark Cave-Ayland wrote:
>>> Observe that mac_via_init() has obvious side effects. In particular, it
>>> creates two devices that are then visible in "info qtree", and that's
>>> caught by device-introspect-test.
>>>
>>> I believe these things need to be
This policy suppresses deprecated bits in output, and thus permits
"testing the future". Implement it for QMP command query-qmp-schema:
suppress information on deprecated commands, events and object type
members, i.e. anything that has the special feature flag "deprecated".
Signed-off-by: Markus
Mark Cave-Ayland writes:
> On 10/03/2020 09:07, Markus Armbruster wrote:
>
>> Widespread QOM usage anti-pattern ahead; cc: QOM maintainers.
>>
>> Peter Maydell writes:
>>
>>> On Mon, 9 Mar 2020 at 10:02, Pan Nengyuan wrote:
On 3/9/2020 5:21 PM, Peter Maydell wrote:
> Could you explai
Policy is separate for input and output.
Input policy can be "accept" (accept silently), or "reject" (reject
the request with an error).
Output policy can be "accept" (pass on unchanged), or "hide" (filter
out the deprecated parts).
Default is "accept". Policies other than "accept" are implemen
On Wed, Mar 11, 2020 at 07:23:42PM -0400, Eduardo Habkost wrote:
> The CONFIG_LINUX check at the top of mmap-alloc.c never worked
> because it was done before including osdep.h.
>
> This means MAP_SYNC and MAP_SHARED_VALIDATE would always be set
> to 0 at the beginning of the file. Luckily, this
Hi Yoshinori,
On 3/15/20 2:28 PM, Philippe Mathieu-Daudé wrote:
From: Yoshinori Sato
Reviewed-by: Richard Henderson
Signed-off-by: Yoshinori Sato
Signed-off-by: Richard Henderson
[PMD: Use newer QOM style, split cpu-qom.h, restrict access to
extable array, use rx_cpu_tlb_fill() extracted
Signed-off-by: Markus Armbruster
---
scripts/qapi/commands.py | 6 +++---
scripts/qapi/doc.py| 10 +-
scripts/qapi/introspect.py | 10 +-
scripts/qapi/schema.py | 36 --
scripts/qapi/types.py | 4 ++--
script
On Sat, Mar 14, 2020 at 10:39:11AM +0100, Paolo Bonzini wrote:
> On 12/03/20 00:23, Eduardo Habkost wrote:
> > Changes v1 -> v2:
> > * Use -isystem for $PWD/linux-headers too
> > Reported-by: "Michael S. Tsirkin"
> >
> > This is an alternative to the patch submitted at:
> >
> > From: Jingqi
On 3/15/20 3:46 PM, Markus Armbruster wrote:
Unlike regular feature flags, the new special feature flag
"deprecated" is recognized by the QAPI generator. For now, it's only
permitted with commands, events, and struct members. It will be put
to use shortly.
What about using a '@DeprecatedSince
In v4.1.0, we added feature flags just to struct types (commit
6a8c0b5102^..f3ed93d545), to satisfy an immediate need (commit
c9d4070991 "file-posix: Add dynamic-auto-read-only QAPI feature"). In
v4.2.0, we added them to commands (commit 23394b4c39 "qapi: Add
feature flags to commands") to satisfy
On Thu, Mar 12, 2020 at 04:05:47PM +0200, Oksana Vohchana wrote:
> QEMUMachine writes some messages to the default logger.
> But it sometimes hard to read the output if we have requests to
> more than one VM.
> This patch adds a label to the logger in the debug mode.
>
> Signed-off-by: Oksana Vohc
Eric Blake writes:
> On 3/13/20 4:54 PM, Markus Armbruster wrote:
>
>>
>> I append my hacked up version of auto-propagated-errp.cocci. It
>> produces the same patch as yours for the complete tree.
>>
>>
>>
>> // Use ERRP_AUTO_PROPAGATE (see include/qapi/error.h)
>> //
>
>> //
>> // Usage example
From: Vincent Fazio
In ELFv2, function pointers are entry points and are in host endianness.
Previously, the signal handler would be swapped if the target CPU was a
different endianness than the host. This would cause a SIGSEGV when
attempting to translate the opcode pointed to by the swapped ad
Philippe Mathieu-Daudé writes:
> On 3/15/20 3:46 PM, Markus Armbruster wrote:
>> Unlike regular feature flags, the new special feature flag
>> "deprecated" is recognized by the QAPI generator. For now, it's only
>> permitted with commands, events, and struct members. It will be put
>> to use sh
On 15/03/20 15:56, Markus Armbruster wrote:
>>
>> The question is why they are not, i.e. where does the above reasoning break.
> I don't know. But let's for the sake of the argument assume this
> actually worked. Asking for help in the monitor then *still* has side
> effects visible in the time s
Le 15/03/2020 à 16:52, Vincent Fazio a écrit :
> From: Vincent Fazio
>
> In ELFv2, function pointers are entry points and are in host endianness.
"host endianness" is misleading here. "target endianness" is better.
>
> Previously, the signal handler would be swapped if the target CPU was a
> d
On Thu, 12 Mar 2020 at 16:33, Peter Maydell wrote:
>
> On Thu, 12 Mar 2020 at 00:34, Beata Michalska
> wrote:
> >
> > KVM_SET_VCPU_EVENTS might actually lead to vcpu registers being modified.
> > As such this should be the last step of sync to avoid potential overwriting
> > of whatever changes K
On Thu, 12 Mar 2020 at 10:25, Andrew Jones wrote:
>
> On Thu, Mar 12, 2020 at 12:34:01AM +, Beata Michalska wrote:
> > On ARMv7 & ARMv8 some load/store instructions might trigger a data abort
> > exception with no valid ISS info to be decoded. The lack of decode info
> > makes it at least tric
On 3/15/20 6:48 AM, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daudé
>
> The RX code flash is not a Masked ROM but a EEPROM (electrically
> erasable programmable flash memory).
> When implementing the flash hardware, the rom_ptr() returns NULL
> and the reset vector is not set.
> Inst
On 3/13/20 11:36 AM, Philippe Mathieu-Daudé wrote:
> Avoid building TCG when building only tools:
>
> ./configure --enable-tools --disable-system --disable-user
>
> This saves us from running the soft-float tests enabled since
> commit 76170102508.
>
> Signed-off-by: Philippe Mathieu-Daudé
>
Ping.
On 3/10/20 10:21 PM, Richard Henderson wrote:
> A given RISU testcase for SVE can produce
>
> tcg-op-vec.c:511: do_shifti: Assertion `i >= 0 && i < (8 << vece)' failed.
>
> because expand_vec_sari gave a shift count of 32 to a MO_32
> vector shift.
>
> In 44f1441dbe1, we changed from dire
On 3/13/20 11:36 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/Makefile.include | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Richard Henderson
r~
On 3/13/20 3:28 PM, Laurent Vivier wrote:
>> ifeq ($(CONFIG_LINUX)$(CONFIG_SECCOMP)$(CONFIG_LIBCAP_NG),yyy)
>> -HELPERS-y += virtiofsd$(EXESUF)
>> -vhost-user-json-y += tools/virtiofsd/50-qemu-virtiofsd.json
>> +HELPERS-$(CONFIG_SOFTMMU) += virtiofsd$(EXESUF)
>> +vhost-user-json-$(CONFIG_SOFTMMU)
On 3/13/20 11:36 AM, Philippe Mathieu-Daudé wrote:
> These tests fails when configured with --disable-system.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/Makefile.include | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
So... they don't currently fail check-u
On 3/15/20 1:07 PM, Richard Henderson wrote:
> On 3/13/20 11:36 AM, Philippe Mathieu-Daudé wrote:
>> These tests fails when configured with --disable-system.
>>
>> Signed-off-by: Philippe Mathieu-Daudé
>> ---
>> tests/Makefile.include | 16
>> 1 file changed, 8 insertions(+), 8 d
On 3/13/20 11:36 AM, Philippe Mathieu-Daudé wrote:
> These stubs are not required when configured with --disable-system.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> stubs/Makefile.objs | 52 ++---
> 1 file changed, 30 insertions(+), 22 deletions(-)
On 3/13/20 11:36 AM, Philippe Mathieu-Daudé wrote:
> These stubs are not required when configured with --disable-system.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> util/Makefile.objs | 59 +-
> 1 file changed, 38 insertions(+), 21 deletions(-)
On 3/13/20 11:36 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> target/riscv/cpu.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson
r~
On 3/13/20 11:36 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> exec.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
On 3/13/20 11:36 AM, Philippe Mathieu-Daudé wrote:
> Commit ffaee83bcb2 moved qmp_query_target but forgot to remove
> this include.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> arch_init.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Richard Henderson
r~
On 3/13/20 11:36 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> target/arm/cpu.h| 10 +-
> target/i386/cpu.h | 18 +-
> target/ppc/cpu.h| 2 --
> target/s390x/internal.h | 3 ++-
> t
On 3/13/20 11:36 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> exec.c | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index 7bc9828c5b..f258502966 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -185,10 +185,6 @@ struct DirtyBitmapSnaps
On 3/13/20 11:36 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> target/i386/cpu.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
On 3/13/20 11:36 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> target/s390x/cpu.c | 12 +---
> 1 file changed, 5 insertions(+), 7 deletions(-)
Reviewed-by: Richard Henderson
r~
Now that we can pass 7 parameters, do not encode register
operands within simd_data.
Reviewed-by: Alex Bennée
Reviewed-by: Taylor Simpson
Signed-off-by: Richard Henderson
---
v2: Remove gen_helper_sve_fmla typedef (phil).
---
target/arm/helper-sve.h| 45 +++
target/arm/sve_helper.
On 3/13/20 11:41 AM, Philippe Mathieu-Daudé wrote:
> Move out x86-specific structures from generic machine code.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> qapi/machine-target.json | 45 ++
> qapi/machine.json | 42 ---
On Sun, Mar 15, 2020 at 11:46:04AM -0400, Eduardo Habkost wrote:
> On Sat, Mar 14, 2020 at 10:39:11AM +0100, Paolo Bonzini wrote:
> > On 12/03/20 00:23, Eduardo Habkost wrote:
> > > Changes v1 -> v2:
> > > * Use -isystem for $PWD/linux-headers too
> > > Reported-by: "Michael S. Tsirkin"
> > >
>
On 3/13/20 11:36 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> include/hw/core/cpu.h | 7 ++-
> hw/core/cpu.c | 2 ++
> 2 files changed, 8 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
On 3/13/20 11:45 AM, Philippe Mathieu-Daudé wrote:
> +if (qemu_strtol(str + pos, &p, 16, &val) < 0 || val > 0xff) {
> +goto inval;
> +}
This is doing more that *just* using qemu_strtol, it's also validating the
input. I don't think you need to adjust the patch, just im
On Sun, Mar 15, 2020 at 11:45:59AM -0400, Eduardo Habkost wrote:
> On Wed, Mar 11, 2020 at 07:23:42PM -0400, Eduardo Habkost wrote:
> > The CONFIG_LINUX check at the top of mmap-alloc.c never worked
> > because it was done before including osdep.h.
> >
> > This means MAP_SYNC and MAP_SHARED_VALIDA
Patchew URL: https://patchew.org/QEMU/20200313184607.11792-1-phi...@redhat.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#
1 - 100 of 181 matches
Mail list logo
