On Sun, Mar 15, 2020 at 11:46:04AM -0400, Eduardo Habkost wrote: > On Sat, Mar 14, 2020 at 10:39:11AM +0100, Paolo Bonzini wrote: > > On 12/03/20 00:23, Eduardo Habkost wrote: > > > Changes v1 -> v2: > > > * Use -isystem for $PWD/linux-headers too > > > Reported-by: "Michael S. Tsirkin" <m...@redhat.com> > > > > > > This is an alternative to the patch submitted at: > > > > > > From: Jingqi Liu <jingqi....@intel.com> > > > Subject: [PATCH] util: fix to get configuration macros in > > > util/mmap-alloc.c > > > Date: Thu, 5 Mar 2020 23:41:42 +0800 > > > Message-Id: <20200305154142.63070-1-jingqi....@intel.com> > > > > > > Before moving the osdep.h include to the top of the file, we had > > > to address warnings triggered when <linux/mman.h> was included > > > after <sys/mman.h> (done in patch 1/2). > > > > > > Eduardo Habkost (2): > > > Use -isystem for linux-headers dir > > > mmap-alloc: Include osdep.h before checking CONFIG_LINUX > > > > > > Makefile.target | 2 +- > > > configure | 2 +- > > > util/mmap-alloc.c | 7 +++---- > > > 3 files changed, 5 insertions(+), 6 deletions(-) > > > > > > > Queued, thanks. > > Please don't queue patch 2/2. It breaks the build on mips.
I don't argue that it doesn't, but MIPS pretends to support features such as MAP_SYNC when in fact it does nothing. > -- > Eduardo
