On 3/13/20 11:45 AM, Philippe Mathieu-Daudé wrote: > + if (qemu_strtol(str + pos, &p, 16, &val) < 0 || val > 0xff) { > + goto inval; > + }
This is doing more that *just* using qemu_strtol, it's also validating the input. I don't think you need to adjust the patch, just improve the commit message. With that, Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~