[Bug 1813165] Re: KVM internal error. Suberror: 1 emulation failure

2020-03-09 Thread tstrike
L0 DistroRelease: Ubuntu 20.04 on Kernel Linux 5.4.0-14-generic x86_64 L1 3 guestsWindows 10, Centos 8 No L2s No guests are enabled for UEFI Boot -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/18

Re: [PATCH v4 2/3] mac_via: fix incorrect creation of mos6522 device in mac_via

2020-03-09 Thread Pan Nengyuan
On 3/10/2020 12:16 AM, Mark Cave-Ayland wrote: > On 09/03/2020 14:14, Markus Armbruster wrote: > >> Pan Nengyuan writes: >> >>> On 3/9/2020 8:34 PM, Markus Armbruster wrote: Peter Maydell writes: > On Mon, 9 Mar 2020 at 10:02, Pan Nengyuan wrote: >> On 3/9/2020 5:21 PM, Pet

[PATCH] i386/kvm: Add CPU property to expose VMware CPUID signature

2020-03-09 Thread Liran Alon
Some guests are only familiar with VMware PV interface. Therefore, in order for these guests to run properly on KVM, we need to be able to expose VMware main CPUID leaf. i.e. leaf 0x4000. E.g. Without exposing this VMware CPUID leaf, some guests will fail to boot. For example, because of guest

Re: [PATCH v2 4/5] KVM: Kick resamplefd for split kernel irqchip

2020-03-09 Thread Peter Xu
On Mon, Mar 09, 2020 at 04:33:59PM -0600, Alex Williamson wrote: [...] > > > diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c > > > index 15747fe2c2..13921b333d 100644 > > > --- a/hw/intc/ioapic.c > > > +++ b/hw/intc/ioapic.c > > > @@ -236,8 +236,27 @@ void ioapic_eoi_broadcast(int vector) > > >

Re: [PATCH 5/5] hw/core/loader: Provide rom_add_file_fixed() a 'max_size' argument

2020-03-09 Thread David Gibson
On Mon, Mar 09, 2020 at 03:43:53PM +0100, Philippe Mathieu-Daudé wrote: > Let rom_add_file_fixed() call rom_add_file() with a 'max_size' > argument, to avoid writing more than the available space for > the ROMs. > > Signed-off-by: Philippe Mathieu-Daudé ppc parts Acked-by: David Gibson > ---

Re: [PATCH] spapr/xive: use SPAPR_IRQ_IPI to define IPI ranges exposed to the guest

2020-03-09 Thread David Gibson
On Fri, Mar 06, 2020 at 01:33:07PM +0100, Cédric Le Goater wrote: > The "ibm,xive-lisn-ranges" defines ranges of interrupt numbers that > the guest can use to configure IPIs. It starts at 0 today but it could > change to some other offset. Make clear which IRQ range we are > exposing by using SPAPR

Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements Message-id: 20200309235411.76587-1-liran.a...

Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash e

Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread Liran Alon
On 10/03/2020 2:54, no-re...@patchew.org wrote: Patchew URL: https://urldefense.com/v3/__https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/__;!!GqivPVa7Brio!N5car8IBDE_QFIGGfZAaPfF3gc3sv_CIDltJvgI8K5bvOLgPcGxKnVicygP6jf4$ Hi, This series failed the asan build test. Plea

Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements Message-id: 20200309235411.76587-1-liran.a...

Re: [PATCH] python/qemu/qmp.py: QMP debug with VM label

2020-03-09 Thread John Snow
On 3/4/20 5:05 AM, Oksana Vohchana wrote: > QEMUMachine writes some messages to the default logger. > But it sometimes to hard the read the output if we have requested to > more than one VM. > This patch adds name in QMP command if it needs and labels with it in > debug mode. > Hiya! I like t

Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements Message-id: 20200309235411.76587-1-liran.a...

Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash e

Re: [PATCH v2 4/5] KVM: Kick resamplefd for split kernel irqchip

2020-03-09 Thread Alex Williamson
On Mon, 9 Mar 2020 20:38:08 -0400 Peter Xu wrote: > On Mon, Mar 09, 2020 at 04:33:59PM -0600, Alex Williamson wrote: > > [...] > > > > > diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c > > > > index 15747fe2c2..13921b333d 100644 > > > > --- a/hw/intc/ioapic.c > > > > +++ b/hw/intc/ioapic.c > >

Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements Message-id: 20200309235411.76587-1-liran.a...

Re: [PATCH] qcow2: remove QCowL2Meta parameter from handle_copied

2020-03-09 Thread John Snow
CC qemu-block and qcow2 maintainers (Use scripts/get_maintainer.pl to identify maintainers.) On 3/9/20 12:35 PM, Yi Li wrote: > The QCowL2Meta **m parameter is not used > > Signed-off-by: Yi Li > --- > block/qcow2-cluster.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff

Re: [PATCH RESEND 2/3] vhost: fix a null pointer reference of vhost_log

2020-03-09 Thread Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
Hi Michael, ping... On 2020/2/24 14:42, Longpeng(Mike) wrote: > From: Longpeng > > vhost_log_alloc() may fails and returned pointer of log is null. > However there're two places derefernce the return pointer without > check. > > Signed-off-by: Longpeng > --- > hw/virtio/vhost.c | 19

Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash e

Re: Any interest in dwc-otg (aka dwc2) device emulation? For Raspi 3 and below.

2020-03-09 Thread John Snow
On 3/6/20 7:34 PM, Paul Zimmerman wrote: > Hi Folks, > > I have been working on an emulation of the dwc-otg USB controller > (host mode only for now), as implemented on the Raspberry Pi 3 and > below, and on numerous other embedded platforms. I have it to a point > where it works pretty well wi

Re: [PATCH] tests/acceptance/ppc_prep_40p: Use cdn.netbsd.org hostname

2020-03-09 Thread David Gibson
On Fri, Feb 28, 2020 at 04:10:19PM +, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > > > Use NetBSD content delivery network to get faster downloads. > > Even with this patch I get failures on my big dev box: > > (48/67) > tests/acceptance/ppc_prep_40p.py:IbmPrep40pMachine.test_

Re: [PATCH] tests/acceptance/ppc_prep_40p: Use cdn.netbsd.org hostname

2020-03-09 Thread Cleber Rosa
- Original Message - > From: "David Gibson" > To: "Alex Bennée" > Cc: qemu-devel@nongnu.org, "Wainer dos Santos Moschetta" > , "Kamil Rytarowski" > , "Hervé Poussineau" , "Cleber Rosa" > , > qemu-...@nongnu.org, "Philippe Mathieu-Daudé" > Sent: Monday, March 9, 2020 9:41:16 PM > Sub

Re: [RFC PATCH 1/1] ppc/spapr: Add hotplugged flag on DIMM LMBs on drmem_v2

2020-03-09 Thread David Gibson
On Thu, Mar 05, 2020 at 09:22:02PM -0300, Leonardo Bras wrote: > On reboot, all memory that was previously added using object_add and > device_add is placed in this DIMM area. > > The new SPAPR_LMB_FLAGS_HOTPLUGGED flag helps Linux to put this memory in > the correct memory zone, so no unmovable a

Re: [PATCH] target/ppc: Fix rlwinm on ppc64

2020-03-09 Thread David Gibson
On Mon, Mar 09, 2020 at 11:45:57PM +0300, Vitaly Chikunov wrote: > rlwinm cannot just AND with Mask if shift value is zero on ppc64 when > Mask Begin is greater than Mask End and high bits are set to 1. > > Note that PowerISA 3.0B says that for `rlwinm' ROTL32 is used, and > ROTL32 is defined (in

Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements Message-id: 20200309235411.76587-1-liran.a...

Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash e

Re: [PATCH v2 2/4] virtio-net: implement RSS configuration command

2020-03-09 Thread Jason Wang
On 2020/3/9 下午4:34, Yuri Benditovich wrote: Optionally report RSS feature. Handle RSS configuration command and keep RSS parameters in virtio-net device context. Signed-off-by: Yuri Benditovich --- hw/net/trace-events| 3 + hw/net/virtio-net.c| 148 +++

Re: [PATCH v2 3/4] virtio-net: implement RX RSS processing

2020-03-09 Thread Jason Wang
On 2020/3/9 下午4:34, Yuri Benditovich wrote: If VIRTIO_NET_F_RSS negotiated and RSS is enabled, process incoming packets, calculate packet's hash and place the packet into respective RX virtqueue. Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c| 86 +++

Re: [PATCH v2 4/4] virtio-net: block migration if RSS feature negotiated

2020-03-09 Thread Jason Wang
On 2020/3/9 下午4:34, Yuri Benditovich wrote: Block migration for reference implementation of RSS feature in QEMU. When we add support for RSS on backend side, we'll implement migration of current RSS settings. Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c| 18 ++

Re: Any interest in dwc-otg (aka dwc2) device emulation? For Raspi 3 and below.

2020-03-09 Thread Paul Zimmerman
Hi John, Thanks for the tips! I found an issue when testing with the usb-storage device, so I will work on fixing that, and then think about how best to split up the patches. Thanks, Paul On Mon, Mar 9, 2020 at 7:23 PM John Snow wrote: > > > On 3/6/20 7:34 PM, Paul Zimmerman wrote: > > Hi Folk

Re: [PATCH v3 3/3] via-ide: Also emulate non 100% native mode

2020-03-09 Thread Michael S. Tsirkin
On Mon, Mar 09, 2020 at 09:50:57PM +0100, BALATON Zoltan wrote: > On Mon, 9 Mar 2020, Michael S. Tsirkin wrote: > > On Mon, Mar 09, 2020 at 08:18:13PM +0100, BALATON Zoltan wrote: > > > Some machines operate in "non 100% native mode" where interrupts are > > > fixed at legacy IDE interrupts and som

Re: [PATCH v3 2/3] pci: Honour wmask when resetting PCI_INTERRUPT_LINE

2020-03-09 Thread Michael S. Tsirkin
On Mon, Mar 09, 2020 at 09:54:27PM +0100, BALATON Zoltan wrote: > On Mon, 9 Mar 2020, Michael S. Tsirkin wrote: > > On Mon, Mar 09, 2020 at 08:18:13PM +0100, BALATON Zoltan wrote: > > > The pci_do_device_reset() function (called from pci_device_reset) > > > clears the PCI_INTERRUPT_LINE config reg

Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs

2020-03-09 Thread Cleber Rosa
On Thu, Feb 06, 2020 at 02:05:04PM +0100, Philippe Mathieu-Daudé wrote: > > > > On another thread Thomas said he doesn't want to be responsible of other > > tests: > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg670132.html > > > > We could move the set of tests converted from Peter per

Re: [PATCH] target/ppc: Fix rlwinm on ppc64

2020-03-09 Thread Richard Henderson
On 3/9/20 1:45 PM, Vitaly Chikunov wrote: > rlwinm cannot just AND with Mask if shift value is zero on ppc64 when > Mask Begin is greater than Mask End and high bits are set to 1. > > Note that PowerISA 3.0B says that for `rlwinm' ROTL32 is used, and > ROTL32 is defined (in 3.3.14) so that rotated

Re: [PATCH] docs: Add RX target.

2020-03-09 Thread Yoshinori Sato
2020-03-10 00:07 に Eric Blake さんは書きました: On 3/8/20 8:06 AM, Yoshinori Sato wrote: Add rx-virt target specificaion document. specification Signed-off-by: Yoshinori Sato --- docs/system/target-rx.rst | 35 +++ docs/system/targets.rst | 1 + 2 files chang

Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs

2020-03-09 Thread Cleber Rosa
On Sat, Feb 08, 2020 at 01:02:41PM +, Peter Maydell wrote: > On Fri, 7 Feb 2020 at 19:34, Cleber Rosa wrote: > > Also, the build and make steps worked fine without `--disable-gnutls`. > > I was trying to not carry over any "exception" type of arguments, > > unless they proved to be necessary.

[PATCH qemu v8 1/3] ppc/spapr: Move GPRs setup to one place

2020-03-09 Thread Alexey Kardashevskiy
At the moment "pseries" starts in SLOF which only expects the FDT blob pointer in r3. As we are going to introduce a OpenFirmware support in QEMU, we will be booting OF clients directly and these expect a stack pointer in r1, Linux looks at r3/r4 for the initramdisk location (although vmlinux can f

[PATCH qemu v8 0/3] spapr: Kill SLOF

2020-03-09 Thread Alexey Kardashevskiy
This is another attempt to implement minimalistic Open Firmware Client Interface in QEMU. v8 is simplified to only support -kernel/-initrd; this does not have early boot serial output (wait until Linux initializes the serial console). With this, I can boot unmodified Fedora 30 via petitboot passe

[PATCH qemu v8 2/3] spapr/cas: Separate CAS handling from rebuilding the FDT

2020-03-09 Thread Alexey Kardashevskiy
At the moment "ibm,client-architecture-support" ("CAS") is implemented in SLOF and QEMU assists via the custom H_CAS hypercall which copies an updated flatten device tree (FDT) blob to the SLOF memory which it then uses to update its internal tree. When we enable the OpenFirmware client interface

[PATCH qemu v8 3/3] spapr: Implement Open Firmware client interface

2020-03-09 Thread Alexey Kardashevskiy
The PAPR platform which describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require collaboration between the firmware and the hypervisor. Since the beginning, the runtime component of the firmware (RTAS) has been implemented as a 2

Re: [PATCH RESEND 2/3] vhost: fix a null pointer reference of vhost_log

2020-03-09 Thread Michael S. Tsirkin
On Mon, Feb 24, 2020 at 02:42:18PM +0800, Longpeng(Mike) wrote: > From: Longpeng > > vhost_log_alloc() may fails and returned pointer of log is null. > However there're two places derefernce the return pointer without > check. > > Signed-off-by: Longpeng > --- > hw/virtio/vhost.c | 19

Re: [PATCH v2 3/4] virtio-net: implement RX RSS processing

2020-03-09 Thread Michael S. Tsirkin
On Mon, Mar 09, 2020 at 10:34:37AM +0200, Yuri Benditovich wrote: > If VIRTIO_NET_F_RSS negotiated and RSS is enabled, process > incoming packets, calculate packet's hash and place the > packet into respective RX virtqueue. > > Signed-off-by: Yuri Benditovich > --- > hw/net/virtio-net.c

Re: [PATCH v2 4/4] virtio-net: block migration if RSS feature negotiated

2020-03-09 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 11:12:05AM +0800, Jason Wang wrote: > > On 2020/3/9 下午4:34, Yuri Benditovich wrote: > > Block migration for reference implementation of > > RSS feature in QEMU. When we add support for RSS > > on backend side, we'll implement migration of > > current RSS settings. > > > >

Re: [Question] About GET LBA STATUS(16) support in qemu scsi emulation layer

2020-03-09 Thread Lin Ma
First of all, Thanks for your reply, Stefan. We know that the GET LBA STATUS works well under scsi lun passthrough due to the vm directly talks to the scsi target. I'm curious that if I use file backend image(say qcow2) + qemu scsi emulation, Does it make sense if I issue sg_get_lba_status in vm

Re: [PATCH] docs/devel/qapi-code-gen: Fix typo in grammar

2020-03-09 Thread Markus Armbruster
Queued.

[PATCH v2] qom-qmp-cmds: fix two memleaks in qmp_object_add

2020-03-09 Thread Pan Nengyuan
'type/id' forgot to free in qmp_object_add, this patch fix that. The leak stack: Direct leak of 84 byte(s) in 6 object(s) allocated from: #0 0x7fe2a5ebf768 in __interceptor_malloc (/lib64/libasan.so.5+0xef768) #1 0x7fe2a505 in g_malloc (/lib64/libglib-2.0.so.0+0x52445) #2 0x7fe2a50

Re: [PATCH qemu v8 1/3] ppc/spapr: Move GPRs setup to one place

2020-03-09 Thread Cédric Le Goater
On 3/10/20 6:07 AM, Alexey Kardashevskiy wrote: > At the moment "pseries" starts in SLOF which only expects the FDT blob > pointer in r3. As we are going to introduce a OpenFirmware support in > QEMU, we will be booting OF clients directly and these expect a stack > pointer in r1, Linux looks at r3

Re: [PATCH v4 3/4] Introduce the NVMM impl

2020-03-09 Thread Maxime Villard
Le 02/03/2020 à 20:35, Paolo Bonzini a écrit : > > > Il lun 2 mar 2020, 20:28 Maxime Villard > ha scritto: > > > >> +        nvmm_vcpu_pre_run(cpu); > >> + > >> +        if (atomic_read(&cpu->exit_request)) { > >> +            qemu_cpu_kick_self(); >

Re: [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp

2020-03-09 Thread Vladimir Sementsov-Ogievskiy
08.03.2020 22:09, Christian Schoenebeck wrote: On Freitag, 6. März 2020 06:15:28 CET Vladimir Sementsov-Ogievskiy wrote: diff --git a/scripts/coccinelle/auto-propagated-errp.cocci b/scripts/coccinelle/auto-propagated-errp.cocci new file mode 100644 index 00..bff274bd6d --- /dev/null +++

<    1   2   3   4   5   6