Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements Message-id: 20200309235411.76587-1-liran.a...@oracle.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 9a5eea3 hw/i386/vmport: Assert vmport initialized before registering commands 1e6dd04 hw/i386/vmport: Add support for CMD_GETHZ 0ac0d03 i386/cpu: Store LAPIC bus frequency in CPU structure a7c67f7 hw/i386/vmport: Allow x2apic without IR 45a8906 hw/i386/vmport: Add support for CMD_GET_VCPU_INFO b2e5182 hw/i386/vmport: Add support for CMD_GETTIMEFULL 781c578 hw/i386/vmport: Add support for CMD_GETTIME b9766e1 hw/i386/vmport: Add support for CMD_GETBIOSUUID 45d84ea hw/i386/vmport: Define enum for all commands 4fd0f2a hw/i386/vmport: Report VMX type in CMD_GETVERSION fb9a37d hw/i386/vmport: Introduce vmx-version property 42c9b1b hw/i386/vmport: Add device properties ef80fe3 hw/i386/vmport: Set EAX to -1 on failed and unsupported commands 4f4c376 hw/i386/vmport: Propagate IOPort read to vCPU EAX register === OUTPUT BEGIN === 1/14 Checking commit 4f4c3766dab8 (hw/i386/vmport: Propagate IOPort read to vCPU EAX register) 2/14 Checking commit ef80fe384f2a (hw/i386/vmport: Set EAX to -1 on failed and unsupported commands) 3/14 Checking commit 42c9b1bcba22 (hw/i386/vmport: Add device properties) 4/14 Checking commit fb9a37d94ae8 (hw/i386/vmport: Introduce vmx-version property) 5/14 Checking commit 4fd0f2a4fbd8 (hw/i386/vmport: Report VMX type in CMD_GETVERSION) 6/14 Checking commit 45d84eaad9b8 (hw/i386/vmport: Define enum for all commands) 7/14 Checking commit b9766e1d7b89 (hw/i386/vmport: Add support for CMD_GETBIOSUUID) ERROR: "(foo*)" should be "(foo *)" #33: FILE: hw/i386/vmport.c:128: + uint32_t *uuid_parts = (uint32_t*)(qemu_uuid.data); total: 1 errors, 0 warnings, 39 lines checked Patch 7/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/14 Checking commit 781c5786106a (hw/i386/vmport: Add support for CMD_GETTIME) 9/14 Checking commit b2e51824129e (hw/i386/vmport: Add support for CMD_GETTIMEFULL) 10/14 Checking commit 45a8906700f6 (hw/i386/vmport: Add support for CMD_GET_VCPU_INFO) ERROR: return is not a function, parentheses are not required #41: FILE: hw/i386/vmport.c:185: + return (1 << VCPU_INFO_RESERVED_BIT); total: 1 errors, 0 warnings, 38 lines checked Patch 10/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/14 Checking commit a7c67f736cd1 (hw/i386/vmport: Allow x2apic without IR) 12/14 Checking commit 0ac0d0363873 (i386/cpu: Store LAPIC bus frequency in CPU structure) 13/14 Checking commit 1e6dd042d2a2 (hw/i386/vmport: Add support for CMD_GETHZ) 14/14 Checking commit 9a5eea388576 (hw/i386/vmport: Assert vmport initialized before registering commands) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200309235411.76587-1-liran.a...@oracle.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com