Better error messages, documentation tweaks to help
people follow the process for expected file updates.
Michael S. Tsirkin (5):
bios-tables-test: tell people how to update
bios-tables-test: fix up DIFF generation
bios-tables-test: default diff command
bios-tables-test: fix path to allowed
Most people probably just want diff -u. So let's use that
as the default.
Signed-off-by: Michael S. Tsirkin
---
tests/qtest/bios-tables-test.c | 27 ++-
1 file changed, 10 insertions(+), 17 deletions(-)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-table
For now just a pointer to the source file.
Signed-off-by: Michael S. Tsirkin
---
tests/qtest/bios-tables-test.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 3ab4872bd7..6b5f24bf62 100644
--- a/tests/q
Turns out it goes to stdout which is suppressed even with V=1.
Force DIFF output to stderr to make it visible.
Signed-off-by: Michael S. Tsirkin
---
tests/qtest/bios-tables-test.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qte
Fixes: 1e8a1fae7464 ("test: Move qtests to a separate directory")
Signed-off-by: Michael S. Tsirkin
---
tests/qtest/bios-tables-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 6ec1c5be64..6535ab7f04 1
On Tue, Jan 21, 2020 at 11:10:10PM -0800, no-re...@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20200122064907.512501-1-...@redhat.com/
>
>
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Type: series
> Message-id: 20
Drop a trailing whitespace. Make line shorter.
Fixes: 76525114736e8 ("vhost: Only align sections for vhost-user")
Signed-off-by: Michael S. Tsirkin
---
hw/virtio/vhost.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
index 25fd4691
Remind users of rebuild-expected-aml.sh about the process
to follow. Suppress the warning if allowed file list exists -
that's a big hint user is already aware of the process.
Signed-off-by: Michael S. Tsirkin
---
tests/data/acpi/rebuild-expected-aml.sh | 7 +++
1 file changed, 7 insertions(
On Wed, Jan 22, 2020 at 04:16:24PM +0900, David Stevens wrote:
> Define a mechanism for sharing objects between different virtio
> devices.
>
> Signed-off-by: David Stevens
> ---
> content.tex | 18 ++
> 1 file changed, 18 insertions(+)
>
> diff --git a/content.tex b/content.tex
On Wed, Jan 22, 2020 at 04:16:15PM +0900, David Stevens wrote:
> This RFC comes from the recent discussion on buffer sharing [1],
> specifically about the need to share resources between different
> virtio devices. For a concrete use case, this can be used to share
> virtio-gpu allocated buffers wi
On 22/01/2020 09:05, Michael S. Tsirkin wrote:
> For now just a pointer to the source file.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> tests/qtest/bios-tables-test.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-
On Wed, Jan 22, 2020 at 04:16:35PM +0900, David Stevens wrote:
> Signed-off-by: David Stevens
> ---
> virtio-gpu.tex | 30 ++
> 1 file changed, 30 insertions(+)
>
> diff --git a/virtio-gpu.tex b/virtio-gpu.tex
> index af4ca61..a1f0210 100644
> --- a/virtio-gpu.tex
> +
On 22/01/2020 09:06, Michael S. Tsirkin wrote:
> Fixes: 1e8a1fae7464 ("test: Move qtests to a separate directory")
> Signed-off-by: Michael S. Tsirkin
> ---
> tests/qtest/bios-tables-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/bios-tables-test.c b/
On 1/21/20 9:24 PM, Ian Jiang wrote:
> For FMV.W.X that moves the lower 32 bits of an integer register to a
> floating-point register, Rd should encoded with NoN-boxing scheme.
> Note: This applies to RV64 only.
>
> Signed-off-by: Ian Jiang
> ---
> target/riscv/insn_trans/trans_rvf.inc.c | 1 +
>
On Tue, 21 Jan 2020 20:31:48 +0100 (CET)
BALATON Zoltan wrote:
> On Tue, 21 Jan 2020, Igor Mammedov wrote:
> > If user provided non-sense RAM size, board will complain and
> > continue running with max RAM size supported or sometimes
> > crash like this:
> > %QEMU -M bamboo -m 1
> >exec.c:19
On Wed, Jan 15, 2020 at 07:23:14PM -0800, Raphael Norwitz wrote:
> > > +error_report("The VHOST_USER_PROTOCOL_F_CONFIGURE_SLOTS protocol
> > > "
> > > + "feature is not supported when the "
> > > + "VHOST_USER_PROTOCOL_F_REPLY_ACK features has also "
On 22/01/2020 09:05, Michael S. Tsirkin wrote:
> Turns out it goes to stdout which is suppressed even with V=1.
> Force DIFF output to stderr to make it visible.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> tests/qtest/bios-tables-test.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletio
On Tue, Jan 21, 2020 at 10:27:51PM -0300, Wainer dos Santos Moschetta wrote:
> +def test_aarch64_virt_kvm(self):
> +"""
> +:avocado: tags=arch:aarch64
> +:avocado: tags=machine:virt
> +:avocado: tags=accel:kvm
> +"""
> +self.do_test_aarch64_virt()
On Wed, Jan 22, 2020 at 10:00:01AM +0100, Laurent Vivier wrote:
> On 22/01/2020 09:05, Michael S. Tsirkin wrote:
> > Turns out it goes to stdout which is suppressed even with V=1.
> > Force DIFF output to stderr to make it visible.
> >
> > Signed-off-by: Michael S. Tsirkin
> > ---
> > tests/qtes
On 22/01/2020 02.27, Wainer dos Santos Moschetta wrote:
> Some acceptance tests require KVM or they are skipped. Travis
> enables nested virtualization by default with Ubuntu
> 18.04 (Bionic) on x86_64. So in order to run the kvm tests, this
> changed the acceptance builder to run in a Bionic VM. A
On 22/01/2020 09.05, Michael S. Tsirkin wrote:
> For now just a pointer to the source file.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> tests/qtest/bios-tables-test.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-
On 22/01/2020 09.06, Michael S. Tsirkin wrote:
> Fixes: 1e8a1fae7464 ("test: Move qtests to a separate directory")
> Signed-off-by: Michael S. Tsirkin
> ---
> tests/qtest/bios-tables-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/bios-tables-test.c b/
On 22/01/2020 02.27, Wainer dos Santos Moschetta wrote:
> Some acceptance tests require KVM or they are skipped. Travis
> enables nested virtualization by default with Ubuntu
> 18.04 (Bionic) on x86_64. So in order to run the kvm tests, this
> changed the acceptance builder to run in a Bionic VM. A
On Tue, Jan 21, 2020 at 07:49:39PM +0100, Kashyap Chamarthy wrote:
[...]
> +@item @code{taa-no}
> +
> +Recommended to inform that the guest that the host is @i{not} vulnerable
> +to CVE-2019-11135, TSX Asyncrnous Abort (TAA).
> +
> +This too is an MSR feature, so it does not show up in the Linux
Long delay, compliments of the season. My apologies!
Yury Kotov writes:
> The monitor_qmp_can_read (as a callback of qemu_chr_fe_set_handlers)
> should return size of buffer which monitor_qmp_read can process.
> Currently, monitor_can_read returns 1, because it guarantees that
> only one QMP co
* Michael S. Tsirkin (m...@redhat.com) wrote:
> Drop a trailing whitespace. Make line shorter.
>
> Fixes: 76525114736e8 ("vhost: Only align sections for vhost-user")
> Signed-off-by: Michael S. Tsirkin
Oops apologies for that.
Reviewed-by: Dr. David Alan Gilbert
> ---
> hw/virtio/vhost.c | 6
--
Ian Jiang
Richard Henderson 于2020年1月22日周三 下午4:53写道：
>
> On 1/21/20 9:24 PM, Ian Jiang wrote:
> > For FMV.W.X that moves the lower 32 bits of an integer register to a
> > floating-point register, Rd should encoded with NoN-boxing scheme.
> > Note: This applies to RV64 only.
> >
> > Signed-off-b
Am 22.01.2020 um 07:32 hat Markus Armbruster geschrieben:
> Kevin Wolf writes:
>
> > This patch adds a new 'coroutine' flag to QMP command definitions that
> > tells the QMP dispatcher that the command handler is safe to be run in a
> > coroutine.
>
> I'm afraid I missed this question in my revi
> > +When an object created by one virtio device needs to be
> > +shared with a seperate virtio device, the first device can
> > +export the object by generating a \field{uuid}
>
> This is a field where?
It's a property of the exported object, but I guess it doesn't really
correspond to any concre
The AIS feature has been disabled late in the v2.10 development cycle since
there were some issues with migration (see commit 3f2d07b3b01ea61126b -
"s390x/ais: for 2.10 stable: disable ais facility"). We originally wanted
to enable it again for newer machine types, but apparently we forgot to do
th
On 22.01.20 11:14, Thomas Huth wrote:
> The AIS feature has been disabled late in the v2.10 development cycle since
> there were some issues with migration (see commit 3f2d07b3b01ea61126b -
> "s390x/ais: for 2.10 stable: disable ais facility"). We originally wanted
> to enable it again for newer ma
When we are copying we want to ensure we grab the first
resolution (the found in path section). However even that binary might
be a symlink so lets make sure we chase the symlinks to copy the right
binary to where it can be found.
Signed-off-by: Alex Bennée
---
tests/docker/docker.py | 3 ++-
1
From: Thomas Huth
iotest 147 and 205 have recently been marked as "NBD-only", so they
are currently simply skipped and thus can be removed.
iotest 129 occasionally fails in the gitlab-CI, and according to Max,
there are some known issues with this test (see for example this URL:
https://lists.no
Hi,
There isn't much in my queue at the moment. The move of the various
compilers to buster fixes one of the shippable problems. I have a
longer series cooking to support multiarch docker builds which I'll
try and get posted by the end of this week.
Alex Bennée (2):
tests/docker: move most cros
This includes fixing up the dependencies (Which were already wrong for
one of the mips variants).
Signed-off-by: Alex Bennée
---
tests/docker/Makefile.include| 16
tests/docker/dockerfiles/debian-amd64.docker | 2 +-
.../docker/dockerfiles/debian-armel-c
On Wed, 22 Jan 2020 17:50:28 +1100
David Gibson wrote:
> On Tue, Jan 21, 2020 at 10:32:55AM +0100, Greg Kurz wrote:
> > On Tue, 21 Jan 2020 14:43:32 +1100
> > David Gibson wrote:
> >
> > > On Mon, Jan 20, 2020 at 09:04:38AM +0100, Greg Kurz wrote:
> > > > On Fri, 17 Jan 2020 16:44:27 +0100
> >
Michael S. Tsirkin writes:
> Drop a trailing whitespace. Make line shorter.
>
> Fixes: 76525114736e8 ("vhost: Only align sections for vhost-user")
> Signed-off-by: Michael S. Tsirkin
Reviewed-by: Alex Bennée
> ---
> hw/virtio/vhost.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletio
Philippe Mathieu-Daudé writes:
> Missed in 870c034da0b, hopefully reported by Coverity.
>
> Fixes: Coverity CID 1412793 (Incorrect expression)
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
> ---
> hw/misc/stm32f4xx_syscfg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 del
On Wed, 22 Jan 2020 11:14:37 +0100
Thomas Huth wrote:
> The AIS feature has been disabled late in the v2.10 development cycle since
> there were some issues with migration (see commit 3f2d07b3b01ea61126b -
> "s390x/ais: for 2.10 stable: disable ais facility"). We originally wanted
> to enable it
On 22.01.20 11:29, Cornelia Huck wrote:
> On Wed, 22 Jan 2020 11:14:37 +0100
> Thomas Huth wrote:
>
>> The AIS feature has been disabled late in the v2.10 development cycle since
>> there were some issues with migration (see commit 3f2d07b3b01ea61126b -
>> "s390x/ais: for 2.10 stable: disable ais
On 22/01/2020 11.29, Cornelia Huck wrote:
> On Wed, 22 Jan 2020 11:14:37 +0100
> Thomas Huth wrote:
>
>> The AIS feature has been disabled late in the v2.10 development cycle since
>> there were some issues with migration (see commit 3f2d07b3b01ea61126b -
>> "s390x/ais: for 2.10 stable: disable a
> ok but how is this then used? will there be more commands to pass
> this uuid to another device?
This is intended to be used with the virtio video device being
discussed here https://markmail.org/thread/ingyqlps4rbcuazh. I don't
have a specific patch for how that will work, but it will likely be
* Xiao Yang (yangx...@cn.fujitsu.com) wrote:
> On 2020/1/21 20:22, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > There's a lot of the original fuse code we don't need; trim them down.
> Hi Dave,
>
> enum fuse_buf_copy_flags is not used by the v2 patch so I think w
Marc-André Lureau writes:
> Hi
>
> On Tue, Jan 21, 2020 at 7:01 PM Markus Armbruster wrote:
>> Daniel P. Berrangé writes:
>> > On Tue, Jan 21, 2020 at 02:36:17PM +0100, Markus Armbruster wrote:
>> >> static const TypeInfo char_type_info = {
>> >> .name = TYPE_FOO,
>> >> .
On Wed, Jan 22, 2020 at 07:13:41PM +0900, David Stevens wrote:
> > > +When an object created by one virtio device needs to be
> > > +shared with a seperate virtio device, the first device can
> > > +export the object by generating a \field{uuid}
> >
> > This is a field where?
>
> It's a property o
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Juan Quintela
---
migration/ram.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index d2208b5534..f95d656c26 100644
--- a/migration/ram
Hi
In the v4 series:
* Updated to latest pull request
* redo the check for active migration at the end of the iteration stage
* testing/testing/testing it now passes the test for multifd + cancel
hundred of times in a row
* Use g_free consistently
Please review, Juan.
In the v3 series:
- Add b
Be sure that we are not doing neither read/write after shutdown of the
QEMUFile.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Juan Quintela
---
Set error in case that there is none (dave)
---
migration/qemu-file.c | 22 +-
1 file changed
If we do a cancel, we got out without one error, but we can't do the
rest of the output as in a normal situation.
Signed-off-by: Juan Quintela
---
migration/ram.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/migration/ram.c b/migration/ram.c
index f95d656c26..3fd7fdffcf
This function returns if we are in the middle of a migration.
It is like migration_is_setup_or_active() with CANCELLING and COLO.
Adapt all calers that are needed.
Signed-off-by: Juan Quintela
---
migration/migration.c | 29 -
migration/migration.h | 1 +
migration/s
Signed-off-by: Juan Quintela
---
tests/qtest/migration-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 26e2e77289..b6a74a05ce 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@
Test that this sequerce works:
- launch source
- launch target
- start migration
- cancel migration
- relaunch target
- do migration again
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Juan Quintela
---
- Wait for 1st trhead to move to cancelled before launc
** Changed in: maas
Status: Incomplete => New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1859656
Title:
[2.6] Unable to reboot s390x KVM machine after initial deploy
Status in MAAS:
Ne
On Tue, Jan 21, 2020 at 03:07:53PM +0100, Aleksandar Markovic wrote:
> On Mon, Jan 20, 2020 at 3:51 PM Stefan Hajnoczi wrote:
> >
> > On Sat, Jan 18, 2020 at 03:08:37PM +0100, Aleksandar Markovic wrote:
> > > 3) The community will be given all devised performance measurement
> > > methods in the
This series adds emulation of TIME CSRs for privileged mode. With
this series, we see approximately 25+% improvement in hackbench
numbers for non-virtualized (or Host) Linux and 40+% improvement
in hackbench numbers for Guest/VM Linux.
These patches are based on mainline/alistair/riscv-hyp-ext-v0.
Currently, TIME CSRs are emulated only for user-only mode. This
patch add TIME CSRs emulation for privileged mode.
For privileged mode, the TIME CSRs will return value provided
by rdtime callback which is registered by QEMU machine/platform
emulation (i.e. CLINT emulation). If rdtime callback is n
On Wed, Jan 22, 2020 at 03:08:49AM -0500, Michael S. Tsirkin wrote:
> Drop a trailing whitespace. Make line shorter.
>
> Fixes: 76525114736e8 ("vhost: Only align sections for vhost-user")
> Signed-off-by: Michael S. Tsirkin
> ---
> hw/virtio/vhost.c | 6 +++---
> 1 file changed, 3 insertions(+),
This patch extends CLINT emulation to provide rdtime callback for
TCG. This rdtime callback will be called wheneven TIME CSRs are
read in privileged modes.
Signed-off-by: Anup Patel
Reviewed-by: Alistair Francis
---
hw/riscv/sifive_clint.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/
On Fri, 17 Jan 2020 15:08:55 +0530
Ganesh Goudar wrote:
> From: Aravinda Prasad
>
> This patch sets the default value of SPAPR_CAP_FWNMI_MCE
> to SPAPR_CAP_ON for machine type 4.2.
>
Now that 4.2 has been released, we want this for 5.0...
> Signed-off-by: Aravinda Prasad
> Signed-off-by: Ga
On Thu, Nov 7, 2019 at 10:22 PM Palmer Dabbelt wrote:
>
> On Wed, 06 Nov 2019 03:56:29 PST (-0800), Anup Patel wrote:
> > This series adds RTC device to QEMU RISC-V virt machine. We have
> > selected Goldfish RTC device model for this. It's a pretty simple
> > synthetic device with few MMIO regist
On 23.12.2019 20:51, Alexander Popov wrote:
> Fuzzing the Linux kernel with syzkaller allowed to find how to crash qemu
> using a special SCSI_IOCTL_SEND_COMMAND. It hits the assertion in
> ide_dma_cb() introduced in the commit a718978ed58a in July 2015.
>
> This patch series fixes incorrect handl
Around 66% of qemu.git commits since v4.1.0 include a Message-Id: tag. Hooray!
Message-Id: references the patch email that a commit was merged from.
This information is helpful to anyone wishing to refer back to email
discussions and patch series.
Please use git-am(1) -m/--message-id or set am.m
Kevin Wolf writes:
> Am 22.01.2020 um 07:32 hat Markus Armbruster geschrieben:
>> Kevin Wolf writes:
>>
>> > This patch adds a new 'coroutine' flag to QMP command definitions that
>> > tells the QMP dispatcher that the command handler is safe to be run in a
>> > coroutine.
>>
>> I'm afraid I m
Am 22.01.2020 um 12:53 hat Alexander Popov geschrieben:
> On 23.12.2019 20:51, Alexander Popov wrote:
> > Fuzzing the Linux kernel with syzkaller allowed to find how to crash qemu
> > using a special SCSI_IOCTL_SEND_COMMAND. It hits the assertion in
> > ide_dma_cb() introduced in the commit a718978
Alex Bennée writes:
> Marc-André Lureau writes:
>> Actually, we are not that far off from being able to use GObject
>> altogether (I hacked something like that to play with), but I
>> disgress...
>
> As a mostly hands off observer who mainly c&p's QOM code when he has to
> I have to ask is this
Am 22.01.2020 um 13:02 hat Stefan Hajnoczi geschrieben:
> Around 66% of qemu.git commits since v4.1.0 include a Message-Id: tag.
> Hooray!
>
> Message-Id: references the patch email that a commit was merged from.
> This information is helpful to anyone wishing to refer back to email
> discussion
Stefan Hajnoczi writes:
> Around 66% of qemu.git commits since v4.1.0 include a Message-Id: tag.
> Hooray!
>
> Message-Id: references the patch email that a commit was merged from.
> This information is helpful to anyone wishing to refer back to email
> discussions and patch series.
So I gue
On 22/01/2020 12.15, Juan Quintela wrote:
> Signed-off-by: Juan Quintela
> ---
> tests/qtest/migration-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index 26e2e77289..b6a74a05ce 100644
> --- a/tests/q
Hi
On Wed, Jan 22, 2020 at 4:25 PM Markus Armbruster wrote:
>
> Alex Bennée writes:
>
> > Marc-André Lureau writes:
> >> Actually, we are not that far off from being able to use GObject
> >> altogether (I hacked something like that to play with), but I
> >> disgress...
> >
> > As a mostly hands
On Wed, 15 Jan 2020 19:10:47 +0100
Cédric Le Goater wrote:
> On 1/15/20 6:48 PM, Greg Kurz wrote:
> > Migration can potentially race with CAS reboot. If the migration thread
> > completes migration after CAS has set spapr->cas_reboot but before the
> > mainloop could pick up the reset request and
On 1/22/20 6:08 AM, Michael S. Tsirkin wrote:
Drop a trailing whitespace. Make line shorter.
hmmm... wondering why Patchew didn't catch that. Any idea?
- Wainer
Fixes: 76525114736e8 ("vhost: Only align sections for vhost-user")
Signed-off-by: Michael S. Tsirkin
---
hw/virtio/vhost.c |
According to the description of "ibm,client-architecture-support" that
can found in LoPAPR "B.6.2.3 Root Node Methods":
If multiple partition processors or threads are active at the time of
the ibm,client-architecture-support method call, or an error is detected
in the format of the ibm,architectu
The SiFive test device found on virt machine can be used by
generic syscon reboot and poweroff drivers available in Linux
kernel.
This patch updates FDT generation in virt machine so that
Linux kernel can probe and use generic syscon drivers.
Signed-off-by: Anup Patel
---
Changes since v1:
- Re
If only bitmaps postcopy migration enabled and not ram, this assertion
will fire, as we don't have to_src_file for bitmaps postcopy migration.
migrate_postcopy_ram() accesses migrations state, which may be freed in
main thread, so, we should ref/unref it in postcopy incoming thread.
Signed-off-by
Keep bitmap state for disabled bitmaps too. Keep the state until the
end of the process. It's needed for the following commit to implement
bitmap postcopy canceling.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
migration/block-dirty-bitmap.c | 59 ++
1 file cha
Hi all!
Patches 5 and 6 fixes two crashes, triggered by new test case in patch
7.
Vladimir Sementsov-Ogievskiy (7):
migration/block-dirty-bitmap: refactor incoming state to be one struct
migration/block-dirty-bitmap: rename finish_lock to just lock
migration/block-dirty-bitmap: simplify dir
Previous patches fixed two crashes which may occur on shutdown prior to
bitmaps postcopy finished. Check that it works now.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/199 | 12 +++-
tests/qemu-iotests/199.out | 4 ++--
2 files changed, 13 insertions(+), 3 del
On 1/22/20 8:22 AM, Alex Bennée wrote:
When we are copying we want to ensure we grab the first
resolution (the found in path section). However even that binary might
be a symlink so lets make sure we chase the symlinks to copy the right
binary to where it can be found.
Signed-off-by: Alex Benn
finish_lock is bad name, as lock used not only on process end.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
migration/block-dirty-bitmap.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c
index 281
bdrv_enable_dirty_bitmap_locked() call does nothing, as if we are in
postcopy, bitmap successor must be enabled, and reclaim operation will
enable the bitmap.
So, actually we need just call _reclaim_ in both if branches, and
making differences only to add an assertion seems not really good. The
lo
If target is turned of prior to postcopy finished, we crash because
busy bitmaps are found at shutdown.
Let's fix it by removing all unfinished bitmaps on shutdown.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
migration/migration.h | 1 +
migration/block-dirty-bitmap.c | 44 +++
Move enabled_bitmaps and finish_lock, which are part of incoming state
to DirtyBitmapLoadState, and make static global variable to store state
instead of static local one.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
migration/block-dirty-bitmap.c | 77 +++---
1 fi
On Wed, 22 Jan 2020 at 12:42, Marc-André Lureau
wrote:
> From the top of my mind, this is the pain point when trying to use GObject:
> - static/inlined object, not supported by GObject, unlikely to ever be
> - few users in qemu, transition possible.
Isn't there lots of use of this in the device e
Peter Maydell writes:
> The qemu-nbd documentation is currently in qemu-nbd.texi in Texinfo
> format, which we present to the user as:
> * a qemu-nbd manpage
> * a section of the main qemu-doc HTML documentation
>
> Convert the documentation to rST format, and present it to the user as:
> *
Hi
On Wed, Jan 22, 2020 at 5:28 PM Peter Maydell wrote:
>
> On Wed, 22 Jan 2020 at 12:42, Marc-André Lureau
> wrote:
> > From the top of my mind, this is the pain point when trying to use GObject:
> > - static/inlined object, not supported by GObject, unlikely to ever be
> > - few users in qemu,
Hi Alex,
On 1/22/20 8:22 AM, Alex Bennée wrote:
Hi,
There isn't much in my queue at the moment. The move of the various
compilers to buster fixes one of the shippable problems. I have a
longer series cooking to support multiarch docker builds which I'll
try and get posted by the end of this wee
The qtests have recently been moved to a separate subdirectory, so
the paths that are mentioned in the documentation have to be adjusted
accordingly. And some of the iotests are now always run as part of
"make check", so this information has to be adjusted here, too.
Signed-off-by: Thomas Huth
--
On Wed, Jan 22, 2020 at 11:06:53AM -0200, Wainer dos Santos Moschetta wrote:
>
> On 1/22/20 6:08 AM, Michael S. Tsirkin wrote:
> > Drop a trailing whitespace. Make line shorter.
>
>
> hmmm... wondering why Patchew didn't catch that. Any idea?
>
> - Wainer
It did.
> >
> > Fixes: 76525114736e8
On 10/01/2020 20.12, Wainer dos Santos Moschetta wrote:
> The genisoimage program is required for tests/cdrom-test
> tests, otherwise they are skipped. The current Travis
> environments do not provide it by default, so let's
> explicitly require the genisoimage package.
>
> Signed-off-by: Wainer d
On Wed, 22 Jan 2020 12:30:03 +
Alex Bennée wrote:
> Stefan Hajnoczi writes:
>
> > Around 66% of qemu.git commits since v4.1.0 include a Message-Id: tag.
> > Hooray!
> >
> > Message-Id: references the patch email that a commit was merged from.
> > This information is helpful to anyone wish
Public bug reported:
I tried building cmake on Debian unstable for Alpha today using qemu-
user and the compiled cmake binary crashed with "Illegal Instruction":
g++ -Wl,-z,relro -Wl,--as-needed -g -O2 -fdebug-prefix-map=/<>=.
-Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2
Le 18/01/2020 à 00:02, Richard Henderson a écrit :
> With bad luck, we can wind up with no space at all for brk,
> which will generally cause the guest malloc to fail.
>
> This bad luck is easier to come by with ET_DYN (PIE) binaries,
> where either the stack or the interpreter (ld.so) gets placed
Le 16/01/2020 à 23:49, Aleksandar Markovic a écrit :
> From: Aleksandar Markovic
>
> A very specific thing for these two ioctls is that their code
> implies that their third argument is of type 'long', but the
> kernel uses that argument as if it is of type 'int'. This anomaly
> is recognized als
Le 16/01/2020 à 23:49, Aleksandar Markovic a écrit :
> From: Aleksandar Markovic
>
> These FS_IOC32_FLAGS ioctls are identical to
> FS_IOC_FLAGS ioctls, but without the anomaly of their
> number defined as if their third argument is of type long, while
> it is treated internally in kernel as is o
Le 16/01/2020 à 23:49, Aleksandar Markovic a écrit :
> From: Aleksandar Markovic
>
> These FS_IOC32_VERSION ioctls are identical to
> FS_IOC_VERSION ioctls, but without the anomaly of their
> number defined as if their third argument is of type long, while
> it is treated internally in kernel as
On 1/22/20 1:47 PM, Greg Kurz wrote:
> On Wed, 15 Jan 2020 19:10:47 +0100
> Cédric Le Goater wrote:
>
>> On 1/15/20 6:48 PM, Greg Kurz wrote:
>>> Migration can potentially race with CAS reboot. If the migration thread
>>> completes migration after CAS has set spapr->cas_reboot but before the
>>>
On 01/22/20 13:30, Alex Bennée wrote:
>
> Stefan Hajnoczi writes:
>
>> Around 66% of qemu.git commits since v4.1.0 include a Message-Id: tag.
>> Hooray!
>>
>> Message-Id: references the patch email that a commit was merged from.
>> This information is helpful to anyone wishing to refer back to
On Tue, 21 Jan 2020 00:50:33 +0100
Christian Schoenebeck wrote:
> A good 9p client sends T_readdir with "count" parameter that's sufficiently
> smaller than client's initially negotiated msize (maximum message size).
> We perform a check for that though to avoid the server to be interrupted
> wit
Le 16/01/2020 à 23:49, Aleksandar Markovic a écrit :
> From: Aleksandar Markovic
>
> kcov is kernel code coverage tracing tool. It requires kernel 4.4+
> compiled with certain kernel options.
>
> This patch checks if kcov header "sys/kcov.h" is present on build
> machine, and stores the result i
Le 16/01/2020 à 23:49, Aleksandar Markovic a écrit :
> From: Aleksandar Markovic
>
> FDSETEMSGTRESH, FDSETMAXERRS, and FDGETMAXERRS ioctls are commands
> for controlling error reporting of a floppy drive.
>
> FDSETEMSGTRESH's third agrument is a pointer to the structure:
>
> struct floppy_max_e
1 - 100 of 287 matches
Mail list logo
