On Tue, Jan 21, 2020 at 11:10:10PM -0800, no-re...@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20200122064907.512501-1-...@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 20200122064907.512501-1-...@redhat.com > Subject: [PULL v2 00/17] virtio, pc: fixes, features > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > ./scripts/checkpatch.pl --mailback base.. > === TEST SCRIPT END === > > From https://github.com/patchew-project/qemu > * [new tag] patchew/20200122064907.512501-1-...@redhat.com -> > patchew/20200122064907.512501-1-...@redhat.com > Switched to a new branch 'test' > 920a20e i386:acpi: Remove _HID from the SMBus ACPI entry > cd87503 vhost: Only align sections for vhost-user > 9ef0893 vhost: Add names to section rounded warning > 61681af vhost-vsock: delete vqs in vhost_vsock_unrealize to avoid memleaks > ee96146 virtio-scsi: convert to new virtio_delete_queue > c221c38 virtio-scsi: delete vqs in unrealize to avoid memleaks > 4a878a8 virtio-9p-device: convert to new virtio_delete_queue > addbaec virtio-9p-device: fix memleak in virtio_9p_device_unrealize > 9a05a8d bios-tables-test: document expected file update > 0478609 acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command > 5765438 acpi: cpuhp: spec: add typical usecases > 23f1ef6 acpi: cpuhp: introduce 'Command data 2' field > aa3f3fa acpi: cpuhp: spec: clarify store into 'Command data' when 'Command > field' == 0 > a245ce7 acpi: cpuhp: spec: fix 'Command data' description > d310d0d acpi: cpuhp: spec: clarify 'CPU selector' register usage and > endianness > b6b3688 tests: q35: MCH: add default SMBASE SMRAM lock test > 522df3f q35: implement 128K SMRAM at default SMBASE address > > === OUTPUT BEGIN === > 1/17 Checking commit 522df3f88659 (q35: implement 128K SMRAM at default > SMBASE address) > 2/17 Checking commit b6b368876a2f (tests: q35: MCH: add default SMBASE SMRAM > lock test) > 3/17 Checking commit d310d0d464eb (acpi: cpuhp: spec: clarify 'CPU selector' > register usage and endianness) > 4/17 Checking commit a245ce7de00c (acpi: cpuhp: spec: fix 'Command data' > description) > 5/17 Checking commit aa3f3fa5fc4e (acpi: cpuhp: spec: clarify store into > 'Command data' when 'Command field' == 0) > 6/17 Checking commit 23f1ef67a7a0 (acpi: cpuhp: introduce 'Command data 2' > field) > 7/17 Checking commit 5765438a9869 (acpi: cpuhp: spec: add typical usecases) > 8/17 Checking commit 04786095aecf (acpi: cpuhp: add CPHP_GET_CPU_ID_CMD > command) > 9/17 Checking commit 9a05a8d4907a (bios-tables-test: document expected file > update) > WARNING: line over 80 characters > #23: FILE: tests/qtest/bios-tables-test.c:20: > + * Contributor or ACPI Maintainer (steps 4-7 need to be redone to resolve > conflicts > > total: 0 errors, 1 warnings, 38 lines checked > > Patch 9/17 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 10/17 Checking commit addbaecb1d51 (virtio-9p-device: fix memleak in > virtio_9p_device_unrealize) > 11/17 Checking commit 4a878a8af35b (virtio-9p-device: convert to new > virtio_delete_queue) > 12/17 Checking commit c221c38c4eb0 (virtio-scsi: delete vqs in unrealize to > avoid memleaks) > 13/17 Checking commit ee961460de93 (virtio-scsi: convert to new > virtio_delete_queue) > 14/17 Checking commit 61681af92804 (vhost-vsock: delete vqs in > vhost_vsock_unrealize to avoid memleaks) > 15/17 Checking commit 9ef0893d58b6 (vhost: Add names to section rounded > warning) > 16/17 Checking commit cd875038bb0f (vhost: Only align sections for vhost-user) > ERROR: trailing whitespace > #49: FILE: hw/virtio/vhost.c:554: > + if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) { $ > > WARNING: line over 80 characters > #64: FILE: hw/virtio/vhost.c:569: > + trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa, > mrs_size, > > total: 1 errors, 1 warnings, 43 lines checked > > Patch 16/17 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > 17/17 Checking commit 920a20e6fd35 (i386:acpi: Remove _HID from the SMBus > ACPI entry)
This is benighn, will fix with a follow-up patch. > === OUTPUT END === > > Test command exited with code: 1 > > > The full log is available at > http://patchew.org/logs/20200122064907.512501-1-...@redhat.com/testing.checkpatch/?type=message. > --- > Email generated automatically by Patchew [https://patchew.org/]. > Please send your feedback to patchew-de...@redhat.com
