Re: [PATCH] virtio: fix IO request length in virtio SCSI/block #PSBM-78839

2019-12-05 Thread Denis Plotnikov
Ping! On 25.11.2019 12:16, Denis Plotnikov wrote: > > > On 06.11.2019 15:03, Michael S. Tsirkin wrote: >> On Thu, Oct 24, 2019 at 11:34:34AM +, Denis Lunev wrote: >>> On 10/24/19 12:28 AM, Michael S. Tsirkin wrote: On Fri, Oct 18, 2019 at 02:55:47PM +0300, Denis Plotnikov wrote: > Fro

Re: [PATCH v2] Revert "qemu-options.hx: Update for reboot-timeout parameter"

2019-12-05 Thread Markus Armbruster
Han Han writes: > This reverts commit bbd9e6985ff342cbe15b9cb7eb30e842796fbbe8. > > In 20a1922032 we allowed reboot-timeout=-1 again, so update the doc > accordingly. > > Signed-off-by: Han Han > --- > qemu-options.hx | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/

Re: [PATCH 4/5] hw/arm/smmuv3: Use correct bit positions in EVT_SET_ADDR2 macro

2019-12-05 Thread Auger Eric
Hi Simon, On 12/4/19 2:55 PM, Simon Veith wrote: > The bit offsets in the EVT_SET_ADDR2 macro do not match those specified > in the ARM SMMUv3 Architecture Specification. In all events that use > this macro, e.g. F_WALK_EABT, the faulting fetch address or IPA actually > occupies the 32-bit words 6

Re: [PATCH 5/5] hw/arm/smmuv3: Report F_STE_FETCH fault address in correct word position

2019-12-05 Thread Auger Eric
Hi Simon, On 12/4/19 2:55 PM, Simon Veith wrote: > The smmuv3_record_event() function that generates the F_STE_FETCH error > uses the EVT_SET_ADDR macro to record the fetch address, placing it in > 32-bit words 4 and 5. > > The correct position for this address is in words 6 and 7, per the > SMMU

Re: [PATCH 2/5] hw/arm/smmuv3: Check stream IDs against actual table LOG2SIZE

2019-12-05 Thread Auger Eric
Hi Simon, On 12/4/19 2:55 PM, Simon Veith wrote: > When checking whether a stream ID is in range of the stream table, we > have so far been only checking it against our implementation limit > (SMMU_IDR1_SIDSIZE). However, the guest can program the > STRTAB_BASE_CFG.LOG2SIZE field to a size that is

Re: [PATCH 1/5] hw/arm/smmuv3: Apply address mask to linear strtab base address

2019-12-05 Thread Auger Eric
Hi Simon, On 12/4/19 2:55 PM, Simon Veith wrote: > In the SMMU_STRTAB_BASE register, the stream table base address only > occupies bits [51:6]. Other bits, such as RA (bit [62]), must be masked > out to obtain the base address. > > The branch for 2-level stream tables correctly applies this mask

Re: [PATCH RESEND 4/4] target/i386: Add notes for versioned CPU models

2019-12-05 Thread Xiaoyao Li
On 12/2/2019 2:32 PM, Tao Xu wrote: Add which features are added or removed in this version. Remove the changed model-id in versioned CPU models. Signed-off-by: Tao Xu --- target/i386/cpu.c | 50 +++ 1 file changed, 25 insertions(+), 25 deletions(-

Re: [PULL v2 4/6] spapr: Add /chosen to FDT only at reset time to preserve kernel and initramdisk

2019-12-05 Thread Laurent Vivier
On 05/12/2019 05:26, Alexey Kardashevskiy wrote: > > > On 04/12/2019 21:32, Laurent Vivier wrote: >> On 04/12/2019 05:40, Alexey Kardashevskiy wrote: >>> >>> >>> On 04/12/2019 15:23, Alexey Kardashevskiy wrote: On 04/12/2019 03:09, Laurent Vivier wrote: > > Bad reply, the p

Re: [PATCH RESEND 0/4] Add extra information to versioned CPU models

2019-12-05 Thread Xiaoyao Li
On 12/2/2019 2:32 PM, Tao Xu wrote: This series of patches will remove MPX from Denverton, remove Remove monitor from some CPU models. Add additional information for -cpu help to indicate the changes in this version of CPU model. The output is as follows: x86_64-softmmu/qemu-system-x86_64 -cpu h

Re: [RFC PATCH 0/9] Introduce mediate ops in vfio-pci

2019-12-05 Thread Yan Zhao
On Thu, Dec 05, 2019 at 02:33:19PM +0800, Jason Wang wrote: > Hi: > > On 2019/12/5 上午11:24, Yan Zhao wrote: > > For SRIOV devices, VFs are passthroughed into guest directly without host > > driver mediation. However, when VMs migrating with passthroughed VFs, > > dynamic host mediation is required

Re: [PATCH v6 0/9] Clock framework API

2019-12-05 Thread Damien Hedde
On 12/4/19 9:34 PM, Philippe Mathieu-Daudé wrote: > On 12/4/19 5:40 PM, Damien Hedde wrote: >> On 12/2/19 5:15 PM, Peter Maydell wrote: >>> >>> The one topic I think we could do with discussing is whether >>> a simple uint64_t giving the frequency of the clock in Hz is >>> the right representati

Re: [RFC v5 024/126] error: auto propagated local_err

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
04.12.2019 17:59, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of >> functions with errp OUT parameter. >> >> It has three goals: >> >> 1. Fix issue with error_fatal & error_prepend/error_append_hint: user >

Re: [PATCH v7] Implement backend program convention command for vhost-user-blk

2019-12-05 Thread Micky C
Ping again On Mon, Dec 2, 2019 at 9:53 AM Micky C wrote: > Ping > > On Mon, Nov 25, 2019 at 1:17 PM Micky Yun Chan(michiboo) < > chanmicky...@gmail.com> wrote: > >> From: Micky Yun Chan >> >> This patch is to add standard commands defined in >> docs/interop/vhost-user.rst >> For vhost-user-* pr

Re: [PATCH v5 1/2] block/nbd: extract the common cleanup code

2019-12-05 Thread Stefano Garzarella
Hi Pan, On Thu, Dec 05, 2019 at 11:45:27AM +0800, pannengy...@huawei.com wrote: > From: Pan Nengyuan > > The BDRVNBDState cleanup code is common in two places, add > nbd_clear_bdrvstate() function to do these cleanups. > > Signed-off-by: Stefano Garzarella I only suggested this change, so I t

Re: [PATCH v5 2/2] block/nbd: fix memory leak in nbd_open()

2019-12-05 Thread Stefano Garzarella
On Thu, Dec 05, 2019 at 11:45:28AM +0800, pannengy...@huawei.com wrote: > From: Pan Nengyuan > > In currently implementation there will be a memory leak when > nbd_client_connect() returns error status. Here is an easy way to > reproduce: > > 1. run qemu-iotests as follow and check the result wi

[PATCH v1] intel_iommu: fix bug to read DMAR_RTADDR_REG

2019-12-05 Thread Yi Sun
Should directly read DMAR_RTADDR_REG but not using 's->root'. Because 's->root' is modified in 'vtd_root_table_setup()' so that the first 12 bits are omitted. This causes the guest iommu debugfs cannot show pasid tables. Signed-off-by: Yi Sun --- hw/i386/intel_iommu.c | 7 +++ 1 file changed

Re: [PATCH v6 0/9] Clock framework API

2019-12-05 Thread Philippe Mathieu-Daudé
On 12/5/19 10:36 AM, Damien Hedde wrote: On 12/4/19 9:34 PM, Philippe Mathieu-Daudé wrote: On 12/4/19 5:40 PM, Damien Hedde wrote: On 12/2/19 5:15 PM, Peter Maydell wrote: The one topic I think we could do with discussing is whether a simple uint64_t giving the frequency of the clock in Hz is

[Bug 1846427] Re: 4.1.0: qcow2 corruption on savevm/quit/loadvm cycle

2019-12-05 Thread Matti Hameister
The qemu 4.1.0 upgrade killed pretty much all my VMs. I had data corruption (i.e. tar was unable to extract some larger data archives for testing purposes) in all my Linux VMs and other strange errors. The Windows VM was killed after I ran "qemu-img check -r all" on the image. Afterwards Windows wa

Re: [PATCH v3 4/4] pc-bios/s390x: Fix reset psw mask

2019-12-05 Thread Cornelia Huck
On Tue, 3 Dec 2019 08:28:13 -0500 Janosch Frank wrote: > We need to set the short psw indication bit in the reset psw, as it is > a short psw. > > fixes: 9629823290 ("pc-bios/s390-ccw: do a subsystem reset before running the > guest") > Signed-off-by: Janosch Frank > --- > pc-bios/s390-ccw/j

Re: [PATCH v6 0/9] Clock framework API

2019-12-05 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > On 12/5/19 10:36 AM, Damien Hedde wrote: > > On 12/4/19 9:34 PM, Philippe Mathieu-Daudé wrote: > > > On 12/4/19 5:40 PM, Damien Hedde wrote: > > > > On 12/2/19 5:15 PM, Peter Maydell wrote: > > > > > > > > > > The one topic I think we could do

Re: [Qemu-devel] [PATCH v27 5/8] target/avr: Add limited support for USART and 16 bit timer peripherals

2019-12-05 Thread Aleksandar Markovic
On Thursday, July 25, 2019, Pavel Dovgalyuk wrote: > > From: Qemu-devel [mailto:qemu-devel-bounces+patchwork-qemu- > > devel=patchwork.kernel@nongnu.org] On Behalf Of Michael Rolnik > > From: Sarah Harris > > > > These were designed to facilitate testing but should provide enough > function

[PATCH] migration: Rate limit inside host pages

2019-12-05 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" When using hugepages, rate limiting is necessary within each huge page, since a 1G huge page can take a significant time to send, so you end up with bursty behaviour. Fixes: 4c011c37ecb3 ("postcopy: Send whole huge pages") Reported-by: Lin Ma Signed-off-by: Dr. Da

Re: 回复: 答复: [Qemu-devel] migrate_set_speed has no effect if the guest is using hugepages.

2019-12-05 Thread Dr. David Alan Gilbert
Hi Lin, I've just posted 'migration: Rate limit inside host pages'; please let me know if it helps for you. Dave -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH v27 5/8] target/avr: Add limited support for USART and 16 bit timer peripherals

2019-12-05 Thread Aleksandar Markovic
On Thursday, December 5, 2019, Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > > > On Thursday, July 25, 2019, Pavel Dovgalyuk wrote: > >> > From: Qemu-devel [mailto:qemu-devel-bounces+patchwork-qemu- >> > devel=patchwork.kernel@nongnu.org] On Behalf Of Michael Rolnik >> > From: S

[PATCH] s390x/tcg: clear local interrupts on reset normal

2019-12-05 Thread Cornelia Huck
We neglected to clean up pending interrupts and emergency signals; fix that. Signed-off-by: Cornelia Huck --- Noted while looking at the fixes for the kvm reset handling. We now clear some fields twice in the paths for clear or initial reset; but (a) we already do that for other fields and (b)

Re: [PATCH 3/5] hw/arm/smmuv3: Align stream table base address to table size

2019-12-05 Thread Auger Eric
Hi Simon, On 12/4/19 2:55 PM, Simon Veith wrote: > Per the specification, and as observed in hardware, the SMMUv3 aligns > the SMMU_STRTAB_BASE address to the size of the table by masking out the > respective least significant bits in the ADDR field. > > Apply this masking logic to our smmu_find_

[PATCH] net: Remove deprecated [hub_id name] tuple of 'hostfwd_add' / 'hostfwd_remove'

2019-12-05 Thread Thomas Huth
It's been deprecated since QEMU v3.1.0. Time to finally remove it now. Signed-off-by: Thomas Huth --- hmp-commands.hx | 8 net/hub.c| 23 --- net/hub.h| 2 -- net/slirp.c | 44 qemu-

Re: [PATCH for-5.0 1/8] q35: implement 128K SMRAM at default SMBASE address

2019-12-05 Thread Laszlo Ersek
Hi Igor, On 12/04/19 18:05, Igor Mammedov wrote: > Use commit (2f295167e0 q35/mch: implement extended TSEG sizes) for > inspiration and (ab)use reserved register in config space at 0x9c > offset [*] to extend q35 pci-host with ability to use 128K at > 0x3 as SMRAM and hide it (like TSEG) from

Re: [PATCH v6 0/9] Clock framework API

2019-12-05 Thread Philippe Mathieu-Daudé
On 12/5/19 11:21 AM, Dr. David Alan Gilbert wrote: * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: On 12/5/19 10:36 AM, Damien Hedde wrote: On 12/4/19 9:34 PM, Philippe Mathieu-Daudé wrote: On 12/4/19 5:40 PM, Damien Hedde wrote: On 12/2/19 5:15 PM, Peter Maydell wrote: The one topic I

Re: [PATCH] s390x/tcg: clear local interrupts on reset normal

2019-12-05 Thread Philippe Mathieu-Daudé
Hi Cornelia, On 12/5/19 11:38 AM, Cornelia Huck wrote: We neglected to clean up pending interrupts and emergency signals; fix that. Signed-off-by: Cornelia Huck --- Noted while looking at the fixes for the kvm reset handling. IIUC we always neglected to clean these fields, but Janosh recent

Re: [PATCH v6 0/9] Clock framework API

2019-12-05 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > On 12/5/19 11:21 AM, Dr. David Alan Gilbert wrote: > > * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > > > On 12/5/19 10:36 AM, Damien Hedde wrote: > > > > On 12/4/19 9:34 PM, Philippe Mathieu-Daudé wrote: > > > > > On 12/4/19 5:40 PM, Dam

Re: [PATCH v6 0/9] Clock framework API

2019-12-05 Thread Philippe Mathieu-Daudé
On 12/5/19 11:56 AM, Dr. David Alan Gilbert wrote: * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: On 12/5/19 11:21 AM, Dr. David Alan Gilbert wrote: * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: On 12/5/19 10:36 AM, Damien Hedde wrote: On 12/4/19 9:34 PM, Philippe Mathieu-Daudé wro

Re: [PATCH] s390x/tcg: clear local interrupts on reset normal

2019-12-05 Thread Cornelia Huck
On Thu, 5 Dec 2019 11:56:33 +0100 Philippe Mathieu-Daudé wrote: > Hi Cornelia, > > On 12/5/19 11:38 AM, Cornelia Huck wrote: > > We neglected to clean up pending interrupts and emergency signals; > > fix that. > > > > Signed-off-by: Cornelia Huck > > --- > > > > Noted while looking at the fix

Re: [Qemu-devel] [PATCH v27 5/8] target/avr: Add limited support for USART and 16 bit timer peripherals

2019-12-05 Thread Aleksandar Markovic
On Thursday, December 5, 2019, Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > > > On Thursday, December 5, 2019, Aleksandar Markovic < > aleksandar.m.m...@gmail.com> wrote: > >> >> >> On Thursday, July 25, 2019, Pavel Dovgalyuk wrote: >> >>> > From: Qemu-devel [mailto:qemu-devel-boun

Re: [RFC][PATCH 2/3] docs/specs: Add specification of ivshmem device revision 2

2019-12-05 Thread Markus Armbruster
This has been on the list for more than three weeks already. I apologize for the delay. Jan Kiszka writes: > From: Jan Kiszka > > This imports the ivshmem v2 specification draft from Jailhouse. Its > final home is to be decided, this shall just simplify the review process > at this stage. > >

Re: [PATCH for-5.0 3/8] acpi: cpuhp: spec: clarify 'CPU selector' register usage and endianness

2019-12-05 Thread Laszlo Ersek
On 12/04/19 18:05, Igor Mammedov wrote: > * Move reserved registers to the top of the section, so reader would be > aware of effects when reading registers description. > * State registers endianness explicitly at the beginning of the section > * Describe registers behavior in case of 'CPU select

[PATCH v3] qga: fence guest-set-time if hwclock not available

2019-12-05 Thread Cornelia Huck
The Posix implementation of guest-set-time invokes hwclock to set/retrieve the time to/from the hardware clock. If hwclock is not available, the user is currently informed that "hwclock failed to set hardware clock to system time", which is quite misleading. This may happen e.g. on s390x, which has

[PATCH v6] qga: add command guest-get-devices for reporting VirtIO devices

2019-12-05 Thread Tomáš Golembiovský
Add command for reporting devices on Windows guest. The intent is not so much to report the devices but more importantly the driver (and its version) that is assigned to the device. This gives caller the information whether VirtIO drivers are installed and/or whether inadequate driver is used on a

Re: [PATCH for-5.0 7/8] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

2019-12-05 Thread Laszlo Ersek
On 12/04/19 18:05, Igor Mammedov wrote: > Extend CPU hotplug interface to return architecture specific > identifier for current CPU in 2 registers: > - lower 32 bits existing ACPI_CPU_CMD_DATA_OFFSET_RW > - upper 32 bits in new ACPI_CPU_CMD_DATA2_OFFSET_R at >offset 0. OK. > Target user is

Re: [PATCH v3 3/4] s390x: Fix cpu normal reset ri clearing

2019-12-05 Thread Cornelia Huck
On Tue, 3 Dec 2019 08:28:12 -0500 Janosch Frank wrote: > As it turns out we need to clear the ri controls and PSW enablement > bit to be architecture compliant. > > Signed-off-by: Janosch Frank > Reviewed-by: Christian Borntraeger > --- > target/s390x/cpu.c | 7 ++- > target/s390x/cpu.h

Re: [PATCH v1] intel_iommu: fix bug to read DMAR_RTADDR_REG

2019-12-05 Thread Peter Xu
On Thu, Dec 05, 2019 at 05:54:39PM +0800, Yi Sun wrote: > Should directly read DMAR_RTADDR_REG but not using 's->root'. > Because 's->root' is modified in 'vtd_root_table_setup()' so > that the first 12 bits are omitted. This causes the guest > iommu debugfs cannot show pasid tables. > > Signed-of

[PATCH v2 2/6] linux-user: convert target_mmap debug to tracepoint

2019-12-05 Thread Alex Bennée
It is a pain to re-compile when you need to debug and tracepoints are a fairly low impact way to instrument QEMU. Signed-off-by: Alex Bennée --- linux-user/mmap.c | 27 +-- linux-user/trace-events | 1 + 2 files changed, 2 insertions(+), 26 deletions(-) diff --git

Re: [PATCH v3] qga: fence guest-set-time if hwclock not available

2019-12-05 Thread Philippe Mathieu-Daudé
Hi Cornelia, On 12/5/19 12:53 PM, Cornelia Huck wrote: The Posix implementation of guest-set-time invokes hwclock to set/retrieve the time to/from the hardware clock. If hwclock is not available, the user is currently informed that "hwclock failed to set hardware clock to system time", which is

[QUESTION] "cpu" vs "core"

2019-12-05 Thread Aleksandar Markovic
Hi, all. Times are changing, and perhaps some words change their significance or are less in use. What do you think of introducing a new option in our command line "-core", that would be (code-wise) a sinomym to "-cpu" (that becomes almost archaic)? Yours, Aleksandar

Re: [PATCH v3] qga: fence guest-set-time if hwclock not available

2019-12-05 Thread Philippe Mathieu-Daudé
On 12/5/19 2:12 PM, Cornelia Huck wrote: On Thu, 5 Dec 2019 14:05:19 +0100 Philippe Mathieu-Daudé wrote: Hi Cornelia, On 12/5/19 12:53 PM, Cornelia Huck wrote: The Posix implementation of guest-set-time invokes hwclock to set/retrieve the time to/from the hardware clock. If hwclock is not av

Re: [PATCH v37 07/17] target/avr: Add instruction translation - Bit and Bit-test Instructions

2019-12-05 Thread Michael Rolnik
I think they do follow the division in the docs. On Thu, Dec 5, 2019 at 2:28 PM Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > > > On Wednesday, November 27, 2019, Michael Rolnik wrote: > >> This includes: >> - LSR, ROR >> - ASR >> - SWAP >> - SBI, CBI >> - BST,

Re: [RFC PATCH 0/9] Introduce mediate ops in vfio-pci

2019-12-05 Thread Jason Wang
On 2019/12/5 下午4:51, Yan Zhao wrote: On Thu, Dec 05, 2019 at 02:33:19PM +0800, Jason Wang wrote: Hi: On 2019/12/5 上午11:24, Yan Zhao wrote: For SRIOV devices, VFs are passthroughed into guest directly without host driver mediation. However, when VMs migrating with passthroughed VFs, dynamic h

Re: [PATCH v37 07/17] target/avr: Add instruction translation - Bit and Bit-test Instructions

2019-12-05 Thread Michael Rolnik
my mistake. Thanks. I will split it. On Thu, Dec 5, 2019 at 3:17 PM Michael Rolnik wrote: > I think they do follow the division in the docs. > > On Thu, Dec 5, 2019 at 2:28 PM Aleksandar Markovic < > aleksandar.m.m...@gmail.com> wrote: > >> >> >> On Wednesday, November 27, 2019, Michael Rolnik

Re: [QUESTION] "cpu" vs "core"

2019-12-05 Thread Thomas Huth
On 05/12/2019 14.11, Aleksandar Markovic wrote: > Hi, all. > > Times are changing, and perhaps some words change their significance or > are less in use. > > What do you think of introducing a new option in our command line > "-core", that would be (code-wise) a sinomym to "-cpu" (that becomes >

Re: [PATCH v7] Implement backend program convention command for vhost-user-blk

2019-12-05 Thread Marc-André Lureau
Hi On Mon, Nov 25, 2019 at 9:17 AM Micky Yun Chan(michiboo) wrote: > > From: Micky Yun Chan > > This patch is to add standard commands defined in docs/interop/vhost-user.rst > For vhost-user-* program > > Signed-off-by: Micky Yun Chan (michiboo) > --- > contrib/vhost-user-blk/vhost-user-blk.c

Re: [RFC v5 024/126] error: auto propagated local_err

2019-12-05 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 04.12.2019 17:59, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of >>> functions with errp OUT parameter. >>> >>> It has three goals: >>> >>> 1. Fix issue with erro

Re: [PATCH v7] Implement backend program convention command for vhost-user-blk

2019-12-05 Thread Markus Armbruster
Cc: Marc-André for docs/vhost-user.json expertise. "Micky Yun Chan(michiboo)" writes: > From: Micky Yun Chan > > This patch is to add standard commands defined in docs/interop/vhost-user.rst > For vhost-user-* program > > Signed-off-by: Micky Yun Chan (michiboo) > --- > contrib/vhost-user-blk

Re: [PATCH] migration: Rate limit inside host pages

2019-12-05 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > When using hugepages, rate limiting is necessary within each huge > page, since a 1G huge page can take a significant time to send, so > you end up with bursty behaviour. > > Fixes: 4c011c37ecb3 ("postcopy: Send whole huge

Re: [PATCH v3] qga: fence guest-set-time if hwclock not available

2019-12-05 Thread Cornelia Huck
On Thu, 5 Dec 2019 14:05:19 +0100 Philippe Mathieu-Daudé wrote: > Hi Cornelia, > > On 12/5/19 12:53 PM, Cornelia Huck wrote: > > The Posix implementation of guest-set-time invokes hwclock to > > set/retrieve the time to/from the hardware clock. If hwclock > > is not available, the user is curren

[PATCH] qemu-img: fix info --backing-chain --image-opts

2019-12-05 Thread Stefan Hajnoczi
Only apply --image-opts to the topmost image when listing an entire backing chain. It is incorrect to treat backing filenames as image options. Assuming we have the backing chain t.IMGFMT.base <- t.IMGFMT.mid <- t.IMGFMT, qemu-img info fails as follows: $ qemu-img info --backing-chain --image-

Re: [PATCH v37 13/17] target/avr: Register AVR support with the rest of QEMU

2019-12-05 Thread Aleksandar Markovic
On Wednesday, November 27, 2019, Michael Rolnik wrote: > Add AVR related definitions into QEMU > > Signed-off-by: Michael Rolnik > Tested-by: Philippe Mathieu-Daudé > Reviewed-by: Aleksandar Markovic > --- > qapi/machine.json | 3 ++- > include/disas/dis-asm.h| 6 ++ > includ

[Bug 1809291] Re: SD Card not working in Ubuntu 18.10 (CMD 2, 3 timeout). The device worked fine in Ubuntu 18.04 and earlier versions but not in Ubuntu 18.10

2019-12-05 Thread Misa.Z
Dear Dr. KC.Wang, Download qemu-4.2.0-rc4 source code, change hw/sd/sd.c at line 1560 like follows and remake (line: 1560) if (req.arg & ACMD41_ENQUIRY_MASK) { /*if (FIELD_EX32(sd->ocr & req.arg, OCR, VDD_VOLTAGE_WINDOW)) {*/ BTW, here is my micro-kernel-os for arm platform based the contents

[PATCH v2 4/6] linux-user: log page table changes under -d page

2019-12-05 Thread Alex Bennée
The CPU_LOG_PAGE flag is woefully underused and could stand to do extra duty tracking page changes. If the user doesn't want to see the details as things change they still have the tracepoints available. We push the locking into log_page_dump and pass a reason for the banner text. Signed-off-by:

Re: [PATCH v5 1/2] block/nbd: extract the common cleanup code

2019-12-05 Thread Eric Blake
On 12/5/19 3:42 AM, Stefano Garzarella wrote: Hi Pan, On Thu, Dec 05, 2019 at 11:45:27AM +0800, pannengy...@huawei.com wrote: From: Pan Nengyuan The BDRVNBDState cleanup code is common in two places, add nbd_clear_bdrvstate() function to do these cleanups. Signed-off-by: Stefano Garzarella

[PATCH v2 5/6] linux-user: convert target_munmap debug to a tracepoint

2019-12-05 Thread Alex Bennée
Convert the final bit of DEBUG_MMAP to a tracepoint and remove the last remanents of the #ifdef hackery. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- linux-user/mmap.c | 9 ++--- linux-user/trace-events | 1 + 2 files changed, 3 insertions(+), 7 deletions(-) diff --g

Re: [PATCH] net/imx_fec: Updating the IMX_FEC IP to support loopback mode.

2019-12-05 Thread Jason Wang
On 2019/12/4 下午11:11, Peter Maydell wrote: On Wed, 4 Dec 2019 at 02:15, Jason Wang wrote: On 2019/11/30 上午12:04, Philippe Mathieu-Daudé wrote: On Fri, Nov 29, 2019 at 4:59 PM Wasim, Bilal wrote: Thanks for the pointers philippe.. Is the patch okay to be merged without it or do I need to d

[PATCH v2 6/6] trace: replace hand-crafted pattern_glob with g_pattern_match_simple

2019-12-05 Thread Alex Bennée
We already use g_pattern_match elsewhere so remove the duplication. Signed-off-by: Alex Bennée --- trace/control.c | 35 +-- 1 file changed, 1 insertion(+), 34 deletions(-) diff --git a/trace/control.c b/trace/control.c index d9cafc161bb..0fb81241607 100644 --- a

Re: [PATCH] migration: Rate limit inside host pages

2019-12-05 Thread Peter Xu
On Thu, Dec 05, 2019 at 10:29:18AM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > When using hugepages, rate limiting is necessary within each huge > page, since a 1G huge page can take a significant time to send, so > you end up with bursty behaviour. > > Fixes:

[PATCH] socket: websocket refresh of max_size outside of poll

2019-12-05 Thread Anisse Astier
Because serial backend readiness isn't checked, the socket frontend (in websocket mode) would send new characters before previous characters were consumed. This lead to skipped characters, or worse, SysRq keys being triggered. This patch ensures the readable size is refreshed before consuming any

[PATCH v2 0/6] linux-user mmap debug cleanup

2019-12-05 Thread Alex Bennée
Hi, This is a quick re-spin of the mmap tracing. I don't bother with pretty formatting the protection/type flags as they were incomplete and not hard to extract from just dumping the hex values. This makes most of the patches much simpler. I've also dropped the home-made pattern_glob routine. The

[PATCH v2 1/6] linux-user: convert target_mprotect debug to tracepoint

2019-12-05 Thread Alex Bennée
It is a pain to re-compile when you need to debug and tracepoints are a fairly low impact way to instrument QEMU. Signed-off-by: Alex Bennée --- v2 - don't both with ascii conversion --- linux-user/mmap.c | 10 ++ linux-user/trace-events | 3 +++ 2 files changed, 5 insertions(+

Re: [PATCH v37 07/17] target/avr: Add instruction translation - Bit and Bit-test Instructions

2019-12-05 Thread Aleksandar Markovic
On Wednesday, November 27, 2019, Michael Rolnik wrote: > This includes: > - LSR, ROR > - ASR > - SWAP > - SBI, CBI > - BST, BLD > - BSET, BCLR > > Signed-off-by: Michael Rolnik > --- > target/avr/translate.c | 1123 > 1 file chang

Re: [PATCH for-5.0 8/8] acpi: cpuhp: spec: document procedure for enabling modern CPU hotplug

2019-12-05 Thread Laszlo Ersek
On 12/04/19 18:05, Igor Mammedov wrote: > Describe how to enable and detect modern CPU hotplug interface. > Detection part is based on new CPHP_GET_CPU_ID_CMD command, > introduced by "acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command" patch. > > Signed-off-by: Igor Mammedov > --- > docs/specs/acpi_cp

Error compiling Qemu-4.1 on Linux

2019-12-05 Thread Aijaz . Baig
Hello I’m trying to compile Qemu from sources and as such face the well known errors of requiring Glib-2.4 and gthread-2.0 ERROR: glib-2.40 gthread-2.0 is required to compile QEMU I’m on Linux Mint and I’ve installed libglib-2.0 from the repo AB1@piper11:~$ dpkg -l | grep -i libglib ii libgl

Re: [PATCH v6] qga: add command guest-get-devices for reporting VirtIO devices

2019-12-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/03fbd542d6bae4cf07be56c51d57fc2962720445.1575546855.git.tgole...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it lo

[PATCH v2 3/6] linux-user: add target_mmap_complete tracepoint

2019-12-05 Thread Alex Bennée
For full details we also want to see where the mmaps end up. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- linux-user/mmap.c | 2 +- linux-user/trace-events | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/linux-user/mmap.c b/linux-user/mmap.c index f4f

Re: [PATCH for-5.0 4/8] acpi: cpuhp: spec: fix 'Command data' description

2019-12-05 Thread Laszlo Ersek
On 12/04/19 18:05, Igor Mammedov wrote: > Correct returned value description in case 'Command field' == 0x0, > it's in not PXM but CPU selector value with pending event (1) s/in not/not/ > > In addition describe 0 blanket value in case of not supported > 'Command field' value. > > Signed-off-by

Re: [PATCH for-5.0 5/8] acpi: cpuhp: spec: clarify store into 'Command data' when 'Command field' == 0

2019-12-05 Thread Laszlo Ersek
On 12/04/19 18:05, Igor Mammedov wrote: > Write section of 'Command data' register should describe what happens > when it's written into. Correct description in case the last stored > 'Command field' value equals to 0, to reflect that currently it's not s/equals to/equals/ or s/equals to/is equa

Re: [PATCH v3] qga: fence guest-set-time if hwclock not available

2019-12-05 Thread Michal Privoznik
On 12/5/19 2:12 PM, Cornelia Huck wrote: On Thu, 5 Dec 2019 14:05:19 +0100 Philippe Mathieu-Daudé wrote: Hi Cornelia, On 12/5/19 12:53 PM, Cornelia Huck wrote: The Posix implementation of guest-set-time invokes hwclock to set/retrieve the time to/from the hardware clock. If hwclock is not av

Re: [PATCH] fence: introduce a file-based self-fence mechanism

2019-12-05 Thread Felipe Franciosi
Heya, > On Nov 26, 2019, at 12:18 PM, Marc-André Lureau > wrote: > > On Mon, Nov 25, 2019 at 8:14 PM Felipe Franciosi wrote: >> >> This introduces a self-fence mechanism to Qemu, causing it to die if a >> heartbeat condition is not met. Currently, a file-based heartbeat is >> available and ca

Re: [PATCH for-5.0 6/8] acpi: cpuhp: spec: add typical usecases

2019-12-05 Thread Laszlo Ersek
On 12/04/19 18:05, Igor Mammedov wrote: > Document work-flows for > * finding a CPU with pending 'insert/remove' event > * enumerating present and possible CPUs > > Signed-off-by: Igor Mammedov > --- > docs/specs/acpi_cpu_hotplug.txt | 29 + > 1 file changed, 29 i

Re: [PATCH] migration: Rate limit inside host pages

2019-12-05 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > When using hugepages, rate limiting is necessary within each huge > > page, since a 1G huge page can take a significant time to send, so > > you end up with bursty behav

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

2019-12-05 Thread Eduardo Habkost
On Mon, Dec 02, 2019 at 10:15:12AM +0100, David Hildenbrand wrote: > > >> Say the user has the option to select a model (zEC12, z13, z14), upper > >> layers always want to have a model that includes all backported security > >> features. While the host model can do that, CPU definitions can't. You

Re: Error compiling Qemu-4.1 on Linux

2019-12-05 Thread Daniel P . Berrangé
On Thu, Dec 05, 2019 at 01:40:11PM +, aijaz.b...@protonmail.com wrote: > Hello > > I’m trying to compile Qemu from sources and as such face the well known > errors of requiring Glib-2.4 and gthread-2.0 > > ERROR: glib-2.40 gthread-2.0 is required to compile QEMU > > I’m on Linux Mint and I’

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

2019-12-05 Thread David Hildenbrand
On 05.12.19 15:35, Eduardo Habkost wrote: > On Mon, Dec 02, 2019 at 10:15:12AM +0100, David Hildenbrand wrote: >> Say the user has the option to select a model (zEC12, z13, z14), upper layers always want to have a model that includes all backported security features. While the host m

Re: [PATCH v6] hw/core/qdev: cleanup Error ** variables

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
29.11.2019 9:07, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> Rename Error ** parameter in check_only_migratable to common errp. >> >> In device_set_realized: >> >> - Move "if (local_err != NULL)" closer to error setters. >> >> - Drop 'Error **local_errp': it doesn't s

Re: [RFC v5 024/126] error: auto propagated local_err

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
05.12.2019 15:36, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> 04.12.2019 17:59, Markus Armbruster wrote: >>> Vladimir Sementsov-Ogievskiy writes: >>> Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of functions with errp OUT parameter. >>

Re: [PATCH v4 26/40] target/arm: Update define_one_arm_cp_reg_with_opaque for VHE

2019-12-05 Thread Richard Henderson
On 12/4/19 2:38 PM, Alex Bennée wrote: > > Richard Henderson writes: > >> On 12/4/19 10:58 AM, Alex Bennée wrote: @@ -7437,13 +7437,10 @@ void define_one_arm_cp_reg_with_opaque(ARMCPU *cpu, mask = PL0_RW; break; case 4: +case 5:

[PATCH v7 02/21] net/net: Clean up variable shadowing in net_client_init()

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
Variable int err in inner scope shadows Error *err in outer scope. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé --- net/net.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/net/net.c b/net/net.c

[PATCH v7 01/21] hw/core/loader-fit: fix freeing errp in fit_load_fdt

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
fit_load_fdt forget to check that errp is not NULL and to zero it after freeing. Fix it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- hw/core/loader-fit.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/core/loader-fit.c b/hw/core/loader-fit

[PATCH v7 11/21] hw/i386/amd_iommu: rename Error ** parameter to more common errp

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/i386/amd_iommu.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c index d55dbf07fc..b1175e52c7 100644 --- a/hw/i386/amd_iommu.c +++ b/hw/i386/amd_iommu.c @@ -1533,7 +1533

[PATCH v7 03/21] error: rename errp to errp_in where it is IN-argument

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
Error **errp is almost always OUT-argument: it's assumed to be NULL, or pointer to NULL-initialized pointer, or pointer to error_abort or error_fatal, for callee to report error. But very few functions instead get Error **errp as IN-argument: it's assumed to be set (or, maybe, NULL), and callee sh

[PATCH v7 14/21] hw/s390x: rename Error ** parameter to more common errp

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Cornelia Huck --- hw/s390x/event-facility.c | 2 +- hw/s390x/s390-stattrib.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c index 66205697ae..dc733ee2af 100644

[PATCH v7 16/21] hw/tpm: rename Error ** parameter to more common errp

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Berger --- hw/tpm/tpm_emulator.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/tpm/tpm_emulator.c b/hw/tpm/tpm_emulator.c index 22f9113432..10d587ed40 100644 --- a/hw/tpm/tpm_emulator.c +++ b/hw/tpm/

[PATCH v7 10/21] block/snapshot: rename Error ** parameter to more common errp

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- include/block/snapshot.h | 2 +- block/snapshot.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/block/snapshot.h b/include/block/snapshot.h index b5d5084a12..2bfcd57578 100644 --- a

[PATCH v7 08/21] 9pfs: well form error hint helpers

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
Make error_append_security_model_hint and error_append_socket_sockfd_hint hint append helpers well formed: rename errp to errp_in, as it is IN-parameter here (which is unusual for errp). Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/9pfs/9p-local.c | 2 +- hw/9pfs/9p-proxy.c | 2 +- 2 files

[PATCH v7 05/21] vnc: drop Error pointer indirection in vnc_client_io_error

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
We don't need Error **, as all callers pass local Error object, which isn't used after the call, or NULL. Use Error * instead. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Markus Armbruster --- ui/vnc.h | 2 +- ui/vnc.c | 20 +++- 2 files changed, 8 insertions(+), 1

[PATCH v7 04/21] hmp: drop Error pointer indirection in hmp_handle_error

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
We don't need Error **, as all callers pass local Error object, which isn't used after the call. Use Error * instead. Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Dr. David Alan Gilbert Reviewed-by: Markus Armbruster --- include/monitor/hmp.h | 2 +- dump/dump-hmp-cmds.c

[PATCH v7 15/21] hw/sd: drop extra whitespace in sdhci_sysbus_realize() header

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- hw/sd/sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 88404d0e9d..18c0c052ce 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -1459,7 +1459,7 @@ static void sd

Re: [PATCH 05/21] crypto: Fix typo in QCryptoTLSSession's comment

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
30.11.2019 22:42, Markus Armbruster wrote: > Cc: "Daniel P. Berrangé" > Signed-off-by: Markus Armbruster > --- > include/crypto/tlssession.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/crypto/tlssession.h b/include/crypto/tlssession.h > index e01e1a9dc2..1

[PATCH v7 06/21] qdev-monitor: well form error hint helpers

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
Make qbus_list_bus and qbus_list_dev hint append helpers well formed: rename errp to errp_in, as it is IN-parameter here (which is unusual for errp), rename functions to be error_append_*_hint. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qdev-monitor.c | 12 +++- 1 file changed, 7 in

[PATCH v7 21/21] nbd: assert that Error** is not NULL in nbd_iter_channel_error

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
The local_err parameter is not here to return information about nbd_iter_channel_error failure. Instead it's assumed to be filled when passed to the function. This is already stressed by its name (local_err, instead of classic errp). Stress it additionally by assertion. Signed-off-by: Vladimir Sem

[PATCH v7 17/21] hw/usb: rename Error ** parameter to more common errp

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/usb/dev-network.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/dev-network.c b/hw/usb/dev-network.c index 5de6213cc4..b81a8abe83 100644 --- a/hw/usb/dev-network.c +++ b/hw/usb/dev-network.c @@ -1342,7 +1342,7 @@ stat

[PATCH v7 20/21] hw/vfio/ap: drop local_err from vfio_ap_realize

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
No reason for local_err here, use errp directly instead. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Markus Armbruster --- hw/vfio/ap.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c index da6a20669d..8fbaa724c2 100644 --- a

Re: [PATCH 06/21] io: Fix Error usage in a comment

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
30.11.2019 22:42, Markus Armbruster wrote: > Cc: "Daniel P. Berrangé" > Signed-off-by: Markus Armbruster > --- > include/io/task.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/io/task.h b/include/io/task.h > index 5cb9faf9f2..1abbfb8b65 100644 > --- a/inclu

  1   2   3   >