On 2019/12/4 下午11:11, Peter Maydell wrote:
On Wed, 4 Dec 2019 at 02:15, Jason Wang<jasow...@redhat.com> wrote:
On 2019/11/30 上午12:04, Philippe Mathieu-Daudé wrote:
On Fri, Nov 29, 2019 at 4:59 PM Wasim, Bilal<bilal_wa...@mentor.com> wrote:
Thanks for the pointers philippe.. Is the patch okay to be merged without it or
do I need to do a re-submission with the updated username ?
If there are no review comments on your patch, I think the maintainer
taking your patch can fix this details directly, no need to resend.
-----Original Message-----
From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com]
Sent: Friday, November 29, 2019 8:38 PM
To:bilalwasim...@gmail.com;qemu-devel@nongnu.org
Cc:peter.mayd...@linaro.org;aa1ron...@gmail.com;j...@tribudubois.net;qemu-...@nongnu.org;
Wasim, Bilal<bilal_wa...@mentor.com>;li...@roeck-us.net; Jason
Wang<jasow...@redhat.com>
Subject: Re: [PATCH] net/imx_fec: Updating the IMX_FEC IP to support loopback
mode.
Hi Bilal,
Cc'ing Jason, the maintainer of network devices.
On 11/29/19 4:05 PM,bilalwasim...@gmail.com wrote:
From: bwasim<bilal_wa...@mentor.com>
Your git setup misses your 'user.name', you could fix it running:
git config user.name "Bilal Wasim"
(eventually with the --global option).
The patch looks good otherwise.
Thanks!
Applied with the fix for user.name.
Could you fix up the non-standard block comment formatting too?
thanks
-- PMM
Yes, fixed.
Thanks
