From: Liu Jingqi
This structure describes memory side cache information for memory
proximity domains if the memory side cache is present and the
physical device forms the memory side cache.
The software could use this information to effectively place
the data in memory to maximize the performance
In ACPI 6.3 chapter 5.2.27 Heterogeneous Memory Attribute Table (HMAT),
The initiator represents processor which access to memory. And in 5.2.27.3
Memory Proximity Domain Attributes Structure, the attached initiator is
defined as where the memory controller responsible for a memory proximity
domain
From: Liu Jingqi
Add -numa hmat-lb option to provide System Locality Latency and
Bandwidth Information. These memory attributes help to build
System Locality Latency and Bandwidth Information Structure(s)
in ACPI Heterogeneous Memory Attribute Table (HMAT). Before using
hmat-lb option, enable HMA
From: Liu Jingqi
HMAT is defined in ACPI 6.3: 5.2.27 Heterogeneous Memory Attribute Table
(HMAT). The specification references below link:
http://www.uefi.org/sites/default/files/resources/ACPI_6_3_final_Jan30.pdf
It describes the memory attributes, such as memory side cache
attributes and bandw
ACPI table HMAT has been introduced, QEMU now builds HMAT tables for
Heterogeneous Memory with boot option '-numa node'.
Add test cases on PC and Q35 machines with 2 numa nodes.
Because HMAT is generated when system enable numa, the
following tables need to be added for this test:
tests/data/a
This series of patches will build Heterogeneous Memory Attribute Table (HMAT)
according to the command line. The ACPI HMAT describes the memory attributes,
such as memory side cache attributes and bandwidth and latency details,
related to the Memory Proximity Domain.
The software is expected to use
From: Liu Jingqi
This structure describes the memory access latency and bandwidth
information from various memory access initiator proximity domains.
The latency and bandwidth numbers represented in this structure
correspond to rated latency and bandwidth for the platform.
The software could use
Check configuring HMAT usecase
Acked-by: Markus Armbruster
Suggested-by: Igor Mammedov
Signed-off-by: Tao Xu
---
Changes in v20:
- Use g_assert_true and g_assert_false to replace g_assert
(Thomas and Markus)
Changes in v19:
- Add some fail cases for hmat-cache when level=0
Chan
On 11/28/19 6:34 PM, Cornelia Huck wrote:
> On Wed, 27 Nov 2019 19:38:06 +0100
> Janosch Frank wrote:
>
>> On 11/27/19 7:25 PM, Janosch Frank wrote:
>>>
>>> There's 0 (initiated), busy and operational and as far as I know we
>>> implement neither.
>>
>> That came out wrong...
>> s/operational/n
On Thu, Nov 28, 2019 at 04:17:17PM +, Marc Zyngier wrote:
> HCR_EL2.TID1 mandates that access from EL1 to REVIDR_EL1, AIDR_EL1
> (and their 32bit equivalents) as well as TCMTR, TLBTR are trapped
> to EL2. QEMU ignores it, naking it harder for a hypervisor to
Typo: "making it harder"
> virtua
Yury Kotov writes:
> The monitor_can_read (as a callback of qemu_chr_fe_set_handlers)
> should return size of buffer which monitor_qmp_read or monitor_read
> can process.
> Currently, monitor_can_read returns 1 as a result of logical not.
> Thus, for each QMP command, len(QMD) iterations of the m
On Thu, Nov 28, 2019 at 04:17:18PM +, Marc Zyngier wrote:
> HCR_EL2.TID3 requires that AArch32 reads of MVFR[012] are trapped to
> EL2, and that HCR_EL2.TID0 does the same for reads of FPSID.
> In order to handle this, introduce a new TCG helper function that
> checks for these control bits bef
28.11.2019 23:29, Markus Armbruster wrote:
> Vladimir Sementsov-Ogievskiy writes:
>
>> 28.11.2019 17:23, Markus Armbruster wrote:
>>> Vladimir Sementsov-Ogievskiy writes:
>>>
Error **errp is almost always OUT-argument: it's assumed to be NULL, or
pointer to NULL-initialized pointer, or
On Thu, Nov 28, 2019 at 8:48 PM Felipe Franciosi wrote:
>
> When QOM APIs were added to ich9 in 6f1426ab, the getter for sci_int was
> written using uint32_t. However, the object property is uint8_t. This
> fixes the getter for correctness.
>
> Signed-off-by: Felipe Franciosi
Reviewed-by: Marc-A
On Tue, Nov 19, 2019 at 11:57:22AM +0100, Juan Quintela wrote:
>Wei Yang wrote:
>> Fill data and update/cleanup related field in one place. Also make the
>> code a little clean.
>>
>> Signed-off-by: Wei Yang
>
>Reviewed-by: Juan Quintela
>
>right cleanup.
>
Hi, Juan
Do you have other comments
29.11.2019 9:10, Markus Armbruster wrote:
> Vladimir Sementsov-Ogievskiy writes:
>
>> No reason for local_err here, use errp directly instead.
>
> Related: "[PATCH v6] hw/vfio/ap: drop local_err from vfio_ap_realize".
> I'm surprised it's just two. Did you search for the anti-pattern
> systemat
On 28/11/2019 22.06, Stefan Weil wrote:
> Am 28.11.19 um 16:35 schrieb Thomas Huth:
>
>> So far we only have compile coverage for tci. But since commit
>> 2f160e0f9797c7522bfd0d09218d0c9340a5137c ("tci: Add implementation
>> for INDEX_op_ld16u_i64") has been included now, we can also run the
>> "t
On 29/11/2019 08.38, Christian Borntraeger wrote:
>
>
> On 28.11.19 16:05, Peter Maydell wrote:
>> On Thu, 28 Nov 2019 at 12:48, Christian Borntraeger
>> wrote:
>>>
>>>
>>>
>>> On 28.11.19 13:45, Cornelia Huck wrote:
On Thu, 28 Nov 2019 13:35:29 +0100
Christian Borntraeger wrote:
28.11.2019 23:29, Markus Armbruster wrote:
>>> [PATCH v6] block/snapshot: rename Error ** parameter to more common
>>> errp
>>> [PATCH v6] hw/i386/amd_iommu: rename Error ** parameter to more
>>> common errp
>>> [PATCH v6] qga: rename Error ** parameter to more common errp
>>>
Hi
On Fri, Oct 4, 2019 at 3:23 PM Marc-André Lureau
wrote:
>
> Hi,
>
> With external processes or helpers participating to the VM support, it
> becomes necessary to handle their migration. Various options exist to
> transfer their state:
> 1) as the VM memory, RAM or devices (we could say that's
git "send-email" doesn't really work well with my work account because the
server considers it "less secure" and does NOT provide a way around it.. I've
had to re-submit the patch from my secondary email...
-Original Message-
From: Qemu-arm [mailto:qemu-arm-bounces+bilal_wasim=mentor...
On Fri, 29 Nov 2019 09:16:21 +0100
Janosch Frank wrote:
> On 11/28/19 6:34 PM, Cornelia Huck wrote:
> > On Wed, 27 Nov 2019 19:38:06 +0100
> > Janosch Frank wrote:
> >
> >> On 11/27/19 7:25 PM, Janosch Frank wrote:
> >>>
> >>> There's 0 (initiated), busy and operational and as far as I know
Hi Corey
On Fri, Nov 22, 2019 at 2:44 AM Corey Minyard wrote:
>
> On Wed, Nov 20, 2019 at 07:24:36PM +0400, Marc-André Lureau wrote:
> > Instead, set the initial data field directly.
> >
> > (the initial data is an array of 256 bytes. As I don't know if it may
> > change over time, I keep the poi
On Fri, Nov 29, 2019 at 01:52:16PM +0500, bilalwasim...@gmail.com wrote:
> From: bwasim
>
> The current code makes a bad assumption that the most-significant byte
> of the MAC address is used to determine if the address is multicast or
> unicast, but in reality only a single bit is used to determ
On Thu, 28 Nov 2019 13:10:21 -0300
Eduardo Habkost wrote:
> On Thu, Nov 28, 2019 at 06:15:16PM +0400, Marc-André Lureau wrote:
> > Hi,
> >
> > Setting up shared memory for vhost-user is a bit complicated from
> > command line, as it requires NUMA setup such as: m 4G -object
> > memory-backend-fi
11.11.2019 19:01, Max Reitz wrote:
> Quorum cannot share WRITE or RESIZE on its children. Presumably, it
> only does so because as a filter, it seemed intuitively correct to point
> its .bdrv_child_perm to bdrv_filter_default_perm().
>
> However, it is not really a filter, and bdrv_filter_default
Hi Aleksandar,
Yes, adding a note about the limitations of the USART emulation sounds like a
good idea.
Yes, I'm happy with switching to the (L)GPL license that's being used elsewhere.
Kind regards,
Sarah Harris
On Thu, 28 Nov 2019 12:02:38 +0100
Aleksandar Markovic wrote:
> On Thursday, No
> Sarah,
> do you mind if use the same license I use for my code?
I'm happy to use the same license.
Kind regards,
Sarah Harris
On Thu, 28 Nov 2019 14:28:19 +0200
Michael Rolnik wrote:
> On Wed, Nov 27, 2019 at 11:06 PM Aleksandar Markovic <
> aleksandar.m.m...@gmail.com> wrote:
>
> > On Wed,
It defaults to returning 0 anyway and that return value is not
necessary, as 0 is also the default rc that the caller would return.
While doing that we can simplify the logic a bit and return early if
we inject a PGM exception.
Signed-off-by: Janosch Frank
Reviewed-by: Thomas Huth
---
target/s
On Fri, Nov 29, 2019 at 11:30:51AM +0400, Marc-André Lureau wrote:
> Hi
>
> On Fri, Nov 29, 2019 at 11:03 AM Gerd Hoffmann wrote:
> >
> > On Thu, Nov 28, 2019 at 06:15:16PM +0400, Marc-André Lureau wrote:
> > > Hi,
> > >
> > > Setting up shared memory for vhost-user is a bit complicated from
> >
On 2019-11-29 08:28, Edgar E. Iglesias wrote:
On Thu, Nov 28, 2019 at 04:17:18PM +, Marc Zyngier wrote:
HCR_EL2.TID3 requires that AArch32 reads of MVFR[012] are trapped to
EL2, and that HCR_EL2.TID0 does the same for reads of FPSID.
In order to handle this, introduce a new TCG helper functi
On 29.11.19 10:17, Janosch Frank wrote:
> It defaults to returning 0 anyway and that return value is not
> necessary, as 0 is also the default rc that the caller would return.
>
> While doing that we can simplify the logic a bit and return early if
> we inject a PGM exception.
>
> Signed-off-by:
On 29/11/19 10:27, Daniel P. Berrangé wrote:
>> Yes, with a fallback path currently using a temporary file under /tmp
>> (we may want to use shm_open() instead, or a different location such
>> as XDG_RUNTIME_DIR? - and use O_TMPFILE)
> We can't assume either /tmp or XDG_RUNTIME_DIR is on tmpfs as t
11.11.2019 19:01, Max Reitz wrote:
> After a couple of follow-up patches, this function will replace
> bdrv_recurse_is_first_non_filter() in check_to_replace_node().
>
> bdrv_recurse_is_first_non_filter() is both not sufficiently specific for
> check_to_replace_node() (it allows cases that should
Hi
On Fri, Nov 29, 2019 at 1:27 PM Daniel P. Berrangé wrote:
>
> On Fri, Nov 29, 2019 at 11:30:51AM +0400, Marc-André Lureau wrote:
> > Hi
> >
> > On Fri, Nov 29, 2019 at 11:03 AM Gerd Hoffmann wrote:
> > >
> > > On Thu, Nov 28, 2019 at 06:15:16PM +0400, Marc-André Lureau wrote:
> > > > Hi,
> >
On Thu, 28 Nov 2019 16:59:33 +
"Dr. David Alan Gilbert" wrote:
> * Marc-André Lureau (marcandre.lur...@redhat.com) wrote:
> > Hi,
> >
> > Setting up shared memory for vhost-user is a bit complicated from
> > command line, as it requires NUMA setup such as: m 4G -object
> > memory-backend-fil
On Thu, Nov 28, 2019 at 07:04:08PM +, Dr. David Alan Gilbert wrote:
> Hi,
> We seem to have a bit of a mess with libcap and libcap-ng; and I'm not
> sure if we should try and untangle it.
>
> a) Our configure script has tests for both libcap and libcap-ng
> for libcap it says $cap, for lib
On 28/11/19 17:10, Eduardo Habkost wrote:
> On Thu, Nov 28, 2019 at 06:15:16PM +0400, Marc-André Lureau wrote:
>> Hi,
>>
>> Setting up shared memory for vhost-user is a bit complicated from
>> command line, as it requires NUMA setup such as: m 4G -object
>> memory-backend-file,id=mem,size=4G,mem-pa
On Thu, Nov 28, 2019 at 07:11:00PM +0100, Cornelia Huck wrote:
> The Posix implementation of guest-set-time invokes hwclock to
> set/retrieve the time to/from the hardware clock. If hwclock
> is not available, the user is currently informed that "hwclock
> failed to set hardware clock to system tim
11.11.2019 19:02, Max Reitz wrote:
> Signed-off-by: Max Reitz
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On Fri, Nov 29, 2019 at 10:33:39AM +0100, Paolo Bonzini wrote:
> On 29/11/19 10:27, Daniel P. Berrangé wrote:
> >> Yes, with a fallback path currently using a temporary file under /tmp
> >> (we may want to use shm_open() instead, or a different location such
> >> as XDG_RUNTIME_DIR? - and use O_TMP
On Fri, Nov 29, 2019 at 1:42 PM Daniel P. Berrangé wrote:
>
> On Fri, Nov 29, 2019 at 01:31:11PM +0400, Marc-André Lureau wrote:
> > Hi
> >
> > On Fri, Nov 29, 2019 at 1:27 PM Daniel P. Berrangé
> > wrote:
> > >
> > > On Fri, Nov 29, 2019 at 11:30:51AM +0400, Marc-André Lureau wrote:
> > > > Hi
11.11.2019 19:02, Max Reitz wrote:
> This will be useful when we want to store additional attributes for each
> child.
>
> Signed-off-by: Max Reitz
you forget my
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On Fri, Nov 29, 2019 at 01:31:11PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Fri, Nov 29, 2019 at 1:27 PM Daniel P. Berrangé
> wrote:
> >
> > On Fri, Nov 29, 2019 at 11:30:51AM +0400, Marc-André Lureau wrote:
> > > Hi
> > >
> > > On Fri, Nov 29, 2019 at 11:03 AM Gerd Hoffmann wrote:
> > > >
>
We need to know if we run in pv state or not when emulating
instructions.
Signed-off-by: Janosch Frank
---
hw/s390x/s390-virtio-ccw.c | 2 ++
target/s390x/cpu.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index e2a302398d.
When a guest has saved a ipib of type 5 and call diagnose308 with
subcode 10, we have to setup the protected processing environment via
Ultravisor calls. The calls are done by KVM and are exposed via an API.
The following steps are necessary:
1. Create a VM (register it with the Ultravisor)
2. Cre
On Fri, Nov 29, 2019 at 09:24:37AM +, Marc Zyngier wrote:
> On 2019-11-29 08:28, Edgar E. Iglesias wrote:
> > On Thu, Nov 28, 2019 at 04:17:18PM +, Marc Zyngier wrote:
> > > HCR_EL2.TID3 requires that AArch32 reads of MVFR[012] are trapped to
> > > EL2, and that HCR_EL2.TID0 does the same f
Now that we know the protection state off the cpus, we can start
handling all diag 308 subcodes in the protected state.
For subcodes 0 and 1 we need to unshare all pages before continuing,
so the guest doesn't accidentally expose data when dumping.
For subcode 3/4 we tear down the protected VM an
For diag308 subcodes 8 - 10 we have a new ipib of type 5. The ipib
holds the address and length of the secure execution header, as well
as a list of guest components.
Each component is a block of memory, for example kernel or initrd,
which needs to be decrypted by the Ultravisor in order to run a
Let's sync all the protvirt header changes
Signed-off-by: Janosch Frank
---
linux-headers/linux/kvm.h | 42 +++
1 file changed, 42 insertions(+)
diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h
index 3d9b18f7f8..4448d59960 100644
--- a/linux
On 29/11/19 10:39, Daniel P. Berrangé wrote:
> On Fri, Nov 29, 2019 at 10:33:39AM +0100, Paolo Bonzini wrote:
>> On 29/11/19 10:27, Daniel P. Berrangé wrote:
Yes, with a fallback path currently using a temporary file under /tmp
(we may want to use shm_open() instead, or a different locati
Most of the QEMU changes for PV are related to the new IPL type with
subcodes 8 - 10 and the execution of the necessary Ultravisor calls to
IPL secure guests. Note that we can only boot into secure mode from
normal mode, i.e. stfle 161 is not active in secure mode.
The other changes related to dat
Secure guests no longer intercept with code 4 for an instruction
interception. Instead they have codes 104 and 108 for secure
instruction interception and secure instruction notification
respectively.
The 104 mirrors the 4 interception.
The 108 is a notification interception to let KVM and QEMU k
On Fri, 29 Nov 2019 at 09:45, Edgar E. Iglesias
wrote:
> IIRC, the current EL was always known at translation time but I've
> not been tracking recent changes.
Yes, it's known at translate time, in dc->current_el.
(The code is structured to make it difficult to accidentally
use info that's not kn
Status storing is obviously not done by qemu anymore.
Signed-off-by: Janosch Frank
---
target/s390x/helper.c | 4
target/s390x/sigp.c | 1 +
2 files changed, 5 insertions(+)
diff --git a/target/s390x/helper.c b/target/s390x/helper.c
index a3a49164e4..3800c4b395 100644
--- a/target/s390x/
Patchew URL:
https://patchew.org/QEMU/2b7a42487a5d4a258062bd209a0d1...@svr-ies-mbx-03.mgc.mentorg.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: RE: [PATCH] Updating the GEM MAC IP to properly filter out the
multicast addresses
SCLP for a protected guest is done over the SIDAD, so we need to use
the s390_cpu_virt_mem_* functions to access the SIDAD instead of guest
memory when reading/writing SCBs.
To not confuse the sclp emulation, we set 0x4000 as the SCCB address,
since the function that injects the sclp external inte
Hi Peter,
the following changes since commit 1a61a081ac33ae6cb7dd2e38d119a572f416c7f7:
Update version for v4.2.0-rc3 release (2019-11-26 21:52:26 +)
are available in the Git repository at:
https://gitlab.com/huth/qemu.git tags/pull-request-2019-11-29
for you to fetch changes up to bf8
Handling of CPU reset and setting of the IPL psw from guest storage at
offset 0 is done by a Ultravisor call. Let's only fetch it if
necessary.
Signed-off-by: Janosch Frank
Reviewed-by: Thomas Huth
---
hw/s390x/pv.c | 5 +
hw/s390x/pv.h | 1 +
hw/s390x/s390-virtio-
If a vcpu is not properly reset it might be better to just end the VM.
Signed-off-by: Janosch Frank
Reviewed-by: David Hildenbrand
---
target/s390x/kvm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
index 5b1ed3acb4..15b041a601 100644
--- a/targe
[...]
>
> +struct IPLBlockPVComp {
> +uint64_t tweak_pref;
> +uint64_t addr;
> +uint64_t size;
> +} QEMU_PACKED;
QEMU_PACKED should not be needed.
> +typedef struct IPLBlockPVComp IPLBlockPVComp;
> +
> +struct IPLBlockPV {
> +uint8_t reserved[84];
"reserved0"
> +uint8_t
IO instruction data is routed through SIDAD for protected guests, so
adresses do not need to be checked, as this is kernel memory.
Signed-off-by: Janosch Frank
---
target/s390x/ioinst.c | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git a/target/s390x/i
CPU resets for protected guests need to be done via Ultravisor
calls. Hence we need a way to issue these calls for each reset.
As we formerly had only one reset function and it was called for
initial, as well as for the clear reset, we now need a new interface.
Signed-off-by: Janosch Frank
---
On 29.11.19 10:48, Janosch Frank wrote:
> We need to know if we run in pv state or not when emulating
> instructions.
>
> Signed-off-by: Janosch Frank
> ---
> hw/s390x/s390-virtio-ccw.c | 2 ++
> target/s390x/cpu.h | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/hw/s390x/s390
On Fri, 29 Nov 2019 10:33:39 +0100
Paolo Bonzini wrote:
> On 29/11/19 10:27, Daniel P. Berrangé wrote:
> >> Yes, with a fallback path currently using a temporary file under /tmp
> >> (we may want to use shm_open() instead, or a different location such
> >> as XDG_RUNTIME_DIR? - and use O_TMPFILE)
For protected guests the IPIB is written/read to/from the satellite
block, so we need to make those accesses virtual to make them go
through KVM mem ops.
Signed-off-by: Janosch Frank
---
target/s390x/diag.c | 26 +++---
1 file changed, 23 insertions(+), 3 deletions(-)
diff -
11.11.2019 19:02, Max Reitz wrote:
> We will need this to verify that Quorum can let one of its children be
> replaced without breaking anything else.
>
> Signed-off-by: Max Reitz
> ---
> block/quorum.c | 23 +++
> 1 file changed, 23 insertions(+)
>
> diff --git a/block/qu
On 29.11.19 10:48, Janosch Frank wrote:
> Secure guests no longer intercept with code 4 for an instruction
> interception. Instead they have codes 104 and 108 for secure
> instruction interception and secure instruction notification
> respectively.
>
> The 104 mirrors the 4 interception.
>
> The
11.11.2019 19:02, Max Reitz wrote:
> Signed-off-by: Max Reitz
> ---
> block/quorum.c | 62 ++
> 1 file changed, 62 insertions(+)
>
> diff --git a/block/quorum.c b/block/quorum.c
> index 3a824e77e3..8ee03e9baf 100644
> --- a/block/quorum.c
> +++ b
On Fri, 29 Nov 2019 00:31:32 +0400
Marc-André Lureau wrote:
> Hi
>
> On Thu, Nov 28, 2019 at 9:25 PM Igor Mammedov wrote:
> >
> > On Thu, 28 Nov 2019 18:15:18 +0400
> > Marc-André Lureau wrote:
> >
> > > Add an option to simplify shared memory / vhost-user setup.
> > >
> > > Currently, using
Update the edk2 submodule from release edk2-stable201905 to
edk2-stable201911.
In this release, the EDK2 project its OpenSSL submodule from 1.1.1b
to 1.1.1d to fix the following CVEs (marked as 'low severity'):
- https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-1543
- https://cve.mitre.org
On 29.11.19 10:34, Vladimir Sementsov-Ogievskiy wrote:
> 11.11.2019 19:01, Max Reitz wrote:
>> After a couple of follow-up patches, this function will replace
>> bdrv_recurse_is_first_non_filter() in check_to_replace_node().
>>
>> bdrv_recurse_is_first_non_filter() is both not sufficiently specific
Generated .h need to be generated before compiling any .c using them.
To know which .h a .c uses, we need to compile it.
Since commit 4115852bb0 "build: do not sprinkle around
GENERATED_HEADERS dependencies", we break this circular dependency the
simple & stupid way: the generated headers are a pr
This fixes various boot scenarios, e.g. the possibility to use
"-boot menu=on".
Signed-off-by: Thomas Huth
---
pc-bios/s390-ccw.img | Bin 42608 -> 42608 bytes
pc-bios/s390-netboot.img | Bin 67232 -> 67232 bytes
2 files changed, 0 insertions(+), 0 deletions(-)
diff --git a/pc-bios/s390-ccw
On 29/11/19 10:34, Daniel P. Berrangé wrote:
>> y) Should we flip over to only using one or the other - what
>> are the advantages?
> In libvirt we use libcap-ng. We picked this originally as its API
> design allows you do write simpler code than libcap in some cases
> You can see some docs
I had this commit ready for when the next EDK2 release were go out,
which just happened: https://edk2.groups.io/g/devel/message/51502
Laszlo doesn't think it's worth the churn to rush to get this update
into into 4.2-rc4: https://bugs.launchpad.net/qemu/+bug/1852196/comments/2
I agree with Laszlo
On Wed, 27 Nov 2019 12:50:40 -0500
Janosch Frank wrote:
> Adding comments and reordering code for better readability in the
> diag308 and machine reset functions. Also making the kvm sclp function
> void and refactoring it.
>
> v4
> * Added sclp cleanup
> * Renamed ccpu reset wrapper
From: Claudio Imbrenda
The existing s390 bios gets the LOADPARM information from the system using
an SCLP call that specifies a buffer length too small to contain all the
output.
The recent fixes in the SCLP code have exposed this bug, since now the
SCLP call will return an error (as per archite
* Paolo Bonzini (pbonz...@redhat.com) wrote:
> On 29/11/19 10:34, Daniel P. Berrangé wrote:
> >> y) Should we flip over to only using one or the other - what
> >> are the advantages?
> > In libvirt we use libcap-ng. We picked this originally as its API
> > design allows you do write simpler
On 29.11.19 10:48, Janosch Frank wrote:
> CPU resets for protected guests need to be done via Ultravisor
> calls. Hence we need a way to issue these calls for each reset.
>
> As we formerly had only one reset function and it was called for
> initial, as well as for the clear reset, we now need a n
On 29.11.19 10:47, Janosch Frank wrote:
> When a guest has saved a ipib of type 5 and call diagnose308 with
> subcode 10, we have to setup the protected processing environment via
> Ultravisor calls. The calls are done by KVM and are exposed via an API.
>
> The following steps are necessary:
> 1.
On 29.11.19 10:48, Janosch Frank wrote:
> Now that we know the protection state off the cpus, we can start
> handling all diag 308 subcodes in the protected state.
>
> For subcodes 0 and 1 we need to unshare all pages before continuing,
> so the guest doesn't accidentally expose data when dumping.
On 29/11/19 11:07, Igor Mammedov wrote:
>>> So user who wants something non trivial could override default
>>> non-numa behavior with
>>> -object memory-backend-file,id=mem,size=4G,mem-path=/dev/shm,share=on \
>>> -machine memdev=mem
>>> or use any other backend that suits theirs needs.
>> Th
11.11.2019 19:02, Max Reitz wrote:
> Let check_to_replace_node() use the more specialized
> bdrv_recurse_can_replace() instead of
> bdrv_recurse_is_first_non_filter(), which is too restrictive.
or not enough restrictive in case of quorum
>
> Signed-off-by: Max Reitz
> ---
> block.c | 18 +
On Fri, 29 Nov 2019 10:31:36 +0100
Paolo Bonzini wrote:
> On 28/11/19 17:10, Eduardo Habkost wrote:
> > On Thu, Nov 28, 2019 at 06:15:16PM +0400, Marc-André Lureau wrote:
> >> Hi,
> >>
> >> Setting up shared memory for vhost-user is a bit complicated from
> >> command line, as it requires NUMA
11.11.2019 19:02, Max Reitz wrote:
> There is no guarantee that we can still replace the node we want to
> replace at the end of the mirror job. Double-check by calling
> bdrv_recurse_can_replace().
>
> Signed-off-by: Max Reitz
> ---
> block/mirror.c | 14 +-
> 1 file changed, 13
On 29/11/2019 10.48, Janosch Frank wrote:
> Status storing is obviously not done by qemu anymore.
>
> Signed-off-by: Janosch Frank
> ---
> target/s390x/helper.c | 4
> target/s390x/sigp.c | 1 +
> 2 files changed, 5 insertions(+)
>
> diff --git a/target/s390x/helper.c b/target/s390x/help
On 29.11.19 10:48, Janosch Frank wrote:
> SCLP for a protected guest is done over the SIDAD, so we need to use
> the s390_cpu_virt_mem_* functions to access the SIDAD instead of guest
> memory when reading/writing SCBs.
... Can you elaborate a bit more how that is going to be used? Did you
hack in
On 11/29/19 11:09 AM, David Hildenbrand wrote:
> [...]
>>
>> +struct IPLBlockPVComp {
>> +uint64_t tweak_pref;
>> +uint64_t addr;
>> +uint64_t size;
>> +} QEMU_PACKED;
>
> QEMU_PACKED should not be needed.
>
>> +typedef struct IPLBlockPVComp IPLBlockPVComp;
>> +
>> +struct IPLBlock
29.11.2019 13:23, Max Reitz wrote:
> On 29.11.19 10:34, Vladimir Sementsov-Ogievskiy wrote:
>> 11.11.2019 19:01, Max Reitz wrote:
>>> After a couple of follow-up patches, this function will replace
>>> bdrv_recurse_is_first_non_filter() in check_to_replace_node().
>>>
>>> bdrv_recurse_is_first_non_
On Fri, 29 Nov 2019 at 10:08, Thomas Huth wrote:
>
> Hi Peter,
>
> the following changes since commit 1a61a081ac33ae6cb7dd2e38d119a572f416c7f7:
>
> Update version for v4.2.0-rc3 release (2019-11-26 21:52:26 +)
>
> are available in the Git repository at:
>
> https://gitlab.com/huth/qemu.gi
On 29/11/19 11:23, Igor Mammedov wrote:
> [...]
>> Therefore, I think instead of -mem-shared we should add a "-m
>> memdev=..." option. This option:
>>
>> * would be mutually exclusive with both -mem-path
>>
>> * would be handled from allocate_system_memory_nonnuma.
>>
>> * could be mutually exclu
On Wed, Nov 20, 2019 at 06:43:19AM -0500, Janosch Frank wrote:
> Most of the QEMU changes for PV are related to the new IPL type with
> subcodes 8 - 10 and the execution of the necessary Ultravisor calls to
> IPL secure guests. Note that we can only boot into secure mode from
> normal mode, i.e. st
On 29.11.19 12:04, Thomas Huth wrote:
> On 29/11/2019 10.48, Janosch Frank wrote:
>> Status storing is obviously not done by qemu anymore.
>>
>> Signed-off-by: Janosch Frank
>> ---
>> target/s390x/helper.c | 4
>> target/s390x/sigp.c | 1 +
>> 2 files changed, 5 insertions(+)
>>
>> diff --
On Fri, Nov 29, 2019 at 03:24:14PM +0500, bilalwasim...@gmail.com wrote:
> From: bwasim
>
> The current code makes a bad assumption that the most-significant byte
> of the MAC address is used to determine if the address is multicast or
> unicast, but in reality only a single bit is used to determ
On 29.11.19 12:21, Janosch Frank wrote:
> On 11/29/19 11:47 AM, David Hildenbrand wrote:
>> On 29.11.19 10:48, Janosch Frank wrote:
>>> CPU resets for protected guests need to be done via Ultravisor
>>> calls. Hence we need a way to issue these calls for each reset.
>>>
>>> As we formerly had only
Thanks for also helping me get through the "somewhat" tedious patch process of
QEMU.. Will be helpful for future submissions..
- Bilal
-Original Message-
From: Edgar E. Iglesias [mailto:edgar.igles...@gmail.com]
Sent: Friday, November 29, 2019 4:22 PM
To: bilalwasim...@gmail.com
Cc: qe
On 11/29/19 11:43 AM, David Hildenbrand wrote:
> On 29.11.19 10:48, Janosch Frank wrote:
>> SCLP for a protected guest is done over the SIDAD, so we need to use
>> the s390_cpu_virt_mem_* functions to access the SIDAD instead of guest
>> memory when reading/writing SCBs.
>
> ... Can you elaborate
Since we are using the newer capng library, rename the symbol to match.
Signed-off-by: Paolo Bonzini
---
configure | 2 +-
qemu-bridge-helper.c | 6 +++---
scsi/qemu-pr-helper.c | 12 ++--
3 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/configure b/configu
On 29.11.19 10:48, Janosch Frank wrote:
> For protected guests the IPIB is written/read to/from the satellite
> block, so we need to make those accesses virtual to make them go
> through KVM mem ops.
same comment regarding virt mem access. IMHO, the KVM mem ops should
return a hard error in case w
1 - 100 of 260 matches
Mail list logo
