Re: [Qemu-devel] [PATCH] migration: check length directly to make sure the range is aligned

* Wei Yang (richardw.y...@linux.intel.com) wrote: > On Fri, Jul 19, 2019 at 07:06:51PM +0100, Dr. David Alan Gilbert wrote: > >* Paolo Bonzini (pbonz...@redhat.com) wrote: > >> On 19/07/19 19:54, Dr. David Alan Gilbert wrote: > >> >> -if ((uintptr_t)host_endaddr & (rb->page_size - 1)) { > >

Re: [PATCH v20 0/5] Add ARMv8 RAS virtualization support in QEMU

On 2019/10/28 23:16, Peter Maydell wrote: >> Hi Peter, >> what do you think about it? > I suggest you just use R: for the moment. The code will all end up going > through my tree or perhaps Michael's anyway, so it doesn't make much > practical difference. ok, got it, thanks. > > thanks > --

Re: [PATCH v6 08/11] migration: add new migration state wait-unplug

* Jens Freimann (j...@freimann.org) wrote: > Dr. David Alan Gilbert schrieb am Di., 29. Okt. 2019, > 03:57: > > > * Jens Freimann (jfreim...@redhat.com) wrote: > > > This patch adds a new migration state called wait-unplug. It is entered > > > after the SETUP state if failover devices are presen

Re: [PATCH] spapr: Don't request to unplug the same core twice

On Thu, Oct 24, 2019 at 08:28:54AM +0200, Greg Kurz wrote: > On Thu, 24 Oct 2019 09:38:17 +1100 > David Gibson wrote: > > > On Wed, Oct 23, 2019 at 09:17:40PM +0200, Greg Kurz wrote: > > > We must not call spapr_drc_detach() on a detached DRC otherwise bad things > > > can happen, ie. QEMU hangs

Re: [PATCH qemu] spapr: Add /choses to FDT only at reset time to preserve kernel and initramdisk

On Thu, Oct 24, 2019 at 03:13:08PM +1100, Alexey Kardashevskiy wrote: 65;5603;1c> Since "spapr: Render full FDT on ibm,client-architecture-support" we build > the entire flatten device tree (FDT) twice - at the reset time and > when "ibm,client-architecture-support" (CAS) is called. The full FDT f

Re: [Qemu-devel] [PATCH] migration: check length directly to make sure the range is aligned

On Tue, Oct 29, 2019 at 07:04:19AM +, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> On Fri, Jul 19, 2019 at 07:06:51PM +0100, Dr. David Alan Gilbert wrote: >> >* Paolo Bonzini (pbonz...@redhat.com) wrote: >> >> On 19/07/19 19:54, Dr. David Alan Gilbert wrot

Re: [PULL] RISC-V Patches for the 4.2 Soft Freeze, Part 2

On Mon, 28 Oct 2019 at 15:58, Palmer Dabbelt wrote: > > merged tag 'for_upstream' > Primary key fingerprint: 0270 606B 6F3C DF3D 0B17 0970 C350 3912 AFBE 8E67 > Subkey fingerprint: 5D09 FD08 71C8 F85B 94CA 8A0D 281F 0DB8 D28D 5469 > The following changes since commit 9bb73502321d46f4d320fa1

Re: [RFC 0/3] block/file-posix: Work around XFS bug

On 28.10.19 12:25, Vladimir Sementsov-Ogievskiy wrote: > 28.10.2019 14:04, Kevin Wolf wrote: >> Am 27.10.2019 um 13:35 hat Stefan Hajnoczi geschrieben: >>> On Fri, Oct 25, 2019 at 11:58:46AM +0200, Max Reitz wrote: [...] (3) Drop handle_alloc_space(), i.e. revert c8bb23cbdbe32f. To

RE: [PATCH v5] ssi: xilinx_spips: Skip spi bus update for a few register writes

Thanks Francisco & Alistair for review. I have sent V6 with Review tags and commit message fix. Regards, Sai Pavan > -Original Message- > From: Francisco Iglesias > Sent: Friday, October 25, 2019 6:47 PM > To: Sai Pavan Boddu > Cc: Alistair Francis ; Peter Maydell > ; Edgar Iglesias ; q

RE: [Virtio-fs] [PATCH] virtiofsd: Fix data corruption with O_APPEND wirte in writeback mode

> -Original Message- > From: virtio-fs-boun...@redhat.com [mailto:virtio-fs-boun...@redhat.com] On > Behalf Of misono.tomoh...@fujitsu.com > Sent: Friday, October 25, 2019 7:02 PM > To: 'Vivek Goyal' > Cc: virtio...@redhat.com; qemu-devel@nongnu.org > Subject: Re: [Virtio-fs] [PATCH] virt

Re: QMP netdev_add multiple dnssearch values

> What exactly goes wrong? Does the QMP command fail? Does it succeed > but the network backend incorrectly? QMP command succesfully creates Slirp backend, but ignore whole arguments: - `dnssearch` - `hostfwd` - `guestfwd` As example, `dnssearch` field of `NetdevUserOptions` goes straight to the

[PULL 04/19] tests/qapi-schema: Fix feature documentation testing

Commit 8aa3a33e44 "tests/qapi-schema: Test for good feature lists in structs" made test-qapi.py show features, but neglected to show their documentation. Fix that. Signed-off-by: Markus Armbruster Message-Id: <20191024110237.30963-5-arm...@redhat.com> --- tests/qapi-schema/doc-bad-feature.out

[PULL 07/19] qapi: De-duplicate entity documentation generation code

QAPISchemaGenDocVisitor.visit_command() duplicates texi_entity() for its boxed arguments case. The previous commit added another copy in .visit_event(). Replace texi_entity() by texi_type() and texi_msg(). Use texi_msg() for the boxed arguments case as well. Signed-off-by: Markus Armbruster Me

[PULL 09/19] qapi: Fix enum doc comment checking

Enumeration type documentation comments are not checked, as demonstrated by test doc-bad-enum-member. This is because we neglect to call self.doc.check() for enumeration types. Messed up in 816a57cd6e "qapi: Fix detection of bogus member documentation". Fix it. Signed-off-by: Markus Armbruster

[PULL 00/19] QAPI patches for 2019-10-29

The following changes since commit aaffb853359829a37daaf883c773e8320b55c723: Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2019-10-28' into staging (2019-10-28 14:40:01 +) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2019-10-29

[PULL 02/19] tests/qapi-schema: Demonstrate command and event doc comment bugs

Add negative tests doc-bad-boxed-command-arg and doc-bad-event-arg to cover boxed and no arguments. They demonstrate insufficient doc comment checking. Update positive test doc-good to cover boxed event arguments. It demonstrates the generated doc comment misses arguments. These bugs will be fi

[PULL 13/19] qapi: Eliminate .check_doc() overrides

All sub-classes of QAPISchemaEntity now override .check_doc() the same way, except for QAPISchemaType and and QAPISchemaArrayType. Put the overrides' code in QAPISchemaEntity.check_doc(), and drop the overrides. QAPISchemaType doesn't care because it's abstract. QAPISchemaArrayType doesn't care b

[PULL 12/19] qapi: Simplify ._make_implicit_object_type()

All callers now pass doc=None. Drop the argument. Signed-off-by: Markus Armbruster Message-Id: <20191024110237.30963-13-arm...@redhat.com> --- scripts/qapi/schema.py | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py

[PULL 05/19] qemu-doc: Belatedly document QMP command deprecation

Commit 24fb413300 "qmp: Introduce blockdev-change-medium" (v2.5.0) deprecated change. Commit 2ff3025797 "migrate: move max-bandwidth and downtime-limit to migrate_set_parameter" (v2.8.0) deprecated migrate_set_downtime and migrate_set_speed. These wre missed in commit eb22aeca65 "docs: document d

[PULL 01/19] tests/qapi-schema: Demonstrate feature and enum doc comment bugs

Add negative tests doc-bad-enum-member and doc-bad-feature to cover documentation for nonexistent enum members and features, and test doc-undoc-feature to cover features lacking documentation. None of them works. To be fixed later in this series. Signed-off-by: Markus Armbruster Message-Id: <20

[PULL 14/19] qapi: Fold normalize_if() into check_if()

check_if() is always called together with normalize_if(). Fold the latter into the former. Signed-off-by: Markus Armbruster Message-Id: <20191024110237.30963-15-arm...@redhat.com> --- scripts/qapi/expr.py | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/scripts/

Re: [PATCH v1 1/1] opensbi: Upgrade from v0.4 to v0.5

On Mon, Oct 28, 2019 at 5:56 PM Palmer Dabbelt wrote: > > On Sat, 26 Oct 2019 01:46:45 PDT (-0700), phi...@redhat.com wrote: > > On Sat, Oct 26, 2019 at 10:45 AM Philippe Mathieu-Daudé > > wrote: > >> > >> Hi Alistair, > >> > >> On 10/26/19 1:15 AM, Alistair Francis wrote: > >> > This release has

[PULL 03/19] tests/qapi-schema: Cover alternate documentation comments

Signed-off-by: Markus Armbruster Message-Id: <20191024110237.30963-4-arm...@redhat.com> --- tests/qapi-schema/doc-good.texi | 17 + tests/qapi-schema/doc-good.json | 8 tests/qapi-schema/doc-good.out | 12 3 files changed, 37 insertions(+) diff --git a/tes

[PULL 18/19] qapi: Polish reporting of bogus member documentation

Improve error messages from the following documented members are not in the declaration: a the following documented members are not in the declaration: aa, bb to the more concise documented member 'a' does not exist documented members 'aa', 'bb' do not exist Signed-off-by: Marku

[PULL 10/19] qapi: Clean up doc comment checking for implicit union base

An object type's doc comment describes the type's members, less the ones defined in a named base type. Cases: * Struct: the members are defined in 'data' and inherited from 'base'. Since the base type cannot be implicit, the doc comment describes just 'data'. * Simple union: the only member

[PULL 06/19] qapi: Implement boxed event argument documentation

Generate a reference "Arguments: the members of ...", just like we do for commands since commit c2dd311cb7 "qapi2texi: Implement boxed argument documentation". No change to generated QMP documentation; we don't yet use boxed events outside tests/. Signed-off-by: Markus Armbruster Message-Id: <20

[PULL 15/19] qapi: Fold normalize_features() into check_features()

check_features() is always called together with normalize_features(): the former in check_struct() and check_command(), the latter in their caller check_exprs(). Fold the latter into the former. Signed-off-by: Markus Armbruster Message-Id: <20191024110237.30963-16-arm...@redhat.com> --- scripts

[PULL 11/19] qapi: Fix doc comment checking for commands and events

When a command's 'data' is an object, its doc comment describes the arguments defined there. When 'data' names a type, the doc comment does not describe arguments. Instead, the doc generator inserts a pointer to the named type. An event's doc comment works the same. We don't actually check doc

[PULL 16/19] qapi: Fold normalize_enum() into check_enum()

check_features() is always called together with normalize_features(). Fold the latter into the former. Signed-off-by: Markus Armbruster Message-Id: <20191024110237.30963-17-arm...@redhat.com> --- scripts/qapi/expr.py | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/sc

[PULL 17/19] qapi: Lift features into QAPISchemaEntity

Commit 6a8c0b5102 "qapi: Add feature flags to struct types" added features to QAPISchemaObjectType. Commit a95daa5093 "qapi: Add feature flags to commands in qapi" added them to QAPISchemaCommand, duplicating the code. Tolerable, but the duplication will only get worse as we add features to more

[PULL 19/19] qapi: Check feature documentation against the schema

Commit f3ed93d545 "qapi: Allow documentation for features" neglected to check documentation against the schema. Fix that: check them the same way we check arguments. Signed-off-by: Markus Armbruster Message-Id: <20191024110237.30963-20-arm...@redhat.com> --- scripts/qapi/parser.py

[PULL 08/19] qapi: Split .connect_doc(), .check_doc() off .check()

Splitting documentation checking off the .check() methods makes them a bit more focused, which is welcome, as some of them are pretty big. It also prepares the ground for the following commits. Signed-off-by: Markus Armbruster Message-Id: <20191024110237.30963-9-arm...@redhat.com> --- scripts/qa

Re: [PATCH v1 1/1] target/riscv: Remove atomic accesses to MIP CSR

On Fri, Oct 18, 2019 at 7:44 PM Alistair Francis wrote: > > On Fri, Oct 18, 2019 at 9:51 AM Palmer Dabbelt wrote: > > > > On Tue, 08 Oct 2019 15:04:18 PDT (-0700), Alistair Francis wrote: > > > Instead of relying on atomics to access the MIP register let's update > > > our helper function to inst

Re: [PATCH] fdc: support READ command with VERIFY DMA mode

On 10/20/19 2:38 AM, Sven Schnelle wrote: > While working on the Tulip driver i tried to write some Teledisk images to > a floppy image which didn't work. Turned out that Teledisk checks the written > data by issuing a READ command to the FDC but running the DMA controller > in VERIFY mode. As w

Re: [PATCH v2] qcow2-bitmap: Fix uint64_t left-shift overflow

On 28.10.19 07:33, Tuguoyi wrote: > In check_constraints_on_bitmap(), the sanity check on the > granularity will cause uint64_t integer left-shift overflow > when cluster_size is 2M and the granularity is BIGGER than > 32K. As a result, for a qcow2 disk with cluster_size set to > 2M, we could not e

Re: [PATCH v6 0/11] add failover feature for assigned network devices

On Mon, Oct 28, 2019 at 11:58:53AM -0400, Michael S. Tsirkin wrote: I see at least comments from Markus. You answered but don't you need to also tweak the patch? That comment was addressed already IMO, but I'll change the patch description as well and while I'm at it will also fix David's comme

Re: [RFC 0/3] block/file-posix: Work around XFS bug

29.10.2019 11:50, Max Reitz wrote: > On 28.10.19 12:25, Vladimir Sementsov-Ogievskiy wrote: >> 28.10.2019 14:04, Kevin Wolf wrote: >>> Am 27.10.2019 um 13:35 hat Stefan Hajnoczi geschrieben: On Fri, Oct 25, 2019 at 11:58:46AM +0200, Max Reitz wrote: > > [...] > > (3) Drop handle_alloc_sp

[PATCH v7 02/11] pci: add option for net failover

This patch adds a failover_pair_id property to PCIDev which is used to link the primary device in a failover pair (the PCI dev) to a standby (a virtio-net-pci) device. It only supports ethernet devices. Also currently it only supports PCIe devices. The requirement for PCIe is because it doesn't su

[PATCH v7 0/11] add failover feature for assigned network devices

This is implementing the host side of the net_failover concept (https://www.kernel.org/doc/html/latest/networking/net_failover.html) Changes since v6: * reword patch description of 06/11 (Markus) * have qemu_savevm_state_guest_unplug_pending() return true when at least one device is still not un

[PATCH v7 01/11] qdev/qbus: add hidden device support

This adds support for hiding a device to the qbus and qdev APIs. The first user of this will be the virtio-net failover feature but the API introduced with this patch could be used to implement other features as well, for example hiding pci devices when a pci bus is powered off. qdev_device_add()

[PATCH v7 07/11] migration: allow unplug during migration for failover devices

In "b06424de62 migration: Disable hotplug/unplug during migration" we added a check to disable unplug for all devices until we have figured out what works. For failover primary devices qdev_unplug() is called from the migration handler, i.e. during migration. This patch adds a flag to DeviceState

[PATCH v7 03/11] pci: mark devices partially unplugged

Only the guest unplug request was triggered. This is needed for the failover feature. In case of a failed migration we need to plug the device back to the guest. Signed-off-by: Jens Freimann --- hw/pci/pcie.c| 3 +++ include/hw/pci/pci.h | 1 + 2 files changed, 4 insertions(+) diff --gi

[PATCH v7 04/11] pci: mark device having guest unplug request pending

Set pending_deleted_event in DeviceState for failover primary devices that were successfully unplugged by the Guest OS. Signed-off-by: Jens Freimann --- hw/pci/pcie.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 19363ff8ce..08718188bb 100644 --- a/hw

[PATCH v7 10/11] net/virtio: add failover support

This patch adds support to handle failover device pairs of a virtio-net device and a (vfio-)pci device, where the virtio-net acts as the standby device and the (vfio-)pci device as the primary. The general idea is that we have a pair of devices, a (vfio-)pci and a emulated (virtio-net) device. Bef

[PATCH v7 05/11] qapi: add unplug primary event

This event is emitted when we sent a request to unplug a failover primary device from the Guest OS and it includes the device id of the primary device. Signed-off-by: Jens Freimann --- qapi/migration.json | 19 +++ 1 file changed, 19 insertions(+) diff --git a/qapi/migration.jso

[PATCH v7 06/11] qapi: add failover negotiated event

This event is sent to let libvirt know that VIRTIO_NET_F_STANDBY feature is enabled. The primary device this virtio-net (standby) device is associated with, is now hotplugged by the virtio-net device. Signed-off-by: Jens Freimann --- qapi/net.json | 19 +++ 1 file changed, 19 ins

Re: [RFC 0/3] block/file-posix: Work around XFS bug

On 29.10.19 12:48, Vladimir Sementsov-Ogievskiy wrote: > 29.10.2019 11:50, Max Reitz wrote: >> On 28.10.19 12:25, Vladimir Sementsov-Ogievskiy wrote: >>> 28.10.2019 14:04, Kevin Wolf wrote: Am 27.10.2019 um 13:35 hat Stefan Hajnoczi geschrieben: > On Fri, Oct 25, 2019 at 11:58:46AM +0200,

Re: [PATCH v2] qcow2-bitmap: Fix uint64_t left-shift overflow

29.10.2019 14:14, Max Reitz wrote: > On 28.10.19 07:33, Tuguoyi wrote: >> In check_constraints_on_bitmap(), the sanity check on the >> granularity will cause uint64_t integer left-shift overflow >> when cluster_size is 2M and the granularity is BIGGER than >> 32K. As a result, for a qcow2 disk with

[PATCH v7 08/11] migration: add new migration state wait-unplug

This patch adds a new migration state called wait-unplug. It is entered after the SETUP state if failover devices are present. It will transition into ACTIVE once all devices were succesfully unplugged from the guest. So if a guest doesn't respond or takes long to honor the unplug request the use

[PATCH v7 09/11] libqos: tolerate wait-unplug migration state

Signed-off-by: Jens Freimann --- tests/libqos/libqos.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/libqos/libqos.c b/tests/libqos/libqos.c index d71557c5cb..f229eb2cb8 100644 --- a/tests/libqos/libqos.c +++ b/tests/libqos/libqos.c @@ -125,7 +125,8 @@ void migrate(Q

[PATCH v7 11/11] vfio: unplug failover primary device before migration

As usual block all vfio-pci devices from being migrated, but make an exception for failover primary devices. This is achieved by setting unmigratable to 0 but also add a migration blocker for all vfio-pci devices except failover primary devices. These will be unplugged before migration happens by t

Re: [RFC 0/3] block/file-posix: Work around XFS bug

29.10.2019 14:55, Max Reitz wrote: > On 29.10.19 12:48, Vladimir Sementsov-Ogievskiy wrote: >> 29.10.2019 11:50, Max Reitz wrote: >>> On 28.10.19 12:25, Vladimir Sementsov-Ogievskiy wrote: 28.10.2019 14:04, Kevin Wolf wrote: > Am 27.10.2019 um 13:35 hat Stefan Hajnoczi geschrieben: >>

Re: [PATCH v1 1/1] target/riscv: Remove atomic accesses to MIP CSR

Alistair Francis writes: > Instead of relying on atomics to access the MIP register let's update > our helper function to instead just lock the IO mutex thread before > writing. This follows the same concept as used in PPC for handling > interrupts > > Signed-off-by: Alistair Francis Acked-by

Re: [PATCH v5 1/3] tests/vm: netbsd autoinstall, using serial console

Thomas Huth writes: > On 18/10/2019 20.17, Eduardo Habkost wrote: >> From: Gerd Hoffmann >> >> Instead of fetching the prebuilt image from patchew download the install >> iso and prepare the image locally. Install to disk, using the serial >> console. Create qemu user, configure ssh login.

Re: [PATCH] fw_cfg: Allow reboot-timeout=-1 again

"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert (git)" writes: >> >> > From: "Dr. David Alan Gilbert" >> > >> > Commit ee5d0f89de3e53cdb0dc added range checking on reboot-timeout >> > to only allow the range 0..65535; however both qe

Re: [RFC 0/3] block/file-posix: Work around XFS bug

On 29.10.19 13:05, Vladimir Sementsov-Ogievskiy wrote: > 29.10.2019 14:55, Max Reitz wrote: >> On 29.10.19 12:48, Vladimir Sementsov-Ogievskiy wrote: >>> 29.10.2019 11:50, Max Reitz wrote: On 28.10.19 12:25, Vladimir Sementsov-Ogievskiy wrote: > 28.10.2019 14:04, Kevin Wolf wrote: >> A

Re: [PATCH v6 06/11] qapi: add failover negotiated event

Jens Freimann writes: > On Fri, Oct 25, 2019 at 04:03:54PM +0200, Markus Armbruster wrote: >>Bear with me, I know next to nothing about failover. >> >>Jens Freimann writes: >> >>> This event is sent to let libvirt know that VIRTIO_NET_F_STANDBY feature >>> was enabled. The primary device this vi

Re: [RFC 0/3] block/file-posix: Work around XFS bug

29.10.2019 15:11, Max Reitz wrote: > On 29.10.19 13:05, Vladimir Sementsov-Ogievskiy wrote: >> 29.10.2019 14:55, Max Reitz wrote: >>> On 29.10.19 12:48, Vladimir Sementsov-Ogievskiy wrote: 29.10.2019 11:50, Max Reitz wrote: > On 28.10.19 12:25, Vladimir Sementsov-Ogievskiy wrote: >> 28

Re: [RFC 0/3] block/file-posix: Work around XFS bug

On 29.10.19 13:19, Vladimir Sementsov-Ogievskiy wrote: > 29.10.2019 15:11, Max Reitz wrote: >> On 29.10.19 13:05, Vladimir Sementsov-Ogievskiy wrote: >>> 29.10.2019 14:55, Max Reitz wrote: On 29.10.19 12:48, Vladimir Sementsov-Ogievskiy wrote: > 29.10.2019 11:50, Max Reitz wrote: >> On

Re: [PATCH v7 06/11] qapi: add failover negotiated event

Jens Freimann writes: > This event is sent to let libvirt know that VIRTIO_NET_F_STANDBY feature > is enabled. The primary device this virtio-net (standby) device is > associated with, is now hotplugged by the virtio-net device. > > Signed-off-by: Jens Freimann > --- > qapi/net.json | 19 ++

Re: [PATCH v7 05/11] qapi: add unplug primary event

Jens Freimann writes: > This event is emitted when we sent a request to unplug a Uh, "we sent a requestion [...] from the Guest OS"... do you mean "we received"? > failover primary device from the Guest OS and it includes the > device id of the primary device. > > Signed-off-by: Jens Freimann

Re: [PATCH v7 1/4] block/replication.c: Ignore requests after failover

On 24.10.19 16:25, Lukas Straub wrote: > After failover the Secondary side of replication shouldn't change state, > because > it now functions as our primary disk. > > In replication_start, replication_do_checkpoint, replication_stop, ignore > the request if current state is BLOCK_REPLICATION_DON

Re: [PATCH] fw_cfg: Allow reboot-timeout=-1 again

* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> "Dr. David Alan Gilbert (git)" writes: > >> > >> > From: "Dr. David Alan Gilbert" > >> > > >> > Commit ee5d0f89de3e53cdb0dc added range checking on reboot

Re: [PATCH v5 0/2] RTC support for QEMU RISC-V virt machine

On Fri, Oct 25, 2019 at 6:28 AM Anup Patel wrote: > > This series adds RTC device to QEMU RISC-V virt machine. We have > selected Goldfish RTC device model for this. It's a pretty simple > synthetic device with few MMIO registers and no dependency external > clock. The driver for Goldfish RTC is a

Re: [PATCH v5 1/2] hw: rtc: Add Goldfish RTC device

On Fri, Oct 25, 2019 at 6:30 AM Anup Patel wrote: > > This patch adds model for Google Goldfish virtual platform RTC device. > > We will be adding Goldfish RTC device to the QEMU RISC-V virt machine > for providing real date-time to Guest Linux. The corresponding Linux > driver for Goldfish RTC de

[Bug 1850378] [NEW] RISC-V unreliable IPIs

Public bug reported: I am working on a project with custom inter processor interrupts (IPIs) on the RISC-V virt machine. After upgrading from version 3.1.0 to 4.1.0 which fixes a related issue (https://github.com/riscv/riscv-qemu/issues/132) I am able to use the CPU hotplug feature. However, i

Re: [PATCH v2 0/2] block/nvme: add support for write zeros and discard

On 10/28/19 6:35 AM, Max Reitz wrote: > On 13.09.19 15:36, Maxim Levitsky wrote: >> This is the second part of the patches I prepared >> for this driver back when I worked on mdev-nvme. >> >> V2: addressed review feedback, no major changes >> >> Best regards, >> Maxim Levitsky >> >> Maxim L

Re: [PATCH] MAINTAINERS: add more bitmap-related to Dirty Bitmaps section

On 10/26/19 12:56 PM, Vladimir Sementsov-Ogievskiy wrote: > Let's add bitmaps persistence qcow2 feature and postcopy bitmaps > migration to Dirty Bitmaps section. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertio

Re: [PATCH v7 05/11] qapi: add unplug primary event

On Tue, Oct 29, 2019 at 01:50:02PM +0100, Markus Armbruster wrote: Jens Freimann writes: This event is emitted when we sent a request to unplug a Uh, "we sent a requestion [...] from the Guest OS"... do you mean "we received"? No, we sent a pci hotplug event to the guest by "pushing" the

Re: [PATCH v7 05/11] qapi: add unplug primary event

Jens Freimann writes: > On Tue, Oct 29, 2019 at 01:50:02PM +0100, Markus Armbruster wrote: >>Jens Freimann writes: >> >>> This event is emitted when we sent a request to unplug a >> >>Uh, "we sent a requestion [...] from the Guest OS"... do you mean "we >>received"? > > No, we sent a pci hotplu

Re: [PATCH] fw_cfg: Allow reboot-timeout=-1 again

On 10/29/19 3:26 AM, Dr. David Alan Gilbert wrote: * Laszlo Ersek (ler...@redhat.com) wrote: On 10/25/19 18:57, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Commit ee5d0f89de3e53cdb0dc added range checking on reboot-timeout to only allow the range 0..65535; however both

Re: [PATCH 0/1] dirty-bitmaps: remove deprecated autoload parameter

On 25.09.19 01:01, John Snow wrote: > I'm going to be honest, here. There's actually no real reason to remove > this now, but we could, so I'm going to. > > Also, in terms of the API serving as documentation, it's nicer to not > pretend this is an option that does anything, so out it goes. > > Th

Re: [PATCH] iotests: Remove 130 from the "auto" group

On 18.10.19 18:10, Thomas Huth wrote: > Peter hit a "Could not open 'TEST_DIR/t.IMGFMT': Failed to get shared > 'write' lock - Is another process using the image [TEST_DIR/t.IMGFMT]?" > error with 130 already twice. Looks like this test is a little bit > shaky, and currently nobody has a real clue

Re: [PATCH] nvme: fix NSSRS offset in CAP register

On 23.10.19 09:33, Klaus Jensen wrote: > Fix the offset of the NSSRS field the CAP register. > > Signed-off-by: Klaus Jensen > Reported-by: Javier Gonzalez > --- > include/block/nvme.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks; added John’s note and applied to my block bra

Re: [RFC v2 09/22] vfio/pci: add iommu_context notifier for pasid alloc/free

On Thu, Oct 24, 2019 at 08:34:30AM -0400, Liu Yi L wrote: > This patch adds pasid alloc/free notifiers for vfio-pci. It is > supposed to be fired by vIOMMU. VFIO then sends PASID allocation > or free request to host. > > Cc: Kevin Tian > Cc: Jacob Pan > Cc: Peter Xu > Cc: Eric Auger > Cc: Yi S

Re: [RFC v2 07/22] hw/pci: introduce pci_device_iommu_context()

On Thu, Oct 24, 2019 at 08:34:28AM -0400, Liu Yi L wrote: > This patch adds pci_device_iommu_context() to get an iommu_context > for a given device. A new callback is added in PCIIOMMUOps. Users > who wants to listen to events issued by vIOMMU could use this new > interface to get an iommu_context

RFC: New device for zero-copy VM memory access

Hi All, Over the past week, I have been working to come up with a solution to the memory transfer performance issues that hinder the Looking Glass Project. Currently Looking Glass works by using the IVSHMEM shared memory device which is fed by an application that captures the guest's video o

[PATCH] block/block-copy: fix s->copy_size for compressed cluster

0e2402452f1f20429 allowed writes larger than cluster, but that's unsupported for compressed write. Fix it. Fixes: 0e2402452f1f20429 Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/block-copy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/block-copy.c b/bloc

Re: [PATCH v1 1/1] target/riscv: Remove atomic accesses to MIP CSR

On Tue, 29 Oct 2019 03:49:23 PDT (-0700), alistai...@gmail.com wrote: On Fri, Oct 18, 2019 at 7:44 PM Alistair Francis wrote: On Fri, Oct 18, 2019 at 9:51 AM Palmer Dabbelt wrote: > > On Tue, 08 Oct 2019 15:04:18 PDT (-0700), Alistair Francis wrote: > > Instead of relying on atomics to access

[Bug 1850378] Re: RISC-V unreliable IPIs

Can you post a whole program that reproduces this? freedom-e-sdk will run bare-metal code on QEMU if you don't want to post the rest of the surrounding infrastructure. -- You received this bug notification because you are a member of qemu- devel-ml, whic

Re: [PULL v2 00/12] tcg patch queue

On Mon, 28 Oct 2019 at 14:59, Richard Henderson wrote: > > V2 fixes a build problem that affected win32. > > > r~ > > > The following changes since commit 187f35512106501fe9a11057f4d8705431e0026d: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-testing-next-251019-3' into staging

Re: [PATCH v5 00/13] Multi-phase reset mechanism

Hi, Does anyone has comment about the interface / patch 3 ? Should I try to split it ? Thanks, Damien On 10/18/19 5:06 PM, Damien Hedde wrote: > Hi all, > > The purpose of this series is to split the current reset procedure > into multiple phases. This will help to solve some ordering > difficu

[PATCH 3/6] docs: disable sphinx warning about missing cross references

Sphinx is a bit *too* strict about missing cross references to C types, where it complains about missing references to uint8_t. Even if that were fixed in kernel-doc, we would still have lots of missing references to types that are not yet documented. So unfortunately let's disable for now the nit

[RFC PATCH 0/6] docs: integrate doc comments with Sphinx build

Hello, this is an attempt at including kernel-doc, with small tweaks (see patch 2) to support QEMU's doc comment format, in the Sphinx documentation pipeline. The ugly part is patch 3, which disables Sphinx's "nitpicking" (warn on invalid cross-reference) mode. It would probably be possible to u

[PATCH 2/6] docs: tweak kernel-doc for QEMU coding standards

Surprisingly, QEMU does have a pretty consistent doc comment style and it is not very different from the Linux kernel's. Of the documentation "sigils", only "#" separates the QEMU doc comment style from Linux's, and it has 200+ instances vs. 6 for the kernel's '&struct foo' (all in accel/tcg/trans

[PATCH 1/6] docs: import Linux kernel-doc script and extension

Import Linux's kernel-doc script, as well as the Linux extension to call kernel-doc according to the arguments and parameters given to a reStructuredText directive. The kernel-doc extension accepts a filename, which is relative to the QEMU source tree root. The extension also notifies Sphinx abou

[PATCH 4/6] memory: adjust API documentation to (modified) kerneldoc format

Fix a few instances where kernel-doc complains about doc comments in memory.h. Signed-off-by: Paolo Bonzini --- include/exec/memory.h | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index e499dc215b..1e875996ec 1

[PATCH 6/6] memory: include MemoryListener documentation and some missing function parameters

These cover the remaining warnings from kernel-doc. Signed-off-by: Paolo Bonzini --- include/exec/memory.h | 211 +- 1 file changed, 209 insertions(+), 2 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 1e875996ec..c84fde75fa

[PATCH 5/6] docs: add memory API reference

Add kernel-doc directive to parse and include doc comments from include/exec/memory.h. Signed-off-by: Paolo Bonzini --- docs/devel/memory.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/devel/memory.rst b/docs/devel/memory.rst index b6a4c37ea5..5dc8a12682 100644 --- a/docs/deve

Re: [PULL 0/4] Crypto luks patches

On Mon, 28 Oct 2019 at 15:58, Daniel P. Berrangé wrote: > > The following changes since commit 187f35512106501fe9a11057f4d8705431e0026d: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-testing-next-251019-3' into staging (2019-10-26 > 10:13:48 +0100) > > are available in the Git

[PATCH 1/2] fw_cfg: Allow reboot-timeout=-1 again

From: "Dr. David Alan Gilbert" Commit ee5d0f89de3e53cdb0dc added range checking on reboot-timeout to only allow the range 0..65535; however both qemu and libvirt document the special value -1 to mean don't reboot. Allow it again. Fixes: ee5d0f89de3e53cdb0dc ("fw_cfg: Fix -boot reboot-timeout er

[PATCH 0/2] fw_cfg: Allow reboot-timeout=-1 again

Fix the '-1' special value, and add a test. Dr. David Alan Gilbert (1): fw_cfg: Allow reboot-timeout=-1 again Philippe Mathieu-Daudé (1): tests/fw_cfg: Test 'reboot-timeout=-1' special value hw/nvram/fw_cfg.c | 7 --- tests/fw_cfg-test.c | 21 + 2 files changed, 2

[PATCH 2/2] tests/fw_cfg: Test 'reboot-timeout=-1' special value

The special value -1 means "don't reboot" for QEMU/libvirt. Add a trivial test. Signed-off-by: Philippe Mathieu-Daudé --- tests/fw_cfg-test.c | 21 + 1 file changed, 21 insertions(+) diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c index 1d3147f821..5dc807ba23 100644 -

Re: [PULL 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge

Hi Aleksandar, On 10/29/19 6:18 AM, Aleksandar Markovic wrote: On Monday, October 28, 2019, Philippe Mathieu-Daudé > wrote: Hi Peter, This is a X86/MIPS pull, Paolo and Aleksandar are OK I send it: https://lists.gnu.org/archive/html/qemu-devel/2019-10/

[Bug 1850378] Re: RISC-V unreliable IPIs

I created a minimal example from my setup. I'm running a kernel 4.19.57 with a custom firmware based on bbl (https://github.com/riscv/riscv-pk). An ioctl device from a kernel module is used to execute the code above in kernel space. In the example, the userspace application proceeds after a coup

Re: [PULL 00/11] Q800 branch patches

On Mon, 28 Oct 2019 at 18:48, Laurent Vivier wrote: > > The following changes since commit 7bc8f9734213b76e76631a483be13d6737c2adbc: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20191025' into staging (2019-10-25 > 13:12:16 +0100) > > are available in the Git repos

Re: [RFC PATCH 0/6] docs: integrate doc comments with Sphinx build

Patchew URL: https://patchew.org/QEMU/20191029162248.13383-1-pbonz...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [RFC PATCH 0/6] docs: integrate doc comments with Sphinx build

On Tue, 29 Oct 2019 at 16:22, Paolo Bonzini wrote: > > Hello, > > this is an attempt at including kernel-doc, with small tweaks (see patch > 2) to support QEMU's doc comment format, in the Sphinx documentation pipeline. > > The ugly part is patch 3, which disables Sphinx's "nitpicking" (warn on >

Re: [PULL 0/1] qemu-openbios queue 20191028

On Mon, 28 Oct 2019 at 19:42, Mark Cave-Ayland wrote: > > [This contains a last-minute bugfix for qemu-system-sparc which fixes the > keyboard > in OpenBIOS when booting in graphics mode.] > > The following changes since commit 9bb73502321d46f4d320fa17aa38201445783fc4: > > Merge remote-tracking

Re: [PATCH] fdc: support READ command with VERIFY DMA mode

Le 29/10/2019 à 12:00, John Snow a écrit : > > > On 10/20/19 2:38 AM, Sven Schnelle wrote: >> While working on the Tulip driver i tried to write some Teledisk images to >> a floppy image which didn't work. Turned out that Teledisk checks the written >> data by issuing a READ command to the FDC but

  1   2   >