On Tue, Oct 29, 2019 at 01:50:02PM +0100, Markus Armbruster wrote:
Jens Freimann <jfreim...@redhat.com> writes:

This event is emitted when we sent a request to unplug a

Uh, "we sent a requestion [...] from the Guest OS"...  do you mean "we
received"?

No, we sent a pci hotplug event to the guest by "pushing" the pcie attention
button. So, it's QEMU requesting the unplug.

+##
+# @UNPLUG_PRIMARY:
+#
+# Emitted from source side of a migration when migration state is
+# WAIT_UNPLUG. Device was unplugged by guest operating system.
+# Device resources in QEMU are kept on standby to be able to re-plug it in case
+# of migration failure.
+#
+# @device-id: QEMU device id of the unplugged device
+#
+# Since: 4.2
+#
+# Example:
+#   {"event": "UNPLUG_PRIMARY", "data": {"device-id": "hostdev0"} }
+#
+##
+{ 'event': 'UNPLUG_PRIMARY',
+  'data': { 'device-id': 'str' } }

Commit message might need a touch-up.  Regardless:
Acked-by: Markus Armbruster <arm...@redhat.com>

Thanks for the review!

regards,
Jens

Reply via email to