Thomas Huth <th...@redhat.com> writes:
> On 18/10/2019 20.17, Eduardo Habkost wrote: >> From: Gerd Hoffmann <kra...@redhat.com> >> >> Instead of fetching the prebuilt image from patchew download the install >> iso and prepare the image locally. Install to disk, using the serial >> console. Create qemu user, configure ssh login. Install packages >> needed for qemu builds. >> >> Signed-off-by: Gerd Hoffmann <kra...@redhat.com> >> Reviewed-by: Kamil Rytarowski <n...@gmx.com> >> Tested-by: Thomas Huth <th...@redhat.com> >> [ehabkost: rebased to latest qemu.git master] >> Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> >> --- >> tests/vm/netbsd | 189 +++++++++++++++++++++++++++++++++++++++++++++--- >> 1 file changed, 179 insertions(+), 10 deletions(-) >> >> diff --git a/tests/vm/netbsd b/tests/vm/netbsd >> index ee9eaeab50..49a99477f4 100755 >> --- a/tests/vm/netbsd >> +++ b/tests/vm/netbsd >> @@ -2,10 +2,11 @@ >> # >> # NetBSD VM image >> # >> -# Copyright 2017 Red Hat Inc. >> +# Copyright 2017-2019 Red Hat Inc. >> # >> # Authors: >> # Fam Zheng <f...@redhat.com> >> +# Gerd Hoffmann <kra...@redhat.com> >> # >> # This code is licensed under the GPL version 2 or later. See >> # the COPYING file in the top-level directory. >> @@ -13,30 +14,198 @@ >> >> import os >> import sys >> +import time >> import subprocess >> import basevm >> >> class NetBSDVM(basevm.BaseVM): >> name = "netbsd" >> arch = "x86_64" >> + >> + link = >> "https://cdn.netbsd.org/pub/NetBSD/NetBSD-8.0/images/NetBSD-8.0-amd64.iso"; > > I'd like to suggest to go immediately with 8.1 instead of 8.0. I tested > it and it worked for me out-of-the-box, without further modifications. *Sigh* I had to drop this from my PR after it broke again. It looked like it was getting stuck on the installer waiting for something. I had it working at one point so I'm not sure why it's not working again. The rest of the patches are merged now though. > >> + >> + if os.path.exists(img): >> + os.remove(img) > > These two lines have been removed recently with commit > fcd2060e8efff83b7bdef04323077f87e011fdc4 ... please drop them from the > patch. > > Thanks, > Thomas -- Alex Bennée
