Re: [PATCH v7 19/20] target/arm: Rebuild hflags for M-profile.

2019-10-18 Thread Richard Henderson
On 10/18/19 5:25 AM, Peter Maydell wrote: > On Thu, 17 Oct 2019 at 19:51, Richard Henderson > wrote: >> >> Continue setting, but not relying upon, env->hflags. >> >> Reviewed-by: Alex Bennée >> Signed-off-by: Richard Henderson >> --- >> v7: Add rebuilds for v7m_msr and nvic_writel to v7m.ccr. >>

Re: [PATCH v7 17/20] target/arm: Rebuild hflags at MSR writes

2019-10-18 Thread Richard Henderson
On 10/18/19 5:32 AM, Peter Maydell wrote: > On Thu, 17 Oct 2019 at 19:51, Richard Henderson > wrote: >> >> Continue setting, but not relying upon, env->hflags. >> >> Reviewed-by: Alex Bennée >> Signed-off-by: Richard Henderson >> --- >> target/arm/translate-a64.c | 13 +++-- >> target/a

Re: [PATCH] blockdev: modify blockdev-change-medium to change non-removable device

2019-10-18 Thread Eric Blake
On 10/18/19 7:09 AM, Denis Plotnikov wrote: The modification is useful to workaround exclusive file access restrictions, e.g. to implement VM migration with shared disk stored on a storage with the exclusive file opening model: a destination VM is started waiting for incomming migration with a fa

Re: [PATCH v8 1/3] docs: improve qcow2 spec about extending image header

2019-10-18 Thread Vladimir Sementsov-Ogievskiy
18.10.2019 17:00, Eric Blake wrote: > On 10/18/19 4:47 AM, Vladimir Sementsov-Ogievskiy wrote: >> Make it more obvious how to add new fields to the version 3 header and >> how to interpret them. >> >> The specification is adjusted so for new defined optional fields: > > The specification is adjust

Re: [PATCH v8 2/3] docs: define padding for qcow2 header

2019-10-18 Thread Vladimir Sementsov-Ogievskiy
18.10.2019 17:02, Eric Blake wrote: > On 10/18/19 4:47 AM, Vladimir Sementsov-Ogievskiy wrote: >> Header extensions ends are already defined to be multiply of 8. Let's >> gently ask for header length to be a multiply of 8 too, when we have >> some additional fields. Requiring this may be considered

Re: [PATCH v8 3/3] docs: qcow2: introduce compression type feature

2019-10-18 Thread Vladimir Sementsov-Ogievskiy
18.10.2019 17:04, Eric Blake wrote: > On 10/18/19 4:47 AM, Vladimir Sementsov-Ogievskiy wrote: >> The patch add new additional field to qcow2 header: compression_type, >> which specifies compression type. If field is absent or zero, default >> compression type is set: ZLIB, which corresponds to cur

Re: [PATCH 0/2] tests/acceptance: Add tests for the PA-RISC machine

2019-10-18 Thread Sven Schnelle
Hi Philippe, On Fri, Oct 18, 2019 at 04:23:10PM +0200, Philippe Mathieu-Daudé wrote: > Sven since you tested this series, can I add your Tested-by tag? Sure, please do. > On Thu, Oct 10, 2019 at 2:21 PM Philippe Mathieu-Daudé > wrote: > > > > This tests boot a HP-UX firmware CD-ROM which allow

Re: [PATCH v2] .travis.yml: Test the release tarball

2019-10-18 Thread Philippe Mathieu-Daudé
ping? On 10/7/19 6:04 PM, Philippe Mathieu-Daudé wrote: Add a job to generate the release tarball and build/install few QEMU targets from it. Ideally we should build the 'efi' target from the 'roms' directory, but it is too time consuming. This job is only triggered when a tag starting with 'v

Re: [PATCH] hw/timer/exynos4210_mct: Initialize ptimer before starting it

2019-10-18 Thread Philippe Mathieu-Daudé
On 10/18/19 4:31 PM, Peter Maydell wrote: From: Guenter Roeck When booting a recent Linux kernel, the qemu message "Timer with delta zero, disabling" is seen, apparently because a ptimer is started before being initialized. Fix the problem by initializing the offending ptimer before starting i

Re: Default CPU models on s390x and ppc64

2019-10-18 Thread Christian Borntraeger
On 17.10.19 17:18, David Hildenbrand wrote: > On 17.10.19 17:16, Jiri Denemark wrote: >> Hi David and David, >> >> I'm working on libvirt's support [1] for query-machines' >> default-cpu-type, which is supposed to return the type of the default >> CPU model that QEMU uses for each machine type.

Re: [PATCH] iotests: Skip read-only cases in 118 when run as root

2019-10-18 Thread Philippe Mathieu-Daudé
On 10/18/19 4:27 PM, Kevin Wolf wrote: Am 18.10.2019 um 14:59 hat Philippe Mathieu-Daudé geschrieben: Hi Kevin, On 10/18/19 1:51 PM, Kevin Wolf wrote: Some tests in 118 use chmod to remove write permissions from the file and assume that the image can indeed not be opened read-write afterwards.

Re: [RFC 2/3] acpi: cpuhp: add typical usecases into spec

2019-10-18 Thread Igor Mammedov
On Thu, 10 Oct 2019 16:13:22 +0200 Laszlo Ersek wrote: > On 10/09/19 15:22, Igor Mammedov wrote: > > Clarify values of "CPU selector' register and add workflows for > > * finding CPU with pending 'insert/remove' event > > * enumerating present/non present CPUs > > > > Signed-off-by: Igor Mam

Re: [PATCH 1/4] target/arm: Vectorize USHL and SSHL

2019-10-18 Thread Richard Henderson
On 10/17/19 9:01 AM, Alex Bennée wrote: >> +/* >> + * Rely on the TCG guarantee that out of range shifts produce >> + * unspecified results, not undefined behaviour (i.e. no trap). >> + * Discard out-of-range results after the fact. >> + */ >> +tcg_gen_ext8s_i32(lsh, b); >>

Re: [PATCH 0/5] hw/arm/exynos4210: Add acceptance tests to the SMDKC210 board

2019-10-18 Thread Philippe Mathieu-Daudé
Hi Peter, On 10/5/19 5:47 PM, Philippe Mathieu-Daudé wrote: Hi all, Yesterday Peter Maydell asked on IRC if I had any working Exynos4 image. I looked at some old backuped notes and could boot Guenter initrd with BusyBox. I'll use this cover letter to share my notes, they might help to have this

Re: [PATCH v7 17/20] target/arm: Rebuild hflags at MSR writes

2019-10-18 Thread Peter Maydell
On Fri, 18 Oct 2019 at 15:30, Richard Henderson wrote: > > On 10/18/19 5:32 AM, Peter Maydell wrote: > > On Thu, 17 Oct 2019 at 19:51, Richard Henderson > > wrote: > > Why only rebuild hflags if !ARM_CP_SUPPRESS_TB_END ? > > For instance on the Xscale CPUs we set SUPPRESS_TB_END for the SCTLR, >

Re: Python 2 and test/vm/netbsd

2019-10-18 Thread Eduardo Habkost
On Fri, Oct 18, 2019 at 09:13:24AM +0200, Thomas Huth wrote: > On 18/10/2019 00.55, Eduardo Habkost wrote: > > On Thu, Oct 17, 2019 at 07:05:41PM -0300, Eduardo Habkost wrote: > >> On Wed, Oct 16, 2019 at 07:41:24PM -0300, Eduardo Habkost wrote: > >>> On Wed, Oct 16, 2019 at 08:11:57AM +0200, Thoma

Re: [PATCH v7 19/20] target/arm: Rebuild hflags for M-profile.

2019-10-18 Thread Peter Maydell
On Fri, 18 Oct 2019 at 15:31, Richard Henderson wrote: > > On 10/18/19 5:25 AM, Peter Maydell wrote: > > This seems fragile -- we have to remember to add in > > a call to arm_rebuild_hflags() for every individual > > case of a memory-mapped system register that we choose > > to cache in tb flags.

Re: [PATCH v7 19/20] target/arm: Rebuild hflags for M-profile.

2019-10-18 Thread Peter Maydell
On Fri, 18 Oct 2019 at 15:52, Peter Maydell wrote: > > On Fri, 18 Oct 2019 at 15:31, Richard Henderson > wrote: > > > > On 10/18/19 5:25 AM, Peter Maydell wrote: > > > This seems fragile -- we have to remember to add in > > > a call to arm_rebuild_hflags() for every individual > > > case of a mem

Re: Python 2 and test/vm/netbsd

2019-10-18 Thread Philippe Mathieu-Daudé
On 10/18/19 4:29 PM, Eduardo Habkost wrote: On Fri, Oct 18, 2019 at 12:44:39PM +0200, Gerd Hoffmann wrote: Hi, Running with V=1, I see packages being downloaded at reasonable speeds, but there's a huge interval (of various minutes) between each package download. I've found the cause for t

Re: [PATCH] iotests: Skip read-only cases in 118 when run as root

2019-10-18 Thread Max Reitz
On 18.10.19 16:27, Kevin Wolf wrote: > Am 18.10.2019 um 14:59 hat Philippe Mathieu-Daudé geschrieben: >> Hi Kevin, >> >> On 10/18/19 1:51 PM, Kevin Wolf wrote: >>> Some tests in 118 use chmod to remove write permissions from the file >>> and assume that the image can indeed not be opened read-write

Re: [PATCH] blockdev: modify blockdev-change-medium to change non-removable device

2019-10-18 Thread Max Reitz
On 18.10.19 14:09, Denis Plotnikov wrote: > The modification is useful to workaround exclusive file access restrictions, > e.g. to implement VM migration with shared disk stored on a storage with > the exclusive file opening model: a destination VM is started waiting for > incomming migration with

Re: [PATCH 2/4] mc146818rtc: Move RTC_ISA_IRQ definition

2019-10-18 Thread Thomas Huth
On 18/10/2019 15.35, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > The ISA default number for the RTC devices is not related to its > registers neither. Move this definition to "hw/timer/mc146818rtc.h". > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/timer/mc146

[PATCH v5 07/13] hw/core/qdev: update hotplug reset regarding resettable

2019-10-18 Thread Damien Hedde
This commit make use of the resettable API to reset the device being hotplugged during when it is realized. Also it make sure it is put in a reset state coherent with the parent it is plugged into. Signed-off-by: Damien Hedde --- I'm not sure I've done everything that's required here since I do

[PATCH v5 02/13] hw/core/qdev: add trace events to help with resettable transition

2019-10-18 Thread Damien Hedde
Adds trace events to reset procedure and when updating the parent bus of a device. Signed-off-by: Damien Hedde --- hw/core/qdev.c | 27 --- hw/core/trace-events | 9 + 2 files changed, 33 insertions(+), 3 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/

[PATCH v5 05/13] hw/core/resettable: add support for changing parent

2019-10-18 Thread Damien Hedde
Add a function resettable_change_parent() to do the required plumbing when changing the parent a of Resettable object. We need to make sure that the reset state of the object remains coherent with the reset state of the new parent. We make the 2 following hypothesis: + when an object is put in a

[PATCH v5 00/13] Multi-phase reset mechanism

2019-10-18 Thread Damien Hedde
Hi all, The purpose of this series is to split the current reset procedure into multiple phases. This will help to solve some ordering difficulties we have during reset. Previous version can be found here: https://lists.gnu.org/archive/html/qemu-devel/2019-08/msg04359.html This series adds resett

[PATCH v5 10/13] vl: replace deprecated qbus_reset_all registration

2019-10-18 Thread Damien Hedde
Replace deprecated qbus_reset_all by resettable_cold_reset_fn for the sysbus reset registration. Apart for the raspi machines, this does not impact the behavior because: + at this point resettable just call the old reset methods of devices and buses in the same order than qdev/qbus. + resettable

[PATCH v5 06/13] hw/core/qdev: handle parent bus change regarding resettable

2019-10-18 Thread Damien Hedde
In qdev_set_parent_bus(), when changing the parent bus of a realized device, if the source and destination buses are not in the same reset state, some adaptation are required. This patch adds needed call to resettable_change_parent() to make sure a device reset state stays coherent with its parent

[PATCH v5 01/13] add device_legacy_reset function to prepare for reset api change

2019-10-18 Thread Damien Hedde
Provide a temporary device_legacy_reset function doing what device_reset does to prepare for the transition with Resettable API. All occurrence of device_reset in the code tree are also replaced by device_legacy_reset. The new resettable API has different prototype and semantics (resetting child

[PATCH v5 09/13] docs/devel/reset.txt: add doc about Resettable interface

2019-10-18 Thread Damien Hedde
Signed-off-by: Damien Hedde --- Should I add an entry into index.rst ? --- docs/devel/reset.rst | 282 +++ 1 file changed, 282 insertions(+) create mode 100644 docs/devel/reset.rst diff --git a/docs/devel/reset.rst b/docs/devel/reset.rst new file mode 10

[PATCH v5 08/13] hw/core: deprecate old reset functions and introduce new ones

2019-10-18 Thread Damien Hedde
Deprecate device_legacy_reset(), qdev_reset_all() and qbus_reset_all() to be replaced by new functions device_cold_reset() and bus_cold_reset() which uses resettable API. Also introduce resettable_cold_reset_fn() which may be used as a replacement for qdev_reset_all_fn and qbus_reset_all_fn(). Fo

[PATCH v5 04/13] hw/core: add Resettable support to BusClass and DeviceClass

2019-10-18 Thread Damien Hedde
This commit adds support of Resettable interface to buses and devices: + ResettableState structure is added in the Bus/Device state + Resettable methods are implemented. + device/bus_is_in_reset function defined This commit allows to transition the objects to the new multi-phase interface without

[PATCH v5 03/13] hw/core: create Resettable QOM interface

2019-10-18 Thread Damien Hedde
This commit defines an interface allowing multi-phase reset. This aims to solve a problem of the actual single-phase reset (built in DeviceClass and BusClass): reset behavior is dependent on the order in which reset handlers are called. In particular doing external side-effect (like setting an qemu

[PATCH v5 11/13] hw/s390x/ipl: replace deprecated qdev_reset_all registration

2019-10-18 Thread Damien Hedde
Replace deprecated qdev_reset_all by resettable_cold_reset_fn for the ipl registration in the main reset handlers. This does not impact the behavior for the following reasons: + at this point resettable just call the old reset methods of devices and buses in the same order than qdev/qbus. + rese

[PATCH v5 12/13] hw/gpio/bcm2835_gpio: Isolate sdbus reparenting

2019-10-18 Thread Damien Hedde
Split gpfsel_set() in 2 so that the sdbus reparenting is done in a dedicated function. Signed-off-by: Damien Hedde --- Cc: Peter Maydell Cc: Andrew Baumann Cc: Philippe Mathieu-Daudé Cc: qemu-...@nongnu.org --- hw/gpio/bcm2835_gpio.c | 16 1 file changed, 12 insertions(+), 4

[PATCH v5 13/13] hw/gpio/bcm2835_gpio: Update to resettable

2019-10-18 Thread Damien Hedde
Transition the bcm2835_gpio device class to Resettable. The sdbus reparenting is delayed in hold phase to respect resettable side-effect rules. Signed-off-by: Damien Hedde --- Cc: Peter Maydell Cc: Andrew Baumann Cc: Philippe Mathieu-Daudé Cc: qemu-...@nongnu.org --- hw/gpio/bcm2835_gpio.c |

Re: [PATCH v2 1/5] hbitmap: handle set/reset with zero length

2019-10-18 Thread Max Reitz
On 11.10.19 11:07, Vladimir Sementsov-Ogievskiy wrote: > Passing zero length to these functions leads to unpredicted results. > Zero-length set/reset may occur in active-mirror, on zero-length write > (which is unlikely, but not guaranteed to never happen). > > Let's just do nothing on zero-length

Re: [PATCH v6 37/54] plugin: expand the plugin_init function to include an info block

2019-10-18 Thread Aaron Lindsay OS
On Oct 17 14:15, Alex Bennée wrote: > This provides a limited amount of info to plugins about the guest > system that will allow them to make some additional decisions on > setup. > > Signed-off-by: Alex Bennée > > --- > v6 > - split and move to pre example plugins > - checkpatch fixes > ---

Re: [PULL 00/13] Audio 20191018 patches

2019-10-18 Thread Peter Maydell
ilable in the Git repository at: > > git://git.kraxel.org/qemu tags/audio-20191018-pull-request > > for you to fetch changes up to 0cf13e367a99dd1abefc46ec94b4c1a80c678f61: > > paaudio: fix channel order for usb-audio

[PATCH 01/14] sm501: replace PROP_PTR with PROP_LINK

2019-10-18 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- hw/display/sm501.c | 5 +++-- hw/sh4/r2d.c | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 1f33c87e65..a87d18efab 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501.c @@ -1930,7 +1

[PATCH 00/14] Clean-ups: remove QDEV_PROP_PTR

2019-10-18 Thread Marc-André Lureau
Hi, QDEV_PROP_PTR is marked in multiple places as "FIXME/TODO/remove me". In most cases, it can be easily replaced with QDEV_PROP_LINK when the pointer points to an Object. There are a few places where such substitution isn't possible. For those places, it seems reasonable to use a specific sette

[PATCH 05/14] dp8393x: replace PROP_PTR with PROP_LINK

2019-10-18 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- hw/mips/mips_jazz.c | 3 ++- hw/net/dp8393x.c| 7 +++ 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/mips/mips_jazz.c b/hw/mips/mips_jazz.c index 8d010a0b6e..878925a963 100644 --- a/hw/mips/mips_jazz.c +++ b/hw/mips/mips_jazz.c @@ -2

[PATCH 12/14] omap-gpio: remove PROP_PTR

2019-10-18 Thread Marc-André Lureau
Since clock are not QOM objects, replace PROP_PTR of clocks with setters methods. Signed-off-by: Marc-André Lureau --- hw/arm/omap1.c| 2 +- hw/arm/omap2.c| 13 +++-- hw/gpio/omap_gpio.c | 42 +++--- include/hw/arm/omap.h | 17 ++

[PATCH 02/14] vmmouse: replace PROP_PTR with PROP_LINK

2019-10-18 Thread Marc-André Lureau
While at it, use the expected type. Signed-off-by: Marc-André Lureau --- hw/i386/pc.c | 6 +++--- hw/i386/vmmouse.c| 8 +++- hw/input/pckbd.c | 8 +++- include/hw/input/i8042.h | 4 +++- 4 files changed, 12 insertions(+), 14 deletions(-) diff --git a/hw/i386/

[PATCH 03/14] lance: replace PROP_PTR with PROP_LINK

2019-10-18 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- hw/dma/sparc32_dma.c | 2 +- hw/net/lance.c | 5 ++--- hw/net/pcnet-pci.c | 2 +- hw/net/pcnet.h | 2 +- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/dma/sparc32_dma.c b/hw/dma/sparc32_dma.c index 0e5bbcdc7f..3e4da0c47f 10064

[PATCH 09/14] smbus-eeprom: remove PROP_PTR

2019-10-18 Thread Marc-André Lureau
Instead, set the initial data field directly. Since it is only 256 bytes, let's simply copy it to avoid invalid pointers issues. Signed-off-by: Marc-André Lureau --- hw/i2c/smbus_eeprom.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/hw/i2c/smbus_eeprom.c

[PATCH 14/14] Remove QDEV_PROP_PTR

2019-10-18 Thread Marc-André Lureau
No longer used in the tree. The comment about user_creatable is still quite relevant, but there is already a similar comment in qdev-core.h. Signed-off-by: Marc-André Lureau --- hw/core/qdev-properties.c| 18 -- include/hw/qdev-properties.h | 22 -- 2 file

[PATCH 06/14] leon3: replace PROP_PTR with PROP_LINK

2019-10-18 Thread Marc-André Lureau
"set_pil_in" and "set_pil_in" are used to set a callback, but have a single user and cannot be modified by the user. Simplify the code by calling directly into leon3_set_pil_in(), and use a "cpu" link property. Signed-off-by: Marc-André Lureau --- hw/intc/grlib_irqmp.c | 20 ++--

[PATCH 04/14] etraxfs: remove PROP_PTR usage

2019-10-18 Thread Marc-André Lureau
etraxfs_dma_client are not Object, so can't be exposed to user with QOM path. Let's remove property usage and move the constructor to the .c unit, simplifying some code on the way. Signed-off-by: Marc-André Lureau --- hw/net/etraxfs_eth.c | 35 --- include/hw

[PATCH 10/14] omap-intc: remove PROP_PTR

2019-10-18 Thread Marc-André Lureau
Since clock are not QOM objects, replace PROP_PTR of clocks with setters methods. (in theory there should probably be different methods for omap1 & omap2 intc, but this is left as a future improvement) Signed-off-by: Marc-André Lureau --- hw/arm/omap1.c| 4 ++-- hw/arm/omap2.c|

[PATCH 13/14] qdev: remove PROP_MEMORY_REGION

2019-10-18 Thread Marc-André Lureau
PROP_MEMORY_REGION was a derivative of PROP_PTR, added in commit ed03d749f3f513b8fb0287757cfda2cb6825f063 (qdev: add MemoryRegion property) and thankfully no longer needed since commit 3eff40dbf44896a8180c86c84dbdefb2eb173fbe (hw/misc: Remove mmio_interface device). Signed-off-by: Marc-André Lurea

[PATCH 11/14] omap-i2c: remove PROP_PTR

2019-10-18 Thread Marc-André Lureau
Since clock are not QOM objects, replace PROP_PTR of clocks with setters methods. Signed-off-by: Marc-André Lureau --- hw/arm/omap1.c| 2 +- hw/arm/omap2.c| 8 hw/i2c/omap_i2c.c | 19 --- include/hw/arm/omap.h | 9 + 4 files changed, 26 ins

[PATCH 07/14] RFC: mips/cps: fix setting saar property

2019-10-18 Thread Marc-André Lureau
There is no "saar" property. Note: I haven't been able to test this code. Help welcome. May fix commit 043715d1e0fbb3e3411be3f898c5b77b7f90327a ("target/mips: Update ITU to utilize SAARI and SAAR CP0 registers") Signed-off-by: Marc-André Lureau --- hw/mips/cps.c | 2 +- 1 file changed, 1 insert

[PATCH 08/14] cris: replace PROP_PTR with PROP_LINK for interrupt vector

2019-10-18 Thread Marc-André Lureau
Instead of using raw interrupt vector pointer, store the associated CPU with a link property. Signed-off-by: Marc-André Lureau --- hw/cris/axis_dev88.c | 4 +--- hw/intc/Makefile.objs | 2 +- hw/intc/etraxfs_pic.c | 18 +++--- 3 files changed, 9 insertions(+), 15 deletions(-) dif

Re: [PATCH v6 37/54] plugin: expand the plugin_init function to include an info block

2019-10-18 Thread Alex Bennée
Aaron Lindsay OS writes: > On Oct 17 14:15, Alex Bennée wrote: >> This provides a limited amount of info to plugins about the guest >> system that will allow them to make some additional decisions on >> setup. >> >> Signed-off-by: Alex Bennée >> >> --- >> v6 >> - split and move to pre exampl

Re: [PATCH v2] .travis.yml: Test the release tarball

2019-10-18 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > ping? I've pulled it into testing/next to play but I was wondering if it was worth it given how infrequently it would run... > > On 10/7/19 6:04 PM, Philippe Mathieu-Daudé wrote: >> Add a job to generate the release tarball and build/install few >> QEMU targe

Re: [PATCH v2 4/5] block/mirror: support unaligned write in active mirror

2019-10-18 Thread Max Reitz
On 11.10.19 11:07, Vladimir Sementsov-Ogievskiy wrote: > Prior 9adc1cb49af8d do_sync_target_write had a bug: it reset aligned-up > region in the dirty bitmap, which means that we may not copy some bytes > and assume them copied, which actually leads to producing corrupted > target. > > So 9adc1cb4

Re: [PATCH 04/14] etraxfs: remove PROP_PTR usage

2019-10-18 Thread Peter Maydell
On Fri, 18 Oct 2019 at 16:42, Marc-André Lureau wrote: > > etraxfs_dma_client are not Object, so can't be exposed to user with > QOM path. Let's remove property usage and move the constructor to the > .c unit, simplifying some code on the way. > > Signed-off-by: Marc-André Lureau > + > +/* Insta

Re: [PATCH v2] Do not use %m in common code to print error messages

2019-10-18 Thread Thomas Huth
On 18/10/2019 15.49, Kamil Rytarowski wrote: > On 18.10.2019 15:42, Stefano Garzarella wrote: >> On Fri, Oct 18, 2019 at 03:07:16PM +0200, Thomas Huth wrote: >>> The %m format specifier is an extension from glibc - and when compiling >>> QEMU for NetBSD, the compiler correctly complains, e.g.: >>>

Re: [PATCH v2 0/5] active-mirror: support unaligned guest operations

2019-10-18 Thread Max Reitz
On 11.10.19 11:07, Vladimir Sementsov-Ogievskiy wrote: > Commit 9adc1cb49af8d fixed a bug about unaligned (to dirty bitmap > granularity) guest writes (and discards) by simply requesting > corresponding alignment on mirror-top filter. However forcing large > alignment obviously decreases performanc

Re: Python 2 and test/vm/netbsd

2019-10-18 Thread Samuel Thibault
Philippe Mathieu-Daudé, le ven. 18 oct. 2019 16:58:00 +0200, a ecrit: > On 10/18/19 4:29 PM, Eduardo Habkost wrote: > > On Fri, Oct 18, 2019 at 12:44:39PM +0200, Gerd Hoffmann wrote: > > >Hi, > > > > > > > > Running with V=1, I see packages being downloaded at reasonable > > > > > speeds, but

Re: [PATCH v2 00/23] iotests: Add and use $SOCK_DIR

2019-10-18 Thread Max Reitz
On 17.10.19 15:31, Max Reitz wrote: > Hi, > > Perhaps the main reason we cannot run important tests such as 041 in CI > is that when they care Unix sockets in $TEST_DIR, the path may become > too long to connect to them. > > To get by this problem, this series lets the check script create a new >

Re: [PATCH 08/10] nbd/server: introduce NBDExtentArray

2019-10-18 Thread Vladimir Sementsov-Ogievskiy
09.10.2019 20:02, Eric Blake wrote: > On 9/30/19 10:15 AM, Vladimir Sementsov-Ogievskiy wrote: >> Introduce NBDExtentArray class, to handle extents list creation in more >> controlled way and with less OUT parameters in functions. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >>   nbd/s

[PATCH v1 5/6] s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW INDICATION

2019-10-18 Thread David Hildenbrand
Testing this, there seems to be something messed up. We are dealing with unsigned numbers. "Each operand is treated as an unsigned binary integer." Let's just implement as written in the PoP: "A subtraction is performed by adding the contents of the second operand with the bitwise complement of

[PATCH v1 0/6] s390x/tcg: Vector instruction fixes

2019-10-18 Thread David Hildenbrand
Ivan reported that a simple $ go get -v -d github.com/FactomProject/factom Will result in errors when vector instructions are in use. Turns out golang makes excessive use of vector instructions, e.g., for crypto, hashes but also basic math. I tracked the involved vector instructions and start

[PATCH] iotests: Remove 130 from the "auto" group

2019-10-18 Thread Thomas Huth
Peter hit a "Could not open 'TEST_DIR/t.IMGFMT': Failed to get shared 'write' lock - Is another process using the image [TEST_DIR/t.IMGFMT]?" error with 130 already twice. Looks like this test is a little bit shaky, and currently nobody has a real clue what could be causing this issue, so for the t

[PATCH v1 6/6] s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW COMPUTE BORROW INDICATION

2019-10-18 Thread David Hildenbrand
The numbers are unsigned, the computation is wrong. "Each operand is treated as an unsigned binary integer". Let's implement as given in the PoP: "A subtraction is performed by adding the contents of the second operand with the bitwise complement of the third operand along with a borrow indicati

[PATCH v1 1/6] s390x/tcg: Fix VECTOR MULTIPLY LOGICAL ODD

2019-10-18 Thread David Hildenbrand
We have to read from odd offsets. Fixes: 2bf3ee38f1f8 ("s390x/tcg: Implement VECTOR MULTIPLY *") Signed-off-by: David Hildenbrand --- target/s390x/vec_int_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/vec_int_helper.c b/target/s390x/vec_int_helper.c in

[PATCH v1 2/6] s390x/tcg: Fix VECTOR MULTIPLY AND ADD *

2019-10-18 Thread David Hildenbrand
We missed that we always read a "double-wide even-odd element pair of the fourth operand". Fix it in all four variants. Fixes: 1b430aec4157 ("s390x/tcg: Implement VECTOR MULTIPLY AND ADD *") Signed-off-by: David Hildenbrand --- target/s390x/vec_int_helper.c | 8 1 file changed, 4 insert

Re: [PATCH 04/14] etraxfs: remove PROP_PTR usage

2019-10-18 Thread Marc-André Lureau
Hi On Fri, Oct 18, 2019 at 5:59 PM Peter Maydell wrote: > > On Fri, 18 Oct 2019 at 16:42, Marc-André Lureau > wrote: > > > > etraxfs_dma_client are not Object, so can't be exposed to user with > > QOM path. Let's remove property usage and move the constructor to the > > .c unit, simplifying some

[PATCH v1 4/6] s390x/tcg: Fix VECTOR SUBTRACT COMPUTE BORROW INDICATION

2019-10-18 Thread David Hildenbrand
Looks like my idea of what a "borrow" is was wrong. We are dealing with unsigned numbers. A subtraction is simply an addition with the bitwise complement. If we get a carry during the addition, that's the borrow. "The operands are treated as unsigned binary integers." This is nice, as we can reuse

[PATCH v1 3/6] s390x/tcg: Fix VECTOR SHIFT RIGHT ARITHMETIC BY BYTE

2019-10-18 Thread David Hildenbrand
We forgot to propagate the highest bit accross the high doubleword in two cases (shift >=64). Fixes: 5f724887e3dd ("s390x/tcg: Implement VECTOR SHIFT RIGHT ARITHMETIC") Signed-off-by: David Hildenbrand --- target/s390x/vec_int_helper.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

Re: [PATCH v2 0/5] active-mirror: support unaligned guest operations

2019-10-18 Thread Vladimir Sementsov-Ogievskiy
18.10.2019 18:54, Max Reitz wrote: > On 11.10.19 11:07, Vladimir Sementsov-Ogievskiy wrote: >> Commit 9adc1cb49af8d fixed a bug about unaligned (to dirty bitmap >> granularity) guest writes (and discards) by simply requesting >> corresponding alignment on mirror-top filter. However forcing large >>

Re: [PATCH 1/5] iotests: remove 'linux' from default supported platforms

2019-10-18 Thread Max Reitz
On 11.10.19 16:50, Thomas Huth wrote: > From: John Snow > > verify_platform will check an explicit whitelist and blacklist instead. > The default will now be assumed to be allowed to run anywhere. > > For tests that do not specify their platforms explicitly, this has the effect > of > enabling

Re: [PATCH 2/5] iotests: Test 041 does not work on macOS

2019-10-18 Thread Max Reitz
On 11.10.19 16:50, Thomas Huth wrote: > 041 works fine on Linux, FreeBSD and OpenBSD, so let's mark it as > only supported on these systems. > > Signed-off-by: Thomas Huth > --- > tests/qemu-iotests/041 | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/qemu-iotest

Re: [RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

2019-10-18 Thread Igor Mammedov
On Thu, 10 Oct 2019 16:56:18 +0200 Laszlo Ersek wrote: > On 10/09/19 15:22, Igor Mammedov wrote: > > Extend CPU hotplug interface to return architecture specific > > identifier for current CPU (in case of x86, it's APIC ID). > > > > Signed-off-by: Igor Mammedov > > --- > > TODO: > > * cripple

Re: [PATCH 01/14] sm501: replace PROP_PTR with PROP_LINK

2019-10-18 Thread Peter Maydell
On Fri, 18 Oct 2019 at 16:42, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > --- > hw/display/sm501.c | 5 +++-- > hw/sh4/r2d.c | 3 ++- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/hw/display/sm501.c b/hw/display/sm501.c > index 1f33c87e65..a87d18ef

[Bug 1847232] Re: qemu TCG in s390x mode issue with calculating HASH

2019-10-18 Thread David Hildenbrand
** Changed in: qemu Assignee: (unassigned) => David Hildenbrand (davidhildenbrand) ** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1847232 Ti

Re: [PATCH 04/14] etraxfs: remove PROP_PTR usage

2019-10-18 Thread Peter Maydell
On Fri, 18 Oct 2019 at 17:11, Marc-André Lureau wrote: > Is there really much difference between: > > dev = qdev_create() > qdev_prop_set_ptr(dev, "prop", ptr); > qdev_init_nofail() > > and > > dev = qdev_create(MYDEV) > MYDEV(dev)->prop = ptr; > qdev_init_nofail() One is easier to grep for than

Re: [PATCH 08/10] nbd/server: introduce NBDExtentArray

2019-10-18 Thread Eric Blake
On 10/18/19 11:07 AM, Vladimir Sementsov-Ogievskiy wrote:   static int nbd_co_send_extents(NBDClient *client, uint64_t handle, -   NBDExtent *extents, unsigned int nb_extents, -   uint64_t length, bool last, -  

Re: [PATCH 01/14] sm501: replace PROP_PTR with PROP_LINK

2019-10-18 Thread Marc-André Lureau
Hi On Fri, Oct 18, 2019 at 6:22 PM Peter Maydell wrote: > > On Fri, 18 Oct 2019 at 16:42, Marc-André Lureau > wrote: > > > > Signed-off-by: Marc-André Lureau > > --- > > hw/display/sm501.c | 5 +++-- > > hw/sh4/r2d.c | 3 ++- > > 2 files changed, 5 insertions(+), 3 deletions(-) > > > > d

Re: [PATCH v2 2/2] migration: savevm_state_handler_insert: constant-time element insertion

2019-10-18 Thread Michael Roth
Quoting Dr. David Alan Gilbert (2019-10-18 04:43:52) > * Laurent Vivier (lviv...@redhat.com) wrote: > > On 18/10/2019 10:16, Dr. David Alan Gilbert wrote: > > > * Scott Cheloha (chel...@linux.vnet.ibm.com) wrote: > > >> savevm_state's SaveStateEntry TAILQ is a priority queue. Priority > > >> sorti

Re: [PATCH 0/5] ARM virt: Add NVDIMM support

2019-10-18 Thread Auger Eric
Hi Shameer, On 10/4/19 5:52 PM, Shameer Kolothum wrote: > This series adds NVDIMM support to arm/virt platform. > This has a dependency on [0] and make use of the GED > device for NVDIMM hotplug events. The series reuses > some of the patches posted by Eric in his earlier > attempt here[1]. > > P

[PATCH] i386/kvm: add NoNonArchitecturalCoreSharing Hyper-V enlightenment

2019-10-18 Thread Vitaly Kuznetsov
Hyper-V TLFS specifies this enlightenment as: "NoNonArchitecturalCoreSharing - Indicates that a virtual processor will never share a physical core with another virtual processor, except for virtual processors that are reported as sibling SMT threads. This can be used as an optimization to avoid the

Re: Python 2 and test/vm/netbsd

2019-10-18 Thread Eduardo Habkost
On Fri, Oct 18, 2019 at 06:00:19PM +0200, Samuel Thibault wrote: > Philippe Mathieu-Daudé, le ven. 18 oct. 2019 16:58:00 +0200, a ecrit: > > On 10/18/19 4:29 PM, Eduardo Habkost wrote: > > > On Fri, Oct 18, 2019 at 12:44:39PM +0200, Gerd Hoffmann wrote: > > > >Hi, > > > > > > > > > > Running w

Re: [PATCH 0/6] migration/postcopy: enable compress during postcopy

2019-10-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191018004850.9888-1-richardw.y...@linux.intel.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [PATCH 01/14] sm501: replace PROP_PTR with PROP_LINK

2019-10-18 Thread Peter Maydell
On Fri, 18 Oct 2019 at 17:36, Marc-André Lureau wrote: > On Fri, Oct 18, 2019 at 6:22 PM Peter Maydell > wrote: > > So I think the right fix here is to properly QOMify the > > code which is not QOMified, ie hw/char/serial.c, in a > > way that means that the various "memory mapped 16650-ish > > d

Re: [PATCH v32 04/13] target/avr: Add instruction translation - Registers definition

2019-10-18 Thread Aleksandar Markovic
On Friday, October 18, 2019, Michael Rolnik wrote: > On Fri, Oct 18, 2019 at 4:23 PM Aleksandar Markovic > wrote: > > > > > > > > On Friday, October 18, 2019, Michael Rolnik wrote: > >> > >> > >> > >> On Fri, Oct 18, 2019 at 11:52 AM Aleksandar Markovic < > aleksandar.m.m...@gmail.com> wrote: >

Re: [PATCH v1 1/1] target/riscv: Remove atomic accesses to MIP CSR

2019-10-18 Thread Palmer Dabbelt
On Tue, 08 Oct 2019 15:04:18 PDT (-0700), Alistair Francis wrote: Instead of relying on atomics to access the MIP register let's update our helper function to instead just lock the IO mutex thread before writing. This follows the same concept as used in PPC for handling interrupts Signed-off-by:

Re: [PATCH] iotests: Skip read-only cases in 118 when run as root

2019-10-18 Thread Kevin Wolf
Am 18.10.2019 um 17:00 hat Max Reitz geschrieben: > On 18.10.19 16:27, Kevin Wolf wrote: > > Am 18.10.2019 um 14:59 hat Philippe Mathieu-Daudé geschrieben: > >> Hi Kevin, > >> > >> On 10/18/19 1:51 PM, Kevin Wolf wrote: > >>> Some tests in 118 use chmod to remove write permissions from the file > >

Re: [PATCH 10/14] omap-intc: remove PROP_PTR

2019-10-18 Thread Peter Maydell
On Fri, 18 Oct 2019 at 16:43, Marc-André Lureau wrote: > > Since clock are not QOM objects, replace PROP_PTR of clocks with > setters methods. > > (in theory there should probably be different methods for omap1 & > omap2 intc, but this is left as a future improvement) > > Signed-off-by: Marc-André

Re: [PATCH 11/14] omap-i2c: remove PROP_PTR

2019-10-18 Thread Peter Maydell
On Fri, 18 Oct 2019 at 16:43, Marc-André Lureau wrote: > > Since clock are not QOM objects, replace PROP_PTR of clocks with > setters methods. > > Signed-off-by: Marc-André Lureau > --- > --- a/include/hw/arm/omap.h > +++ b/include/hw/arm/omap.h > @@ -77,6 +77,15 @@ typedef struct omap_intr_hand

Re: [PATCH 12/14] omap-gpio: remove PROP_PTR

2019-10-18 Thread Peter Maydell
On Fri, 18 Oct 2019 at 16:43, Marc-André Lureau wrote: > > Since clock are not QOM objects, replace PROP_PTR of clocks with > setters methods. > > Signed-off-by: Marc-André Lureau > -/* Using qdev pointer properties for the clocks is not ideal. > - * qdev should support a generic means of defin

Re: [PATCH 14/14] Remove QDEV_PROP_PTR

2019-10-18 Thread Peter Maydell
On Fri, 18 Oct 2019 at 16:44, Marc-André Lureau wrote: > > No longer used in the tree. The comment about user_creatable is still > quite relevant, but there is already a similar comment in qdev-core.h. > > Signed-off-by: Marc-André Lureau > --- > hw/core/qdev-properties.c| 18 ---

Re: [PATCH 13/14] qdev: remove PROP_MEMORY_REGION

2019-10-18 Thread Peter Maydell
On Fri, 18 Oct 2019 at 16:44, Marc-André Lureau wrote: > > PROP_MEMORY_REGION was a derivative of PROP_PTR, added in commit > ed03d749f3f513b8fb0287757cfda2cb6825f063 (qdev: add MemoryRegion > property) and thankfully no longer needed since commit > 3eff40dbf44896a8180c86c84dbdefb2eb173fbe (hw/mis

Re: [PATCH v2 1/3] iotests: Fix 173

2019-10-18 Thread Eric Blake
On 10/17/19 7:17 AM, Max Reitz wrote: Why haven't we noticed the failure? Because the test rarely gets run: './check -qcow2 173' is insufficient (that defaults to using file protocol) './check -nfs 173' is insufficient (that defaults to using raw format) so the test is only run with: ./check -qc

Re: [PATCH 07/14] RFC: mips/cps: fix setting saar property

2019-10-18 Thread Philippe Mathieu-Daudé
On 10/18/19 5:42 PM, Marc-André Lureau wrote: There is no "saar" property. Note: I haven't been able to test this code. Help welcome. > May fix commit 043715d1e0fbb3e3411be3f898c5b77b7f90327a ("target/mips: Update ITU to utilize SAARI and SAAR CP0 registers") This seems a MIPS feature that is n

Re: [PATCH v2 20/20] hw/pci-host/i440fx: Remove the last PIIX3 traces

2019-10-18 Thread Aleksandar Markovic
On Friday, October 18, 2019, Philippe Mathieu-Daudé wrote: > The PIIX3 is not tied to the i440FX and can even be used without it. > Move its creation to the machine code (pc_piix.c). > We have now removed the last trace of southbridge code in the i440FX > northbridge. > > Signed-off-by: Philippe

Re: [PATCH v2] .travis.yml: Test the release tarball

2019-10-18 Thread Philippe Mathieu-Daudé
On 10/18/19 5:56 PM, Alex Bennée wrote: Philippe Mathieu-Daudé writes: ping? I've pulled it into testing/next to play but I was wondering if it was worth it given how infrequently it would run... Well, it will run when we tag release candidate and catch eventual bugs before we tag the fi

Re: [PATCH 4/5] iotests: Skip "make check-block" if QEMU does not support virtio-blk

2019-10-18 Thread Max Reitz
On 11.10.19 16:50, Thomas Huth wrote: > The next patch is going to add some python-based tests to the "auto" > group, and these tests require virtio-blk to work properly. Running > iotests without virtio-blk likely does not make too much sense anyway, > so instead of adding a check for the availabi

<    1   2   3   4   5   >