On Fri, 18 Oct 2019 at 17:11, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > Is there really much difference between: > > dev = qdev_create() > qdev_prop_set_ptr(dev, "prop", ptr); > qdev_init_nofail() > > and > > dev = qdev_create(MYDEV) > MYDEV(dev)->prop = ptr; > qdev_init_nofail()
One is easier to grep for than the other if you're looking for things we need to fix :-) I've just replied to patch 1 of this set with a reply that gives my general objections which are the same for this patch as that one; it's probably less confusing if we keep the conversation in that thread rather than conducting it along two parallel tracks (my fault for not reading the whole series first; I should probably have replied to the cover letter). thanks -- PMM
