On Fri, 18 Oct 2019 at 16:43, Marc-André Lureau <marcandre.lur...@redhat.com> wrote: > > Since clock are not QOM objects, replace PROP_PTR of clocks with > setters methods. > > (in theory there should probably be different methods for omap1 & > omap2 intc, but this is left as a future improvement) > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > --- > diff --git a/include/hw/arm/omap.h b/include/hw/arm/omap.h > index 2fda996648..6b7897ba27 100644 > --- a/include/hw/arm/omap.h > +++ b/include/hw/arm/omap.h > @@ -67,6 +67,16 @@ void omap_clk_setrate(omap_clk clk, int divide, int > multiply); > int64_t omap_clk_getrate(omap_clk clk); > void omap_clk_reparent(omap_clk clk, omap_clk parent); > > +/* omap_intc.c */ > +#define TYPE_OMAP_INTC "common-omap-intc" > +#define OMAP_INTC(obj) \ > + OBJECT_CHECK(omap_intr_handler, (obj), TYPE_OMAP_INTC) > + > +typedef struct omap_intr_handler_s omap_intr_handler; > +
If you add /* * TODO: Ideally we should have a clock framework that * let us wire these clocks up with QOM properties or links. */ > +void omap_intc_set_iclk(omap_intr_handler *intc, omap_clk clk); > +void omap_intc_set_fclk(omap_intr_handler *intc, omap_clk clk); > + then Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM
