[Qemu-devel] [PATCH v4 3/3] hw/gpio: Add in AST2600 specific implementation

The AST2600 has the same sets of 3.6v gpios as the AST2400 plus an addtional two sets of 1.8V gpios. Signed-off-by: Rashmica Gupta --- hw/gpio/aspeed_gpio.c | 188 -- slirp | 2 +- 2 files changed, 184 insertions(+), 6 deletions(-) diff

[Qemu-devel] [PATCH v4 0/3] Add Aspeed GPIO controller model

v4: - proper interupt handling thanks to Andrew - switch statements for reading and writing suggested by Peter - some small cleanups suggested by Alexey v3: - didn't have each gpio set up as an irq - now can't access set AC on ast2400 (only exists on ast2500) - added ast2600 implementation (patch

[Qemu-devel] [PATCH v4 1/3] hw/gpio: Add basic Aspeed GPIO model for AST2400 and AST2500

GPIO pins are arranged in groups of 8 pins labeled A,B,..,Y,Z,AA,AB,AC. (Note that the ast2400 controller only goes up to group AB). A set has four groups (except set AC which only has one) and is referred to by the groups it is composed of (eg ABCD,EFGH,...,YZAAAB). Each set is accessed and contro

[Qemu-devel] [PATCH v4 2/3] aspeed: add a GPIO controller to the SoC

Signed-off-by: Rashmica Gupta --- hw/arm/aspeed_soc.c | 17 + include/hw/arm/aspeed_soc.h | 3 +++ 2 files changed, 20 insertions(+) diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c index c6fb3700f2..ff422c8ad1 100644 --- a/hw/arm/aspeed_soc.c +++ b/hw/arm/aspeed_s

Re: [Qemu-devel] [qemu-s390x] [PATCH-for-4.2 v1 5/6] s390x/mmu: Better storage key reference and change bit handling

On 13.08.19 16:54, Cornelia Huck wrote: > On Mon, 12 Aug 2019 13:27:36 +0200 > David Hildenbrand wrote: > >> Any access sets the reference bit. In case we have a read-fault, we >> should not allow writes to the TLB entry if the change bit was not >> already set. >> >> This is a preparation for pr

Re: [Qemu-devel] [PATCH v3 1/3] hw/gpio: Add basic Aspeed GPIO model for AST2400 and AST2500

On Tue, 2019-08-06 at 14:57 +0100, Peter Maydell wrote: > On Tue, 30 Jul 2019 at 06:45, Rashmica Gupta > wrote: > > GPIO pins are arranged in groups of 8 pins labeled > > A,B,..,Y,Z,AA,AB,AC. > > (Note that the ast2400 controller only goes up to group AB). > > A set has four groups (except set AC

Re: [Qemu-devel] [PATCH v3 3/3] hw/gpio: Add in AST2600 specific implementation

Thanks for the feedback! I fixed up all the things you mentioned in v4. On Tue, 2019-08-13 at 17:31 +1000, Alexey Kardashevskiy wrote: > > On 30/07/2019 15:45, Rashmica Gupta wrote: > > The AST2600 has the same sets of 3.6v gpios as the AST2400 plus an > > addtional two sets of 1.8V gpios. > > >

[Qemu-devel] [PATCH-for-4.2 v2 2/6] s390x/tcg: Rework MMU selection for instruction fetches

Instructions are always fetched from primary address space, except when in home address mode. Perform the selection directly in cpu_mmu_index(). get_mem_index() is only used to perform data access, instructions are fetched via cpu_lduw_code(), which translates to cpu_mmu_index(env, true). We don'

[Qemu-devel] [PATCH-for-4.2 v2 1/6] s390x/mmu: ASC selection in s390_cpu_get_phys_page_debug()

Let's select the ASC before calling the function. This is a prepararion to remove the ASC magic depending on the access mode from mmu_translate. There is currently no way to distinguish if we have code or data access. For now, we were using code access, because especially when debugging with the g

[Qemu-devel] [PATCH-for-4.2 v2 0/6] s390x/mmu: Storage key reference and change bit handling

The first two patches are modified patches from: [PATCH-for-4.2 v1 0/9] s390x: MMU changes and extensions This series primarily fixes minor things in the storage key handling code in the MMU and implements fairly reliable reference and change bit handling for TCG. To track the reference and ch

[Qemu-devel] [PATCH-for-4.2 v2 3/6] s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE

Whenever we modify a storage key, we shuld flush the TLBs of all CPUs, so the MMU fault handling code can properly consider the changed storage key (to e.g., properly set the reference and change bit on the next accesses). These functions are barely used in modern Linux guests, so the performance

[Qemu-devel] [PATCH-for-4.2 v2 5/6] s390x/mmu: Better storage key reference and change bit handling

Any access sets the reference bit. In case we have a read-fault, we should not allow writes to the TLB entry if the change bit was not already set. This is a preparation for proper storage-key reference/change bit handling in TCG and a fix for KVM whereby read accesses would set the change bit (ol

[Qemu-devel] [PATCH-for-4.2 v2 4/6] s390x/mmu: Trace the right value if setting/getting the storage key fails

We want to trace the actual return value, not "0". Reviewed-by: Cornelia Huck Signed-off-by: David Hildenbrand --- target/s390x/mmu_helper.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c index c34e8d2021..d22c6b9c

[Qemu-devel] [PATCH-for-4.2 v2 6/6] s390x/mmu: Factor out storage key handling

Factor it out, add a comment how it all works, and also use it in the REAL MMU. Reviewed-by: Cornelia Huck Signed-off-by: David Hildenbrand --- target/s390x/mmu_helper.c | 113 +++--- 1 file changed, 69 insertions(+), 44 deletions(-) diff --git a/target/s390x/mm

Re: [Qemu-devel] [PATCH] pc-bios/s390-ccw/net: fix a possible memory leak in get_uuid()

On Wed, 14 Aug 2019 14:14:26 +0800 wrote: > There is a possible memory leak in get_uuid(). Should free allocated mem > before > return NULL. > > Signed-off-by: Yifan Luo > --- > pc-bios/s390-ccw/netmain.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/pc-bios/s390-ccw/netmain.c b/p

Re: [Qemu-devel] [PATCH v2 1/4] block: introduce aio task pool

13.08.2019 23:47, Max Reitz wrote: > On 30.07.19 16:18, Vladimir Sementsov-Ogievskiy wrote: >> Common interface for aio task loops. To be used for improving >> performance of synchronous io loops in qcow2, block-stream, >> copy-on-read, and may be other places. >> >> Signed-off-by: Vladimir Sements

Re: [Qemu-devel] [PATCH v2 2/4] block/qcow2: refactor qcow2_co_preadv_part

14.08.2019 0:31, Max Reitz wrote: > On 30.07.19 16:18, Vladimir Sementsov-Ogievskiy wrote: >> Further patch will run partial requests of iterations of >> qcow2_co_preadv in parallel for performance reasons. To prepare for >> this, separate part which may be parallelized into separate function >> (q

Re: [Qemu-devel] [PATCH v2 6/7] target/riscv: rationalise softfloat includes

Palmer Dabbelt writes: > On Fri, 09 Aug 2019 18:55:42 PDT (-0700), alistai...@gmail.com wrote: >> On Fri, Aug 9, 2019 at 2:22 AM Alex Bennée wrote: >>> >>> We should avoid including the whole of softfloat headers in cpu.h and >>> explicitly include it only where we will be calling softfloat >>

Re: [Qemu-devel] [Qemu-riscv] [PATCH] riscv: sifive_e: Correct various SoC IP block sizes

Hi Palmer, On Wed, Aug 7, 2019 at 10:53 AM Bin Meng wrote: > > On Wed, Aug 7, 2019 at 5:06 AM Philippe Mathieu-Daudé > wrote: > > > > On 8/5/19 8:43 AM, Bin Meng wrote: > > > On Mon, Aug 5, 2019 at 2:14 PM Chih-Min Chao > > > wrote: > > >> On Sat, Aug 3, 2019 at 8:27 AM Bin Meng wrote: > > >

Re: [Qemu-devel] [PATCH] ppc: Add support for 'mffsl' instruction

On 8/13/19 4:31 PM, Paul A. Clarke wrote: > +TCGv_i64 mask = tcg_const_i64(FP_MODE | FP_STATUS | FP_ENABLES); > +tcg_gen_and_i64(t0, t0, mask); Better as tcg_gen_andi_i64(t0, t0, FP_MODE | FP_STATUS | FP_ENABLES); You failed to free the temporary that you allocated here. r~

Re: [Qemu-devel] [PATCH v2] riscv: rv32: Root page table address can be larger than 32-bit

Hi Palmer, On Sat, Aug 10, 2019 at 9:49 AM Alistair Francis wrote: > > On Wed, Aug 7, 2019 at 7:50 PM Bin Meng wrote: > > > > For RV32, the root page table's PPN has 22 bits hence its address > > bits could be larger than the maximum bits that target_ulong is > > able to represent. Use hwaddr in

Re: [Qemu-devel] [PATCH] usb: reword -usb command-line option and mention xHCI

* Stefan Hajnoczi (stefa...@redhat.com) wrote: > The -usb section of the man page is not very clear on what exactly -usb > does and fails to mention xHCI as a modern alternative (-device > nec-usb-xhci). Isn't 'qemu-xhci' the current favoured device? Dave > Signed-off-by: Stefan Hajnoczi > ---

[Qemu-devel] [PATCH 1/2] qapi: deprecate drive-mirror and drive-backup

It's hard and not necessary to maintain outdated versions of these commands. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qemu-deprecated.texi | 4 qapi/block-core.json | 4 qapi/transaction.json | 2 +- blockdev.c| 10 ++ 4 files changed, 19 insertions(+),

Re: [Qemu-devel] [PATCH-for-4.2 v2 3/6] s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE

David Hildenbrand writes: > Whenever we modify a storage key, we shuld flush the TLBs of all CPUs, > so the MMU fault handling code can properly consider the changed storage > key (to e.g., properly set the reference and change bit on the next > accesses). > > These functions are barely used in

[Qemu-devel] [PATCH 0/2] Deprecate implicit filters

Hi all! Max's series to fix some problems around filters consists of 42 patches. I'm sure that we didn't find all bugs around filters, and that filters would be a constant source of bugs in future, as during developing new feature nobody will consider all possible cases of dealing with filters (OK

[Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

To get rid of implicit filters related workarounds in future let's deprecate them now. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qemu-deprecated.texi | 7 +++ qapi/block-core.json | 6 -- include/block/block_int.h | 10 +- blockdev.c| 10

Re: [Qemu-devel] [PATCH-for-4.2 v2 3/6] s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE

On 14.08.19 12:06, Alex Bennée wrote: > > David Hildenbrand writes: > >> Whenever we modify a storage key, we shuld flush the TLBs of all CPUs, >> so the MMU fault handling code can properly consider the changed storage >> key (to e.g., properly set the reference and change bit on the next >> ac

Re: [Qemu-devel] [PATCH v3 1/2] scsi: lsi: exit infinite loop while executing script (CVE-2019-12068)

+-- On Tue, 13 Aug 2019, Paolo Bonzini wrote --+ | After the first instruction is processed, "again" is only reached if | s->waiting == LSI_NOWAIT. Therefore, we could move the Windows hack to the | beginning and remove the s->waiting condition. The only change would be | that it would also be

Re: [Qemu-devel] [PATCH v3 1/2] scsi: lsi: exit infinite loop while executing script (CVE-2019-12068)

On 14/08/19 12:25, P J P wrote: > +-- On Tue, 13 Aug 2019, Paolo Bonzini wrote --+ > | After the first instruction is processed, "again" is only reached if > | s->waiting == LSI_NOWAIT. Therefore, we could move the Windows hack to the > | beginning and remove the s->waiting condition. The only

Re: [Qemu-devel] [PATCH v4] migration: do not rom_reset() during incoming migration

Hi Paolo Ping, is any other comment I hadn't addressed? Cheers Catherine On Thu, 6 Jun 2019 at 02:31, Dr. David Alan Gilbert wrote: > Paolo, can you take this one please. > > * Catherine Ho (catherine.h...@gmail.com) wrote: > > Commit 18269069c310 ("migration: Introduce ignore-shared capability

Re: [Qemu-devel] [PATCH-for-4.2 v2 3/6] s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE

David Hildenbrand writes: > On 14.08.19 12:06, Alex Bennée wrote: >> >> David Hildenbrand writes: >> >>> Whenever we modify a storage key, we shuld flush the TLBs of all CPUs, >>> so the MMU fault handling code can properly consider the changed storage >>> key (to e.g., properly set the refere

Re: [Qemu-devel] [PATCH-for-4.2 v2 3/6] s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE

On 14.08.19 12:44, Alex Bennée wrote: > > David Hildenbrand writes: > >> On 14.08.19 12:06, Alex Bennée wrote: >>> >>> David Hildenbrand writes: >>> Whenever we modify a storage key, we shuld flush the TLBs of all CPUs, so the MMU fault handling code can properly consider the changed

Re: [Qemu-devel] [PATCH 1/6] migration: Add traces for multifd terminate threads

* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert and queued > --- > migration/ram.c| 4 > migration/trace-events | 2 ++ > 2 files changed, 6 insertions(+) > > diff --git a/migration/ram.c b/migration/ram.c > index 8

Re: [Qemu-devel] [PATCH 1/1] x86: add CPU flags supported inside libvirt

On Thu, Jul 18, 2019 at 16:45:37 +0300, Denis V. Lunev wrote: > There are the following flags available in libvirt inside cpu_map.xm > > > > > > > We have faced the problem that QEMU does not start once these flags are > present in the domain.xml. Libvirt should

Re: [Qemu-devel] [PATCH 0/6] Fix multifd with big number of channels

Patchew URL: https://patchew.org/QEMU/20190814020218.1868-1-quint...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make

Re: [Qemu-devel] [PATCH] usbredir: fix buffer-overflow on vmload

On Wed, Aug 07, 2019 at 12:40:48PM +0400, Marc-André Lureau wrote: > If interface_count is NO_INTERFACE_INFO, let's not access the arrays > out-of-bounds. > > ==994==ERROR: AddressSanitizer: heap-buffer-overflow on address > 0x625000243930 at pc 0x5642068086a8 bp 0x7f0b6f9ffa50 sp 0x7f0b6f9ffa40

[Qemu-devel] [PATCH v4] scsi: lsi: exit infinite loop while executing script (CVE-2019-12068)

From: Prasad J Pandit When executing script in lsi_execute_script(), the LSI scsi adapter emulator advances 's->dsp' index to read next opcode. This can lead to an infinite loop if the next opcode is empty. Exit such loop after 10k iterations. Reported-by: Bugs SysSec Signed-off-by: Prasad J Pa

Re: [Qemu-devel] [PATCH v3 1/2] scsi: lsi: exit infinite loop while executing script (CVE-2019-12068)

+-- On Wed, 14 Aug 2019, Paolo Bonzini wrote --+ | On 14/08/19 12:25, P J P wrote: | > Should I send a revised patch? (with above change) | | Yes, please. Sent v4. Thank you. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F

Re: [Qemu-devel] [PATCH 1/1] usb-redir: merge interrupt packets

On Wed, Jul 24, 2019 at 02:58:59PM +0200, Martin Cerveny wrote: > Interrupt packets (limited by wMaxPacketSize) should be buffered and merged > by algorithm described in USB spec. > (see usb_20.pdf/5.7.3 Interrupt Transfer Packet Size Constraints). Added to usb patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH] xhci: Add No Op Command

On Sat, Jul 20, 2019 at 03:04:27PM +0900, hikaru...@gmail.com wrote: > From: Hikaru Nishida > > This commit adds No Op Command (23) to xHC for verifying the operation > of the Command Ring mechanisms. > No Op Command is defined in XHCI spec (4.6.2) and just reports Command > Completion Event with

[Qemu-devel] [PATCH 0/4] configure: Fix libssh on Ubuntu 18.04

Since a long time occured between libssh 0.7 and libssh 0.8, distributions went cherry-picking improvments from the trunk branch into their 0.7 branch, leading to packages versioned as 0.7 but having 0.8 features. This series fixes the oddest combination found so far, packaged with Ubuntu 18.04.

[Qemu-devel] [PATCH 2/4] configure: Avoid using libssh deprecated API

The libssh packaged by a distribution can predate version 0.8, but still provides the newer API introduced after version 0.7. Using the deprecated API leads to build failure, as on Ubuntu 18.04: CC block/ssh.o block/ssh.c: In function 'check_host_key_hash': block/ssh.c:444:5: error:

[Qemu-devel] [PATCH 3/4] configure: Improve checking libssh version is 0.8

To figure out which libssh version is installed, checking for ssh_get_server_publickey() is not sufficient. ssh_get_server_publickey() has been introduced in libssh commit bbd052202 (predating 0.8) but distributions also backported other pre-0.8 patches, such libssh commit 963c46e4f which introduc

[Qemu-devel] [PATCH 4/4] configure: Log the libssh version detected

Log wether the version is 0.7 or 0.8 to better understand user reports. Signed-off-by: Philippe Mathieu-Daudé --- configure | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 040aa8eb6c..d06cee0ba0 100755 --- a/configure +++ b/configure @@ -3930,

[Qemu-devel] [RFC PATCH 1/4] configure: Improve libssh check

The libssh pkg-config is not complete, the libraries required to link with libssh are not returned. For example on Ubuntu 18.04: $ dpkg -l|fgrep libssh ii libssh-4:arm64 0.8.0~20170825.94fa1e38-1ubuntu0.2 arm64 tiny C SSH library (OpenSSL flavor) ii libssh-dev 0.8.0~20170825.94fa1e38-1ubunt

Re: [Qemu-devel] [PATCH v4 1/3] hw/gpio: Add basic Aspeed GPIO model for AST2400 and AST2500

On 14/08/2019 09:14, Rashmica Gupta wrote: > GPIO pins are arranged in groups of 8 pins labeled A,B,..,Y,Z,AA,AB,AC. > (Note that the ast2400 controller only goes up to group AB). > A set has four groups (except set AC which only has one) and is > referred to by the groups it is composed of (eg ABC

Re: [Qemu-devel] [PATCH 4/4] configure: Log the libssh version detected

The series seems fine, so: Acked-by: Richard W.M. Jones If it was me I'd be inclined to file a bug against Ubuntu and get them to fix their broken package instead :-) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualizatio

Re: [Qemu-devel] [PATCH v4 2/3] aspeed: add a GPIO controller to the SoC

On 14/08/2019 09:14, Rashmica Gupta wrote: > Signed-off-by: Rashmica Gupta > --- > hw/arm/aspeed_soc.c | 17 + > include/hw/arm/aspeed_soc.h | 3 +++ > 2 files changed, 20 insertions(+) > > diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c > index c6fb3700f2..ff422c

Re: [Qemu-devel] [PATCH v4] migration: do not rom_reset() during incoming migration

On 14/08/19 12:40, Catherine Ho wrote: > Hi Paolo > Ping, is any other comment I hadn't addressed? No, I queued the patch now. Paolo > Cheers > Catherine > > On Thu, 6 Jun 2019 at 02:31, Dr. David Alan Gilbert > wrote: > > Paolo, can you take this one please. >

Re: [Qemu-devel] [PATCH 2/4] configure: Avoid using libssh deprecated API

On Wednesday, 14 August 2019 14:15:25 CEST Philippe Mathieu-Daudé wrote: > The libssh packaged by a distribution can predate version 0.8, > but still provides the newer API introduced after version 0.7. > > Using the deprecated API leads to build failure, as on Ubuntu 18.04: > > CC block

Re: [Qemu-devel] [RFC PATCH 1/4] configure: Improve libssh check

On Wednesday, 14 August 2019 14:15:24 CEST Philippe Mathieu-Daudé wrote: > The libssh pkg-config is not complete, the libraries required to > link with libssh are not returned. For example on Ubuntu 18.04: > > $ dpkg -l|fgrep libssh > ii libssh-4:arm64 0.8.0~20170825.94fa1e38-1ubuntu0.2 arm64

Re: [Qemu-devel] [PATCH v4 3/3] hw/gpio: Add in AST2600 specific implementation

On 14/08/2019 09:14, Rashmica Gupta wrote: > The AST2600 has the same sets of 3.6v gpios as the AST2400 plus an > addtional two sets of 1.8V gpios. > > Signed-off-by: Rashmica Gupta > --- > hw/gpio/aspeed_gpio.c | 188 -- > slirp | 2 +- >

Re: [Qemu-devel] [PATCH] test-bitmap: test set 1 bit case for bitmap_set

On 14/08/19 02:27, Wei Yang wrote: > All current bitmap_set test cases set range across word, while the > handle of a range within one word is different from that. > > Add case to set 1 bit as a represent for set range within one word. > > Signed-off-by: Wei Yang > > --- > Thanks for Paolo's fi

Re: [Qemu-devel] [PATCH 3/4] configure: Improve checking libssh version is 0.8

On Wednesday, 14 August 2019 14:15:26 CEST Philippe Mathieu-Daudé wrote: > To figure out which libssh version is installed, checking for > ssh_get_server_publickey() is not sufficient. > > ssh_get_server_publickey() has been introduced in libssh > commit bbd052202 (predating 0.8) but distributions

Re: [Qemu-devel] [PATCH 4/4] configure: Log the libssh version detected

On Wednesday, 14 August 2019 14:15:27 CEST Philippe Mathieu-Daudé wrote: > Log wether the version is 0.7 or 0.8 to better understand > user reports. > > Signed-off-by: Philippe Mathieu-Daudé > --- > configure | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/configur

Re: [Qemu-devel] [PATCH-for-4.1? 0/7] vl: Allow building with CONFIG_BLUETOOTH disabled

On 8/13/19 4:04 PM, Peter Maydell wrote: > On Tue, 13 Aug 2019 at 15:01, Philippe Mathieu-Daudé > wrote: >> On 7/15/19 3:13 PM, Thomas Huth wrote: >>> On 12/07/2019 15.39, Philippe Mathieu-Daudé wrote: A series of obvious patches to build without the deprecated bluetooth devices. Still

Re: [Qemu-devel] [PATCH v3 0/3] Add Aspeed GPIO controller model

On 30/07/2019 07:44, Rashmica Gupta wrote: > There are a couple of things I'm not confident about here: > - what should be in init vs realize? > - should the irq state be in vmstate? > - is there a better way to do composition of classes (patch 3)? You can not do twice : obj = object_new(TY

Re: [Qemu-devel] [PATCH-for-4.1? 3/7] MAINTAINERS: Add an entry for the Bluetooth devices

Cc'ing qemu-trivial@ to salvage this patch. On 7/12/19 3:39 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index cc9636b43a..5d8f27d9bd 100644 > --- a/MAINT

[Qemu-devel] [PATCH] pc-bios/s390-ccw/net: fix a possible memory leak in get_uuid()

There is a possible memory leak in get_uuid(). Should free allocated mem before return NULL. Signed-off-by: Yifan Luo --- pc-bios/s390-ccw/netmain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/pc-bios/s390-ccw/netmain.c b/pc-bios/s390-ccw/netmain.c index f3542cb2cf1..f2dcc01e272 100644

Re: [Qemu-devel] [PATCH v9 01/11] hw/arm: simplify arm_load_dtb

On 13/08/2019 23:55, Eduardo Habkost wrote: > > CCing ARM maintainers. I'd like to at least get one Acked-by from > them before queueing this on machine-next. > > > On Fri, Aug 09, 2019 at 02:57:21PM +0800, Tao wrote: >> From: Tao Xu >> >> In struct arm_boot_info, kernel_filename, initrd_filen

Re: [Qemu-devel] CPU hotplug using SMM with QEMU+OVMF

My comments below. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, August 14, 2019 12:09 AM > To: edk2-devel-groups-io > Cc: edk2-rfc-groups-io ; qemu devel list > ; Igor Mammedov ; > Paolo Bonzini ; Yao, Jiewen > ; Chen, Yingwen ; > Nakajima, Jun ;

Re: [Qemu-devel] [PATCH] usb: reword -usb command-line option and mention xHCI

On Tue, Aug 13, 2019 at 07:54:16PM +0200, Thomas Huth wrote: > On 8/13/19 3:30 PM, Stefan Hajnoczi wrote: > > The -usb section of the man page is not very clear on what exactly -usb > > does and fails to mention xHCI as a modern alternative (-device > > nec-usb-xhci). > > > > Signed-off-by: Stefan

Re: [Qemu-devel] bitmaps branch rebase

08.08.2019 0:45, John Snow wrote: > FYI: I rebased jsnow/bitmaps on top of kwolf/block-next, itself based on > top of v4.1.0-rc4. > > I'll post this along with the eventual pull request, but here's the > diffstat against the published patches: > > 011/33:[0003] [FC] 'block/backup: upgrade copy_bi

Re: [Qemu-devel] [PATCH 2/4] configure: Avoid using libssh deprecated API

On Wed, 2019-08-14 at 14:15 +0200, Philippe Mathieu-Daudé wrote: > The libssh packaged by a distribution can predate version 0.8, > but still provides the newer API introduced after version 0.7. > > Using the deprecated API leads to build failure, as on Ubuntu 18.04: > > CC block/ssh.o >

Re: [Qemu-devel] [PATCH v4 0/3] Add Aspeed GPIO controller model

Patchew URL: https://patchew.org/QEMU/20190814071433.22243-1-rashmic...@gmail.com/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit tha

Re: [Qemu-devel] [Qemu-block] [PATCH 7/7] iotests: Disable 126 for some vmdk subformats

On 14.08.19 00:26, John Snow wrote: > > > On 8/13/19 10:00 AM, Max Reitz wrote: >> On 12.08.19 23:33, John Snow wrote: >>> >>> >>> On 7/25/19 11:57 AM, Max Reitz wrote: Several vmdk subformats do not work with iotest 126, so disable them. (twoGbMaxExtentSparse actually should work,

Re: [Qemu-devel] CPU hotplug using SMM with QEMU+OVMF

On 14/08/19 15:20, Yao, Jiewen wrote: >> - Does this part require a new branch somewhere in the OVMF SEC code? >> How do we determine whether the CPU executing SEC is BSP or >> hot-plugged AP? > [Jiewen] I think this is blocked from hardware perspective, since the first > instruction. > There

Re: [Qemu-devel] [PATCH 2/4] configure: Avoid using libssh deprecated API

On 8/14/19 3:27 PM, Andrea Bolognani wrote: > On Wed, 2019-08-14 at 14:15 +0200, Philippe Mathieu-Daudé wrote: >> The libssh packaged by a distribution can predate version 0.8, >> but still provides the newer API introduced after version 0.7. >> >> Using the deprecated API leads to build failure, a

Re: [Qemu-devel] [PATCH 2/6] migration: Make global sem_sync semaphore by channel

* Juan Quintela (quint...@redhat.com) wrote: > This makes easy to debug things because when you want for all threads > to arrive at that semaphore, you know which one your are waiting for. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert and queued. > --- > migration/ram.

Re: [Qemu-devel] [PATCH] ehci: Ensure that device is not NULL before calling usb_ep_get

On Tue, Aug 13, 2019 at 01:42:03PM +0200, Gerd Hoffmann wrote: > On Tue, Aug 06, 2019 at 06:23:38AM -0700, Guenter Roeck wrote: > > On 8/2/19 7:11 AM, Gerd Hoffmann wrote: > > > On Wed, Jul 31, 2019 at 01:08:50PM +0200, Philippe Mathieu-Daudé wrote: > > > > On 7/30/19 7:45 PM, Guenter Roeck wrote:

[Qemu-devel] [PATCH 3/4] block/backup: use bdrv_dirty_bitmap_next_dirty

Use more effective search for next dirty byte. Trace point is dropped to not introduce additional variable and logic only for trace point. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/backup.c | 7 +++ block/trace-events | 1 - 2 files changed, 3 insertions(+), 5 deletions(-) d

[Qemu-devel] [PATCH 2/4] block/dirty-bitmap: add _next_dirty API

We have bdrv_dirty_bitmap_next_zero, let's add corresponding bdrv_dirty_bitmap_next_dirty, which is more comfortable to use than bitmap iterators in some cases. It will be used in the following commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/dirty-bitmap.h | 2 ++ include/

[Qemu-devel] [PATCH 4/4] block/backup: fix and improve skipping unallocated in backup_do_cow

1. There is a bug: after detection an allocated area of skip_bytes length we ignore skip_bytes variable and my finish up by copying more than skip_bytes. 2. If request area is allocated we call block_status for each cluster on each loop iteration, even if after the first call we know that the whol

[Qemu-devel] [PATCH 0/4] backup: fix skipping unallocated clusters

Hi all! There is a bug in not yet merged patch "block/backup: teach TOP to never copy unallocated regions" in https://github.com/jnsnow/qemu bitmaps. 04 fixes it. So, I propose to put 01-03 somewhere before "block/backup: teach TOP to never copy unallocated regions" and squash 04 into "block/backu

[Qemu-devel] [PATCH 1/4] block/dirty-bitmap: switch _next_dirty_area and _next_zero to int64_t

It's very uncomfortable that we can't use same variable as result of bdrv_dirty_bitmap_next_zero and parameter of bdrv_dirty_bitmap_next_dirty_area. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/dirty-bitmap.h | 6 +++--- include/qemu/hbitmap.h | 5 ++--- block/dirty-bitm

Re: [Qemu-devel] [PATCH 2/4] configure: Avoid using libssh deprecated API

On Wed, 2019-08-14 at 16:15 +0200, Philippe Mathieu-Daudé wrote: > On 8/14/19 3:27 PM, Andrea Bolognani wrote: > > On Wed, 2019-08-14 at 14:15 +0200, Philippe Mathieu-Daudé wrote: > > > The libssh packaged by a distribution can predate version 0.8, > > > but still provides the newer API introduced

Re: [Qemu-devel] [PATCH 0/6] Fix multifd with big number of channels

* Juan Quintela (quint...@redhat.com) wrote: > Hi > > When we have much more channels than cpus, we end having failures when > writting to sockets. This series: > - add some traces > - fix some of the trouble with serialization of creating the > threads/channels in proper order. > - Ask for help

Re: [Qemu-devel] [PATCH 3/6] migration: Make sure that all multifd channels have been created

* Juan Quintela (quint...@redhat.com) wrote: > If we start the migration before all have been created, we have to > handle the case that one channel still don't exist. This way it is > easier. > > Signed-off-by: Juan Quintela > --- > migration/ram.c| 14 ++ > migration/trace

Re: [Qemu-devel] [PATCH v2 2/4] block/qcow2: refactor qcow2_co_preadv_part

On 14.08.19 11:11, Vladimir Sementsov-Ogievskiy wrote: > 14.08.2019 0:31, Max Reitz wrote: >> On 30.07.19 16:18, Vladimir Sementsov-Ogievskiy wrote: >>> Further patch will run partial requests of iterations of >>> qcow2_co_preadv in parallel for performance reasons. To prepare for >>> this, separat

[Qemu-devel] [PATCH v1] s390x/tcg: Fix VERIM with 32/64 bit elements

Wrong order of operands. The constant always comes last. Makes QEMU crash reliably on specific git fetch invocations. Reported-by: Stefano Brivio Signed-off-by: David Hildenbrand --- I guess it is too late for 4.1 :( --- target/s390x/translate_vx.inc.c | 2 +- 1 file changed, 1 insertion(+),

Re: [Qemu-devel] [PATCH 2/4] configure: Avoid using libssh deprecated API

On 8/14/19 4:51 PM, Andrea Bolognani wrote: > On Wed, 2019-08-14 at 16:15 +0200, Philippe Mathieu-Daudé wrote: >> On 8/14/19 3:27 PM, Andrea Bolognani wrote: >>> On Wed, 2019-08-14 at 14:15 +0200, Philippe Mathieu-Daudé wrote: The libssh packaged by a distribution can predate version 0.8,

Re: [Qemu-devel] [PATCH v2 2/4] block/qcow2: refactor qcow2_co_preadv_part

On 8/14/19 4:11 AM, Vladimir Sementsov-Ogievskiy wrote: > 14.08.2019 0:31, Max Reitz wrote: >> On 30.07.19 16:18, Vladimir Sementsov-Ogievskiy wrote: >>> Further patch will run partial requests of iterations of >>> qcow2_co_preadv in parallel for performance reasons. To prepare for >>> this, separa

Re: [Qemu-devel] [PATCH v6 25/42] mirror: Deal with filters

12.08.2019 16:26, Max Reitz wrote: > On 12.08.19 13:09, Vladimir Sementsov-Ogievskiy wrote: >> 09.08.2019 19:13, Max Reitz wrote: >>> This includes some permission limiting (for example, we only need to >>> take the RESIZE permission for active commits where the base is smaller >>> than the top). >

[Qemu-devel] [PATCH v4] riscv: hmp: Add a command to show virtual memory mappings

This adds 'info mem' command for RISC-V, to show virtual memory mappings that aids debugging. Rather than showing every valid PTE, the command compacts the output by merging all contiguous physical address mappings into one block and only shows the merged block mapping details. Signed-off-by: Bin

Re: [Qemu-devel] [PATCH] riscv: hmp: Add a command to show virtual memory mappings

Hi Palmer, On Wed, Aug 14, 2019 at 9:35 AM Bin Meng wrote: > > Hi Palmer, > > On Tue, Aug 13, 2019 at 11:18 PM Palmer Dabbelt wrote: > > > > On Wed, 31 Jul 2019 05:49:15 PDT (-0700), bmeng...@gmail.com wrote: > > > This adds 'info mem' command for RISC-V, to show virtual memory > > > mappings th

Re: [Qemu-devel] [PATCH v1] s390x/tcg: Fix VERIM with 32/64 bit elements

On Wed, 14 Aug 2019 17:12:42 +0200 David Hildenbrand wrote: > Wrong order of operands. The constant always comes last. Makes QEMU crash > reliably on specific git fetch invocations. > > Reported-by: Stefano Brivio > Signed-off-by: David Hildenbrand > --- > > I guess it is too late for 4.1 :(

Re: [Qemu-devel] [PATCH v1] s390x/tcg: Fix VERIM with 32/64 bit elements

On 14.08.19 17:41, Cornelia Huck wrote: > On Wed, 14 Aug 2019 17:12:42 +0200 > David Hildenbrand wrote: > >> Wrong order of operands. The constant always comes last. Makes QEMU crash >> reliably on specific git fetch invocations. >> >> Reported-by: Stefano Brivio >> Signed-off-by: David Hildenbr

Re: [Qemu-devel] [PATCH v2 3/4] block/qcow2: refactor qcow2_co_pwritev_part

On 30.07.19 16:18, Vladimir Sementsov-Ogievskiy wrote: > Similarly to previous commit, prepare for parallelizing write-loop > iterations. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2.c | 150 +- > 1 file changed, 88 insertion

Re: [Qemu-devel] [PATCH v2 2/4] block/qcow2: refactor qcow2_co_preadv_part

On 14.08.19 17:15, Eric Blake wrote: > On 8/14/19 4:11 AM, Vladimir Sementsov-Ogievskiy wrote: >> 14.08.2019 0:31, Max Reitz wrote: >>> On 30.07.19 16:18, Vladimir Sementsov-Ogievskiy wrote: Further patch will run partial requests of iterations of qcow2_co_preadv in parallel for performan

Re: [Qemu-devel] [PATCH] test-bitmap: test set 1 bit case for bitmap_set

On Wed, Aug 14, 2019 at 02:38:24PM +0200, Paolo Bonzini wrote: >On 14/08/19 02:27, Wei Yang wrote: >> All current bitmap_set test cases set range across word, while the >> handle of a range within one word is different from that. >> >> Add case to set 1 bit as a represent for set range within one

Re: [Qemu-devel] [PATCH v6 30/42] qemu-img: Use child access functions

09.08.2019 19:13, Max Reitz wrote: > This changes iotest 204's output, because blkdebug on top of a COW node > used to make qemu-img map disregard the rest of the backing chain (the > backing chain was broken by the filter). With this patch, the > allocation in the base image is reported correctly

[Qemu-devel] [PATCH v3] ppc: Add support for 'mffsl' instruction

From: "Paul A. Clarke" ISA 3.0B added a set of Floating-Point Status and Control Register (FPSCR) instructions: mffsce, mffscdrn, mffscdrni, mffscrn, mffscrni, mffsl. This patch adds support for 'mffsl'. 'mffsl' is identical to 'mffs', except it only returns mode, status, and enable bits from th

Re: [Qemu-devel] [PATCH 5/6] migration: add some multifd traces

* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Queued > --- > migration/ram.c| 3 +++ > migration/trace-events | 4 > 2 files changed, 7 insertions(+) > > diff --git a/migration/ram.c b/migration/ram.c > index f1ae

Re: [Qemu-devel] [PATCH v2 3/4] block/qcow2: refactor qcow2_co_pwritev_part

On 30.07.19 16:18, Vladimir Sementsov-Ogievskiy wrote: > Similarly to previous commit, prepare for parallelizing write-loop > iterations. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2.c | 150 +- > 1 file changed, 88 insertion

Re: [Qemu-devel] [PATCH v2 4/4] block/qcow2: introduce parallel subrequest handling in read and write

On 30.07.19 16:18, Vladimir Sementsov-Ogievskiy wrote: > It improves performance for fragmented qcow2 images. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2.c | 125 + > block/trace-events | 1 + > 2 files changed, 115 inser

Re: [Qemu-devel] [PATCH v3] ppc: Add support for 'mffsl' instruction

Patchew URL: https://patchew.org/QEMU/1565799261-498-1-git-send-email...@us.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v3] ppc: Add support for 'mffsl' instruction Message-id: 1565799261-498-1-git-send

Re: [Qemu-devel] [PATCH v3] ppc: Add support for 'mffsl' instruction

Should these 'checkpatch' ERRORs be addressed, even if it will diverge the code style from the existing, surrounding code? On 8/14/19 11:30 AM, no-re...@patchew.org wrote: > This series seems to have some coding style problems. See output below for > more information: > === OUTPUT BEGIN === > ER

Re: [Qemu-devel] [PATCH v3 13/14] migration/ram: add support to send encrypted pages

* Singh, Brijesh (brijesh.si...@amd.com) wrote: > When memory encryption is enabled, the guest memory will be encrypted with > the guest specific key. The patch introduces RAM_SAVE_FLAG_ENCRYPTED_PAGE > flag to distinguish the encrypted data from plaintext. Encrypted pages > may need special handli

Re: [Qemu-devel] [PATCH 0/4] configure: Fix libssh on Ubuntu 18.04

Patchew URL: https://patchew.org/QEMU/20190814121527.17876-1-phi...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make d

Re: [Qemu-devel] [PATCH 0/4] backup: fix skipping unallocated clusters

14 авг. 2019 г. 17:43 пользователь Vladimir Sementsov-Ogievskiy написал: Hi all! There is a bug in not yet merged patch "block/backup: teach TOP to never copy unallocated regions" in https://github.com/jnsnow/qemu bitmaps. 04 fixes it. So, I propose to put 01-03 somewhere before "block/backup

  1   2   3   >