On Wed, 2019-08-14 at 14:15 +0200, Philippe Mathieu-Daudé wrote: > The libssh packaged by a distribution can predate version 0.8, > but still provides the newer API introduced after version 0.7. > > Using the deprecated API leads to build failure, as on Ubuntu 18.04: > > CC block/ssh.o > block/ssh.c: In function 'check_host_key_hash': > block/ssh.c:444:5: error: 'ssh_get_publickey' is deprecated > [-Werror=deprecated-declarations] > r = ssh_get_publickey(s->session, &pubkey); > ^ > In file included from block/ssh.c:27:0: > /usr/include/libssh/libssh.h:489:31: note: declared here > SSH_DEPRECATED LIBSSH_API int ssh_get_publickey(ssh_session session, > ssh_key *key); > ^~~~~~~~~~~~~~~~~ > rules.mak:69: recipe for target 'block/ssh.o' failed > make: *** [block/ssh.o] Error 1 > > Fix by using the newer API if available. > > Suggested-by: Andrea Bolognani <abolo...@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > block/ssh.c | 2 +- > configure | 7 +++++++ > 2 files changed, 8 insertions(+), 1 deletion(-)
Did I really suggest this? I have no recollection of doing so, or even getting involved with libssh support in QEMU at all for that matter. -- Andrea Bolognani / Red Hat / Virtualization
