[Qemu-devel] [PATCH v3 26/29] Clean up inclusion of sysemu/sysemu.h

2019-08-09 Thread Markus Armbruster
In my "build everything" tree, changing sysemu/sysemu.h triggers a recompile of some 5400 out of 6600 objects (not counting tests and objects that don't depend on qemu/osdep.h). Almost a third of its inclusions are actually superfluous. Delete them. Downgrade two more to qapi/qapi-types-run-stat

[Qemu-devel] [PATCH v3 20/29] Include qemu/main-loop.h less

2019-08-09 Thread Markus Armbruster
In my "build everything" tree, changing qemu/main-loop.h triggers a recompile of some 5600 out of 6600 objects (not counting tests and objects that don't depend on qemu/osdep.h). It includes block/aio.h, which in turn includes qemu/event_notifier.h, qemu/notify.h, qemu/processor.h, qemu/qsp.h, qem

[Qemu-devel] [PATCH v9 01/11] hw/arm: simplify arm_load_dtb

2019-08-09 Thread Tao
From: Tao Xu In struct arm_boot_info, kernel_filename, initrd_filename and kernel_cmdline are copied from from MachineState. This patch add MachineState as a parameter into arm_load_dtb() and move the copy chunk of kernel_filename, initrd_filename and kernel_cmdline into arm_load_kernel(). Revie

[Qemu-devel] [PATCH v9 06/11] hmat acpi: Build Memory Proximity Domain Attributes Structure(s)

2019-08-09 Thread Tao
From: Liu Jingqi HMAT is defined in ACPI 6.3: 5.2.27 Heterogeneous Memory Attribute Table (HMAT). The specification references below link: http://www.uefi.org/sites/default/files/resources/ACPI_6_3_final_Jan30.pdf It describes the memory attributes, such as memory side cache attributes and bandw

[Qemu-devel] [PATCH v3 14/29] migration: Move the VMStateDescription typedef to typedefs.h

2019-08-09 Thread Markus Armbruster
We declare incomplete struct VMStateDescription in a couple of places so we don't have to include migration/vmstate.h for the typedef. That's fine with me. However, the next commit will drop migration/vmstate.h from a massive number of compiles. Move the typedef to qemu/typedefs.h now, so I don't

[Qemu-devel] [PATCH v9 07/11] hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s)

2019-08-09 Thread Tao
From: Liu Jingqi This structure describes the memory access latency and bandwidth information from various memory access initiator proximity domains. The latency and bandwidth numbers represented in this structure correspond to rated latency and bandwidth for the platform. The software could use

[Qemu-devel] [PATCH v3 29/29] sysemu: Split sysemu/runstate.h off sysemu/sysemu.h

2019-08-09 Thread Markus Armbruster
sysemu/sysemu.h is a rather unfocused dumping ground for stuff related to the system-emulator. Evidence: * It's included widely: in my "build everything" tree, changing sysemu/sysemu.h still triggers a recompile of some 1100 out of 6600 objects (not counting tests and objects that don't depen

[Qemu-devel] [PATCH v9 02/11] numa: move numa global variable nb_numa_nodes into MachineState

2019-08-09 Thread Tao
From: Tao Xu Add struct NumaState in MachineState and move existing numa global nb_numa_nodes(renamed as "num_nodes") into NumaState. And add variable numa_support into MachineClass to decide which submachines support NUMA. Reviewed-by: Igor Mammedov Suggested-by: Igor Mammedov Suggested-by: E

[Qemu-devel] [PATCH v3 18/29] Include hw/hw.h exactly where needed

2019-08-09 Thread Markus Armbruster
In my "build everything" tree, changing hw/hw.h triggers a recompile of some 2600 out of 6600 objects (not counting tests and objects that don't depend on qemu/osdep.h). The previous commits have left only the declaration of hw_error() in hw/hw.h. This permits dropping most of its inclusions. To

[Qemu-devel] [PATCH v9 09/11] numa: Extend the CLI to provide memory latency and bandwidth information

2019-08-09 Thread Tao
From: Liu Jingqi Add -numa hmat-lb option to provide System Locality Latency and Bandwidth Information. These memory attributes help to build System Locality Latency and Bandwidth Information Structure(s) in ACPI Heterogeneous Memory Attribute Table (HMAT). Signed-off-by: Liu Jingqi Signed-off-

[Qemu-devel] [PATCH v9 10/11] numa: Extend the CLI to provide memory side cache information

2019-08-09 Thread Tao
From: Liu Jingqi Add -numa hmat-cache option to provide Memory Side Cache Information. These memory attributes help to build Memory Side Cache Information Structure(s) in ACPI Heterogeneous Memory Attribute Table (HMAT). Signed-off-by: Liu Jingqi Signed-off-by: Tao Xu --- No changes in v9. --

[Qemu-devel] [PATCH v9 05/11] numa: Extend CLI to provide initiator information for numa nodes

2019-08-09 Thread Tao
From: Tao Xu In ACPI 6.3 chapter 5.2.27 Heterogeneous Memory Attribute Table (HMAT), The initiator represents processor which access to memory. And in 5.2.27.3 Memory Proximity Domain Attributes Structure, the attached initiator is defined as where the memory controller responsible for a memory p

[Qemu-devel] [PATCH v9 11/11] tests/bios-tables-test: add test cases for ACPI HMAT

2019-08-09 Thread Tao
From: Tao Xu ACPI table HMAT has been introduced, QEMU now builds HMAT tables for Heterogeneous Memory with boot option '-numa node'. Add test cases on PC and Q35 machines with 2 numa nodes. Because HMAT is generated when system enable numa, the following tables need to be added for this test:

[Qemu-devel] [PATCH v9 08/11] hmat acpi: Build Memory Side Cache Information Structure(s)

2019-08-09 Thread Tao
From: Liu Jingqi This structure describes memory side cache information for memory proximity domains if the memory side cache is present and the physical device forms the memory side cache. The software could use this information to effectively place the data in memory to maximize the performance

[Qemu-devel] [PATCH v3] hw: net: cadence_gem: Fix build errors in DB_PRINT()

2019-08-09 Thread Bin Meng
When CADENCE_GEM_ERR_DEBUG is turned on, there are several compilation errors in DB_PRINT(). Fix them. While we are here, update to use appropriate modifiers in the same DB_PRINT() call. Signed-off-by: Bin Meng --- Changes in v3: - use PRIx64 as rx_desc_get_buffer() returns uint64_t - use %u f

Re: [Qemu-devel] [PATCH 4/8] block/backup: improve unallocated clusters skipping

2019-08-09 Thread Vladimir Sementsov-Ogievskiy
07.08.2019 21:01, Max Reitz wrote: > On 07.08.19 10:07, Vladimir Sementsov-Ogievskiy wrote: >> Limit block_status querying to request bounds on write notifier to >> avoid extra seeking. > > I don’t understand this reasoning. Checking whether something is > allocated for qcow2 should just mean an

Re: [Qemu-devel] [PATCH 3/8] block/io: handle alignment and max_transfer for copy_range

2019-08-09 Thread Vladimir Sementsov-Ogievskiy
07.08.2019 20:28, Max Reitz wrote: > On 07.08.19 10:07, Vladimir Sementsov-Ogievskiy wrote: >> copy_range ignores these limitations, let's improve it. block/backup >> code handles max_transfer for copy_range by itself, now it's not needed >> more, drop it. > > Shouldn’t this be two separate patche

Re: [Qemu-devel] [PATCH 8/8] block/backup: backup_do_cow: use bdrv_dirty_bitmap_next_dirty_area

2019-08-09 Thread Vladimir Sementsov-Ogievskiy
07.08.2019 21:46, Max Reitz wrote: > On 07.08.19 10:07, Vladimir Sementsov-Ogievskiy wrote: >> Use effective bdrv_dirty_bitmap_next_dirty_area interface. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> block/backup.c | 56 ++ >> 1 file

Re: [Qemu-devel] [PATCH v1 0/7] softfloat header cleanups

2019-08-09 Thread Alex Bennée
Markus Armbruster writes: > Alex Bennée writes: > >> Hi Markus, >> >> As promised here is a softfloat specific follow-up to your headers >> clean-up series: >> >> From: Markus Armbruster >> Date: Tue, 6 Aug 2019 17:14:06 +0200 >> Message-Id: <20190806151435.10740-1-arm...@redhat.com> >

Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-09 Thread Stefan Hajnoczi
On Thu, Aug 08, 2019 at 10:53:16AM +0100, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > On Wed, Aug 07, 2019 at 04:57:15PM -0400, Vivek Goyal wrote: > > 2. Can MAP/UNMAP be performed directly in QEMU via a separate virtqueue? > > I think there's two things to s

Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-09 Thread Stefan Hajnoczi
On Thu, Aug 08, 2019 at 08:53:20AM -0400, Vivek Goyal wrote: > On Thu, Aug 08, 2019 at 10:53:16AM +0100, Dr. David Alan Gilbert wrote: > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > On Wed, Aug 07, 2019 at 04:57:15PM -0400, Vivek Goyal wrote: > > > > Kernel also serializes MAP/UNMAP on on

Re: [Qemu-devel] [PATCH] tests/test-hbitmap: test next_zero and _next_dirty_area after truncate

2019-08-09 Thread Vladimir Sementsov-Ogievskiy
08.08.2019 3:04, John Snow wrote: > > > On 8/5/19 12:46 PM, Vladimir Sementsov-Ogievskiy wrote: >> Test that hbitmap_next_zero and hbitmap_next_dirty_area can find things >> after old bitmap end. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> >> It's a follow-up for >> >> [PATC

Re: [Qemu-devel] [PATCH v3 14/33] hw/s390x/s390-virtio-ccw.c: remove qdev_reset_all call

2019-08-09 Thread Damien Hedde
On 8/8/19 12:50 PM, Cornelia Huck wrote: > On Mon, 29 Jul 2019 16:56:35 +0200 > Damien Hedde wrote: > >> Replace deprecated qdev_reset_all by device_reset_warm. >> >> This does not impact the behavior. > > Not so sure about that; see below. In this case, qdev_reset_all is used. The qdev subt

Re: [Qemu-devel] [PATCH v1 5/7] target/mips: rationalise softfloat includes

2019-08-09 Thread Alex Bennée
Richard Henderson writes: > On 8/8/19 9:41 AM, Alex Bennée wrote: >> index 21c0615e020..f146924623c 100644 >> --- a/target/mips/cpu.h >> +++ b/target/mips/cpu.h >> @@ -5,7 +5,8 @@ >> >> #include "cpu-qom.h" >> #include "exec/cpu-defs.h" >> -#include "fpu/softfloat.h" >> +#include "fpu/softflo

Re: [Qemu-devel] [PATCH v3 08/33] Add function to control reset with gpio inputs

2019-08-09 Thread Damien Hedde
On 8/9/19 7:51 AM, David Gibson wrote: > On Wed, Aug 07, 2019 at 11:37:51AM +0100, Peter Maydell wrote: >> On Wed, 31 Jul 2019 at 07:33, David Gibson >> wrote: >>> >>> On Mon, Jul 29, 2019 at 04:56:29PM +0200, Damien Hedde wrote: It adds the possibility to add 2 gpios to control the warm

Re: [Qemu-devel] [RFC PATCH 1/6] utils/python_api: add scripting interface for Qemu with python lib

2019-08-09 Thread Stefan Hajnoczi
On Thu, Aug 08, 2019 at 11:53:07AM +0100, Daniel P. Berrangé wrote: > On Thu, Aug 08, 2019 at 11:10:13AM +0100, Stefan Hajnoczi wrote: > > On Wed, Aug 07, 2019 at 12:20:47PM +0200, Philippe Mathieu-Daudé wrote: > > > > +void python_args_clean(char *args[], int nargs) > > > > +{ > > > > +for (in

Re: [Qemu-devel] [PATCH v1 7/7] targets (various): use softfloat-helpers.h where we can

2019-08-09 Thread David Hildenbrand
On 08.08.19 18:41, Alex Bennée wrote: > Generally the cpu and non-FP helper files just want to manipulate the > softfloat flags. For this they can just use the -helpers.h include > which brings in a minimal number of inline helpers. > > Signed-off-by: Alex Bennée > --- > target/alpha/helper.c

Re: [Qemu-devel] [RFC PATCH v2 03/17] fuzz: Keep memory mapped for fork-based fuzzer

2019-08-09 Thread Stefan Hajnoczi
On Mon, Aug 05, 2019 at 07:11:04AM +, Oleinik, Alexander wrote: > Otherwise, the RAM is unmapped from the child-processes, which breaks > any fuzz tests relying on DMA. > > Signed-off-by: Alexander Oleinik > --- > exec.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [RFC PATCH v2 04/17] fuzz: Skip modules that were already initialized

2019-08-09 Thread Stefan Hajnoczi
On Mon, Aug 05, 2019 at 07:11:05AM +, Oleinik, Alexander wrote: > Signed-off-by: Alexander Oleinik > --- > util/module.c | 7 +++ > 1 file changed, 7 insertions(+) Why is this necessary? Existing callers only invoke this function once for each type. Please include justification in the

Re: [Qemu-devel] [RFC PATCH v2 06/17] fuzz: Add FUZZ_TARGET module type

2019-08-09 Thread Stefan Hajnoczi
On Mon, Aug 05, 2019 at 07:11:07AM +, Oleinik, Alexander wrote: > Signed-off-by: Alexander Oleinik > --- > include/qemu/module.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

[Qemu-devel] [PATCH] qemu-img convert: Deprecate using -n and -o together

2019-08-09 Thread Kevin Wolf
bdrv_create options specified with -o have no effect when skipping image creation with -n, so this doesn't make sense. Warn against the misuse and deprecate the combination so we can make it a hard error later. Signed-off-by: Kevin Wolf --- qemu-img.c | 5 + qemu-deprecated.texi |

Re: [Qemu-devel] [Fail] tests/test-util-filemonitor fails

2019-08-09 Thread Daniel P . Berrangé
On Fri, Aug 09, 2019 at 08:06:09AM +0800, Wei Yang wrote: > On Thu, Aug 08, 2019 at 10:22:13AM +0100, Daniel P. Berrangé wrote: > >On Thu, Aug 08, 2019 at 04:46:53PM +0800, Wei Yang wrote: > >> On Thu, Aug 08, 2019 at 09:02:29AM +0100, Daniel P. Berrangé wrote: > >> >On Thu, Aug 08, 2019 at 10:07:2

Re: [Qemu-devel] [PATCH 4/8] block/backup: improve unallocated clusters skipping

2019-08-09 Thread Vladimir Sementsov-Ogievskiy
09.08.2019 10:50, Vladimir Sementsov-Ogievskiy wrote: > 07.08.2019 21:01, Max Reitz wrote: >> On 07.08.19 10:07, Vladimir Sementsov-Ogievskiy wrote: >>> Limit block_status querying to request bounds on write notifier to >>> avoid extra seeking. >> >> I don’t understand this reasoning.  Checking whe

[Qemu-devel] [PATCH v2 7/7] targets (various): use softfloat-helpers.h where we can

2019-08-09 Thread Alex Bennée
Generally the cpu and non-FP helper files just want to manipulate the softfloat flags. For this they can just use the -helpers.h include which brings in a minimal number of inline helpers. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- target/alpha/helper.c | 2 +- target/micro

[Qemu-devel] [PATCH v2 1/7] fpu: move LIT64 helper to softfloat-types

2019-08-09 Thread Alex Bennée
This simple pasting helper can be used by those who don't need the entire softfloat api. Move it to the smaller types header. Signed-off-by: Alex Bennée Acked-by: Richard Henderson --- include/fpu/softfloat-types.h | 2 ++ include/fpu/softfloat.h | 2 -- 2 files changed, 2 insertions(+),

[Qemu-devel] [PATCH v2 3/7] fpu: make softfloat-macros "self-contained"

2019-08-09 Thread Alex Bennée
The macros use the "flags" type and to be consistent if anyone just needs the macros we should bring in the header we need. There is an outstanding TODO to audit the use of "flags" and replace with bool at which point this include could be dropped. Signed-off-by: Alex Bennée Acked-by: Richard Hen

[Qemu-devel] [PATCH v2 4/7] fpu: rename softfloat-specialize.h -> .inc.c

2019-08-09 Thread Alex Bennée
This is not a normal header and should only be included in the main softfloat.c file to bring in the various target specific specialisations. Indeed as it contains non-inlined C functions it is not even a legal header. Rename it to match our included C convention. Signed-off-by: Alex Bennée Revie

Re: [Qemu-devel] [PATCH v3 02/33] add temporary device_legacy_reset function to replace device_reset

2019-08-09 Thread Damien Hedde
On 8/7/19 4:27 PM, Peter Maydell wrote: > On Mon, 29 Jul 2019 at 15:58, Damien Hedde wrote: >> >> Provide a temporary function doing what device_reset does to do the >> transition with Resettable API which will trigger a prototype change >> of device_reset. > > The other point here is that devi

[Qemu-devel] [PATCH v2 0/7] softfloat includes cleanup

2019-08-09 Thread Alex Bennée
Hi Markus, Here is v2 of the softfloat headers cleanup which addresses Richards comments from yesterday. The following patches need review 01 - fpu move LIT64 helper to softfloat types (1 ack) 03 - fpu make softfloat macros self contained (1 ack) 05 - target mips rationalise softfloat in

[Qemu-devel] [PATCH v2 2/7] fpu: move inline helpers into a separate header

2019-08-09 Thread Alex Bennée
There are a bunch of users of the inline helpers who do not need access to the entire softfloat API. Move those inline helpers into a new header file which can be included without bringing in the rest of the world. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - don't squas

[Qemu-devel] [PATCH v2 6/7] target/riscv: rationalise softfloat includes

2019-08-09 Thread Alex Bennée
We should avoid including the whole of softfloat headers in cpu.h and explicitly include it only where we will be calling softfloat functions. We can use the -types.h and -helpers.h in cpu.h for the few bits that are global. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- target/r

Re: [Qemu-devel] [RFC PATCH v2 05/17] fuzz: Add direct receive function for qtest server

2019-08-09 Thread Stefan Hajnoczi
On Mon, Aug 05, 2019 at 07:11:06AM +, Oleinik, Alexander wrote: > The direct receive function qtest_server_recv is directly invoked by the > qtest client, when the server and client exist within the same process. > > Signed-off-by: Alexander Oleinik > --- > include/sysemu/qtest.h | 4 >

[Qemu-devel] [PATCH v2 5/7] target/mips: rationalise softfloat includes

2019-08-09 Thread Alex Bennée
We should avoid including the whole of softfloat headers in cpu.h and explicitly include it only where we will be calling softfloat functions. We can use the -types.h in cpu.h for the few bits that are global. We also move the restore_snan_bit_mode into internal.h and include -helpers.h there. Sig

Re: [Qemu-devel] [PATCH] numa: Introduce MachineClass::auto_enable_numa for implicit NUMA node

2019-08-09 Thread Igor Mammedov
On Thu, 8 Aug 2019 16:35:00 +1000 David Gibson wrote: > On Wed, Aug 07, 2019 at 02:52:56PM -0300, Eduardo Habkost wrote: > > On Tue, Aug 06, 2019 at 02:50:55PM +0200, Igor Mammedov wrote: > > > On Mon, 5 Aug 2019 15:13:02 +0800 > > > Tao Xu wrote: > > > > > > > Add MachineClass::auto_enabl

Re: [Qemu-devel] [RFC PATCH v2 09/17] fuzz: hardcode needed objects into i386 target

2019-08-09 Thread Stefan Hajnoczi
On Mon, Aug 05, 2019 at 07:11:10AM +, Oleinik, Alexander wrote: > Temporary solution until there is a better build solution for fuzzers in > tests/Makefile.include > > Signed-off-by: Alexander Oleinik > --- > target/i386/Makefile.objs | 20 > 1 file changed, 20 insertion

Re: [Qemu-devel] [PATCH v2 0/7] softfloat includes cleanup

2019-08-09 Thread Philippe Mathieu-Daudé
On 8/9/19 11:19 AM, Alex Bennée wrote: > Hi Markus, > > Here is v2 of the softfloat headers cleanup which addresses Richards > comments from yesterday. > > The following patches need review >01 - fpu move LIT64 helper to softfloat types (1 ack) >03 - fpu make softfloat macros self contain

Re: [Qemu-devel] [PATCH v2 0/7] softfloat includes cleanup

2019-08-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190809091940.1223-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v2 0/7] softfloat includes cleanup Message-id: 20190809091940.1223-1-

Re: [Qemu-devel] [RFC PATCH v2 10/17] fuzz: qtest client directly interacts with server

2019-08-09 Thread Stefan Hajnoczi
On Mon, Aug 05, 2019 at 07:11:11AM +, Oleinik, Alexander wrote: > Signed-off-by: Alexander Oleinik > --- > tests/libqtest.c | 61 ++-- > tests/libqtest.h | 6 + > 2 files changed, 65 insertions(+), 2 deletions(-) Please refactor the code inste

Re: [Qemu-devel] [PATCH v3 20/29] Include qemu/main-loop.h less

2019-08-09 Thread Philippe Mathieu-Daudé
On 8/9/19 8:46 AM, Markus Armbruster wrote: > In my "build everything" tree, changing qemu/main-loop.h triggers a > recompile of some 5600 out of 6600 objects (not counting tests and > objects that don't depend on qemu/osdep.h). It includes block/aio.h, > which in turn includes qemu/event_notifier

Re: [Qemu-devel] [RFC PATCH v2 12/17] fuzz: Add fuzzer skeleton

2019-08-09 Thread Stefan Hajnoczi
On Mon, Aug 05, 2019 at 07:11:13AM +, Oleinik, Alexander wrote: > diff --git a/tests/fuzz/fuzz.c b/tests/fuzz/fuzz.c > new file mode 100644 > index 00..9e03e15d7b > --- /dev/null > +++ b/tests/fuzz/fuzz.c > @@ -0,0 +1,245 @@ > +#include "qemu/osdep.h" > +#include "qemu-common.h" > +#inc

Re: [Qemu-devel] [RFC PATCH v2 14/17] fuzz: Add forking support to the fuzzer

2019-08-09 Thread Stefan Hajnoczi
On Mon, Aug 05, 2019 at 07:11:15AM +, Oleinik, Alexander wrote: > +void *counter_shm; > +size_t feature_shm_len; > +uintptr_t feature_shm; > +size_t offset; > + > +typedef struct CoverageRegion { > +uint8_t *start; > +size_t length; > +bool store; /* Set this if it needs to be copie

Re: [Qemu-devel] [PATCH v2 0/7] softfloat includes cleanup

2019-08-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190809091940.1223-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v2 0/7] softfloat includes cleanup Message-id: 20190809091940.1223-1-

Re: [Qemu-devel] [PATCH v3 12/33] hw/pci/: remove qdev/qbus_reset_all call

2019-08-09 Thread Damien Hedde
On 8/7/19 5:31 PM, Peter Maydell wrote: > On Mon, 29 Jul 2019 at 15:59, Damien Hedde wrote: >> >> Replace deprecated qdev/bus_reset_all by device/bus_reset_warm. >> >> This does not impact the behavior. >> >> Signed-off-by: Damien Hedde > > I'll come back to patches 12-28 later. They're all o

Re: [Qemu-devel] [PULL 09/22] target/arm: Implement ARMv8.5-CondM

2019-08-09 Thread Peter Maydell
On Tue, 5 Mar 2019 at 16:51, Peter Maydell wrote: > > From: Richard Henderson > > Tested-by: Laurent Desnogues > Signed-off-by: Richard Henderson > Message-id: 20190301200501.16533-9-richard.hender...@linaro.org > Reviewed-by: Peter Maydell > Signed-off-by: Peter Maydell > diff --git a/targe

Re: [Qemu-devel] [PATCH v3 09/29] Include migration/qemu-file-types.h a lot less

2019-08-09 Thread Philippe Mathieu-Daudé
On 8/9/19 8:46 AM, Markus Armbruster wrote: > In my "build everything" tree, changing migration/qemu-file-types.h > triggers a recompile of some 2600 out of 6600 objects (not counting > tests and objects that don't depend on qemu/osdep.h). > > The culprit is again hw/hw.h, which supposedly include

Re: [Qemu-devel] [PATCH v2 0/7] softfloat includes cleanup

2019-08-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190809091940.1223-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v2 0/7] softfloat includes cleanup Message-id: 20190809091940.1223-1-

Re: [Qemu-devel] [PATCH v3 16/29] Include exec/memory.h slightly less

2019-08-09 Thread Philippe Mathieu-Daudé
On 8/9/19 8:46 AM, Markus Armbruster wrote: > Drop unnecessary inclusions from headers. Downgrade a few more to > exec/hwaddr.h. > > Signed-off-by: Markus Armbruster > --- > hw/audio/lm4549.h | 1 + > hw/display/edid-region.c| 1 + > hw/display/tc6393xb.c

Re: [Qemu-devel] [PATCH v3 19/29] Include qemu/queue.h slightly less

2019-08-09 Thread Philippe Mathieu-Daudé
On 8/9/19 8:46 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > hw/scsi/vhost-scsi.c| 1 - > hw/vfio/ap.c| 1 - > include/exec/cpu-defs.h | 1 - > include/hw/xen/xen_common.h | 1 - > include/net/can_emu.h | 1 + > include/net/filter.h

Re: [Qemu-devel] [PATCH v3 07/33] automatically add vmstate for reset support in devices

2019-08-09 Thread Peter Maydell
On Thu, 8 Aug 2019 at 16:42, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > On Mon, 29 Jul 2019 at 15:59, Damien Hedde > > wrote: > > > > > > This add the reset related sections for every QOM > > > device. > > > > A bit more detail in the commit message w

Re: [Qemu-devel] [PATCH v1 1/7] fpu: move LIT64 helper to softfloat-types

2019-08-09 Thread Peter Maydell
On Thu, 8 Aug 2019 at 17:41, Alex Bennée wrote: > > This simple pasting helper can be used by those who don't need the > entire softfloat api. Move it to the smaller types header. > > Signed-off-by: Alex Bennée > --- > include/fpu/softfloat-types.h | 2 ++ > include/fpu/softfloat.h | 2 --

Re: [Qemu-devel] [PATCH 4/8] block/backup: improve unallocated clusters skipping

2019-08-09 Thread Vladimir Sementsov-Ogievskiy
09.08.2019 10:50, Vladimir Sementsov-Ogievskiy wrote: > 07.08.2019 21:01, Max Reitz wrote: >> On 07.08.19 10:07, Vladimir Sementsov-Ogievskiy wrote: >>> Limit block_status querying to request bounds on write notifier to >>> avoid extra seeking. >> >> I don’t understand this reasoning.  Checking whe

Re: [Qemu-devel] [PATCH v3 20/29] Include qemu/main-loop.h less

2019-08-09 Thread Philippe Mathieu-Daudé
On 8/9/19 11:42 AM, Philippe Mathieu-Daudé wrote: [...] > netmap failing again :S > > $ make docker-image-debian-amd64 V=1 DEBUG=1 To clarify an incomplete paste, this command doesn't build QEMU. It build the docker image, start an container instance, and keep an interactive shell opened, so you

Re: [Qemu-devel] [PATCH v2 0/7] softfloat includes cleanup

2019-08-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190809091940.1223-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v2 0/7] softfloat includes cleanup Message-id: 20190809091940.1223-1-

[Qemu-devel] [Bug 1838946] Re: qemu 3.10 golang crash

2019-08-09 Thread Peter Maydell
Thanks for retesting! (We haven't quite got 4.1.0 out of the door yet, so I'll just move this bug to 'fix committed' for the moment; we'll update it back to 'fix released' next week.) ** Changed in: qemu Status: Fix Released => Fix Committed -- You received this bug notification because

Re: [Qemu-devel] [PATCH v2 5/7] target/mips: rationalise softfloat includes

2019-08-09 Thread Aleksandar Markovic
On Fri, Aug 9, 2019 at 11:23 AM Alex Bennée wrote: > We should avoid including the whole of softfloat headers in cpu.h and > explicitly include it only where we will be calling softfloat > functions. We can use the -types.h in cpu.h for the few bits that are > global. We also move the restore_sna

Re: [Qemu-devel] [PATCH 4/8] block/backup: improve unallocated clusters skipping

2019-08-09 Thread Vladimir Sementsov-Ogievskiy
09.08.2019 12:12, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2019 10:50, Vladimir Sementsov-Ogievskiy wrote: >> 07.08.2019 21:01, Max Reitz wrote: >>> On 07.08.19 10:07, Vladimir Sementsov-Ogievskiy wrote: Limit block_status querying to request bounds on write notifier to avoid extra see

Re: [Qemu-devel] [PATCH v3 07/33] automatically add vmstate for reset support in devices

2019-08-09 Thread Damien Hedde
On 8/9/19 12:07 PM, Peter Maydell wrote: > On Thu, 8 Aug 2019 at 16:42, Dr. David Alan Gilbert > wrote: >> >> * Peter Maydell (peter.mayd...@linaro.org) wrote: >>> On Mon, 29 Jul 2019 at 15:59, Damien Hedde >>> wrote: This add the reset related sections for every QOM device. >

Re: [Qemu-devel] [PATCH v3 20/29] Include qemu/main-loop.h less

2019-08-09 Thread Philippe Mathieu-Daudé
On 8/9/19 11:42 AM, Philippe Mathieu-Daudé wrote: [...] > netmap failing again :S > > $ make docker-image-debian-amd64 V=1 DEBUG=1 > [...] > CC net/netmap.o > net/netmap.c: In function 'netmap_update_fd_handler': > net/netmap.c:109:5: error: implicit declaration of function > 'qemu_set_fd_h

Re: [Qemu-devel] [PATCH 11/67] target/arm: Add stubs for aa32 decodetree

2019-08-09 Thread Aleksandar Markovic
On Thu, Aug 8, 2019 at 5:43 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/8/19 4:41 AM, Aleksandar Markovic wrote: > > +/* > > + * Include the generated decoders. > > + * Note that the T32 decoder reuses some of the trans_* functions > > + * initially declared

Re: [Qemu-devel] [PATCH v3 07/33] automatically add vmstate for reset support in devices

2019-08-09 Thread Peter Maydell
On Fri, 9 Aug 2019 at 11:29, Damien Hedde wrote: > > One way to keep the feature without copy-pasting vmsd would be to add > a new vmstate_register with an additional argument to pass the base > class vmsd section and handle the whole thing there. If we have a vmstate section which contains no ac

Re: [Qemu-devel] [PATCH v2 0/7] softfloat includes cleanup

2019-08-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190809091940.1223-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v2 0/7] softfloat includes cleanup Message-id: 20190809091940.1223-1-

Re: [Qemu-devel] [PATCH v3 20/29] Include qemu/main-loop.h less

2019-08-09 Thread Philippe Mathieu-Daudé
On 8/9/19 12:29 PM, Philippe Mathieu-Daudé wrote: > On 8/9/19 11:42 AM, Philippe Mathieu-Daudé wrote: > [...] >> netmap failing again :S >> >> $ make docker-image-debian-amd64 V=1 DEBUG=1 >> [...] >> CC net/netmap.o >> net/netmap.c: In function 'netmap_update_fd_handler': >> net/netmap.c:109

Re: [Qemu-devel] [PATCH v3 24/29] Include sysemu/hostmem.h less

2019-08-09 Thread Philippe Mathieu-Daudé
On 8/9/19 8:46 AM, Markus Armbruster wrote: > Move the HostMemoryBackend typedef from sysemu/hostmem.h to > qemu/typedefs.h. This renders a few inclusions of sysemu/hostmem.h > superfluous; drop them. > > Cc: Eduardo Habkost > Cc: Igor Mammedov > Signed-off-by: Markus Armbruster > Reviewed-by:

Re: [Qemu-devel] [PATCH v3 00/29] Tame a few "touch this, recompile the world" headers

2019-08-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190809064645.22656-1-arm...@redhat.com/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that ha

Re: [Qemu-devel] [PATCH v3 07/33] automatically add vmstate for reset support in devices

2019-08-09 Thread Damien Hedde
On 8/9/19 12:32 PM, Peter Maydell wrote: > On Fri, 9 Aug 2019 at 11:29, Damien Hedde wrote: >> >> One way to keep the feature without copy-pasting vmsd would be to add >> a new vmstate_register with an additional argument to pass the base >> class vmsd section and handle the whole thing there. >

Re: [Qemu-devel] [PATCH v3 25/29] numa: Move remaining NUMA declarations from sysemu.h to numa.h

2019-08-09 Thread Philippe Mathieu-Daudé
On 8/9/19 8:46 AM, Markus Armbruster wrote: > Commit e35704ba9c "numa: Move NUMA declarations from sysemu.h to > numa.h" left a few NUMA-related macros behind. Move them now. > > Cc: Eduardo Habkost > Cc: Marcel Apfelbaum > Signed-off-by: Markus Armbruster > Reviewed-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH v3 05/33] Switch to new api in qdev/bus

2019-08-09 Thread Peter Maydell
On Fri, 9 Aug 2019 at 01:10, David Gibson wrote: > > On Wed, Jul 31, 2019 at 01:31:28PM +0200, Philippe Mathieu-Daudé wrote: > > On 7/31/19 11:29 AM, Damien Hedde wrote: > > > On 7/31/19 8:05 AM, David Gibson wrote: > > >> On Mon, Jul 29, 2019 at 04:56:26PM +0200, Damien Hedde wrote: > > >>> @@ -9

Re: [Qemu-devel] [PATCH v9 00/11] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

2019-08-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190809065731.9097-1-tao3...@intel.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make do

Re: [Qemu-devel] [PATCH v3 05/33] Switch to new api in qdev/bus

2019-08-09 Thread Cédric Le Goater
>>> So.. is this change in the device_reset() signature really necessary? >>> Even if there are compelling reasons to handle warm reset in the new >>> API, that doesn't been you need to change device_reset() itself from >>> its established meaning of a cold (i.e. as per power cycle) reset. >>> Wa

Re: [Qemu-devel] [PATCH v3 09/29] Include migration/qemu-file-types.h a lot less

2019-08-09 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 8/9/19 8:46 AM, Markus Armbruster wrote: >> In my "build everything" tree, changing migration/qemu-file-types.h >> triggers a recompile of some 2600 out of 6600 objects (not counting >> tests and objects that don't depend on qemu/osdep.h). >> >> The culprit is

Re: [Qemu-devel] [PATCH v3 20/29] Include qemu/main-loop.h less

2019-08-09 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 8/9/19 8:46 AM, Markus Armbruster wrote: >> In my "build everything" tree, changing qemu/main-loop.h triggers a >> recompile of some 5600 out of 6600 objects (not counting tests and >> objects that don't depend on qemu/osdep.h). It includes block/aio.h, >> whi

Re: [Qemu-devel] Does i386-linux-user build on an i686 host?

2019-08-09 Thread Peter Maydell
On Thu, 8 Aug 2019 at 16:37, Markus Armbruster wrote: > > Fails for me, but perhaps I'm doing it wrong: > NOTE: cross-compilers enabled: 'cc' > $ make > CC i386-linux-user/linux-user/syscall.o > /home/armbru/qemu/linux-user/ioctls.h:306:9: error: ‘SNDCTL_DSP_MAPINBUF’ > undeclared here

Re: [Qemu-devel] [PATCH 4/8] block/backup: improve unallocated clusters skipping

2019-08-09 Thread Max Reitz
On 09.08.19 09:50, Vladimir Sementsov-Ogievskiy wrote: > 07.08.2019 21:01, Max Reitz wrote: >> On 07.08.19 10:07, Vladimir Sementsov-Ogievskiy wrote: >>> Limit block_status querying to request bounds on write notifier to >>> avoid extra seeking. >> >> I don’t understand this reasoning. Checking wh

Re: [Qemu-devel] [PATCH v3 20/29] Include qemu/main-loop.h less

2019-08-09 Thread Philippe Mathieu-Daudé
On 8/9/19 1:55 PM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: >> On 8/9/19 8:46 AM, Markus Armbruster wrote: >>> In my "build everything" tree, changing qemu/main-loop.h triggers a >>> recompile of some 5600 out of 6600 objects (not counting tests and >>> objects that don't depend o

Re: [Qemu-devel] [PATCH 4/8] block/backup: improve unallocated clusters skipping

2019-08-09 Thread Vladimir Sementsov-Ogievskiy
09.08.2019 15:25, Max Reitz wrote: > On 09.08.19 09:50, Vladimir Sementsov-Ogievskiy wrote: >> 07.08.2019 21:01, Max Reitz wrote: >>> On 07.08.19 10:07, Vladimir Sementsov-Ogievskiy wrote: Limit block_status querying to request bounds on write notifier to avoid extra seeking. >>> >>> I do

[Qemu-devel] [PATCH for 4.2 v7 03/26] target/mips: Amend CP0 MemoryMapID register implementation

2019-08-09 Thread Aleksandar Markovic
From: Yongbok Kim Add migration support and fix preprocessor constant name for MemoryMapID register. Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 2 +- target/mips/machine.c | 7 +-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH for 4.2 v7 10/26] target/mips: Style improvements in machine.c

2019-08-09 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé --- target/mips/machine.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/mips/machine.c b/target/mi

[Qemu-devel] [PATCH for 4.2 v7 11/26] target/mips: Style improvements in cps.c

2019-08-09 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic --- hw/mips/cps.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/mips/cps.c b/hw/mips/cps.c index c84bc64..8fe2f47 100644 --- a/hw/mips/cp

[Qemu-devel] [PATCH for 4.2 v7 00/26] target/mips: Misc patches for 4.2

2019-08-09 Thread Aleksandar Markovic
From: Aleksandar Markovic This series includes misc MIPS patches intended to be integrated after 4.1 release. v6->v7: - added four more patches on CP0 cleanup - other minor improvements v5->v6: - added five more patches on style improvements - added five patches on CP0 cleanup - oth

[Qemu-devel] [PATCH for 4.2 v7 09/26] target/mips: Style improvements in internal.h

2019-08-09 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé --- target/mips/internal.h | 57 +++--- 1 file changed, 35 insertions(+), 22 deletions(

[Qemu-devel] [PATCH for 4.2 v7 05/26] target/mips: Add support for emulation of CRC32 group of instructions

2019-08-09 Thread Aleksandar Markovic
From: Yongbok Kim Add emulation of MIPS' CRC32 (Cyclic Redundancy Check) instructions. Reuse zlib crc32() and Linux crc32c(). Note that, at the time being, there is no MIPS CPU that supports CRC32 instructions (they are an optional part of MIPS64/32 R6 anf nanoMIPS ISAs). Signed-off-by: Yongbok

[Qemu-devel] [PATCH for 4.2 v7 06/26] target/mips: Style improvements in cp0_timer.c

2019-08-09 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé --- target/mips/cp0_timer.c | 42 +++--- 1 file changed, 23 insertions(+), 19 deletions(-) dif

[Qemu-devel] [PATCH for 4.2 v7 07/26] target/mips: Style improvements in cpu.c

2019-08-09 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé --- target/mips/cpu.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/target/mips/cpu.c b/ta

[Qemu-devel] [PATCH for 4.2 v7 13/26] target/mips: Style improvements in mips_int.c

2019-08-09 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic --- hw/mips/mips_int.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/mips/mips_int.c b/hw/mips/mips_int.c index f899f6c..4c731ab 100644 --- a

[Qemu-devel] [PATCH for 4.2 v7 08/26] target/mips: Style improvements in helper.c

2019-08-09 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic --- target/mips/helper.c | 98 1 file changed, 60 insertions(+), 38 deletions(-) diff --git a/target/mips/helper.c

[Qemu-devel] [PATCH for 4.2 v7 19/26] target/mips: Clean up handling of CP0 register 5

2019-08-09 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 5. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 6 + target/mips/translate.c | 64 - 2 files changed, 38 insertions(+), 32 deletions(-) diff --git a/target/mips

[Qemu-devel] [PATCH for 4.2 v7 12/26] target/mips: Style improvements in mips_fulong2e.c

2019-08-09 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic --- hw/mips/mips_fulong2e.c | 96 + 1 file changed, 58 insertions(+), 38 deletions(-) diff --git a/hw/mips/mips_fulong2

[Qemu-devel] [PATCH for 4.2 v7 23/26] target/mips: Clean up handling of CP0 register 30

2019-08-09 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 30. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index ff71737..b6378ae 100644 --- a/targe

[Qemu-devel] [PATCH for 4.2 v7 04/26] target/mips: Add support for emulation of GINVT instruction

2019-08-09 Thread Aleksandar Markovic
From: Yongbok Kim Implement emulation of GINVT instruction. As QEMU doesn't support caches and virtualization, this implementation covers only GINVT (Global Invalidate TLB) instruction among TLB-related instructions. Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic --- disas/mips

[Qemu-devel] [PATCH for 4.2 v7 15/26] target/mips: Style improvements in mips_mipssim.c

2019-08-09 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic --- hw/mips/mips_mipssim.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/hw/mips/mips_mipssim.c b/hw/mips/mips_mipssim.c inde

  1   2   3   >