On 06/08/19 08:40, Gerd Hoffmann wrote:
> Well, the commit message pretty much says it. We have sdl.mo in both
> ui/ and audio/ (final module names are audio-sdl.so and ui-sdl.so).
>
> This certainly was needed back when I added it. Possibly it can be
> removed now, I don't follow build system c
Some more nasty things discovered during the Meson conversion project.
Paolo Bonzini (2):
qemu-ga: clean up TOOLS variable
configure: define CONFIG_TOOLS here
Makefile | 9 -
configure | 5 -
2 files changed, 8 insertions(+), 6 deletions(-)
--
1.8.3.1
qemu-ga is included in the TOOLS variable without the .exe suffix, and this is
then worked around twice in the Makefile. Do the right thing in configure
instead.
Signed-off-by: Paolo Bonzini
---
Makefile | 4 ++--
configure | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a
Defining CONFIG_TOOLS on the basis of $(TOOLS) has the disadvantage
of including it also if e.g. qemu-ga is requested. The correct
information is available in configure, define it there.
This also has the benefit of not installing the manpages for block layer
tools if the only "tool" being built
From: Marc-André Lureau
The hashtable is used like a set, use the convenience
g_hash_table_add() function.
Signed-off-by: Marc-André Lureau
Signed-off-by: Paolo Bonzini
---
util/module.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/util/module.c b/util/module.c
index
Improve coverage for modules: add a test that asks QEMU to check that
no symbols are missing from any of the modules.
Markus, is using qtest ok or should it use an x- qmp command instead?
Paolo
Marc-André Lureau (3):
module: use g_hash_table_add()
module: return success on module load
test
qcrypto_random_*, AES and qcrypto_init do not need to be linked as a whole
and are the only parts that are used by user-mode emulation. Place them
in libqemuutil, so that whatever needs them will pick them up automatically.
Signed-off-by: Paolo Bonzini
---
MAINTAINERS |
From: Marc-André Lureau
This is a left-over from commit
c12b6d70e384c769ca372e15ffd19b3e9f563662 ("pixman: drop submodule")
Signed-off-by: Marc-André Lureau
Signed-off-by: Paolo Bonzini
---
configure | 5 -
1 file changed, 5 deletions(-)
diff --git a/configure b/configure
index c5a5b44..
From: Marc-André Lureau
Let the caller know of load success.
Note that this also changes slightly the behaviour of the function to
try loading on subsequent calls if the previous ones failed.
Signed-off-by: Marc-André Lureau
Signed-off-by: Paolo Bonzini
---
include/qemu/module.h | 2 +-
uti
From: Marc-André Lureau
This test will simply check that modules can be loaded, and no symbols
are missing.
Signed-off-by: Marc-André Lureau
Signed-off-by: Paolo Bonzini
---
qtest.c| 9 +++
tests/Makefile.include | 1 +
tests/libqtest.c | 6 +
tests/libqtest.h
Public bug reported:
I made the update to 1903, and the HDA device stopped working.
The driver says the device is working correctly, but it does not.
When I try to open the Windows sound configuration, the dialog hangs and never
shows it's content.
Several people reported this back in May:
htt
Patchew URL:
https://patchew.org/QEMU/1565075472-15106-1-git-send-email-pbonz...@redhat.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/b
On Mon, Aug 05, 2019 at 08:49:49PM +0200, Jens Freimann wrote:
> On Mon, Aug 05, 2019 at 10:22:25AM -0400, Michael S. Tsirkin wrote:
> > On Mon, Aug 05, 2019 at 03:12:15PM +0200, Jens Freimann wrote:
> > > On Fri, Aug 02, 2019 at 11:22:10AM -0400, Michael S. Tsirkin wrote:
> > > > On Fri, Aug 02, 2
On Tue, Aug 06, 2019 at 09:11:15AM +0200, Paolo Bonzini wrote:
> qcrypto_random_*, AES and qcrypto_init do not need to be linked as a whole
> and are the only parts that are used by user-mode emulation. Place them
> in libqemuutil, so that whatever needs them will pick them up automatically.
>
>
On Tue, 30 Jul 2019 at 01:51, Richard Henderson
wrote:
>
> On 7/29/19 7:15 AM, Peter Maydell wrote:
> > On Fri, 26 Jul 2019 at 18:50, Richard Henderson
> > wrote:
> >>
> >> Used only on the thumb side so far, but will be more obvious
> >> once we start unifying the implementation of A32+T32.
> >>
On Mon, 5 Aug 2019 16:54:06 +0100
Peter Maydell wrote:
> On Mon, 5 Aug 2019 at 16:47, Igor Mammedov wrote:
> > On Mon, 5 Aug 2019 14:42:38 +0100
> > Peter Maydell wrote:
> > > This is definitely a bad idea -- devices should not add their
> > > own memory regions to the system memory MR. They
s390 was trying to solve limited KVM memslot size issue by abusing
memory_region_allocate_system_memory(), which breaks API contract
where the function might be called only once.
Beside an invalid use of API, the approach also introduced migration
issue, since RAM chunks for each KVM_SLOT_MAX_BYTE
Changelog:
since v3:
- fix compilation issue
- advance HVA along with GPA in kvm_set_phys_mem()
since v2:
- break migration from old QEMU (since 2.12-4.1) for guest with >8TB RAM
and drop migratable aliases patch as was agreed during v2 review
- drop 4.2 machines patch a
Max memslot size supported by kvm on s390 is 8Tb,
move logic of splitting RAM in chunks upto 8T to KVM code.
This way it will hide KVM specific restrictions in KVM code
and won't affect baord level design decisions. Which would allow
us to avoid misusing memory_region_allocate_system_memory() API
Am 06.08.2019 um 00:19 hat John Snow geschrieben:
>
>
> On 8/2/19 10:07 AM, Kevin Wolf wrote:
> > Am 01.08.2019 um 19:57 hat Max Reitz geschrieben:
> >> On 01.08.19 17:17, Kevin Wolf wrote:
> >>> The part of iotests.main() that is related to the implementation of the
> >>> debug option -d and ena
On Tue, 30 Jul 2019 at 03:11, Richard Henderson
wrote:
>
> On 7/29/19 6:52 AM, Peter Maydell wrote:
> > I'm not so convinced about this one -- gen_exception_insn()
> > and gen_exception_internal_insn() shouldn't have the
> > same pattern of function prototype but different semantics
> > like this,
* Kővágó, Zoltán (dirty.ice...@gmail.com) wrote:
> Signed-off-by: Kővágó, Zoltán
> ---
>
> Notes:
> Changes from v2:
>
> * audiodev parameter for wavcapture is now mandatory.
> * removed some unnecessary qdict_haskey calls from hmp_wavcapture
>
> ui/vnc.h| 2 ++
> moni
On Tue, 30 Jul 2019 at 01:39, Richard Henderson
wrote:
>
> On 7/29/19 7:05 AM, Peter Maydell wrote:
> > On Fri, 26 Jul 2019 at 18:50, Richard Henderson
> > wrote:
> >>
> >> We currently have 3 different ways of computing the architectural
> >> value of "PC" as seen in the ARM ARM.
> >>
> >> The v
it seems the code in blue in tests/fuzz/fuzz.c does not do anything, what
it supposed to be?
// TODO: Replace this with QEMU's built-in linked list
static void enum_memory(void)
{
mtree_info(true, true, true);
fuzz_memory_region *fmr = g_new0(fuzz_memory_region, 1);
fmr->io = false;
On Mon, 5 Aug 2019 at 22:26, Richard Henderson
wrote:
>
> On 8/5/19 8:44 AM, Peter Maydell wrote:
> > On Fri, 26 Jul 2019 at 18:50, Richard Henderson
> > wrote:
> >>
> >> This unifies the implementation of the actual instructions
> >> for a32, t32, and t16. In order to make this happen, we
> >>
On Mon, 5 Aug 2019 at 18:01, Max Reitz wrote:
>
> On 05.08.19 18:59, Vladimir Sementsov-Ogievskiy wrote:
> > 05.08.2019 19:37, Max Reitz wrote:
> >> The following changes since commit
> >> 9bb68d34dda9be60335e73e65c8fb61bca035362:
> >>
> >>Merge remote-tracking branch
> >> 'remotes/philmd-gi
On Mon, 5 Aug 2019 at 22:13, Richard Henderson wrote:
>
> On 8/5/19 11:03 AM, Peter Maydell wrote:
> > The x86 architecture requires that all conversions from floating
> > point to integer which raise the 'invalid' exception (infinities of
> > both signs, NaN, and all values which don't fit in the
* Wei Yang (richardw.y...@linux.intel.com) wrote:
> With the growth of migration capabilities, it is not proper to display
> them in "info migrate". Users are recommended to use "info
> migrate_capabiltiies" to list them.
>
> Signed-off-by: Wei Yang
> Suggested-by: Dr. David Alan Gilbert
Review
I suspect you're not using the new version of QEMU in your test. The
'go' binary will fork and exec other go binaries, and Linux binfmt-misc
will use the system QEMU binary to run those, even if you were running
the top level 'go' binary with the newer QEMU you've built.
For Ubuntu this means you
https://patchew.org/QEMU/20190805180332.10185-1-peter.mayd...@linaro.org/
is a patch which I think probably fixes this bug -- could you test it?
(I don't have an x86 vm with node.js in it to test with.)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is sub
On Gluster storage with sector size of 4096 bytes, buf_align may be
wrong; reading 4096 bytes into unaligned buffer succeeds. This probably
happens because the actual read happens on the Gluster node with aligned
buffer, and Gluster client does not enforce any alignment on the host.
However reques
On Tue, 6 Aug 2019 at 00:16, Paolo Bonzini wrote:
>
> On 05/08/19 23:13, Richard Henderson wrote:
> > On 8/5/19 11:03 AM, Peter Maydell wrote:
> >> The x86 architecture requires that all conversions from floating
> >> point to integer which raise the 'invalid' exception (infinities of
> >> both si
On Mon, Aug 05, 2019 at 08:52:54AM -0700, Bin Meng wrote:
> When CADENCE_GEM_ERR_DEBUG is turned on, there are several
> compilation errors in DB_PRINT(). Fix them.
>
> Signed-off-by: Bin Meng
> ---
>
> hw/net/cadence_gem.c | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> dif
On 06.08.19 12:12, Peter Maydell wrote:
> On Mon, 5 Aug 2019 at 18:01, Max Reitz wrote:
>>
>> On 05.08.19 18:59, Vladimir Sementsov-Ogievskiy wrote:
>>> 05.08.2019 19:37, Max Reitz wrote:
The following changes since commit
9bb68d34dda9be60335e73e65c8fb61bca035362:
Merge rem
For reference alongside this patch set.
Evaluation version of the CCIX 1.0a base specification now available,
(though there is a form to complete and license agreement)..
https://www.ccixconsortium.com/ccix-library/download-form/
Thanks,
Jonathan
On Tue, 25 Jun 2019 19:27:45 +0800
Jonathan Cam
Ramiro Polla writes:
> Since the '!' packet is not handled by the new infrastructure,
> gdb_handle_packet() would call run_cmd_parser() with a NULL cmd_parser
> value, which would lead to an unsupported packet ("$#00") being sent,
> which could confuse the gdb client.
>
> This also has a side-e
Replace all node_id assumptions with lookups from
machinestate->numa_state->nodes[]
and remove aspects that assume a sequential numbering of nodes. This enables
non-sequential NUMA node number topoligies to be created.
Default assignments of CPU->nodeid (get_default_cpu_node_id) now return
a node
On Tue, Aug 06, 2019 at 09:29:45PM +1000, Daniel Black wrote:
> Replace all node_id assumptions with lookups from
> machinestate->numa_state->nodes[]
> and remove aspects that assume a sequential numbering of nodes. This enables
> non-sequential NUMA node number topoligies to be created.
>
> Defa
On Tue, 6 Aug 2019 at 12:12, Max Reitz wrote:
>
> On 06.08.19 12:12, Peter Maydell wrote:
> > On Mon, 5 Aug 2019 at 18:01, Max Reitz wrote:
> >>
> >> On 05.08.19 18:59, Vladimir Sementsov-Ogievskiy wrote:
> >>> 05.08.2019 19:37, Max Reitz wrote:
> The following changes since commit
> 9
'edid' is a property of the virtio-gpu base device, so turning
it off on virtio-gpu-pci is not enough (it misses -ccw). Turn
it off on the base device instead.
Fixes: 0a71966253c8 ("edid: flip the default to enabled")
Signed-off-by: Cornelia Huck
---
Only just noticed this... should we still sho
The following changes since commit 9bb68d34dda9be60335e73e65c8fb61bca035362:
Merge remote-tracking branch 'remotes/philmd-gitlab/tags/edk2-next-20190803'
into staging (2019-08-05 11:05:36 +0100)
are available in the Git repository at:
https://github.com/XanClic/qemu.git tags/pull-block-2019
Perform two guest writes to not yet backed up areas of an image, where
the former touches an inner area of the latter.
Before HEAD^, copy offloading broke this in two ways:
(1) The target image differs from the reference image (what the source
was when the backup started).
(2) But you will not
The backup job must only copy areas that the copy_bitmap reports as
dirty. This is always the case when using traditional non-offloading
backup, because it copies each cluster separately. When offloading the
copy operation, we sometimes copy more than one cluster at a time, but
we only check whet
From: Vladimir Sementsov-Ogievskiy
Without this, hbitmap_next_zero and hbitmap_next_dirty_area are broken
after truncate. So, orig_size is broken since it's introduction in
76d570dc495c56bb.
Fixes: 76d570dc495c56bb
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-id: 20190805120120.23585-1-v
From: Vladimir Sementsov-Ogievskiy
Enabled by default copy_range ignores compress option. It's definitely
unexpected for user.
It's broken since introduction of copy_range usage in backup in
9ded4a011496.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-id: 20190730163251.755248-3-vsement..
Signed-off-by: Max Reitz
Message-id: 20190805113526.20319-1-mre...@redhat.com
Reviewed-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Max Reitz
---
tests/qemu-iotests/151 | 25 +
tests/qemu-iotests/151.out | 4 ++--
2 files changed, 27 insertions(+), 2 deletions(-)
Signed-off-by: Max Reitz
Message-id: 20190805152840.32190-1-mre...@redhat.com
Signed-off-by: Max Reitz
---
tests/qemu-iotests/124 | 38 ++
tests/qemu-iotests/124.out | 4 ++--
2 files changed, 36 insertions(+), 6 deletions(-)
diff --git a/tests/qemu-iote
In write-blocking mode, all writes to the top node directly go to the
target. We must only mirror chunks of data that are aligned to the
job's granularity, because that is how the dirty bitmap works.
Therefore, the request alignment for writes must be the job's
granularity (in write-blocking mode)
On Fri, Aug 02, 2019 at 06:28:51PM -0700, Richard Henderson wrote:
> On 8/2/19 9:27 AM, Richard Henderson wrote:
> > On 8/2/19 5:25 AM, Andrew Jones wrote:
> >> Note, certainly more features may be added to the list of
> >> advertised features, e.g. 'vfp' and 'neon'. The only requirement
> >> is th
On Fri, Aug 02, 2019 at 11:07:54AM -0700, Richard Henderson wrote:
> On 8/2/19 5:25 AM, Andrew Jones wrote:
> > +/*
> > + * SVE registers are encoded in KVM's memory in an endianness-invariant
> > format.
> > + * The byte at offset i from the start of the in-memory representation
> > contains
> >
03.08.2019 0:19, Max Reitz wrote:
> On 02.08.19 20:58, Vladimir Sementsov-Ogievskiy wrote:
>> hbitmap_reset is broken: it rounds up the requested region. It leads to
>> the following bug, which is shown by fixed test:
>>
>> assume granularity = 2
>> set(0, 3) # count becomes 4
>> reset(0, 1) # coun
On Sat, Jul 13, 2019 at 06:58:56PM +0200, Philippe Mathieu-Daudé wrote:
> The qemu-nsis.bmp file was not listed with the other blobs, thus
> not installed in the ${BINDIR} location.
>
> This fixes:
>
> $ make installer
> [...]
> (cd /tmp/qemu-nsis; \
>for i in qemu-system-*.exe;
Hi all,
I've been going through the insn32.decode file, and found some
confusing inconsistencies with the ISA spec that I don't understand. I
hope some of you can clarify.
There is a field defined called "%sh10" as follows:
%sh1020:10
Which is used in the "@sh" format as follows:
@sh ..
On Mon, 5 Aug 2019 15:13:02 +0800
Tao Xu wrote:
> Add MachineClass::auto_enable_numa field. When it is true, a NUMA node
> is expected to be created implicitly.
>
> Acked-by: David Gibson
> Suggested-by: Igor Mammedov
> Suggested-by: Eduardo Habkost
> Signed-off-by: Tao Xu
> ---
>
> This p
On 8/5/19 7:54 AM, Jan Kiszka wrote:
> From: Jan Kiszka
>
> So far, the server leaves the posix shared memory object behind when
> terminating, requiring the user to explicitly remove it in order to
> start a new instance.
>
> Signed-off-by: Jan Kiszka
> ---
>
> Changes in v2:
> - respect use
On 06/08/19 11:41, Daniel P. Berrangé wrote:
> On Tue, Aug 06, 2019 at 09:11:15AM +0200, Paolo Bonzini wrote:
>> qcrypto_random_*, AES and qcrypto_init do not need to be linked as a whole
>> and are the only parts that are used by user-mode emulation. Place them
>> in libqemuutil, so that whatever
On Fri, 26 Jul 2019 11:45:16 +0100
Shameer Kolothum wrote:
> This initializes the GED device with base memory and irq, configures
> ged memory hotplug event and builds the corresponding aml code. With
> this, both hot and cold plug of device memory is enabled now for Guest
> with ACPI boot.
>
>
On 8/6/19 5:51 AM, Kevin Wolf wrote:
> Am 06.08.2019 um 00:19 hat John Snow geschrieben:
>>
>>
>> On 8/2/19 10:07 AM, Kevin Wolf wrote:
>>> Am 01.08.2019 um 19:57 hat Max Reitz geschrieben:
On 01.08.19 17:17, Kevin Wolf wrote:
> The part of iotests.main() that is related to the implemen
On Tue, Aug 06, 2019 at 03:07:40PM +0200, Paolo Bonzini wrote:
> On 06/08/19 11:41, Daniel P. Berrangé wrote:
> > On Tue, Aug 06, 2019 at 09:11:15AM +0200, Paolo Bonzini wrote:
> >> qcrypto_random_*, AES and qcrypto_init do not need to be linked as a whole
> >> and are the only parts that are used
On Fri, 26 Jul 2019 11:45:17 +0100
Shameer Kolothum wrote:
> Generate Memory Affinity Structures for PC-DIMM ranges.
>
> Signed-off-by: Shameer Kolothum
> Signed-off-by: Eric Auger
> Reviewed-by: Igor Mammedov
> ---
> hw/arm/virt-acpi-build.c | 9 +
> 1 file changed, 9 insertions(+)
On 8/2/19 7:11 AM, Gerd Hoffmann wrote:
On Wed, Jul 31, 2019 at 01:08:50PM +0200, Philippe Mathieu-Daudé wrote:
On 7/30/19 7:45 PM, Guenter Roeck wrote:
The following assert is seen once in a while while resetting the
Linux kernel.
qemu-system-x86_64: hw/usb/core.c:734: usb_ep_get:
Ass
On Tue, 6 Aug 2019 at 13:44, Daniel P. Berrangé wrote:
>
> On Sat, Jul 13, 2019 at 06:58:56PM +0200, Philippe Mathieu-Daudé wrote:
> > The qemu-nsis.bmp file was not listed with the other blobs, thus
> > not installed in the ${BINDIR} location.
> >
> > This fixes:
> >
> > $ make installer
> >
On Fri, Aug 02, 2019 at 11:53:52AM +0100, Dr. David Alan Gilbert wrote:
> * piaojun (piao...@huawei.com) wrote:
> > Use F_GETLK for fcntl when F_OFD_GETLK not defined, such as kernel 3.10.
> >
> > Signed-off-by: Jun Piao
>
>
> > ---
> > v2:
> > - Use F_OFD_SETLK to replace F_OFD_GETLK in #ifdef
Hey,
On 8/2/19 1:07 PM, Kevin Wolf wrote:
Am 28.06.2019 um 21:45 hat Daniel Henrique Barboza geschrieben:
Adding to Block Drivers the capability of being able to clean up
its created files can be useful in certain situations. For the
LUKS driver, for instance, a failure in one of its authentica
On Tue, Aug 06, 2019 at 02:25:27PM +0100, Peter Maydell wrote:
> On Tue, 6 Aug 2019 at 13:44, Daniel P. Berrangé wrote:
> >
> > On Sat, Jul 13, 2019 at 06:58:56PM +0200, Philippe Mathieu-Daudé wrote:
> > > The qemu-nsis.bmp file was not listed with the other blobs, thus
> > > not installed in the
On 8/6/19 8:39 AM, Vladimir Sementsov-Ogievskiy wrote:
> 03.08.2019 0:19, Max Reitz wrote:
>> On 02.08.19 20:58, Vladimir Sementsov-Ogievskiy wrote:
>>> hbitmap_reset is broken: it rounds up the requested region. It leads to
>>> the following bug, which is shown by fixed test:
>>>
>>> assume gra
On Fri, 26 Jul 2019 11:45:19 +0100
Shameer Kolothum wrote:
> For machines 4.2 or higher with ACPI boot use GED for system_powerdown
> event instead of GPIO. Guest boot with DT still uses GPIO.
one more thing,
though GED is sort of described in ACPI spec, MMIO event mapping
is a totally QEMU inve
On Tue, Aug 06, 2019 at 01:58:19PM +0200, Cornelia Huck wrote:
> 'edid' is a property of the virtio-gpu base device, so turning
> it off on virtio-gpu-pci is not enough (it misses -ccw). Turn
> it off on the base device instead.
>
> Fixes: 0a71966253c8 ("edid: flip the default to enabled")
> Signe
On Tue, 6 Aug 2019 at 14:40, Gerd Hoffmann wrote:
>
> On Tue, Aug 06, 2019 at 01:58:19PM +0200, Cornelia Huck wrote:
> > 'edid' is a property of the virtio-gpu base device, so turning
> > it off on virtio-gpu-pci is not enough (it misses -ccw). Turn
> > it off on the base device instead.
> >
> > F
06.08.2019 16:30, John Snow wrote:
>
>
> On 8/6/19 8:39 AM, Vladimir Sementsov-Ogievskiy wrote:
>> 03.08.2019 0:19, Max Reitz wrote:
>>> On 02.08.19 20:58, Vladimir Sementsov-Ogievskiy wrote:
hbitmap_reset is broken: it rounds up the requested region. It leads to
the following bug, whic
On Tue, 30 Jul 2019 at 06:45, Rashmica Gupta wrote:
>
> GPIO pins are arranged in groups of 8 pins labeled A,B,..,Y,Z,AA,AB,AC.
> (Note that the ast2400 controller only goes up to group AB).
> A set has four groups (except set AC which only has one) and is
> referred to by the groups it is compose
On Tue, 30 Jul 2019 at 06:45, Rashmica Gupta wrote:
>
> There are a couple of things I'm not confident about here:
> - what should be in init vs realize?
We are not very good at documenting this distinction (and there's
some bits of it I'm not sure about either), but:
* init cannot contain anyth
On Mon, 29 Jul 2019 at 22:47, Paolo Bonzini wrote:
>
> The race is as follows:
>
> vCPU thread reader thread
> --- ---
> TLB check -> slow path
> notdirty_mem_write
> write to RAM
> set dirt
On Tue, 6 Aug 2019 at 12:59, Max Reitz wrote:
>
> The following changes since commit 9bb68d34dda9be60335e73e65c8fb61bca035362:
>
> Merge remote-tracking branch
> 'remotes/philmd-gitlab/tags/edk2-next-20190803' into staging (2019-08-05
> 11:05:36 +0100)
>
> are available in the Git repository a
* Wei Yang (richardw.y...@linux.intel.com) wrote:
> The purpose of the calculation is to find a HostPage which is partially
> dirty.
>
> * fixup_start_addr points to the start of the HostPage to discard
> * run_start points to the next HostPage to check
>
> While in the middle stage, there wo
On 8/6/19 3:00 AM, Peter Maydell wrote:
> Renaming pc_next would be a cross-target change, so let's put that
> on the shelf for the moment. Maybe just put a TODO comment to the
> effect that we could consider renaming in future ?
I wasn't suggesting renaming the cross-target variable.
I was sugge
In my "build everything" tree, changing a type in qapi/common.json
triggers a recompile of some 3600 out of 6600 objects (not counting
tests and objects that don't depend on qemu/osdep.h).
One common dependency is QapiErrorClass: it's used only in in
qapi/error.h, which uses nothing else, and is w
TYPE_IOMMU_MEMORY_REGION is a direct subtype of TYPE_MEMORY_REGION.
Its instance struct is IOMMUMemoryRegion, and its first member is a
MemoryRegion. Correct. Its class struct is IOMMUMemoryRegionClass,
and its first member is a DeviceClass. Wrong. Messed up when commit
1221a474676 introduced t
While there, drop the obsolete file comment.
Signed-off-by: Markus Armbruster
---
include/qemu/typedefs.h | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h
index fcdaae58c4..29346648d4 100644
--- a/include/qemu/type
When commit 5f7d05ecfda added QLIST_INSERT_HEAD_RCU() to qemu/queue.h,
it had to include qemu/atomic.h. Commit 341774fe6cc removed
QLIST_INSERT_HEAD_RCU() again, but neglected to remove the #include.
Do that now.
Signed-off-by: Markus Armbruster
Reviewed-by: Thomas Huth
---
include/qemu/queue.
In my "build everything" tree, changing migration/qemu-file-types.h
triggers a recompile of some 2600 out of 6600 objects (not counting
tests and objects that don't depend on qemu/osdep.h).
The culprit is again hw/hw.h, which supposedly includes it for
convenience.
Include migration/qemu-file-typ
Some of the generated qapi-types-MODULE.h are included all over the
place. Changing a QAPI type can trigger massive recompiling. Top
scorers recompile more than 1000 out of some 6600 objects (not
counting tests and objects that don't depend on qemu/osdep.h):
6300 qapi/qapi-builtin-types.h
We declare incomplete struct VMStateDescription in a couple of places
so we don't have to include migration/vmstate.h for the typedef.
That's fine with me. However, the next commit will drop
migration/vmstate.h from a massive number of compiles. Move the
typedef to qemu/typedefs.h now, so I don't
According to hw/ide/internal's file comment, only files in hw/ide/ are
supposed to include it. Drag reality slightly closer to supposition.
Three includes outside hw/ide remain: hw/arm/sbsa-ref.c,
include/hw/ide/pci.h, and include/hw/misc/macio/macio.h. Turns out
board code needs ide-internal.h
docs/devel/tracing.txt explains "since many source files include
trace.h, [the generated trace.h use] a minimum of types and other
header files included to keep the namespace clean and compile times
and dependencies down."
Commit 4815185902 "trace: Add per-vCPU tracing states for events with
the '
migration/qemu-file.h neglects to include it even though it needs
ram_addr_t. Fix that. Drop a few superfluous inclusions elsewhere.
Signed-off-by: Markus Armbruster
---
accel/stubs/tcg-stub.c | 1 -
balloon.c | 1 -
hw/smbios/smbios.c | 1 -
include
Back in 2016, we discussed[1] rules for headers, and these were
generally liked:
1. Have a carefully curated header that's included everywhere first. We
got that already thanks to Peter: osdep.h.
2. Headers should normally include everything they need beyond osdep.h.
If exceptions are need
hw/hw.h used to include headers hardware emulation "usually" needs.
The previous commits removed all but one of them, to good effect.
Only qom/object.h is left. Remove that one, too.
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
---
include/hw/display/edid.h | 2 +-
incl
Commit e35704ba9c "numa: Move NUMA declarations from sysemu.h to
numa.h" left a few NUMA-related macros behind. Move them now.
Cc: Eduardo Habkost
Cc: Marcel Apfelbaum
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Eduardo Habkost
---
exec.c
sysemu/numa.h includes hw/boards.h just for the CPUArchId typedef, at
the cost of pulling in more than two dozen extra headers indirectly.
I could move the typedef from hw/boards.h to qemu/typedefs.h. But
it's used in just two headers: boards.h and numa.h.
I could move it to another header both
In my "build everything" tree, changing sysemu/sysemu.h triggers a
recompile of some 1800 out of 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h, down from 5400 due to the
previous commit).
Several headers include sysemu/sysemu.h just to get typedef
VMChangeStateEntr
hw/tpm/trace-events uses TARGET_FMT_plx formats with uint64_t
arguments. That's wrong, TARGET_FMT_plx takes hwaddr. Since hwaddr
happens to be uint64_t, it works anyway. Messed up in commit
ec427498da5, v2.12.0. Clean up by replacing TARGET_FMT_plx with its
macro expansion.
scripts/tracetool/f
We have quite a few "touch this, recompile the world" headers. My
"build everything" tree has some 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h). Touching any of 54
headers triggers a recompile of more than half of them.
This series reduces them to 46.
Six of t
Drop unnecessary inclusions from headers. Downgrade a few more to
exec/hwaddr.h.
Signed-off-by: Markus Armbruster
---
hw/audio/lm4549.h | 1 +
hw/display/edid-region.c| 1 +
hw/display/tc6393xb.c | 1 +
hw/net/can/can_sja1000.h| 1 +
hw/ne
Signed-off-by: Markus Armbruster
---
hw/scsi/vhost-scsi.c| 1 -
hw/vfio/ap.c| 1 -
include/exec/cpu-defs.h | 1 -
include/hw/xen/xen_common.h | 1 -
include/net/can_emu.h | 1 +
include/net/filter.h| 1 +
include/qemu/range.h| 2 --
include/qom/ob
sysemu/sysemu.h is a rather unfocused dumping ground for stuff related
to the system-emulator. Evidence:
* It's included widely: in my "build everything" tree, changing
sysemu/sysemu.h still triggers a recompile of some 1100 out of 6600
objects (not counting tests and objects that don't depen
In my "build everything" tree, changing sysemu/sysemu.h triggers a
recompile of some 5400 out of 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h).
hw/qdev-core.h includes sysemu/sysemu.h since recent commit e965ffa70a
"qdev: add qdev_add_vm_change_state_handler()".
Move the HostMemoryBackend typedef from sysemu/hostmem.h to
qemu/typedefs.h. This renders a few inclusions of sysemu/hostmem.h
superfluous; drop them.
Cc: Eduardo Habkost
Cc: Igor Mammedov
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Eduardo Habkost
Revie
hw/boards.h pulls in almost 60 headers. The less we include it into
headers, the better. As a first step, drop superfluous inclusions,
and downgrade some more to what's actually needed. Gets rid of just
one inclusion into a header.
Cc: Eduardo Habkost
Cc: Marcel Apfelbaum
Signed-off-by: Marku
In my "build everything" tree, changing hw/hw.h triggers a recompile
of some 2600 out of 6600 objects (not counting tests and objects that
don't depend on qemu/osdep.h).
The previous commits have left only the declaration of hw_error() in
hw/hw.h. This permits dropping most of its inclusions. To
1 - 100 of 196 matches
Mail list logo
