Re: [Qemu-devel] [RFC v1 06/18] intel_iommu: support virtual command emulation and pasid request

2019-07-11 Thread Liu, Yi L
> From: Peter Xu [mailto:zh...@redhat.com] > Sent: Thursday, July 11, 2019 9:13 AM > To: Liu, Yi L > Subject: Re: [RFC v1 06/18] intel_iommu: support virtual command emulation and > pasid request > > On Wed, Jul 10, 2019 at 11:51:17AM +, Liu, Yi L wrote: > > [...] > > > > > +s->vcrs

Re: [Qemu-devel] [RFC v1 03/18] hw/pci: introduce PCIPASIDOps to PCIDevice

2019-07-11 Thread Liu, Yi L
> From: da...@gibson.dropbear.id.au [mailto:da...@gibson.dropbear.id.au] > Sent: Thursday, July 11, 2019 11:52 AM > To: Liu, Yi L > Subject: Re: [RFC v1 03/18] hw/pci: introduce PCIPASIDOps to PCIDevice > > On Wed, Jul 10, 2019 at 11:08:15AM +, Liu, Yi L wrote: > > > From: Peter Xu [mailto:zh

Re: [Qemu-devel] [PATCH] virtio-balloon: fix QEMU 4.0 config size migration incompatibility

2019-07-11 Thread Wolfgang Bumiller
On Wed, Jul 10, 2019 at 04:14:40PM +0200, Stefan Hajnoczi wrote: > The virtio-balloon config size changed in QEMU 4.0 even for existing > machine types. Migration from QEMU 3.1 to 4.0 can fail in some > circumstances with the following error: > > qemu-system-x86_64: get_pci_config_device: Bad c

Re: [Qemu-devel] [RFC v1 10/18] intel_iommu: tag VTDAddressSpace instance with PASID

2019-07-11 Thread Liu, Yi L
> From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On Behalf > Of Peter Xu > Sent: Tuesday, July 9, 2019 2:13 PM > To: Liu, Yi L > Subject: Re: [RFC v1 10/18] intel_iommu: tag VTDAddressSpace instance with > PASID > > On Fri, Jul 05, 2019 at 07:01:43PM +0800, Liu Yi L wrote: >

Re: [Qemu-devel] Problems building and installing qemu v4.1.0-rc1 in single step

2019-07-11 Thread Philippe Mathieu-Daudé
Hi Guenter, Cc'ing Markus/Dan/Alex On 7/11/19 3:07 AM, Guenter Roeck wrote: > On Wed, Jul 10, 2019 at 03:01:53PM -0700, Guenter Roeck wrote: >> Hi, >> >> when trying to run "make -j30 install" from a clean tree on v4.1.0-rc0, I get >> _lots_ of undefined symbol errors. >> >> If I run "make -j30"

Re: [Qemu-devel] [PATCH v2] linux-user: fix to handle variably sized SIOCGSTAMP with new kernels

2019-07-11 Thread Christian Ehrhardt
On Mon, Jun 17, 2019 at 5:35 PM Laurent Vivier wrote: > > Le 17/06/2019 à 15:11, Daniel P. Berrangé a écrit : > > The SIOCGSTAMP symbol was previously defined in the > > asm-generic/sockios.h header file. QEMU sees that header > > indirectly via sys/socket.h > > > > In linux kernel commit 0768e170

Re: [Qemu-devel] [PATCH 0/4] virtio: handle zoned backing devices

2019-07-11 Thread Paolo Bonzini
On 11/07/19 02:52, Dmitry Fomichev wrote: > Paolo, > WRT to Host Aware drives, these MAY work, but we don't have any of these > available for testing and are not able to verify which drivers do work > with them and which do not. This is the reason for not letting them pass > thru. If you prefer, I

[Qemu-devel] [PATCH] migration/postcopy: PostcopyState is already set in loadvm_postcopy_handle_advise()

2019-07-11 Thread Wei Yang
PostcopyState is already set to ADVISE at the beginning of loadvm_postcopy_handle_advise(). Remove the redundant set. Signed-off-by: Wei Yang --- migration/savevm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/migration/savevm.c b/migration/savevm.c index 8a2ada529e..2350e219fc 100644 -

Re: [Qemu-devel] [RFC v1 11/18] intel_iommu: create VTDAddressSpace per BDF+PASID

2019-07-11 Thread Liu, Yi L
> From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On Behalf > Of Peter Xu > Sent: Tuesday, July 9, 2019 2:39 PM > To: Liu, Yi L > Subject: Re: [RFC v1 11/18] intel_iommu: create VTDAddressSpace per BDF+PASID > > On Fri, Jul 05, 2019 at 07:01:44PM +0800, Liu Yi L wrote: > > [..

Re: [Qemu-devel] [PATCH] virtio-balloon: fix QEMU 4.0 config size migration incompatibility

2019-07-11 Thread Dr. David Alan Gilbert
* Wolfgang Bumiller (w.bumil...@proxmox.com) wrote: > On Wed, Jul 10, 2019 at 04:14:40PM +0200, Stefan Hajnoczi wrote: > > The virtio-balloon config size changed in QEMU 4.0 even for existing > > machine types. Migration from QEMU 3.1 to 4.0 can fail in some > > circumstances with the following er

Re: [Qemu-devel] [PATCH] LUKS: support preallocation in qemu-img

2019-07-11 Thread Maxim Levitsky
On Wed, 2019-07-10 at 23:52 +0200, Max Reitz wrote: > On 10.07.19 23:24, Max Reitz wrote: > > On 10.07.19 19:03, Maxim Levitsky wrote: > > > preallocation=off and preallocation=metadata > > > both allocate luks header only, and preallocation=falloc/full > > > is passed to underlying file, with the

Re: [Qemu-devel] [PATCH 02/11] audio: basic support for multi backend audio

2019-07-11 Thread Dr. David Alan Gilbert
* Zoltán Kővágó (dirty.ice...@gmail.com) wrote: > On 2019-07-10 06:06, Markus Armbruster wrote: > > "Kővágó, Zoltán" writes: > > > >> Audio functions no longer access glob_audio_state, instead they get an > >> AudioState as a parameter. This is required in order to support > >> multiple backends

Re: [Qemu-devel] RFC: Why does target/m68k RTE insn. use gen_exception

2019-07-11 Thread Peter Maydell
On Wed, 10 Jul 2019 at 19:15, Alex Bennée wrote: > Lucien Murray-Pitts writes: > > I am very new to TCG, so it does seem there is a lot of code in the > > translator_loop that appears to be interacting with the CPU model/state. > > Should I be worried about this, or is this a safe function to cal

[Qemu-devel] [Bug 1836136] Re: u-boot: any plans to update u-boot to v2019.07

2019-07-11 Thread Peter Maydell
Are there any notable bugfixes or new features that this would get us for the two platforms where we ship a u-boot binary ? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1836136 Title: u-boot: any

[Qemu-devel] [PATCH v2] LUKS: support preallocation in qemu-img

2019-07-11 Thread Maxim Levitsky
preallocation=off and preallocation=metadata both allocate luks header only, and preallocation=falloc/full is passed to underlying file. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1534951 Signed-off-by: Maxim Levitsky --- block/crypto.c | 25 ++--- 1 file changed, 22

Re: [Qemu-devel] [PATCH V2] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-11 Thread Jason Wang
On 2019/7/10 下午3:50, Zhang, Chen wrote: -Original Message- From: Jason Wang [mailto:jasow...@redhat.com] Sent: Tuesday, July 9, 2019 10:48 PM To: Zhang, Chen ; Li Zhijian ; Peter Maydell ; qemu-dev Cc: Zhang Chen Subject: Re: [Qemu-devel] [PATCH V2] net/colo-compare.c: Fix memory le

Re: [Qemu-devel] RFC: Why does target/m68k RTE insn. use gen_exception

2019-07-11 Thread Richard Henderson
On 7/10/19 7:50 PM, Lucien Murray-Pitts wrote: > > >> On Wed, Jul 10, 2019 at 4:04 AM Richard Henderson > mailto:richard.hender...@linaro.org>> wrote: > > > I did have a suggestion.  It was fairly detailed. > > https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg06522.html > > Your

Re: [Qemu-devel] [PATCH] LUKS: support preallocation in qemu-img

2019-07-11 Thread Daniel P . Berrangé
On Wed, Jul 10, 2019 at 11:24:46PM +0200, Max Reitz wrote: > On 10.07.19 19:03, Maxim Levitsky wrote: > > preallocation=off and preallocation=metadata > > both allocate luks header only, and preallocation=falloc/full > > is passed to underlying file, with the given image size. > > > > Note that th

Re: [Qemu-devel] [PATCH v2] linux-user: fix to handle variably sized SIOCGSTAMP with new kernels

2019-07-11 Thread Daniel P . Berrangé
On Thu, Jul 11, 2019 at 10:02:01AM +0200, Christian Ehrhardt wrote: > On Mon, Jun 17, 2019 at 5:35 PM Laurent Vivier wrote: > > > > Le 17/06/2019 à 15:11, Daniel P. Berrangé a écrit : > > > The SIOCGSTAMP symbol was previously defined in the > > > asm-generic/sockios.h header file. QEMU sees that

Re: [Qemu-devel] [PATCH RFC] gpio: Add Virtual Aggregator GPIO Driver

2019-07-11 Thread Phil Reid
On 10/07/2019 18:21, Geert Uytterhoeven wrote: Hi Phil, On Wed, Jul 10, 2019 at 4:00 AM Phil Reid wrote: On 6/07/2019 00:05, Geert Uytterhoeven wrote: GPIO controllers are exported to userspace using /dev/gpiochip* character devices. Access control to these devices is provided by standard UN

Re: [Qemu-devel] [RISU RFC PATCH v2 04/14] risugen_x86: add module

2019-07-11 Thread Richard Henderson
On 7/10/19 8:21 PM, Jan Bobek wrote: > Doesn't B8 (without REX.W) work for x86_64, too? It zeroes the upper > part of the destination, so it's effectively zero-extending, and it's > one byte shorter than C7 (no ModR/M byte needed). Sorry, I shouldn't have been quite so terse. What I meant is i

Re: [Qemu-devel] [RISU RFC PATCH v2 06/14] x86.risu: add MMX instructions

2019-07-11 Thread Richard Henderson
On 7/10/19 8:29 PM, Jan Bobek wrote: >>> +# Arithmetic Instructions >>> +PADDB MMX 1100 !emit { modrm(); mem(size => 8); >>> } >>> +PADDW MMX 1101 !emit { modrm(); mem(size => 8); >>> } >>> +PADDD MMX 1110 !emit { mo

Re: [Qemu-devel] [RISU RFC PATCH v2 06/14] x86.risu: add MMX instructions

2019-07-11 Thread Richard Henderson
On 7/10/19 8:32 PM, Jan Bobek wrote: > On 7/3/19 5:49 PM, Richard Henderson wrote: >> On 7/1/19 6:35 AM, Jan Bobek wrote: >>> +MOVQMMX 011 d 1110 !emit { rex(w => 1); modrm(mod >>> => MOD_DIRECT, rm => ~REG_ESP); } >>> +MOVQ_memMMX 011 d 1110 !emit { r

Re: [Qemu-devel] [PATCH] migration/postcopy: fix document of postcopy_send_discard_bm_ram()

2019-07-11 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > Commit 6b6712efccd3 ('ram: Split dirty bitmap by RAMBlock') changes the > parameter of postcopy_send_discard_bm_ram(), while left the document > part untouched. > > This patch correct the document and fix one typo by hand. > > Signed-off-by: Wei

Re: [Qemu-devel] [RISU RFC PATCH v2 06/14] x86.risu: add MMX instructions

2019-07-11 Thread Alex Bennée
Richard Henderson writes: > On 7/10/19 8:32 PM, Jan Bobek wrote: >> On 7/3/19 5:49 PM, Richard Henderson wrote: >>> On 7/1/19 6:35 AM, Jan Bobek wrote: +MOVQMMX 011 d 1110 !emit { rex(w => 1); modrm(mod => MOD_DIRECT, rm => ~REG_ESP); } +MOVQ_mem

Re: [Qemu-devel] [PATCH for 4.1] target/arm: report ARMv8.2 FP16 for ARM -cpu max

2019-07-11 Thread Richard Henderson
On 7/10/19 7:24 PM, Alex Bennée wrote: > When we converted to using feature bits in 602f6e42cfbf we missed out > the fact (dp && arm_dc_feature(s, ARM_FEATURE_V8)) was supported for > -cpu max configurations. This caused a regression in the GCC test > suite. Fix this by setting the appropriate FP16

Re: [Qemu-devel] [PATCH RFC] gpio: Add Virtual Aggregator GPIO Driver

2019-07-11 Thread Geert Uytterhoeven
Hi Phil, On Thu, Jul 11, 2019 at 11:24 AM Phil Reid wrote: > On 10/07/2019 18:21, Geert Uytterhoeven wrote: > > On Wed, Jul 10, 2019 at 4:00 AM Phil Reid wrote: > >> On 6/07/2019 00:05, Geert Uytterhoeven wrote: > >>> GPIO controllers are exported to userspace using /dev/gpiochip* > >>> characte

Re: [Qemu-devel] [PATCH v2 00/13] Add SEV guest live migration support

2019-07-11 Thread Dr. David Alan Gilbert
* Singh, Brijesh (brijesh.si...@amd.com) wrote: > AMD SEV encrypts the memory of VMs and because this encryption is done using > an address tweak, the hypervisor will not be able to simply copy ciphertext > between machines to migrate a VM. Instead the AMD SEV Key Management API > provides a set of

[Qemu-devel] migrate_set_speed has no effect if the guest is using hugepages.

2019-07-11 Thread Lin Ma
Hi all, When I live migrate a qemu/kvm guest, If the guest is using huge pages, I found that the migrate_set_speed command had no effect during stage 2. It was caused by commit 4c011c3 postcopy: Send whole huge pages I'm wondering that is it by design or is it a bug waiting for fix? Thanks, Li

Re: [Qemu-devel] [PATCH v2] linux-user: fix to handle variably sized SIOCGSTAMP with new kernels

2019-07-11 Thread Christian Borntraeger
On 11.07.19 11:24, Daniel P. Berrangé wrote: > On Thu, Jul 11, 2019 at 10:02:01AM +0200, Christian Ehrhardt wrote: >> On Mon, Jun 17, 2019 at 5:35 PM Laurent Vivier wrote: >>> >>> Le 17/06/2019 à 15:11, Daniel P. Berrangé a écrit : The SIOCGSTAMP symbol was previously defined in the a

Re: [Qemu-devel] migrate_set_speed has no effect if the guest is using hugepages.

2019-07-11 Thread Dr. David Alan Gilbert
* Lin Ma (l...@suse.com) wrote: > Hi all, Hi Lin, > When I live migrate a qemu/kvm guest, If the guest is using huge pages, I > found that > the migrate_set_speed command had no effect during stage 2. Can you explain what you mean by 'stage 2'? > It was caused by commit 4c011c3 postcopy: Send

[Qemu-devel] [PATCH-for-4.1] tests/docker: Install Sphinx in the Fedora image

2019-07-11 Thread Philippe Mathieu-Daudé
Since commit 5f71eac06e the Sphinx tool is required to build the rST documentation. This fixes: $ ./configure --enable-docs ERROR: User requested feature docs configure was not able to find it. Install texinfo, Perl/perl-podlators and python-sphinx Signed-off-by: Philippe Math

Re: [Qemu-devel] [PATCH for 4.1] target/arm: report ARMv8.2 FP16 for ARM -cpu max

2019-07-11 Thread Alex Bennée
Richard Henderson writes: > On 7/10/19 7:24 PM, Alex Bennée wrote: >> When we converted to using feature bits in 602f6e42cfbf we missed out >> the fact (dp && arm_dc_feature(s, ARM_FEATURE_V8)) was supported for >> -cpu max configurations. This caused a regression in the GCC test >> suite. Fix

[Qemu-devel] [PATCH v2 for 4.1] target/arm: report ARMv8-A FP support for AArch32 -cpu max

2019-07-11 Thread Alex Bennée
When we converted to using feature bits in 602f6e42cfbf we missed out the fact (dp && arm_dc_feature(s, ARM_FEATURE_V8)) was supported for -cpu max configurations. This caused a regression in the GCC test suite. Fix this by setting the appropriate bits in mvfr1.FPHP to report ARMv8-A with FP suppor

Re: [Qemu-devel] [PATCH v2] linux-user: fix to handle variably sized SIOCGSTAMP with new kernels

2019-07-11 Thread Laurent Vivier
Le 11/07/2019 à 11:24, Daniel P. Berrangé a écrit : > On Thu, Jul 11, 2019 at 10:02:01AM +0200, Christian Ehrhardt wrote: >> On Mon, Jun 17, 2019 at 5:35 PM Laurent Vivier wrote: >>> >>> Le 17/06/2019 à 15:11, Daniel P. Berrangé a écrit : The SIOCGSTAMP symbol was previously defined in the >>

[Qemu-devel] [PULL 07/19] migration/multifd: sync packet_num after all thread are done

2019-07-11 Thread Juan Quintela
From: Wei Yang Notification from recv thread is not ordered, which means we may be notified by one MultiFDRecvParams but adjust packet_num for another. Move the adjustment after we are sure each recv thread are sync-ed. Signed-off-by: Wei Yang Reviewed-by: Juan Quintela Reviewed-by: Peter Xu

[Qemu-devel] [PULL 01/19] migration: fix multifd_recv event typo

2019-07-11 Thread Juan Quintela
It uses num in multifd_send(). Make it coherent. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Wei Yang Signed-off-by: Juan Quintela --- migration/trace-events | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/trace-events b/migrati

Re: [Qemu-devel] [PATCH v7 00/13] Add migration support for VFIO device

2019-07-11 Thread Dr. David Alan Gilbert
* Yan Zhao (yan.y.z...@intel.com) wrote: > Hi Kirti, > There are still unaddressed comments to your patches v4. > Would you mind addressing them? > > 1. should we register two migration interfaces simultaneously > (https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg04750.html) Please don't

[Qemu-devel] [PULL 08/19] migratioin/ram.c: reset complete_round when we gets a queued page

2019-07-11 Thread Juan Quintela
From: Wei Yang In case we gets a queued page, the order of block is interrupted. We may not rely on the complete_round flag to say we have already searched the whole blocks on the list. Signed-off-by: Wei Yang Reviewed-by: Juan Quintela Message-Id: <20190605010828.6969-1-richardw.y...@linux.in

[Qemu-devel] [PULL 06/19] cutils: remove one unnecessary pointer operation

2019-07-11 Thread Juan Quintela
From: Wei Yang Since we will not operate on the next address pointed by out, it is not necessary to do addition on it. After removing the operation, the function size reduced 16/18 bytes. Signed-off-by: Wei Yang Reviewed-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Message-Id: <201

[Qemu-devel] [PULL 10/19] memory: Don't set migration bitmap when without migration

2019-07-11 Thread Juan Quintela
From: Peter Xu Similar to 9460dee4b2 ("memory: do not touch code dirty bitmap unless TCG is enabled", 2015-06-05) but for the migration bitmap - we can skip the MIGRATION bitmap update if migration not enabled. Reviewed-by: Paolo Bonzini Reviewed-by: Juan Quintela Signed-off-by: Peter Xu Mess

[Qemu-devel] [PULL 09/19] migration: No need to take rcu during sync_dirty_bitmap

2019-07-11 Thread Juan Quintela
From: Peter Xu cpu_physical_memory_sync_dirty_bitmap() has one RAMBlock* as parameter, which means that it must be with RCU read lock held already. Taking it again inside seems redundant. Removing it. Instead comment on the functions about the RCU read lock. Reviewed-by: Paolo Bonzini Reviewe

[Qemu-devel] [PULL 13/19] memory: Introduce memory listener hook log_clear()

2019-07-11 Thread Juan Quintela
From: Peter Xu Introduce a new memory region listener hook log_clear() to allow the listeners to hook onto the points where the dirty bitmap is cleared by the bitmap users. Previously log_sync() contains two operations: - dirty bitmap collection, and, - dirty bitmap clear on remote site. L

[Qemu-devel] [PULL 02/19] migration-test: rename parameter to parameter_int

2019-07-11 Thread Juan Quintela
We would need _str ones on the next patch. Signed-off-by: Juan Quintela Reviewed-by: Wei Yang Signed-off-by: Juan Quintela --- tests/migration-test.c | 55 +- 1 file changed, 28 insertions(+), 27 deletions(-) diff --git a/tests/migration-test.c b/tests/

[Qemu-devel] [PULL 00/19] Migration patches

2019-07-11 Thread Juan Quintela
The following changes since commit 6df2cdf44a82426f7a59dcb03f0dd2181ed7fdfa: Update version for v4.1.0-rc0 release (2019-07-09 17:21:53 +0100) are available in the Git repository at: https://github.com/juanquintela/qemu.git tags/migration-pull-request for you to fetch changes up to 0b47e79b

[Qemu-devel] [PULL 12/19] memory: Pass mr into snapshot_and_clear_dirty

2019-07-11 Thread Juan Quintela
From: Peter Xu Also we change the 2nd parameter of it to be the relative offset within the memory region. This is to be used in follow up patches. Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Message-Id: <20190603065056.25211-6-pet...@redhat.com> Signed-off-by: Juan Quintela --- exec.c

[Qemu-devel] [PULL 05/19] migration/xbzrle: update cache and current_data in one place

2019-07-11 Thread Juan Quintela
From: Wei Yang When we are not in the last_stage, we need to update the cache if page is not the same. Currently this procedure is scattered in two places and mixed with encoding status check. This patch extract this general step out to make the code a little bit easy to read. Signed-off-by: W

[Qemu-devel] [PULL 14/19] kvm: Update comments for sync_dirty_bitmap

2019-07-11 Thread Juan Quintela
From: Peter Xu It's obviously obsolete. Do some update. Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Message-Id: <20190603065056.25211-8-pet...@redhat.com> Signed-off-by: Juan Quintela --- accel/kvm/kvm-all.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --g

[Qemu-devel] [PULL 04/19] migration/multifd: call multifd_send_sync_main when sending RAM_SAVE_FLAG_EOS

2019-07-11 Thread Juan Quintela
From: Wei Yang On receiving RAM_SAVE_FLAG_EOS, multifd_recv_sync_main() is called to synchronize receive threads. Current synchronization mechanism is to wait for each channel's sem_sync semaphore. This semaphore is triggered by a packet with MULTIFD_FLAG_SYNC flag. While in current implementatio

[Qemu-devel] [PULL 11/19] bitmap: Add bitmap_copy_with_{src|dst}_offset()

2019-07-11 Thread Juan Quintela
From: Peter Xu These helpers copy the source bitmap to destination bitmap with a shift either on the src or dst bitmap. Meanwhile, we never have bitmap tests but we should. This patch also introduces the initial test cases for utils/bitmap.c but it only tests the newly introduced functions. Si

[Qemu-devel] [PULL 03/19] migration-test: Add migration multifd test

2019-07-11 Thread Juan Quintela
We set multifd-channels. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Thomas Huth Tested-by: Wei Yang Signed-off-by: Juan Quintela --- tests/migration-test.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/tests

[Qemu-devel] [PULL 19/19] migration: allow private destination ram with x-ignore-shared

2019-07-11 Thread Juan Quintela
From: Peng Tao By removing the share ram check, qemu is able to migrate to private destination ram when x-ignore-shared capability is on. Then we can create multiple destination VMs based on the same source VM. This changes the x-ignore-shared migration capability to work similar to Lai's origin

[Qemu-devel] [PULL 17/19] kvm: Support KVM_CLEAR_DIRTY_LOG

2019-07-11 Thread Juan Quintela
From: Peter Xu Firstly detect the interface using KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2 and mark it. When failed to enable the new feature we'll fall back to the old sync. Provide the log_clear() hook for the memory listeners for both address spaces of KVM (normal system memory, and SMM) and deliev

[Qemu-devel] [PULL 15/19] kvm: Persistent per kvmslot dirty bitmap

2019-07-11 Thread Juan Quintela
From: Peter Xu When synchronizing dirty bitmap from kernel KVM we do it in a per-kvmslot fashion and we allocate the userspace bitmap for each of the ioctl. This patch instead make the bitmap cache be persistent then we don't need to g_malloc0() every time. More importantly, the cached per-kvms

[Qemu-devel] [PULL 16/19] kvm: Introduce slots lock for memory listener

2019-07-11 Thread Juan Quintela
From: Peter Xu Introduce KVMMemoryListener.slots_lock to protect the slots inside the kvm memory listener. Currently it is close to useless because all the KVM code path now is always protected by the BQL. But it'll start to make sense in follow up patches where we might do remote dirty bitmap

Re: [Qemu-devel] [PULL for 4.1 0/4] testing and gdbstub fixes

2019-07-11 Thread Peter Maydell
On Wed, 10 Jul 2019 at 11:25, Alex Bennée wrote: > > The following changes since commit 6df2cdf44a82426f7a59dcb03f0dd2181ed7fdfa: > > Update version for v4.1.0-rc0 release (2019-07-09 17:21:53 +0100) > > are available in the Git repository at: > > https://github.com/stsquad/qemu.git tags/pull-

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-11 Thread Paolo Bonzini
On 11/07/19 12:43, Juan Quintela wrote: > The following changes since commit 6df2cdf44a82426f7a59dcb03f0dd2181ed7fdfa: > > Update version for v4.1.0-rc0 release (2019-07-09 17:21:53 +0100) > > are available in the Git repository at: > > https://github.com/juanquintela/qemu.git tags/migration

Re: [Qemu-devel] [PULL 0/3] Bitmaps patches

2019-07-11 Thread Peter Maydell
On Wed, 10 Jul 2019 at 20:23, John Snow wrote: > > The following changes since commit 6df2cdf44a82426f7a59dcb03f0dd2181ed7fdfa: > > Update version for v4.1.0-rc0 release (2019-07-09 17:21:53 +0100) > > are available in the Git repository at: > > https://github.com/jnsnow/qemu.git tags/bitmaps-

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-11 Thread Juan Quintela
Paolo Bonzini wrote: > On 11/07/19 12:43, Juan Quintela wrote: >> The following changes since commit 6df2cdf44a82426f7a59dcb03f0dd2181ed7fdfa: >> >> Update version for v4.1.0-rc0 release (2019-07-09 17:21:53 +0100) >> >> are available in the Git repository at: >> >> https://github.com/juanq

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-11 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 11/07/19 12:43, Juan Quintela wrote: > > The following changes since commit 6df2cdf44a82426f7a59dcb03f0dd2181ed7fdfa: > > > > Update version for v4.1.0-rc0 release (2019-07-09 17:21:53 +0100) > > > > are available in the Git repository at: > >

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-11 Thread Peter Maydell
On Thu, 11 Jul 2019 at 12:34, Dr. David Alan Gilbert wrote: > > * Paolo Bonzini (pbonz...@redhat.com) wrote: > > On 11/07/19 12:43, Juan Quintela wrote: > > > The following changes since commit > > > 6df2cdf44a82426f7a59dcb03f0dd2181ed7fdfa: > > > > > > Update version for v4.1.0-rc0 release (20

Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix output of extract2 opcodes

2019-07-11 Thread Richard Henderson
On 7/10/19 8:12 PM, Aleksandar Markovic wrote: > On Tue, Jul 9, 2019 at 8:56 PM Richard Henderson > wrote: >> >> The aarch64 argument ordering for the operands is big-endian, >> whereas the tcg argument ordering is little-endian. Use REG0 >> so that we honor the rZ constraints. > > Hello, Richar

Re: [Qemu-devel] [PATCH-for-4.1] tests/docker: Install Sphinx in the Fedora image

2019-07-11 Thread Richard Henderson
On 7/11/19 12:27 PM, Philippe Mathieu-Daudé wrote: > Since commit 5f71eac06e the Sphinx tool is required > to build the rST documentation. > > This fixes: > > $ ./configure --enable-docs > > ERROR: User requested feature docs > configure was not able to find it. > Install texin

Re: [Qemu-devel] [PATCH v7 00/13] Add migration support for VFIO device

2019-07-11 Thread Yan Zhao
On Thu, Jul 11, 2019 at 06:50:12PM +0800, Dr. David Alan Gilbert wrote: > * Yan Zhao (yan.y.z...@intel.com) wrote: > > Hi Kirti, > > There are still unaddressed comments to your patches v4. > > Would you mind addressing them? > > > > 1. should we register two migration interfaces simultaneously >

[Qemu-devel] [PATCH-for-4.1] tests/docker: Install Sphinx in the Ubuntu images

2019-07-11 Thread Philippe Mathieu-Daudé
Since commit 5f71eac06e the Sphinx tool is required to build the rST documentation. This fixes: $ ./configure --enable-docs ERROR: User requested feature docs configure was not able to find it. Install texinfo, Perl/perl-podlators and python-sphinx Signed-off-by: Philippe Math

Re: [Qemu-devel] [PATCH v7 04/13] vfio: Add save and load functions for VFIO PCI devices

2019-07-11 Thread Dr. David Alan Gilbert
* Kirti Wankhede (kwankh...@nvidia.com) wrote: > These functions save and restore PCI device specific data - config > space of PCI device. > Tested save and restore with MSI and MSIX type. > > Signed-off-by: Kirti Wankhede > Reviewed-by: Neo Jia > --- > hw/vfio/pci.c | 114 > ++

[Qemu-devel] [Bug 1836192] Re: Regressions on arm926 target with some GCC tests

2019-07-11 Thread Peter Maydell
We didn't spot that armv5 CPUs don't have mvfr0, so now the vfp refactor is looking at mvfr0 fields to gate feature presence we need to initialize cpu->isar.mvfr0 specifically to a value that indicates the right thing even on the armv5 CPUs which don't have a guest-visible mvfr0. This specifically

[Qemu-devel] [Bug 1836192] [NEW] Regressions on arm926 target with some GCC tests

2019-07-11 Thread Christophe Lyon
Public bug reported: Hi, After trying qemu master: commit 474f3938d79ab36b9231c9ad3b5a9314c2aeacde Merge: 68d7ff0 14f5d87 Author: Peter Maydell Date: Fri Jun 21 15:40:50 2019 +0100 even with the fix for https://bugs.launchpad.net/qemu/+bug/1834496, I've noticed several regressions compared to q

[Qemu-devel] [PATCH for-4.1] target/arm: Set VFP-related MVFR0 fields for arm926 and arm1026

2019-07-11 Thread Peter Maydell
The ARMv5 architecture didn't specify detailed per-feature ID registers. Now that we're using the MVFR0 register fields to gate the existence of VFP instructions, we need to set up the correct values in the cpu->isar structure so that we still provide an FPU to the guest. This fixes a regression i

Re: [Qemu-devel] [PATCH v7 06/13] vfio: Add VM state change handler to know state of VM

2019-07-11 Thread Dr. David Alan Gilbert
* Kirti Wankhede (kwankh...@nvidia.com) wrote: > VM state change handler gets called on change in VM's state. This is used to > set > VFIO device state to _RUNNING. > VM state change handler, migration state change handler and log_sync listener > are called asynchronously, which sometimes lead to

Re: [Qemu-devel] qemu compilation failure with nettle 3.5.1

2019-07-11 Thread Dr. David Alan Gilbert
Copying in Daniel * Amol Surati (suratia...@gmail.com) wrote: > Hi, > > The qemu upstream (at commit 6df2cdf44a at the moment) fails to compile > with nettle 3.5.1. It seems that Nettle has deprecated a few parts of > its API. > > A workaround is to provide --disable-nettle during qemu configura

[Qemu-devel] [Bug 1836192] Re: Regressions on arm926 target with some GCC tests

2019-07-11 Thread Peter Maydell
We didn't spot that armv5 CPUs don't have mvfr0, so now the vfp refactor is looking at mvfr0 fields to gate feature presence we need to initialize cpu->isar.mvfr0 specifically to a value that indicates the right thing even on the armv5 CPUs which don't have a guest-visible mvfr0. This specifically

Re: [Qemu-devel] [PATCH] LUKS: support preallocation in qemu-img

2019-07-11 Thread Max Reitz
On 11.07.19 11:20, Daniel P. Berrangé wrote: > On Wed, Jul 10, 2019 at 11:24:46PM +0200, Max Reitz wrote: >> On 10.07.19 19:03, Maxim Levitsky wrote: >>> preallocation=off and preallocation=metadata >>> both allocate luks header only, and preallocation=falloc/full >>> is passed to underlying file,

Re: [Qemu-devel] [PATCH] LUKS: support preallocation in qemu-img

2019-07-11 Thread Max Reitz
On 11.07.19 10:39, Maxim Levitsky wrote: > On Wed, 2019-07-10 at 23:52 +0200, Max Reitz wrote: >> On 10.07.19 23:24, Max Reitz wrote: >>> On 10.07.19 19:03, Maxim Levitsky wrote: preallocation=off and preallocation=metadata both allocate luks header only, and preallocation=falloc/full >>>

[Qemu-devel] [PATCH RFC v5 0/3] Baby steps towards saner headers

2019-07-11 Thread Markus Armbruster
Back in 2016, we discussed rules for headers, and these were generally liked: 1. Have a carefully curated header that's included everywhere first. We got that already thanks to Peter: osdep.h. 2. Headers should normally include everything they need beyond osdep.h. If exceptions are needed

[Qemu-devel] [PATCH RFC v5 2/3] include: Make headers more self-contained

2019-07-11 Thread Markus Armbruster
The previous commit marked 182 headers FIXME: 1 FIXME Does not pass make check-headers without CONFIG_CPUID_H, yet! 2 FIXME Does not pass make check-headers without CONFIG_LINUX, yet! 2 FIXME Does not pass make check-headers without CONFIG_OPENGL, yet! 1 FIXME Does not pass

[Qemu-devel] [PATCH RFC v5 3/3] tests: Check target-independent headers for each target, too

2019-07-11 Thread Markus Armbruster
Testing target-independent headers for each target is massive overkill, and may well be inacceptably slow. But let's see what explodes. Numerous target-independent headers don't pass this test, by design or by accident. Fortunately, they all fail for a user emulation target. Most failing header

[Qemu-devel] [PATCH RFC v5 1/3] tests: New make target check-source

2019-07-11 Thread Markus Armbruster
Make target check-source is for checking the source code itself. For now, there's just one such check, make target check-headers. It checks basic header sanity: for each header "FOO.h", test whether #include "qemu/osdep.h" #include "FOO.h" #include "FOO.h" compiles. The

Re: [Qemu-devel] [PULL 02/22] pcie: check that slt ctrl changed before deleting

2019-07-11 Thread Peter Maydell
On Tue, 2 Jul 2019 at 16:06, Michael S. Tsirkin wrote: > > During boot, linux would sometimes overwrites control of a powered off > slot before powering it on. Unfortunately QEMU interprets that as a > power off request and ejects the device. > > For example: > > /x86_64-softmmu/qemu-system-x86_64

Re: [Qemu-devel] [PULL 24/27] hw/block/pflash_cfi02: Implement erase suspend/resume

2019-07-11 Thread Peter Maydell
On Tue, 2 Jul 2019 at 04:29, Philippe Mathieu-Daudé wrote: > > From: Stephen Checkoway > > During a sector erase (but not a chip erase), the embeded erase program > can be suspended. Once suspended, the sectors not selected for erasure > may be read and programmed. Autoselect mode is allowed duri

Re: [Qemu-devel] [PATCH 8/8] iotests/257: test traditional sync modes

2019-07-11 Thread Max Reitz
On 11.07.19 05:21, John Snow wrote: > > On 7/10/19 4:46 PM, Max Reitz wrote: >> On 10.07.19 21:00, John Snow wrote: >>> On 7/10/19 1:14 PM, Max Reitz wrote: On 10.07.19 03:05, John Snow wrote: Hm. How useful is bitmap support for 'top' then, anyway? That means that if you wan

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-11 Thread Peter Maydell
On Thu, 11 Jul 2019 at 11:56, Juan Quintela wrote: > > The following changes since commit 6df2cdf44a82426f7a59dcb03f0dd2181ed7fdfa: > > Update version for v4.1.0-rc0 release (2019-07-09 17:21:53 +0100) > > are available in the Git repository at: > > https://github.com/juanquintela/qemu.git tag

Re: [Qemu-devel] [PATCH for-4.1] target/arm: Set VFP-related MVFR0 fields for arm926 and arm1026

2019-07-11 Thread Richard Henderson
On 7/11/19 2:12 PM, Peter Maydell wrote: > The ARMv5 architecture didn't specify detailed per-feature ID > registers. Now that we're using the MVFR0 register fields to > gate the existence of VFP instructions, we need to set up > the correct values in the cpu->isar structure so that we still > prov

Re: [Qemu-devel] [PATCH for-4.1] target/arm: Set VFP-related MVFR0 fields for arm926 and arm1026

2019-07-11 Thread Peter Maydell
On Thu, 11 Jul 2019 at 13:43, Richard Henderson wrote: > > On 7/11/19 2:12 PM, Peter Maydell wrote: > > @@ -1713,6 +1719,12 @@ static void arm1026_initfn(Object *obj) > > }; > > define_one_arm_cp_reg(cpu, &ifar); > > } > > +/* > > + * Similarly, we need to set MVFR0

Re: [Qemu-devel] Use Case for Qemu BT

2019-07-11 Thread Ari Sundholm
Hi! On 7/8/19 4:46 AM, Sebastian Audet wrote: So...this is not really a use-case per-say as it is actually a thing I would like to do but can't at present... Win 10 is lacking an ad2p sink and this means if I'm using it to play a windows-only game and want to stream from e.g. my phone to my com

[Qemu-devel] [PATCH-for-4.1] tests/docker: Install Ubuntu images noninteractively

2019-07-11 Thread Philippe Mathieu-Daudé
We correctly use the DEBIAN_FRONTEND environment variable on the Debian images, but forgot the Ubuntu ones are based on it. Since building docker images is not interactive, we need to inform the APT tools about it using the DEBIAN_FRONTEND environment variable (we already use it on our Debian imag

Re: [Qemu-devel] [PULL 24/27] hw/block/pflash_cfi02: Implement erase suspend/resume

2019-07-11 Thread Philippe Mathieu-Daudé
On 7/11/19 2:35 PM, Peter Maydell wrote: > On Tue, 2 Jul 2019 at 04:29, Philippe Mathieu-Daudé wrote: >> >> From: Stephen Checkoway >> >> During a sector erase (but not a chip erase), the embeded erase program >> can be suspended. Once suspended, the sectors not selected for erasure >> may be rea

Re: [Qemu-devel] [PULL 09/30] i.MX6UL: Add i.MX6UL SOC

2019-07-11 Thread Peter Maydell
On Thu, 16 Aug 2018 at 14:47, Peter Maydell wrote: > > From: Jean-Christophe Dubois > +enum FslIMX6ULConfiguration { > +FSL_IMX6UL_NUM_CPUS = 1, Hi; Coverity has just noticed some "unreachable code" in places like the imx6ul realize function: > +static void fsl_imx6ul_realize(Devic

Re: [Qemu-devel] [PATCH] LUKS: support preallocation in qemu-img

2019-07-11 Thread Max Reitz
On 11.07.19 14:23, Max Reitz wrote: > On 11.07.19 11:20, Daniel P. Berrangé wrote: >> On Wed, Jul 10, 2019 at 11:24:46PM +0200, Max Reitz wrote: [...] >>> Hm. I would expect a preallocated image to read 0. But if you just >>> pass this through to the protocol layer, it won’t read 0. >> >> Yes,

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-11 Thread Christian Borntraeger
On 11.07.19 12:43, Juan Quintela wrote: > The following changes since commit 6df2cdf44a82426f7a59dcb03f0dd2181ed7fdfa: > > Update version for v4.1.0-rc0 release (2019-07-09 17:21:53 +0100) > > are available in the Git repository at: > > https://github.com/juanquintela/qemu.git tags/migrat

Re: [Qemu-devel] [PULL 05/22] virtio-pmem: add virtio device

2019-07-11 Thread Peter Maydell
On Tue, 2 Jul 2019 at 16:07, Michael S. Tsirkin wrote: > > From: Pankaj Gupta > > This is the implementation of virtio-pmem device. Support will require > machine changes for the architectures that will support it, so it will > not yet be compiled. It can be unlocked with VIRTIO_PMEM_SUPPORTED pe

Re: [Qemu-devel] [PULL 08/22] virtio-pci: Proxy for virtio-pmem

2019-07-11 Thread Peter Maydell
On Tue, 2 Jul 2019 at 16:07, Michael S. Tsirkin wrote: > > From: Pankaj Gupta > > We need a proxy device for virtio-pmem, and this device has to be the > actual memory device so we can cleanly hotplug it. > > Forward memory device class functions either to the actual device or use > properties of

Re: [Qemu-devel] [PATCH] LUKS: support preallocation in qemu-img

2019-07-11 Thread Daniel P . Berrangé
On Thu, Jul 11, 2019 at 02:23:55PM +0200, Max Reitz wrote: > On 11.07.19 11:20, Daniel P. Berrangé wrote: > > On Wed, Jul 10, 2019 at 11:24:46PM +0200, Max Reitz wrote: > >> On 10.07.19 19:03, Maxim Levitsky wrote: > >>> preallocation=off and preallocation=metadata > >>> both allocate luks header o

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-11 Thread Peter Maydell
On Thu, 11 Jul 2019 at 13:56, Christian Borntraeger wrote: > > > > On 11.07.19 12:43, Juan Quintela wrote: > > The following changes since commit 6df2cdf44a82426f7a59dcb03f0dd2181ed7fdfa: > > > > Update version for v4.1.0-rc0 release (2019-07-09 17:21:53 +0100) > > > > are available in the Git r

Re: [Qemu-devel] [PATCH for-4.1] target/arm: Set VFP-related MVFR0 fields for arm926 and arm1026

2019-07-11 Thread Alex Bennée
Peter Maydell writes: > The ARMv5 architecture didn't specify detailed per-feature ID > registers. Now that we're using the MVFR0 register fields to > gate the existence of VFP instructions, we need to set up > the correct values in the cpu->isar structure so that we still > provide an FPU to t

Re: [Qemu-devel] [PATCH for-4.1] target/arm: Set VFP-related MVFR0 fields for arm926 and arm1026

2019-07-11 Thread Peter Maydell
On Thu, 11 Jul 2019 at 14:01, Alex Bennée wrote: > > > Peter Maydell writes: > > > The ARMv5 architecture didn't specify detailed per-feature ID > > registers. Now that we're using the MVFR0 register fields to > > gate the existence of VFP instructions, we need to set up > > the correct values in

Re: [Qemu-devel] qemu compilation failure with nettle 3.5.1

2019-07-11 Thread Daniel P . Berrangé
On Thu, Jul 11, 2019 at 01:18:17PM +0100, Dr. David Alan Gilbert wrote: > Copying in Daniel > > * Amol Surati (suratia...@gmail.com) wrote: > > Hi, > > > > The qemu upstream (at commit 6df2cdf44a at the moment) fails to compile > > with nettle 3.5.1. It seems that Nettle has deprecated a few part

[Qemu-devel] [PATCH for 4.1?] includes: remove stale [smp|max]_cpus externs

2019-07-11 Thread Alex Bennée
Commit a5e0b3311 removed these in favour of querying machine properties. Remove the extern declarations as well. Signed-off-by: Alex Bennée Cc: Like Xu --- include/sysemu/sysemu.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index 984c43

Re: [Qemu-devel] [PATCH v6] qemu-io: add pattern file for write command

2019-07-11 Thread Max Reitz
On 27.06.19 17:26, Denis Plotnikov wrote: > > > On 19.06.2019 13:09, Vladimir Sementsov-Ogievskiy wrote: >> 10.06.2019 16:21, Denis Plotnikov wrote: >>> The patch allows to provide a pattern file for write >>> command. There was no similar ability before. >>> >>> Signed-off-by: Denis Plotnikov >

[Qemu-devel] [PATCH-for-4.1] hw/block/pflash_cfi02: Explicit switch fallthrough for ERASE commands

2019-07-11 Thread Philippe Mathieu-Daudé
Previous to commit ddb6f2254, the DQ2 bit was incorrectly set during PROGRAM command (0xA0). The commit reordered the switch cases to only set the DQ2 bit for the ERASE commands using a fallthrough, but did not explicit the fallthrough is intentional. Mark the switch fallthrough with a comment int

  1   2   3   4   >