Re: [Qemu-devel] [PATCH v6 02/11] Add vhost-user-input-pci

2019-04-26 Thread Gerd Hoffmann
> +static void vhost_input_get_config(VirtIODevice *vdev, uint8_t *config_data) > +{ > +VirtIOInput *vinput = VIRTIO_INPUT(vdev); > +VHostUserInput *vhi = VHOST_USER_INPUT(vdev); > +int ret; > + > +memset(config_data, 0, vinput->cfg_size); > + > +ret = vhost_dev_get_config(&vhi-

Re: [Qemu-devel] [PATCH v6 04/11] contrib: add vhost-user-input

2019-04-26 Thread Gerd Hoffmann
On Tue, Apr 23, 2019 at 03:19:57PM +0200, Marc-André Lureau wrote: > Add a vhost-user input backend example, based on virtio-input-host > device. It takes an evdev path as argument, and can be associated with > a vhost-user-input device via a UNIX socket: > > $ vhost-user-input -p /dev/input/event

[Qemu-devel] [PATCH 3/3] sev: Change SEV to use EncryptedRAMBlock Notifier

2019-04-26 Thread Natarajan, Janakarajan
The EncryptedRAMBlock Notifier lets SEV know which guest RAM pages will contain encrypted guest data. Using this notifier lets SEV skip pinning pages that do not contain encrypted data. Signed-off-by: Janakarajan Natarajan --- target/i386/sev.c | 25 - 1 file changed, 8

[Qemu-devel] [PATCH 0/3] Add RAM block encrypted notifier

2019-04-26 Thread Natarajan, Janakarajan
Currently, the SEV guest launch registers to a RAM block notifier. When called, we issue KVM_MEMORY_ENCRYPT_{REG,UNREG}_REGION ioctl to register the memory with the KVM driver. These ioctls should be called only for the region which contains the encrypted data but the RAM block notifier gets called

[Qemu-devel] [PATCH 1/3] ram-encrypted-notifier: Introduce a RAM block encrypted notifier

2019-04-26 Thread Natarajan, Janakarajan
A client can register to this notifier to know whether the newly added or removed memory region is marked as encrypted. This information is needed for the SEV guest launch. In SEV guest, some memory regions may contain encrypted data (e.g guest RAM). The memory region which contains the encrypted d

[Qemu-devel] [PATCH 2/3] hw: Notify listeners about guest pages which contain encrypted data

2019-04-26 Thread Natarajan, Janakarajan
PC ram, pflash unit 0 rom and pc-dimm memory hotplug ram blocks need to be encrypted. Also, notify listeners when freeing a MemoryRegion if it has encrypted data. Signed-off-by: Janakarajan Natarajan --- exec.c | 5 + hw/i386/pc.c | 1 + hw/i386/pc_sysfw.c | 2

Re: [Qemu-devel] [PATCH v6 05/11] vhost-user: add vhost_user_gpu_set_socket()

2019-04-26 Thread Gerd Hoffmann
On Tue, Apr 23, 2019 at 03:19:58PM +0200, Marc-André Lureau wrote: > Add a new vhost-user message to give a unix socket to a vhost-user > backend for GPU display updates. Can you split input/gpu into two patch series? > +Wire format > +=== > + > +Unless specified differently, numbers are

[Qemu-devel] [Bug 1826422] Re: Regression: QEMU 4.0 hangs the host (*bisect included*)

2019-04-26 Thread Saverio Miroddi
ok, so, if I understand correctly, the workaround is: - set `x-no-kvm-intx=on` and enable MSI in the guest (via regedit or module params) which may lead to a performance regression (at least under certain circumstances). Is it therefore preferrable, performance and configuration-wise, to use QEM

Re: [Qemu-devel] [PATCH] hvf: Add missing break statement

2019-04-26 Thread Paolo Bonzini
On 22/04/19 18:09, Philippe Mathieu-Daudé wrote: > Oops... I'm surprised no compiler warned about this yet... > > This probably mean: > - This code is not covered by Continuous Integration > - Upstream maintainers are not building this code > - Upstream is not running this code > > Please tell me

Re: [Qemu-devel] [PATCH v3 0/3] char-socket: Fix race condition

2019-04-26 Thread Paolo Bonzini
On 23/04/19 18:55, Daniel P. Berrangé wrote: > ping - paolo/marc-andré - unless I'm missing something, it looks like > this chardev series slipped through the cracks and missed 4.0 Yeah, it had a bug unfortunately. I'm looking at it RSN. Paolo > > On Fri, Feb 22, 2019 at 03:46:23PM +0200, Albe

Re: [Qemu-devel] [PATCH v6 08/11] contrib: add vhost-user-gpu

2019-04-26 Thread Gerd Hoffmann
Hi, > +#ifdef CONFIG_LIBDRM_INTEL > +static bool > +intel_alloc_bo(struct drm_buffer *buf) > +{ > +uint32_t tiling = I915_TILING_NONE; > + > +buf->intel_bo = drm_intel_bo_alloc_tiled(buf->dev->bufmgr, > "vhost-user-gpu", > + buf->width, buf->h

[Qemu-devel] About pt-br keyboard layout

2019-04-26 Thread Lin Ma
Hi all, While I launch qemu with vnc + pt-br keyboard layout on my pc, If I type shift + 6 in iPXE shell or grub shell via my usual 105-key keyboard, shift + 6 would be mapped to "(apostrophe), But IIUC the correct character should be ¨(diaeresis) in pt-br layout. I'm wondering that is it the

Re: [Qemu-devel] [RHEL-8.1 virt 0/2] Enable SEV VM to boot with assigned PCI device

2019-04-26 Thread Paolo Bonzini
On 10/04/19 02:08, Gary R Hook wrote: > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1667249 > > On an AMD SEV enabled host with an SEV enabled guest, attaching an > assigned device to the VM results in a failure to start the VM: > > qemu-kvm: -device vfio-pci,host=01:00.0,id=hostdev0,bu

Re: [Qemu-devel] Following up questions related to QEMU and I/O Thread

2019-04-26 Thread Paolo Bonzini
On 23/04/19 14:04, Stefan Hajnoczi wrote: >> In addition, does Virtio-scsi support Batch I/O Submission feature >> which may be able to increase the IOPS via reducing the number of >> system calls? > > I don't see obvious batching support in drivers/scsi/virtio_scsi.c. > The Linux block layer suppo

Re: [Qemu-devel] [PATCH 3/4] qdev: Don't compile hotplug code in user-mode emulation

2019-04-26 Thread Paolo Bonzini
On 25/04/19 22:00, Eduardo Habkost wrote: > diff --git a/hw/core/qdev-hotplug-stubs.c b/hw/core/qdev-hotplug-stubs.c > new file mode 100644 > index 00..c710f23388 > --- /dev/null > +++ b/hw/core/qdev-hotplug-stubs.c > @@ -0,0 +1,44 @@ > +/* > + * qdev hotplug handler stubs (for user-mode em

Re: [Qemu-devel] About pt-br keyboard layout

2019-04-26 Thread Gerd Hoffmann
On Fri, Apr 26, 2019 at 04:09:12PM +0800, Lin Ma wrote: > Hi all, > > While I launch qemu with vnc + pt-br keyboard layout on my pc, If I type > shift + 6 in iPXE shell or grub shell via my usual 105-key keyboard, > shift + 6 would be mapped to "(apostrophe), But IIUC the correct character > shoul

Re: [Qemu-devel] [PATCH 0/4] Remove some qdev_get_machine() calls from CONFIG_USER_ONLY

2019-04-26 Thread Like Xu
On 2019/4/26 4:00, Eduardo Habkost wrote: This series moves some qdev code outside qdev.o, so it can be compiled only in CONFIG_SOFTMMU. The code being moved includes two qdev_get_machine() calls, so this will make it easier to move qdev_get_machine() to CONFIG_SOFTMMU later. After this series,

[Qemu-devel] [PATCH 1/3] migration/colo.c: Remove redundant input parameter

2019-04-26 Thread Zhang Chen
From: Zhang Chen The colo_do_failover no need the input parameter. Signed-off-by: Zhang Chen --- include/migration/colo.h | 2 +- migration/colo-failover.c | 2 +- migration/colo.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/migration/colo.h b/inclu

[Qemu-devel] [PATCH 0/3] Optimize COLO related codes and description

2019-04-26 Thread Zhang Chen
From: Zhang Chen In this series we optimize codes and fix some tiny issues. Zhang Chen (3): migration/colo.c: Remove redundant input parameter migration/colo.h: Remove obsolete codes qemu-option.hx: Update missed parameter for colo-compare include/migration/colo.h | 4 +--- migration/co

[Qemu-devel] [PATCH 3/3] qemu-option.hx: Update missed parameter for colo-compare

2019-04-26 Thread Zhang Chen
From: Zhang Chen We missed the iothread related args in this file. This patch is used to fix this issue. Signed-off-by: Zhang Chen --- qemu-options.hx | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 08749a3391..a4500c99ef 100

[Qemu-devel] [PATCH 2/3] migration/colo.h: Remove obsolete codes

2019-04-26 Thread Zhang Chen
From: Zhang Chen Signed-off-by: Zhang Chen --- include/migration/colo.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/migration/colo.h b/include/migration/colo.h index ddebe0ad27..f6fbe23ec9 100644 --- a/include/migration/colo.h +++ b/include/migration/colo.h @@ -22,8 +22,6 @@ en

Re: [Qemu-devel] [PATCH] Revert "armv7m: Guard against no -kernel argument"

2019-04-26 Thread Stefan Hajnoczi
On Thu, Apr 25, 2019 at 08:07:06PM +0200, Philippe Mathieu-Daudé wrote: > On 1/4/19 4:16 PM, Peter Maydell wrote: > > On Thu, 3 Jan 2019 at 14:41, Stefan Hajnoczi wrote: > >> > >> This reverts commit 01fd41ab3fb69971c24a69ed49cde96086d81278. > >> > >> The generic loader device (-device loader,file

Re: [Qemu-devel] [PATCH] migration/colo.c: Remove redundant input parameter

2019-04-26 Thread Zhang, Chen
This patch have been integrated in this series: http://lists.nongnu.org/archive/html/qemu-devel/2019-04/msg04520.html Please review it at this link. Thanks Zhang Chen > -Original Message- > From: Zhang, Chen > Sent: Friday, April 26, 2019 11:40 AM > To: Laurent Vivier ; Dr. David Alan Gi

Re: [Qemu-devel] [PATCH] migration/colo.h: Remove obsolete codes

2019-04-26 Thread Zhang, Chen
This patch have been integrated in this series: http://lists.nongnu.org/archive/html/qemu-devel/2019-04/msg04520.html Please review it at this link. Thanks Zhang Chen > -Original Message- > From: Zhang, Chen > Sent: Friday, April 26, 2019 11:40 AM > To: Laurent Vivier ; Dr. David Alan Gil

Re: [Qemu-devel] [PATCH v6 02/11] Add vhost-user-input-pci

2019-04-26 Thread Marc-André Lureau
Hi On Fri, Apr 26, 2019 at 9:12 AM Gerd Hoffmann wrote: > > > +static void vhost_input_get_config(VirtIODevice *vdev, uint8_t > > *config_data) > > +{ > > +VirtIOInput *vinput = VIRTIO_INPUT(vdev); > > +VHostUserInput *vhi = VHOST_USER_INPUT(vdev); > > +int ret; > > + > > +memset

[Qemu-devel] [PATCH] MAINTAINERS: Add qemu-options* to related field

2019-04-26 Thread Zhang Chen
From: Zhang Chen No one to maintain qemu-options related file, add it to Markus's Command line option argument parsing field. Signed-off-by: Zhang Chen --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 23db6f8408..acc3b32f88 100644 --- a/MAINTA

[Qemu-devel] Failing qemu-iotest 005 with raw

2019-04-26 Thread Thomas Huth
When running iotest 005 with raw, the test currently fails for me: 005 - output mismatch (see 005.out.bad) --- /home/thuth/devel/qemu/tests/qemu-iotests/005.out 2019-04-23 16:43:11.0 +0200 +++ /home/thuth/tmp/qemu-build/tests/qemu-iotests/005.out.bad 2019-04-26 11:34:11.0

Re: [Qemu-devel] [PATCH v6 04/11] contrib: add vhost-user-input

2019-04-26 Thread Marc-André Lureau
Hi On Fri, Apr 26, 2019 at 9:16 AM Gerd Hoffmann wrote: > > On Tue, Apr 23, 2019 at 03:19:57PM +0200, Marc-André Lureau wrote: > > Add a vhost-user input backend example, based on virtio-input-host > > device. It takes an evdev path as argument, and can be associated with > > a vhost-user-input d

[Qemu-devel] [PATCH] trace: fix runstate tracing

2019-04-26 Thread Yury Kotov
Signed-off-by: Yury Kotov --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index ff5dfb6fbc..ad9b181e57 100644 --- a/vl.c +++ b/vl.c @@ -725,7 +725,7 @@ void runstate_set(RunState new_state) assert(new_state < RUN_STATE__MAX); trace_runstate_set

[Qemu-devel] [PATCH 0/6] Add vhost-user-input

2019-04-26 Thread Marc-André Lureau
Hi, This is the vhost-user-input part of "[PATCH v6 00/11] vhost-user for input & GPU". v1: (changes since original v6 series) - add "libvhost-user: fix -Waddress-of-packed-member" & "util: simplify unix_listen()" - use unix_listen() - build vhost-user-input by default (when applicable) Marc-A

[Qemu-devel] [PATCH 2/6] libvhost-user: add PROTOCOL_F_CONFIG if {set, get}_config

2019-04-26 Thread Marc-André Lureau
Add the config protocol feature bit if the set_config & get_config callbacks are implemented. Signed-off-by: Marc-André Lureau --- contrib/libvhost-user/libvhost-user.c | 4 1 file changed, 4 insertions(+) diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/libvhost

[Qemu-devel] [PATCH 1/6] libvhost-user: fix -Waddress-of-packed-member

2019-04-26 Thread Marc-André Lureau
/home/elmarco/src/qemu/contrib/libvhost-user/libvhost-user.c: In function ‘vu_set_mem_table_exec_postcopy’: /home/elmarco/src/qemu/contrib/libvhost-user/libvhost-user.c:546:31: warning: taking address of packed member of ‘struct VhostUserMsg’ may result in an unaligned pointer value [-Waddress-o

[Qemu-devel] [PATCH 5/6] util: simplify unix_listen()

2019-04-26 Thread Marc-André Lureau
The only caller of unix_listen() left is qga/channel-posix.c. There is no need to deal with legacy coma-trailing options ",...". Signed-off-by: Marc-André Lureau --- util/qemu-sockets.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/util/qemu-sockets.c b

[Qemu-devel] [PATCH 6/6] contrib: add vhost-user-input

2019-04-26 Thread Marc-André Lureau
Add a vhost-user input backend example, based on virtio-input-host device. It takes an evdev path as argument, and can be associated with a vhost-user-input device via a UNIX socket: $ vhost-user-input -p /dev/input/eventX -s /tmp/vui.sock $ qemu ... -chardev socket,id=vuic,path=/tmp/vui.sock -

[Qemu-devel] [PATCH 3/6] Add vhost-user-backend

2019-04-26 Thread Marc-André Lureau
Create a vhost-user-backend object that holds a connection to a vhost-user backend (or "slave" process) and can be referenced from virtio devices that support it. See later patches for input & gpu usage. Note: a previous iteration of this object made it user-creatable, and allowed managed sub-proc

[Qemu-devel] [PATCH 4/6] Add vhost-user-input-pci

2019-04-26 Thread Marc-André Lureau
Add a new virtio-input device, which connects to a vhost-user backend. Instead of reading configuration directly from an input device / evdev (like virtio-input-host), it reads it over vhost-user protocol with {SET,GET}_CONFIG messages. The vhost-user-backend handles the queues & events setup. Si

Re: [Qemu-devel] [PATCH 6/6] contrib: add vhost-user-input

2019-04-26 Thread Marc-André Lureau
Hi On Fri, Apr 26, 2019 at 12:25 PM Marc-André Lureau wrote: > > Add a vhost-user input backend example, based on virtio-input-host > device. It takes an evdev path as argument, and can be associated with > a vhost-user-input device via a UNIX socket: > > $ vhost-user-input -p /dev/input/eventX -

Re: [Qemu-devel] Failing qemu-iotest 005 with raw

2019-04-26 Thread Kevin Wolf
Am 26.04.2019 um 11:41 hat Thomas Huth geschrieben: > > When running iotest 005 with raw, the test currently fails for me: > > 005 - output mismatch (see 005.out.bad) > --- /home/thuth/devel/qemu/tests/qemu-iotests/005.out 2019-04-23 > 16:43:11.0 +0200 > +++ /home/thuth/tmp/qemu-b

[Qemu-devel] [PATCH v2 00/10] s390x: new guest features

2019-04-26 Thread Christian Borntraeger
Adding gen15. v1->v2: - rework csske deprecation - white space fixes - also require msa4 for msa9 Christian Borntraeger (7): *** BLURB HERE *** Christian Borntraeger (10): linux header sync s390x/cpumodel: ignore csske for expansion s390x/cpumodel: Miscellaneous-Instruction

[Qemu-devel] [PATCH v2 10/10] s390x/cpumodel: wire up 8561 and 8562 as gen15 machines

2019-04-26 Thread Christian Borntraeger
8561 and 8562 will be gen15 machines. There is no name yet, lets us use the cpu id as base name. Later on we can provide aliases with the proper name. Signed-off-by: Christian Borntraeger --- target/s390x/cpu_models.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/s390x/cpu_models.

[Qemu-devel] [PATCH v2 09/10] s390x/cpumodel: disable csske and bpb from gen15 cpu models onwards

2019-04-26 Thread Christian Borntraeger
These facilities are deprecated and no longer needed. Signed-off-by: Christian Borntraeger --- target/s390x/gen-features.c | 12 1 file changed, 12 insertions(+) diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c index 6260f56dc1..c346b76bdf 100644 --- a/target/

[Qemu-devel] [PATCH v2 08/10] s390x/cpumodel: add gen15 defintions

2019-04-26 Thread Christian Borntraeger
add several new features (msa9, sort, deflate, additional vector instructions, new general purpose instructions) to generation 15. Also disable csske and bpb from the default model. This will allow to migrate gen15 machines to future machines that do not have these features. Signed-off-by: Christ

[Qemu-devel] [PATCH v2 03/10] s390x/cpumodel: Miscellaneous-Instruction-Extensions Facility 3

2019-04-26 Thread Christian Borntraeger
Provide the "Miscellaneous-Instruction-Extensions Facility 3" via stfle.61. Signed-off-by: Christian Borntraeger Reviewed-by: David Hildenbrand --- target/s390x/cpu_features.c | 1 + target/s390x/cpu_features_def.h | 1 + 2 files changed, 2 insertions(+) diff --git a/target/s390x/cpu_featu

[Qemu-devel] [PATCH v2 05/10] s390x/cpumodel: vector enhancements

2019-04-26 Thread Christian Borntraeger
Add vector enhancements to the cpu model. Signed-off-by: Christian Borntraeger Reviewed-by: David Hildenbrand --- target/s390x/cpu_features.c | 2 ++ target/s390x/cpu_features_def.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/target/s390x/cpu_features.c b/target/s390x/cpu_feature

[Qemu-devel] [PATCH v2 01/10] linux header sync

2019-04-26 Thread Christian Borntraeger
to be replaced by a proper one Signed-off-by: Christian Borntraeger --- linux-headers/asm-s390/kvm.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h index 0265482f8f..03ab5968c7 100644 --- a/linux-headers/asm-s39

[Qemu-devel] [PATCH v2 04/10] s390x/cpumodel: msa9 facility

2019-04-26 Thread Christian Borntraeger
Provide the MSA9 facility (stfle.155). This also contains pckmo functions for key wrapping. Keep them in a separate group to disable those as a block if necessary. Signed-off-by: Christian Borntraeger --- target/s390x/cpu_features.c | 32 + target/s390x/cpu_features.h

Re: [Qemu-devel] [PATCH v2 02/10] s390x/cpumodel: ignore csske for expansion

2019-04-26 Thread David Hildenbrand
On 26.04.19 13:09, Christian Borntraeger wrote: > csske will be removed in a future machine. Ignore it for expanding the > cpu model. Otherwise qemu falls back to z9. > > Signed-off-by: Christian Borntraeger > Cc: qemu-sta...@nongnu.org > --- > target/s390x/cpu_models.c | 2 ++ > 1 file changed,

[Qemu-devel] [PATCH v2 02/10] s390x/cpumodel: ignore csske for expansion

2019-04-26 Thread Christian Borntraeger
csske will be removed in a future machine. Ignore it for expanding the cpu model. Otherwise qemu falls back to z9. Signed-off-by: Christian Borntraeger Cc: qemu-sta...@nongnu.org --- target/s390x/cpu_models.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/s390x/cpu_models.c b/targe

[Qemu-devel] [PATCH v2 06/10] s390x/cpumodel: enhanced sort facility

2019-04-26 Thread Christian Borntraeger
add the enhanced sort facility. Signed-off-by: Christian Borntraeger Reviewed-by: David Hildenbrand --- target/s390x/cpu_features.c | 10 ++ target/s390x/cpu_features.h | 1 + target/s390x/cpu_features_def.h | 8 target/s390x/gen-features.c | 14 ++ ta

[Qemu-devel] [PATCH v2 07/10] s390x/cpumodel: add Deflate-conversion facility

2019-04-26 Thread Christian Borntraeger
add the deflate conversion facility. Signed-off-by: Christian Borntraeger --- target/s390x/cpu_features.c | 9 + target/s390x/cpu_features.h | 1 + target/s390x/cpu_features_def.h | 7 +++ target/s390x/gen-features.c | 12 target/s390x/kvm.c |

Re: [Qemu-devel] [PATCH v2 09/10] s390x/cpumodel: disable csske and bpb from gen15 cpu models onwards

2019-04-26 Thread David Hildenbrand
On 26.04.19 13:10, Christian Borntraeger wrote: > These facilities are deprecated and no longer needed. > > Signed-off-by: Christian Borntraeger > --- > target/s390x/gen-features.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/target/s390x/gen-features.c b/target/s390x/

Re: [Qemu-devel] [PATCH v2 09/10] s390x/cpumodel: disable csske and bpb from gen15 cpu models onwards

2019-04-26 Thread David Hildenbrand
On 26.04.19 13:18, Christian Borntraeger wrote: > > > On 26.04.19 13:18, David Hildenbrand wrote: >> On 26.04.19 13:10, Christian Borntraeger wrote: >>> These facilities are deprecated and no longer needed. >>> >>> Signed-off-by: Christian Borntraeger >>> --- >>> target/s390x/gen-features.c | 1

Re: [Qemu-devel] [PATCH v2 10/10] s390x/cpumodel: wire up 8561 and 8562 as gen15 machines

2019-04-26 Thread Christian Borntraeger
On 26.04.19 13:21, David Hildenbrand wrote: > On 26.04.19 13:10, Christian Borntraeger wrote: >> 8561 and 8562 will be gen15 machines. There is no name yet, lets us use >> the cpu id as base name. Later on we can provide aliases with the proper >> name. >> >> Signed-off-by: Christian Borntraeger

Re: [Qemu-devel] [PATCH v2 09/10] s390x/cpumodel: disable csske and bpb from gen15 cpu models onwards

2019-04-26 Thread Christian Borntraeger
On 26.04.19 13:18, David Hildenbrand wrote: > On 26.04.19 13:10, Christian Borntraeger wrote: >> These facilities are deprecated and no longer needed. >> >> Signed-off-by: Christian Borntraeger >> --- >> target/s390x/gen-features.c | 12 >> 1 file changed, 12 insertions(+) >> >> d

Re: [Qemu-devel] [PATCH v2 10/10] s390x/cpumodel: wire up 8561 and 8562 as gen15 machines

2019-04-26 Thread David Hildenbrand
On 26.04.19 13:10, Christian Borntraeger wrote: > 8561 and 8562 will be gen15 machines. There is no name yet, lets us use > the cpu id as base name. Later on we can provide aliases with the proper > name. > > Signed-off-by: Christian Borntraeger > --- > target/s390x/cpu_models.c | 2 ++ > 1 file

Re: [Qemu-devel] [PATCH v2 10/10] s390x/cpumodel: wire up 8561 and 8562 as gen15 machines

2019-04-26 Thread Christian Borntraeger
On 26.04.19 13:21, David Hildenbrand wrote: > On 26.04.19 13:10, Christian Borntraeger wrote: >> 8561 and 8562 will be gen15 machines. There is no name yet, lets us use >> the cpu id as base name. Later on we can provide aliases with the proper >> name. >> >> Signed-off-by: Christian Borntraeger

Re: [Qemu-devel] [PATCH 3/4] qdev: Don't compile hotplug code in user-mode emulation

2019-04-26 Thread Eduardo Habkost
On Fri, Apr 26, 2019 at 10:27:58AM +0200, Paolo Bonzini wrote: > On 25/04/19 22:00, Eduardo Habkost wrote: > > diff --git a/hw/core/qdev-hotplug-stubs.c b/hw/core/qdev-hotplug-stubs.c > > new file mode 100644 > > index 00..c710f23388 > > --- /dev/null > > +++ b/hw/core/qdev-hotplug-stubs.c

Re: [Qemu-devel] [PATCH v2 00/10] s390x: new guest features

2019-04-26 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190426111003.21246-1-borntrae...@de.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190426111003.21246-1-borntrae...@de.ibm.com Subject: [Qemu-devel] [PATCH v2 00/10] s

Re: [Qemu-devel] [PATCH v2 10/10] s390x/cpumodel: wire up 8561 and 8562 as gen15 machines

2019-04-26 Thread David Hildenbrand
On 26.04.19 13:10, Christian Borntraeger wrote: > 8561 and 8562 will be gen15 machines. There is no name yet, lets us use > the cpu id as base name. Later on we can provide aliases with the proper > name. > > Signed-off-by: Christian Borntraeger > --- > target/s390x/cpu_models.c | 2 ++ > 1 file

Re: [Qemu-devel] [PATCH v2 10/10] s390x/cpumodel: wire up 8561 and 8562 as gen15 machines

2019-04-26 Thread David Hildenbrand
On 26.04.19 13:24, Christian Borntraeger wrote: > > > On 26.04.19 13:21, David Hildenbrand wrote: >> On 26.04.19 13:10, Christian Borntraeger wrote: >>> 8561 and 8562 will be gen15 machines. There is no name yet, lets us use >>> the cpu id as base name. Later on we can provide aliases with the pr

Re: [Qemu-devel] [PATCH v2 10/10] s390x/cpumodel: wire up 8561 and 8562 as gen15 machines

2019-04-26 Thread Christian Borntraeger
On 26.04.19 13:32, David Hildenbrand wrote: > On 26.04.19 13:10, Christian Borntraeger wrote: >> 8561 and 8562 will be gen15 machines. There is no name yet, lets us use >> the cpu id as base name. Later on we can provide aliases with the proper >> name. >> >> Signed-off-by: Christian Borntraeger

Re: [Qemu-devel] [PATCH] Revert "armv7m: Guard against no -kernel argument"

2019-04-26 Thread Peter Maydell
On Fri, 26 Apr 2019 at 10:17, Stefan Hajnoczi wrote: > > On Thu, Apr 25, 2019 at 08:07:06PM +0200, Philippe Mathieu-Daudé wrote: > > Previous to this commit (v3.1), we have: > > > > $ qemu-system-aarch64 -M netduino2 > > qemu-system-aarch64: Guest image must be specified (using -kernel) > > > > No

Re: [Qemu-devel] About pt-br keyboard layout

2019-04-26 Thread Lin Ma
On 4/26/19 4:38 PM, Gerd Hoffmann wrote: On Fri, Apr 26, 2019 at 04:09:12PM +0800, Lin Ma wrote: Hi all, While I launch qemu with vnc + pt-br keyboard layout on my pc, If I type shift + 6 in iPXE shell or grub shell via my usual 105-key keyboard, shift + 6 would be mapped to "(apostrophe), Bu

Re: [Qemu-devel] [PATCH v2 10/10] s390x/cpumodel: wire up 8561 and 8562 as gen15 machines

2019-04-26 Thread Christian Borntraeger
On 26.04.19 13:52, David Hildenbrand wrote: > On 26.04.19 13:36, Christian Borntraeger wrote: >> >> >> On 26.04.19 13:32, David Hildenbrand wrote: >>> On 26.04.19 13:10, Christian Borntraeger wrote: 8561 and 8562 will be gen15 machines. There is no name yet, lets us use the cpu id as b

Re: [Qemu-devel] [PATCH v6 05/11] vhost-user: add vhost_user_gpu_set_socket()

2019-04-26 Thread Marc-André Lureau
Hi On Fri, Apr 26, 2019 at 9:33 AM Gerd Hoffmann wrote: > > On Tue, Apr 23, 2019 at 03:19:58PM +0200, Marc-André Lureau wrote: > > Add a new vhost-user message to give a unix socket to a vhost-user > > backend for GPU display updates. > > Can you split input/gpu into two patch series? > > > +Wire

Re: [Qemu-devel] [PATCH v3 11/13] tests: acpi: add simple arm/virt testcase

2019-04-26 Thread Igor Mammedov
On Fri, 26 Apr 2019 00:51:56 +0800 x00249684 wrote: > Hi Igor, > > +static void test_acpi_virt_tcg(void) > +{ > +test_data data = { > +.machine = "virt", > +.uefi_fl1 = "pc-bios/edk2-aarch64-code.fd", > +.uefi_fl2 = "pc-bios/edk2-arm-vars.fd", > +.cd = > "tes

Re: [Qemu-devel] [PATCH v2 10/10] s390x/cpumodel: wire up 8561 and 8562 as gen15 machines

2019-04-26 Thread David Hildenbrand
On 26.04.19 13:36, Christian Borntraeger wrote: > > > On 26.04.19 13:32, David Hildenbrand wrote: >> On 26.04.19 13:10, Christian Borntraeger wrote: >>> 8561 and 8562 will be gen15 machines. There is no name yet, lets us use >>> the cpu id as base name. Later on we can provide aliases with the pr

Re: [Qemu-devel] About pt-br keyboard layout

2019-04-26 Thread Gerd Hoffmann
> > So -k must match the *hosts* keyboard layout. > So, that means, If I launch qemu with -k pt-br on a host, I need to ensure > the keyboard layout > must be pt-br as well onthathypervisorhost,Then when I connected to this vnc > server(qemu) > throughvncviewer on mylaptop(us keyboard layout), I ty

Re: [Qemu-devel] [PATCH v2 10/10] s390x/cpumodel: wire up 8561 and 8562 as gen15 machines

2019-04-26 Thread David Hildenbrand
On 26.04.19 14:01, Christian Borntraeger wrote: > > > On 26.04.19 13:52, David Hildenbrand wrote: >> On 26.04.19 13:36, Christian Borntraeger wrote: >>> >>> >>> On 26.04.19 13:32, David Hildenbrand wrote: On 26.04.19 13:10, Christian Borntraeger wrote: > 8561 and 8562 will be gen15 machi

Re: [Qemu-devel] [PATCH v6 05/11] vhost-user: add vhost_user_gpu_set_socket()

2019-04-26 Thread Gerd Hoffmann
Hi, > > > +Wire format > > > +=== > > > + > > > +Unless specified differently, numbers are in the machine native byte > > > +order. > > > + > > > +A vhost-user-gpu request consists of 2 header fields and a payload. > > > + > > > ++-+--+-+ > > > +| request | size | pay

Re: [Qemu-devel] [PATCH v2 for-4.1 0/2] Fix ohci_die() and move PCI code to separate file

2019-04-26 Thread Philippe Mathieu-Daudé
On 4/26/19 7:42 AM, Thomas Huth wrote: > On 26/04/2019 00.55, Philippe Mathieu-Daudé wrote: >> Hi Thomas, >> >> On 4/19/19 9:56 AM, Thomas Huth wrote: >>> First patch fixes a problem with ohci_die(), second patch moves PCI code >>> into >>> a separate file, so that the sysbus OHCI device can also

Re: [Qemu-devel] [PATCH v6 05/11] vhost-user: add vhost_user_gpu_set_socket()

2019-04-26 Thread Marc-André Lureau
Hi On Fri, Apr 26, 2019 at 2:06 PM Gerd Hoffmann wrote: > > Hi, > > > > > +Wire format > > > > +=== > > > > + > > > > +Unless specified differently, numbers are in the machine native byte > > > > +order. > > > > + > > > > +A vhost-user-gpu request consists of 2 header fields and a paylo

Re: [Qemu-devel] [PATCH v2 for-4.1 0/2] Fix ohci_die() and move PCI code to separate file

2019-04-26 Thread Thomas Huth
On 26/04/2019 14.14, Philippe Mathieu-Daudé wrote: > On 4/26/19 7:42 AM, Thomas Huth wrote: >> On 26/04/2019 00.55, Philippe Mathieu-Daudé wrote: >>> Hi Thomas, >>> >>> On 4/19/19 9:56 AM, Thomas Huth wrote: First patch fixes a problem with ohci_die(), second patch moves PCI code into >>

Re: [Qemu-devel] [PATCH v2 for-4.1 0/2] Fix ohci_die() and move PCI code to separate file

2019-04-26 Thread Philippe Mathieu-Daudé
On 4/26/19 2:20 PM, Thomas Huth wrote: > On 26/04/2019 14.14, Philippe Mathieu-Daudé wrote: >> On 4/26/19 7:42 AM, Thomas Huth wrote: >>> On 26/04/2019 00.55, Philippe Mathieu-Daudé wrote: Hi Thomas, On 4/19/19 9:56 AM, Thomas Huth wrote: > First patch fixes a problem with ohci_d

[Qemu-devel] aio context ownership during bdrv_close()

2019-04-26 Thread Anton Kuchin
I can't figure out ownership of aio context during bdrv_close(). As far as I understand bdrv_unref() shold be called with acquired aio context to prevent concurrent operations (at least most usages in blockdev.c explicitly acquire and release context, but not all). But if refcount reaches zer

Re: [Qemu-devel] [PATCH 1/3] ram-encrypted-notifier: Introduce a RAM block encrypted notifier

2019-04-26 Thread Igor Mammedov
On Thu, 25 Apr 2019 22:58:18 + "Natarajan, Janakarajan" wrote: > A client can register to this notifier to know whether the newly added or > removed memory region is marked as encrypted. This information is needed > for the SEV guest launch. In SEV guest, some memory regions may contain > enc

Re: [Qemu-devel] [PATCH 3/6] Add vhost-user-backend

2019-04-26 Thread Marc-André Lureau
Hi On Fri, Apr 26, 2019 at 12:27 PM Marc-André Lureau wrote: > > Create a vhost-user-backend object that holds a connection to a > vhost-user backend (or "slave" process) and can be referenced from > virtio devices that support it. See later patches for input & gpu > usage. > > Note: a previous i

Re: [Qemu-devel] About pt-br keyboard layout

2019-04-26 Thread Lin Ma
On 4/26/19 7:48 PM, Gerd Hoffmann wrote: So -k must match the *hosts* keyboard layout. So, that means, If I launch qemu with -k pt-br on a host, I need to ensure the keyboard layout must be pt-br as well onthathypervisorhost,Then when I connected to this vnc server(qemu) throughvncviewer on my

Re: [Qemu-devel] [PATCH v2 10/10] s390x/cpumodel: wire up 8561 and 8562 as gen15 machines

2019-04-26 Thread Cornelia Huck
On Fri, 26 Apr 2019 14:05:30 +0200 David Hildenbrand wrote: > On 26.04.19 14:01, Christian Borntraeger wrote: > > > > > > On 26.04.19 13:52, David Hildenbrand wrote: > >> On 26.04.19 13:36, Christian Borntraeger wrote: > >>> > >>> > >>> On 26.04.19 13:32, David Hildenbrand wrote: > O

[Qemu-devel] [Bug 1826422] Re: Regression: QEMU 4.0 hangs the host (*bisect included*)

2019-04-26 Thread Alex Williamson
The change in QEMU 4.0 is only a change in defaults of the machine type, it can be entirely reverted in the VM config with kernel_irqchip=on or with libvirt. Using a machine type prior to the q35 4.0 machine type would also avoid it. There are no performance issues with these configurations that

Re: [Qemu-devel] [PULL 00/19] first batch of s390x patches for 4.1

2019-04-26 Thread Peter Maydell
On Thu, 25 Apr 2019 at 14:21, Cornelia Huck wrote: > > The following changes since commit 3284aa128153750f14a61e8a96fd085e6f2999b6: > > Merge remote-tracking branch 'remotes/lersek/tags/edk2-pull-2019-04-22' > into staging (2019-04-24 13:19:41 +0100) > > are available in the Git repository at:

Re: [Qemu-devel] [PATCH v6 08/11] contrib: add vhost-user-gpu

2019-04-26 Thread Marc-André Lureau
Hi On Fri, Apr 26, 2019 at 10:03 AM Gerd Hoffmann wrote: > > Hi, > > > +#ifdef CONFIG_LIBDRM_INTEL > > +static bool > > +intel_alloc_bo(struct drm_buffer *buf) > > +{ > > +uint32_t tiling = I915_TILING_NONE; > > + > > +buf->intel_bo = drm_intel_bo_alloc_tiled(buf->dev->bufmgr, > > "vho

Re: [Qemu-devel] [PATCH for-4.1] block: Assert that drv->bdrv_child_perm is set in bdrv_child_perm()

2019-04-26 Thread Alberto Garcia
ping On Thu 04 Apr 2019 01:29:53 PM CEST, Alberto Garcia wrote: > There is no need to check for this because all block drivers that have > children implement bdrv_child_perm and all callers already ensure that > bs->drv is set. > > Furthermore, if this check would fail then the callers would end u

Re: [Qemu-devel] [PATCH for-4.1] commit: Use bdrv_append() in commit_start()

2019-04-26 Thread Alberto Garcia
ping On Wed 03 Apr 2019 04:37:48 PM CEST, Alberto Garcia wrote: > This function combines bdrv_set_backing_hd() and bdrv_replace_node() > so we can use it to simplify the code a bit in commit_start(). > > Signed-off-by: Alberto Garcia > --- > block/commit.c | 11 +-- > 1 file changed, 1 i

Re: [Qemu-devel] [PATCH for-4.1 v2 0/2] commit: Make base read-only if there is an early failure

2019-04-26 Thread Alberto Garcia
ping On Thu 11 Apr 2019 02:32:26 PM CEST, Alberto Garcia wrote: > Hi, > > this is the same patch I posted yesterday, but with a test case. > > Berto > > Alberto Garcia (2): > commit: Make base read-only if there is an early failure > iotests: Check that images are in read-only mode after block

Re: [Qemu-devel] [PATCH for-4.1] block: Use bdrv_unref_child() for all children in bdrv_close()

2019-04-26 Thread Alberto Garcia
ping On Sun 31 Mar 2019 01:17:47 PM CEST, Alberto Garcia wrote: > bdrv_unref_child() does the following things: > > - Updates the child->bs->inherits_from pointer. > - Calls bdrv_detach_child() to remove the BdrvChild from bs->children. > - Calls bdrv_unref() to unref the child BlockDriverSt

Re: [Qemu-devel] [RFC PATCH v1 01/10] KVM: SVM: Add KVM_SEV SEND_START command

2019-04-26 Thread Borislav Petkov
On Wed, Apr 24, 2019 at 04:09:59PM +, Singh, Brijesh wrote: > The command is used to create an outgoing SEV guest encryption context. > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: Paolo Bonzini > Cc: "Radim Krčmář" > Cc: Joerg Roedel > Cc: Borislav Petkov > Cc:

Re: [Qemu-devel] [RFC PATCH v1 01/10] KVM: SVM: Add KVM_SEV SEND_START command

2019-04-26 Thread Singh, Brijesh
On 4/26/19 9:10 AM, Borislav Petkov wrote: > On Wed, Apr 24, 2019 at 04:09:59PM +, Singh, Brijesh wrote: >> The command is used to create an outgoing SEV guest encryption context. >> >> Cc: Thomas Gleixner >> Cc: Ingo Molnar >> Cc: "H. Peter Anvin" >> Cc: Paolo Bonzini >> Cc: "Radim Krčmá

Re: [Qemu-devel] Using --enable-kvm fails with WindowsXP guest on an AMD host (works on Intel host)

2019-04-26 Thread balducci
(apologies if this doesn't get properly threaded into: http://lists.nongnu.org/archive/html/qemu-devel/2019-04/msg03407.html) > After upgrading host (Gentoo Linux) a Windows XP guest can't boot anymore. > > Some findings while testing: > > * XP image boots & works OK on an Intel machine (Gentoo Li

[Qemu-devel] [Bug 1826568] [NEW] RISC-V Disassembler/translator instruction decoding disagreement

2019-04-26 Thread Floyd42
Public bug reported: When running QEMU V3.1.0 for platform RISC-V, 64bit, Spike V1.10 with "-d in_asm -singlestep -D qemu_log.txt", my (faulty) test code brought up this message in the logs: 0x8002cade: 05139517e2bf illegal Disassembler disagrees with translator ove

Re: [Qemu-devel] [PULL 00/11] Machine queue, 2019-04-25

2019-04-26 Thread Peter Maydell
On Thu, 25 Apr 2019 at 18:57, Eduardo Habkost wrote: > > The following changes since commit 3284aa128153750f14a61e8a96fd085e6f2999b6: > > Merge remote-tracking branch 'remotes/lersek/tags/edk2-pull-2019-04-22' > into staging (2019-04-24 13:19:41 +0100) > > are available in the Git repository at

Re: [Qemu-devel] [PATCH 1/3] ram-encrypted-notifier: Introduce a RAM block encrypted notifier

2019-04-26 Thread Janakarajan Natarajan
On 4/26/19 7:29 AM, Igor Mammedov wrote: > On Thu, 25 Apr 2019 22:58:18 + > "Natarajan, Janakarajan" wrote: > >> A client can register to this notifier to know whether the newly added or >> removed memory region is marked as encrypted. This information is needed >> for the SEV guest launch. In

[Qemu-devel] [PATCH v4 00/10] block/pflash_cfi02: Implement missing AMD pflash functionality

2019-04-26 Thread Stephen Checkoway
The goal of this patch series implement the following AMD command-set parallel flash functionality: - flash interleaving; - nonuniform sector sizes; - erase suspend/resume commands; and - multi-sector erase. During refactoring and implementation, I discovered several bugs that are fixed here as we

[Qemu-devel] [PATCH v4 01/10] block/pflash_cfi02: Add test for supported commands

2019-04-26 Thread Stephen Checkoway
Test the AMD command set for parallel flash chips. This test uses an ARM musicpal board with a pflash drive to test the following list of currently-supported commands. - Autoselect - CFI - Sector erase - Chip erase - Program - Unlock bypass - Reset Signed-off-by: Stephen Checkoway --- tests/Make

[Qemu-devel] [PATCH v4 07/10] block/pflash_cfi02: Fix reset command not ignored during erase

2019-04-26 Thread Stephen Checkoway
When the flash device is performing a chip erase, all commands are ignored. When it is performing a sector erase, only the erase suspend command is valid, which is currently not supported. In particular, the reset command should not cause the device to reset to read array mode while programming is

[Qemu-devel] [PATCH v4 03/10] block/pflash_cfi02: Fix command address comparison

2019-04-26 Thread Stephen Checkoway
Most AMD commands only examine 11 bits of the address. This masks the addresses used in the comparison to 11 bits. The exceptions are word or sector addresses which use offset directly rather than the shifted offset, boff. Signed-off-by: Stephen Checkoway Acked-by: Thomas Huth --- hw/block/pfla

[Qemu-devel] [PATCH v4 02/10] block/pflash_cfi02: Refactor, NFC intended

2019-04-26 Thread Stephen Checkoway
Simplify and refactor for upcoming commits. In particular, pull out all of the code to modify the status into simple helper functions. Status handling becomes more complex once multiple chips are interleaved to produce a single device. No change in functionality is intended with this commit. Sign

[Qemu-devel] [PATCH v4 06/10] block/pflash_cfi02: Fix CFI in autoselect mode

2019-04-26 Thread Stephen Checkoway
After a flash device enters CFI mode from autoselect mode, the reset command returns the device to autoselect mode. An additional reset command is necessary to return to read array mode. Signed-off-by: Stephen Checkoway Acked-by: Thomas Huth --- hw/block/pflash_cfi02.c | 21 +-

[Qemu-devel] [PATCH v4 05/10] block/pflash_cfi02: Implement nonuniform sector sizes

2019-04-26 Thread Stephen Checkoway
Some flash chips support sectors of different sizes. For example, the AMD AM29LV160DT has 31 64 kB sectors, one 32 kB sector, two 8 kB sectors, and a 16 kB sector, in that order. The AM29LV160DB has those in the reverse order. The `num-blocks` and `sector-length` properties work exactly as they di

[Qemu-devel] [PATCH v4 04/10] block/pflash_cfi02: Implement intereleaved flash devices

2019-04-26 Thread Stephen Checkoway
It's common for multiple narrow flash chips to be hooked up in parallel to support wider buses. For example, four 8-bit wide flash chips (x8) may be combined in parallel to produce a 32-bit wide device. Similarly, two 16-bit wide chips (x16) may be combined. This commit introduces `device-width` a

  1   2   >