Re: [Qemu-devel] Issues around TYPE_INTERFACE

2019-03-18 Thread Daniel P . Berrangé
On Mon, Mar 18, 2019 at 01:21:01PM +, Peter Maydell wrote: > On Mon, 18 Mar 2019 at 13:17, Daniel P. Berrangé wrote: > > On Mon, Mar 18, 2019 at 01:53:38PM +0100, Markus Armbruster wrote: > > > In case teaching it to checkpatch turns out to be too onerous: perhaps > > > certain things would be

[Qemu-devel] [PULL 3/3] virtio-gpu: clear command and fence queues on reset

2019-03-18 Thread Gerd Hoffmann
It was never correct to not clear them. Due to commit "3912e66a3feb virtio-vga: fix reset." this became more obvious though. The virtio rings get properly reset now, and trying to process the stale commands will trigger an assert in the virtio core. Signed-off-by: Gerd Hoffmann Reviewed-by: Mar

[Qemu-devel] [PATCH] configure: Remove --source-path option

2019-03-18 Thread Peter Maydell
Normally configure identifies the source path by looking at the location where the configure script itself exists. We also provide a --source-path option which lets the user manually override this. There isn't really an obvious use case for the --source-path option, and in commit 927128222b0a91f56

Re: [Qemu-devel] [PATCH] configure: Remove --source-path option

2019-03-18 Thread Daniel P . Berrangé
On Mon, Mar 18, 2019 at 01:40:19PM +, Peter Maydell wrote: > Normally configure identifies the source path by looking > at the location where the configure script itself exists. > We also provide a --source-path option which lets the user > manually override this. > > There isn't really an obv

Re: [Qemu-devel] [PATCH v3] hw/acpi: extract acpi_add_rom_blob()

2019-03-18 Thread Wei Yang
On Mon, Mar 18, 2019 at 01:39:12PM +0100, Igor Mammedov wrote: >On Fri, 15 Mar 2019 08:44:32 +0800 >Wei Yang wrote: > >in subject: s/extract/generalize/ > >> arm and i386 has almost the same function acpi_add_rom_blob(), except >> giving different FWCfgCallback function. >> >> This patch extract

Re: [Qemu-devel] [Qemu-block] [PATCH v3 02/12] blockdev: Check @replaces in blockdev_mirror_common

2019-03-18 Thread Alberto Garcia
On Wed 13 Feb 2019 11:53:01 PM CET, Max Reitz wrote: > There is no reason why the constraints we put on @replaces should be > limited to drive-mirror. Therefore, move the sanity checks from > qmp_drive_mirror() to blockdev_mirror_common() so they apply to > blockdev-mirror as well. > > Signed-off-

Re: [Qemu-devel] [Bug 1820247] Re: QEMU random crash caused by libspice-server

2019-03-18 Thread Premysl Kouril
Hi Christian, thanks for reply, chmmm, what makes you think there are similarities? To me it looks like a different problem. Regards, Premysl On Mon, Mar 18, 2019 at 8:15 AM Christian Ehrhardt  < 1820...@bugs.launchpad.net> wrote: > Hi Premysl, > this has similarities to [1] which was fixed l

Re: [Qemu-devel] [PATCH v5 00/20] Acceptance Tests: target architecture support

2019-03-18 Thread Eduardo Habkost
On Tue, Mar 12, 2019 at 01:18:04PM -0400, Cleber Rosa wrote: [...] Thanks, I'm queueing the whole series, except for two patches: > Cleber Rosa (19): > Acceptance tests: show avocado test execution by default > Acceptance tests: improve docstring on pick_default_qemu_bin() > Acceptance test

Re: [Qemu-devel] [PATCH v5 00/20] Acceptance Tests: target architecture support

2019-03-18 Thread Eduardo Habkost
On Mon, Mar 18, 2019 at 09:30:13AM +0100, Markus Armbruster wrote: > I understand these tests could serve as "meaningful boot tests" in the > sense I used in "Maintainers, please tell us how to boot your > machines!"[*] Which machine types do they cover? These: * pc (x86_64) * malta (mips) * mal

[Qemu-devel] [Bug 1820247] Re: QEMU random crash caused by libspice-server

2019-03-18 Thread Christian Ehrhardt 
Hi, the warnings around "duplicate channel type 2 id 0" where present in the other bug as well. And since that often means it passes the same area of code I wanted to suggest to provide the same debug data. The actual crash is a different one for sure as the stack traces look different and also

Re: [Qemu-devel] [PATCH 2/2] block-stream: include base into job node list

2019-03-18 Thread Alberto Garcia
On Tue 26 Feb 2019 05:39:41 PM CET, Andrey Shinkevich wrote: > On 26/02/2019 16:33, Alberto Garcia wrote: >> On Mon 25 Feb 2019 05:39:14 PM CET, Vladimir Sementsov-Ogievskiy wrote: --- a/block/stream.c +++ b/block/stream.c @@ -259,6 +259,15 @@ void stream_start(const char *job_id, >

Re: [Qemu-devel] [PATCH] ati-vga: i2c fix

2019-03-18 Thread Gerd Hoffmann
> Does it work with the latest patch for you? I could not make Linux driver > recognise the card yet so if you have some settings that's needed for this > you could share those. It may also need changes to vgabios but I'm not > familiar with that so I hope you can help with that. I've found the r12

Re: [Qemu-devel] [PULL 0/3] Seabios 1.12.1 20190318 patches

2019-03-18 Thread Peter Maydell
ilable in the Git repository at: > > git://git.kraxel.org/qemu tags/seabios-1.12.1-20190318-pull-request > > for you to fetch changes up to 92b80ab1d628c47a517cd9c8664710508e4c20ad: > > seabios: update binaries to 1.12.1 (2019-03-18 14:07:06 +0100) > > ---

Re: [Qemu-devel] [PULL 2/4] usb-mtp: fix some usb_mtp_write_data return paths

2019-03-18 Thread Bandan Das
Peter Maydell writes: ... >> +} else { >> +usb_mtp_queue_result(s, RES_STORE_FULL, d->trans, >> + 0, 0, 0, 0); >> +} > > Presumably one of these should be RES_OK of some kind ? > Ah, yes, that's a typo. >

Re: [Qemu-devel] [PATCH 2/2] filemon: ensure watch IDs are unique to QFileMonitor scope

2019-03-18 Thread Bandan Das
Daniel P. Berrangé writes: > On Fri, Mar 15, 2019 at 01:24:42PM -0400, Bandan Das wrote: >> Daniel P. Berrangé writes: >> ... >> >> Thanks, this fixes it! I had a related question about the way >> >> qemu_file_monitor_add_watch works. >> >> >> >> Am I correct in understanding that if there is a

Re: [Qemu-devel] [PATCH 1/2] iotests: 030 TestParallelOps non-shared base node

2019-03-18 Thread Alberto Garcia
On Thu 21 Feb 2019 04:26:38 PM CET, Andrey Shinkevich wrote: > The test case TestParallelOps::test_stream_parallel in #030 fails > if a base node is protected by the block-stream running job that > includes the base node into the job node list (block_job_add_bdrv) > without BLK_PERM_GRAPH_MOD share

Re: [Qemu-devel] [PATCH v2 09/11] hw/acpi: Add ACPI Generic Event Device Support

2019-03-18 Thread Shameerali Kolothum Thodi
Hi Igor, > -Original Message- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: 18 March 2019 12:26 > To: Shameerali Kolothum Thodi > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; > eric.au...@redhat.com; peter.mayd...@linaro.org; > shannon.zha...@gmail.com; sa...@linux.intel.c

Re: [Qemu-devel] [PATCH 1/2] iotests: 030 TestParallelOps non-shared base node

2019-03-18 Thread Vladimir Sementsov-Ogievskiy
18.03.2019 18:05, Alberto Garcia wrote: > On Thu 21 Feb 2019 04:26:38 PM CET, Andrey Shinkevich wrote: >> The test case TestParallelOps::test_stream_parallel in #030 fails >> if a base node is protected by the block-stream running job that >> includes the base node into the job node list (block_job

Re: [Qemu-devel] [PULL 0/3] Vga 20190318 patches

2019-03-18 Thread Peter Maydell
ilable in the Git repository at: > > git://git.kraxel.org/qemu tags/vga-20190318-pull-request > > for you to fetch changes up to dc84ed5b57cc6d06955e2f49ade9dca277e92cd4: > > virtio-gpu: clear command and fence queues on reset (2019-03-18 13:10:57 > +0100) > >

Re: [Qemu-devel] Combining synchronous and asynchronous IO

2019-03-18 Thread Kevin Wolf
Am 18.03.2019 um 13:44 hat Sergio Lopez geschrieben: > Kevin Wolf writes: > > Am 15.03.2019 um 16:33 hat Sergio Lopez geschrieben: > >> Stefan Hajnoczi writes: > >> > On Thu, Mar 14, 2019 at 06:31:34PM +0100, Sergio Lopez wrote: > >> >> Our current AIO path does a great job at unloading the work fr

[Qemu-devel] [PATCH v2] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored

2019-03-18 Thread Roger Pau Monne
Or if it's not possible to honor the hinted address an error is returned instead. This makes it easier to spot the actual failure, instead of failing later on when the caller of xen_remap_bucket realizes the mapping has not been created at the requested address. Also note that at least on FreeBSD

[Qemu-devel] [PATCH] block: Make bdrv_{copy_on_read, crypto_luks, replication} static

2019-03-18 Thread Alberto Garcia
Signed-off-by: Alberto Garcia --- block/copy-on-read.c | 2 +- block/crypto.c | 2 +- block/replication.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/block/copy-on-read.c b/block/copy-on-read.c index 64dcc424b5..d670fec42b 100644 --- a/block/copy-on-read.c +++ b/

Re: [Qemu-devel] [PATCH v7] pflash: Require backend size to match device, improve errors

2019-03-18 Thread Markus Armbruster
Kevin Wolf writes: > Am 08.03.2019 um 18:03 hat Markus Armbruster geschrieben: >> >> bool blk_check_size_and_read_all(BlockBackend *blk, void *buf, hwaddr >> >> size, >> >> Error **errp) >> >> { >> >> int64_t blk_len; >> >> int ret; >> >> >> >> blk_l

Re: [Qemu-devel] [PATCH v2] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored

2019-03-18 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne [mailto:roger@citrix.com] > Sent: 18 March 2019 15:46 > To: qemu-devel@nongnu.org > Cc: Roger Pau Monne ; Stefano Stabellini > ; Anthony > Perard ; Paul Durrant ; > Igor Druzhinin > ; Paolo Bonzini ; Richard > Henderson ; > Eduardo Habkost

Re: [Qemu-devel] [PATCH for-4.0?] arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-18 Thread Alex Bennée
Peter Maydell writes: > At the moment the Arm implementations of kvm_arch_{get,put}_registers() > don't support having QEMU change the values of system registers > (aka coprocessor registers for AArch32). This is because although > kvm_arch_get_registers() calls write_list_to_cpustate() to > up

Re: [Qemu-devel] [PATCH v2] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored

2019-03-18 Thread Igor Druzhinin
On 18/03/2019 15:45, Roger Pau Monne wrote: > Or if it's not possible to honor the hinted address an error is returned > instead. This makes it easier to spot the actual failure, instead of > failing later on when the caller of xen_remap_bucket realizes the > mapping has not been created at the req

Re: [Qemu-devel] [PATCH v2] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored

2019-03-18 Thread Roger Pau Monné
On Mon, Mar 18, 2019 at 03:48:59PM +, Igor Druzhinin wrote: > On 18/03/2019 15:45, Roger Pau Monne wrote: > > Or if it's not possible to honor the hinted address an error is returned > > instead. This makes it easier to spot the actual failure, instead of > > failing later on when the caller of

Re: [Qemu-devel] [PATCH] scripts/make-release: Stop shipping u-boot source as a tarball

2019-03-18 Thread Peter Maydell
On Sat, 16 Mar 2019 at 03:25, Michael Roth wrote: > > Quoting Peter Maydell (2019-03-14 10:56:28) > > In commit d0dead3b6df7f6cd970e we changed to shipping the u-boot > > sources as a tarball, to work around a problem where they > > contained a file and directory that had the same name except > >

[Qemu-devel] [PULL for-4.0 0/7] qemu-ga patch queue for 4.0

2019-03-18 Thread Michael Roth
The following changes since commit 3c18a08cf387d44a351b9877497b5e0ea27c5140: Merge remote-tracking branch 'remotes/kraxel/tags/seabios-1.12.1-20190318-pull-request' into staging (2019-03-18 13:14:24 +) are available in the Git repository at: git://github.com/mdroth/qemu.gi

[Qemu-devel] [PULL for-4.0 7/7] qmp: common 'id' handling & make QGA conform to QMP spec

2019-03-18 Thread Michael Roth
From: Marc-André Lureau Let qmp_dispatch() copy the 'id' field. That way any qmp client will conform to the specification, including QGA. Furthermore, it simplifies the work for qemu monitor. CC: Michael Roth Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Signed-off-by: Micha

[Qemu-devel] [PULL for-4.0 2/7] qga-win: Adding support for Windows Server 2019 get-osinfo command

2019-03-18 Thread Michael Roth
From: Bishara AbuHattoum Since Windows Server 2016, Microsoft stopped upgrading the major and minor versions of their new Windows Server product, so, the current functionality of checking major and minor version numbers to determine the Windows Server version wont work as expected. The implemente

[Qemu-devel] [PULL for-4.0 3/7] qga-win: include glib when building VSS DLL

2019-03-18 Thread Michael Roth
Commit 3ebee3b191e defined assert() as g_assert(), but when we build the VSS DLL component of QGA (to handle fsfreeze) we do not include glib, which results in breakage when building with VSS support enabled. Fix this by including glib (along with the -lintl and -lws2_32 dependencies it brings).

[Qemu-devel] [PULL for-4.0 4/7] qga-win: fix VSS build breakage due to unintended gnu99 C++ flag

2019-03-18 Thread Michael Roth
Commit 7be41675f7c set -std=gnu99 for C code via QEMU_CFLAGS. Currently we generate a "custom" QEMU_CXXFLAGS for VSS DLL C++ build by filtering out some options from QEMU_CFLAGS and adding some others. Since we don't filter out -std=gnu99 currently this breaks builds when VSS support is enabled. W

[Qemu-devel] [PULL for-4.0 1/7] qga: update docs with systemd suspend support info

2019-03-18 Thread Michael Roth
From: Daniel Henrique Barboza Commit 067927d62e ("qga: systemd hibernate/suspend/hybrid-sleep support") failed to update qapi-schema.json after adding systemd hibernate/suspend/hybrid-sleep capabilities to guest-suspend-* QGA commands. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Eric Bl

[Qemu-devel] [PULL for-4.0 5/7] qga: Fix guest-get-fsinfo PCI address collection in Windows

2019-03-18 Thread Michael Roth
From: Matt Hines The Windows QEMU guest agent erroneously tries to collect PCI information directly from the physical drive. However, windows stores SCSI/IDE information with the drive and PCI information with the underlying storage controller This changes get_pci_info to use the physical drive's

[Qemu-devel] [PULL for-4.0 6/7] qga: process_event() simplification

2019-03-18 Thread Michael Roth
From: Marc-André Lureau Simplify the code around qmp_dispatch(): - rely on qmp_dispatch/check_obj() for message checking - have a single send_response() point - constify send_response() argument It changes a couple of error messages: * When @req isn't a dictionary, from Invalid JSON syntax

Re: [Qemu-devel] [PATCH v7] pflash: Require backend size to match device, improve errors

2019-03-18 Thread Kevin Wolf
Am 18.03.2019 um 17:03 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 08.03.2019 um 18:03 hat Markus Armbruster geschrieben: > >> >> bool blk_check_size_and_read_all(BlockBackend *blk, void *buf, hwaddr > >> >> size, > >> >> Error **errp) > >> >

Re: [Qemu-devel] [PULL for-4.0 0/7] qemu-ga patch queue for 4.0

2019-03-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190318162410.10183-1-mdr...@linux.vnet.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190318162410.10183-1-mdr...@linux.vnet.ibm.com Type: series Subject: [Qemu-devel] [PULL for-4.

Re: [Qemu-devel] [PATCH v2] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored

2019-03-18 Thread Anthony PERARD
On Mon, Mar 18, 2019 at 03:48:59PM +, Igor Druzhinin wrote: > On 18/03/2019 15:45, Roger Pau Monne wrote: > > diff --git a/hw/i386/xen/xen-mapcache.c b/hw/i386/xen/xen-mapcache.c > > index 349f72d00c..23de5517db 100644 > > --- a/hw/i386/xen/xen-mapcache.c > > +++ b/hw/i386/xen/xen-mapcache.c >

Re: [Qemu-devel] [PATCH v2] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored

2019-03-18 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 18 March 2019 16:35 > To: Igor Druzhinin > Cc: Roger Pau Monne ; qemu-devel@nongnu.org; Stefano > Stabellini > ; Paul Durrant ; Paolo > Bonzini ; > Richard Henderson ; Eduardo Habkost ; > Michael S. T

Re: [Qemu-devel] [libvirt] [PATCH 1/2] numa: deprecate 'mem' parameter of '-numa node' option

2019-03-18 Thread Igor Mammedov
On Mon, 4 Mar 2019 14:52:30 +0100 Igor Mammedov wrote: > On Fri, 1 Mar 2019 18:01:52 + > "Dr. David Alan Gilbert" wrote: > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > On Fri, 1 Mar 2019 15:49:47 + > > > Daniel P. Berrangé wrote: > > > > > > > On Fri, Mar 01, 2019 at 0

[Qemu-devel] [PATCH] qemu-iotests: Fix 232 for non-qcow2

2019-03-18 Thread Kevin Wolf
232 is marked as generic, but commit 12efe428c9e added code that assumes qcow2. What the new test really needs is backing files and support for updating the backing file link (.bdrv_change_backing_file). Split the non-generic code into a new test case 247 and make it work with qed, too. Signed-of

Re: [Qemu-devel] [PATCH] vl: Fix to create migration object before block backends again

2019-03-18 Thread Kevin Wolf
Am 13.03.2019 um 09:43 hat Markus Armbruster geschrieben: > Recent commit cda4aa9a5a0 moved block backend creation before machine > property evaluation. This broke qemu-iotests 055. Turns out we need > to create the migration object before block backends, so block > backends can add migration blo

Re: [Qemu-devel] [PATCH v2 09/11] hw/acpi: Add ACPI Generic Event Device Support

2019-03-18 Thread Igor Mammedov
On Mon, 18 Mar 2019 15:04:28 + Shameerali Kolothum Thodi wrote: > Hi Igor, > > > -Original Message- > > From: Igor Mammedov [mailto:imamm...@redhat.com] > > Sent: 18 March 2019 12:26 > > To: Shameerali Kolothum Thodi > > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; > > eric.au...

Re: [Qemu-devel] [PATCH for-4.0] include/qemu/bswap.h: Use __builtin_memcpy() in accessor functions

2019-03-18 Thread Paolo Bonzini
On 18/03/19 12:29, Peter Maydell wrote: > In the accessor functions ld*_he_p() and st*_he_p() we use memcpy() > to perform a load or store to a pointer which might not be aligned > for the size of the type. We rely on the compiler to optimize this > memcpy() into an efficient load or store instruct

Re: [Qemu-devel] [PULL 05/21] migration: Introduce ignore-shared capability

2019-03-18 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" writes: > > > From: Yury Kotov > > > > We want to use local migration to update QEMU for running guests. > > In this case we don't need to migrate shared (file backed) RAM. > > So, add a capability to ignore such blo

Re: [Qemu-devel] [PATCH 1/2] target/mips: Optimize ILVOD. MSA instructions

2019-03-18 Thread Mateja Marjanovic
On 15.3.19. 17:46, Aleksandar Markovic wrote: From: Mateja Marjanovic Subject: [PATCH 1/2] target/mips: Optimize ILVOD. MSA instructions From: Mateja Marjanovic Optimize set of MSA instructions ILVOD, using directly tcg registers and performing logic on them insted of using helpers. insted -

[Qemu-devel] [PATCH 02/13] qgraph: fix qos_node_contains with options

2019-03-18 Thread Paolo Bonzini
Currently, if qos_node_contains was passed options, it would still create an edge without any options. Instead, in that case NULL acts as a terminator. Signed-off-by: Paolo Bonzini --- tests/libqos/qgraph.c | 12 tests/libqos/qgraph.h | 15 +-- 2 files changed, 17 inser

Re: [Qemu-devel] [PATCH v7] pflash: Require backend size to match device, improve errors

2019-03-18 Thread Markus Armbruster
Kevin Wolf writes: > Am 18.03.2019 um 17:03 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 08.03.2019 um 18:03 hat Markus Armbruster geschrieben: >> >> >> bool blk_check_size_and_read_all(BlockBackend *blk, void *buf, hwaddr >> >> >> size, >> >> >>

[Qemu-devel] [PATCH 10/13] libqos: add ARM imx25-pdk machine object

2019-03-18 Thread Paolo Bonzini
This is used to test imx_i2c. Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 1 + tests/libqos/arm-imx25-pdk-machine.c | 92 2 files changed, 93 insertions(+) create mode 100644 tests/libqos/arm-imx25-pdk-machine.c diff --git a/tests/Makef

[Qemu-devel] [PATCH 11/13] tests: convert OMAP i2c tests to qgraph

2019-03-18 Thread Paolo Bonzini
This way, pca9952-test and tmp105-test will run for every machine that exposes an i2c-bus. Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 9 +++-- tests/libqos/i2c-omap.c | 19 -- tests/libqos/i2c.h | 4 tests/pca9552-test.c| 44 ++-

[Qemu-devel] [PATCH 04/13] libqos: fix omap-i2c receiving more than 4 bytes

2019-03-18 Thread Paolo Bonzini
If more than 4 bytes are received, the FIFO cannot host the entire contents of the transfer and STP will be nonzero before entering the transfer loop. Also, CNT will contain the number of bytes left to be transferred instead of the total number of bytes in the transfer. (Reverse engineered from t

[Qemu-devel] [PATCH 08/13] libqos: convert I2C to qgraph

2019-03-18 Thread Paolo Bonzini
Create an i2c-bus interface, corresponding to the I2CAdapter struct. Wrap IMXI2C and OMAPI2C with a QOSGraphObject, and add the get_driver function to retrieve the I2CAdapter. The conversion is still not complete; for simplicity, i2c_recv and i2c_send (along with their wrappers) still take an adap

[Qemu-devel] [PATCH 06/13] imx25-pdk: create ds1338 for qtest inside the test

2019-03-18 Thread Paolo Bonzini
There is no need to have a test device created by the board. Instead, create it in the qtest so that we will be able to run it on other boards too. Signed-off-by: Paolo Bonzini --- hw/arm/imx25_pdk.c | 9 - tests/ds1338-test.c | 2 +- 2 files changed, 1 insertion(+), 10 deletions(-) di

[Qemu-devel] [PATCH 07/13] libqos: split I2CAdapter initialization and allocation

2019-03-18 Thread Paolo Bonzini
Provide *_init functions that populate an I2CAdapter struct without allocating one, and make the existing *_create functions wrap them. Because in the new setup *_create might return a pointer inside the IMXI2C or OMAPI2C struct, create companion *_free functions to go back to the outer pointer.

[Qemu-devel] [PATCH 12/13] tests: convert ds1338-test to qtest

2019-03-18 Thread Paolo Bonzini
This way, ds1338-test will run for every machine that exposes an i2c-bus. Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 8 tests/ds1338-test.c| 37 + tests/libqos/i2c-imx.c | 19 --- tests/libqos/i2c.h | 2 -- 4 f

[Qemu-devel] [PATCH 01/13] qgraph: allow extra_device_opts on bus nodes

2019-03-18 Thread Paolo Bonzini
Allow choosing the bus that the device will be placed on, in case the machine has more than one. Otherwise, the bus may not match the base address of the controller we attach it to. Signed-off-by: Paolo Bonzini --- tests/qos-test.c | 17 ++--- 1 file changed, 10 insertions(+), 7 del

[Qemu-devel] [PATCH 03/13] libqos: move common i2c code to libqos

2019-03-18 Thread Paolo Bonzini
The functions to read/write 8-bit or 16-bit registers are the same in tmp105 and pca9552 tests, and in fact they are a special case of "read block"/"write block" functionality; read block in turn is used in ds1338-test. Move everything inside libqos-test, removing the duplication. Account for the

[Qemu-devel] [PATCH 13/13] libqos: i2c: move address into QI2CDevice

2019-03-18 Thread Paolo Bonzini
This removes the hardcoded I2C address from the tests. The address is passed via QOSGraphEdgeOptions to i2c_device_create and stored in the QI2CDevice. The i2c_send and i2c_recv functions, along with their wrappers, therefore, can be changed to take a QI2CDevice rather than an adapter/address pai

[Qemu-devel] [PATCH 09/13] libqos: add ARM n800 machine object

2019-03-18 Thread Paolo Bonzini
This is used to test omap_i2c. Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 1 + tests/libqos/arm-n800-machine.c | 92 + 2 files changed, 93 insertions(+) create mode 100644 tests/libqos/arm-n800-machine.c diff --git a/tests/Makefile.inclu

[Qemu-devel] [PATCH v3] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored

2019-03-18 Thread Roger Pau Monne
Or if it's not possible to honor the hinted address an error is returned instead. This makes it easier to spot the actual failure, instead of failing later on when the caller of xen_remap_bucket realizes the mapping has not been created at the requested address. Also note that at least on FreeBSD

Re: [Qemu-devel] [PATCH v3] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored

2019-03-18 Thread Igor Druzhinin
On 18/03/2019 17:37, Roger Pau Monne wrote: > Or if it's not possible to honor the hinted address an error is returned > instead. This makes it easier to spot the actual failure, instead of > failing later on when the caller of xen_remap_bucket realizes the > mapping has not been created at the req

[Qemu-devel] [PATCH 05/13] pca9552-test: do not rely on state across tests

2019-03-18 Thread Paolo Bonzini
receive_autoinc is relying on the LED state that is set by send_and_receive. Stop doing that, because qgraph resets the machine between tests. Signed-off-by: Paolo Bonzini --- tests/pca9552-test.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/tests/pca9552

[Qemu-devel] [PATCH preliminary for 4.1 00/13] Convert I2C tests to qgraph

2019-03-18 Thread Paolo Bonzini
This series is meant to be a reference for converting tests to qgraph. It covers a bit of everything: finding common code across multiple tests, the kind of bug that you could find when running tests across more machine types, creating new machines, and converting tests. I have not yet tested it f

[Qemu-devel] [Bug 1820686] [NEW] risc-v: 'c.unimp' instruction decoded as 'c.addi4spn fp, 0'

2019-03-18 Thread Jonathan Behrens
Public bug reported: QEMU 3.1 incorrectly decodes the "c.unimp" instruction (opcode 0x) as an "addi4spn fp, 0" when either of the two following bytes are non- zero. This is because the ctx->opcode value used when decoding the instruction is actually filled with a 32-bit load (to handle normal

Re: [Qemu-devel] [PATCH 2/2] riscv: sifive_u: Correct UART0's IRQ in the device tree

2019-03-18 Thread Alistair Francis
On Sun, Mar 17, 2019 at 1:24 AM Bin Meng wrote: > > The UART0's interrupt vector is wrongly set to 1 in the device tree. > Use SIFIVE_U_UART0_IRQ instead. > > Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Alistair > --- > > hw/riscv/sifive_u.c | 2 +- > 1 file changed, 1 insertion(+)

Re: [Qemu-devel] [PATCH 1/2] riscv: sifive_uart: Generate TX interrupt

2019-03-18 Thread Alistair Francis
On Sun, Mar 17, 2019 at 1:24 AM Bin Meng wrote: > > At present the sifive uart model only generates RX interrupt. This > updates it to generate TX interrupt so that it is more useful. > > Note the TX fifo is still unimplemented. > > Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Alistai

Re: [Qemu-devel] [PATCH preliminary for 4.1 00/13] Convert I2C tests to qgraph

2019-03-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190318171521.8524-1-pbonz...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash time

[Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU

2019-03-18 Thread Mateja Marjanovic
From: Mateja Marjanovic Wrong type of NaN was generated for IEEE754-2008 by maddf and msubf insturctions when the arguments were inf, zero, nan or zero, inf, nan respectively. Mateja Marjanovic (1): target/mips: Fix minor bug in FPU fpu/softfloat-specialize.h | 24 1

[Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU

2019-03-18 Thread Mateja Marjanovic
From: Mateja Marjanovic Wrong type of NaN was generated for IEEE754-2008 by maddf and msubf insturctions when the arguments were inf, zero, nan or zero, inf, nan respectively. Signed-off-by: Mateja Marjanovic --- fpu/softfloat-specialize.h | 24 1 file changed, 16 inse

[Qemu-devel] [Bug 1819182] Re: info does not recognize file format of vpc with subformat=fixed

2019-03-18 Thread John Snow
Well, 2.11 is way too old, but it still does reproduce on the latest development head. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1819182 Title: info does not recognize file format of vpc with s

Re: [Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU

2019-03-18 Thread Peter Maydell
On Mon, 18 Mar 2019 at 18:26, Mateja Marjanovic wrote: > > From: Mateja Marjanovic > > Wrong type of NaN was generated for IEEE754-2008 by maddf and > msubf insturctions when the arguments were inf, zero, nan or > zero, inf, nan respectively. > > Signed-off-by: Mateja Marjanovic > @@ -519,6 +51

[Qemu-devel] [PATCH] vl: Fix error location of positional arguments

2019-03-18 Thread Markus Armbruster
We blame badness in positional arguments on the last option argument: $ qemu-system-x86_64 -vnc :1 bad.img qemu-system-x86_64: -vnc :1: Could not open 'foo': No such file or directory I believe we've done this ever since we reported locations. Fix it to qemu-system-x86_64: bad.img:

Re: [Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU

2019-03-18 Thread Aleksandar Markovic
> From: Mateja Marjanovic > Subject: [PATCH] target/mips: Fix minor bug in FPU > > From: Mateja Marjanovic > > Wrong type of NaN was generated for IEEE754-2008 by maddf and > msubf insturctions when the arguments were inf, zero, nan or > zero, inf, nan respectively. > "insturctions" -> "instr

[Qemu-devel] [Bug 1819343] Re: Qcow2 image stuck as locked after host crash

2019-03-18 Thread John Snow
I wonder if your QEMU is using OFD locks or not, which might depend on a few things: -Are you using a distributed QEMU or one you've built yourself? -What glibc was it compiled against? -What version of Linux are you running under? I would have thought that after the process that held the lock di

Re: [Qemu-devel] [PATCH v2 0/2] hw: provide error checking of disable-legacy/modern property usage

2019-03-18 Thread Eduardo Habkost
On Tue, Mar 12, 2019 at 09:19:37PM -0400, Michael S. Tsirkin wrote: > On Fri, Feb 15, 2019 at 10:32:37AM +, Daniel P. Berrangé wrote: > > Changed in v2: > > > > - Fix properties set for v2.6 machine type compat so that it > >only affects the virtio devices which support both legacy > >

Re: [Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU

2019-03-18 Thread Aleksandar Markovic
Hi, Mateja, > From: Mateja Marjanovic > Subject: [PATCH] target/mips: Fix minor bug in FPU > > From: Mateja Marjanovic > > Wrong type of NaN was generated for IEEE754-2008 by maddf and > msubf insturctions when the arguments were inf, zero, nan or > zero, inf, nan respectively. > > Signed-off

[Qemu-devel] [PATCH] spapr: Remove NULL checks on error_propagate() calls

2019-03-18 Thread Markus Armbruster
Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/error_propagate_null.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Markus Armbruster --- hw/ppc/spapr_pci.c | 4 +--- 1 file changed, 1 insertion(+), 3

Re: [Qemu-devel] [PATCH 1/5] trace-events: Consistently point to docs/devel/tracing.txt

2019-03-18 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 3/14/19 7:09 PM, Markus Armbruster wrote: >> Almost all trace-events do so in a comment right at the beginning. > > It was not obvious at first that "do so" means "consistently point to > docs/devel/tracing.txt". > >> Touch up the ones that don't. I see. Clar

[Qemu-devel] [Bug 1819343] Re: Qcow2 image stuck as locked after host crash

2019-03-18 Thread Tim Schuster
Hi, I used both the standard qemu package from the archlinux repositories as well as one I compiled myself with a few patches on top to improve audio performance. According to my logs, the compiled version used 2.28-4, I don't know what archlinux compiles them against. 2.28-5 is currently deploye

[Qemu-devel] [Bug 1820686] Re: risc-v: 'c.unimp' instruction decoded as 'c.addi4spn fp, 0'

2019-03-18 Thread Palmer Dabbelt
Thanks. If you spin a full patch (ie, "git commit -s" and then "git show") I can drop it on riscv-qemu-3.1, our backports branch. Otherwise hopefully we got the bug via the decodetree conversion. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscrib

Re: [Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU

2019-03-18 Thread Aleksandar Markovic
> From: Mateja Marjanovic > Subject: [PATCH] target/mips: Fix minor bug in FPU "v2" is missing in the subject line, and now v1 and v2 are incorrectly linked on mailing list website. An isolated patch is perhaps better sent without cover letter - especially since your cover letter doesn't add an

Re: [Qemu-devel] [PATCH] test-announce-self: convert to qgraph

2019-03-18 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > This removes the duplicated initialization code. > > Signed-off-by: Paolo Bonzini Reviewed-by: Dr. David Alan Gilbert > --- > tests/Makefile.include | 3 -- > tests/test-announce-self.c | 82 -- > tests/vi

[Qemu-devel] running out of Arm TB flags...

2019-03-18 Thread Peter Maydell
Hi; for the M-profile floating point work I'm going to need I think three new TB flags (to control whether to generate the code to do the various independent things the pseudocode ExecuteFPCheck() function does before executing any FP insn). Unfortunately we currently have only 2 unused bits in the

Re: [Qemu-devel] [PATCH v3 4/7] hw/mips: Remove the redundant CONFIG_MIPS_ITU Makefile variable

2019-03-18 Thread Aleksandar Markovic
> From: Philippe Mathieu-Daudé > Subject: [PATCH v3 4/7] hw/mips: Remove the redundant CONFIG_MIPS_ITU > Makefile variable > > The Inter-Thread Communication Unit (ITU, introduced in commit > 34fa7e83e11) is part of the Coherent Processing System (CPS), > as describe in commit 408294352ad: > >

Re: [Qemu-devel] PMON2000 compilation and kernel question

2019-03-18 Thread John Snow
On 3/6/19 11:01 AM, Andrew Randrianasulu wrote: >> This could be some missing or buggy emulation. Maybe if you can get some >> debug logs from kernel that could tell what it's doing. Usually at least -d >> unimp,guest_errors options are recommended for debugging but if nothing is >> printed t

[Qemu-devel] [Bug 1819343] Re: Qcow2 image stuck as locked after host crash

2019-03-18 Thread John Snow
Hi, a colleague of mine has pointed out that this is a well-worn problem with nfs*v3*: https://bugzilla.redhat.com/show_bug.cgi?id=1547095#c43 Workarounds seem to involve: - Use v4, or - Use the nolock option. Does this cover your use case? ** Bug watch added: Red Hat Bugzilla #1547095 https

Re: [Qemu-devel] [PATCH] hw/s390x: fix clang compilation on 32bit machines

2019-03-18 Thread Philippe Mathieu-Daudé
Le lun. 18 mars 2019 11:34, Marcel Apfelbaum a écrit : > Hi Christian, > > On 3/18/19 11:27 AM, Christian Borntraeger wrote: > > > > On 16.03.19 12:09, Philippe Mathieu-Daudé wrote: > >> Hi Marcel, > >> > >> On 3/16/19 10:50 AM, Marcel Apfelbaum wrote: > >>> Configuring QEMU with: > >>> conf

Re: [Qemu-devel] [PULL 00/12] EDK2 Firmware roms

2019-03-18 Thread Philippe Mathieu-Daudé
Hi Peter, Le dim. 17 mars 2019 23:02, Peter Maydell a écrit : > On Sun, 17 Mar 2019 at 20:29, Peter Maydell > wrote: > > > > On Sat, 16 Mar 2019 at 22:25, Philippe Mathieu-Daudé > wrote: > > > > > > The following changes since commit > 8b088d3f8ab5642020d28fa0c2a8d938bc5f3592: > > > > > > Me

Re: [Qemu-devel] [PATCH 13/14] hw/hppa/Kconfig: Dino board requires e1000 network card

2019-03-18 Thread Philippe Mathieu-Daudé
Le lun. 18 mars 2019 10:07, Paolo Bonzini a écrit : > On 16/03/19 23:41, Philippe Mathieu-Daudé wrote: > > On 3/16/19 10:50 PM, Paolo Bonzini wrote: > >>> This fixes when configuring with --without-default-devices: > >>> > >>> $ qemu-system-hppa > >>> qemu-system-hppa: Unsupported NIC model:

[Qemu-devel] [Bug 1819343] Re: Qcow2 image stuck as locked after host crash

2019-03-18 Thread Tim Schuster
Yes, it would be v3, I'll use v4 then, thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1819343 Title: Qcow2 image stuck as locked after host crash Status in QEMU: New Bug description: A

Re: [Qemu-devel] [Xen-devel] [PATCH v3] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored

2019-03-18 Thread Marek Marczykowski-Górecki
On Mon, Mar 18, 2019 at 06:37:31PM +0100, Roger Pau Monne wrote: > Or if it's not possible to honor the hinted address an error is returned > instead. Just to be sure: MAP_FIXED will cause to map at specified address, even if something is mapped there already. From mmap(2): If the memory reg

Re: [Qemu-devel] PMON2000 compilation and kernel question

2019-03-18 Thread BALATON Zoltan
Hello, On Mon, 18 Mar 2019, John Snow wrote: On 3/6/19 11:01 AM, Andrew Randrianasulu wrote: This could be some missing or buggy emulation. Maybe if you can get some debug logs from kernel that could tell what it's doing. Usually at least -d unimp,guest_errors options are recommended for debu

Re: [Qemu-devel] State of QEMU CI as we enter 4.0

2019-03-18 Thread Wainer dos Santos Moschetta
Hi all, On 03/14/2019 12:57 PM, Alex Bennée wrote: Hi, As we approach stabilisation for 4.0 I thought it would be worth doing a review of the current state of CI and stimulate some discussion of where it is working for us and what could be improved. Testing in Build System ===

Re: [Qemu-devel] State of QEMU CI as we enter 4.0

2019-03-18 Thread Cleber Rosa
On Thu, Mar 14, 2019 at 03:57:06PM +, Alex Bennée wrote: > > Hi, > > As we approach stabilisation for 4.0 I thought it would be worth doing a > review of the current state of CI and stimulate some discussion of where > it is working for us and what could be improved. > > Testing in Build Sys

Re: [Qemu-devel] [Qemu-block] [PATCH v2] qcow2: discard bitmap when removed

2019-03-18 Thread John Snow
On 2/28/19 4:26 AM, Andrey Shinkevich wrote: > When a bitmap is removed, we can clean some space on the disk. The size > of a cluster may be larger, so is the size of the bitmap that includes > many clusters. Some bitmaps can be as large as tens of megabytes. > The flag QCOW2_DISCARD_ALWAYS allo

[Qemu-devel] [PATCH] ati-vga: Fix indexed access to video memory

2019-03-18 Thread BALATON Zoltan
Coverity (CID 1399700) found that this was wrong so instead of trying to do it by hand use existing access functions that should work better. Signed-off-by: BALATON Zoltan --- hw/display/ati.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/hw/display/ati.

Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] iotests: avoid broken pipe with certtool

2019-03-18 Thread John Snow
On 2/19/19 11:37 AM, Eric Blake wrote: > On 2/19/19 10:21 AM, Daniel P. Berrangé wrote: > +tls_certtool() +{ +certtool "$@" 1>certtool.log 2>&1 +if test "$?" = 0; then + head -1 certtool.log +else + cat certtool.log +fi +

[Qemu-devel] [Bug 1814418] Re: persistent bitmap will be inconsistent when qemu crash,

2019-03-18 Thread John Snow
This has been checked in upstream and is pending release for 4.0; QEMU will now load inconsistent bitmaps and expose them with a status of "Inconsistent" and an extra boolean inconsistent = true. You can remove them with block-dirty-bitmap-remove. ** Changed in: qemu Status: New => Fix Co

Re: [Qemu-devel] [Qemu-block] [PATCH] scsi-disk: Fix crash if request is invaild or disk is no medium

2019-03-18 Thread John Snow
On 3/7/19 3:57 AM, Zhengui li wrote: > From: Zhengui Li > > Qemu will crash with the assertion error that "assert(r->req.aiocb != > NULL)" in scsi_read_complete if request is invaild or disk is no medium. > The error is below: > qemu-kvm: hw/scsi/scsi_disk.c:299: scsi_read_complete: Assertion

<    1   2   3   >