> -----Original Message----- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 18 March 2019 16:35 > To: Igor Druzhinin <igor.druzhi...@citrix.com> > Cc: Roger Pau Monne <roger....@citrix.com>; qemu-devel@nongnu.org; Stefano > Stabellini > <sstabell...@kernel.org>; Paul Durrant <paul.durr...@citrix.com>; Paolo > Bonzini <pbonz...@redhat.com>; > Richard Henderson <r...@twiddle.net>; Eduardo Habkost <ehabk...@redhat.com>; > Michael S. Tsirkin > <m...@redhat.com>; Marcel Apfelbaum <marcel.apfelb...@gmail.com>; > xen-de...@lists.xenproject.org > Subject: Re: [PATCH v2] xen-mapcache: use MAP_FIXED flag so the mmap address > hint is always honored > > On Mon, Mar 18, 2019 at 03:48:59PM +0000, Igor Druzhinin wrote: > > On 18/03/2019 15:45, Roger Pau Monne wrote: > > > diff --git a/hw/i386/xen/xen-mapcache.c b/hw/i386/xen/xen-mapcache.c > > > index 349f72d00c..23de5517db 100644 > > > --- a/hw/i386/xen/xen-mapcache.c > > > +++ b/hw/i386/xen/xen-mapcache.c > > > @@ -185,8 +185,13 @@ static void xen_remap_bucket(MapCacheEntry *entry, > > > } > > > > > > if (!dummy) { > > > + /* > > > + * If the caller has requested the mapping at a specific address > > > use > > > + * MAP_FIXED to make sure it's honored. > > > + */ > > > > Since the comment now applied to both invocation - could it be moved > > outside the if statement then? > > That sounds good to me.
I have no problem and my R-b still stands. Paul > > -- > Anthony PERARD
